Re: [PATCH] net: support VLAN stacking packet type parsing

Hi Morten, all, пн, 7 июл. 2025 г. в 19:09, Morten Brørup : > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Friday, 4 July 2025 13.32 > > > Hi all, > > > > this email discussion comes at a bit of a fortunate time for me, as I'm > > currently looking at our vlan tag/qinq

Re: [EXTERNAL] Re: [PATCH v1 04/12] node: add process callback for IP4 FIB

Hi Ankur, пт, 18 апр. 2025 г. в 15:45, Ankur Dwivedi : > > Hi Vladimir, > >> diff --git a/lib/node/ip4_lookup_fib.c b/lib/node/ip4_lookup_fib.c > >> index e87864e672..c535b191f8 100644 > >> --- a/lib/node/ip4_lookup_fib.c > >> +++ b/lib/node/ip4_lookup_fib.c > >> @@ -40,6 +40,169 @@ static struct

[PATCH v2] net/ice: fix flow engines order

scales poorly with each distinct wildcard mask configuration. Fixes: fabc9e1322e2 ("net/ice: fix flows handling") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/intel/ice/ice_generic_flow.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) di

[PATCH] net/ice: fix flow engines order

scales poorly with each distinct wildcard mask configuration. Fixes: fabc9e1322e2 ("net/ice: fix flows handling") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/intel/ice/ice_generic_flow.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) di

[PATCH] net/ice: fix segmentation fault Rx function

Fix a typo in avx512 rx function, where accidentally the _mm_load_si128 argument was passed by value instead of a pointer. Fixes: 43fd3624fdfe ("drivers: replace GCC pragma with cast") Cc: andre...@linux.microsoft.com Signed-off-by: Vladimir Medvedkin --- drivers/net

[PATCH v2] net/ice: fix how ice driver handles flows

order they work in the HW pipeline. Fixes: 9c5f0070fa3f ("net/ice: map group to pipeline stage") Cc: qi.z.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/intel/ice/ice_generic_flow.c | 30 ++-- 1 file changed, 17 inserti

[PATCH] net/ice: fix how ice driver handles flows

order they work in the HW pipeline. Fixes: 9c5f0070fa3f ("net/ice: map group to pipeline stage") Cc: qi.z.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_generic_flow.c | 27 ++- 1 file changed, 14 insertions(+), 13

[PATCH] net/ice: fix memory leak in scalar Rx

t;net/ice: support buffer split in scalar Rx") Cc: yuanx.w...@intel.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_rxtx.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index

[PATCH] net/ixgbe: fix missing E610 support in flow engine

Currently flow engine is missing a new mac type E610 in the check for fdir support. This patch adds this mac type to the check. Fixes: 316637762a5f ("net/ixgbe/base: enable E610 device") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/ixgbe/ixgbe_fdir.c | 3 ++

[PATCH] fib: rename configuration flag

Rename RTE_FIB_F_NETWORK_ORDER with RTE_FIB_F_LOOKUP_NETWORK_ORDER to explicitly indicate that it is only used in lookup. Fixes: e194f3cd5685 ("fib: lookup IPv4 address in network order") Signed-off-by: Vladimir Medvedkin --- lib/fib/rte_fib.c | 4 ++-- lib/fib/rte_fib.h | 4 ++-

Re: rte_fib network order bug

Hi all, [Robin] > I had not understood that it was *only* the lookups that were network order [Morten] >When I saw the byte order flag the first time, it was not clear to me either that it only affected lookups - I too thought it covered the entire API of the library. This needs to be emphasized i

[PATCH] net/i40e: fix read register return status check

'i40e_get_outer_vlan()' does not check 'i40e_aq_debug_read_register()' return value. This patch fixes this issue. Coverity issue: 445518 Fixes: 86eb05d6350b ("net/i40e: add flow validate function") Cc: beilei.x...@intel.com Cc: sta...@dpdk.org Signed-off-by: Vladim

[PATCH v2] test/fib: clarify FIB RCU negative tests

Add additional negative tests for rte_fib_rcu_qsbr_add(). Also explicitly check returned codes. Additionally add a check into the rte_fib_rcu_qsbr_add() for passed fib argument. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c | 21 +++-- lib/fib/rte_fib.c | 3 +++ 2

[PATCH v4 1/4] thash: add RSS hash key generation API

Toeplitz hash key with respect to hash values distribution. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 13 + lib/hash/rte_thash.h | 24 lib/hash/version.map | 2 ++ 3 files changed, 39 insertions(+) diff --git a/lib/hash/rte_thash.c b/lib/hash

[PATCH v4 4/4] test/thash: add tests for RSS key generation API

key with the new API and run the test again, noting the new distribution. Finally, we also measure said distribution for some well known RSS hash key which is used in some PMDs. Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 108 ++ 1 file

[PATCH v4 3/4] hash: implement RSS hash key generation API

This patch implements Toeplitz hash key generation function using the new polynomial generation function. Signed-off-by: Vladimir Medvedkin --- doc/guides/rel_notes/release_24_11.rst | 3 +++ lib/hash/rte_thash.c | 23 ++- 2 files changed, 21 insertions

[PATCH v4 2/4] hash: add dynamic polynomial calculation

polynomial calculation for polynomials of degree 7 or higher, resulting in better entropy of generated RSS hash key. Signed-off-by: Vladimir Medvedkin --- lib/hash/meson.build | 1 + lib/hash/rte_thash.c | 44 + lib/hash/rte_thash.h | 13 ++ lib/hash

[PATCH v4 0/4] RSS hash key generation

notes - rebase to current version v3 - change rte_thash_gen_key() arguments types v2 - fix some minor issues Vladimir Medvedkin (4): thash: add RSS hash key generation API hash: add dynamic polynomial calculation hash: implement RSS hash key generation API test/thash: add tests for RSS

[PATCH] test/fib: clarify FIB RCU negative tests

Add additional negative tests for rte_fib_rcu_qsbr_add(). Also explicitly check returned codes. Additionally add a check into the rte_fib_rcu_qsbr_add() for passed fib argument. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c | 21 +++-- lib/fib/rte_fib.c | 3 +++ 2

[PATCH] fib: fix return value behavior

Fixes the behavior of the rte_fib_rcu_qsbr_add() function regarding its return value to align with the existing rte_fib API. Fixes: 96c3d06a3547 ("fib: implement RCU rule reclamation") Signed-off-by: Vladimir Medvedkin --- lib/fib/dir24_8.c | 21 - lib/fib/rte_

[PATCH v5] fib: network byte order IPv4 lookup

Previously when running rte_fib_lookup IPv4 addresses must have been in host byte order. This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on fib create, which will allow to have IPv4 in network byte order on lookup. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c

[PATCH v3 4/4] test/thash: add tests for RSS key generation API

key with the new API and run the test again, noting the new distribution. Finally, we also measure said distribution for some well known RSS hash key which is used in some PMDs. Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 108 ++ 1 file

[PATCH v3 3/4] hash: implement RSS hash key generation API

This patch implements Toeplitz hash key generation function using the new polynomial generation function. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/lib/hash/rte_thash.c b/lib/hash

[PATCH v3 2/4] hash: add dynamic polynomial calculation

polynomial calculation for polynomials of degree 7 or higher, resulting in better entropy of generated RSS hash key. Signed-off-by: Vladimir Medvedkin --- lib/hash/meson.build | 1 + lib/hash/rte_thash.c | 46 +- lib/hash/rte_thash.h | 13 ++ lib/hash

[PATCH v3 1/4] thash: add RSS hash key generation API

Toeplitz hash key with respect to hash values distribution. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 13 + lib/hash/rte_thash.h | 24 lib/hash/version.map | 2 ++ 3 files changed, 39 insertions(+) diff --git a/lib/hash/rte_thash.c b/lib/hash

[PATCH v3 0/4] RSS hash key generation

v2 - fix some minor issues Vladimir Medvedkin (4): thash: add RSS hash key generation API hash: add dynamic polynomial calculation hash: implement RSS hash key generation API test/thash: add tests for RSS key generation API app/test/test_thash.c | 108 lib/hash

[PATCH v4] fib: network byte order IPv4 lookup

Previously when running rte_fib_lookup IPv4 addresses must have been in host byte order. This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on fib create, which will allow to have IPv4 in network byte order on lookup. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c

[PATCH v2 4/4] test/thash: add tests for RSS key generation API

key with the new API and run the test again, noting the new distribution. Finally, we also measure said distribution for some well known RSS hash key which is used in some PMDs. Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 108 ++ 1 file

[PATCH v2 3/4] hash: implement RSS hash key generation API

This patch implements Toeplitz hash key generation function using the new polynomial generation function. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/lib/hash/rte_thash.c b/lib/hash

[PATCH v2 2/4] hash: add dynamic polynomial calculation

polynomial calculation for polynomials of degree 7 or higher, resulting in better entropy of generated RSS hash key. Signed-off-by: Vladimir Medvedkin --- lib/hash/meson.build | 1 + lib/hash/rte_thash.c | 46 +- lib/hash/rte_thash.h | 13 ++ lib/hash

[PATCH v2 0/4] RSS hash key generation

. For example, if we know that we are receiving flows where source/destination addresses are fixed or limited to a small quantity, but source port has good distribution, we could generate an RSS key that will give us good distribution across our ReTa. v2 - fix some minor issues Vladimir Medvedkin

[PATCH v2 1/4] thash: add RSS hash key generation API

Toeplitz hash key with respect to hash values distribution. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 13 + lib/hash/rte_thash.h | 24 lib/hash/version.map | 2 ++ 3 files changed, 39 insertions(+) diff --git a/lib/hash/rte_thash.c b/lib/hash

[PATCH v3 2/2] test/fib: add RCU functional tests

Add positive and negative tests for API rte_fib_rcu_qsbr_add. Also test FIB library behavior when RCU QSBR is enabled. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c | 209 1 file changed, 209 insertions(+) diff --git a/app/test

[PATCH v3 1/2] fib: implement RCU rule reclamation

. Signed-off-by: Vladimir Medvedkin Acked-by: Stephen Hemminger --- lib/fib/dir24_8.c | 98 - lib/fib/dir24_8.h | 9 + lib/fib/meson.build | 5 ++- lib/fib/rte_fib.c | 11 + lib/fib/rte_fib.h | 50 ++- lib/fib

[PATCH v3] fib: network byte order IPv4 lookup

Previously when running rte_fib_lookup IPv4 addresses must have been in host byte order. This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on fib create, which will allow to have IPv4 in network byte order on lookup. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c

[PATCH v2 2/2] test/fib: add RCU functional tests

Add positive and negative tests for API rte_fib_rcu_qsbr_add. Also test FIB library behavior when RCU QSBR is enabled. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c | 209 1 file changed, 209 insertions(+) diff --git a/app/test

[PATCH v2 1/2] fib: implement RCU rule reclamation

. Signed-off-by: Vladimir Medvedkin --- lib/fib/dir24_8.c | 104 +++- lib/fib/dir24_8.h | 9 lib/fib/meson.build | 5 ++- lib/fib/rte_fib.c | 11 + lib/fib/rte_fib.h | 50 - lib/fib/version.map | 7 +++ 6 files changed

[PATCH v2] fib: network byte order IPv4 lookup

Previously when running rte_fib_lookup IPv4 addresses must have been in host byte order. This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on fib create, which will allow to have IPv4 in network byte order on lookup. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c

[PATCH] fib6: add runtime checks for vector lookup

AVX512 lookup function requires CPU to support RTE_CPUFLAG_AVX512DQ and RTE_CPUFLAG_AVX512BW. Add runtime checks of these two flags when deciding if vector function can be used. Fixes: c3e12e0f0354 ("fib: add dataplane algorithm for IPv6") Cc: sta...@dpdk.org Signed-off-by: Vladimir

[PATCH v2] fib: network byte order IPv4 lookup

Previously when running rte_fib_lookup IPv4 addresses must have been in host byte order. This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on fib create, which will allow to have IPv4 in network byte order on lookup. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c

Re: [PATCH] fib: implement RCU rule reclamation

Hi David, Robin, Thanks, I'll send v2 with the fix. сб, 28 сент. 2024 г. в 00:59, David Marchand : > On Fri, Sep 27, 2024 at 6:13 PM Robin Jarry wrote: > > > > Vladimir Medvedkin, Sep 06, 2024 at 13:09: > > > Currently, for DIR24-8 algorithm, the tbl8 gro

Re: [PATCH] fib: network byte order IPv4 lookup

Hi David, Thanks for pointing out this problem, I'll send a fix and v2. пн, 30 сент. 2024 г. в 16:07, David Marchand : > On Sat, Sep 28, 2024 at 1:51 AM David Marchand > wrote: > > > > On Fri, Sep 6, 2024 at 1:07 PM Vladimir Medvedkin > > wrote: > &

[PATCH] fib: implement RCU rule reclamation

. Signed-off-by: Vladimir Medvedkin --- lib/fib/dir24_8.c | 104 +++- lib/fib/dir24_8.h | 9 lib/fib/meson.build | 1 + lib/fib/rte_fib.c | 11 + lib/fib/rte_fib.h | 50 - lib/fib/version.map | 7 +++ 6 files changed

[PATCH] fib: network byte order IPv4 lookup

Previously when running rte_fib_lookup IPv4 addresses must have been in host byte order. This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on fib create, which will allow to have IPv4 in network byte order on lookup. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c

[PATCH] fib: fix vector lookup

allocating an extra 4 byte in the end of the tbl24. Fixes: 7dc7868b200d ("fib: add DIR24-8 dataplane algorithm") Fixes: c3e12e0f0354 ("fib: add dataplane algorithm for IPv6") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- lib/fib/dir24_8.c | 4 ++-- lib/fib/t

[PATCH] hash: fix thash lfsr initialization

Reverse polynomial for an LFSR was initialized improperly which could generate improper bit sequence in some situations. This patch implements proper polynomial reversing function. Fixes: 28ebff11c2dc ("hash: add predictable RSS") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin

[RFC 4/4] test/thash: add tests for RSS key generation API

key with the new API and run the test again, noting the new distribution. Finally, we also measure said distribution for some well known RSS hash key which is used in some PMDs. Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 108 ++ 1 file

[RFC 3/4] hash: implement RSS hash key generation API

This patch implements Toeplitz hash key generation function using the new polynomial generation function. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/lib/hash/rte_thash.c b/lib/hash

[RFC 2/4] hash: add dynamic polynomial calculation

polynomial calculation for polynomials of degree 7 or higher, resulting in better entropy of generated RSS hash key. Signed-off-by: Vladimir Medvedkin --- lib/hash/meson.build | 1 + lib/hash/rte_thash.c | 46 +- lib/hash/rte_thash.h | 13 ++ lib/hash

[RFC 1/4] thash: add RSS hash key generation API

Toeplitz hash key with respect to hash values distribution. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 13 + lib/hash/rte_thash.h | 24 lib/hash/version.map | 4 +++- 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/lib/hash

[RFC 0/4] RSS hash key generation

. For example, if we know that we are receiving flows where source/destination addresses are fixed or limited to a small quantity, but source port has good distribution, we could generate an RSS key that will give us good distribution across our ReTa. Vladimir Medvedkin (4): thash: add RSS hash

[PATCH] examples/ipsec-secgw: revert fix SA salt endianness

shihong.w...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- examples/ipsec-secgw/ipsec.h | 2 +- examples/ipsec-secgw/sa.c| 13 ++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ips

[PATCH] doc: announce fib configuration structure changes

Announce addition of the flags field into rte_fib_conf structure. Signed-off-by: Vladimir Medvedkin --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 6948641ff6

[PATCH v5 3/3] net/ice: fix return value for raw pattern parsing function

ng in RSS") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index aa76718313..b720e0f755 100644 --- a/drivers/net/ice/ice_hash.c +++

[PATCH v5 2/3] net/ice: refactor raw pattern parsing function

Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern. Signed-off-by: Vladimir Medvedkin tmp --- drivers/net/ice/ice_hash.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 6b3095e2c5

[PATCH v5 1/3] net/ice: fix possible memory leak

l Theodore Stolarchuk Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index f923641533..6b3095e2c5 100644 --- a/drivers/net/ice/ice_ha

[PATCH v4 3/3] net/ice: fix return value for raw pattern parsing function

ng in RSS") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 506ea261e8..1188962752 100644 --- a/drivers/net/ice/ice_hash.c +++

[PATCH v4 2/3] net/ice: refactor raw pattern parsing function

Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern. Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 6b3095e2c5..506ea261e8

[PATCH v4 1/3] net/ice: fix possible memory leak

l Theodore Stolarchuk Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index f923641533..6b3095e2c5 100644 --- a/drivers/net/ice/ice_ha

[PATCH v3 3/3] net/ice: fix return value for raw pattern parsing function

ng in RSS") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index d63e673b25..b040a198bb 100644 --- a/drivers/net/ice/ice_hash.c +++

[PATCH v3 2/3] net/ice: refactor raw pattern parsing function

Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern. Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index cdce1d0ea2..d63e673b25

[PATCH v3 1/3] net/ice: fix possible memory leak

l Theodore Stolarchuk Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index f923641533..cdce1d0ea2 100644 --- a/drivers/net/ice/ice_ha

Re: IPv6 APIs rework

Hi Robin, Thanks, that is a good idea. чт, 18 июл. 2024 г. в 21:27, Morten Brørup : > > From: Robin Jarry [mailto:rja...@redhat.com] > > > > Hi folks, > > > > while working on IPv6 support for grout [1], I noticed that all DPDK > > IPv6 APIs used fixed sized arrays in the route lookup functio

[PATCH v2 3/3] net/ice: fix return value for raw pattern parsing function

ng in RSS") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 00503d0d28..13a68b8f02 100644 --- a/drivers/net/ice/ice_hash.c +++

[PATCH v2 2/3] net/ice: refactor raw pattern parsing function

Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern. Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 913f54fca4..00503d0d28

[PATCH v2 1/3] net/ice: fix possible memory leak

l Theodore Stolarchuk Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index f923641533..913f54fca4 100644 --- a/drivers/net/ice/ice_ha

[PATCH] net/ice: fix possible memory leak

ng in RSS") Cc: ting...@intel.com Cc:sta...@dpdk.org Reported-by: Michael Theodore Stolarchuk Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_hash.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/d

[PATCH] net/ice: use a different method to filter LLDP packets

special AQ command (LLDP filter control). Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ice_ethdev.c | 34 +- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 194109b0f6

[PATCH] net/ice: fix vlan stripping in double VLAN mode

single VLAN in a packet is treated as inner VLAN. This patch fixes the logic of how vlan stripping is programmed. Bugzilla ID: 1402 Fixes: de5da9d16430 ("net/ice: support double VLAN") Cc: mingjinx...@intel.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/net/ice/ic

[PATCH] doc: clarify ipsec-secgw documentation on TSO

Updated ipsec-secgw user guide to reflect that ipsec-secgw only supports TSO for TCP/IP at this time. Signed-off-by: Vladimir Medvedkin --- doc/guides/sample_app_ug/ipsec_secgw.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst b/doc/guides

Re: [PATCH] hash: fix segfault by adding param name NULL check

+cc stable@ Acked-by: Vladimir Medvedkin чт, 6 июл. 2023 г. в 16:26, Conor Fogarty : > Add NULL pointer check to params->name, which is later > copied into the hash datastructure. Without this check > the code segfaults on the strlcpy() of a NULL pointer. > > Fixes: 4

Re: [PATCH] lib/hash: fix the return value description of rte_hash

I believe this patch requires fixline and cc stable@ Fixes: af75078fece3 ("first public release") Apart from it Acked-by: Vladimir Medvedkin чт, 6 июл. 2023 г. в 23:58, Stephen Hemminger : > On Mon, 27 Jun 2022 21:11:21 +0800 > Chenming C wrote: > > > The rte_ha

[PATCH] fib6: fix adding default route as first route

rg Signed-off-by: Vladimir Medvedkin --- lib/fib/trie.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/lib/fib/trie.c b/lib/fib/trie.c index 3e780afdaf..09470e7287 100644 --- a/lib/fib/trie.c +++ b/lib/fib/trie.c @@ -451,6 +451,14 @@ get_nxt_net(uint8_t *i

[PATCH] fib: fix adding default route overwriting entire table

;) Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- lib/fib/dir24_8.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/fib/dir24_8.c b/lib/fib/dir24_8.c index 3efdcb533c..5f73b8a7f0 100644 --- a/lib/fib/dir24_8.c +++ b/lib/fib/dir24_8.c @@ -388,6 +388,12 @@ modify_

[PATCH] fib: fix adding a default route

Fixed an issue that occurs when adding a default route as the first route. Bugzilla ID: 1160 Fixes: 7dc7868b200d ("fib: add DIR24-8 dataplane algorithm") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- v2: - remove unnecessary parenthesis --- lib/fib/dir24_8.c | 2

[PATCH] fib: fix adding a default route

Fixed an issue that occurs when adding a default route as the first route. Bugzilla ID: 1160 Fixes: 7dc7868b200d ("fib: add DIR24-8 dataplane algorithm") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- lib/fib/dir24_8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v2 2/2] test: add additional tests for thash library

Adds tests comparing the results of applying the output of rte_thash_get_complement() to the tuple with the result of calling rte_thash_adjust_tuple(). Suggested-by: Konstantin Ananyev Signed-off-by: Konstantin Ananyev Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 132

[PATCH v2 1/2] hash: fix reading unaligned bits implementation

Fixes: 28ebff11c2dc ("hash: add predictable RSS") Cc: sta...@dpdk.org Acked-by: Konstantin Ananyev Tested-by: Konstantin Ananyev Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/hash/rte

[PATCH] test/ipsec: fix TAP default MAC address

default TAP mac address was changed in commit id: c3006be2acab49c6b77ae9c9ef04b061e5dacbd6 reflect changes in ipsec test scripts. Fixes: c3006be2acab ("net/tap: set locally administered bit for fixed MAC address") Cc: d...@linux.vnet.ibm.com Cc: sta...@dpdk.org Signed-off-by: Vladimir

[PATCH] test: add additional tests for thash library

Adds tests comparing the results of applying the output of rte_thash_get_complement() to the tuple with the result of calling rte_thash_adjust_tuple(). Suggested-by: Konstantin Ananyev Signed-off-by: Konstantin Ananyev Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 132

[PATCH] hash: fix reading unaligned bits implementation

Fixes: 28ebff11c2dc ("hash: add predictable RSS") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index 0249883b8d..2228af576b 10

Re: [PATCH v6] hash: add XOR32 hash function

Hi Bili, The rte_hash_xor32() implementation looks a bit messy with respect to byte ordering, i.e. in case when data_len >= 8 init_val is byte swapped, but in other cases the data is byte swapped. Maybe it could be implemented like: static inline uint32_t rte_hash_xor32(const void *data, uint32_t

[PATCH v3 2/2] test/hash: fix coverity warning

Check return value after bulk lookup Coverity issue: 357746 Fixes: 14b8ab576235 ("hash: add bulk lookup with signatures array") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_perf.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff -

[PATCH v3 1/2] test/hash: fix coverity warning

Remove unnecessary variable assignment Coverity issue: 336800 Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket") Cc: dharmik.thak...@arm.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin Reviewed-by: Ruifeng Wang --- app/test/test_hash_readwrite_lf_perf.

[PATCH v2] test/hash: fix coverity warning

Check return value after bulk lookup Coverity issue: 357746 Fixes: 14b8ab576235 ("hash: add bulk lookup with signatures array") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_perf.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff -

[PATCH 2/2] test/hash: fix coverity warning

Check return value after bulk lookup Coverity issue: 357746 Fixes: 14b8ab576235 ("hash: add bulk lookup with signatures array") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_perf.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) di

[PATCH 1/2] test/hash: fix coverity warning

Remove unnecessary variable assignment Coverity issue: 336800 Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket") Cc: dharmik.thak...@arm.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_readwrite_lf_perf.c | 1 - 1 file changed,

[PATCH v2] test/ipsec: fix performance test failure

mance cases") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- Notes: v2: - fix gcc4 warnings app/test/test_ipsec_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_ipsec_perf.c b/app/test/test_ipsec_perf.c index 346a851648..11de9a6

[PATCH] test/ipsec: fix performance test failure

mance cases") Cc: savinay.dharma...@intel.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test/test_ipsec_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_ipsec_perf.c b/app/test/test_ipsec_perf.c index 346a851648..580cad00f6 10064

[PATCH] app/test: fix buffer overflow in table unit tests

This patch fixes stack buffer overflow reported by ASAN. Bugzilla ID: 820 Fixes: 5205954791cb ("app/test: packet framework unit tests") Cc: cristian.dumitre...@intel.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test/test_table_tables.c | 10 +- 1 file

[PATCH v3] app/test-fib: fix possible division by zero

uot;) Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test-fib/main.c | 8 1 file changed, 8 insertions(+) diff --git a/app/test-fib/main.c b/app/test-fib/main.c index ecd420116a..067c5284f9 100644 --- a/app/test-fib/main.c +++ b/app/test-fib/main.c @@ -711,6 +711,10 @@ parse_

[PATCH v2] app/test-fib: fix possible division by zero

uot;) Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test-fib/main.c | 40 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/app/test-fib/main.c b/app/test-fib/main.c index ecd420116a..9bc8b8a7ca 100644 --- a/app/test-fib/main.c +++ b

[PATCH] app/test-fib: fix possible division by zero

FIB") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin --- app/test-fib/main.c | 40 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/app/test-fib/main.c b/app/test-fib/main.c index ecd420116a..9bc8b8a7ca 100644 --- a/app/test-fib

[PATCH v3] hash: fix thash gfni implementation

compilation problems on 32bit arch due to lack of support for _mm_extract_epi64() by implementing XOR folding with _mm_extract_epi32() on 32-bit arch. Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin Acked

[PATCH v2] hash: fix thash gfni implementation

compilation problems on 32bit arch due to lack of support for _mm_extract_epi64() by implementing XOR folding with _mm_extract_epi32() on 32-bit arch. Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin Acked

[PATCH v2] hash: clarify comments for RTE_HASH_BUCKET_ENTRIES

This patch adds a comment for RTE_HASH_BUCKET_ENTRIES explaining why a particular value was chosen. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_cuckoo_hash.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/hash/rte_cuckoo_hash.h b/lib/hash/rte_cuckoo_hash.h

[dpdk-dev] [PATCH] hash: fix thash gfni implementation

: add new Toeplitz hash implementation") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash_x86_gfni.h | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/lib/hash/rte_thash_x86_gfni.h

[dpdk-dev] [PATCH 1/2] doc: add programmer's guide for the RIB library

Currently, programmer's guide for the RIB library is missing. This commit adds it. Signed-off-by: Vladimir Medvedkin --- doc/guides/prog_guide/img/rib_internals.svg | 148 + doc/guides/prog_guide/img/rib_pic.svg | 152 + doc/guides/prog_guide/inde

[dpdk-dev] [PATCH 2/2] doc: add programmer's guide for the FIB library

Currently, programmer's guide for the FIB library is missing. This commit adds it. Signed-off-by: Vladimir Medvedkin --- doc/guides/prog_guide/fib_lib.rst | 139 + doc/guides/prog_guide/img/dir_24_8_alg.svg | 136 doc/guides/prog_guide/inde

[dpdk-dev] [PATCH] hash: clarify comments for RTE_HASH_BUCKET_ENTRIES

This patch adds a comment for RTE_HASH_BUCKET_ENTRIES explaining why a particular value was chosen. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_cuckoo_hash.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/hash/rte_cuckoo_hash.h b/lib/hash/rte_cuckoo_hash.h

  1   2   3   4   5   6   >