[PATCH v5 03/13] test: add test for hotplug and secondary process operations

2025-07-18 Thread Stephen Hemminger
Use null device to exercise ethdev start/stop in secondary process. Signed-off-by: Stephen Hemminger --- app/test/test_mp_secondary.c | 51 +--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/app/test/test_mp_secondary.c b/app/test

[PATCH v5 13/13] pdump: mark API and application as deprecated

2025-07-18 Thread Stephen Hemminger
When the pdump application is run print a warning. Add release note about deprecation and mark the API's as deprecated. Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 3 +++ app/pdump/meson.build | 1 + app/test-pmd/meson.

[PATCH v5 12/13] app/dumpcap: use port mirror instead of pdump

2025-07-18 Thread Stephen Hemminger
Use the new port mirror API instead of pdump. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 443 +--- app/dumpcap/meson.build | 2 +- 2 files changed, 373 insertions(+), 72 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c

[PATCH v5 10/13] test: add tests for ethdev mirror

2025-07-18 Thread Stephen Hemminger
Simple API and packet mirroring standalone tests. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 1 + app/test/test_ethdev_mirror.c | 286 ++ 2 files changed, 287 insertions(+) create mode 100644 app/test/test_ethdev_mirror.c diff --git

[PATCH v5 11/13] app/testpmd: support for port mirroring

2025-07-18 Thread Stephen Hemminger
Add new commands to enable testing of port mirror functionality. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 1 + app/test-pmd/cmdline_mirror.c | 129 app/test-pmd/cmdline_mirror.h | 12 ++ app/test-pmd

[PATCH v5 09/13] pcapng: make queue optional

2025-07-18 Thread Stephen Hemminger
The queue field is optional in pcapng received packet. Use UINT16_MAX as flag value. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 7 --- lib/pcapng/rte_pcapng.h | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng

[PATCH v5 08/13] pcapng: split packet copy from header insertion

2025-07-18 Thread Stephen Hemminger
In new model, the packet was already copied, only need to wrap it in pcapng format. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 178 +--- lib/pcapng/rte_pcapng.h | 27 +- 2 files changed, 120 insertions(+), 85 deletions(-) diff --git

[PATCH v5 06/13] mbuf: add dynamic flag for use by port mirroring

2025-07-18 Thread Stephen Hemminger
Add names for new port mirror fields. Signed-off-by: Stephen Hemminger --- lib/mbuf/rte_mbuf_dyn.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/mbuf/rte_mbuf_dyn.h b/lib/mbuf/rte_mbuf_dyn.h index 865c90f579..72a31b22b3 100644 --- a/lib/mbuf/rte_mbuf_dyn.h +++ b/lib/mbuf

[PATCH v5 07/13] ethdev: add port mirroring feature

2025-07-18 Thread Stephen Hemminger
This adds new feature port mirroring to the ethdev layer. Signed-off-by: Stephen Hemminger --- config/rte_config.h | 1 + lib/ethdev/ethdev_driver.h | 6 + lib/ethdev/ethdev_private.c | 58 - lib/ethdev/ethdev_private.h | 3 + lib/ethdev/ethdev_trace.h

[PATCH v5 05/13] net/ring: add new devarg to create vdev from existing ring

2025-07-18 Thread Stephen Hemminger
n the parameter. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 966c64d9a5..94a739a925 100644 --- a/drivers/net

[PATCH v5 04/13] net/ring: allow lockfree transmit if ring supports it

2025-07-18 Thread Stephen Hemminger
Need to be able have multiple threads all using same transmit queue when using SPAN. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c

[PATCH v5 02/13] ethdev: make sure all necessary headers included

2025-07-18 Thread Stephen Hemminger
Best not to depend on other EAL headers to include stuff. Some of the later changes had build failures on some platforms. Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_private.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev

[PATCH v5 00/13] Packet capture using port mirroring

2025-07-18 Thread Stephen Hemminger
more that the overhead of looking at the callback list. TODO items: - need release notes for new features (will wait till 25.11) - more through testing on real hardware v5 - fix build warnings when experimental not enabled. Stephen Hemminger (13): ethdev: allow start/stop from secondary proces

[PATCH v5 01/13] ethdev: allow start/stop from secondary process

2025-07-18 Thread Stephen Hemminger
later add queue and other operations as needed. Bugzilla ID: 73 Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_driver.c | 11 - lib/ethdev/ethdev_private.c | 93 + lib/ethdev/ethdev_private.h | 26 +++ lib/ethdev/rte_ethdev.c | 84

Re: [PATCH 0/4] rework mlx5 guide

2025-07-18 Thread Stephen Hemminger
On Fri, 18 Jul 2025 00:05:40 +0200 Thomas Monjalon wrote: > The main mlx5 doc (for net driver) is improved > with better explanations, better organization, better readability, > and will be a better skeleton for future detailed explanations. > > Maayan Kashani (1): > doc: add testpmd command e

Re: [PATCH 3/4] doc: rework mlx5 guide per features

2025-07-18 Thread Stephen Hemminger
On Fri, 18 Jul 2025 00:05:43 +0200 Thomas Monjalon wrote: > The documentation for net mlx5 is reworded and re-organized. > Design, configuration, requirements and limitations > are grouped per features for easier reading. > > New details are added, and more will come later. > > Signed-off-by: T

Re: [PATCH] net/mlx5: document IP fragment matching limitations

2025-07-18 Thread Stephen Hemminger
On Fri, 18 Jul 2025 13:51:56 +0200 Dariusz Sosnowski wrote: > NVIDIA NICs do not support matching on packet headers appearing > after IP header if the received packet is an IP fragment. > This patch updates the relevant documentation. > > Bugzilla ID: 1417 > > Signed-off-by: Dariusz Sosnowski

Re: [PATCH v5 03/14] net/sxe: add tx rx setup and data path

2025-07-17 Thread Stephen Hemminger
On Wed, 9 Jul 2025 21:20:10 -0400 Jie Liu wrote: > s32 __rte_cold __sxe_rx_queue_mbufs_alloc(struct sxe_rx_queue *rxq) > +{ > + struct sxe_rx_buffer *buf_ring = rxq->buffer_ring; > + s32 ret = 0; > + u64 dma_addr; > + u16 i; > + > + for (i = 0; i < rxq->ring_depth; i++) { > +

Re: [PATCH 00/11] NXP DPAA2 driver enhancements and fixes

2025-07-17 Thread Stephen Hemminger
Too late for 25.07 now. But will put in next-net for 25.11 I notice if shadow declaration warning is enabled, lots of warning occur. In file included from ../drivers/net/dpaa2/dpaa2_ethdev.c:26: ../drivers/net/dpaa2/dpaa2_ethdev.c: In function ‘dpaa2_alloc_rx_tx_queues’: ../drivers/bus/fslmc/por

Re: [PATCH v9 02/14] net/sxe: add ethdev probe and remove

2025-07-17 Thread Stephen Hemminger
On Wed, 16 Jul 2025 04:29:18 -0400 Jie Liu wrote: > +static s32 sxe_hdc_cmd_process(struct sxe_hw *hw, u64 trace_id, > + struct sxe_hdc_trans_info *trans_info) > +{ > + s32 ret; > + u8 retry_idx; > + struct sxe_adapter *adapter = hw->adapter; > + sigset

Re: [PATCH v9 02/14] net/sxe: add ethdev probe and remove

2025-07-16 Thread Stephen Hemminger
On Wed, 16 Jul 2025 04:29:18 -0400 Jie Liu wrote: > diff --git a/drivers/net/sxe/meson.build b/drivers/net/sxe/meson.build > index dad9ee44a0..34571522f7 100644 > --- a/drivers/net/sxe/meson.build > +++ b/drivers/net/sxe/meson.build > @@ -1,9 +1,22 @@ > # SPDX-License-Identifier: BSD-3-Clause >

Re: [PATCH v9 02/14] net/sxe: add ethdev probe and remove

2025-07-16 Thread Stephen Hemminger
On Wed, 16 Jul 2025 04:29:18 -0400 Jie Liu wrote: > + > +#define false 0 > +#define true 1 > + Bad idea, conflicts with stdbool.h

Re: [PATCH v9 02/14] net/sxe: add ethdev probe and remove

2025-07-16 Thread Stephen Hemminger
On Wed, 16 Jul 2025 04:29:18 -0400 Jie Liu wrote: > --- /dev/null > +++ b/drivers/net/sxe/base/sxe_common.c > @@ -0,0 +1,66 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright (C), 2022, Linkdata Technology Co., Ltd. > + */ > + > +#include > +#include > +#include > +#include > +#in

Re: [PATCH v9 03/14] net/sxe: add tx rx setup and data path

2025-07-16 Thread Stephen Hemminger
On Wed, 16 Jul 2025 04:29:19 -0400 Jie Liu wrote: > +const alignas(RTE_CACHE_LINE_SIZE) u32 sxe_ptype_table[SXE_PACKET_TYPE_MAX] > = { > + Prefer using DPDK macro __rte_cache_align where possible.

Re: [PATCH v9 03/14] net/sxe: add tx rx setup and data path

2025-07-16 Thread Stephen Hemminger
On Wed, 16 Jul 2025 04:29:19 -0400 Jie Liu wrote: > Add setup, initialization, and logic for tx and rx queues. > > Signed-off-by: Jie Liu > --- Buried in checkpatch warnings are some spelling errors here: WARNING:TYPO_SPELLING: 'unsupport' may be misspelled - perhaps 'unsupported'? #5037: FI

Re: [PATCH] doc: remove Mellanox acquisition explanation

2025-07-16 Thread Stephen Hemminger
On Wed, 16 Jul 2025 17:56:04 +0200 Thomas Monjalon wrote: > 16/07/2025 12:37, Bruce Richardson: > > On Wed, Jul 16, 2025 at 12:15:16PM +0200, Thomas Monjalon wrote: > > > Time has passed since Mellanox acquisition by NVIDIA. > > > No need to explain this anymore. > > > > > > Signed-off-by: Tho

[PATCH v3 2/2] doc: remove use of '-n 4' option in documentation examples

2025-07-15 Thread Stephen Hemminger
Many places in the documentation are using -n 4 to set the number of memory channels. This is no longer required and is unneccessary in most cases. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Jack Bond-Preston --- doc/guides/contributing/documentation.rst | 2

[PATCH v3 1/2] doc: add note about CPU 0

2025-07-15 Thread Stephen Hemminger
On Linux (and probably BSD), CPU 0 can not be fully isolated because it receives timer interrupts and is used for other kernel related functions. The DPDK documentation should be updated to tell users to avoid polling on that CPU. Signed-off-by: Stephen Hemminger --- doc/guides/linux_gsg

[PATCH v3 0/2] cpu0 and memory channels doc update

2025-07-15 Thread Stephen Hemminger
This is revised version of earlier patches to address some guidance about CPU and memory channels in the documentation. Stephen Hemminger (2): doc: add note about CPU 0 doc: remove use of '-n 4' option in documentation examples doc/guides/contributing/documentation.rst |

[PATCH v4 13/13] pdump: mark API and application as deprecated

2025-07-15 Thread Stephen Hemminger
When the pdump application is run print a warning. Add release note about deprecation and mark the API's as deprecated. Signed-off-by: Stephen Hemminger pdump build deprecated --- app/pdump/main.c | 3 +++ app/pdump/meson.build| 1 + app/tes

[PATCH v4 12/13] app/dumpcap: use port mirror instead of pdump

2025-07-15 Thread Stephen Hemminger
Use the new port mirror API instead of pdump. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 443 +--- app/dumpcap/meson.build | 2 +- 2 files changed, 373 insertions(+), 72 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c

[PATCH v4 11/13] app/testpmd: support for port mirroring

2025-07-15 Thread Stephen Hemminger
Add new commands to enable testing of port mirror functionality. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 1 + app/test-pmd/cmdline_mirror.c | 129 app/test-pmd/cmdline_mirror.h | 12 ++ app/test-pmd

[PATCH v4 09/13] pcapng: make queue optional

2025-07-15 Thread Stephen Hemminger
The queue field is optional in pcapng received packet. Use UINT16_MAX as flag value. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 7 --- lib/pcapng/rte_pcapng.h | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng

[PATCH v4 10/13] test: add tests for ethdev mirror

2025-07-15 Thread Stephen Hemminger
Simple API and packet mirroring standalone tests. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 1 + app/test/test_ethdev_mirror.c | 285 ++ 2 files changed, 286 insertions(+) create mode 100644 app/test/test_ethdev_mirror.c diff --git

[PATCH v4 08/13] pcapng: split packet copy from header insertion

2025-07-15 Thread Stephen Hemminger
In new model, the packet was already copied, only need to wrap it in pcapng format. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 178 +--- lib/pcapng/rte_pcapng.h | 27 +- 2 files changed, 120 insertions(+), 85 deletions(-) diff --git

[PATCH v4 07/13] ethdev: add port mirroring feature

2025-07-15 Thread Stephen Hemminger
This adds new feature port mirroring to the ethdev layer. Signed-off-by: Stephen Hemminger --- config/rte_config.h | 1 + lib/ethdev/ethdev_driver.h | 6 + lib/ethdev/ethdev_private.c | 58 +- lib/ethdev/ethdev_private.h | 3 + lib/ethdev/ethdev_trace.h

[PATCH v4 06/13] mbuf: add dynamic flag for use by port mirroring

2025-07-15 Thread Stephen Hemminger
Add names for new port mirror fields. Signed-off-by: Stephen Hemminger --- lib/mbuf/rte_mbuf_dyn.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/mbuf/rte_mbuf_dyn.h b/lib/mbuf/rte_mbuf_dyn.h index 865c90f579..72a31b22b3 100644 --- a/lib/mbuf/rte_mbuf_dyn.h +++ b/lib/mbuf

[PATCH v4 05/13] net/ring: add new devarg to create vdev from existing ring

2025-07-15 Thread Stephen Hemminger
n the parameter. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 966c64d9a5..94a739a925 100644 --- a/drivers/net

[PATCH v4 03/13] test: add test for hotplug and secondary process operations

2025-07-15 Thread Stephen Hemminger
Use null device to exercise ethdev start/stop in secondary process. Signed-off-by: Stephen Hemminger --- app/test/test_mp_secondary.c | 51 +--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/app/test/test_mp_secondary.c b/app/test

[PATCH v4 04/13] net/ring: allow lockfree transmit if ring supports it

2025-07-15 Thread Stephen Hemminger
Need to be able have multiple threads all using same transmit queue when using SPAN. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c

[PATCH v4 02/13] ethdev: make sure all necessary headers included

2025-07-15 Thread Stephen Hemminger
Best not to depend on other EAL headers to include stuff. Some of the later changes had build failures on some platforms. Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_private.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev

[PATCH v4 01/13] ethdev: allow start/stop from secondary process

2025-07-15 Thread Stephen Hemminger
later add queue and other operations as needed. Bugzilla ID: 73 Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_driver.c | 11 - lib/ethdev/ethdev_private.c | 93 + lib/ethdev/ethdev_private.h | 26 +++ lib/ethdev/rte_ethdev.c | 84

[PATCH v4 00/13] Packet capture using port mirroring

2025-07-15 Thread Stephen Hemminger
- don't need ring pmd to timestamp Stephen Hemminger (13): ethdev: allow start/stop from secondary process ethdev: make sure all necessary headers included test: add test for hotplug and secondary process operations net/ring: allow lockfree transmit if ring supports it net/ring:

[PATCH] latencystats: make errors visible

2025-07-15 Thread Stephen Hemminger
This is attempt to get more info from latencystats test failures. When updating stats fails print message with ERR priority so it is not hidden. When updating stats fails in the test print the error code. Signed-off-by: Stephen Hemminger --- app/test/test_latencystats.c| 3 ++- lib

[PATCH] mailmap: sort entries

2025-07-14 Thread Stephen Hemminger
The lines in .mailmap are supposed to be sorted, they have gotten out of order over time. Signed-off-by: Stephen Hemminger --- .mailmap | 70 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/.mailmap b/.mailmap index

Re: [PATCH v1] mailmap: add new email to DPDK

2025-07-14 Thread Stephen Hemminger
On Mon, 14 Jul 2025 14:11:41 -0500 Pravin Pathak wrote: > Adding new mail for DPDK contribution > > Signed-off-by: Pravin Pathak > --- > .mailmap | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.mailmap b/.mailmap > index c7d55c7386..c81e745ce7 100644 > --- a/.mailmap > +++ b/.mailma

Re: [RFC PATCH] doc: clarify VLAN and QinQ stripping behaviour

2025-07-14 Thread Stephen Hemminger
On Mon, 14 Jul 2025 14:30:14 +0100 Bruce Richardson wrote: > The behaviour of VLAN tag stripping Rx offloads is unclear in DPDK, and > not very well documented. Even the documentation that does exist appears > contradictory. > > For example, the doxygen docs for the mbuf flag > RTE_MBUF_F_RX_QIN

Re: [PATCH 0/3] common/sfc_efx/base: fix compiler warnings in X4 netport API

2025-07-11 Thread Stephen Hemminger
On Fri, 11 Jul 2025 19:13:01 +0400 (+04) Ivan Malov wrote: > On Fri, 11 Jul 2025, Stephen Hemminger wrote: > > > On Fri, 11 Jul 2025 18:43:46 +0400 > > Ivan Malov wrote: > > > >> The 25.07 release has got support for AMD Solarflare X45xx adapters [1]. >

Re: [v8 1/8] bus/dpaa: add FMan node

2025-07-10 Thread Stephen Hemminger
On Thu, 3 Jul 2025 11:07:36 +0530 vanshika.shu...@nxp.com wrote: > > /* Create device name */ > memset(dev->name, 0, RTE_ETH_NAME_MAX_LEN); > - if (fman_intf->mac_type == fman_offline_internal) > + if (fman_intf->mac_type == fman_offline_inter

[PATCH v3 02/13] test: add test for hotplug and secondary process operations

2025-07-10 Thread Stephen Hemminger
Use null device to exercise ethdev start/stop in secondary process. Signed-off-by: Stephen Hemminger --- app/test/test_mp_secondary.c | 51 +--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/app/test/test_mp_secondary.c b/app/test

[PATCH v3 00/13] Packet capture using port mirroring

2025-07-10 Thread Stephen Hemminger
has not been measured but the overhead of checking for mirror port is no more that the overhead of looking at the callback list. TODO items: - some names are too verbose - need release notes for new features - more through testing on real hardware V3 - fix CI test reported issues Stephen

[PATCH v3 12/13] app/dumpcap: use port mirror instead of pdump

2025-07-10 Thread Stephen Hemminger
Use the new port mirror API instead of pdump. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 444 +--- app/dumpcap/meson.build | 2 +- 2 files changed, 374 insertions(+), 72 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c

[PATCH v3 13/13] pdump: mark API and application as deprecated

2025-07-10 Thread Stephen Hemminger
When the pdump application is run print a warning. Add release note about deprecation and mark the API's as deprecated. Signed-off-by: Stephen Hemminger pdump build deprecated --- app/pdump/main.c | 3 +++ app/pdump/meson.build| 1 + app/tes

[PATCH v3 08/13] pcapng: split packet copy from header insertion

2025-07-10 Thread Stephen Hemminger
In new model, the packet was already copied, only need to wrap it in pcapng format. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 178 +--- lib/pcapng/rte_pcapng.h | 27 +- 2 files changed, 120 insertions(+), 85 deletions(-) diff --git

[PATCH v3 11/13] app/testpmd: support for port mirroring

2025-07-10 Thread Stephen Hemminger
Add new commands to enable testing of port mirror functionality. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 1 + app/test-pmd/cmdline_mirror.c | 129 app/test-pmd/cmdline_mirror.h | 12 ++ app/test-pmd

[PATCH v3 07/13] ethdev: add port mirroring feature

2025-07-10 Thread Stephen Hemminger
This adds new feature port mirroring to the ethdev layer. Signed-off-by: Stephen Hemminger --- config/rte_config.h | 1 + lib/ethdev/ethdev_driver.h | 6 + lib/ethdev/ethdev_private.c | 58 - lib/ethdev/ethdev_private.h | 3 + lib/ethdev/ethdev_trace.h

[PATCH v3 10/13] test: add tests for ethdev mirror

2025-07-10 Thread Stephen Hemminger
Simple API and packet mirroring standalone tests. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 1 + app/test/test_ethdev_mirror.c | 285 ++ 2 files changed, 286 insertions(+) create mode 100644 app/test/test_ethdev_mirror.c diff --git

[PATCH v3 09/13] pcapng: make queue optional

2025-07-10 Thread Stephen Hemminger
The queue field is optional in pcapng received packet. Use UINT16_MAX as flag value. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 7 --- lib/pcapng/rte_pcapng.h | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng

[PATCH v3 06/13] ethdev: make sure all necessary headers included

2025-07-10 Thread Stephen Hemminger
Best not to depend on other EAL headers to include stuff. Some of the later changes had build failures on some platforms. Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_private.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev

[PATCH v3 05/13] mbuf: add dynamic flag for use by port mirroring

2025-07-10 Thread Stephen Hemminger
Add names for new port mirror fields. Signed-off-by: Stephen Hemminger --- lib/mbuf/rte_mbuf_dyn.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/mbuf/rte_mbuf_dyn.h b/lib/mbuf/rte_mbuf_dyn.h index 865c90f579..72a31b22b3 100644 --- a/lib/mbuf/rte_mbuf_dyn.h +++ b/lib/mbuf

[PATCH v3 04/13] net/ring: add new devargs for dumpcap use

2025-07-10 Thread Stephen Hemminger
going into ring to be timestamped. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 74 - 1 file changed, 72 insertions(+), 2 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 966c64d9a5..0f97c

[PATCH v3 03/13] net/ring: allow lockfree transmit if ring supports it

2025-07-10 Thread Stephen Hemminger
Need to be able have multiple threads all using same transmit queue when using SPAN. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c

[PATCH v3 01/13] ethdev: allow start/stop from secondary process

2025-07-10 Thread Stephen Hemminger
later add queue and other operations as needed. Bugzilla ID: 73 Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_driver.c | 11 - lib/ethdev/ethdev_private.c | 93 + lib/ethdev/ethdev_private.h | 26 +++ lib/ethdev/rte_ethdev.c | 84

Re: [PATCH] event/eth_tx: prefetch mbuf headers

2025-07-10 Thread Stephen Hemminger
On Fri, 28 Mar 2025 06:43:39 +0100 Mattias Rönnblom wrote: > Prefetch mbuf headers, resulting in ~10% throughput improvement when > the Ethernet RX and TX Adapters are hosted on the same core (likely > ~2x in case a dedicated TX core is used). > > Signed-off-by: Mattias Rönnblom > Tested-by: Pe

Re: Secondary process access control mechanism

2025-07-09 Thread Stephen Hemminger
On Wed, 9 Jul 2025 20:02:30 +0200 Morten Brørup wrote: > Are there any access control mechanisms to govern what a secondary process > can do to a primary process? > > Let's say I'm running a primary process, and want to allow only authorized > secondary processes to attach to it. No unauthoriz

Re: [PATCH v8 1/1] app/testpmd: canonicalize short PCI name format

2025-07-09 Thread Stephen Hemminger
On Tue, 8 Jul 2025 11:37:40 +0300 Shani Peretz wrote: > when providing short format PCI device names in devargs > (e.g. "08:00:0") it is converted and stored as long format. > however when attach_port is called from testpmd, the user might > provide a short format, which will be passed to find_de

[RFC v2 12/12] pdump: mark API and application as deprecated

2025-07-09 Thread Stephen Hemminger
When the pdump application is run print a warning. Add release note about deprecation and mark the API's as deprecated. Signed-off-by: Stephen Hemminger pdump build deprecated --- app/pdump/main.c | 3 +++ app/pdump/meson.build| 1 + app/tes

[RFC v2 11/12] app/dumpcap: use port mirror instead of pdump

2025-07-09 Thread Stephen Hemminger
Use the new port mirror API instead of pdump. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 443 +--- app/dumpcap/meson.build | 2 +- 2 files changed, 373 insertions(+), 72 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c

[RFC v2 10/12] app/testpmd: support for port mirroring

2025-07-09 Thread Stephen Hemminger
Add new commands to enable testing of port mirror functionality. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 1 + app/test-pmd/cmdline_mirror.c | 129 app/test-pmd/cmdline_mirror.h | 12 ++ app/test-pmd

[RFC v2 09/12] test: add tests for ethdev mirror

2025-07-09 Thread Stephen Hemminger
Simple API and packet mirroring standalone tests. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 1 + app/test/test_ethdev_mirror.c | 285 ++ 2 files changed, 286 insertions(+) create mode 100644 app/test/test_ethdev_mirror.c diff --git

[RFC v2 08/12] pcapng: make queue optional

2025-07-09 Thread Stephen Hemminger
The queue field is optional in pcapng received packet. Use UINT16_MAX as flag value. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 7 --- lib/pcapng/rte_pcapng.h | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng

[RFC v2 07/12] pcapng: split packet copy from header insertion

2025-07-09 Thread Stephen Hemminger
In new model, the packet was already copied, only need to wrap it in pcapng format. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 178 +--- lib/pcapng/rte_pcapng.h | 27 +- 2 files changed, 120 insertions(+), 85 deletions(-) diff --git

[RFC v2 06/12] ethdev: add port mirroring feature

2025-07-09 Thread Stephen Hemminger
This adds new feature port mirroring to the ethdev layer. Signed-off-by: Stephen Hemminger --- config/rte_config.h | 1 + lib/ethdev/ethdev_driver.h | 6 + lib/ethdev/ethdev_private.c | 58 +- lib/ethdev/ethdev_private.h | 3 + lib/ethdev/ethdev_trace.h

[RFC v2 05/12] mbuf: add dynamic flag for use by port mirroring

2025-07-09 Thread Stephen Hemminger
Add names for new port mirror fields. Signed-off-by: Stephen Hemminger --- lib/mbuf/rte_mbuf_dyn.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/mbuf/rte_mbuf_dyn.h b/lib/mbuf/rte_mbuf_dyn.h index 865c90f579..72a31b22b3 100644 --- a/lib/mbuf/rte_mbuf_dyn.h +++ b/lib/mbuf

[RFC v2 03/12] net/ring: allow lockfree transmit if ring supports it

2025-07-09 Thread Stephen Hemminger
Need to be able have multiple threads all using same transmit queue when using SPAN. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c

[RFC v2 04/12] net/ring: add new devargs for dumpcap use

2025-07-09 Thread Stephen Hemminger
going into ring to be timestamped. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 74 - 1 file changed, 72 insertions(+), 2 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 966c64d9a5..0f97c

[RFC v2 02/12] test: add test for hotplug and secondary process operations

2025-07-09 Thread Stephen Hemminger
Use null device to exercise ethdev start/stop in secondary process. Signed-off-by: Stephen Hemminger --- app/test/test_mp_secondary.c | 51 +--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/app/test/test_mp_secondary.c b/app/test

[RFC v2 01/12] ethdev: allow start/stop from secondary process

2025-07-09 Thread Stephen Hemminger
later add queue and other operations as needed. Bugzilla ID: 73 Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_driver.c | 11 - lib/ethdev/ethdev_private.c | 93 + lib/ethdev/ethdev_private.h | 26 +++ lib/ethdev/rte_ethdev.c | 84

[RFC v2 00/12] Packet capture using port mirroring

2025-07-09 Thread Stephen Hemminger
has not been measured but the overhead of checking for mirror port is no more that the overhead of looking at the callback list. TODO items: - some names are too verbose - need release notes for new features - more through testing on real hardware Stephen Hemminger (12): ethdev: allow

Re: [PATCH v4 14/14] net/sxe: add Solve compilation problems.

2025-07-09 Thread Stephen Hemminger
On Wed, 9 Jul 2025 04:43:14 -0400 Jie Liu wrote: > Add Fix compiling issues. > > Signed-off-by: Jie Liu > --- Please integrate these into earlier patches. Overall will not go further in review and build tests until driver passes CI build tests.

Re: [PATCH v3] pcapng: allow any protocol link type for the interface block

2025-07-08 Thread Stephen Hemminger
On Tue, 8 Jul 2025 15:02:45 -0600 Schneide wrote: > From: Dylan Schneider > > Allow the user to specify protocol link type when creating pcapng files. > This change is needed to specify the protocol type in the pcapng file, > DLT_EN10MB specifies ethernet packets only. This will allow dissecto

[RFC] add hints to CLAUDE

2025-07-08 Thread Stephen Hemminger
Soon users are going to want to use AI code generation like Claude with DPDK. There is a convention for giving hints to AI tool. Rough first draft Signed-off-by: Stephen Hemminger --- CLAUDE.md | 33 + 1 file changed, 33 insertions(+) create mode 100644

Re: [RFC PATCH v2 0/5] rework EAL argument parsing in DPDK

2025-07-08 Thread Stephen Hemminger
On Tue, 8 Jul 2025 17:20:34 + Bruce Richardson wrote: > This RFC is a second, more complete, prototype of one approach we may > want to take to help improve management of EAL cmdline arguments. > > BACKGROUND: > - The first problem that led to this work was that of providing a > way for u

Re: [PATCH] net/bonding: avoid RSS reta update in flow-isolation mode

2025-07-07 Thread Stephen Hemminger
On Fri, 4 Jul 2025 19:20:31 +0530 madhuker.myt...@oracle.com wrote: > From: Madhuker Mythri > > In bonding PMD, member_start() function checks whether RSS(mq_mode) is > enabled and then calling the RSS rte_eth_dev_rss_reta_update() API, which > is returning error in-case of device configured in

Re: [PATCH v1 2/6] net/zxdh: fix issues related to MAC configuration

2025-07-07 Thread Stephen Hemminger
On Mon, 7 Jul 2025 13:56:17 +0800 Junlong Wang wrote: > Fix error handling when MAC configuration fails. > This is issue was discovered during internal testing. > > Fixes: 1c8f68b64cfc ("net/zxdh: optimize MAC operations") > Cc: sta...@dpdk.org > > Signed-off-by: Junlong Wang > --- > drivers

Re: [PATCH v3 14/14] net/sxe: add Solve compilation problems.

2025-07-07 Thread Stephen Hemminger
On Mon, 7 Jul 2025 07:58:19 -0400 Jie Liu wrote: > Add Fix compiling issues. > > Signed-off-by: Jie Liu > --- The patch series is not build in CI. Please fix each patch so that it builds on Linux with GCC and Clang. The overall patch set needs to build on all supported platforms before review

Re: [PATCH v3 14/14] net/sxe: add Solve compilation problems.

2025-07-07 Thread Stephen Hemminger
On Mon, 7 Jul 2025 07:58:19 -0400 Jie Liu wrote: > Add Fix compiling issues. > > Signed-off-by: Jie Liu Please integrate these into the individual patches. Each patch in series must compile cleanly because at some later time a developer will be needing to do "git bisect" and if one of these p

Re: [PATCH v3 01/14] net/sxe: add base driver directory and doc

2025-07-07 Thread Stephen Hemminger
On Mon, 7 Jul 2025 07:58:06 -0400 Jie Liu wrote: > +Dynamic Logging Parameters > +~~ > + > +One may leverage EAL option "--log-level" to change default levels > +for the log types supported by the driver. The option is used with > +an argument typically consisting of two

Re: [PATCH v3 01/14] net/sxe: add base driver directory and doc

2025-07-07 Thread Stephen Hemminger
On Mon, 7 Jul 2025 07:58:06 -0400 Jie Liu wrote: > diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst > index 10a2eca3b0..67e6374c69 100644 > --- a/doc/guides/nics/index.rst > +++ b/doc/guides/nics/index.rst > @@ -72,3 +72,4 @@ Network Interface Controller Drivers > vmxnet3

Re: [PATCH v3 02/14] net/sxe: add ethdev probe and remove

2025-07-07 Thread Stephen Hemminger
> diff --git a/drivers/net/sxe/Makefile b/drivers/net/sxe/Makefile > new file mode 100644 > index 00..f75fd35e32 > --- /dev/null > +++ b/drivers/net/sxe/Makefile > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2010-2016 Intel Corporation > + > +include $(RT

Re: 回复: [V5 00/18] add hinic3 pmd driver

2025-07-06 Thread Stephen Hemminger
On Mon, 7 Jul 2025 03:27:20 + "wangfeifei (J)" wrote: > -邮件原件- > 发件人: Stephen Hemminger > 发送时间: 2025年7月2日 22:56 > 收件人: Feifei Wang > 抄送: dev@dpdk.org; chenyi (CY) > 主题: Re: [V5 00/18] add hinic3 pmd driver > > On Wed, 2 Jul 2025 10:09:23 +0800

Re: [PATCH] ethdev: fix shadow variable definition

2025-07-03 Thread Stephen Hemminger
On Thu, 3 Jul 2025 10:24:07 -0700 Stephen Hemminger wrote: > diff --git a/config/meson.build b/config/meson.build > index f31fef216c..3fc58c53b8 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -322,6 +322,7 @@ global_cflags = [ > '-Wnested-exte

[PATCH] ethdev: fix shadow variable definition

2025-07-03 Thread Stephen Hemminger
The variable 'ret' is defined twice in rte_eth_tx_queue_setup. Can remove one. Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") Signed-off-by: Stephen Hemminger --- config/meson.build | 1 + lib/ethdev/rte_ethdev.c | 1 - 2 files changed, 1 insertion(+), 1 del

Re: [PATCH] net/bonding: avoid RSS reta update in flow-isolation mode

2025-07-03 Thread Stephen Hemminger
On Thu, 3 Jul 2025 17:29:03 +0530 madhuker.myt...@oracle.com wrote: > From: Madhuker Mythri > > In bonding PMD, member_start() function checks whether RSS(mq_mode) is > enabled and then calling the RSS rte_eth_dev_rss_reta_update() API, which > is returning error in-case of device configured in

Re: [PATCH v2] build/x86: fix support for older compilers

2025-07-03 Thread Stephen Hemminger
On Thu, 3 Jul 2025 10:12:10 +0200 David Marchand wrote: > On Thu, Jul 3, 2025 at 10:01 AM Bruce Richardson > wrote: > > > > On Wed, Jul 02, 2025 at 11:22:42AM -0700, Stephen Hemminger wrote: > > > On Wed, 2 Jul 2025 17:00:45 +0100 > > > Bruce Richardso

Re: [PATCH v2] build/x86: fix support for older compilers

2025-07-02 Thread Stephen Hemminger
On Wed, 2 Jul 2025 17:00:45 +0100 Bruce Richardson wrote: > Some older compilers e.g. gcc 8.5, do not support overriding > -march=native with another architecture, leading to build warnings such > as reported in Bugzilla (link below). Add a check for that case, and > explicitly add the avx512 fl

Re: [PATCH v3 2/2] net/zxdh: add support flow director ops

2025-07-02 Thread Stephen Hemminger
On Wed, 2 Jul 2025 15:34:45 +0800 Bingbin Chen wrote: > Provide support for ETH, VLAN, IPv4/IPv6, TCP/UDP, VXLAN, > and mask matching, supporting multiple actions > include drop/count/mark/queue/rss,and vxlan decap/encap. > > Signed-off-by: Bingbin Chen > --- > doc/guides/nics/features/zxdh.i

Re: [V5 00/18] add hinic3 pmd driver

2025-07-02 Thread Stephen Hemminger
On Wed, 2 Jul 2025 10:09:23 +0800 Feifei Wang wrote: > From: Yi Chen > > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support > for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. > > v5: > - solve hinic3.ini unknown feature issue > > V4: > - solve patch applic

[PATCH v3] test/argparse: change initialization to workaround LTO

2025-07-01 Thread Stephen Hemminger
uld be upper case. Fixes: 6c5c6571601c ("argparse: verify argument config") Cc: fengcheng...@huawei.com Signed-off-by: Stephen Hemminger --- v3 - fix spelling errors app/test/test_argparse.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletion

Re: [PATCH 0/6] net/hns3: VF support multi-TCs

2025-07-01 Thread Stephen Hemminger
On Wed, 11 Jun 2025 16:18:54 +0800 Dengdui Huang wrote: > This patchset adds the VF multi-TCs feature. > > Chengwen Feng (6): > net/hns3: fix VF fail to config queue TC > net/hns3: remove duplicate struct field > net/hns3: refactor DCB module code > net/hns3: VF support parse max TC numb

  1   2   3   4   5   6   7   8   9   10   >