Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2022-01-18 Thread Stephen Douthit
On 12/22/21 19:55, Wang, Haiyue wrote: OK, let's see in 2022, happy holidays. ;-) A bit of a slower start to 2022 than I had hoped, but I have a v3 of the hotplug fix in progress. It's now working for the 82599 and C3000 ixgbe devices under Linux, and I'm in the process of getting this built a

Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-22 Thread Stephen Douthit
From Steve's response: ME: "I guess this is just in C3000 reference board SDK ?" Steve: "It's the board covered by Intel Doc # 574437." I check the doc "Last Updated: 11/07/2018" It should be some kind of customer release, that's why they are not in the official *open source*

Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-21 Thread Stephen Douthit
On 12/20/21 20:15, Wang, Haiyue wrote: -Original Message- From: Stephen Douthit Sent: Tuesday, December 21, 2021 05:33 To: Wang, Haiyue ; Lu, Wenzhuo ; Changchun Ouyang ; Zhang, Helin Cc: dev@dpdk.org; Wang, Wen ; sta...@dpdk.org Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF

Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-20 Thread Stephen Douthit
On 12/20/21 02:53, Wang, Haiyue wrote: -Original Message- From: Stephen Douthit Sent: Tuesday, December 7, 2021 06:19 To: Wang, Haiyue ; Lu, Wenzhuo ; Changchun Ouyang ; Zhang, Helin Cc: dev@dpdk.org; Wen Wang ; Stephen Douthit ; sta...@dpdk.org Subject: [PATCH v2 3/7] net/ixgbe

Re: [PATCH v2 1/7] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs

2021-12-20 Thread Stephen Douthit
On 12/20/21 02:45, Wang, Haiyue wrote: -Original Message- From: Stephen Douthit Sent: Tuesday, December 7, 2021 06:19 To: Wang, Haiyue ; Lu, Wenzhuo Cc: dev@dpdk.org; Wen Wang ; Stephen Douthit ; sta...@dpdk.org Subject: [PATCH v2 1/7] net/ixgbe: Fix ixgbe_is_sfp() to return valid

[PATCH v2 7/7] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2021-12-06 Thread Stephen Douthit
_sfps parameter inherited from the mainline Linux driver. Signed-off-by: Stephen Douthit --- drivers/net/ixgbe/base/ixgbe_x550.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c index 8810d

[PATCH v2 5/7] net/ixgbe: Fix SFP detection and linking on hotplug

2021-12-06 Thread Stephen Douthit
userspace request), and then get cleared once the requested subtask has been completed. Fixes: af75078fece ("first public release") Cc: sta...@dpdk.org Signed-off-by: Stephen Douthit --- drivers/net/ixgbe/base/ixgbe_type.h | 2 + drivers/net/ixgbe/ixgbe_ethdev.

[PATCH v2 6/7] net/ixgbe: Retry SFP ID read field to handle misbehaving SFPs

2021-12-06 Thread Stephen Douthit
ID read several times looking not just for NAK, but also for a valid ID field. Since the device isn't NAKing the trasanction the existing longer retry code in ixgbe_read_i2c_byte_generic_int() doesn't apply here. Signed-off-by: Stephen Douthit --- drivers/net/ixgbe/base/ixgbe_

[PATCH v2 4/7] net/ixgbe: Run 82599 link status workaround only on affected devices

2021-12-06 Thread Stephen Douthit
n coded in ixgbe_dev_link_update_share() * Runs only on fiber 82599 devices, not all fiber ixgbe devs (which don't all use SDP3 as TX_DISABLE) Fixes: 1ca05831b9b ("net/ixgbe: fix link status") Fixes: ff8162cb957 ("net/ixgbe: fix link status") Cc: sta...@dpdk.org Signed-off-by: Step

[PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-06 Thread Stephen Douthit
Signed-off-by: Stephen Douthit --- drivers/net/ixgbe/base/ixgbe_common.c | 46 +++ drivers/net/ixgbe/base/ixgbe_phy.h| 3 ++ 2 files changed, 49 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c index 2764cf7cf1..3b

[PATCH v2 2/7] net/ixgbe: Add ixgbe_check_sfp_cage() for testing state of PRSNT# signal

2021-12-06 Thread Stephen Douthit
circuit the I2C polling and greatly speed things up for devices we know are absent. Fixes: dd3a93cf5a2 ("net/ixgbe/base: bypass checking link for crosstalk") Cc: sta...@dpdk.org Signed-off-by: Stephen Douthit --- drivers/net/ixgbe/base/ixgbe_common.c | 60 +++---

[PATCH v2 1/7] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs

2021-12-06 Thread Stephen Douthit
Currently all X500EM* MAC types fallthrough to the default case and get reported as non-SFP regardless of media type, which isn't correct. Fixes: 0790adeb567 ("ixgbe/base: support X550em_a device") Cc: sta...@dpdk.org Signed-off-by: Stephen Douthit --- drivers/net/ixgbe/ixgb

[PATCH v2 0/7] ixgbe SFP handling fixes

2021-12-06 Thread Stephen Douthit
nefit. Since all of my testing was done on a C3000 platform, and the ixgbe driver now covers a large number of devices, any regression testing that can be done on other ixgbe devices would be greatly appreciated. Thanks, Steve Stephen Douthit (7): net/ixgbe: Fix ixgbe_is_sfp() to return valid r

[PATCH 7/7] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2021-12-06 Thread Stephen Douthit
_sfps parameter inherited from the mainline Linux driver. Signed-off-by: Stephen Douthit --- drivers/net/ixgbe/base/ixgbe_x550.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c index 8810d

[PATCH 7/7] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2021-12-03 Thread Stephen Douthit
_sfps parameter inherited from the mainline Linux driver. Signed-off-by: Stephen Douthit --- drivers/net/ixgbe/base/ixgbe_x550.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c index 8810d

[PATCH 6/7] net/ixgbe: Retry SFP ID read field to handle misbehaving SFPs

2021-12-03 Thread Stephen Douthit
he ID read several times looking not just for NAK, but also for a valid ID field. Since the device isn't NAKing the trasaction the existing longer retry code in ixgbe_read_i2c_byte_generic_int() doesn't apply here. Signed-off-by: Stephen Douthit --- drivers/net/ixgbe/base/i

[PATCH 5/7] net/ixgbe: Fix SFP detection and linking on hotplug

2021-12-03 Thread Stephen Douthit
userspace request), and then get cleared once the requested subtask has been completed. Fixes: af75078fece ("first public release") Cc: sta...@dpdk.org Signed-off-by: Stephen Douthit --- drivers/net/ixgbe/base/ixgbe_type.h | 2 + drivers/net/ixgbe/ixgbe_ethdev.

[PATCH 4/7] net/ixgbe: Run 82599 link status workaround only on affected devices

2021-12-03 Thread Stephen Douthit
n coded in ixgbe_dev_link_update_share() * Runs only on fiber 82599 devices, not all fiber ixgbe devs (which don't all use SDP3 as TX_DISABLE) Fixes: 1ca05831b9b ("net/ixgbe: fix link status") Fixes: ff8162cb957 ("net/ixgbe: fix link status") Cc: sta...@dpdk.org Signed-off-by: Step

[PATCH 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-03 Thread Stephen Douthit
Signed-off-by: Stephen Douthit --- drivers/net/ixgbe/base/ixgbe_common.c | 46 +++ drivers/net/ixgbe/base/ixgbe_phy.h| 3 ++ 2 files changed, 49 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c index 2764cf7cf1..3b

[PATCH 2/7] net/ixgbe: Add ixgbe_check_sfp_cage() for testing state of PRSNT# signal

2021-12-03 Thread Stephen Douthit
circuit the I2C polling and greatly speed things up for devices we know are absent. Fixes: dd3a93cf5a2 ("net/ixgbe/base: bypass checking link for crosstalk") Cc: sta...@dpdk.org Signed-off-by: Stephen Douthit --- drivers/net/ixgbe/base/ixgbe_common.c | 60 +++---

[PATCH 1/7] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs

2021-12-03 Thread Stephen Douthit
Currently all X500EM* MAC types fallthrough to the default case and get reported as non-SFP regardless of media type, which isn't correct. Fixes: 0790adeb567 ("ixgbe/base: support X550em_a device") Cc: sta...@dpdk.org Signed-off-by: Stephen Douthit --- drivers/net/ixgbe/ixgb

[PATCH 0/7] ixgbe SFP handling fixes

2021-12-03 Thread Stephen Douthit
Since all of my testing was done on a C3000 platform, and the ixgbe driver now covers a large number of devices, any regression testing that can be done on other ixgbe devices would be greatly appreciated. Thanks, Steve Stephen Douthit (7): net/ixgbe: Fix ixgbe_is_sfp() to return valid result fo