Change my email to a personal one.
Signed-off-by: Stanislaw Kardach
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b9d258e627..e61c57b1be 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -310,7 +310,7 @@ F: examples/*/*_altivec
hind flushing the cache line to free it
up to other data?
Other than that there is a ratified RISC-V extension for cache
management operations (including flush) - Zicbom.
NT load/store hints are being worked on right now.
--
Best Regards,
Stanislaw Kardach
return before
> +
> +def __flush(self) -> None:
> +"""
> +Clear all session buffer
> +"""
> +self.session.buffer = ""
> +self.session.before = ""
> +
> +def __prompt(self, c
tion hacks and the public APIs simply to not forget.
Though I'd do the refactoring sooner than later because once tests start
being merged there will be a higher possibility of them relying on
hacks.
--
Best Regards,
Stanislaw Kardach
'.', 1)[0]
> 'a.b.c'
>
Oh, I've totally missed that!
If that's the case then this function is a result of the always-timeout
logic. Note that get_output_before() is only called from
send_expect_base() (and indirectly by send_expect()) to get the output
of the command without the prompt.
So the reason why self.send_expect("echo 'foo'", "#") returns a proper
output ('foo\n') is:
0. On login() time pexpect sets the remote prompt to "[PEXPECT]#".
1. send_expect() -> self.send_expect_base() sets the match prompt to #.
This causes self.session.prompt() to update the self.session.buffer,
match # and chomp it, leaving the ssh buffer as:
foo
[PEXPECT]
2. send_expect_base() calls self.get_output_before() which cuts the last
line of the output. Note that the "if" at the end is necessary for
commands that do not return any output. Otherwise the output would
be "[PEXPECT]". Also note that if there are any control characters
printed by the remote shell, then this will also not work because
a straight string comparison is done, not a regex match.
Contrary, if self.magic_prompt was not used and pexpect's original
prompt was left undisturbed, then all the hacks above would not be
needed and the code would be cleaner.
> > > +if not self.isalive():
> > > +raise SSHSessionDeadException(self.node)
> > > +before: list[str] = self.session.before.rsplit("\r\n", 1)
> > > +if before[0] == "[PEXPECT]":
> > > +before[0] = ""
> > Unnecessary if prompt was handled in proper way as mentioned above.
> > > +
> > > +return before[0]
> > > +
> > > +def get_output_all(self) -> str:
> > > +output: str = self.session.before
> > > +output.replace("[PEXPECT]", "")
> > Ditto. If session.PROMPT was restored properly, this function would not be
> > necessary at all.
> > > +return output
> > > +
> > > +def close(self, force: bool = False) -> None:
> > > +if force is True:
> > > +self.session.close()
> > > +else:
> > > +if self.isalive():
> > > +self.session.logout()
> > > +
> > > +def isalive(self) -> bool:
> > > +return self.session.isalive()
> > > diff --git a/dts/framework/utils.py b/dts/framework/utils.py new file
> > > mode 100644 index 00..db87349827
> > > --- /dev/null
> > > +++ b/dts/framework/utils.py
> > > @@ -0,0 +1,12 @@
> > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2010-2014
> > > +Intel Corporation # Copyright(c) 2022 PANTHEON.tech s.r.o.
> > > +# Copyright(c) 2022 University of New Hampshire #
> > > +
> > > +def RED(text: str) -> str:
> > > +return f"\u001B[31;1m{str(text)}\u001B[0m"
> > > +
> > > +
> > > +def GREEN(text: str) -> str:
> > > +return f"\u001B[32;1m{str(text)}\u001B[0m"
> > > --
> > > 2.30.2
> > >
> >
> > --
> > Best Regards,
> > Stanislaw Kardach
>
--
Best Regards,
Stanislaw Kardach
.sendline(command)
> +
> +def get_output_before(self) -> str:
The name is missleading. In pxssh terms "before" means all the lines
before the matched expect()/prompt(). Here it returns the last line of
the output. Perhaps get_last_output_line() is better?
> +if not self.isalive():
> +raise SSHSessionDeadException(self.node)
> +before: list[str] = self.session.before.rsplit("\r\n", 1)
> +if before[0] == "[PEXPECT]":
> +before[0] = ""
Unnecessary if prompt was handled in proper way as mentioned above.
> +
> +return before[0]
> +
> +def get_output_all(self) -> str:
> +output: str = self.session.before
> +output.replace("[PEXPECT]", "")
Ditto. If session.PROMPT was restored properly, this function would not
be necessary at all.
> +return output
> +
> +def close(self, force: bool = False) -> None:
> +if force is True:
> +self.session.close()
> +else:
> +if self.isalive():
> +self.session.logout()
> +
> +def isalive(self) -> bool:
> +return self.session.isalive()
> diff --git a/dts/framework/utils.py b/dts/framework/utils.py
> new file mode 100644
> index 00..db87349827
> --- /dev/null
> +++ b/dts/framework/utils.py
> @@ -0,0 +1,12 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2010-2014 Intel Corporation
> +# Copyright(c) 2022 PANTHEON.tech s.r.o.
> +# Copyright(c) 2022 University of New Hampshire
> +#
> +
> +def RED(text: str) -> str:
> +return f"\u001B[31;1m{str(text)}\u001B[0m"
> +
> +
> +def GREEN(text: str) -> str:
> +return f"\u001B[32;1m{str(text)}\u001B[0m"
> --
> 2.30.2
>
--
Best Regards,
Stanislaw Kardach
pport using ssh keys for login rather
> than hard-coded passwords.
>
> /Bruce
The only reason I have mentioned different shells is to illustrate that
prompt might be changed not only due to user modifying PS1 env variable.
I agree with the rest (root-only, bash-only).
--
Best Regards,
Stanislaw Kardach
bug.
2. Different shells use different prompts on different distros. Hence
perhaps there should be a regex here (same as with original_prompt)
and there could be a conf.yaml option to modify it on a per-host
basis?
--
Best Regards,
Stanislaw Kardach
Since the riscv64_linux_gcc was in fact a Ubuntu-specific cross-file,
rename it.
Signed-off-by: Stanislaw Kardach
---
.ci/linux-build.sh | 2 +-
config/riscv/{riscv64_linux_gcc => riscv64_linux_gcc_ubuntu} | 0
devtools/test-meson-builds
PowerPC and ARM.
Signed-off-by: Stanislaw Kardach
---
.github/workflows/build.yml | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index c0d2829d0e..1106256539 100644
--- a/.github/workflows/build.yml
+++ b
Through some mixup all cross-files for PowerPC and ARM platforms were
using C Preprocessor (cpp) instead of GCC (g++).
This caused meson to fail detecting the C++ compiler presence and
therefore disabling some targets (i.e. C++ include file checks).
Signed-off-by: Stanislaw Kardach
---
config
run in
cross-compiled environments:
* PowerPC and ARM cross-files define cpp instead of g++ as C++ compiler.
That's wrong because cpp is a C Preprocessor binary.
* The CI workflow file does not install a g++ cross-compiler.
This patchset fixes both issues.
Stanislaw Kardach (2):
config:
Add more details to the description of a known issue of PMDs not being
usable when --no-huge EAL command line parameter is used. The issue
actually happens whenever there is a need for physical addresses, even
when there is no PMD attached.
Signed-off-by: Stanislaw Kardach
---
doc/guides
There was an extra * in the title of the RISC-V entry. It gets rendered
in the documentation output giving an impression that there will be a
footnote for this entry, which is not the case.
Signed-off-by: Stanislaw Kardach
---
doc/guides/rel_notes/release_22_07.rst | 2 +-
1 file changed, 1
++ test.
Besides, the user's guide for RISC-V cross-compilation recommends the
use of crossbuild-essential-riscv64.
Signed-off-by: Stanislaw Kardach
---
.github/workflows/build.yml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/.github/workflows/build.yml b/.github/work
rte_xmm_t is a union type which wraps around xmm_t and maps its contents
to scalar structures. Since C++ has stricter type conversion rules than
C, the rte_xmm_t::x has to be used instead of C-casting.
Signed-off-by: Stanislaw Kardach
---
lib/eal/riscv/include/rte_vect.h | 4 ++--
1 file
).
Signed-off-by: Stanislaw Kardach
---
lib/lpm/rte_lpm_scalar.h | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/lib/lpm/rte_lpm_scalar.h b/lib/lpm/rte_lpm_scalar.h
index f0d9f37894..161b40ff80 100644
--- a/lib/lpm/rte_lpm_scalar.h
+++ b/lib/lpm/rte_lpm_scalar.h
shion is always correct? All current architectures
define rte_xmm_t in the same manner implying that.
Additionally change RISC-V CI settings to use crossbuild-essential-riscv64
package which provides tools that enable C++ checks.
[1] http://mails.dpdk.org/archives/dev/2022-June/243683.html
Stan
Checks cross-compilation using Ubuntu 20.04 x86.
Signed-off-by: David Marchand
Signed-off-by: Stanislaw Kardach
---
.ci/linux-build.sh | 4
.github/workflows/build.yml | 11 ++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/.ci/linux-build.sh b/.ci/linux
Validate RISC-V compilation when test-meson-builds.sh is called. The
check will be only performed if appropriate toolchain is present on the
system (same as with other architectures).
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
devtools/test-meson
From: Michal Mazurek
Add checks for all flag values defined in the RISC-V misa CSR register.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Michal Mazurek
Signed-off-by: Stanislaw Kardach
---
app/test/test_cpuflags.c | 81
1 file
Add missing em_mask_key() implementation and fix l3fwd_common.h
inclusion in FIB lookup functions to enable the l3fwd to be run on
RISC-V.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
examples/l3fwd/l3fwd_em.c | 8
examples/l3fwd/l3fwd_fib.c
Define the missing __NR_memfd_create syscall id to enable the memif PMD.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
drivers/net/memif/meson.build | 5 -
drivers/net/memif/rte_eth_memif.h | 2 ++
2 files changed, 2 insertions(+), 5 deletions
Define the missing __NR_bpf syscall id to enable the tap PMD.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
drivers/net/tap/meson.build | 5 -
drivers/net/tap/tap_bpf.h | 2 ++
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers
platforms: uio_pci_generic, vfio-pci noiommu and
igb_uio.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
doc/guides/nics/features/ixgbe.ini | 1 +
drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
drivers/net/ixgbe/meson.build | 6 --
3 files changed
ic_thread_fence() used to implement rte_atomic_thread_fence().
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Michal Mazurek
Signed-off-by: Stanislaw Kardach
---
MAINTAINERS | 6 +
app/test/test_xmmt_ops.h | 16 +++
con
cific cpuflags test.
Commits 7-8 add RISC-V build testing to test-meson-builds.sh and github CI.
I appreciate Your comments and feedback.
Best Regards,
Stanislaw Kardach
v4:
- Update RISC-V cross-compilation docs to remove vendor-specific instructions
and better match the Ubuntu enviro
Signed-off-by: Stanislaw Kardach
---
doc/guides/rel_notes/release_22_07.rst | 5
lib/lpm/meson.build| 1 +
lib/lpm/rte_lpm.h | 4 ++-
lib/lpm/rte_lpm_scalar.h | 37 ++
4 files changed, 46 insertions(+), 1
All other rte_lpm_lookup* functions take lpm argument as a const. As the
basic rte_lpm_lookup() performs the same function, it should also do
that.
As this function is inline, no API/ABI change happens.
Signed-off-by: Stanislaw Kardach
Acked-by: Vladimir Medvedkin
Acked-by: Stephen Hemminger
Make sure that ipsec_perf_autotest checks if there are any crypto
devices available before it starts performance testing.
Same test is performed in the ipsec_autotest so it seems prudent to do
it here too to not introduce false failures.
Signed-off-by: Stanislaw Kardach
---
app/test
Checks cross-compilation using Ubuntu 20.04 x86.
Signed-off-by: David Marchand
Signed-off-by: Stanislaw Kardach
---
.ci/linux-build.sh | 4
.github/workflows/build.yml | 11 ++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/.ci/linux-build.sh b/.ci/linux
Validate RISC-V compilation when test-meson-builds.sh is called. The
check will be only performed if appropriate toolchain is present on the
system (same as with other architectures).
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
devtools/test-meson
From: Michal Mazurek
Add checks for all flag values defined in the RISC-V misa CSR register.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Michal Mazurek
Signed-off-by: Stanislaw Kardach
---
app/test/test_cpuflags.c | 81
1 file
Add missing em_mask_key() implementation and fix l3fwd_common.h
inclusion in FIB lookup functions to enable the l3fwd to be run on
RISC-V.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
examples/l3fwd/l3fwd_em.c | 8
examples/l3fwd/l3fwd_fib.c
Define the missing __NR_bpf syscall id to enable the tap PMD.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
drivers/net/tap/meson.build | 5 -
drivers/net/tap/tap_bpf.h | 2 ++
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers
Define the missing __NR_memfd_create syscall id to enable the memif PMD.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
drivers/net/memif/meson.build | 5 -
drivers/net/memif/rte_eth_memif.h | 2 ++
2 files changed, 2 insertions(+), 5 deletions
platforms: uio_pci_generic, vfio-pci noiommu and
igb_uio.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
doc/guides/nics/features/ixgbe.ini | 1 +
drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
drivers/net/ixgbe/meson.build | 6 --
3 files changed
ic_thread_fence() used to implement rte_atomic_thread_fence().
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Michal Mazurek
Signed-off-by: Stanislaw Kardach
---
Depends-on: series-22867 ("test/ring: remove excessive inlining")
Depends-on: series-22868 ("lpm: ad
h and github CI.
I appreciate Your comments and feedback.
Best Regards,
Stanislaw Kardach
v4:
- Update RISC-V cross-compilation docs to remove vendor-specific instructions
and better match the Ubuntu environment.
- Remove optional "fence" removal in the CYCLE and TIME c
Signed-off-by: Stanislaw Kardach
---
doc/guides/rel_notes/release_22_07.rst | 5
lib/lpm/meson.build| 1 +
lib/lpm/rte_lpm.h | 4 ++-
lib/lpm/rte_lpm_scalar.h | 40 ++
4 files changed, 49 insertions(+), 1
All other rte_lpm_lookup* functions take lpm argument as a const. As the
basic rte_lpm_lookup() performs the same function, it should also do
that.
As this function is inline, no API/ABI change happens.
Signed-off-by: Stanislaw Kardach
---
lib/lpm/rte_lpm.h | 2 +-
1 file changed, 1 insertion
Signed-off-by: Stanislaw Kardach
---
doc/guides/rel_notes/release_22_07.rst | 5
lib/lpm/meson.build| 1 +
lib/lpm/rte_lpm.h | 4 ++-
lib/lpm/rte_lpm_scalar.h | 36 ++
4 files changed, 45 insertions(+), 1
All other rte_lpm_lookup* functions take lpm argument as a const. As the
basic rte_lpm_lookup() performs the same function, it should also do
that.
As this function is inline, no API/ABI change happens.
Signed-off-by: Stanislaw Kardach
---
lib/lpm/rte_lpm.h | 2 +-
1 file changed, 1 insertion
on to force inlining as the test code works
perfectly fine without it.
GCC has a bug report for a similar case (with conditionals):
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93062
Fixes: a9fe152363 test/ring: add custom element size functional tests
Signed-off-by: Stanislaw Kardach
---
app
l.com
Signed-off-by: Stanislaw Kardach
---
v2: Replace existing logic with rfc1812_process().
---
examples/l3fwd/l3fwd_lpm.c | 24 ++--
1 file changed, 6 insertions(+), 18 deletions(-)
diff --git a/examples/l3fwd/l3fwd_lpm.c b/examples/l3fwd/l3fwd_lpm.c
index bec22c44cd..7a1
Checks cross-compilation using Ubuntu 20.04 x86.
Signed-off-by: David Marchand
Signed-off-by: Stanislaw Kardach
---
.ci/linux-build.sh | 4
.github/workflows/build.yml | 11 ++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/.ci/linux-build.sh b/.ci/linux
Validate RISC-V compilation when test-meson-builds.sh is called. The
check will be only performed if appropriate toolchain is present on the
system (same as with other architectures).
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
devtools/test-meson
From: Michal Mazurek
Add checks for all flag values defined in the RISC-V misa CSR register.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Michal Mazurek
Signed-off-by: Stanislaw Kardach
---
app/test/test_cpuflags.c | 81
1 file
Add missing em_mask_key() implementation and fix l3fwd_common.h
inclusion in FIB lookup functions to enable the l3fwd to be run on
RISC-V.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
examples/l3fwd/l3fwd_em.c | 8
examples/l3fwd/l3fwd_fib.c
Define the missing __NR_bpf syscall id to enable the tap PMD.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
drivers/net/tap/meson.build | 5 -
drivers/net/tap/tap_bpf.h | 2 ++
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers
Define the missing __NR_memfd_create syscall id to enable the memif PMD.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
drivers/net/memif/meson.build | 5 -
drivers/net/memif/rte_eth_memif.h | 2 ++
2 files changed, 2 insertions(+), 5 deletions
platforms: uio_pci_generic, vfio-pci noiommu and
igb_uio.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
doc/guides/nics/features/ixgbe.ini | 1 +
drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
drivers/net/ixgbe/meson.build | 6 --
3 files changed
e compiler attribute used in rte_vect.h directly.
- rte_*mb() used directly in rte_atomic.h to reduce code duplication.
- __atomic_thread_fence() used to implement rte_atomic_thread_fence().
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Michal Mazurek
Signed-off-by: Stanislaw Kardach
-
h and github CI.
I appreciate Your comments and feedback.
Best Regards,
Stanislaw Kardach
v3:
- Limit test-meson-builds.sh testing to a generic rv64gc configuration.
Previous version was missing this change by mistake.
v2:
- Separate bug-fixes into separate series.
- Prevent RV64_CSRR
Checks cross-compilation using Ubuntu 20.04 x86.
Signed-off-by: David Marchand
Signed-off-by: Stanislaw Kardach
---
.ci/linux-build.sh | 4
.github/workflows/build.yml | 11 ++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/.ci/linux-build.sh b/.ci/linux
Validate RISC-V compilation when test-meson-builds.sh is called. The
check will be only performed if appropriate toolchain is present on the
system (same as with other architectures).
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
devtools/test-meson
From: Michal Mazurek
Add checks for all flag values defined in the RISC-V misa CSR register.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Michal Mazurek
Signed-off-by: Stanislaw Kardach
---
app/test/test_cpuflags.c | 81
1 file
Add missing em_mask_key() implementation and fix l3fwd_common.h
inclusion in FIB lookup functions to enable the l3fwd to be run on
RISC-V.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
examples/l3fwd/l3fwd_em.c | 8
examples/l3fwd/l3fwd_fib.c
Define the missing __NR_bpf syscall id to enable the tap PMD.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
drivers/net/tap/meson.build | 5 -
drivers/net/tap/tap_bpf.h | 2 ++
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers
Define the missing __NR_memfd_create syscall id to enable the memif PMD.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
drivers/net/memif/meson.build | 5 -
drivers/net/memif/rte_eth_memif.h | 2 ++
2 files changed, 2 insertions(+), 5 deletions
platforms: uio_pci_generic, vfio-pci noiommu and
igb_uio.
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Stanislaw Kardach
---
doc/guides/nics/features/ixgbe.ini | 1 +
drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
drivers/net/ixgbe/meson.build | 6 --
3 files changed
e compiler attribute used in rte_vect.h directly.
- rte_*mb() used directly in rte_atomic.h to reduce code duplication.
- __atomic_thread_fence() used to implement rte_atomic_thread_fence().
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
Signed-off-by: Michal Mazurek
Signed-off-by: Stanislaw Kardach
-
h and github CI.
I appreciate Your comments and feedback.
Best Regards,
Stanislaw Kardach
v2:
- Separate bug-fixes into separate series.
- Prevent RV64_CSRR leak to API users.
- Limit test-meson-builds.sh testing to a generic rv64gc configuration.
- Clean-up release notes and fix style i
gavat...@marvell.com
Signed-off-by: Stanislaw Kardach
---
examples/l3fwd/l3fwd_lpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/l3fwd/l3fwd_lpm.c b/examples/l3fwd/l3fwd_lpm.c
index bec22c44cd..6e1defbf7f 100644
--- a/examples/l3fwd/l3fwd_lpm.c
+++ b/exampl
Signed-off-by: Stanislaw Kardach
---
doc/guides/rel_notes/release_22_07.rst | 5 +
lib/lpm/meson.build| 1 +
lib/lpm/rte_lpm.h | 4 +-
lib/lpm/rte_lpm_scalar.h | 122 +
4 files changed, 131 insertions(+), 1
on to force inlining as the test code works
perfectly fine without it.
Fixes: a9fe152363 test/ring: add custom element size functional tests
Signed-off-by: Stanislaw Kardach
---
app/test/test_ring.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test/test_ring.h
;)
Signed-off-by: Stanislaw Kardach
---
app/test/test_hash_readwrite.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/app/test/test_hash_readwrite.c b/app/test/test_hash_readwrite.c
index 9b192f2b5e..6373e62d33 100644
--- a/app/test/test_hash_readwrite.c
+++
")
Cc: yipeng1.w...@intel.com
Signed-off-by: Stanislaw Kardach
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
---
app/test/test_hash_readwrite.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/app/test/test_hash_readwrite.c b/app/test/test_hash_readwrite.c
index
Validate RISC-V compilation when test-meson-builds.sh is called. The
check will be only performed if appropriate toolchain is present on the
system (same as with other architectures).
Signed-off-by: Stanislaw Kardach
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
---
devtools/test-meson
loops with ring enqueue/dequeue and it seems to be caused by excessive
__rte_always_inline usage. ring perf test compiles just fine under
debug.
To work around this, disable the offending tests in debug mode.
Signed-off-by: Stanislaw Kardach
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grov
From: Michal Mazurek
Add checks for all flag values defined in the RISC-V misa CSR register.
Signed-off-by: Michal Mazurek
Signed-off-by: Stanislaw Kardach
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
---
app/test/test_cpuflags.c | 81
1 file
Add missing em_mask_key() implementation and fix l3fwd_common.h
inclusion in FIB lookup functions to enable the l3fwd to be run on
RISC-V.
Signed-off-by: Stanislaw Kardach
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
---
examples/l3fwd/l3fwd_em.c | 8
examples/l3fwd/l3fwd_fib.c
Define the missing __NR_bpf syscall id to enable the tap PMD.
Signed-off-by: Stanislaw Kardach
---
drivers/net/tap/meson.build | 5 -
drivers/net/tap/tap_bpf.h | 2 ++
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.build
Define the missing __NR_memfd_create syscall id to enable the memif PMD.
Signed-off-by: Stanislaw Kardach
---
drivers/net/memif/meson.build | 5 -
drivers/net/memif/rte_eth_memif.h | 2 ++
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/memif/meson.build b
).
Signed-off-by: Michal Mazurek
Signed-off-by: Stanislaw Kardach
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
---
MAINTAINERS | 6 +
app/test/test_xmmt_ops.h | 16 ++
config/meson.build| 2 +
co
platforms: uio_pci_generic, vfio-pci noiommu and
igb_uio.
Signed-off-by: Stanislaw Kardach
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
---
doc/guides/nics/features/ixgbe.ini | 1 +
drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
drivers/net/ixgbe/meson.build | 6 --
3 files changed
gavat...@marvell.com
Signed-off-by: Stanislaw Kardach
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
---
examples/l3fwd/l3fwd_lpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/l3fwd/l3fwd_lpm.c b/examples/l3fwd/l3fwd_lpm.c
index bec22c44cd..6e1defbf7f 100644
From: Michal Mazurek
Add an implementation of the rte_lpm_lookupx4() function for platforms
without support for vector operations.
Signed-off-by: Michal Mazurek
Signed-off-by: Stanislaw Kardach
Sponsored-by: Frank Zhao
Sponsored-by: Sam Grove
---
doc/guides/rel_notes/release_22_07.rst
Your comments and feedback.
Best Regards,
Stanislaw Kardach
NOTE: This work was sponsored by StarFive and SiFive which is signified by
"Sponsored-by:" sign-offs in each commit message. After discussing it
with Thomas Monjalon it seemed a better choice than "Suggested-by"
On Fri, Jun 04, 2021 at 04:15:58PM +0200, Stanislaw Kardach wrote:
> Please let me know if I'm missing a bigger picture with the --no-huge
> and --no-shconf usage on non-FreeBSD platforms.
>
After looking at this issue again I'm abandoning this patchset because
it seems wron
When -n argument became optional, the test logic was fixed (by
1e0b51fd4) but the comment indicating why --no-huge and --no-shconf are
used was not changed.
Today those flags are used for compatibility with FreeBSD (see
b5d878e6d), so change the comment to reflect that.
Signed-off-by: Stanislaw
of no_huge which don't actually test
the no-huge logic with a execution environment conditional
no_huge_compat to indicate that it is passed as a compatibility flag,
not as a requirement for a test itself.
Signed-off-by: Stanislaw Kardach
Fixes: b5d878e6db56 ("test: fix EAL flags a
port initialized
TELEMETRY: No legacy callbacks, legacy socket not created
APP: HPET is not enabled, using TSC as default timer
RTE>>
This commit finishes the above test early with SKIP status to signify
that no-huge support is simply not available.
Signed-off-by: Stanislaw Kardach
---
app/te
conf usage on non-FreeBSD platforms.
I'm not adding sta...@dpdk.org on purpose as this does not affect any
current platform I'm aware of (at least in a production scenario).
---
V2:
- Fix checkpatch errors
- Add affected platform in the cover letter.
Stanislaw Kardach (3):
test: disab
On Thu, May 06, 2021 at 04:25:22PM +0200, Michal Krawczyk wrote:
> From: Stanislaw Kardach
>
> Make sure the same random generated RSS key is available to all ENA PMD
> instances in all processes.
>
> Signed-off-by: Stanislaw Kardach
> Reviewed-by: Michal Krawczyk
> Re
On Sun, May 09, 2021 at 02:41:18PM +0100, Ferruh Yigit wrote:
> On 5/7/2021 6:18 PM, Stanislaw Kardach wrote:
> > On Fri, May 07, 2021 at 05:48:50PM +0100, Ferruh Yigit wrote:
> >> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> >>> From: Stanislaw Kardach
> >
On Fri, May 07, 2021 at 05:48:50PM +0100, Ferruh Yigit wrote:
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > From: Stanislaw Kardach
> >
> > Introduce a memory area for ENA driver shared between all the processes
> > of a same prefix (memzone backed).
> > Mo
h->tuple_len - 1 - j);
> - }
> + tmp_len = RTE_MIN(sizeof(uint32_t) * CHAR_BIT,
> + h->tuple_len - ctx->reta_sz_log);
> + offset -= tmp_len;
> + tmp = read_unaligned_bits(tuple, tmp_len,
> + offset);
> + tmp++;
> + tmp &= (1 << tmp_len) - 1;
> + write_unaligned_bits(tuple, tmp_len, offset,
> + tmp);
> }
> } else
> return 0;
> --
> 2.7.4
>
Makes the issue not visible on both x86 and RISC-V.
Tested-by: Stanislaw Kardach
Reviewed-by: Stanislaw Kardach
--
Best Regards,
Stanislaw Kardach
ior to the test?
I haven't analyzed the code in-depth but it seems that the
rte_thash_add_helper() also uses a random lfsr which is then used in the
subkey generation. Could this contribute to the randomness of the issue?
--
Best Regards,
Stanislaw Kardach
lack of
definition in rte_xmm_t semantics. Because once it's in an example,
people may start assuming it's OK to use it this way.
If it is OK, then I'll just post a patch, otherwise we need a separate
discussion.
--
Best Regards,
Stanislaw Kardach
idea on how to solve this
yet and I would not like to hijack this discussion with vector stuff.
Though I may be missing some obvious solution here. Any idea is welcome.
:)
--
Best Regards,
Stanislaw Kardach
at the top of l3fwd_em.c, here:
http://git.dpdk.org/dpdk/tree/examples/l3fwd/l3fwd_em.c#n218
#if defined(__SSE2__)
...
#else
#error No vector engine (SSE, NEON, ALTIVEC) available, check your toolchain
#endif
--
Best Regards,
Stanislaw Kardach
issue.
Lukasz Wojciechowski reproduced the same issue on x86 using a VM with 32
emulated CPU cores to force some lcores not to be woken up.
Fixes: 7c3287a10535 ("test/distributor: add performance test for burst mode")
Cc: David Marchand
Signed-off-by: Stanislaw Kardach
Acked-by: David
;test/distributor: fix quitting workers in burst
mode").
Fixes: c3eabff124e6 ("distributor: add unit tests")
Cc: bruce.richard...@intel.com
Signed-off-by: Stanislaw Kardach
Acked-by: David Hunt
Tested-by: Lukasz Wojciechowski
Reviewed-by: Lukasz Wojciechowski
---
app/test/test_di
not observed, the change is in
line with the functional tests.
---
RFC -> V2
- Split 2 fixes into separate patches.
- Added review/test/ack tags from the RFC discussion.
---
Stanislaw Kardach (2):
test/distributor: fix worker notification in burst
test/distributor: fix burst flush
they won't
be spread over all the workers.
Signed-off-by: Stanislaw Kardach
Fixes: 7c3287a10535 ("test/distributor: add performance test for burst mode")
Cc: david.h...@intel.com
Cc: l.wojciec...@partner.samsung.com
Cc: David Marchand
---
app/test/test_distributor_perf.c | 6 -
When -n argument became optional, the test logic was fixed (by
1e0b51fd4) but the comment indicating why --no-huge and --no-shconf are
used was not changed.
Today those flags are used for compatibility with FreeBSD (see
b5d878e6d), so change the comment to reflect that.
Signed-off-by: Stanislaw
patch doesn't change that to not add confusion.
Signed-off-by: Stanislaw Kardach
Fixes: b5d878e6db56 ("test: fix EAL flags autotest on FreeBSD")
Cc: sta...@dpdk.org
---
app/test/test_eal_flags.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(
used
with --no-shconf to increase the compatibility with FreeBSD. That is if
I'm not missing a bigger picture of using the --no-huge with --no-shconf
on non-FreeBSD platforms.
Stanislaw Kardach (3):
test: disable no-huge test with PA IOVA
test: disable no-huge where it's not necessar
PP: HPET is not enabled, using TSC as default timer
RTE>>
This commit finishes the above test early with SKIP status to signify
that no-huge support is simply not available.
Signed-off-by: Stanislaw Kardach
Cc: sta...@dpdk.org
---
app/test/test_eal_flags.c | 9 +
1 file changed, 9
1 - 100 of 104 matches
Mail list logo