[PATCH] test/security: skip IPsec post process for negative tests

2024-10-03 Thread Srujana Challa
Skips calling test_ipsec_post_process for negative inline IPsec tests as received packet might not be valid for a negative case. Signed-off-by: Srujana Challa --- app/test/test_cryptodev_security_ipsec.c | 1 + app/test/test_security_inline_proto.c| 25 +++- 2 files

[PATCH v1] Revert "doc: extension of crypto event callback announced"

2024-08-01 Thread Srujana Challa
the `qp_id` parameter to the `rte_cryptodev_cb_fn` function unnecessary, and as such, the proposed extension is no longer required. Signed-off-by: Srujana Challa --- doc/guides/rel_notes/deprecation.rst | 5 - 1 file changed, 5 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst

[PATCH] Revert "doc: extension of crypto event callback announced"

2024-08-01 Thread Srujana Challa
the `qp_id` parameter to the `rte_cryptodev_cb_fn` function unnecessary, and as such, the proposed extension is no longer required. Signed-off-by: Srujana Challa --- doc/guides/rel_notes/deprecation.rst | 5 - 1 file changed, 5 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst

[PATCH v3] net/virtio_user: fix cq descriptor conversion with non vDPA backend

2024-07-12 Thread Srujana Challa
eported-by: David Marchand Signed-off-by: Srujana Challa --- v3: - Addressed the review comments from David Marchand. v2: - Added Reported-by tag. .../net/virtio/virtio_user/virtio_user_dev.c | 20 +-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/

RE: [EXTERNAL] Re: [PATCH v2] net/virtio_user: fix issue with converting cq descriptor IOVA address to VA

2024-07-12 Thread Srujana Challa
> On Thu, Jul 11, 2024 at 7:46 PM Srujana Challa wrote: > > > -virtio_user_iova2virt(rte_iova_t iova) > > > +virtio_user_iova2virt(struct virtio_user_dev *dev, rte_iova_t iova) > > > > > > > { > > > > - if (rte_eal_iova_mode(

RE: [EXTERNAL] Re: [PATCH v2] net/virtio_user: fix issue with converting cq descriptor IOVA address to VA

2024-07-11 Thread Srujana Challa
> On Thu, Jul 11, 2024 at 2:44 PM Srujana Challa wrote: > > > > This patch modifies the code to convert descriptor buffer IOVA > > addresses to virtual addresses only when use_va flag is false. > > > > This patch resolves a segmentation fault with the vhost-user b

[PATCH v2] net/virtio_user: fix issue with converting cq descriptor IOVA address to VA

2024-07-11 Thread Srujana Challa
irtio_user: convert cq descriptor IOVA address to Virtual address")' Reported-by: David Marchand Signed-off-by: Srujana Challa --- v2: - Added Reported-by tag. .../net/virtio/virtio_user/virtio_user_dev.c | 28 +++ 1 file changed, 16 insertions(+), 12 deletions(-)

[PATCH dpdk-next-virtio] net/virtio_user: fix issue with converting cq descriptor IOVA address to VA

2024-07-11 Thread Srujana Challa
This patch modifies the code to convert descriptor buffer IOVA addresses to virtual addresses only when use_va flag is false. 'Fixes: 67e9e504dae2 ("net/virtio_user: convert cq descriptor IOVA address to Virtual address")' Signed-off-by: Srujana Challa --- .../ne

RE: [EXTERNAL] Re: [PATCH v3 1/3] net/virtio_user: convert cq descriptor IOVA address to Virtual address

2024-07-11 Thread Srujana Challa
> Hello Srujana, Jerin, > > On Wed, Jul 3, 2024 at 12:04 PM Srujana Challa > wrote: > > > > This patch modifies the code to convert descriptor buffer IOVA > > addresses to virtual addresses during the processing of shadow control > > queue when IOVA mode is PA

[PATCH v3 3/3] net/virtio_user: support sharing vq descriptor IOVA to the backend

2024-07-03 Thread Srujana Challa
Adds support to share descriptor IOVA to the vhost backend. This makes virtio_user driver works in IOVA as PA mode when use_va flag is disabled. This patch also disables use_va flag for VDPA backend. Signed-off-by: Srujana Challa --- .../net/virtio/virtio_user/virtio_user_dev.c | 26

[PATCH v3 2/3] net/virtio: store desc IOVA address in vring data structure

2024-07-03 Thread Srujana Challa
Stores desc IOVA in the queue's vring data structure, as preliminary work to provide a way for Virtio-user to share desc IOVA to the vhost backend. Signed-off-by: Srujana Challa --- drivers/net/virtio/virtio_ring.h | 12 drivers/net/virtio/virtqueue.c | 4 ++-- 2 files ch

[PATCH v3 1/3] net/virtio_user: convert cq descriptor IOVA address to Virtual address

2024-07-03 Thread Srujana Challa
This patch modifies the code to convert descriptor buffer IOVA addresses to virtual addresses during the processing of shadow control queue when IOVA mode is PA. This change enables Virtio-user to operate with IOVA as the descriptor buffer address. Signed-off-by: Srujana Challa --- .../net

[PATCH v3 0/3] net/virtio: support IOVA as PA mode for vDPA backend

2024-07-03 Thread Srujana Challa
VDPA backend type. v1->v2: - Split single patch into three patches. v2->v3: - Addressed the review comment by using rte_mem_iova2virt() for desc address translation. Srujana Challa (3): net/virtio_user: convert cq descriptor IOVA address to Virtual address net/virtio: store desc IOVA addr

RE: [EXTERNAL] Re: [PATCH v2 1/3] net/virtio_user: avoid cq descriptor buffer address accessing

2024-07-02 Thread Srujana Challa
> On 2/29/24 14:29, Srujana Challa wrote: > > This patch makes changes to avoid descriptor buffer address accessing > > while processing shadow control queue. > > So that Virtio-user can work with having IOVA as descriptor buffer > > address. > >

RE: [PATCH v2 0/3] net/virtio: support IOVA as PA mode for vDPA backend

2024-06-19 Thread Srujana Challa
t; Second and third patches helps to share descriptor IOVA address, to the vhost > backend. And also disables the use_va flag for VDPA backend type. > > v1->v2: > - Split single patch into three patches. > > Srujana Challa (3): > net/virtio_user: avoid cq descriptor buffe

[PATCH v2 3/3] net/virtio_user: support sharing vq descriptor IOVA to the backend

2024-02-29 Thread Srujana Challa
Adds support to share descriptor IOVA to the vhost backend. This makes virtio_user driver works in IOVA as PA mode when use_va flag is disabled. This patch also disables use_va flag for VDPA backend. Signed-off-by: Srujana Challa --- .../net/virtio/virtio_user/virtio_user_dev.c | 26

[PATCH v2 2/3] net/virtio: store desc IOVA address in vring data structure

2024-02-29 Thread Srujana Challa
Stores desc IOVA in the queue's vring data structure, as preliminary work to provide a way for Virtio-user to share desc IOVA to the vhost backend. Signed-off-by: Srujana Challa --- drivers/net/virtio/virtio_ring.h | 12 drivers/net/virtio/virtqueue.c | 4 ++-- 2 files ch

[PATCH v2 1/3] net/virtio_user: avoid cq descriptor buffer address accessing

2024-02-29 Thread Srujana Challa
This patch makes changes to avoid descriptor buffer address accessing while processing shadow control queue. So that Virtio-user can work with having IOVA as descriptor buffer address. Signed-off-by: Srujana Challa --- .../net/virtio/virtio_user/virtio_user_dev.c | 68 +-- 1

[PATCH v2 0/3] net/virtio: support IOVA as PA mode for vDPA backend

2024-02-29 Thread Srujana Challa
VDPA backend type. v1->v2: - Split single patch into three patches. Srujana Challa (3): net/virtio_user: avoid cq descriptor buffer address accessing net/virtio: store desc IOVA address in vring data structure net/virtio_user: support sharing vq descriptor IOVA to the backend drivers/

RE: [EXT] Re: [PATCH] net/virtio-user: support IOVA as PA mode for vDPA backend

2024-02-27 Thread Srujana Challa
> Subject: [EXT] Re: [PATCH] net/virtio-user: support IOVA as PA mode for vDPA > backend > > External Email > > -- > Hi Srujana, > > On 2/27/24 06:56, Srujana Challa wrote: > > Disable use_

[PATCH] net/virtio-user: support IOVA as PA mode for vDPA backend

2024-02-26 Thread Srujana Challa
Disable use_va flag for VDPA backend type and fixes the issues with shadow control command processing, when it is disabled. This will help to make virtio user driver works in IOVA as PA mode for vDPA backend. Signed-off-by: Srujana Challa --- drivers/net/virtio/virtio_ring.h | 12

[PATCH] net/virtio-user: support IOVA as PA mode for vDPA backend

2024-02-26 Thread Srujana Challa
Disable use_va flag for VDPA backend type and fixes the issues with shadow control command processing, when it is disabled. This will help to make virtio user driver works in IOVA as PA mode for vDPA backend. Signed-off-by: Srujana Challa --- drivers/net/virtio/virtio_ring.h | 12

[PATCH] net/virtio-user: support IOVA as PA mode for vDPA backend

2024-02-26 Thread Srujana Challa
Disable use_va flag for VDPA backend type and fixes the issues with shadow control command processing, when it is disabled. This will help to make virtio user driver works in IOVA as PA mode for vDPA backend. Signed-off-by: Srujana Challa --- drivers/net/virtio/virtio_ring.h | 12

[PATCH v2 1/2] net/virtio-user: improve kick performance with notification area mapping

2024-01-23 Thread Srujana Challa
the kick performance. Signed-off-by: Srujana Challa --- drivers/net/virtio/virtio_user/vhost.h| 2 + drivers/net/virtio/virtio_user/vhost_vdpa.c | 68 +++ .../net/virtio/virtio_user/virtio_user_dev.c | 43 ++-- .../net/virtio/virtio_user/virtio_user_dev.h | 2

[PATCH v2 2/2] net/virtio-user: add VIRTIO_NET_F_RSS to supported features

2024-01-23 Thread Srujana Challa
: Srujana Challa --- .../net/virtio/virtio_user/virtio_user_dev.c | 31 ++- .../net/virtio/virtio_user/virtio_user_dev.h | 2 ++ drivers/net/virtio/virtio_user_ethdev.c | 3 ++ 3 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user

RE: [EXT] Re: [PATCH 2/2] net/virtio-user: add VIRTIO_NET_F_RSS to supported features

2024-01-22 Thread Srujana Challa
> Hi, > > On 12/8/23 06:31, Srujana Challa wrote: > > This patch introduces new function to get rss device config and adds > > code to forward the RSS control command to backend through hw control > > queue if RSS feature is negotiated. > > This patch will h

RE: [EXT] Re: [PATCH 1/2] net/virtio-user: improve kick performance with notification area mapping

2024-01-22 Thread Srujana Challa
> Hi Srujana, > > Thanks for your contribution! > Is it possible to provide information on which hardware it can be tested on? It can be tested on Marvell's Octeon DPU. > > On 12/8/23 06:31, Srujana Challa wrote: > > This patch introduces new virtio-user callback t

RE: [EXT] [PATCH 2/2] net/virtio-user: add VIRTIO_NET_F_RSS to supported features

2024-01-02 Thread Srujana Challa
lp to negotiate VIRTIO_NET_F_RSS feature if vhost-vdpa > backend supports RSS in HW. > > Signed-off-by: Srujana Challa > --- > .../net/virtio/virtio_user/virtio_user_dev.c | 31 ++- > .../net/virtio/virtio_user/virtio_user_dev.h | 2 ++ > drivers/net/virtio/vir

[PATCH 2/2] net/virtio-user: add VIRTIO_NET_F_RSS to supported features

2023-12-07 Thread Srujana Challa
: Srujana Challa --- .../net/virtio/virtio_user/virtio_user_dev.c | 31 ++- .../net/virtio/virtio_user/virtio_user_dev.h | 2 ++ drivers/net/virtio/virtio_user_ethdev.c | 3 ++ 3 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user

[PATCH 1/2] net/virtio-user: improve kick performance with notification area mapping

2023-12-07 Thread Srujana Challa
is disabled, also update corresponding unsupported feature bit. And also adds code to write to queue notify address in notify callback. This will help in increasing the kick performance. Signed-off-by: Srujana Challa --- doc/guides/nics/virtio.rst| 5 ++ drivers/net/virtio

[PATCH 2/2] net/virtio-user: add VIRTIO_NET_F_RSS to supported features

2023-12-07 Thread Srujana Challa
: Srujana Challa --- .../net/virtio/virtio_user/virtio_user_dev.c | 31 ++- .../net/virtio/virtio_user/virtio_user_dev.h | 2 ++ drivers/net/virtio/virtio_user_ethdev.c | 3 ++ 3 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user

[PATCH 1/2] net/virtio-user: improve kick performance with notification area mapping

2023-12-07 Thread Srujana Challa
is disabled, also update corresponding unsupported feature bit. And also adds code to write to queue notify address in notify callback. This will help in increasing the kick performance. Signed-off-by: Srujana Challa --- doc/guides/nics/virtio.rst| 5 ++ drivers/net/virtio

[PATCH v2] event/cnxk: fix LMTST write for single event mode

2023-05-31 Thread Srujana Challa
LMTST area can be overwritten before read by HW between to consecutive steorl operations. Hence, add wmb() after steorl op to make sure the LMTST operation is complete. Fixes: 313e884a22fd ("event/cnxk: support Tx adapter fast path") Cc: pbhagavat...@marvell.com Signed-off-by: Sruj

[PATCH] event/cnxk: add wmb after steorl for event mode

2023-05-30 Thread Srujana Challa
LMTST area can be overwritten before read by HW between to consecutive steorl operations. Hence, add wmb() after steorl op to make sure the lmtst operation is complete. Signed-off-by: Srujana Challa --- drivers/event/cnxk/cn10k_tx_worker.h | 8 +++- 1 file changed, 3 insertions(+), 5

[PATCH] event/cnxk: add wmb after steorl for event mode

2023-05-30 Thread Srujana Challa
From: Author Srujana Challa LMTST area can be overwritten before read by HW between to consecutive steorl operations. Hence, add wmb() after steorl op to make sure the lmtst operation is complete. Signed-off-by: Srujana Challa --- drivers/event/cnxk/cn10k_tx_worker.h | 8 +++- 1 file

[PATCH] event/cnxk: add wmb after steorl for event mode

2023-05-30 Thread Srujana Challa
From: Author Srujana Challa LMTST area can be overwritten before read by HW between to consecutive steorl operations. Hence, add wmb() after steorl op to make sure the lmtst operation is complete. Signed-off-by: Srujana Challa Change-Id: Ib16d7cd88cff79e9ca78eff8c47b7ddad2d234dd Reviewed-on

RE: [PATCH 4/4] crypto/cnxk: add error interrupt event query handler

2023-01-30 Thread Srujana Challa
eue pair ID with pending error > > interrupt event if any, starting from the given queue pair index, for > > the device. > > > > Signed-off-by: Srujana Challa > The patch description do not match with the API added. > Can you please update it? > Adds RTE_CRYPTODEV_

[PATCH 4/4] crypto/cnxk: add error interrupt event query handler

2022-12-21 Thread Srujana Challa
Adds RTE_CRYPTODEV_EVENT_ERROR query handler for cn9k/cn10k PMD. The query handler finds the next queue pair ID with pending error interrupt event if any, starting from the given queue pair index, for the device. Signed-off-by: Srujana Challa --- drivers/common/cnxk/roc_cpt.c | 4

[PATCH 3/4] cryptodev: introduce query API for error interrupt event

2022-12-21 Thread Srujana Challa
An event RTE_CRYPTODEV_EVENT_ERROR gets fired when crypto PMD receives an error interrupt. This patch adds query function for the application, to get more info about the event. Signed-off-by: Srujana Challa --- lib/cryptodev/cryptodev_pmd.h | 9 + lib/cryptodev/rte_cryptodev.c | 19

[PATCH 2/4] crypto/cnxk: add callback to report CPT HW error

2022-12-21 Thread Srujana Challa
Adds and register callback to report CPT MISC error interrupts to the application using rte_cryptodev_pmd_callback_process. Signed-off-by: Srujana Challa --- drivers/crypto/cnxk/cnxk_cryptodev.c | 12 drivers/crypto/cnxk/cnxk_cryptodev.h | 1 + drivers/crypto/cnxk

[PATCH 1/4] common/cnxk: add CPT HW error callback register functions

2022-12-21 Thread Srujana Challa
Adds functions to register callback API to report CPT_MISC_INT to the driver. Signed-off-by: Srujana Challa --- drivers/common/cnxk/roc_cpt.c | 31 +++ drivers/common/cnxk/roc_cpt.h | 8 +++- drivers/common/cnxk/version.map | 2 ++ 3 files changed, 40

[PATCH 3/4] cryptodev: introduce query API for error interrupt event

2022-12-21 Thread Srujana Challa
An event RTE_CRYPTODEV_EVENT_ERROR gets fired when crypto PMD receives an error interrupt. This patch adds query function for the application, to get more info about the event. Signed-off-by: Srujana Challa --- lib/cryptodev/cryptodev_pmd.h | 9 + lib/cryptodev/rte_cryptodev.c | 19

[PATCH 2/4] crypto/cnxk: add callback to report CPT HW error

2022-12-21 Thread Srujana Challa
Adds and register callback to report CPT MISC error interrupts to the application using rte_cryptodev_pmd_callback_process. Signed-off-by: Srujana Challa --- drivers/crypto/cnxk/cnxk_cryptodev.c | 12 drivers/crypto/cnxk/cnxk_cryptodev.h | 1 + drivers/crypto/cnxk

[PATCH 1/4] common/cnxk: add CPT HW error callback register functions

2022-12-21 Thread Srujana Challa
Adds functions to register callback API to report CPT_MISC_INT to the driver. Signed-off-by: Srujana Challa --- drivers/common/cnxk/roc_cpt.c | 32 drivers/common/cnxk/roc_cpt.h | 8 +++- drivers/common/cnxk/version.map | 2 ++ 3 files changed, 41

[PATCH 4/4] crypto/cnxk: add error interrupt event query handler

2022-12-21 Thread Srujana Challa
Adds RTE_CRYPTODEV_EVENT_ERROR query handler for cn9k/cn10k PMD. The query handler finds the next queue pair ID with pending error interrupt event if any, starting from the given queue pair index, for the device. Signed-off-by: Srujana Challa --- drivers/common/cnxk/roc_cpt.c | 4

RE: [EXT] Re: [RFC PATCH] cryptodev: add return parameter to callback process API

2022-09-19 Thread Srujana Challa
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, July 17, 2022 4:17 PM > To: Akhil Goyal ; Srujana Challa > > Cc: roy.fan.zh...@intel.com; dev@dpdk.org; Jerin Jacob Kollanukkaran > ; Nithin Kumar Dabilpuram > ; Anoob Joseph ; > david.march..

[PATCH] security: remove get_userdata function pointer

2022-08-12 Thread Srujana Challa
Removes get_userdata function pointer as it is being unused and make fast accessing method that uses dynamic field to get userdata as default for optimizing security path. Signed-off-by: Srujana Challa --- app/test/test_security.c | 166 --- doc/guides/nics

[PATCH] common/cnxk: add CPT LF reset sequence

2022-08-11 Thread Srujana Challa
Adds code to reset CPT LF as part of cpt_lf_fini. Signed-off-by: Srujana Challa --- drivers/common/cnxk/roc_cpt.c | 82 ++ drivers/common/cnxk/roc_mbox.h | 6 +++ 2 files changed, 88 insertions(+) diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common

[PATCH] doc: announce change to cryptodev cb function prototype

2022-06-24 Thread Srujana Challa
Function rte_cryptodev_cb_fn prototype will be extended to add new parameter qp_id, to return queue pair ID, which got error interrupt to the application, so that application can reset that particular queue pair. https://mails.dpdk.org/archives/dev/2022-June/245428.html Signed-off-by: Srujana

[RFC PATCH] cryptodev: add return parameter to callback process API

2022-06-24 Thread Srujana Challa
the queue back to normal state. Signed-off-by: Srujana Challa --- lib/cryptodev/cryptodev_pmd.h | 3 ++- lib/cryptodev/rte_cryptodev.c | 8 lib/cryptodev/rte_cryptodev.h | 9 ++--- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib

[RFC PATCH] cryptodev: add return parameter to callback process API

2022-06-24 Thread Srujana Challa
the queue back to normal state. Signed-off-by: Srujana Challa Change-Id: I423c4fd6b8c3d910c60e3a6d4f17534756299213 --- lib/cryptodev/cryptodev_pmd.h | 3 ++- lib/cryptodev/rte_cryptodev.c | 8 lib/cryptodev/rte_cryptodev.h | 9 ++--- 3 files changed, 12 insertions(+), 8 deletions(-) di

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: add support for event vector

2021-09-14 Thread Srujana Challa
. Signed-off-by: Srujana Challa --- Depends-on: series-18262 ("security: Improve inline fast path routines") Depends-on: series-18322 ("eventdev: simplify Rx adapter event vector config") v2: * Set rte_event_vector::attr_valid if all packets in the vector uses same port. doc/

[dpdk-dev] [PATCH] examples/ipsec-secgw: add support for event vector

2021-08-26 Thread Srujana Challa
. Depends-on: series-18262 ("security: Improve inline fast path routines") Depends-on: series-18322 ("eventdev: simplify Rx adapter event vector config") Signed-off-by: Srujana Challa --- doc/guides/sample_app_ug/ipsec_secgw.rst | 18 +- examples/ipsec-secgw/event

[dpdk-dev] [PATCH v2] common/cnxk: fix attaching NPA LF to CPT VF

2021-08-18 Thread Srujana Challa
2: - Fixed checkpatch warning. Signed-off-by: Srujana Challa --- drivers/common/cnxk/roc_cpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c index 2ffd271566..60a68876b0 100644 --- a/drivers/common/cnxk/roc_cpt.c +++

[dpdk-dev] [PATCH] common/cnxk: fix attaching NPA LF to CPT VF

2021-08-18 Thread Srujana Challa
ned-off-by: Srujana Challa --- drivers/common/cnxk/roc_cpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c index 2ffd271566..60a68876b0 100644 --- a/drivers/common/cnxk/roc_cpt.c +++ b/drivers/common/cnxk/roc_cpt.c

[dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add UDP encapsulation for inline protocol

2021-07-13 Thread Srujana Challa
Adds support to allow udp-encap option for RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL mode also. Signed-off-by: Srujana Challa --- examples/ipsec-secgw/sa.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/examples/ipsec-secgw/sa.c b/examples

[dpdk-dev] [PATCH 1/2] common/cnxk: add support for UDP encapsulation

2021-07-13 Thread Srujana Challa
Adds support for UDP encapsulation in crypto_cn10k PMD. Signed-off-by: Srujana Challa --- drivers/common/cnxk/cnxk_security.c | 18 ++ drivers/common/cnxk/meson.build | 1 + 2 files changed, 19 insertions(+) diff --git a/drivers/common/cnxk/cnxk_security.c b/drivers