[dpdk-dev] [PATCH 10/10] eal: add option --master-lcore

2014-11-26 Thread Simon Kuenzer
On 25.11.2014 14:39, Bruce Richardson wrote: > On Tue, Nov 25, 2014 at 01:45:22PM +0100, Thomas Monjalon wrote: >> Hi Simon, >> >> 2014-11-25 10:09, Simon Kuenzer: >>> thanks for your work. I have one (minor) comment for this patch that >>> should be fixed in

[dpdk-dev] [PATCH 10/10] eal: add option --master-lcore

2014-11-25 Thread Simon Kuenzer
Hi Thomas, thanks for your work. I have one (minor) comment for this patch that should be fixed in a later version. Acknowledged. Thanks, Simon On 22.11.2014 22:43, Thomas Monjalon wrote: > From: Simon Kuenzer > > Enable users to specify the lcore id that is used as mas

[dpdk-dev] [PATCH v2] eal: add option --master-lcore

2014-11-06 Thread Simon Kuenzer
eal_parse_common_option() is just called within the option parsing loop. Maybe we can improve this later? I am fine with this patch but I have some comments inlined. In general: acknowledged from my side. Thanks a lot, Simon On 04.11.2014 22:40, Thomas Monjalon wrote: > From: Simon Kuenzer > > Enable

[dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id

2014-07-23 Thread Simon Kuenzer
Hi all, the only issue I could imagine is that current DPDK applications are utilizing the implicit assumption that the master lcore is always set to the first available lcore. I would consider this as a "bug" in the application because it sets up its worker threads not "properly". However, as fa

[dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id

2014-07-23 Thread Simon Kuenzer
On 23.07.2014 11:04, Thomas Monjalon wrote: > 2014-07-23 08:53, Hiroshi Shimamoto: >> 2014-07-23 09:50, Thomas Monjalon: >>> 2014-07-22 23:40, Hiroshi Shimamoto: does anyone have interest in this functionality? I think this is important and useful. Since we should care about cor

[dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id

2014-07-21 Thread Simon Kuenzer
Comments? On 08.07.2014 11:42, Simon Kuenzer wrote: > Here are some comments about the use case of this patch: > > This patch is especially useful in cases where DPDK applications scale > their CPU resources at runtime via starting and stopping slave lcores. > Since the corem

[dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id

2014-07-08 Thread Simon Kuenzer
future release: https://lists.01.org/pipermail/dpdk-ovs/2014-March/000770.html https://lists.01.org/pipermail/dpdk-ovs/2014-March/000773.html Thanks, Simon On 08.07.2014 10:28, Simon Kuenzer wrote: > This commit enables users to specify the lcore id that > is used as master lcore. >

[dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id

2014-07-08 Thread Simon Kuenzer
This commit enables users to specify the lcore id that is used as master lcore. Signed-off-by: Simon Kuenzer --- lib/librte_eal/linuxapp/eal/eal.c | 33 + 1 file changed, 33 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal