Re: [dpdk-dev] [PATCH 1/2] net/vmxnet3: set the queue shared buffer at start

2018-03-12 Thread Shrikrishna Khare
elay configuration of the shared queue > pointers until device start when queuedesc is no longer changing. > > Fixes: 8618d19b52b1 ("net/vmxnet3: reallocate shared memzone on re-config") > > Signed-off-by: Chas Williams Acked-by: Shrikrishna Khare

Re: [dpdk-dev] [PATCH] vmxnet3: set unknown packet_type for non-ipv4 packets

2018-01-17 Thread Shrikrishna Khare
reset for non-ipv4 packets in vmxnet3_rx_offload. > > Signed-off-by: George Wilkie Acked-by: Shrikrishna Khare > --- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c > b/drivers/net/vmxne

[dpdk-dev] [PATCH] net/vmxnet3: convert to 3-Clause BSD License

2017-12-07 Thread Shrikrishna Khare
those licenses to 3-Clause BSD license. Reported-by: Hemant Agrawal Acked-by: Cheryl Houser Acked-by: Bharat Mota Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/base/upt1_defs.h| 22 +- drivers/net/vmxnet3/base/vmxnet3_defs.h | 22 +- 2 files ch

Re: [dpdk-dev] [PATCH] vmxnet3: mac address set fixes

2017-09-10 Thread Shrikrishna Khare
On Fri, 25 Aug 2017, David Harton wrote: > Updated vmxnet3_mac_addr_set() to store the newly set MAC address. > Modified vmxnet3_write_mac() so the h/w is updated in an endian > neutral manner. > > Signed-off-by: David Harton Acked-by: Shrikrishna Khare > --- >

Re: [dpdk-dev] [PATCH] vmxnet3: replenish ring buffers in rx processing

2017-09-10 Thread Shrikrishna Khare
On Fri, 25 Aug 2017, David Harton wrote: > vmxnet3 rx processing should replenish ring buffers after new buffers > are available to prevent the interface from getting stuck in a state > that no new work is processed. > > Signed-off-by: David Harton Thanks for the fix. Acked-

Re: [dpdk-dev] [PATCH] net/vmxnet3: restore correct filtering

2017-08-01 Thread Shrikrishna Khare
> > Signed-off-by: Chas Williams Acked-by: Shrikrishna Khare

Re: [dpdk-dev] [PATCH] net/vmxnet3: restore correct filtering

2017-08-01 Thread Shrikrishna Khare
On Tue, 1 Aug 2017, Charles (Chas) Williams wrote: > > > On 08/01/2017 07:41 PM, Shrikrishna Khare wrote: > > > > > > On Mon, 24 Jul 2017, Charles (Chas) Williams wrote: > > > > > We should only restore shadow_vfta when hw_vlan_filter is acti

Re: [dpdk-dev] [PATCH] net/vmxnet3: restore correct filtering

2017-08-01 Thread Shrikrishna Khare
On Mon, 24 Jul 2017, Charles (Chas) Williams wrote: > We should only restore shadow_vfta when hw_vlan_filter is active. > Otherwise, we should restore the previous filtering behavior. > > Fixes: f003fc383487("vmxnet3: enable vlan filtering") > Cc: sta...@dpdk.org > > Signed-off-by: Chas Willia

Re: [dpdk-dev] [PATCH] net/vmxnet3: restore correct filtering

2017-08-01 Thread Shrikrishna Khare
On Sun, 30 Jul 2017, Thomas Monjalon wrote: > 24/07/2017 16:22, Charles (Chas) Williams: > > We should only restore shadow_vfta when hw_vlan_filter is active. > > Otherwise, we should restore the previous filtering behavior. > > > > Fixes: f003fc383487("vmxnet3: enable vlan filtering") > > Cc:

Re: [dpdk-dev] DPDK ethdev/mbuf features and reviews

2017-07-07 Thread Shrikrishna Khare
On Fri, 7 Jul 2017, Thomas Monjalon wrote: > Hi, > > The ethdev library is very special as it defines the services (ops) > to be implemented in every DPDK networking drivers. > It defines also some configuration bits to support. > The mbuf library defines also some offloads to support in driver

Re: [dpdk-dev] [PATCH v2 5/6] net/vmxnet3: receive queue memory leak

2017-06-23 Thread Shrikrishna Khare
ed-off-by: Mandeep Rohilla Acked-by: Shrikrishna Khare

Re: [dpdk-dev] [PATCH v2 2/6] net/vmxnet3: Implement retrieval of extended stats

2017-06-20 Thread Shrikrishna Khare
On Thu, 15 Jun 2017, Charles (Chas) Williams wrote: > From: Robert Shearman > > Implement xstats_get() to allow a number of driver-specific tx and rx > stats to be retrieved. > > Signed-off-by: Robert Shearman Acked-by: Shrikrishna Khare

Re: [dpdk-dev] [PATCH 1/6] net/vmxnet3: retain counters on restart

2017-05-26 Thread Shrikrishna Khare
gt; vmxnet3 behavior is opposite to that and counters are reset by > the host side implementation each time the device is restarted. > > Change the driver to save the counters in its private context > before it is reset by writing CMD_ACTIVATE to REG_CMD. > > Signed-off-by: Na

Re: [dpdk-dev] [PATCH 1/6] net/vmxnet3: retain counters on restart

2017-05-26 Thread Shrikrishna Khare
On Thu, 25 May 2017, Nachi Prachanda wrote: > > From: Shrikrishna Khare [mailto:skh...@shri-linux.eng.vmware.com] > > Sent: Thursday, May 25, 2017 1:27 PM > > > > On Thu, 25 May 2017, Nachi Prachanda wrote: > > > > > > From: Shrikrishna Khar

Re: [dpdk-dev] [PATCH 1/6] net/vmxnet3: retain counters on restart

2017-05-25 Thread Shrikrishna Khare
On Thu, 25 May 2017, Nachi Prachanda wrote: > > From: Shrikrishna Khare [mailto:skh...@shri-linux.eng.vmware.com] > > Sent: Wednesday, May 24, 2017 2:10 PM > > > > On Fri, 19 May 2017, Charles (Chas) Williams wrote: > > > > > From: Nachiketa Prachanda

Re: [dpdk-dev] [PATCH 1/6] net/vmxnet3: retain counters on restart

2017-05-24 Thread Shrikrishna Khare
On Fri, 19 May 2017, Charles (Chas) Williams wrote: > From: Nachiketa Prachanda > > Most nics like virtio, igb/ixgbe etc. don't reset counters on > dev_start and arguably this helps in monitoring the counters > across a longer time span with multiple device start/stops. > vmxnet3 behavior is o

Re: [dpdk-dev] [PATCH 2/6] net/vmxnet3: Implement retrieval of extended stats

2017-05-23 Thread Shrikrishna Khare
On Fri, 19 May 2017, Charles (Chas) Williams wrote: > From: Robert Shearman > > Implement xstats_get() to allow a number of driver-specific tx and rx > stats to be retrieved. > > Signed-off-by: Robert Shearman Acked-by: Shrikrishna Khare

Re: [dpdk-dev] [PATCH 4/6] net/vmxnet3: Make vmxnet3_process_events less noisy

2017-05-23 Thread Shrikrishna Khare
; Change these to use PMD_DRV_LOG instead of PMD_INIT_LOG since they > don't happen at device init. > > Signed-off-by: Robert Shearman Acked-by: Shrikrishna Khare

Re: [dpdk-dev] [PATCH 6/6] net/vmxnet3: preserve configured MAC address

2017-05-22 Thread Shrikrishna Khare
; > Signed-off-by: George Wilkie Acked-by: Shrikrishna Khare

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Shrikrishna Khare
off-by: Chas Williams > > --- > > Looks good to me and cc-ing Shrikrishna, the new vmxnet3 pmd maintainer. Looks good to me too. Acked-by: Shrikrishna Khare

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix broken debug build

2017-03-13 Thread Shrikrishna Khare
On Mon, 13 Mar 2017, Andrew Rybchenko wrote: > Fixes: 4dd452523000 ("net/vmxnet3: add receive data ring support") > > Signed-off-by: Andrew Rybchenko Thank you for catching and fixing this. Acked-by: Shrikrishna Khare > --- > drivers/net/vmxnet3/vmxnet3_et

[dpdk-dev] [PATCH] maintainers: update for vmxnet3

2017-03-07 Thread Shrikrishna Khare
Taking over DPDK vmxnet3 driver maintainer role. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 01160d0..3c8aefa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -376,7 +376,7

Re: [dpdk-dev] [PATCH v2 4/7] net/vmxnet3: add receive data ring support

2017-03-06 Thread Shrikrishna Khare
On Mon, 6 Mar 2017, Thomas Monjalon wrote: > 2017-03-06 09:17, Shrikrishna Khare: > > Receive Data Ring buffer length is configurable via ethtool -G ethX rx-mini > > Are you configuring the ring length before unbinding from the kernel driver? Changing rx data ring requires ch

[dpdk-dev] [PATCH v3 2/7] net/vmxnet3: introduce generalized cmd interface

2017-03-06 Thread Shrikrishna Khare
commands, the driver first populates the command information field in the shared memory and then issues the command. The emulation interprets the data written to the command information depending on the type of the command. This patch exposes this capability to the driver. Signed-off-by: Shrikrishna

[dpdk-dev] [PATCH v3 7/7] net/vmxnet3: update to version 3

2017-03-06 Thread Shrikrishna Khare
With all vmxnet3 version 3 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 3, provided the emulation advertises support for version 3. This patch also updates release notes. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by

[dpdk-dev] [PATCH v3 0/7] vmxnet3: upgrade to version 3

2017-03-06 Thread Shrikrishna Khare
identified by check-git-log.sh. - fixed compilation issues hit when debug logging is turned on. Change in v3: - fix a typo in commit message for add receive data ring change Shrikrishna Khare (7): net/vmxnet3: prepare for version 3 changes net/vmxnet3: introduce generalized cmd interface

[dpdk-dev] [PATCH v3 5/7] net/vmxnet3: add reserved version 3 command

2017-03-06 Thread Shrikrishna Khare
This command is reserved. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base

[dpdk-dev] [PATCH v3 6/7] net/vmxnet3: add cmd to register memory region

2017-03-06 Thread Shrikrishna Khare
emulation, the emulation will always keep these memory regions mapped, thereby avoiding the mapping/unmapping overhead for every packet. Signed-off-by: Shrikrishna Khare Signed-off-by: Guolin Yang Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 25

[dpdk-dev] [PATCH v3 4/7] net/vmxnet3: add receive data ring support

2017-03-06 Thread Shrikrishna Khare
- a set of small sized buffers that are always mapped by the emulation. If a packet fits into the receive data ring buffer, the emulation delivers the packet via the receive data ring (which must be copied by the guest driver), or else the usual receive path is used. Signed-off-by: Shrikrishna Khare

[dpdk-dev] [PATCH v3 1/7] net/vmxnet3: prepare for version 3 changes

2017-03-06 Thread Shrikrishna Khare
Cleanup some code in preparation of vmxnet3 version 3 changes. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 17 + drivers/net/vmxnet3/vmxnet3_ethdev.h | 9 + 2 files changed, 22 insertions(+), 4

[dpdk-dev] [PATCH v3 3/7] net/vmxnet3: variable length transmit data ring

2017-03-06 Thread Shrikrishna Khare
implementation to allow variable length transmit data ring buffers. The length of the buffer is read from the emulation during initialization. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 14 -- drivers/net/vmxnet3

Re: [dpdk-dev] [PATCH 0/7] vmxnet3: upgrade to version 3

2017-03-06 Thread Shrikrishna Khare
On Fri, 3 Mar 2017, Ferruh Yigit wrote: > > Shrikrishna Khare (7): > > vmxnet3: prepare for version 3 changes > > vmxnet3: introduce generalized command interface to configure the > > device > > vmxnet3: allow variable length transmit data ring buffer &

[dpdk-dev] [PATCH v2 5/7] net/vmxnet3: add reserved version 3 command

2017-03-06 Thread Shrikrishna Khare
This command is reserved. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base

[dpdk-dev] [PATCH v2 1/7] net/vmxnet3: prepare for version 3 changes

2017-03-06 Thread Shrikrishna Khare
Cleanup some code in preparation of vmxnet3 version 3 changes. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 17 + drivers/net/vmxnet3/vmxnet3_ethdev.h | 9 + 2 files changed, 22 insertions(+), 4

[dpdk-dev] [PATCH v2 2/7] net/vmxnet3: introduce generalized cmd interface

2017-03-06 Thread Shrikrishna Khare
commands, the driver first populates the command information field in the shared memory and then issues the command. The emulation interprets the data written to the command information depending on the type of the command. This patch exposes this capability to the driver. Signed-off-by: Shrikrishna

[dpdk-dev] [PATCH v2 7/7] net/vmxnet3: update to version 3

2017-03-06 Thread Shrikrishna Khare
With all vmxnet3 version 3 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 3, provided the emulation advertises support for version 3. This patch also updates release notes. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by

[dpdk-dev] [PATCH v2 0/7] vmxnet3: upgrade to version 3

2017-03-06 Thread Shrikrishna Khare
identified by check-git-log.sh. - fixed compilation issues hit when debug logging is turned on. Shrikrishna Khare (7): net/vmxnet3: prepare for version 3 changes net/vmxnet3: introduce generalized cmd interface net/vmxnet3: variable length transmit data ring net/vmxnet3: add receive data

[dpdk-dev] [PATCH v2 4/7] net/vmxnet3: add receive data ring support

2017-03-06 Thread Shrikrishna Khare
is configurable via ethtool -G ethX rx-mini Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 12 ++-- drivers/net/vmxnet3/vmxnet3_ethdev.c| 9 + drivers/net/vmxnet3/vmxnet3_ethdev.h| 15

[dpdk-dev] [PATCH v2 6/7] net/vmxnet3: add cmd to register memory region

2017-03-06 Thread Shrikrishna Khare
emulation, the emulation will always keep these memory regions mapped, thereby avoiding the mapping/unmapping overhead for every packet. Signed-off-by: Shrikrishna Khare Signed-off-by: Guolin Yang Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 25

[dpdk-dev] [PATCH v2 3/7] net/vmxnet3: variable length transmit data ring

2017-03-06 Thread Shrikrishna Khare
implementation to allow variable length transmit data ring buffers. The length of the buffer is read from the emulation during initialization. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 14 -- drivers/net/vmxnet3

[dpdk-dev] [PATCH 7/7] vmxnet3: update to version 3

2017-02-25 Thread Shrikrishna Khare
With all vmxnet3 version 3 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 3, provided the emulation advertises support for version 3. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3

[dpdk-dev] [PATCH 5/7] vmxnet3: add reserved version 3 command

2017-02-25 Thread Shrikrishna Khare
This command is reserved. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base

[dpdk-dev] [PATCH 1/7] vmxnet3: prepare for version 3 changes

2017-02-25 Thread Shrikrishna Khare
Cleanup some code in preparation of vmxnet3 version 3 changes. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 17 + drivers/net/vmxnet3/vmxnet3_ethdev.h | 9 + 2 files changed, 22 insertions(+), 4

[dpdk-dev] [PATCH 0/7] vmxnet3: upgrade to version 3

2017-02-25 Thread Shrikrishna Khare
incorporated in the vmxnet3 driver, with this patch, the driver can configure emulation to run at vmxnet3 version 3. Shrikrishna Khare (7): vmxnet3: prepare for version 3 changes vmxnet3: introduce generalized command interface to configure the device vmxnet3: allow variable length

[dpdk-dev] [PATCH 2/7] vmxnet3: introduce generalized command interface to configure the device

2017-02-25 Thread Shrikrishna Khare
commands, the driver first populates the command information field in the shared memory and then issues the command. The emulation interprets the data written to the command information depending on the type of the command. This patch exposes this capability to the driver. Signed-off-by: Shrikrishna

[dpdk-dev] [PATCH 4/7] vmxnet3: add receive data ring support

2017-02-25 Thread Shrikrishna Khare
is configurable via ethtool -G ethX rx-mini Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 12 ++-- drivers/net/vmxnet3/vmxnet3_ethdev.c| 9 + drivers/net/vmxnet3/vmxnet3_ethdev.h| 1 + drivers/net

[dpdk-dev] [PATCH 3/7] vmxnet3: allow variable length transmit data ring buffer

2017-02-25 Thread Shrikrishna Khare
implementation to allow variable length transmit data ring buffers. The length of the buffer is read from the emulation during initialization. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 14 -- drivers/net/vmxnet3

[dpdk-dev] [PATCH 6/7] vmxnet3: introduce command to register memory region

2017-02-25 Thread Shrikrishna Khare
emulation, the emulation will always keep these memory regions mapped, thereby avoiding the mapping/unmapping overhead for every packet. Signed-off-by: Shrikrishna Khare Signed-off-by: Guolin Yang Acked-by: Yong Wang Acked-by: Jin Heo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 25