Re: [dpdk-dev] [PATCH v2 4/4] rawdev: pass device id as parameter to selftest

2019-07-04 Thread Shreyansh Jain
> -Original Message- > From: Bruce Richardson > Sent: Friday, June 21, 2019 9:27 PM > To: dev@dpdk.org > Cc: Bruce Richardson ; Shreyansh Jain > > Subject: [PATCH v2 4/4] rawdev: pass device id as parameter to selftest > > When running self-tests, the driver

Re: [dpdk-dev] [PATCH v4 1/9] rawdev: allow devices to skip extra memory allocation

2019-07-02 Thread Shreyansh Jain
> -Original Message- > From: Bruce Richardson > Sent: Monday, July 1, 2019 9:26 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; jer...@marvell.com; jiayu...@intel.com; Bruce > Richardson ; Shreyansh Jain > ; Hemant Agrawal > Subject: [PATCH v4 1/9] rawdev: all

Re: [dpdk-dev] [PATCH] raw/skeleton: fix test raw_attr set get failure

2019-06-11 Thread Shreyansh Jain
e heap by calling malloc > also avoid memory leak in case of test case failures > > Fixes: 88d0e47880ec ("raw/skeleton: fix memory leak on test failure") > > Signed-off-by: Thinh Tran > --- Thanks - I had ignored this issue for quite long now. Acked-by: Shreyansh Jain

Re: [dpdk-dev] [PATCH] doc: fix a grammar mistake in rawdev guide

2019-06-06 Thread Shreyansh Jain
Though John has already acked it, and I was original culprit, more than one Ack doesn't look bad :D > -Original Message- > From: Xiaolong Ye > Sent: Tuesday, June 4, 2019 2:11 PM > To: Shreyansh Jain ; Hemant Agrawal > ; John McNamara ; Marko > Kovacevic > Cc:

Re: [dpdk-dev] [PATCH 02/25] bus/fslmc: use new memory locking API

2019-06-02 Thread Shreyansh Jain
> -Original Message- > From: Anatoly Burakov > Sent: Wednesday, May 29, 2019 10:01 PM > To: dev@dpdk.org > Cc: Hemant Agrawal ; Shreyansh Jain > ; step...@networkplumber.org; > tho...@monjalon.net; david.march...@redhat.com > Subject: [PATCH 02/25] bus/fslmc: us

Re: [dpdk-dev] [PATCH] common/dpaax: fix i686 compilation issue

2019-05-29 Thread Shreyansh Jain
Hi Bruce, > -Original Message- > From: Bruce Richardson > Sent: Wednesday, May 29, 2019 2:48 PM > To: Shreyansh Jain > Cc: ferruh.yi...@intel.com; step...@networkplumber.org; bl...@debian.org; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] common/dpaax: fix i

Re: [dpdk-dev] [PATCH v2 2/5] build: enable large file support on 32-bit

2019-05-29 Thread Shreyansh Jain
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, May 28, 2019 4:38 PM > To: dev@dpdk.org > Cc: Shreyansh Jain ; Alejandro Lucero > ; Anatoly Burakov > ; sta...@dpdk.org; Maxime Coquelin > ; Zhihong Wang ; Luca > Boccassi ; Zhang XuemingX ; Br

[dpdk-dev] [PATCH] common/dpaax: fix i686 compilation issue

2019-05-28 Thread Shreyansh Jain
s.dpdk.org/archives/test-report/2019-May/082622.html Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: shreyansh.j...@nxp.com Signed-off-by: Shreyansh Jain --- Note: - Another option was to use the PRIu32 macros but, in absence of a proper verificati

[dpdk-dev] [PATCH] net/dpaa2: fix incorrect loop increment

2019-04-25 Thread Shreyansh Jain
Identified by LGTM, the loop was incorrectly incrementing a different variable and conditional on another. Fixes: fe2b986ac662 ("net/dpaa2: support generic flow") Cc: sunil.k...@nxp.com Suggested-by: Ferruh Yigit Signed-off-by: Shreyansh Jain --- drivers/net/dpaa2/dpaa2_flow.c | 2

[dpdk-dev] [PATCH v2] examples/l3fwd: support separate buffer pool per port

2019-04-25 Thread Shreyansh Jain
adds an argument '--per-port-pool' to the l3fwd application. By default, old mode of single pool per port (split on sockets) is active. L3fwd user guide is also updated by this patch. Signed-off-by: Shreyansh Jain Acked-by: Ruifeng Wang --- v2: - Updated documentation doc/guides/sam

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-16 Thread Shreyansh Jain
Hi Ananyev, [...] > > As you have stated below, it's just the same thing with two different > views. > > > > > I think it would be plausible for both cases: > > > - one port per core (your case). > > > - multiple ports per core. > > > > Indeed. For this particular patch, I just chose the first on

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-16 Thread Shreyansh Jain
Hello Ananyev, > Hi Shreyansh, > > > > > I tried this patch on MacchiatoBin + 82599 NIC. > > > > Compared with global-pool mode, per-port-pool mode showed slightly > > > lower performance in single core test. > > > > > > That was my thought too - for the case when queues from multiple > ports > >

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-15 Thread Shreyansh Jain
Hello Ruifeng, > > > Hi Shreyansh, > > > -Original Message- > > From: Shreyansh Jain > > Sent: Monday, April 15, 2019 14:48 > > To: Ruifeng Wang (Arm Technology China) ; > > Ananyev, Konstantin ; dev@dpdk.org > > Cc: nd ; nd > > S

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-14 Thread Shreyansh Jain
Hi Ruifeng, [...] > > > > For hardware backed pools, hardware access and exclusion are > expensive. By > > segregating pool/port/lcores it is possible to attain a conflict free > path. This is > > the use-case this patch targets. > > And anyways, this is an optional feature. > > > > > Konstantin

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-12 Thread Shreyansh Jain
Hi Konstantin, Ruifeng, > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, April 8, 2019 3:00 PM > To: Ruifeng Wang (Arm Technology China) ; > Shreyansh Jain ; dev@dpdk.org > Cc: nd > Subject: RE: [dpdk-dev] [PATCH] examples/l3fwd: support separate b

Re: [dpdk-dev] [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code

2019-04-05 Thread Shreyansh Jain
On 05/04/19 6:05 PM, Thomas Monjalon wrote: > 05/04/2019 13:38, Shreyansh Jain: >> On 05/04/19 4:49 PM, Shreyansh Jain wrote: >>> On 05/04/19 3:13 AM, Thomas Monjalon wrote: >>>> 04/04/2019 23:29, Ferruh Yigit: >>>>> On 4/4/2019 8:23 AM, Shreyansh Ja

Re: [dpdk-dev] [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code

2019-04-05 Thread Shreyansh Jain
On 05/04/19 4:49 PM, Shreyansh Jain wrote: > On 05/04/19 3:13 AM, Thomas Monjalon wrote: >> 04/04/2019 23:29, Ferruh Yigit: >>> On 4/4/2019 8:23 AM, Shreyansh Jain wrote: >>>> Removes some unused firmware code which was added in last bump >>>> of the

Re: [dpdk-dev] [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code

2019-04-05 Thread Shreyansh Jain
On 05/04/19 3:13 AM, Thomas Monjalon wrote: > 04/04/2019 23:29, Ferruh Yigit: >> On 4/4/2019 8:23 AM, Shreyansh Jain wrote: >>> Removes some unused firmware code which was added in last bump >>> of the firmware version. No current features uses these APIs. >>&g

[dpdk-dev] [PATCH v2 3/3] doc: bump SDK support version for dpaa2

2019-04-04 Thread Shreyansh Jain
With the change in MC firmware, minimum supported version of the Layerscape SDK too needs to be changed. Signed-off-by: Shreyansh Jain --- doc/guides/nics/dpaa2.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/dpaa2.rst b/doc/guides/nics/dpaa2.rst

[dpdk-dev] [PATCH v2 2/3] drivers: update MC firmware version for FSLMC bus

2019-04-04 Thread Shreyansh Jain
MC firmware is the core component of FSLMC bus and DPAA2 devices. Prior to this patch, MC firmware supported 10.10.x version. This patch bumps the min supported version to 10.14.x. Signed-off-by: Shreyansh Jain Acked-by: Hemant Agrawal --- drivers/bus/fslmc/mc/fsl_dpmng.h| 2 +- drivers

[dpdk-dev] [PATCH v2 0/3] Update FSLMC bus firmware

2019-04-04 Thread Shreyansh Jain
tches updates only necessary changes so as to maintain version compatibility. v1->v2: - In last patch (patch 2), one of a recent fix (e94be227b7) was overwritten. Restoring that change. Shreyansh Jain (3): bus/fslmc: cleanup unused firmware code drivers: update MC firmware version for FSLMC b

[dpdk-dev] [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code

2019-04-04 Thread Shreyansh Jain
Removes some unused firmware code which was added in last bump of the firmware version. No current features uses these APIs. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/mc/dpci.c | 75 drivers/bus/fslmc/mc/dpcon.c | 30 - drivers/bus

[dpdk-dev] [PATCH 1/3] bus/fslmc: cleanup unused firmware code

2019-04-03 Thread Shreyansh Jain
Removes some unused firmware code which was added in last bump of the firmware version. No current features uses these APIs. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/mc/dpci.c | 75 drivers/bus/fslmc/mc/dpcon.c | 30 - drivers/bus

[dpdk-dev] [PATCH 2/3] drivers: update MC firmware version for FSLMC bus

2019-04-03 Thread Shreyansh Jain
MC firmware is the core component of FSLMC bus and DPAA2 devices. Prior to this patch, MC firmware supported 10.10.x version. This patch bumps the min supported version to 10.14.x. Signed-off-by: Shreyansh Jain Acked-by: Hemant Agrawal --- drivers/bus/fslmc/mc/fsl_dpmng.h| 2 +- drivers

[dpdk-dev] [PATCH 3/3] doc: bump SDK support version for dpaa2

2019-04-03 Thread Shreyansh Jain
With the change in MC firmware, minimum supported version of the Layerscape SDK too needs to be changed. Signed-off-by: Shreyansh Jain --- doc/guides/nics/dpaa2.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/dpaa2.rst b/doc/guides/nics/dpaa2.rst

[dpdk-dev] [PATCH 0/3] Update FSLMC bus firmware

2019-04-03 Thread Shreyansh Jain
tches updates only necessary changes so as to maintain version compatibility. Shreyansh Jain (3): bus/fslmc: cleanup unused firmware code drivers: update MC firmware version for FSLMC bus doc: bump SDK support version for dpaa2 doc/guides/nics/dpaa2.rst | 4 +- drivers/bus/fslmc/mc/d

[dpdk-dev] [PATCH] net/dpaa2: accept packets with checksum error

2019-03-19 Thread Shreyansh Jain
would be done as configured for a standard packet path. Signed-off-by: Shreyansh Jain --- drivers/net/dpaa2/dpaa2_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index a8f0e3002..c92edecf3 100644 --- a/drivers/net

Re: [dpdk-dev] [PATCH v3 00/20] NXP DPAA2 fixes and enhancements

2019-01-13 Thread Shreyansh Jain
On 11/01/19 9:42 PM, Ferruh Yigit wrote: > On 1/11/2019 3:51 PM, Ferruh Yigit wrote: >> On 1/11/2019 12:24 PM, Shreyansh Jain wrote: >>> (N: Original series was by Hemant - due to RC window timeline and >>> his unavailability, respining on his behalf) >>>

Re: [dpdk-dev] [PATCH v3 00/20] NXP DPAA2 fixes and enhancements

2019-01-13 Thread Shreyansh Jain
On 11/01/19 5:54 PM, Shreyansh Jain wrote: > (N: Original series was by Hemant - due to RC window timeline and > his unavailability, respining on his behalf) > > This patch set covers following: > > 1. Fixes in the existing NXP DPAA2 bus and net pmd > 2. New object (D

[dpdk-dev] [PATCH v3 15/19] net/dpaa2: add dpdmux initialization and configuration

2019-01-11 Thread Shreyansh Jain
From: Nipun Gupta This patch introduces an rte pmd API to configure dpdmux from the application. dpdmux can work in association with dpni as an additional distribution capability on the NIC. Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/Makefile | 1 + drivers/net/dpaa2/d

[dpdk-dev] [PATCH v3 17/19] mempool/dpaa2: support saving context of buffer pool

2019-01-11 Thread Shreyansh Jain
hread not containing a valid reference to the array, reference is build using the handle avaialble in the dpaa2_queue. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 1 + drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 12 +++- drivers/mempool/dpaa2/dpaa2_hw_memp

[dpdk-dev] [PATCH v3 19/19] bus/fslmc: add support for secondary processes

2019-01-11 Thread Shreyansh Jain
/blacklisting devices in each instance. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_vfio.c | 51 drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 24 +-- 2 files changed, 63 insertions(+), 12 deletions(-) diff --git a/drivers/bus/fslmc

[dpdk-dev] [PATCH v3 16/19] net/dpaa2: add API to support custom hash key

2019-01-11 Thread Shreyansh Jain
From: Nipun Gupta The DPAA2 hw can support a special offset based configuration to program distribution on hash. This is for all cases, which are not directly supported. e.g. HASH based distribution on inner ip header of a GRE tunnel. Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/base/dpaa

[dpdk-dev] [PATCH v3 18/19] net/dpaa2: change reference to private device

2019-01-11 Thread Shreyansh Jain
same as the primary process. Thus, the reference goes invalid. This patch changes the implementation to use the dev_private rather than the rte_eth_dev as that is shared area across all the processes. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 5 - drivers

[dpdk-dev] [PATCH v3 14/19] bus/fslmc: add support for scanning DPDMUX object

2019-01-11 Thread Shreyansh Jain
From: Nipun Gupta Add support in bus and vfio to scan dpdmux type of objects Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/fslmc_bus.c | 5 - drivers/bus/fslmc/fslmc_vfio.c | 2 ++ drivers/bus/fslmc/rte_fslmc.h | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drive

[dpdk-dev] [PATCH v3 12/19] bus/fslmc: make portal func static

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal Change QBMAN portal function to static as it is not exposed outside this file context. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 2 +- drivers/bus/fslmc/portal/dpaa2_hw_dpio.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff

[dpdk-dev] [PATCH v3 13/19] net/dpaa2: add dpdmux mc flib

2019-01-11 Thread Shreyansh Jain
From: Nipun Gupta dpdmux object is added as a part of net driver as it is used to de-multiplex packets to separate interfaces on basis of specific rules. These rules can be configured from the software Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/Makefile| 1 + drivers/net/dp

[dpdk-dev] [PATCH v3 09/19] bus/fslmc: upgrade to latest qbman library

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal This patch upgrades and sync the dpdk based qbman code with new version of qbman flib. Signed-off-by: Youri Querry Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_portal.c | 8 drivers/bus/fslmc/qbman/qbman_sys.h|

[dpdk-dev] [PATCH v3 11/19] bus/fslmc: rename portal pi index to consumer index

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal This is to align with the latest qbman hw library Signed-off-by: Youri Querry Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_portal.c | 51 +++--- drivers/bus/fslmc/qbman/qbman_portal.h | 2 +- 2 files changed, 23 insertions(+), 30 de

[dpdk-dev] [PATCH v3 10/19] bus/fslmc: add dynamic config for memback portal mode

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal Add flag in portal init to adjust the qbman memory type, to decide between legacy portal mode or newly introduced memory backed portals. Signed-off-by: Roy Pledge Signed-off-by: Youri Querry Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c

[dpdk-dev] [PATCH v3 07/19] net/dpaa2: fix device init for secondary process

2019-01-11 Thread Shreyansh Jain
In order to support I/O from secondary process, the burst APIs and OPS APIs shall be mapped/plugged. Fixes: c147eae01cb3 ("net/dpaa2: introduce NXP DPAA2 driver") Cc: sta...@dpdk.org Signed-off-by: Shreyansh Jain --- drivers/net/dpaa2/dpaa2_ethdev.c | 9 - 1 file changed, 8

[dpdk-dev] [PATCH v3 08/19] net/dpaa2: enable optional timestamp in mbuf

2019-01-11 Thread Shreyansh Jain
From: Akhil Goyal This patch enables the population of timestamp field in mbuf on packet receive. It may give performance impact on LX2xxx platforms. So, it has been made optional for Lx2xxx platform. One shall call, rte_dpaa2_enable_ts() to enable it. Nothing is required for LS2 and LS1088 plat

[dpdk-dev] [PATCH v3 05/19] bus/fslmc: fix to convert error msg to warning

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal This is just a information. No need to print it as a error. Fixes: ce9efbf5bb09 ("bus/fslmc: support dynamic logging") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_vfio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[dpdk-dev] [PATCH v3 06/19] bus/fslmc: fix parse method for bus devices

2019-01-11 Thread Shreyansh Jain
("bus/fslmc: support device blacklisting") Cc: sta...@dpdk.org Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_bus.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/f

[dpdk-dev] [PATCH v3 04/19] net/dpaa2: fix bad check for not-null

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal The check !dpaa2->cscn is not correct to check non-null value. Fixes: 5d9a1e4d23fe ("net/dpaa2: enhance queue memory cleanup") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) d

[dpdk-dev] [PATCH v3 03/19] bus/fslmc: fix to use correct physical core for logical core

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal Existing code is using the lcore id as the physical core id. Add code to get the right physical id. Also, dpaa2 can not support one lcore mapping to multiple cpus, print err on such cases. Fixes: ce9efbf5bb09 ("bus/fslmc: support dynamic logging") Cc: sta...@dpdk.org Signe

[dpdk-dev] [PATCH v3 02/19] bus/fslmc: fix the ring mode to use correct cache settings

2019-01-11 Thread Shreyansh Jain
From: Youri Querry The code was incorrectly using the cache inhibited access. It shall use cached enabled access for better performance. Fixes: 293c0ca94c36 ("bus/fslmc: support memory backed portals with QBMAN 5.0") Cc: sta...@dpdk.org Signed-off-by: Youri Querry --- drivers/bus/fslmc/qbman/

[dpdk-dev] [PATCH v3 01/19] bus/fslmc: fix to reset portal memory before use

2019-01-11 Thread Shreyansh Jain
From: Sachin Saxena Uninitialized portal memory is causing unwanted issues. Fixes: 293c0ca94c36 ("bus/fslmc: support memory backed portals with QBMAN 5.0") Cc: sta...@dpdk.org Signed-off-by: Sachin Saxena --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 2 ++ 1 file changed, 2 insertions(+) di

[dpdk-dev] [PATCH v3 00/20] NXP DPAA2 fixes and enhancements

2019-01-11 Thread Shreyansh Jain
mux mc flib bus/fslmc: add support for scanning DPDMUX object net/dpaa2: add dpdmux initialization and configuration net/dpaa2: add API to support custom hash key Sachin Saxena (1): bus/fslmc: fix to reset portal memory before use Shreyansh Jain (5): bus/fslmc: fix parse method for bus de

Re: [dpdk-dev] [PATCH 20/20] bus/fslmc: add function to map any addr via VFIO

2019-01-11 Thread Shreyansh Jain
On 11/01/19 5:28 PM, Ferruh Yigit wrote: > On 1/10/2019 9:58 AM, Shreyansh Jain wrote: >> Hello Ferruh, >> >> Replying on behalf of Hemant... >> >> On 08/01/19 7:40 PM, Ferruh Yigit wrote: >>> On 12/27/2018 6:23 AM, Hemant Agrawal wrote: >>&

[dpdk-dev] [PATCH v2 16/20] net/dpaa2: add API to support custom hash key

2019-01-11 Thread Shreyansh Jain
From: Nipun Gupta The DPAA2 hw can support a special offset based configuration to program distribution on hash. This is for all cases, which are not directly supported. e.g. HASH based distribution on inner ip header of a GRE tunnel. Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/base/dpaa

[dpdk-dev] [PATCH v2 20/20] bus/fslmc: add function to map any addr via VFIO

2019-01-11 Thread Shreyansh Jain
From: Pankaj Chauhan This is required to map any accelerator memory and PCI address to VFIO using QDMA. Signed-off-by: Minghuan Lian Signed-off-by: Pankaj Chauhan --- drivers/bus/fslmc/fslmc_vfio.c | 43 + drivers/bus/fslmc/fslmc_vfio.h | 1 + dr

[dpdk-dev] [PATCH v2 19/20] bus/fslmc: add support for secondary processes

2019-01-11 Thread Shreyansh Jain
/blacklisting devices in each instance. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_vfio.c | 51 drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 24 +-- 2 files changed, 63 insertions(+), 12 deletions(-) diff --git a/drivers/bus/fslmc

[dpdk-dev] [PATCH v2 17/20] mempool/dpaa2: support saving context of buffer pool

2019-01-11 Thread Shreyansh Jain
hread not containing a valid reference to the array, reference is build using the handle avaialble in the dpaa2_queue. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 1 + drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 12 +++- drivers/mempool/dpaa2/dpaa2_hw_memp

[dpdk-dev] [PATCH v2 15/20] net/dpaa2: add dpdmux initialization and configuration

2019-01-11 Thread Shreyansh Jain
From: Nipun Gupta This patch introduces an rte pmd API to configure dpdmux from the application. dpdmux can work in association with dpni as an additional distribution capability on the NIC. Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/Makefile | 1 + drivers/net/dpaa2/d

[dpdk-dev] [PATCH v2 18/20] net/dpaa2: change reference to private device

2019-01-11 Thread Shreyansh Jain
same as the primary process. Thus, the reference goes invalid. This patch changes the implementation to use the dev_private rather than the rte_eth_dev as that is shared area across all the processes. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 5 - drivers

[dpdk-dev] [PATCH v2 14/20] bus/fslmc: add support for scanning DPDMUX object

2019-01-11 Thread Shreyansh Jain
From: Nipun Gupta Add support in bus and vfio to scan dpdmux type of objects Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/fslmc_bus.c | 5 - drivers/bus/fslmc/fslmc_vfio.c | 2 ++ drivers/bus/fslmc/rte_fslmc.h | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drive

[dpdk-dev] [PATCH v2 12/20] bus/fslmc: make portal func static

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal Change QBMAN portal function to static as it is not exposed outside this file context. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 2 +- drivers/bus/fslmc/portal/dpaa2_hw_dpio.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff

[dpdk-dev] [PATCH v2 13/20] net/dpaa2: add dpdmux mc flib

2019-01-11 Thread Shreyansh Jain
From: Nipun Gupta dpdmux object is added as a part of net driver as it is used to de-multiplex packets to separate interfaces on basis of specific rules. These rules can be configured from the software Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/Makefile| 1 + drivers/net/dp

[dpdk-dev] [PATCH v2 11/20] bus/fslmc: rename portal pi index to consumer index

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal This is to align with the latest qbman hw library Signed-off-by: Youri Querry Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_portal.c | 51 +++--- drivers/bus/fslmc/qbman/qbman_portal.h | 2 +- 2 files changed, 23 insertions(+), 30 de

[dpdk-dev] [PATCH v2 09/20] bus/fslmc: upgrade to latest qbman library

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal This patch upgrades and sync the dpdk based qbman code with new version of qbman flib. Signed-off-by: Youri Querry Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_portal.c | 8 drivers/bus/fslmc/qbman/qbman_sys.h|

[dpdk-dev] [PATCH v2 10/20] bus/fslmc: add dynamic config for memback portal mode

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal Add flag in portal init to adjust the qbman memory type, to decide between legacy portal mode or newly introduced memory backed portals. Signed-off-by: Roy Pledge Signed-off-by: Youri Querry Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c

[dpdk-dev] [PATCH v2 08/20] net/dpaa2: enable optional timestamp in mbuf

2019-01-11 Thread Shreyansh Jain
From: Akhil Goyal This patch enables the population of timestamp field in mbuf on packet receive. It may give performance impact on LX2xxx platforms. So, it has been made optional for Lx2xxx platform. One shall call, rte_dpaa2_enable_ts() to enable it. Nothing is required for LS2 and LS1088 plat

[dpdk-dev] [PATCH v2 07/20] net/dpaa2: fix device init for secondary process

2019-01-11 Thread Shreyansh Jain
In order to support I/O from secondary process, the burst APIs and OPS APIs shall be mapped/plugged. Fixes: c147eae01cb3 ("net/dpaa2: introduce NXP DPAA2 driver") Cc: sta...@dpdk.org Signed-off-by: Shreyansh Jain --- drivers/net/dpaa2/dpaa2_ethdev.c | 9 - 1 file changed, 8

[dpdk-dev] [PATCH v2 06/20] bus/fslmc: fix parse method for bus devices

2019-01-11 Thread Shreyansh Jain
("bus/fslmc: support device blacklisting") Cc: sta...@dpdk.org Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_bus.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/f

[dpdk-dev] [PATCH v2 05/20] bus/fslmc: fix to convert error msg to warning

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal This is just a information. No need to print it as a error. Fixes: ce9efbf5bb09 ("bus/fslmc: support dynamic logging") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_vfio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[dpdk-dev] [PATCH v2 03/20] bus/fslmc: fix to use correct physical core for logical core

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal Existing code is using the lcore id as the physical core id. Add code to get the right physical id. Also, dpaa2 can not support one lcore mapping to multiple cpus, print err on such cases. Fixes: ce9efbf5bb09 ("bus/fslmc: support dynamic logging") Cc: sta...@dpdk.org Signe

[dpdk-dev] [PATCH v2 02/20] bus/fslmc: fix the ring mode to use correct cache settings

2019-01-11 Thread Shreyansh Jain
From: Youri Querry The code was incorrectly using the cache inhibited access. It shall use cached enabled access for better performance. Fixes: 293c0ca94c36 ("bus/fslmc: support memory backed portals with QBMAN 5.0") Cc: sta...@dpdk.org Signed-off-by: Youri Querry --- drivers/bus/fslmc/qbman/

[dpdk-dev] [PATCH v2 04/20] net/dpaa2: fix bad check for not-null

2019-01-11 Thread Shreyansh Jain
From: Hemant Agrawal The check !dpaa2->cscn is not correct to check non-null value. Fixes: 5d9a1e4d23fe ("net/dpaa2: enhance queue memory cleanup") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) d

[dpdk-dev] [PATCH v2 01/20] bus/fslmc: fix to reset portal memory before use

2019-01-11 Thread Shreyansh Jain
From: Sachin Saxena Uninitialized portal memory is causing unwanted issues. Fixes: 293c0ca94c36 ("bus/fslmc: support memory backed portals with QBMAN 5.0") Cc: sta...@dpdk.org Signed-off-by: Sachin Saxena --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 2 ++ 1 file changed, 2 insertions(+) di

[dpdk-dev] [PATCH v2 00/20] NXP DPAA2 fixes and enhancements

2019-01-11 Thread Shreyansh Jain
tion and configuration net/dpaa2: add API to support custom hash key Pankaj Chauhan (1): bus/fslmc: add function to map any addr via VFIO Sachin Saxena (1): bus/fslmc: fix to reset portal memory before use Shreyansh Jain (5): bus/fslmc: fix parse method for bus devices net/dpaa2: fix dev

Re: [dpdk-dev] [PATCH 20/20] bus/fslmc: add function to map any addr via VFIO

2019-01-10 Thread Shreyansh Jain
Signed-off-by: Minghuan Lian >> Signed-off-by: Pankaj Chauhan > > This requires either sign-off or ack from 'bus/fslmc' maintainers, which are: > M: Hemant Agrawal > > > > M: Shreyansh Jain > > I think Hemant sending the patchset imp

Re: [dpdk-dev] [PATCH 0/4] NXP DPAA fixes and enhancements

2019-01-04 Thread Shreyansh Jain
ypes >net/dpaa: update RSS offload types > > drivers/bus/dpaa/dpaa_bus.c| 41 +- > drivers/net/dpaa/dpaa_ethdev.c | 19 +++- > drivers/net/dpaa/dpaa_ethdev.h | 12 ++ > 3 files changed, 42 insertions(+), 30 deletions(-) > Series-Acked-by: Shreyansh Jain

Re: [dpdk-dev] [PATCH v3 2/2] doc: add guide for debug and troubleshoot

2019-01-03 Thread Shreyansh Jain
Hello Vipin, Some comments and lots of nitpicks inlined. (I know this comes months late - apologies, just didn't stumble on this earlier). On Monday 26 November 2018 12:38 PM, Vipin Varghese wrote: > Add user guide on debug and troubleshoot for common issues and bottleneck > found in various app

[dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-01-03 Thread Shreyansh Jain
adds an argument '--per-port-pool' to the l3fwd application. By default, old mode of single pool per port (split on sockets) is active. Signed-off-by: Shreyansh Jain --- RFC: https://mails.dpdk.org/archives/dev/2018-November/120002.html examples/l3fwd/m

Re: [dpdk-dev] 18.08.1 patches review and test

2018-12-25 Thread Shreyansh Jain
port any issue before the release date. > > A release candidate tarball can be found at: > > https://dpdk.org/browse/dpdk-stable/tag/?id=v18.08.1-rc1 > > These patches are located at branch 18.08 of dpdk-stable repo: > https://dpdk.org/browse/dpdk-stable/ > [...

Re: [dpdk-dev] [PATCH] raw/skeleton: fix segmentation fault on rawdev_autotest

2018-12-12 Thread Shreyansh Jain
On Tuesday 11 December 2018 06:44 PM, Harman Kalra wrote: > segmentation fault ocured as vdev->device.driver->name did not > return correct value. > Test2 failed as dummy_value was freed before it was used. > > Signed-off-by: Kallio Marko > Signed-off-by: Harman Kalra > --- > drivers/raw/skele

Re: [dpdk-dev] [PATCH] bus/dpaa: do nothing if bus not present

2018-12-06 Thread Shreyansh Jain
n not available; > dpaax: Expect performance impact. Though I agree with the change below, I am surprised that you are observing such logs as above. These were disabled by bumping the dpaax library default log level to ERR: --->8--- commit 93ec301495316922c0fb1df762e9322bad90b8dc Author: Shreya

[dpdk-dev] RFC: Support for multiple buffer pool in examples/l3fwd

2018-11-29 Thread Shreyansh Jain
Currently examples/l3fwd/main.c has support for pktmbuf_pool per socket. L136: static struct rte_mempool * pktmbuf_pool[NB_SOCKETS]; In various setups, having a separate buffer pool per port (or even per queue) can achieve performance many-folds higher than single pool

Re: [dpdk-dev] [PATCH] doc: announce deprecation of rawdev exposed array

2018-11-26 Thread Shreyansh Jain
On Saturday 24 November 2018 11:03 PM, Thomas Monjalon wrote: > 23/11/2018 17:32, Jerin Jacob: >> From: Shreyansh Jain >>> >>> rte_rawdevs is expected to be deprecated in future releases. This is >>> not expected to be directly used, without API access that is

Re: [dpdk-dev] [PATCH v5 0/4] introduces the enetc PMD driver

2018-11-22 Thread Shreyansh Jain
t >>> ... ... >>> Gagandeep Singh (4): >>>net/enetc: add ENETC PMD with basic operations >>>net/enetc: enable Rx and Tx >>>net/enetc: support packet parse type >>>doc: add usage doc for ENETC PMD >> >> For series, >&g

[dpdk-dev] [PATCH] doc: add tested NXP NICs information

2018-11-21 Thread Shreyansh Jain
18.11-rc4 verification done on NXP SoCs with integrated NICs. Signed-off-by: Shreyansh Jain --- doc/guides/rel_notes/release_18_11.rst | 12 1 file changed, 12 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst index

[dpdk-dev] [PATCH] doc: announce deprecation of dpaa2 exposed mem structure

2018-11-15 Thread Shreyansh Jain
rte_dpaa2_memsegs is no more required once the dpaax (pa-va) translation library has been introduced. This can be made internal (for fallback operations) in subsequent release. Signed-off-by: Shreyansh Jain --- This diff was generated over a previous patch on same file (a para before) [1] - so

[dpdk-dev] [PATCH] doc: announce deprecation of rawdev exposed array

2018-11-15 Thread Shreyansh Jain
rte_rawdevs is expected to be deprecated in future releases. This is not expected to be directly used, without API access that is, by any external application or driver. Signed-off-by: Shreyansh Jain --- This is in sync with discussion in [1] [1] http://mails.dpdk.org/archives/dev/2018

Re: [dpdk-dev] [PATCH 1/2] bus/dpaa: fix build with gcc 9.0

2018-11-01 Thread Shreyansh Jain
gt; > Signed-off-by: Ferruh Yigit > --- I don't have gcc 9.0 environment to verify this, but the fix looks reasonable to me: Acked-by: Shreyansh Jain

Re: [dpdk-dev] [PATCH] eal: don't double space init alert messages

2018-10-24 Thread Shreyansh Jain
linuxapp/eal/eal.c | 28 ++-- > 2 files changed, 26 insertions(+), 26 deletions(-) > Reviewed-by: Shreyansh Jain

[dpdk-dev] [PATCH] common/dpaax: fix incorrect error case

2018-10-23 Thread Shreyansh Jain
om Signed-off-by: Shreyansh Jain --- drivers/common/dpaax/dpaax_iova_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c index d54267bb7..19a4e8c58 100644 --- a/drivers/common/dpaax/dpaax_io

[dpdk-dev] [PATCH] raw/skeleton_rawdev: fix memory leak on test failure

2018-10-23 Thread Shreyansh Jain
p.com Signed-off-by: Shreyansh Jain --- drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c index 3405b8984..359c9e296 1006

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-23 Thread Shreyansh Jain
On Tuesday 23 October 2018 03:21 PM, Ferruh Yigit wrote: > On 10/23/2018 8:09 AM, Shreyansh Jain wrote: >> Besides the comment I sent before about 'Fixes' before sign-off, a >> single trivial comment inline ... >> >> On Tuesday 23 October 2018 07:20 AM,

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-23 Thread Shreyansh Jain
free(name); > > - return 0; > + return ret; > } > > static int > Otherwise, the patch is simple enough. Acked-by: Shreyansh Jain

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-22 Thread Shreyansh Jain
On Tuesday 23 October 2018 07:20 AM, Rosen Xu wrote: > This patch fixes rte_eal_hotplug_add without checking return value issue > > Signed-off-by: Rosen Xu > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen...@intel.com > --- Fixes comes *before* signed-off. ..

Re: [dpdk-dev] [PATCH] doc: show internal functions in doxygen

2018-10-21 Thread Shreyansh Jain
On Friday 19 October 2018 01:09 PM, Ferruh Yigit wrote: > On 10/18/2018 6:04 PM, Thomas Monjalon wrote: >> 18/10/2018 18:22, Ferruh Yigit: >>> On 10/18/2018 5:08 PM, Thomas Monjalon wrote: Not sure we want to show the internal functions to users. It may be useful only for PMD developers.

Re: [dpdk-dev] [PATCH v3 0/4] ethdev port freeing

2018-10-17 Thread Shreyansh Jain
On 10/17/2018 7:24 AM, Thomas Monjalon wrote: > [...] > > Note: this patchset depends on multi-process hotplug series by Qi Zhang, > which is accepted but waiting for an unrelated DPAA compilation issue > to be fixed, before landing on master tree. > Can you please point me to which DPAA comp

[dpdk-dev] [PATCH v2 3/3] net/dpaa2: convert logs from errors to debug

2018-10-17 Thread Shreyansh Jain
In case the link is down during initial link state check, messages for link state check flood the console. Reducing the log level for these. Signed-off-by: Shreyansh Jain --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH v2 2/3] bus/fslmc: ignore dpaax pa-va table errors

2018-10-17 Thread Shreyansh Jain
Presence of PA-VA Table is transparent to the drivers. Ignoring the return values from table update call. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_bus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc

[dpdk-dev] [PATCH v2 1/3] common/dpaax: reduce logging level

2018-10-17 Thread Shreyansh Jain
relevant at higher log level, either. Signed-off-by: Shreyansh Jain --- drivers/common/dpaax/dpaax_iova_table.c | 35 + 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c index

[dpdk-dev] [PATCH v2 0/3] Reduce logging level for dpaax and fslmc

2018-10-17 Thread Shreyansh Jain
erved which shouldn't necessarily be ERR. Changed them to DEBUG. [1] http://mails.dpdk.org/archives/dev/2018-October/116096.html Version History: v2: - Added patch description in patch 1 Shreyansh Jain (3): common/dpaax: reduce logging level bus/fslmc: ignore dpaax pa-va table er

Re: [dpdk-dev] dpaax warnings

2018-10-17 Thread Shreyansh Jain
On Wednesday 17 October 2018 11:29 AM, Shreyansh Jain wrote: > On Wednesday 17 October 2018 03:57 AM, Thomas Monjalon wrote: >> Hi Shreyansh, >> >> When initializing DPDK on x86, we get those warnings: >> dpaax: Unable to glob device-tree memory node: >> (/p

[dpdk-dev] [PATCH 3/3] net/dpaa2: convert logs from errors to debug

2018-10-17 Thread Shreyansh Jain
In case the link is down during initial link state check, messages for link state check flood the console. Reducing the log level for these. Signed-off-by: Shreyansh Jain --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH 0/3] Reduce logging level for dpaax and fslmc

2018-10-17 Thread Shreyansh Jain
erved which shouldn't necessarily be ERR. Changed them to DEBUG. [1] http://mails.dpdk.org/archives/dev/2018-October/116096.html Shreyansh Jain (3): common/dpaax: reduce logging level bus/fslmc: ignore dpaax pa-va table errors net/dpaa2: convert logs from errors to debug d

  1   2   3   4   5   6   7   8   9   10   >