> -Original Message-
> From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com]
> Sent: Tuesday, January 2, 2018 4:07 PM
> To: Shachar Beiser
> Cc: dev@dpdk.org; Adrien Mazarguil
> Subject: Re: [PATCH v4] net/mlx5: load libmlx5 and libibverbs in run-time
>
>
MLX5 PMD loads libraries: libibverbs and libmlx5.
MLX5 PMD is not linked to external libraries.
Signed-off-by: Shachar Beiser
---
v1:
load external libraries in run-time
v2:
* fix checkpatch warnings
v3:
* fix checkpatch warnings
v4:
New MACROs in order to reuse code
Support IPv6 header vtc_flow fields : tc , flow_label
Signed-off-by: Shachar Beiser
---
lib/librte_net/rte_ip.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 73ec398..75b9cc3 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib
There are parameters that are not copy from
spec to verbs structure in the vtc_label
Fixes: 43e9d97 ("net/mlx5: support upstream rdma-core")
Cc: sta...@dpdk.org
Signed-off-by: Shachar Beiser
---
drivers/net/mlx5/mlx5_flow.c | 19 ++-
1 file changed, 18 insertions(+),
MLX4 PMD dynamically loads mlx4 and ibverbs in
run-time and it is not linked to external libraries.
Signed-off-by: Shachar Beiser
---
v1:
load external libraries in run-time
v2:
fix checkpatch warnings
v3:
fix checkpatch warnings
---
config/common_base
MLX5 PMD loads libraries: libibverbs and libmlx5.
MLX5 PMD is not linked to external libraries.
Signed-off-by: Shachar Beiser
---
v1:
load external libraries in run-time
v2
* fix checkpatch warnings
v3:
* fix checkpatch warnings
---
config/common_base
MLX4 PMD dynamically loads mlx4 and ibverbs in
run-time and it is not linked to external libraries.
Signed-off-by: Shachar Beiser
---
History:
V1: http://dpdk.org/dev/patchwork/patch/31555/
V2:
Fixing checkpatch code styling warnings
---
config/common_base
MLX5 PMD loads libraries: libibverbs and libmlx5.
MLX5 PMD is not linked to external libraries.
Signed-off-by: Shachar Beiser
---
History:
V1:
http://dpdk.org/patch/31555
V2:
* Fixing checkpatch coding style issues
---
config/common_base | 1 +
drivers/net/mlx5
MLX4 PMD dynamically loads mlx4 and ibverbs in
run-time and it is not linked to external libraries.
Signed-off-by: Shachar Beiser
---
config/common_base | 1 +
drivers/net/mlx4/Makefile | 14 +-
drivers/net/mlx4/lib/mlx4_dll.c | 731
MLX5 PMD loads libraries: libibverbs and libmlx5.
MLX5 PMD is not linked to external libraries.
Signed-off-by: Shachar Beiser
---
config/common_base | 1 +
drivers/net/mlx5/Makefile| 27 +-
drivers/net/mlx5/lib/mlx5_dll.c | 758
Signed-off-by: Shachar Beiser
---
Rebase on top of series:
http://dpdk.org/dev/patchwork/patch/28804/
http://dpdk.org/dev/patchwork/patch/28805/
This patch should be applied on top of :
http://dpdk.org/dev/patchwork/patch/28805/
This patch enhances the commit log of the previous patch:
http
to wait till kernel 4.14
Signed-off-by: Shachar Beiser
---
This patch enhances the commit log of the previous patch:
http://dpdk.org/dev/patchwork/patch/28803/
An update to the release notes will be sent saperately
by Shahaf Shuler.
---
doc/guides/nics/mlx5.rst | 32 +++--
driver
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Monday, September 18, 2017 12:07 PM
> To: Shachar Beiser ; dev@dpdk.org
> Cc: Adrien Mazarguil ; Nélio Laranjeiro
>
> Subject: Re: [dpdk-dev] [PATCH v5] net/mlx5: support upstream r
> -Original Message-
> From: Yongseok Koh
> Sent: Friday, September 15, 2017 11:50 PM
> To: Shachar Beiser
> Cc: dev@dpdk.org; Adrien Mazarguil ; Nélio
> Laranjeiro
> Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/mlx5: replace network to host
> macros
>
>
&
Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
Cc: sta...@dpdk.org
Signed-off-by: Shachar Beiser
---
I have rebased last patch [PATCH v3 2/2] net/mlx5: fix TSO MLNX OFED 3.3
verification
---
drivers/net/mlx5/mlx5_prm.h | 3 ---
1 file changed, 3 deletion
Signed-off-by: Shachar Beiser
---
I have rebased [PATCH v3 1/2] net/mlx5: replace network to host macros
I have fixed a rebase conflict in mlx5_rxtx.h in line 609
-rte_wmb();
+rte_io_wmb();
---
drivers/net/mlx5/mlx5_mac.c | 8 +-
drivers/net/mlx5/mlx5_mr.c | 2 +-
drivers
wait till kernel 4.14
Signed-off-by: Shachar Beiser
---
I have rebased again the [PATCH v5] "net/mlx5: support upstream rdma-core"
Rdma-core upstream & Mellanox OFED are Linux user-space packages :
1. Rdma-core is the Linux upstream user-space package. (generic)
2. Mellanox OFED
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Thursday, September 14, 2017 4:47 PM
> To: Shachar Beiser ; dev@dpdk.org
> Cc: Adrien Mazarguil ; Nélio Laranjeiro
>
> Subject: Re: [dpdk-dev] [PATCH v5] net/mlx5: support upstream r
Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
Cc: sta...@dpdk.org
Signed-off-by: Shachar Beiser
---
There are only 2 patches left since
I have squashed :
[PATCH v2 3/3] “net/mlx5: fix interrupt enable return”
http://dpdk.org/dev/patchwork/patch/28380/
into [d
Signed-off-by: Shachar Beiser
---
There are only 2 patches left since
I have squashed :
[PATCH v2 3/3] “net/mlx5: fix interrupt enable return”
http://dpdk.org/dev/patchwork/patch/28380/
into [dpdk-dev,v5] net/mlx5: support upstream rdma-core
---
drivers/net/mlx5/mlx5_mac.c | 8
commit f11292efd541 ("Merge pull request #202")
b. Tested with linux kernel 4.13-rc4
c. For performance testing recommended to wait till kernel 4.14
Signed-off-by: Shachar Beiser
---
doc/guides/nics/mlx5.rst | 32 +++--
drivers/net/mlx5/Makefile| 23 ++--
driver
wait till kernel 4.14
Signed-off-by: Shachar Beiser
---
doc/guides/nics/mlx5.rst | 32 +++--
drivers/net/mlx5/Makefile| 23 ++--
drivers/net/mlx5/mlx5.c | 97 ---
drivers/net/mlx5/mlx5.h | 4 +-
drivers/net/mlx5/mlx5_ethdev.c
am
pretty sure that this ret value was not initialized.
-Shachar Beiser.
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> Sent: Tuesday, September 5, 2017 4:27 PM
> To: Shachar Beiser
> Cc: dev@dpdk.org; Nélio Laranjeiro ;
&g
wait till kernel 4.14
Signed-off-by: Shachar Beiser
---
doc/guides/nics/mlx5.rst | 32 +++--
drivers/net/mlx5/Makefile| 23 ++--
drivers/net/mlx5/mlx5.c | 97 ---
drivers/net/mlx5/mlx5.h | 4 +-
drivers/net/mlx5/mlx5_ethdev.c
return value is sometimes returned uninitialized
Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management")
Fixes: b18042fb8f49 ("net/mlx5: fix misplaced Rx interrupts functions")
Cc: adrien.mazarg...@6wind.com
Cc: sta...@dpdk.org
Signed-off-by: Shachar Beiser
-
Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
Cc: sta...@dpdk.org
Signed-off-by: Shachar Beiser
---
drivers/net/mlx5/mlx5_prm.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_prm.h b/drivers/net/mlx5/mlx5_prm.h
index 608072f..8b82
Signed-off-by: Shachar Beiser
---
drivers/net/mlx5/mlx5_mac.c | 8 ++-
drivers/net/mlx5/mlx5_mr.c | 2 +-
drivers/net/mlx5/mlx5_rxmode.c | 8 ++-
drivers/net/mlx5/mlx5_rxq.c | 9 +--
drivers/net/mlx5/mlx5_rxtx.c | 131
Does it OK to change it to :
" Fixes: 1be17b6a5539 ("eal: introduce big and little endian types")"
?
> -Original Message-
> From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com]
> Sent: Monday, September 4, 2017 6:15 PM
> To: Shachar Beiser
>
OK,
I will fix to " commit e1016cb733 ("net/mlx5: fix Rx interrupts management") "
> -Original Message-
> From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com]
> Sent: Monday, September 4, 2017 6:24 PM
> To: Shachar Beiser
> Cc: dev@dpdk.org; A
wait till kernel 4.14
Signed-off-by: Shachar Beiser
---
This patch should be applied after the series:
http://dpdk.org/dev/patchwork/patch/28325/
Ack.
--
Nélio Laranjeiro
6WIND
---
doc/guides/nics/mlx5.rst | 32 +++--
drivers/net/mlx5/Makefile| 23 ++--
drivers/net/m
Fixes: 8bb5119634b7 ("net/mlx5: replace network byte order macro")
Cc: shacha...@mellanox.com
Signed-off-by: Shachar Beiser
---
drivers/net/mlx5/mlx5_mac.c | 8 ++-
drivers/net/mlx5/mlx5_mr.c | 2 +-
drivers/net/mlx5/mlx5_rxmode.c | 8 ++-
driver
Fixes: 3c7d44af252a ("net/mlx5: support user space Rx interrupt event")
Cc: sta...@dpdk.org
Signed-off-by: Shachar Beiser
---
drivers/net/mlx5/mlx5_rxq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
ind
Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
Cc: sta...@dpdk.org
Signed-off-by: Shachar Beiser
---
drivers/net/mlx5/mlx5_prm.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_prm.h b/drivers/net/mlx5/mlx5_prm.h
index 608072f..8b82
Yes , off course .
In my next patch the rdma-core is master
f11292efd54132e09c9586a72c6c7bd0f341659d.
I will add that to the patch in the cover letter.
-Shachar Beiser.
shacharbe@pegasus08-006:~/rdma-core$ git remote --v
origin http://l-gerrit.mtl.labs.mlnx:8080/upstream/rdma-core.git
This removes the dependency on specific Mellanox OFED libraries by
using the upstream rdma-core and linux upstream community code.
Minimal requirements: rdma-core v16 and Kernel Linux 4.14.
Signed-off-by: Shachar Beiser
---
doc/guides/nics/mlx5.rst | 29 +-
drivers/net/mlx5
Tested-by : Shachar Beiser
The bug is fixed and now there is no crash:
testpmd> port stop all
Stopping ports...
Done
testpmd> port close all
Closing ports...
Done
testpmd> port detach 0
Detaching a port...
Invalid port 0
Please close port first
testpmd> show port info 0
Invalid
Hi ,
When I say close I mean : " mlx5_dev_close" . This function set the
priv->ctx to NULL.
We think this patch is required because we have an open bug of seg fault
while accessing priv->ctx == NULL.
-Shachar Beiser.
-
.@dpdk.org
Signed-off-by: Shachar Beiser
---
drivers/net/mlx5/mlx5_ethdev.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index b70b7b9..6e67461 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
Missing room in flow allocation to store the drop specification.
Changing flow without storing the change in rte_flow.
Fixes: 88c77dedfbb0 ("net/mlx5: implement drop action in hardware classifier")
Signed-off-by: Shachar Beiser
---
drivers/net/mlx5/mlx5_flow.c | 10 +++---
1 file
Shachar Beiser (1):
net/mlx5: fix drop action seg fault
drivers/net/mlx5/mlx5_flow.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
--
1.8.3.1
Shachar Beiser (1):
net/mlx5: fix drop action seg fault
drivers/net/mlx5/mlx5_flow.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
--
1.8.3.1
Missing room in flow allocation to store the drop specification.
Changing flow without storing the change in rte_flow.
Fixes: 88c77dedfbb0 ("net/mlx5: implement drop action in hardware classifier")
Signed-off-by: Shachar Beiser
---
drivers/net/mlx5/mlx5_flow.c | 10 +++---
1 file
Missing room in flow allocation to store the drop specification.
Changing flow without storing the change in rte_flow.
Fixes: 88c77dedfbb0 ("net/mlx5: implement drop action in hardware classifier")
Signed-off-by: Shachar Beiser
---
drivers/net/mlx5/mlx5_flow.c | 8 +---
1 file
-off-by: Shachar Beiser
---
drivers/net/mlx5/Makefile| 5 +
drivers/net/mlx5/mlx5_flow.c | 17 +
2 files changed, 22 insertions(+)
diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
index c079959..daf8013 100644
--- a/drivers/net/mlx5/Makefile
+++ b
remove/add blank line according to convensions
Shachar Beiser (1):
net/mlx5: implement drop action in hardware classifier
drivers/net/mlx5/Makefile| 5 +
drivers/net/mlx5/mlx5_flow.c | 17 +
2 files changed, 22 insertions(+)
--
1.8.3.1
remove/add blank line according to convensions
Shachar Beiser (1):
net/mlx5: implement drop action in hardware classifier
drivers/net/mlx5/Makefile| 5 +
drivers/net/mlx5/mlx5_flow.c | 17 +
2 files changed, 22 insertions(+)
--
1.8.3.1
-off-by: Shachar Beiser
---
drivers/net/mlx5/Makefile| 5 +
drivers/net/mlx5/mlx5_flow.c | 19 +++
2 files changed, 24 insertions(+)
diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
index c079959..daf8013 100644
--- a/drivers/net/mlx5/Makefile
+++ b
This revision change the define MLX5_DROP_WQ_N according to the
OFED support . #ifdef HAVE_ MLX5_DROP_WQ_N = 1 #else
MLX5_DROP_WQ_N = 4
Shachar Beiser (1):
net/mlx5: implement drop action in hardware classifier
drivers/net/mlx5/Makefile| 5 +
drivers/net/mlx5/mlx5_flow.c | 19
élio Laranjeiro [mailto:nelio.laranje...@6wind.com]
Sent: Monday, May 29, 2017 4:08 PM
To: Shachar Beiser
Cc: dev@dpdk.org; Adrien Mazarguil
Subject: Re: [PATCH] net/mlx5: implement drop action in hardware classifier
On Sun, May 28, 2017 at 06:49:20AM +0000, Shachar Beiser wrote:
> The curre
-off-by: Shachar Beiser
---
drivers/net/mlx5/Makefile| 5 +
drivers/net/mlx5/mlx5_flow.c | 43 +++
2 files changed, 48 insertions(+)
diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
index c079959..daf8013 100644
--- a/drivers/net
-off-by: Shachar Beiser
---
drivers/net/mlx5/Makefile| 5 +
drivers/net/mlx5/mlx5_flow.c | 43 +++
2 files changed, 48 insertions(+)
diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
index c079959..daf8013 100644
--- a/drivers/net
51 matches
Mail list logo
