Thanks for noticing it. We will take it into account and address the issue.
From: Stephen Hemminger
Sent: 29 June 2025 01:20
To: Oleksandr Kolomeiets
Cc: dev@dpdk.org ; Mykola Kostenok ; Serhii
Iliushyk ; Christian Koue Muf
Subject: Re: [PATCH v1 0/4] net/ntnic
From: Oleksandr Kolomeiets
Perform unmapping in a default container, which is used by queues.
Handle multiple mappings when IOMMU is unoptimized.
Fixes: c1c139535591 ("net/ntnic: add VFIO module")
Signed-off-by: Oleksandr Kolomeiets
---
drivers/net/ntnic/include/ntos_drv.h | 1 +
drivers/net
From: Oleksandr Kolomeiets
Handle rx_deferred_start and tx_deferred_start flags
during configuration done in rx_queue_setup and tx_queue_setup,
so that marked queues do not start with dev_start.
Signed-off-by: Oleksandr Kolomeiets
---
drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 46
From: Oleksandr Kolomeiets
The following functions exported by the driver were stubs
which merely changed the status flags:
* rx_queue_start
* rx_queue_stop
* tx_queue_start
* tx_queue_stop
Proper implementation was added to control queues's state.
Signed-off-by: Oleksan
This patchset includes:
* feature start/stop queues on HW layer.
* feature deferred start for queues.
* Improvement for memory mappings when IOMMU is unoptimized.
v2 removes unnecessary log and adds fixed tag to the commit message.
Oleksandr Kolomeiets (3):
net/ntnic: implement start/stop
e; we will gladly discuss them.
Thanks,
Serhii
From: Stephen Hemminger
Sent: 22 February 2025 23:41
To: Serhii Iliushyk
Cc: dev@dpdk.org ; Mykola Kostenok ;
Christian Koue Muf
Subject: Re: [PATCH v1 00/32] add new adapter NT400D13
On Thu, 20 Feb 2025 23:03:24 +0
Compiling without enabled RTE_ASSERT leads to an error during
initialization
Fix incorrect assert conditions
Fixes: ff04525d90d3 ("net/ntnic: replace assert with RTE assert")
Signed-off-by: Serhii Iliushyk
---
v2
* Remove ifdef wrapper
---
drivers/net/ntnic/adapter/nt4ga_adapter.c
Compiling without enabled RTE_ASSERT leads to an error during
initialization
Fix incorrect assert conditions
Fixes: ff04525d90d3 ("net/ntnic: replace assert with RTE assert")
Signed-off-by: Serhii Iliushyk
---
v2
* Remove ifdef wrapper
---
drivers/net/ntnic/adapter/nt4ga_adapter.c
Compiling without enabled RTE_ASSERT leads to an error during
initialization
Fix incorrect assert conditions
Fixes: ff04525d90d3 ("net/ntnic: replace assert with RTE assert")
Signed-off-by: Serhii Iliushyk
---
drivers/net/ntnic/adapter/nt4ga_adapter.c | 8 +---
drivers
Compiling without enabled RTE_ASSERT leads to an error during
initialization
Fix incorrect assert conditions
Fixes: ff04525d90d3 ("net/ntnic: replace assert with RTE assert")
Signed-off-by: Serhii Iliushyk
---
drivers/net/ntnic/adapter/nt4ga_adapter.c | 8 +---
drivers
Check return value from the malloc code
Signed-off-by: Serhii Iliushyk
---
drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 10 ++
drivers/net/ntnic/nthw/nthw_rac.c | 5 -
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ntnic/dbsconfig
Add nthw prefix to functions with abstract names
to avoid exposing global symbols
Signed-off-by: Serhii Iliushyk
---
drivers/net/ntnic/adapter/nt4ga_adapter.c | 6 +-
.../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 6 +-
drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 32 +--
drivers
Use RTE_ASSERT instead of direct calling asserts
Signed-off-by: Serhii Iliushyk
---
drivers/net/ntnic/adapter/nt4ga_adapter.c | 14 ++-
drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 6 +-
drivers/net/ntnic/include/flow_api.h | 2 +-
.../link_mgmt/link_100g/nt4ga_link_100g.c
This patchset contains bugfixes and cleanup for the ntnic PMD
* add SPDX tag
* rename clock registers file
* replace assert with RTE assert
* check result of malloc
* add 'nthw' prefix function names
Serhii Iliushyk (5):
net/ntnic: add SPDX tag
net/ntnic: rename clock regi
Add missed SPDX tag
Signed-off-by: Serhii Iliushyk
---
.../include/NT400D13_U62_Si5332-GM2-RevD-1_V5-Registers.h| 5 +
1 file changed, 5 insertions(+)
diff --git
a/drivers/net/ntnic/nthw/core/include/NT400D13_U62_Si5332-GM2-RevD-1_V5-Registers.h
b/drivers/net/ntnic/nthw/core/include
Rename this files to align the file naming
Signed-off-by: Serhii Iliushyk
---
...egisters.h => nt400d13_u62_si5332_gm2_revd_1_v5_registers.h} | 0
...0_v5-Registers.h => nt200a02_u23_si5340_adr0_v5_registers.h} | 0
.../ntnic/nthw/core/nt200a0x/clock_profiles/nthw_fpga_clk9563.c | 2 +-
d
On 05.03.2025, 19:03, "David Marchand" wrote:
On Thu, Feb 20, 2025 at 11:06 PM Serhii Iliushyk wrote:
> diff --git
> a/drivers/net/ntnic/nthw/core/include/NT400D13_U62_Si5332-GM2-RevD-1_V5-Registers.h
>
> b/drivers/net/ntnic/nthw/core/include/NT400D13_U62_Si5332-GM2
Add initialization for the clock subsystem
Signed-off-by: Serhii Iliushyk
---
...00D13_U62_Si5332-GM2-RevD-1_V5-Registers.h | 425 ++
.../net/ntnic/nthw/core/include/nthw_i2cm.h | 1 +
.../nthw/core/include/nthw_pcm_nt400dxx.h | 14 +
.../nthw/core/include
From: Danylo Vodopianov
- Initialize IGAM module and check for its presence.
- Enable system PLL using IGAM and check for PLL lock status.
- Reset and configure TS PLL and check for lock status.
- Force HIF soft reset and de-assert platform reset.
- Enable RAB1 and RAB2 and perform RAB initializa
From: Danylo Vodopianov
Create and initialize I2C for FPGA.
Signed-off-by: Danylo Vodopianov
---
.../net/ntnic/nthw/core/include/nthw_i2cm.h | 2 +
.../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 7 ++
drivers/net/ntnic/nthw/core/nthw_i2cm.c | 82 +++
3 files changed,
From: Danylo Vodopianov
Add NIM reset and low power functions with presence check
- Implement nim_set_reset function to handle NIM reset.
- Implement set_nim_low_power function to manage
NIM power state.
- Add code to check NIM presence before performing reset.
Signed-off-by: Danylo Vodopianov
From: Danylo Vodopianov
Implement PHY host loopback configuration for Agilex FPGA
Signed-off-by: Danylo Vodopianov
---
.../link_agx_100g/nt4ga_agx_link_100g.c | 116 ++
drivers/net/ntnic/meson.build | 1 +
drivers/net/ntnic/nim/i2c_nim.c |
The changes for untrusted loop bound breaks VLAN processing
This reverts commit 36cd2cb0eea49813dd59ee1df2eb592e8ae5b6b4.
Signed-off-by: Serhii Iliushyk
---
drivers/net/ntnic/ntnic_filter/ntnic_filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ntnic
From: Danylo Vodopianov
Add initialization for I2C mux and LED driver.
Signed-off-by: Danylo Vodopianov
---
.../ntnic/nthw/core/include/nthw_pca9532.h| 3 +++
.../nthw/core/include/nthw_si5332_si5156.h| 3 +++
.../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 23 +++
dr
From: Danylo Vodopianov
Add initialization and logging for Phy Tile module.
Signed-off-by: Danylo Vodopianov
---
.../ntnic/nthw/core/include/nthw_phy_tile.h | 39 ++
.../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 16 +
drivers/net/ntnic/nthw/core/nthw_phy_tile.c | 598 ++
From: Danylo Vodopianov
Create and initialize IGAM module.
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/meson.build | 1 +
.../net/ntnic/nthw/core/include/nthw_igam.h | 37 +++
.../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 4 ++
drivers/net/ntnic/nthw/co
From: Danylo Vodopianov
Add initialization for I/O expanders and configure TS settings.
Signed-off-by: Danylo Vodopianov
---
.../ntnic/nthw/core/include/nthw_pcal6416a.h | 3 +
.../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 69 +++
drivers/net/ntnic/nthw/core/nthw_pcal6416a.
From: Danylo Vodopianov
Reset platform and peripherals for PRM initialization.
Signed-off-by: Danylo Vodopianov
---
.../net/ntnic/nthw/core/include/nthw_prm_nt400dxx.h | 2 ++
.../core/nt400dxx/reset/nthw_fpga_rst_nt400dxx.c| 13 +
drivers/net/ntnic/nthw/core/nthw_prm_nt400dxx
From: Danylo Vodopianov
- Implement nthw_spi_v3 module with initialization, transfer, and
utility functions.
- Add nthw_spim and nthw_spis modules for SPI primary and secondary
interfaces.
- Include SPI v3 header files and update meson build configuration.
- Implement AVR probe function to retrie
From: Danylo Vodopianov
Initialize and create PCM for FPGA and HIF modules
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/meson.build | 1 +
.../nthw/core/include/nthw_pcm_nt400dxx.h | 24 +++-
.../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 18 ++
.../net/
Add reset functions and reset procedure for module PHY FTILE
Signed-off-by: Serhii Iliushyk
---
.../ntnic/nthw/core/include/nthw_phy_tile.h | 12 ++
.../core/nt400dxx/reset/nthw_fpga_rst9574.c | 161 ++
drivers/net/ntnic/nthw/core/nthw_phy_tile.c | 38 +
3 files
From: Danylo Vodopianov
Initialize RAB0 and create PRM for FPGA.
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/meson.build | 1 +
.../nthw/core/include/nthw_prm_nt400dxx.h | 30 +
.../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 11 +
.../net/ntnic/
From: Danylo Vodopianov
Add HIF clock test with write/read verification.
Signed-off-by: Danylo Vodopianov
---
.../net/ntnic/nthw/core/include/nthw_hif.h| 3 +
.../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 20 +
drivers/net/ntnic/nthw/core/nthw_hif.c| 82 +++
Add DDR4 reset and calibration completion handling.
Signed-off-by: Serhii Iliushyk
---
.../core/nt400dxx/reset/nthw_fpga_rst9574.c | 29 ++-
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ntnic/nthw/core/nt400dxx/reset/nthw_fpga_rst9574.c
b/drivers
Add DDR4 reset and calibration functions for FPGA.
Signed-off-by: Serhii Iliushyk
---
.../core/nt400dxx/reset/nthw_fpga_rst9574.c | 95 +++
1 file changed, 95 insertions(+)
diff --git a/drivers/net/ntnic/nthw/core/nt400dxx/reset/nthw_fpga_rst9574.c
b/drivers/net/ntnic/nthw
Add function and structures required to init the new NIC NT400D13
Signed-off-by: Serhii Iliushyk
---
doc/guides/nics/ntnic.rst | 7 +-
doc/guides/rel_notes/release_25_03.rst| 4
drivers/net/ntnic/meson.build | 1 +
.../net/ntnic/nthw/core
Initialize FPGA reset module and register fields.
Signed-off-by: Serhii Iliushyk
---
.../core/nt400dxx/reset/nthw_fpga_rst9574.c | 54 +++
1 file changed, 54 insertions(+)
diff --git a/drivers/net/ntnic/nthw/core/nt400dxx/reset/nthw_fpga_rst9574.c
b/drivers/net/ntnic/nthw
From: Danylo Vodopianov
Configure FEC and TX equalization for 100G NIM on Agilex FPGA
Signed-off-by: Danylo Vodopianov
---
.../link_agx_100g/nt4ga_agx_link_100g.c | 122
drivers/net/ntnic/nim/i2c_nim.c | 80 +
drivers/net/ntnic/nim/i2c_nim.h |
Define and register FPGA reset operations.
Signed-off-by: Serhii Iliushyk
---
.../include/ntnic_nthw_fpga_rst_nt400dxx.h| 34 +++
drivers/net/ntnic/meson.build | 2 +
.../nthw/core/nt400dxx/nthw_fpga_nt400dxx.c | 88 ++-
.../core/nt400dxx/reset
From: Danylo Vodopianov
Implement PHY line loopback configuration for Agilex FPGA
Signed-off-by: Danylo Vodopianov
---
.../link_agx_100g/nt4ga_agx_link_100g.c | 111 ++
.../ntnic/nthw/core/include/nthw_phy_tile.h | 1 +
drivers/net/ntnic/nthw/core/nthw_phy_tile.c |
From: Danylo Vodopianov
Handle NIM module insertion and initialization
Signed-off-by: Danylo Vodopianov
---
.../link_agx_100g/nt4ga_agx_link_100g.c | 33 +++
1 file changed, 33 insertions(+)
diff --git a/drivers/net/ntnic/link_mgmt/link_agx_100g/nt4ga_agx_link_100g.c
b/
From: Danylo Vodopianov
Added logic to check if the administrative port state
has changed.
Signed-off-by: Danylo Vodopianov
---
.../link_agx_100g/nt4ga_agx_link_100g.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/net/ntnic/link_mgmt/link_agx_100g/nt4ga
From: Danylo Vodopianov
Add link state management and NIM reset functionality
- Implement phy_get_link_state to retrieve PHY link state.
- Implement adjust_maturing_delay to adjust link maturing delay.
- Implement get/set to operate current link state.
Signed-off-by: Danylo Vodopianov
---
...
From: Danylo Vodopianov
Initialize NIM and 100G port for Agilex FPGA
Signed-off-by: Danylo Vodopianov
---
.../link_agx_100g/nt4ga_agx_link_100g.c | 143 ++
drivers/net/ntnic/meson.build | 1 +
.../net/ntnic/nthw/core/include/nthw_gmf.h| 2 +
.../nt
From: Danylo Vodopianov
RPF and GFG modules initialization were added.
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/include/nt4ga_link.h| 2 +
drivers/net/ntnic/include/nthw_gfg.h | 33 ++
.../link_agx_100g/nt4ga_agx_link_100g.c | 24 ++
drivers/net/ntnic/m
From: Danylo Vodopianov
Minimal 100g agx link state machine implementation was added.
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/include/nt4ga_link.h| 5 +
.../link_agx_100g/nt4ga_agx_link_100g.c | 111 ++
2 files changed, 116 insertions(+)
diff --g
From: Danylo Vodopianov
Initialize NIM and PHY settings for Agilex FPGA ports
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/include/ntnic_nim.h | 5 +
.../link_agx_100g/nt4ga_agx_link_100g.c | 86 -
drivers/net/ntnic/meson.build | 1 +
driver
From: Danylo Vodopianov
Minimal implementation for link agx 100g was added.
Add support for NT400D13 (Intel Agilex FPGA) link operations.
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/adapter/nt4ga_adapter.c | 9
.../link_agx_100g/nt4ga_agx_link_100g.c | 42 +++
Serhii Iliushyk (9):
net/ntnic: add minimal initialization new NIC NT400D13
net/ntnic: add minimal reset FPGA
net/ntnic: add FPGA modules and registers
net/ntnic: add setup for fpga reset
net/ntnic: add default reset setting for NT400D13
net/ntnic: add DDR calibration to reset stage
On Wed, 5 Feb 2025 11:45:09 +0100
Serhii Iliushyk wrote:
> This patch set addresses fixing issues in the ntnic PMD driver.
>
> Changes in this patch:
>
> The issues detected by the Coverity Scan tool.
> The problems that were detected by the internal tests.
> Fix for B
Remove the shutdown thread and SIGINT handling on the level of PMD
Signed-off-by: Serhii Iliushyk
---
drivers/net/ntnic/ntnic_ethdev.c | 63
1 file changed, 7 insertions(+), 56 deletions(-)
diff --git a/drivers/net/ntnic/ntnic_ethdev.c b/drivers/net/ntnic
From: Danylo Vodopianov
CI found couple coverity problems which were fixed in this commit.
CID: 448983 Out-of-bounds write (OVERRUN).
These issues were fixed with updating index verification statement.
Coverity issue: 448983
Fixes: 96c8249be53e ("net/ntnic: learn flow queue handling")
Signed-
From: Danylo Vodopianov
Add age event generating only for physical ports.
Fixes: 4033e0539435 ("net/ntnic: add flow meter")
Signed-off-by: Danylo Vodopianov
---
.../nthw/flow_api/profile_inline/flow_api_profile_inline.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git
From: Danylo Vodopianov
Fix overflow issue with checking max bit shifting value.
Coverity issue: 448921
Fixes: 833962ebb893 ("net/ntnic: add CAT module")
Signed-off-by: Danylo Vodopianov
---
.../nthw/flow_api/profile_inline/flow_api_profile_inline.c | 2 +-
1 file changed, 1 insertion(+)
From: Danylo Vodopianov
Casting either buf_size and num_descr to uint64_t before performing the
multiplication was done.
Coverity issue: 446740
Fixes: 6b0047fadf41 ("net/ntnic: add queue setup operations")
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/ntnic_ethdev.c | 2 +-
1 file ch
From: Danylo Vodopianov
CI found couple coverity problems which were fixed in this commit.
CID: 448965 Error handling issues (CHECKED_RETURN).
Thread return code check was added.
Coverity issue: 448965
Fixes: a1ba8c473f5c ("net/ntnic: add statistics poll")
Signed-off-by: Danylo Vodopianov
--
From: Danylo Vodopianov
Issue with potentially overflow was fixed.
CID 448944: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)
Coverity issue: 448944
Fixes: 339ca124e659 ("net/ntnic: add flow action modify field")
Signed-off-by: Danylo Vodopianov
---
.../nthw/flow_api/profile_inline/f
Since nitnic PMD driver for is fully added and verified,
the tag EXPERIMENTAL may be removed
Signed-off-by: Serhii Iliushyk
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b86cdd266b..b04951de85 100644
--- a/MAINTAINERS
+++ b
Remove unnecessary checks and logs.
Signed-off-by: Serhii Iliushyk
---
drivers/net/ntnic/nthw/core/nthw_fpga.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/net/ntnic/nthw/core/nthw_fpga.c
b/drivers/net/ntnic/nthw/core/nthw_fpga.c
index 88641145ec
Support for IP Fragmenter DROP counter to display number of packets
dropped due to size larger than MTU.
NOTE: Frames are dropped only in case that both IPV4_EN and IPV4_DF_DROP
are set to one (resp. their IPV6 counterparts).
Signed-off-by: Serhii Iliushyk
---
.../net/ntnic/adapter/nt4ga_stat
Following checks were added for `action modify`:
* range check to trigger an error in case that value is too large
* check for unsupported types of action modify for group 0
Signed-off-by: Serhii Iliushyk
---
.../profile_inline/flow_api_profile_inline.c | 89 ---
1 file changed
From: Danylo Vodopianov
Virtualization backward compatible RSS implementation is no longer
needed, thus RSS was refactored as follows:
* conversion of RTE_ETH_RSS fields into HSH registers was moved to
separate files
* profile wrapper for RSS configuration was removed
* flow_nic_set_hasher(), t
FPGA module mapping(to string) was extended with new fpga's modules.
Signed-off-by: Serhii Iliushyk
---
.../nthw/supported/nthw_fpga_mod_str_map.c| 24 +++
1 file changed, 24 insertions(+)
diff --git a/drivers/net/ntnic/nthw/supported/nthw_fpga_mod_str_map.c
b/driver
From: Danylo Vodopianov
Flow dump output was fixed to show original group
number for `jumps` stored in action and match sets.
Fixes: 6f0fe142caed ("net/ntnic: add flow dump")
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/include/flow_api_engine.h | 2 ++
drivers/net/ntnic/nthw/flo
From: Danylo Vodopianov
The FPGA scrub T parameter shall be encoded timeout using internal unit,
which is measured in 2^30 nanoseconds. It is approx 1.074 times longer
than age timeout specified in seconds. Internal method
hw_mod_flm_inf_sta_data_update_get() was updated to perform conversion
bet
From: Danylo Vodopianov
NTNIC currently cupport only 100G link.
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c
b/drivers/net/ntnic/adapter/nt4g
From: Oleksandr Kolomeiets
pld_ptr points to mp_port_load's element,
which is initialized during driver's probe,
otherwise probe fails and xstats_get_by_id is not called.
Coverity issue: 448945
Fixes: cf6007eac498 ("net/ntnic: add xstats")
Signed-off-by: Oleksandr Kolomeiets
---
drivers/net/n
From: Oleksandr Kolomeiets
Macro DO_COMPARE_INDEXS expects pointer to array.
If condition is true, one of array's elements get overwritten.
Misinterpreting pointer to pointer as pointer to array
may result in out-of-bounds access.
Coverity issue: 448966, 448970, 448971, 448972
Fixes: 6e8b7f11205
From: Danylo Vodopianov
if statement was modify to ensure that word_off
doesn't exceed the size of the array
Coverity issue: 448958
Fixes: 7fa0bf29e667 ("net/ntnic: add hash module")
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/nthw/flow_api/hw_mod/hw_mod_hsh.c | 2 +-
1 file change
From: Danylo Vodopianov
Unused code path in the condition irq_vector >= 0
because the condition irq_vector < 0 is already
established
Coverity issue: 446745
Fixes: 01e34ed9c756 ("net/ntnic: add availability monitor management")
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/dbsconfig/
From: Danylo Vodopianov
convert_error func was removed as far as this approach was deprecated.
Coverity issue: 448973
Fixes: e526adf1fdef ("net/ntnic: add minimal create/destroy flow operations")
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/include/create_elements.h | 1 -
drive
From: Danylo Vodopianov
free for kvlist was added before return to avoid memory leak.
Coveriry issue: 446751
Fixes: fe91ade9f5db ("net/ntnic: add basic queue operations")
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/ntnic_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
From: Danylo Vodopianov
Function operate with uint16_r value, meanwhile return value with
uint32_t size.
This conversion was aligned to the uint8_t as far as max value of the
return value could be equal 16.
Coverity issue: 446747
Fixes: 67aee0a69665 ("net/ntnic: add used writer data handling")
From: Danylo Vodopianov
Add null checking for fpga var.
Coverity issue: 448916
Fixes: 30b2f87ac650 ("net/ntnic: add GMF module")
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/link_mgmt/link_100g/nt4ga_link_100g.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
From: Danylo Vodopianov
p_fpga_mgr is properly freed when it's no longer needed
CID 440546: Resource leak (RESOURCE_LEAK)
Fixes: ddf184d0b6c2 ("net/ntnic: add FPGA initialization")
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/nthw/core/nthw_fpga.c | 2 ++
1 file changed, 2 insertion
From: Danylo Vodopianov
Fix issue with potential rereferencing a pointer
that might be NULL p->m_rpp_lr when calling
nthw_module_query_register
CID 448923: Dereference null return value (NULL_RETURNS)
Coverity issue: 448923
Fixes: f543ca6b9ab2 ("net/ntnic: add RPP local retransmit (RPP LR) flo
From: Danylo Vodopianov
Move null checking before using
Coverity issue: 446759
Fixes: f0fe222ea9cf ("net/ntnic: add releasing virtqueues")
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
From: Danylo Vodopianov
Replace while with if statement to avoid infinite loop
in case ther_type will be modified with extenral source.
Coverity issue: 448917
Fixes: c6821abf58e8 ("net/ntnic: add flow items GTP and actions raw
encap/decap")
Signed-off-by: Danylo Vodopianov
---
drivers/net/nt
From: Danylo Vodopianov
Unused code was removed.
CID: 448981 Logically dead code (DEADCODE)
Coverity issue: 448981
Fixes: e02fdb65c2a8 ("net/ntnic: add flow create/destroy")
Signed-off-by: Danylo Vodopianov
---
.../flow_api/profile_inline/flow_api_profile_inline.c| 9 ++---
1 file ch
From: Danylo Vodopianov
set eth_base to NULL after freeing to prevent
use-after-free
CID: 446746 Use after free (USE_AFTER_FREE)
Coverity issue: 446746
Fixes: 1d3f62a0c4f1 ("net/ntnic: add base init and deinit of flow API")
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/nthw/flow_api
From: Danylo Vodopianov
Issue was fixed with verification in case of the
successful memory re-allocation.
Coverity issue: 448959
Fixes: 4033e0539435 ("net/ntnic: add flow meter")
Signed-off-by: Danylo Vodopianov
---
.../profile_inline/flow_api_profile_inline.c | 15 ++-
1 fil
From: Danylo Vodopianov
CI found couple coverity problems which were fixed in this commit.
CID: 448983, 448980
Memory - corruptions (OVERRUN)
Add check both indices within bounds before calling the macro
Coverity issue: 448983
Fixes: 6e8b7f11205f ("net/ntnic: add categorizer (CAT) FPGA module
From: Danylo Vodopianov
CI found couple coverity problems which were fixed in this commit.
CID: 448984, 448982, 448975, 448969, 448968, 448967
API usage errors (BAD_COMPARE).
Add memcmp return value checking.
Coverity issue: 448984
Fixes: 6e8b7f11205f ("net/ntnic: add categorizer (CAT) FPGA m
Kolomeiets (2):
net/ntnic: remove extra address-of operator
net/ntnic: remove extra check for null
Serhii Iliushyk (6):
net/ntnic: extend module mapping
net/ntnic: refactoring of the FPGA initialization
net/ntnic: remove shutdown thread
net/ntnic: add checks for action modify
net/ntnic
From: Danylo Vodopianov
CI found couple coverity problems which were fixed in this commit.
CID: 448974, 448977, 448978 (OVERRUN).
These issues were fixed with updating index verification statement.
Coverity issue: 448974
Fixes: effa04693274 ("net/ntnic: add statistics")
Signed-off-by: Danylo
Since nitnic PMD driver for is fully added and verified,
the tag EXPERIMENTAL may be removed
Signed-off-by: Serhii Iliushyk
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b86cdd266b..b04951de85 100644
--- a/MAINTAINERS
+++ b
From: Danylo Vodopianov
CI found couple coverity problems which were fixed in this commit.
CID: 448965 Error handling issues (CHECKED_RETURN).
Thread return code check was added.
Coverity issue: 448965
Fixes: a1ba8c473f5c ("net/ntnic: add statistics poll")
Signed-off-by: Danylo Vodopianov
--
From: Danylo Vodopianov
set eth_base to NULL after freeing to prevent
use-after-free
CID: 446746 Use after free (USE_AFTER_FREE)
Coverity issue: 446746
Fixes: 1d3f62a0c4f1 ("net/ntnic: add base init and deinit of flow API")
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/nthw/flow_api
/ntnic: refactor RSS implementation
net/ntnic: fix age timeout recalculation into fpga unit
net/ntnic: rework age event generation
net/ntnic: fix group print
Oleksandr Kolomeiets (2):
net/ntnic: remove extra address-of operator
net/ntnic: remove extra check for null
Serhii Iliushyk (3
From: Danylo Vodopianov
Issue with potentially overflow was fixed.
CID 448944: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)
Coverity issue: 448944
Fixes: 339ca124e659 ("net/ntnic: add flow action modify field")
Signed-off-by: Danylo Vodopianov
---
.../nthw/flow_api/profile_inline/f
From: Danylo Vodopianov
Add age event generating only for physical ports.
Fixes: 4033e0539435 ("net/ntnic: add flow meter")
Signed-off-by: Danylo Vodopianov
---
.../nthw/flow_api/profile_inline/flow_api_profile_inline.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git
From: Danylo Vodopianov
Virtualization backward compatible RSS implementation is no longer
needed, thus RSS was refactored as follows:
* conversion of RTE_ETH_RSS fields into HSH registers was moved to
separate files
* profile wrapper for RSS configuration was removed
* flow_nic_set_hasher(), t
Remove unnecessary checks and logs.
Signed-off-by: Serhii Iliushyk
---
drivers/net/ntnic/nthw/core/nthw_fpga.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/net/ntnic/nthw/core/nthw_fpga.c
b/drivers/net/ntnic/nthw/core/nthw_fpga.c
index 88641145ec
From: Danylo Vodopianov
Flow dump output was fixed to show original group
number for `jumps` stored in action and match sets.
Fixes: 6f0fe142caed ("net/ntnic: add flow dump")
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/include/flow_api_engine.h | 2 ++
drivers/net/ntnic/nthw/flo
FPGA module mapping(to string) was extended with new fpga's modules.
Signed-off-by: Serhii Iliushyk
---
.../nthw/supported/nthw_fpga_mod_str_map.c| 24 +++
1 file changed, 24 insertions(+)
diff --git a/drivers/net/ntnic/nthw/supported/nthw_fpga_mod_str_map.c
b/driver
From: Danylo Vodopianov
NTNIC currently cupport only 100G link.
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c
b/drivers/net/ntnic/adapter/nt4g
From: Oleksandr Kolomeiets
Macro DO_COMPARE_INDEXS expects pointer to array.
If condition is true, one of array's elements get overwritten.
Misinterpreting pointer to pointer as pointer to array
may result in out-of-bounds access.
Coverity issue: 448966, 448970, 448971, 448972
Fixes: 6e8b7f11205
From: Danylo Vodopianov
The FPGA scrub T parameter shall be encoded timeout using internal unit,
which is measured in 2^30 nanoseconds. It is approx 1.074 times longer
than age timeout specified in seconds. Internal method
hw_mod_flm_inf_sta_data_update_get() was updated to perform conversion
bet
From: Danylo Vodopianov
free for kvlist was added before return to avoid memory leak.
Coveriry issue: 446751
Fixes: fe91ade9f5db ("net/ntnic: add basic queue operations")
Signed-off-by: Danylo Vodopianov
---
drivers/net/ntnic/ntnic_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
From: Oleksandr Kolomeiets
pld_ptr points to mp_port_load's element,
which is initialized during driver's probe,
otherwise probe fails and xstats_get_by_id is not called.
Coverity issue: 448945
Fixes: cf6007eac498 ("net/ntnic: add xstats")
Signed-off-by: Oleksandr Kolomeiets
---
drivers/net/n
1 - 100 of 973 matches
Mail list logo
