[dpdk-dev] [PATCH] maintainers: resign from maintenance

2017-12-18 Thread Sergio Gonzalez Monroy
I will not be directly working on the DPDK project anymore. Signed-off-by: Sergio Gonzalez Monroy --- MAINTAINERS | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f0baeb4..64f154a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -113,7

Re: [dpdk-dev] [PATCH 01/11] examples/ipsec-secgw: updated MAINTAINERS file

2017-10-23 Thread Sergio Gonzalez Monroy
; Nicolau, Radu ; Doherty, Declan ; lir...@mellanox.com; nelio.laranje...@6wind.com; tho...@monjalon.net Subject: Re: [dpdk-dev][PATCH 01/11] examples/ipsec-secgw: updated MAINTAINERS file On 10/16/2017 12:27 PM, Sergio Gonzalez Monroy wrote: Hi Aviad, On 14/10/2017 14:27, avia

Re: [dpdk-dev] [PATCH v2 4/6] examples/ipsec-secgw: add correct padding to tunnel mode

2017-10-19 Thread Sergio Gonzalez Monroy
Hi Aviad, I think you missed my question on v1 for this patch. Could you provide an example where the pad calculation with the current code is wrong? Thanks, Sergio On 19/10/2017 19:53, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel Issue: None Signed-off-by: Aviad Yehezkel -- v2

Re: [dpdk-dev] [PATCH] maintainers: updated ipsec_secgw

2017-10-18 Thread Sergio Gonzalez Monroy
/sample_app_ug/hello_world.rst M: Sergio Gonzalez Monroy +M: Radu Nicolau F: examples/ipsec-secgw/ F: doc/guides/sample_app_ug/ipsec_secgw.rst Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: set ip6_plen to the proper value

2017-10-18 Thread Sergio Gonzalez Monroy
les/ipsec-secgw: support IPv6") Signed-off-by: Tomasz Duszynski --- examples/ipsec-secgw/esp.c | 6 -- examples/ipsec-secgw/ipip.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH 09/11] examples/ipsec-secgw: Fixed ip length in case of transport

2017-10-16 Thread Sergio Gonzalez Monroy
On 16/10/2017 12:44, Aviad Yehezkel wrote: On 10/16/2017 12:43 PM, Sergio Gonzalez Monroy wrote: On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel IP length was incorrect causing corrupted ICMP packets for example Signed-off-by: Aviad Yehezkel --- examples/ipsec

Re: [dpdk-dev] [PATCH 08/11] examples/ipsec-secgw: iv should be be64

2017-10-16 Thread Sergio Gonzalez Monroy
On 16/10/2017 11:35, Aviad Yehezkel wrote: On 10/16/2017 12:42 PM, Sergio Gonzalez Monroy wrote: On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel To be compatibile with Linux kernel I am not sure what you are trying to achieve with this change. The requirement

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix ip version check

2017-10-16 Thread Sergio Gonzalez Monroy
p4->ip_p = IPPROTO_ESP; ip4->ip_len = htons(rte_pktmbuf_data_len(m)); } else { Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH 10/11] app/testpmd: compile even if ixgbe anf bnxt pmds are not compiling

2017-10-16 Thread Sergio Gonzalez Monroy
On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel Signed-off-by: Aviad Yehezkel Signed-off-by: Nicolai Radu --- app/test-pmd/cmdline.c | 13 ++--- app/test-pmd/config.c | 12 +++- 2 files changed, 21 insertions(+), 4 deletions(-) This patch is

Re: [dpdk-dev] [PATCH 09/11] examples/ipsec-secgw: Fixed ip length in case of transport

2017-10-16 Thread Sergio Gonzalez Monroy
On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel IP length was incorrect causing corrupted ICMP packets for example Signed-off-by: Aviad Yehezkel --- examples/ipsec-secgw/esp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ipsec

Re: [dpdk-dev] [PATCH 08/11] examples/ipsec-secgw: iv should be be64

2017-10-16 Thread Sergio Gonzalez Monroy
On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel To be compatibile with Linux kernel I am not sure what you are trying to achieve with this change. The requirement is that the IV is unique, IMO changing the endianess is irrelevant here. Can you provide case/exampl

Re: [dpdk-dev] [PATCH 07/11] examples/ipsec-secgw: Fixed phyiscal address of aad

2017-10-16 Thread Sergio Gonzalez Monroy
On 14/10/2017 14:27, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel Signed-off-by: Aviad Yehezkel --- examples/ipsec-secgw/esp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c index 689e917..aa2233d 10064

Re: [dpdk-dev] [PATCH 06/11] examples/ipsec-secgw: Added correct padding to tunnel mode

2017-10-16 Thread Sergio Gonzalez Monroy
Could you provide the cases where the padding is wrong in tunnel mode? Thanks, Sergio On 14/10/2017 14:27, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel Signed-off-by: Aviad Yehezkel --- examples/ipsec-secgw/esp.c | 51 ++ 1 file change

Re: [dpdk-dev] [PATCH 05/11] examples/ipsec-secgw: Fixed transport

2017-10-16 Thread Sergio Gonzalez Monroy
On 14/10/2017 14:27, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel Seems like transport was broken for a long time Commit message needs to be improved. Just mentioned what is wrong or how do you fix it. Given that it is a fix, you should start the commit title with "fix ..." then a

Re: [dpdk-dev] [PATCH 01/11] examples/ipsec-secgw: updated MAINTAINERS file

2017-10-16 Thread Sergio Gonzalez Monroy
ezkel --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c00d6d8..d814ac1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -919,6 +919,7 @@ F: examples/helloworld/ F: doc/guides/sample_app_ug/hello_world.rst M: Sergio Gonzalez Monroy +M: Aviad Shaul Yeh

Re: [dpdk-dev] [PATCH] cryptodev: add function to retrieve device name

2017-10-06 Thread Sergio Gonzalez Monroy
: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH v3] eal/x86: implement x86 specific tsc hz

2017-10-02 Thread Sergio Gonzalez Monroy
On 02/10/2017 12:24, Jerin Jacob wrote: -Original Message- Date: Mon, 2 Oct 2017 12:17:38 +0100 From: Sergio Gonzalez Monroy To: dev@dpdk.org CC: harry.van.haa...@intel.com, bruce.richard...@intel.com Subject: [dpdk-dev] [PATCH v3] eal/x86: implement x86 specific tsc hz X-Mailer: git

[dpdk-dev] [PATCH v3] eal/x86: implement x86 specific tsc hz

2017-10-02 Thread Sergio Gonzalez Monroy
user). Default to the tsc hz estimation if both methods fail. Signed-off-by: Sergio Gonzalez Monroy Acked-by: Harry van Haaren Tested-by: Bruce Richardson --- DEPENDS on: http://dpdk.org/dev/patchwork/patch/29086/ v3: - acked-by and tested-by tags v2: - fix misspelled word in commit message

[dpdk-dev] [PATCH v2] eal/x86: implement x86 specific tsc hz

2017-10-02 Thread Sergio Gonzalez Monroy
user). Default to the tsc hz estimation if both methods fail. Signed-off-by: Sergio Gonzalez Monroy --- DEPENDS on: http://dpdk.org/dev/patchwork/patch/29086/ v2: - fix misspelled word in commit message - address comment for more clear code lib/librte_eal/common/arch/x86/rte_cycles.c

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-29 Thread Sergio Gonzalez Monroy
On 29/09/2017 09:15, Eelco Chaudron wrote: On 29/09/17 10:07, Sergio Gonzalez Monroy wrote: On 12/09/2017 14:08, Eelco Chaudron wrote: Call the mlockall() function, to attempt to lock all of its process memory into physical RAM, and preventing the kernel from paging any of its memory to disk

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-29 Thread Sergio Gonzalez Monroy
On 12/09/2017 14:08, Eelco Chaudron wrote: Call the mlockall() function, to attempt to lock all of its process memory into physical RAM, and preventing the kernel from paging any of its memory to disk. When using testpmd for performance testing, depending on the code path taken, we see a couple

Re: [dpdk-dev] [PATCH v3 1/2] eal/malloc: fix RTE malloc debug macro

2017-09-13 Thread Sergio Gonzalez Monroy
On 09/09/2017 08:33, Xueming Li wrote: This patch replaces broken macro RTE_LIBRTE_MALLOC_DEBUG with RTE_MALLOC_DEBUG. Fixes: af75078fece3 ("first public release") Cc: Sergio Gonzalez Monroy Signed-off-by: Xueming Li --- Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH v3 2/2] eal/malloc: fix RTE malloc element free

2017-09-13 Thread Sergio Gonzalez Monroy
fixes calculation of free memory length to be cleared in malloc_elem_free() by including trailer cookie. Fixes: af75078fece3 ("first public release") Cc: Sergio Gonzalez Monroy Signed-off-by: Xueming Li --- Acked-by: Sergio Gonzalez Monroy

[dpdk-dev] [PATCH] crypto/aesni_mb: fix invalid session error

2017-09-07 Thread Sergio Gonzalez Monroy
Setting an invalid session in the crypto op results in SEGFAULT because the JOB user_data was never set to the crypto op. Fixes: 0f548b50a160 ("crypto/aesni_mb: process crypto op on dequeue") Signed-off-by: Sergio Gonzalez Monroy --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 7

Re: [dpdk-dev] long initialization of rte_eal_hugepage_init

2017-09-06 Thread Sergio Gonzalez Monroy
On 06/09/2017 05:35, Pavan Nikhilesh Bhagavatula wrote: On Wed, Sep 06, 2017 at 03:24:52AM +, 王志克 wrote: Hi All, I observed that rte_eal_hugepage_init() will take quite long time if there are lots of huge pages. Example I have 500 1G huge pages, and it takes about 2 minutes. That is too l

Re: [dpdk-dev] [PATCH] ethdev: ensure consistent port id assignment

2017-09-04 Thread Sergio Gonzalez Monroy
Hi, On 24/08/2016 23:17, amin.tootoonchian at intel.com (Tootoonchian, Amin) wrote: Sergio, could you please review this patch? Thanks, Amin The patch status should be updated to 'Not Applicable' since similar functionality has been implemented (commit d948f596). Only Primary processes are

Re: [dpdk-dev] [PATCH v3 0/2] Dynamically configure mempool handle

2017-09-04 Thread Sergio Gonzalez Monroy
Hi Olivier, On 04/09/2017 14:34, Olivier MATZ wrote: Hi Sergio, On Mon, Sep 04, 2017 at 10:41:56AM +0100, Sergio Gonzalez Monroy wrote: On 15/08/2017 09:07, Santosh Shukla wrote: v3: - Rebased on top of v17.11-rc0 - Updated version.map entry to v17.11. v2: DPDK has support for hw and

Re: [dpdk-dev] [PATCH] eal: Copy raw strings taken from command line

2017-09-04 Thread Sergio Gonzalez Monroy
al_config.hugefile_prefix = strdup(optarg); break; case OPT_SOCKET_MEM_NUM: Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH v3 0/2] Dynamically configure mempool handle

2017-09-04 Thread Sergio Gonzalez Monroy
On 15/08/2017 09:07, Santosh Shukla wrote: v3: - Rebased on top of v17.11-rc0 - Updated version.map entry to v17.11. v2: DPDK has support for hw and sw mempool. Those mempool can work optimal for specific PMD's. Example: sw ring based PMD for Intel NICs. HW mempool manager dpaa2 for dpaa2 P

Re: [dpdk-dev] [PATCH v3] eal/linuxapp: check mmap return value MAP_FAILED

2017-08-29 Thread Sergio Gonzalez Monroy
(const char *filename, const size_t mem_size) } retval = mmap(NULL, mem_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); close(fd); + if (retval == MAP_FAILED) + return NULL; return retval; } Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH 1/2] eal/x86: use cpuid builtin

2017-08-24 Thread Sergio Gonzalez Monroy
On 23/08/2017 21:49, Thomas Monjalon wrote: Please could you explain why the asm code was used? I guess we were not aware that there was a builtin for it. Are you sure this builtin is implemented everywhere? Actually the builtin used in this patch is not supported in most CLANG version (j

[dpdk-dev] [PATCH] eal/x86: use cpuid builtin

2017-08-23 Thread Sergio Gonzalez Monroy
GCC does have the __get_cpuid_count builtin which checks for maximum supported leaf, but implementations differ between CLANG and GCC. This change provides an implementation compatible with both GCC and CLANG 3.4+. Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_eal/common/arch/x86

[dpdk-dev] [PATCH] eal/x86: implement x86 specific tsc hz

2017-08-23 Thread Sergio Gonzalez Monroy
user). Default to the tsc hz estimation if both methods fail. Signed-off-by: Sergio Gonzalez Monroy --- DEPENDS on Jerin's patch: http://dpdk.org/dev/patchwork/patch/27526/ lib/librte_eal/common/arch/x86/rte_cycles.c| 142 + .../common/include/arch/x86/rte_cyc

Re: [dpdk-dev] [PATCH 2/2] eal/x86: implement x86 specific tsc hz

2017-08-23 Thread Sergio Gonzalez Monroy
On 23/08/2017 14:17, Bruce Richardson wrote: On Wed, Aug 23, 2017 at 01:42:41PM +0100, Sergio Gonzalez Monroy wrote: First, try to use CPUID Time Stamp Counter and Nominal Core Crystal Clock Information Leaf to determine the tsc hz on platforms that supports it (does not require priviledge user

Re: [dpdk-dev] [PATCH] eal/malloc: fix malloc cookie check

2017-08-23 Thread Sergio Gonzalez Monroy
ould be checked against cookie. Fixes: af75078 ("first public release") Cc: Sergio Gonzalez Monroy Signed-off-by: Xueming Li --- lib/librte_eal/common/malloc_elem.c | 8 lib/librte_eal/common/malloc_elem.h | 4 ++-- test/test/test_malloc.c | 10 +- 3 fil

[dpdk-dev] [PATCH 2/2] eal/x86: implement x86 specific tsc hz

2017-08-23 Thread Sergio Gonzalez Monroy
user). Default to the DPDK tsc hz estimation if both methods fail. Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_eal/common/arch/x86/rte_cycles.c| 138 + .../common/include/arch/x86/rte_cycles.h | 7 +- lib/librte_eal/linuxapp/eal/Makefile

[dpdk-dev] [PATCH 1/2] eal/x86: use cpuid builtin

2017-08-23 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_eal/common/arch/x86/rte_cpuflags.c | 41 +-- 1 file changed, 7 insertions(+), 34 deletions(-) diff --git a/lib/librte_eal/common/arch/x86/rte_cpuflags.c b/lib/librte_eal/common/arch/x86/rte_cpuflags.c index 0138257

Re: [dpdk-dev] Use rte_malloc in application

2017-08-03 Thread Sergio Gonzalez Monroy
On 03/08/2017 07:12, Rohit Saini (Stellus) wrote: With below code, I am getting this warning. warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] my_node_t *data_ptr = (my_node_t *) rte_malloc(NULL, sizeof(my_node_t), 0); As far as I can see, the syntax looks corre

Re: [dpdk-dev] [PATCH v2] cryptodev: fix NULL pointer dereference

2017-08-01 Thread Sergio Gonzalez Monroy
On 01/08/2017 10:35, Thomas Monjalon wrote: 01/08/2017 10:13, Sergio Gonzalez Monroy: On 31/07/2017 20:33, Thomas Monjalon wrote: 31/07/2017 11:18, Pablo de Lara: When register a crypto driver, a cryptodev driver structure was being allocated, using malloc. Since this call may fail, it is

Re: [dpdk-dev] [PATCH v2] cryptodev: fix NULL pointer dereference

2017-08-01 Thread Sergio Gonzalez Monroy
On 31/07/2017 20:33, Thomas Monjalon wrote: 31/07/2017 11:18, Pablo de Lara: When register a crypto driver, a cryptodev driver structure was being allocated, using malloc. Since this call may fail, it is safer to allocate this memory statically in each PMD, so driver registration will never fail

Re: [dpdk-dev] [PATCH] cryptodev: fix NULL pointer dereference

2017-07-31 Thread Sergio Gonzalez Monroy
mory for crypto driver %u\n", + nb_drivers); + driver->driver = drv; driver->id = nb_drivers; Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

2017-07-28 Thread Sergio Gonzalez Monroy
On 12/07/2017 21:15, Jan Blunck wrote: This function is an alias for rte_vdev_init() which is scheduled to move out of the rte_eal library. Lets deprecate this function to be able to remove it from the cryptodev library in 17.11. Signed-off-by: Jan Blunck --- Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH] pci: limit default numa node to used devices

2017-07-21 Thread Sergio Gonzalez Monroy
On 21/07/2017 16:37, Thomas Monjalon wrote: 21/07/2017 18:03, Sergio Gonzalez Monroy: On 21/07/2017 15:53, Thomas Monjalon wrote: The title and the text below should explain that you move the warning log from scan to probe, thanks to a temporary negative value. I thought that saying that I

Re: [dpdk-dev] [PATCH] pci: limit default numa node to used devices

2017-07-21 Thread Sergio Gonzalez Monroy
the change from one file to another. 21/07/2017 12:11, Sergio Gonzalez Monroy: Commit 8a04cb612589 ("pci: set default numa node for broken systems") added logic to default to NUMA node 0 when sysfs numa_node information was wrong or not available. Unfortunately there are many devices

[dpdk-dev] [PATCH] pci: limit default numa node to used devices

2017-07-21 Thread Sergio Gonzalez Monroy
rnings for them. Instead, only check for invalid NUMA node information for devices managed by the DPDK. Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_eal/common/eal_common_pci.c | 5 + lib/librte_eal/linuxapp/eal/eal_pci.c | 11 +++ 2 files changed, 8 insertions(+), 8

Re: [dpdk-dev] [ovs-dev] [PATCH v2 0/4] rhel/fedora: non-root OvS out of the box

2017-07-14 Thread Sergio Gonzalez Monroy
On 11/07/2017 20:21, Aaron Conole wrote: Aaron Conole writes: Aaron Conole writes: This series attempts to introduce the ability to start and use Open vSwitch 'out of the box' as a non-root user. It does this by modifying the service files to pass the recently introduced --ovs-user argumen

Re: [dpdk-dev] [PATCH v3 04/11] linuxapp/eal_pci: get iommu class

2017-07-14 Thread Sergio Gonzalez Monroy
On 13/07/2017 09:23, santosh wrote: Hi Sergio, On Wednesday 12 July 2017 01:50 PM, Sergio Gonzalez Monroy wrote: On 11/07/2017 07:16, Santosh Shukla wrote: Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Algorithm for iova scheme selection for

Re: [dpdk-dev] [PATCH v3 04/11] linuxapp/eal_pci: get iommu class

2017-07-12 Thread Sergio Gonzalez Monroy
On 11/07/2017 07:16, Santosh Shukla wrote: Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Algorithm for iova scheme selection for PCI bus: 0. Look for device attached to vfio kdrv and has .drv_flag set to RTE_PCI_DRV_NEED_IOVA_VA. 1. Look for any d

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-12 Thread Sergio Gonzalez Monroy
On 12/07/2017 03:45, Tan, Jianfeng wrote: -Original Message- From: Gonzalez Monroy, Sergio Sent: Tuesday, July 11, 2017 7:36 PM To: Tan, Jianfeng; Stephen Hemminger; dev@dpdk.org Subject: Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process On 11/07/2017 02:56, Tan,

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-12 Thread Sergio Gonzalez Monroy
On 11/07/2017 21:00, Stephen Hemminger wrote: On Tue, 11 Jul 2017 12:35:39 +0100 Sergio Gonzalez Monroy wrote: On 11/07/2017 02:56, Tan, Jianfeng wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Tuesday, July 11, 2017 9:13 AM To

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2017-07-11 Thread Sergio Gonzalez Monroy
On 11/07/2017 02:56, Tan, Jianfeng wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Tuesday, July 11, 2017 9:13 AM To: dev@dpdk.org Cc: Stephen Hemminger Subject: [dpdk-dev] [RFC] pci: force address of mappings in secondary process Th

Re: [dpdk-dev] [PATCH] eal: use get_mempolicy(2) to find numa socket on Linux

2017-07-03 Thread Sergio Gonzalez Monroy
On 01/07/2017 15:18, Thomas Monjalon wrote: 21/06/2017 17:49, Sergio Gonzalez Monroy: I think following the discussion of libnuma dependency in another thread [1], you would need to implement a similar approach and keep the old method while providing this alternative if libnuma is present

Re: [dpdk-dev] [PATCH v2 0/4] AESNI GCM PMD: Migration from ISA-L to Multi-buffer library

2017-06-30 Thread Sergio Gonzalez Monroy
+-- test/test/test_cryptodev_gcm_test_vectors.h | 357 12 files changed, 922 insertions(+), 223 deletions(-) Series Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support IPSec Multi-buffer lib v0.46

2017-06-30 Thread Sergio Gonzalez Monroy
On 28/06/2017 12:48, Pablo de Lara wrote: IPSec Multi-buffer library v0.46 has been released, which includes, among othe features, support for 12-byte IV, for AES-CTR, keeping also the previous 16-byte IV, for backward compatibility reasons. Signed-off-by: Pablo de Lara --- doc/guides/cryptod

[dpdk-dev] [PATCH] app/crypto-perf: use rte_mempool_put_bulk

2017-06-30 Thread Sergio Gonzalez Monroy
Use rte_mempool_put_bulk for both latency and throughput tests instead of rte_crypto_op_free to improve application performance. Signed-off-by: Sergio Gonzalez Monroy --- app/test-crypto-perf/cperf_test_latency.c| 14 -- app/test-crypto-perf/cperf_test_throughput.c | 8

[dpdk-dev] [PATCH] app/crypto-perf: set crypto op pool cache

2017-06-30 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- app/test-crypto-perf/cperf_test_latency.c| 2 +- app/test-crypto-perf/cperf_test_throughput.c | 2 +- app/test-crypto-perf/cperf_test_verify.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-crypto-perf

[dpdk-dev] [PATCH] app/crypto-perf: fix digest data for chained mbufs

2017-06-30 Thread Sergio Gonzalez Monroy
Use corect mbuf segment for chained mbufs. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") CC: sta...@dpdk.org Signed-off-by: Sergio Gonzalez Monroy --- app/test-crypto-perf/cperf_ops.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletion

Re: [dpdk-dev] [PATCH v9 1/2] mem: balanced allocation of hugepages

2017-06-28 Thread Sergio Gonzalez Monroy
the patch if you are happy with it? Thanks. Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH] lib/lib_eal:fix the pointer 'elem' may be NULL bug

2017-06-28 Thread Sergio Gonzalez Monroy
On 28/06/2017 09:12, RongQiang Xie wrote: Signed-off-by: RongQiang Xie --- lib/librte_eal/common/eal_common_memzone.c | 6 ++ 1 file changed, 6 insertions(+) mode change 100644 => 100755 lib/librte_eal/common/eal_common_memzone.c diff --git a/lib/librte_eal/common/eal_common_memzone.c

Re: [dpdk-dev] [PATCH v7 0/2] Balanced allocation of hugepages

2017-06-26 Thread Sergio Gonzalez Monroy
On 26/06/2017 11:44, Ilya Maximets wrote: So, what do you think about this version? Is it ready for merge or some additional changes needed? I was just having another look at it and was wondering if we should re-set the old policy instead of DEFAULT? Also noticed that we probably should incr

Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it.

2017-06-26 Thread Sergio Gonzalez Monroy
On 26/06/2017 10:39, Thomas Monjalon wrote: 26/06/2017 11:14, Sergio Gonzalez Monroy: On 23/06/2017 14:02, Thomas Monjalon wrote: 22/06/2017 17:15, Sergio Gonzalez Monroy: Just fyi, the summary line should be lowercase apart from acronyms (DPDK guidelines). On 11/05/2017 02:56, Tonghao Zhang

Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it.

2017-06-26 Thread Sergio Gonzalez Monroy
On 23/06/2017 14:02, Thomas Monjalon wrote: 22/06/2017 17:15, Sergio Gonzalez Monroy: Just fyi, the summary line should be lowercase apart from acronyms (DPDK guidelines). On 11/05/2017 02:56, Tonghao Zhang wrote: The NUMA node information for PCI devices provided through sysfs is invalid for

Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it.

2017-06-22 Thread Sergio Gonzalez Monroy
resent. " + "Set it 0 as default\n"); + dev->device.numa_node = 0; } rte_pci_device_name(addr, dev->name, sizeof(dev->name)); The code changes look fine, so I leave it to Thomas regarding the commit message :) Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH] eal: use get_mempolicy(2) to find numa socket on Linux

2017-06-21 Thread Sergio Gonzalez Monroy
On 18/06/2017 16:52, Gregory Etelson wrote: Use get_mempolicy(2) to find numa socket on Linux instead of parsing /proc/self/numa_maps. When process maps around 1K hugepages numa_maps file can miss huge records in older Linux kernels. get_mempolicy() proved more reliable Requires numactl dev pack

Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages

2017-06-21 Thread Sergio Gonzalez Monroy
On 21/06/2017 09:14, Hemant Agrawal wrote: On 6/20/2017 9:11 PM, Jerin Jacob wrote: -Original Message- Date: Tue, 20 Jun 2017 15:58:50 +0100 From: Sergio Gonzalez Monroy To: Thomas Monjalon , Ilya Maximets CC: dev@dpdk.org, Hemant Agrawal , Bruce Richardson , David Marchand

Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages

2017-06-20 Thread Sergio Gonzalez Monroy
On 20/06/2017 16:41, Jerin Jacob wrote: -Original Message- Date: Tue, 20 Jun 2017 15:58:50 +0100 From: Sergio Gonzalez Monroy To: Thomas Monjalon , Ilya Maximets CC: dev@dpdk.org, Hemant Agrawal , Bruce Richardson , David Marchand , Heetae Ahn , Yuanhan Liu , Jianfeng Tan

Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages

2017-06-20 Thread Sergio Gonzalez Monroy
On 20/06/2017 15:35, Thomas Monjalon wrote: 20/06/2017 15:58, Ilya Maximets: On 20.06.2017 16:07, Thomas Monjalon wrote: 19/06/2017 13:10, Hemant Agrawal: On Thu, Jun 08, 2017 at 02:21:58PM +0300, Ilya Maximets wrote: So, there are 2 option: 1. Return back config option RTE_LIBRTE_EAL_N

Re: [dpdk-dev] [PATCH v3] mem: fix malloc_elem resize with padding

2017-06-20 Thread Sergio Gonzalez Monroy
by including the size of the padding when computing where to split the malloc_elem. Fixes: af75078fece3 ("first public release") Signed-off-by: Jamie Lavigne --- Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH v5 0/2] Balanced allocation of hugepages

2017-06-08 Thread Sergio Gonzalez Monroy
On 08/06/2017 13:14, Bruce Richardson wrote: On Thu, Jun 08, 2017 at 02:21:58PM +0300, Ilya Maximets wrote: Hi everyone, I just want to clarify current status of these patches. As I understand, moving to the new build system (for example, meson+ninja as proposed[1] by Bruce) is a very long proc

Re: [dpdk-dev] [PATCH v2] Correctly handle malloc_elem resize with padding

2017-06-06 Thread Sergio Gonzalez Monroy
Hi Jamie, On 31/05/2017 01:16, Jamie Lavigne wrote: Currently when a malloc_elem is split after resizing, any padding present in the elem is ignored. This causes the resized elem to be too small when padding is present, and user data can overwrite the beginning of the following malloc_elem. So

Re: [dpdk-dev] cryptodev - thread, cryptodev, session, queue-pair mapping .

2017-05-24 Thread Sergio Gonzalez Monroy
Hi, There are different ways you can do this. You have an approach in examples/ipsec-secgw where each thread/lcore uses a hash table for the device/queue mapping for the crypto algorithms combinations (key). The session is 1:1 to SA, so it just keeps a pointer in the SA struct. This holds tru

Re: [dpdk-dev] [PATCH v2 3/3] net/sfc: support multi-process

2017-05-22 Thread Sergio Gonzalez Monroy
On 22/05/2017 13:36, Ferruh Yigit wrote: On 5/22/2017 1:07 PM, Andrew Rybchenko wrote: On 05/22/2017 02:29 PM, Ferruh Yigit wrote: On 5/18/2017 3:00 PM, Andrew Rybchenko wrote: Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton <...> Linux VFIO = Y diff --git a/drivers/

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: crypto operation restructuring

2017-05-04 Thread Sergio Gonzalez Monroy
On 04/05/2017 08:38, Akhil Goyal wrote: On 5/4/2017 1:01 PM, Sergio Gonzalez Monroy wrote: On 04/05/2017 07:09, Akhil Goyal wrote: Hi Sergio, On 5/3/2017 7:48 PM, Sergio Gonzalez Monroy wrote: On 03/05/2017 12:01, Akhil Goyal wrote: Hi Pablo, On 4/28/2017 11:33 PM, Pablo de Lara wrote

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: crypto operation restructuring

2017-05-04 Thread Sergio Gonzalez Monroy
On 04/05/2017 07:09, Akhil Goyal wrote: Hi Sergio, On 5/3/2017 7:48 PM, Sergio Gonzalez Monroy wrote: On 03/05/2017 12:01, Akhil Goyal wrote: Hi Pablo, On 4/28/2017 11:33 PM, Pablo de Lara wrote: This is a proposal to correct and improve the current crypto operation (rte_crypto_op) and

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: crypto operation restructuring

2017-05-03 Thread Sergio Gonzalez Monroy
On 03/05/2017 12:01, Akhil Goyal wrote: Hi Pablo, On 4/28/2017 11:33 PM, Pablo de Lara wrote: This is a proposal to correct and improve the current crypto operation (rte_crypto_op) and symmetric crypto operation (rte_crypto_sym_op) structures, shrinking their sizes to fit both structures into

Re: [dpdk-dev] [PATCH 1/2] eal/ppc: fix mmap for memory initialization

2017-04-13 Thread Sergio Gonzalez Monroy
if (base_addr == MAP_FAILED || base_addr != mcfg->memseg[s].addr) { max_seg = s; Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-04-10 Thread Sergio Gonzalez Monroy
a Maximets wrote: On 27.03.2017 16:01, Sergio Gonzalez Monroy wrote: On 09/03/2017 12:57, Ilya Maximets wrote: On 08.03.2017 16:46, Sergio Gonzalez Monroy wrote: Hi Ilya, I have done similar tests and as you already pointed out, 'numactl --interleave' does not seem to work as e

Re: [dpdk-dev] [PATCH 1/2] eal/ppc: fix mmap for memory initialization

2017-04-06 Thread Sergio Gonzalez Monroy
Hi Chao, You mentioned that 'mmap will not respect the requested address hint', how does the proposed change solves that? Is it that hugepages map to a specific VA region, and without MAP_HUGETLB you may get address from wrong region? If mmap were to respect the hinted address, we could do

Re: [dpdk-dev] [PATCH 0/2] ppc:Fix the memory initialization for IBM POWER

2017-04-06 Thread Sergio Gonzalez Monroy
I cannot manage to find the patch set in patchwork or the mailing list. Could you provide patchwork links for those patches? Regards, Sergio On 06/04/2017 06:47, gowrishankar muthukrishnan wrote: Could this patch be reviewed and added ? This is required in ppc64le for multiprocess support. R

Re: [dpdk-dev] [PATCH] vfio: do not use memcmp() to compare PCI address

2017-03-31 Thread Sergio Gonzalez Monroy
On 31/03/2017 17:18, Andrew Rybchenko wrote: On 03/31/2017 07:09 PM, Sergio Gonzalez Monroy wrote: On 31/03/2017 16:56, Andrew Rybchenko wrote: PCI address structure has padding which may have garbage. Fixes: 2f4adfad0a69 ("vfio: add multiprocess support") Cc: sta...@dpdk.org Sig

Re: [dpdk-dev] [PATCH] vfio: do not use memcmp() to compare PCI address

2017-03-31 Thread Sergio Gonzalez Monroy
On 31/03/2017 16:56, Andrew Rybchenko wrote: PCI address structure has padding which may have garbage. Fixes: 2f4adfad0a69 ("vfio: add multiprocess support") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- It is a real bug which I've hit during multi-process debugging. lib/librte_ea

Re: [dpdk-dev] [PATCH] crypto/scheduler: add get attached slaves API

2017-03-29 Thread Sergio Gonzalez Monroy
On 21/02/2017 15:14, Fan Zhang wrote: This patch adds an API to get the run-time slaves number and list of a cryptodev scheduler PMD. Signed-off-by: Fan Zhang --- drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 31 ++ drivers/crypto/scheduler/rte_cryptodev_scheduler.

Re: [dpdk-dev] [PATCH v2 0/9] Crypto performance app improvements

2017-03-29 Thread Sergio Gonzalez Monroy
/crypto-perf: display results in test runner app/crypto-perf: add range/list of sizes app/crypto-perf: add extra option checks app/crypto-perf: reorg options structure Sergio Gonzalez Monroy (1): app/crypto-perf: move verify as single test type app/test-crypto-perf/Makefile

Re: [dpdk-dev] [PATCH] eal/linux: fix multi-process cannot work

2017-03-29 Thread Sergio Gonzalez Monroy
ist, next) { - if (memcmp(&vfio_res->pci_addr, &dev->addr, sizeof(dev->addr))) + if (rte_eal_compare_pci_addr(&vfio_res->pci_addr, +&dev->addr)) continue; break; } Acked-by: Sergio Gonzalez Monroy

[dpdk-dev] [PATCH] crypto/aesni_gcm: do crypto op in dequeue function

2017-03-29 Thread Sergio Gonzalez Monroy
doing enqueue/dequeue. This patch moves the crypto operation to the dequeue function which fixes the above issue without having to check for the number of free entries in the ring. Fixes: eec136f3c54f ("aesni_gcm: add driver for AES-GCM crypto operations") Signed-off-by: Sergio Gonza

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-03-27 Thread Sergio Gonzalez Monroy
On 09/03/2017 12:57, Ilya Maximets wrote: On 08.03.2017 16:46, Sergio Gonzalez Monroy wrote: Hi Ilya, I have done similar tests and as you already pointed out, 'numactl --interleave' does not seem to work as expected. I have also checked that the issue can be reproduced with quot

Re: [dpdk-dev] Is contiguous hugepages memory still required in latest DPDKs?

2017-03-23 Thread Sergio Gonzalez Monroy
On 23/03/2017 16:24, Ruslan Bilovol wrote: On 03/22/2017 02:08 PM, Ruslan Bilovol wrote: On 03/21/2017 04:41 PM, Sergio Gonzalez Monroy wrote: The DPDK will still try to allocate contiguous hugepages. Since DPDK v16.07 the mempool library is able to create a mempool with multiple chunks of

Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: attach session-qp

2017-03-23 Thread Sergio Gonzalez Monroy
On 23/03/2017 10:38, Akhil Goyal wrote: On 3/23/2017 4:00 PM, Sergio Gonzalez Monroy wrote: That was simpler than I thought. For some reason I understood that the device will support thousands of queues and single session per queue which would have needed more app changes. On 23/03/2017 08:06

Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: attach session-qp

2017-03-23 Thread Sergio Gonzalez Monroy
->tbl[cdev_id_qp].qp); Guideline is to keep error strings in single line to facilitate grep. Other than that: Acked-by: Sergio Gonzalez Monroy + return -1; + } + } sa->cdev_id_qp = cdev_id_qp; return 0;

Re: [dpdk-dev] Is contiguous hugepages memory still required in latest DPDKs?

2017-03-21 Thread Sergio Gonzalez Monroy
The DPDK will still try to allocate contiguous hugepages. Since DPDK v16.07 the mempool library is able to create a mempool with multiple chunks of memory. You would still have the contig memory restriction for any other DPDK library or app. Are you pre-allocating hugepages on boot (kernel cmd

Re: [dpdk-dev] rte_malloc_heap usage scenario

2017-03-14 Thread Sergio Gonzalez Monroy
On 09/03/2017 04:48, Yerden Zhumabekov wrote: Hello, Can anybody explain why rte_malloc_heap.h is advertised as a public interface? It only contains malloc_heap struct which is used internally and violates DPDK naming conventions for public struct. I haven't found any use of it outside of EAL

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-03-08 Thread Sergio Gonzalez Monroy
Hi Ilya, I have done similar tests and as you already pointed out, 'numactl --interleave' does not seem to work as expected. I have also checked that the issue can be reproduced with quota limit on hugetlbfs mount point. I would be inclined towards *adding libnuma as dependency* to DPDK to m

Re: [dpdk-dev] [PATCH v4] eal: Support running as unprivileged user

2017-02-17 Thread Sergio Gonzalez Monroy
--- lib/librte_eal/common/eal_private.h | 12 + lib/librte_eal/linuxapp/eal/eal_memory.c | 75 +++- lib/librte_eal/linuxapp/eal/eal_pci.c| 6 ++- 3 files changed, 71 insertions(+), 22 deletions(-) Acked-by: Sergio Gonzalez Monroy PS: Please keep a summary

Re: [dpdk-dev] cryptodev - Session and queue pair relationship

2017-02-14 Thread Sergio Gonzalez Monroy
Hi Akhil, Thanks for your feedback Declan, The suggestion from Fiona looks good. Should I send the patch for this or is it already in discussion in some different thread? Also, if this new API is added, there would be corresponding change in the ipsec-secgw application as well. I am look

Re: [dpdk-dev] [PATCH v2] eal: Support running as unprivileged user

2017-01-18 Thread Sergio Gonzalez Monroy
On 03/01/2017 22:56, Ben Walker wrote: For Linux kernel 4.0 and newer, the ability to obtain physical page frame numbers for unprivileged users from /proc/self/pagemap was removed. Instead, when an IOMMU is present, simply choose our own DMA addresses instead. Signed-off-by: Ben Walker @@ -255,

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add support for SHA256 HMAC

2017-01-13 Thread Sergio Gonzalez Monroy
: Zbigniew Bodek --- Acked-by: Sergio Gonzalez Monroy

Re: [dpdk-dev] Running DPDK as an unprivileged user

2017-01-05 Thread Sergio Gonzalez Monroy
On 05/01/2017 10:09, Sergio Gonzalez Monroy wrote: On 04/01/2017 21:34, Walker, Benjamin wrote: On Wed, 2017-01-04 at 19:39 +0800, Tan, Jianfeng wrote: Hi Benjamin, On 12/30/2016 4:41 AM, Walker, Benjamin wrote: DPDK today begins by allocating all of the required hugepages, then finds all

Re: [dpdk-dev] Running DPDK as an unprivileged user

2017-01-05 Thread Sergio Gonzalez Monroy
On 04/01/2017 21:34, Walker, Benjamin wrote: On Wed, 2017-01-04 at 19:39 +0800, Tan, Jianfeng wrote: Hi Benjamin, On 12/30/2016 4:41 AM, Walker, Benjamin wrote: DPDK today begins by allocating all of the required hugepages, then finds all of the physical addresses for those hugepages using /p

[dpdk-dev] [dpdk-users] rte_zmalloc() returning non-zeroed memory on FreeBSD

2016-11-04 Thread Sergio Gonzalez Monroy
On 03/11/2016 20:04, Lewis Donzis wrote: > I?m curious about how/whether this got resolved. The 16.07.1 code doesn?t > appear to have this fixed. > > Is it still forthcoming? > > Thanks, > lew It should have been fixed in 16.07.1. http://dpdk.org/browse/dpdk-stable/commit/?id=82f931805506efbb8b5

[dpdk-dev] [PATCH v5 0/2] app/testpmd: improve multiprocess support

2016-10-18 Thread Sergio Gonzalez Monroy
On 30/09/2016 15:00, Marcin Kerlin wrote: > This patch ensure not overwrite device data in the multiprocess application. > > 1)Changes in the library introduces continuity in array rte_eth_dev_data[] > shared between all processes. Secondary process adds new entries in free > space instead of overw

  1   2   3   4   5   6   >