RE: [PATCH v2 02/16] bus/dpaa: verify strdup return value

2023-11-15 Thread Sachin Saxena
Acked-by: Sachin Saxena > -Original Message- > From: Chengwen Feng > Sent: 10 November 2023 03:31 PM > To: tho...@monjalon.net; ferruh.yi...@amd.com; Hemant Agrawal > ; Sachin Saxena ; > Shreyansh Jain > Cc: dev@dpdk.org > Subject: [PATCH v2 02/16] bus/dpaa: ve

RE: [PATCH v2 03/16] bus/fslmc: verify strdup return value

2023-11-15 Thread Sachin Saxena
Acked-by: Sachin Saxena > -Original Message- > From: Chengwen Feng > Sent: 10 November 2023 03:31 PM > To: tho...@monjalon.net; ferruh.yi...@amd.com; Hemant Agrawal > ; Sachin Saxena ; > Shreyansh Jain > Cc: dev@dpdk.org > Subject: [PATCH v2 03/16] bus/fslmc: ve

RE: [PATCH 15/21] bus/fslmc: replace strtok with strtok_r

2023-11-15 Thread Sachin Saxena
Acked-by: Sachin Saxena > -Original Message- > From: Jie Hai > Sent: 13 November 2023 04:16 PM > To: dev@dpdk.org; Hemant Agrawal ; Sachin > Saxena > Cc: haij...@huawei.com; lihuis...@huawei.com; fengcheng...@huawei.com > Subject: [PATCH 15/21] bus/fslmc: replace

Re: [PATCH] net/dpaa2: change threshold value

2023-05-15 Thread Sachin Saxena (OSS)
t;nb_rx_desc" based only. We will further review this suggestion and get back. -- Thanks, Sachin Saxena (NXP)

Re: [PATCH] net/dpaa2: set check sum good flags

2023-05-09 Thread Sachin Saxena (OSS)
ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; + else + mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; if (dpaa2_enable_ts[mbuf->port]) { *dpaa2_timestamp_dynfield(mbuf) = annotation->word2; -- 2.27.0 Acked-by: Sachin Saxena -- Thanks, Sachin Saxena (NXP)

Re: [PATCH] net/dpaa2: set check sum good flags

2023-05-09 Thread Sachin Saxena (OSS)
ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; + else + mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; if (dpaa2_enable_ts[mbuf->port]) { *dpaa2_timestamp_dynfield(mbuf) = annotation->word2; -- 2.27.0 Acked-by: Sachin Saxena -- Thanks, Sachin Saxena (NXP)

[v2] [RFC] dpaa2: replace system("echo ...") with file i/o

2023-05-02 Thread Sachin Saxena (OSS)
and therefore can not test this. Signed-off-by: Stephen Hemminger Reviewed-by: Sachin Saxena --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 45 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc

Re: Dpaa2 driver using system("echo...")

2023-04-28 Thread Sachin Saxena (OSS)
fine. When testing, found issue of memory corruption that I have fixed over your changes. I will send a 'v2' patch in context of your previous patch including this fix for dpaa2 platform. -- Thanks, Sachin Saxena (NXP)

Re: [PATCH v3 16/16] enable lock check

2023-04-10 Thread Sachin Saxena (OSS)
;) endif includes += include_directories('include', 'base/qbman') +annotate_locks = false Acked-by: Sachin Saxena diff --git a/drivers/common/cnxk/meson.build b/drivers/common/cnxk/meson.build index 402c3249cd..b32fae9f5a 100644 --- a/drivers/common/cnxk/meson.b

Re: [PATCH v11 1/5] net/enetfec: introduce NXP ENETFEC driver

2023-03-23 Thread Sachin Saxena (OSS)
On 3/23/2023 4:37 PM, Ferruh Yigit wrote: On 3/23/2023 6:00 AM, Sachin Saxena (OSS) wrote: On 3/21/2023 11:33 PM, Ferruh Yigit wrote: On 11/15/2021 7:19 AM, Apeksha Gupta wrote: +ENETFEC +--- + +This section provides an overview of the NXP ENETFEC and how it is +integrated into the DPDK

Re: [PATCH v11 1/5] net/enetfec: introduce NXP ENETFEC driver

2023-03-22 Thread Sachin Saxena (OSS)
-use of PHY handling in enetfec-uio driver is point of objection. So, we are currently working on changing the design and most probably, we may design new driver w/o UIO support. --- Thanks, Sachin Saxena (NXP)

Re: [PATCH 07/33] doc: update enetfec guide

2023-03-22 Thread Sachin Saxena (OSS)
C Features @@ -91,11 +96,6 @@ ENETFEC Features - Linux - ARMv8 -Supported ENETFEC SoCs --- - -- i.MX 8M Mini - Prerequisites - Acked-by: Sachin Saxena -- Thanks, Sachin Saxena (NXP)

Re: [PATCH 06/33] doc: update enetc guide

2023-03-22 Thread Sachin Saxena (OSS)
-development-tools/layerscape-software-development-kit:LAYERSCAPE-SDK>`_ Driver compilation and testing -~~ +-- Follow instructions available in the document :ref:`compiling and testing a PMD for a NIC ` Acked-by: Sachin Saxena -- Thanks, Sachin Saxena (NXP)

Re: [PATCH 04/33] doc: update dpaa guide

2023-03-22 Thread Sachin Saxena (OSS)
GPLv2), however they are used as BSD in DPDK in userspace. -Pre-Installation Configuration --- - +Configuration +- Environment Variables ~~~~~ Acked-by: Sachin Saxena -- Thanks, Sachin Saxena NXP

Re: [PATCH 05/12] net/enetfec: fix build with GCC 12

2022-06-14 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 6/10/2022 6:38 PM, David Marchand wrote: On Wed, May 18, 2022 at 12:17 PM David Marchand wrote: GCC 12 raises the following warning: ../drivers/net/enetfec/enet_ethdev.c: In function ‘enetfec_rx_queue_setup’: ../drivers/net/enetfec/enet_ethdev.c:473:9

Re: [PATCH 05/12] net/enetfec: fix build with GCC 12

2022-06-12 Thread Sachin Saxena (OSS)
Hello David, I understood and agree with your suggestion. We are using GCC 11.3 where we were not seeing this warning. We will fix this on priority and submit the patch asap. regards, Sachin Saxena On 6/10/2022 6:38 PM, David Marchand wrote: On Wed, May 18, 2022 at 12:17 PM David Marchand

Re: [dpdk-dev] [PATCH 4/4] drivers/net/enetfec: add enqueue and dequeue support

2021-07-05 Thread Sachin Saxena (OSS)
c features added like promiscuous enable, basic stats. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 4 + doc/guides/nics/features/enetfec.ini | 5 + drivers/net/enetfec/enet_ethdev.c| 212 +++- drivers/net/enetfec/e

Re: [dpdk-dev] [PATCH 3/4] drivers/net/enetfec: queue configuration

2021-07-03 Thread Sachin Saxena (OSS)
On 30-Apr-21 10:04 AM, Apeksha Gupta wrote: This patch added RX/TX queue configuration setup operations. added -> adds On packet Rx the respective BD Ring status bit is set which is then Suggestion:  Rx -> reception used for packet processing. Signed-off-by: Sachin Saxena Signed-

Re: [dpdk-dev] [PATCH 2/4] drivers/net/enetfec: UIO support added

2021-07-03 Thread Sachin Saxena (OSS)
and for mapping the allocated memory of register & BD from kernel to DPDK which gives access to non-cacheble memory for BD. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/net/enetfec/enet_ethdev.c | 204 ++ drivers/net/enetfec/enet_

Re: [dpdk-dev] [PATCH 1/4] drivers/net/enetfec: Introduce NXP ENETFEC driver

2021-07-03 Thread Sachin Saxena (OSS)
c driver with probe and patch add -> patch adds uintialisation functions uintialisation-> remove functionality Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 121 doc/guides/nics/features/enetfec.ini | 8 +

Re: [dpdk-dev] [PATCH 0/4] drivers/net: add NXP ENETFEC driver

2021-07-03 Thread Sachin Saxena (OSS)
On 30-Apr-21 10:04 AM, Apeksha Gupta wrote: This patch series introduce the enetfec ethernet driver, enetfec ethernet driver -> enetfec driver ENET fec (Fast Ethernet Controller) is a network poll mode driver for ENET fec ->enetfec Also, please use "enetfec" consistently at all places. the

Re: [dpdk-dev] [PATCH v3] net/dpaa2: fix build error about timesync functions

2020-10-09 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 08-Oct-20 6:42 PM, Ferruh Yigit wrote: On 10/8/2020 3:24 AM, Sachin Saxena (OSS) wrote: [please don't top post, I moved reply to down] On 06-Oct-20 10:46 PM, Ferruh Yigit wrote: From: Chenxu Di Some timesync related source files are built only

[dpdk-dev] [PATCH v1] doc: fix dpaa2 guide

2020-10-07 Thread Sachin Saxena (OSS)
From: Sachin Saxena The diagram to show dpaa2 drivers brief was missing in dpaa2.html file. fix a typo in encoding for a literal block to make it visible in generated doc file. Fixes: 846a8305f277 ("add DPAA2 NIC details") Cc: sta...@dpdk.org Signed-off-by: Sachin Saxena --- doc/g

Re: [dpdk-dev] [PATCH v3] net/dpaa2: fix build error about timesync functions

2020-10-07 Thread Sachin Saxena (OSS)
Following change should also be handled as suggested by Ferruh in earlier. diff --git a/drivers/net/dpaa2/dpaa2_ptp.c b/drivers/net/dpaa2/dpaa2_ptp.c index 9f755e84bf..0e44d4c6bf 100644 --- a/drivers/net/dpaa2/dpaa2_ptp.c +++ b/drivers/net/dpaa2/dpaa2_ptp.c @@ -178,4 +178,6 @@ s

Re: [dpdk-dev] [PATCH v3 1/3] eal: add API for bus close

2020-09-28 Thread Sachin Saxena (OSS)
On 26-Aug-20 11:22 AM, rohit@nxp.com wrote: From: Rohit Raj As per the current code we have API for bus probe, but the bus close API is missing. This breaks the multi process scenarios as objects are not cleaned while terminating the secondary processes. This patch adds a new API rte_bu

[dpdk-dev] [PATCH v2] net/dpaa2: release port upon close

2020-09-28 Thread Sachin Saxena (OSS)
From: Sachin Saxena With removal of old close behavior, the private port resources must be released in the .dev_close callback. Freeing of port private resources is moved from the ".remove(device)" to the ".dev_close(port)" operation Signed-off-by: Sachin Saxena --

Re: [dpdk-dev] [PATCH v2 19/25] drivers/net: check process type in close operation

2020-09-28 Thread Sachin Saxena (OSS)
For dpaa, dpaa2, enetc and pfe Reviewed-by: Sachin Saxena On 28-Sep-20 5:12 AM, Thomas Monjalon wrote: The secondary processes are not allowed to release shared resources. Only process-private ressources should be freed in a secondary process. Most of the time, there is no process-private

Re: [dpdk-dev] [PATCH v2 18/25] drivers/net: accept removing device without any port

2020-09-28 Thread Sachin Saxena (OSS)
For "net/pfe" Reviewed-by: Sachin Saxena On 28-Sep-20 5:12 AM, Thomas Monjalon wrote: The ports can be closed (i.e. completely released) before removing the whole device. Such case was wrongly considered an error by some drivers. If the device supports only one port, there is nothi

Re: [dpdk-dev] [PATCH v2 02/25] ethdev: allow drivers to return error on close

2020-09-28 Thread Sachin Saxena (OSS)
For dpaa, dpaa2, enetc and pfe. Reviewed-by: Sachin Saxena On 28-Sep-20 5:12 AM, Thomas Monjalon wrote: The device operation .dev_close was returning void. This driver interface is changed to return an int. Note that the API rte_eth_dev_close() is still returning void, although a deprecation

[dpdk-dev] [PATCH v1 4/4] net/enetc: release port upon close

2020-09-28 Thread Sachin Saxena (OSS)
From: Sachin Saxena With removal of old close behavior, the private port resources must be released in the .dev_close callback. Freeing of port private resources is moved from the ".remove(device)" to the ".dev_close(port)" operation Signed-off-by: Sachin Saxena --

[dpdk-dev] [PATCH v1 2/4] net/dpaa2: release port upon close

2020-09-28 Thread Sachin Saxena (OSS)
From: Sachin Saxena With removal of old close behavior, the private port resources must be released in the .dev_close callback. Freeing of port private resources is moved from the ".remove(device)" to the ".dev_close(port)" operation Signed-off-by: Sachin Saxena --

[dpdk-dev] [PATCH v1 1/4] net/dpaa: release port upon close

2020-09-28 Thread Sachin Saxena (OSS)
From: Sachin Saxena With removal of old close behavior, the private port resources must be released in the .dev_close callback. Freeing of port private resources is moved from the ".remove(device)" to the ".dev_close(port)" operation Signed-off-by: Sachin Saxena -

[dpdk-dev] [PATCH v1 0/4] Align device close operation with new behavior

2020-09-28 Thread Sachin Saxena (OSS)
From: Sachin Saxena - patches are rebased on v2 series: http://patches.dpdk.org/project/dpdk/list/?series=12533 Sachin Saxena (4): net/dpaa: release port upon close net/dpaa2: release port upon close net/pfe: release port upon close net/enetc: release port upon close drivers/net

[dpdk-dev] [PATCH v1 3/4] net/pfe: release port upon close

2020-09-28 Thread Sachin Saxena (OSS)
From: Sachin Saxena With removal of old close behavior, the private port resources must be released in the .dev_close callback. Freeing of port private resources is moved from the ".remove(device)" to the ".dev_close(port)" operation Signed-off-by: Sachin Saxena

[dpdk-dev] [PATCH v3 3/6] net/dpaa2: fix check for key size

2020-09-23 Thread Sachin Saxena (OSS)
From: Apeksha Gupta DPAA2 has support for raw flow classification, which can be used for any protocol rules. This change fixes flow key pattern length match boundary condition with spec length. Fixes: 3f881f8d6eb0 ("net/dpaa2: support raw flow classification") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH v3 5/6] net/dpaa: send error packets to application

2020-09-23 Thread Sachin Saxena (OSS)
From: Nipun Gupta Send error packets to main queue (rx) to make application enable to receive error packets. Earlier all packets with L3/L4 checksum errors were getting dropped by the hardware. Signed-off-by: Rohit Raj Signed-off-by: Nipun Gupta --- drivers/net/dpaa/dpaa_ethdev.c | 10 ---

[dpdk-dev] [PATCH v3 4/6] bus/dpaa: enables RX/TX error queues

2020-09-23 Thread Sachin Saxena (OSS)
From: Sachin Saxena Enables a debugging queue to fetch error (Rx/Tx) packets to user space. Earlier all packets with L3/L4 checksum errors were getting dropped by the hardware. Setting CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER=y is required which enables following enhancements. 1) Enable TX/RX error

[dpdk-dev] [PATCH v3 6/6] bus/dpaa: enhance link status support

2020-09-23 Thread Sachin Saxena (OSS)
-by: Sachin Saxena Signed-off-by: Rohit Raj --- drivers/bus/dpaa/base/qbman/process.c | 123 +++--- drivers/bus/dpaa/include/process.h| 34 +- drivers/bus/dpaa/rte_bus_dpaa_version.map | 3 + drivers/net/dpaa/dpaa_ethdev.c| 113

[dpdk-dev] [PATCH v3 2/6] bus/fslmc: run secondary debug app without blacklist devices

2020-09-23 Thread Sachin Saxena (OSS)
and DPIO for the secondary process usages. Signed-off-by: Rohit Raj Signed-off-by: Sachin Saxena --- doc/guides/nics/dpaa2.rst | 14 drivers/bus/fslmc/fslmc_vfio.c | 66 +++--- 2 files changed, 75 insertions(+), 5 deletions(-) diff --git a/doc/guides/nics

[dpdk-dev] [PATCH v3 1/6] bus/fslmc: fix atomic queues on nxp lx2 platform

2020-09-23 Thread Sachin Saxena (OSS)
From: Youri Querry Traffic was stalling after few packet while running l2fwd-event in atomic mode on LX2 platform. It was due to wrong dca setting while enqueuing packets to EQCR. This patch fixes the issue by writing correct dca setting. Fixes: 1b49352f41be ("bus/fslmc: rename portal pi index t

[dpdk-dev] [PATCH v3 0/6] enhancement and fixes for nxp dpaax platform

2020-09-23 Thread Sachin Saxena (OSS)
From: Sachin Saxena - V2: Removed checks warnings reported by checkpatch - V3: handled review comments Apeksha Gupta (1): net/dpaa2: fix check for key size Nipun Gupta (1): net/dpaa: send error packets to application Rohit Raj (2): bus/fslmc: run secondary debug app without blacklist

Re: [dpdk-dev] [PATCH v1] maintainers: update for nxp bus, dpaa, dpaa2 and enetc

2020-09-23 Thread Sachin Saxena (OSS)
On 24-Sep-20 5:29 AM, Thomas Monjalon wrote: 14/09/2020 16:06, Sachin Saxena (OSS): From: Sachin Saxena Updated email of maintainer. Signed-off-by: Sachin Saxena --- NXP buses M: Hemant Agrawal -M: Sachin Saxena +M: Sachin Saxena Tab is replaced with a space, and applied

[dpdk-dev] [PATCH v2] net/pfe: fix misuse of if_index

2020-09-14 Thread Sachin Saxena (OSS)
From: Sachin Saxena Pfe pmd has no need to bound host interface for which we require if_index field. Setting it to 0 as unused. Signed-off-by: Sachin Saxena --- drivers/net/pfe/pfe_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe

[dpdk-dev] [PATCH v2] net/dpaa2: fix misuse of if_index

2020-09-14 Thread Sachin Saxena (OSS)
From: Sachin Saxena Dpaa2 pmd has no need to bound host interface for which we require if_index field. Setting it to 0 as unused. Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers

[dpdk-dev] [PATCH v1] maintainers: update for nxp bus, dpaa, dpaa2 and enetc

2020-09-14 Thread Sachin Saxena (OSS)
From: Sachin Saxena Updated email of maintainer. Signed-off-by: Sachin Saxena --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3b16d7a4b..b257427e3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -506,7 +506,7 @@ F

[dpdk-dev] [PATCH v1 2/2] net/pfe: fix misuse of if_index

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena Pfe pmd has no need to bound host interface for which we require if_index field. Setting it to 0 as unused. Signed-off-by: Sachin Saxena --- drivers/net/pfe/pfe_ethdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/pfe/pfe_ethdev.c b

[dpdk-dev] [PATCH v1 1/2] net/dpaa2: fix misuse of if_index

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena Dpaa2 pmd has no need to bound host interface for which we require if_index field. Setting it to 0 as unused. Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2

[dpdk-dev] [PATCH v2 8/8] net/dpaa: send error packets to application

2020-09-11 Thread Sachin Saxena (OSS)
From: Nipun Gupta Send error packets to main queue (rx) to make application enable to receive error packets. Signed-off-by: Rohit Raj Signed-off-by: Nipun Gupta --- drivers/net/dpaa/dpaa_ethdev.c | 10 -- drivers/net/dpaa/dpaa_rxtx.c | 17 + drivers/net/dpaa/dpaa_rxt

[dpdk-dev] [PATCH v2 4/8] bus/dpaa: RX/TX error queues

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER=y 1) Enable TX/RX error queues to check the errors. 2) Display error frame information(payload, status, paresr result). Signed-off-by: Jun Yang Signed-off-by: Rohit Raj Signed-off-by: Sachin Saxena --- drivers/bus/dpaa/base/fman

[dpdk-dev] [PATCH v2 7/8] bus/dpaa: send error packets to application

2020-09-11 Thread Sachin Saxena (OSS)
From: Nipun Gupta Api fman_if_set_err_fqid should be marked as internal. Signed-off-by: Sachin Saxena Signed-off-by: Rohit Raj Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/include/fsl_fman.h | 1 + drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 + 2 files changed, 2 insertions

[dpdk-dev] [PATCH v2 6/8] bus/dpaa: enhance link status support

2020-09-11 Thread Sachin Saxena (OSS)
-by: Sachin Saxena Signed-off-by: Rohit Raj --- drivers/bus/dpaa/base/qbman/process.c | 123 +++--- drivers/bus/dpaa/include/process.h| 34 +- drivers/bus/dpaa/rte_bus_dpaa_version.map | 3 + drivers/net/dpaa/dpaa_ethdev.c| 113

[dpdk-dev] [PATCH v2 5/8] bus/fslmc: fix usage of dpio blocklist flag

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena DPIO object shouldn't be reserved if it is mentioned in blocklist. Exiting code is not setting the correct flag when such object is found. Fixes: c904a212646a ("bus/fslmc: run secondary debug app without blocklist devices") Signed-off-by: Sachin Saxena -

[dpdk-dev] [PATCH v2 1/8] bus/fslmc: fix atomic queues on nxp lx2 platform

2020-09-11 Thread Sachin Saxena (OSS)
From: Youri Querry Traffic was stalling after few packet while running l2fwd-event in atomic mode on LX2 platform. It was due to wrong dca setting while enqueuing packets to EQCR. This patch fixes the issue by writing correct dca setting. Fixes: 1b49352f41be ("bus/fslmc: rename portal pi index t

[dpdk-dev] [PATCH v2 3/8] net/dpaa2: fix check for key size

2020-09-11 Thread Sachin Saxena (OSS)
From: Apeksha Gupta DPAA2 has support for raw flow classification, which can be used for any protocol rules. This change fixes flow key pattern length match. Fixes: 3f881f8d6eb0 ("net/dpaa2: support raw flow classification") Signed-off-by: Apeksha Gupta --- drivers/net/dpaa2/dpaa2_flow.c | 2

[dpdk-dev] [PATCH v2 0/8] enhancement and fixes for nxp dpaax platform

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena - V2: Removed checks warnings reported by checkpatch Apeksha Gupta (1): net/dpaa2: fix check for key size Nipun Gupta (2): bus/dpaa: send error packets to application net/dpaa: send error packets to application Rohit Raj (2): bus/fslmc: run secondary debug app

[dpdk-dev] [PATCH v2 2/8] bus/fslmc: run secondary debug app without blocklist devices

2020-09-11 Thread Sachin Saxena (OSS)
DPMCP and DPIO for the secondary process usages. Signed-off-by: Rohit Raj Reviewed-by: Sachin Saxena --- drivers/bus/fslmc/fslmc_vfio.c | 66 +++--- 1 file changed, 61 insertions(+), 5 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc

[dpdk-dev] [PATCH v1] mempool: dump socket id attribute

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena Enhance the dump function to also print socket_id attribute passed at creation time. Signed-off-by: Sachin Saxena --- lib/librte_mempool/rte_mempool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c

[dpdk-dev] [PATCH v1 7/8] bus/dpaa: send error packets to application

2020-09-11 Thread Sachin Saxena (OSS)
From: Nipun Gupta Api fman_if_set_err_fqid should be marked as internal. Signed-off-by: Sachin Saxena Signed-off-by: Rohit Raj Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/include/fsl_fman.h | 1 + drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 + 2 files changed, 2 insertions

[dpdk-dev] [PATCH v1 5/8] bus/fslmc: fix usage of dpio blocklist flag

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena DPIO object shouldn't be reserved if it is mentioned in blocklist. Exiting code is not setting the correct flag when such object is found. Fixes: c904a212646a ("bus/fslmc: run secondary debug app without blocklist devices") Signed-off-by: Sachin Saxena -

[dpdk-dev] [PATCH v1 8/8] net/dpaa: send error packets to application

2020-09-11 Thread Sachin Saxena (OSS)
From: Nipun Gupta Send error packets to main queue (rx) to make application enable to receive error packets. Signed-off-by: Rohit Raj Signed-off-by: Nipun Gupta --- drivers/net/dpaa/dpaa_ethdev.c | 10 -- drivers/net/dpaa/dpaa_rxtx.c | 17 + drivers/net/dpaa/dpaa_rxt

[dpdk-dev] [PATCH v1 6/8] bus/dpaa: enhance link status support

2020-09-11 Thread Sachin Saxena (OSS)
-by: Sachin Saxena Signed-off-by: Rohit Raj --- drivers/bus/dpaa/base/qbman/process.c | 123 +++--- drivers/bus/dpaa/include/process.h| 34 +- drivers/bus/dpaa/rte_bus_dpaa_version.map | 3 + drivers/net/dpaa/dpaa_ethdev.c| 113 4

[dpdk-dev] [PATCH v1 2/8] bus/fslmc: run secondary debug app without blocklist devices

2020-09-11 Thread Sachin Saxena (OSS)
DPMCP and DPIO for the secondary process usages. Signed-off-by: Rohit Raj Reviewed-by: Sachin Saxena --- drivers/bus/fslmc/fslmc_vfio.c | 66 +++--- 1 file changed, 61 insertions(+), 5 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc

[dpdk-dev] [PATCH v1 1/8] bus/fslmc: fix atomic queues on nxp lx2 platform

2020-09-11 Thread Sachin Saxena (OSS)
From: Youri Querry Traffic was stalling after few packet while running l2fwd-event in atomic mode on LX2 platform. It was due to wrong dca setting while enqueuing packets to EQCR. This patch fixes the issue by writing correct dca setting. Fixes: 1b49352f41be ("bus/fslmc: rename portal pi index t

[dpdk-dev] [PATCH v1 4/8] bus/dpaa: RX/TX error queues

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER=y 1) Enable TX/RX error queues to check the errors. 2) Display error frame information(payload, status, paresr result). Signed-off-by: Jun Yang Signed-off-by: Rohit Raj Signed-off-by: Sachin Saxena --- drivers/bus/dpaa/base/fman

[dpdk-dev] [PATCH v1 3/8] net/dpaa2: fix check for key size

2020-09-11 Thread Sachin Saxena (OSS)
From: Apeksha Gupta DPAA2 has support for raw flow classification, which can be used for any protocol rules. This change fixes flow key pattern length match. Fixes: 3f881f8d6eb0 ("net/dpaa2: support raw flow classification") Signed-off-by: Apeksha Gupta --- drivers/net/dpaa2/dpaa2_flow.c | 2

[dpdk-dev] [PATCH v1 0/8] enhancements and fixes for nxp dpaax platform

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena Apeksha Gupta (1): net/dpaa2: fix check for key size Nipun Gupta (2): bus/dpaa: send error packets to application net/dpaa: send error packets to application Rohit Raj (2): bus/fslmc: run secondary debug app without blocklist devices bus/dpaa: enhance link status

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: remove underscore prefix from internal API

2020-09-09 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 09-Sep-20 6:31 PM, Ferruh Yigit wrote: '_rte_eth_dev_callback_process()' & '_rte_eth_dev_reset()' internal APIs has unconventional underscore ('_') prefix. Although this is not documented most probably this is to mark them as inter

Re: [dpdk-dev] [PATCH v4 2/7] ethdev: move inline device operations

2020-09-09 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 09-Sep-20 6:31 PM, Ferruh Yigit wrote: This patch is a preparation to hide the 'struct eth_dev_ops' from applications by moving some device operations from 'struct eth_dev_ops' to 'struct rte_eth_dev'. Mentioned ethdev APIs are in th

Re: [dpdk-dev] [PATCH] bus/dpaa: fix fd check before close

2020-08-26 Thread Sachin Saxena (OSS)
Thanks Yunjian for the fix. Acked-by: Sachin Saxena On 26-Aug-20 5:24 PM, wangyunjian wrote: From: Yunjian Wang The fd is possibly a negative value while it is passed as an argument to function "close". Fix the check to the fd. Fixes: b9c94167904f ("bus/dpaa: decouple FQ p

Re: [dpdk-dev] [PATCH v1] bus/fslmc: fix dpio close

2020-08-06 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 28-Jul-20 9:54 PM, rohit@nxp.com wrote: From: Rohit Raj The current state of the DPIO object should be checked before trying to close/disable the object. Fixes: 293c0ca94c36 ("bus/fslmc: support memory backed portals with QBMAN 5.0") Cc: sta..

Re: [dpdk-dev] [PATCH v1 3/3] bus/fslmc: support bus close API

2020-08-05 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 28-Jul-20 10:12 PM, rohit@nxp.com wrote: From: Rohit Raj This patch add support for closing the bus objects which were acquired In the bus probe. Some devices need to be cleaned while in both primary and secondary process and while some need to be cleaned

Re: [dpdk-dev] [PATCH v1 2/3] examples/multi_process: cleanup bus objects while terminating app

2020-08-05 Thread Sachin Saxena (OSS)
On 28-Jul-20 10:12 PM, rohit@nxp.com wrote: From: Rohit Raj Certain bus objects may need to be closed and re-acquired while terminating and rerunning the client application. Hence a signal handler is required to catch the termination of the App and hence closing the bus objects. This pa

[dpdk-dev] [PATCH] net/dpaa: announce extended definition of port_id in API 'rte_pmd_dpaa_set_tx_loopback'

2020-07-14 Thread Sachin Saxena (OSS)
From: Sachin Saxena Signed-off-by: Sachin Saxena --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index a58a17946..a0715e587 100644 --- a/doc/guides/rel_notes

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-22 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 22-Jun-20 1:39 PM, Wei Hu (Xavier) wrote: Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver does not support certain VLAN hardware

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: fix data room size verification in Rx queue setup

2020-06-22 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 22-Jun-20 1:38 PM, Wei Hu (Xavier) wrote: In the rte_eth_rx_queue_setup API function, the local variable named mbp_buf_size, which is the data room size of the input parameter mp, is checked to guarantee that each memory chunck used for net device in the mbuf is

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-21 Thread Sachin Saxena (OSS)
On 22-Jun-20 8:17 AM, Wei Hu (Xavier) wrote: Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver does not support certain VLAN hardware offloads and does not check

Re: [dpdk-dev] [PATCH 11/13] drivers/bus: use log register macro

2020-06-21 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 17-Jun-20 12:00 PM, jer...@marvell.com wrote: From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/bus/dpaa/dpaa_bus.c | 10 +- drivers/bus/fslmc/fslmc_bus.c

Re: [dpdk-dev] [PATCH 10/13] drivers/common: use log register macro

2020-06-21 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 17-Jun-20 12:00 PM, jer...@marvell.com wrote: From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/common/dpaax/dpaax_iova_table.c | 10 +-- drivers/common/iavf

Re: [dpdk-dev] [PATCH 06/13] drivers/mempool: use log register macro

2020-06-21 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 17-Jun-20 12:00 PM, jer...@marvell.com wrote: From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/mempool/dpaa/dpaa_mempool.c | 10 ++ drivers/mempool

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-21 Thread Sachin Saxena (OSS)
On 17-Jun-20 12:00 PM, jer...@marvell.com wrote: From: Jerin Jacob Introducing the RTE_LOG_REGISTER macro to avoid the code duplication in the log registration process. It is a wrapper macro for declaring the logtype, register the log and sets it's level in the constructor context. Signed-off

Re: [dpdk-dev] [dpdk-announce] release candidate 19.11-rc4

2019-11-28 Thread Sachin Saxena
dpdk_ethtool_function dpdk_ipv4_multicast regards, Sachin Saxena > -Original Message- > From: dev On Behalf Of Luca Boccassi > Sent: Thursday, November 28, 2019 3:21 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Ju-Hyoung Lee ; > Abhishek Marathe > Subject: Re: [dpd

Re: [dpdk-dev] [PATCH v7 09/10] build: change ABI version to 20.0

2019-11-21 Thread Sachin Saxena
> -Original Message- > From: David Marchand > Sent: Wednesday, November 20, 2019 3:20 AM > To: Anatoly Burakov ; Thomas Monjalon > > Cc: dev ; Hemant Agrawal ; > Sachin Saxena ; Stephen Hemminger > ; Mcnamara, John > ; Kinsella, Ray ; Bruce > Richardson

Re: [dpdk-dev] [PATCH] drivers: copyrights update for nxp files

2019-11-18 Thread Sachin Saxena
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 6, 2019 4:36 PM > To: dev@dpdk.org > Cc: Sachin Saxena ; ferruh.yi...@intel.com; Hemant > Agrawal ; techbo...@dpdk.org > Subject: Re: [PATCH] drivers: copyrights update for nxp files > Imp

[dpdk-dev] [PATCH v2] net/dpaa2: fix Rx offload flags on jumbo MTU set

2019-11-11 Thread Sachin Saxena
dpaa2: support new ethdev offload APIs") Cc: sta...@dpdk.org Signed-off-by: Sachin Saxena Reviewed-by: Gagandeep Singh --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethd

Re: [dpdk-dev] [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx offloads flags

2019-11-11 Thread Sachin Saxena
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 11, 2019 9:27 PM > To: Sachin Saxena > Cc: dev@dpdk.org; ferruh.yi...@intel.com; sta...@dpdk.org > Subject: Re: [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx > offloads flags

[dpdk-dev] [PATCH v1] net/dpaa2: fixes issue of accidentally resetting rx offloads flags

2019-11-11 Thread Sachin Saxena
dpaa2: support new ethdev offload APIs") Cc: sta...@dpdk.org Signed-off-by: Sachin Saxena Reviewed-by: Gagandeep Singh --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethd

Re: [dpdk-dev] [PATCH] drivers: copyrights update for NXP files

2019-11-06 Thread Sachin Saxena
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 6, 2019 4:36 PM > To: dev@dpdk.org > Cc: Sachin Saxena ; ferruh.yi...@intel.com; > Hemant Agrawal ; techbo...@dpdk.org > Subject: Re: [PATCH] drivers: copyrights update for nxp files > Imp

[dpdk-dev] [PATCH] drivers: copyrights update for nxp files

2019-11-06 Thread Sachin Saxena
Signed-off-by: Sachin Saxena --- drivers/bus/dpaa/base/fman/fman.c| 2 +- drivers/bus/dpaa/base/fman/netcfg_layer.c| 2 +- drivers/bus/dpaa/rte_dpaa_bus.h | 2 +- drivers/bus/fslmc/mc/dpci.c | 1 + drivers/bus/fslmc/mc/dpcon.c

Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue

2019-10-31 Thread Sachin Saxena
> -Original Message- > From: David Marchand > Sent: Friday, October 25, 2019 12:47 AM > To: Sachin Saxena > Cc: Babu Radhakrishnan, AgalyaX ; > dev@dpdk.org; Pattan, Reshma ; Hemant > Agrawal ; Parthasarathy, JananeeX M > ; sta...@dpdk.org > Subject: Re: [

Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue

2019-10-03 Thread Sachin Saxena
> -Original Message- > From: Babu Radhakrishnan, AgalyaX > > Sent: Tuesday, September 10, 2019 1:11 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Hemant Agrawal > ; Sachin Saxena ; > Parthasarathy, JananeeX M ; > sta...@dpdk.org > Subject: RE: [PATCH] bu

Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue

2019-10-03 Thread Sachin Saxena
Acked-by: Sachin Saxena regards, Sachin Saxena > -Original Message- > From: Agalya Babu RadhaKrishnan > Sent: Tuesday, September 10, 2019 1:01 PM > To: dev@dpdk.org > Cc: reshma.pat...@intel.com; Hemant Agrawal > ; Sachin Saxena ; > jananeex.m.parthasara...@i

Re: [dpdk-dev] [PATCH 05/10] crypto/dpaa2_sec: fix global variable multiple definitions

2019-09-10 Thread Sachin Saxena
Acked-by: Sachin Saxena

Re: [dpdk-dev] [PATCH 01/10] bus/fslmc: fix global variable multiple definitions

2019-09-10 Thread Sachin Saxena
Acked-by: Sachin Saxena > -Original Message- > From: Ferruh Yigit > Sent: Thursday, September 5, 2019 8:23 PM > To: Hemant Agrawal ; Sachin Saxena > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 01/10] bus/fslmc: fix global variable multiple definitio

[dpdk-dev] [PATCH v1 2/2] net/dpaa2: update MC firmware version for FSLMC bus

2019-09-10 Thread Sachin Saxena
MC firmware is the core component of FSLMC bus and net/DPAA2 devices. Prior to this patch, MC firmware supported 10.14.x version. This patch bumps the min supported version to 10.18.x. Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 1 + drivers/net/dpaa2

[dpdk-dev] [PATCH v1 0/2] Update MC firmware version for FSLMC bus and DPAA2 devices

2019-09-10 Thread Sachin Saxena
This patch add the support for new Management Complex Firmware version to 10.18.x. Sachin Saxena (2): bus/fslmc: update MC firmware version for FSLMC bus net/dpaa2: update MC firmware version for FSLMC bus drivers/bus/fslmc/mc/fsl_dpio_cmd.h| 4 +-- drivers/bus/fslmc/mc/fsl_dpmng.h

[dpdk-dev] [PATCH v1 1/2] bus/fslmc: update MC firmware version for FSLMC bus

2019-09-10 Thread Sachin Saxena
MC firmware is the core component of FSLMC bus and DPAA2 devices. Prior to this patch, MC firmware supported 10.14.x version. This patch bumps the min supported version to 10.18.x. Signed-off-by: Sachin Saxena --- drivers/bus/fslmc/mc/fsl_dpio_cmd.h | 4 ++-- drivers/bus/fslmc/mc

[dpdk-dev] [PATCH v2 30/30] net/dpaa2: add soft parser driver

2019-08-29 Thread Sachin Saxena
From: Sunil Kumar Kori Signed-off-by: Sunil Kumar Kori --- drivers/net/dpaa2/Makefile| 1 + drivers/net/dpaa2/dpaa2_ethdev.c | 24 +++ drivers/net/dpaa2/dpaa2_ethdev.h | 4 + drivers/net/dpaa2/dpaa2_sparser.c | 269 ++ drivers/net/dpaa2/dpaa2_sparser.h

[dpdk-dev] [PATCH v2 28/30] net/dpaa2: support separate MC portal per process

2019-08-29 Thread Sachin Saxena
used as part of the DPNI configuration. By using the process_private member of the rte_eth_dev, it is possible to keep separate handles per process. Without worry of overwriting when secondary process accesses the dev_private. Signed-off-by: Shreyansh Jain Reviewed-by: Sachin Saxena --- drivers

[dpdk-dev] [PATCH v2 27/30] bus/fslmc: support multi vfio group

2019-08-29 Thread Sachin Saxena
From: Hemant Agrawal DPAA2 support VFIO device passthrough in VM. However in this case, each device is associated with different vfio group. This code required different container id for each group. On using the same container fd the second time, ioctl calls are returning error. Signed-off-by:

[dpdk-dev] [PATCH v2 26/30] bus/fslmc: check for Dma map in primary process only

2019-08-29 Thread Sachin Saxena
From: Shreyansh Jain DMA mapping is a property of primary process - SMMU population done once by primary doesn't need to be populated again in secondary Signed-off-by: Shreyansh Jain Reviewed-by: Sachin Saxena --- drivers/bus/fslmc/fslmc_bus.c | 15 +-- 1 file chang

  1   2   >