[dpdk-dev] Q on rte hash table

2021-08-12 Thread Ravi Kerur
Hello, Using dpdk 19.11 and trying to understand the index returned by 'rte_hash_add_key', API says ... * - A positive value that can be used by the caller as an offset into an * array of user data. This value is unique for this key. */ int32_t rte_hash_add_key(const struct rte_hash *h, co

[dpdk-dev] Q on l3fwd-acl and acl library

2021-03-02 Thread Ravi Kerur
Hello, I am using l3fwd-acl example code and would like to know the intention of ACL_DENY_SIGNATURE in the code. Is ACL rules programmed to drop packets and not for any other functionality? I see that userdata is ignored for ACL and programmed with ACL_DENY_SIGNATURE + count. After classification

[dpdk-dev] Q on IXGBE (dpdk 19.11)

2020-06-24 Thread Ravi Kerur
DPDK team, I have a use-case for multicast and wanted to know the current behavior of ixgbe pf and vf driver so my understanding is correct. use-case: 2 VF's (vf1 and vf2 ) from ixgbe is assigned to 2 VM's (vm1 and vm2) vf1 -- registers to mcast 01:00:5e:00:00:01, 01:00:5e:00:00:0a vf2 -- regist

Re: [dpdk-dev] [ovs-dev] OvS DPDK crash when HPET timer enabled

2020-04-14 Thread Ravi Kerur
0 5:27 PM, Ravi Kerur wrote: > > > On Sun, Apr 12, 2020 at 5:05 AM Tonghao Zhang < > xiangxia.m@gmail.com> > > > wrote: > > > > > >> On Sun, Apr 12, 2020 at 7:57 AM Ravi Kerur wrote: > > >>> > > >>> Hello OvS

Re: [dpdk-dev] Debug crash in bucket_enqueue ()

2019-10-24 Thread Ravi Kerur
gcc/lib/librte_table.a(rte_table_lpm_ipv6.o) (--whole-archive) /home/rkerur/dpdk-stable-18.11.2//x86_64-native-linuxapp-gcc/lib/librte_table.a(rte_table_acl.o) (--whole-archive) ... Thanks. > > > Andrew. > > On 10/24/19 7:4

[dpdk-dev] Debug crash in bucket_enqueue ()

2019-10-24 Thread Ravi Kerur
DPDK team, I have a simple multi process setup with OVS/DPDK as primary and another process as secondary. OVS/DPDK sets up mempool and rings with MP/MC flags and secondary process attaches to it. I have used example/multi-process/simple_mp as an example. I have disabled 'ASLR' and made sure primar

[dpdk-dev] Documentation bug or I am doing something wrong

2018-05-29 Thread Ravi Kerur
Hi, I have a VM and a container running inside VM. I am creating virtio/vhost as described in the following link https://dpdk.org/doc/guides/howto/virtio_user_for_container_networking.html (1st issue) Ubuntu:latest or Ubuntu:16.04 doesn't come with 'libnuma1' installed by default. If I just have

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-15 Thread Ravi Kerur
On Thu, Feb 15, 2018 at 10:27 AM, Ravi Kerur wrote: > > > On Thu, Feb 15, 2018 at 2:28 AM, Burakov, Anatoly < > anatoly.bura...@intel.com> wrote: > >> On 14-Feb-18 8:00 PM, Ravi Kerur wrote: >> >>> >>> Earlier I was focusing only on DMAR errors

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-15 Thread Ravi Kerur
On Thu, Feb 15, 2018 at 2:28 AM, Burakov, Anatoly wrote: > On 14-Feb-18 8:00 PM, Ravi Kerur wrote: > >> >> Earlier I was focusing only on DMAR errors and I might have said 'it >> worked' when I didn't notice them on host when dpdk was started on guest. >

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-14 Thread Ravi Kerur
On Tue, Feb 13, 2018 at 6:31 AM, Burakov, Anatoly wrote: > On 12-Feb-18 10:00 PM, Ravi Kerur wrote: > >> >> Let me just give you what has been tested and working/nonworking >> scenarios. Some of your questions might get answered as well. >>

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-12 Thread Ravi Kerur
On Mon, Feb 12, 2018 at 2:13 AM, Burakov, Anatoly wrote: > On 10-Feb-18 5:53 PM, Ravi Kerur wrote: > > >> >> On Sat, Feb 10, 2018 at 2:58 AM, Burakov, Anatoly < >> anatoly.bura...@intel.com <mailto:anatoly.bura...@intel.com>> wrote: >> &

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-10 Thread Ravi Kerur
On Sat, Feb 10, 2018 at 2:58 AM, Burakov, Anatoly wrote: > On 29-Jan-18 10:35 PM, Ravi Kerur wrote: > >> Hi Burakov, >> >> When using vfio-pci on host both VF and PF interfaces works fine with >> dpdk i.e. I don't see DMAR fault messages anymore. However, when

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-09 Thread Ravi Kerur
On Thu, Feb 8, 2018 at 3:20 AM, Burakov, Anatoly wrote: > On 06-Feb-18 5:55 PM, Ravi Kerur wrote: > >> >> Hi Anatoly, >> >> I am actually confused with the state of vIOMMU + DPDK. Can you please >> help me clarify? >> >> I tested following DPDK v

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-06 Thread Ravi Kerur
On Mon, Feb 5, 2018 at 2:01 AM, Burakov, Anatoly wrote: > On 02-Feb-18 8:51 PM, Ravi Kerur wrote: > >> >> >> On Fri, Feb 2, 2018 at 12:21 PM, Ravi Kerur > rke...@gmail.com>> wrote: >> >> >> >> On Fri, Feb 2, 2018 at 2:28 AM, Burakov

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-02 Thread Ravi Kerur
On Fri, Feb 2, 2018 at 12:21 PM, Ravi Kerur wrote: > > > On Fri, Feb 2, 2018 at 2:28 AM, Burakov, Anatoly < > anatoly.bura...@intel.com> wrote: > >> On 01-Feb-18 7:26 PM, Ravi Kerur wrote: >> >>> >>> >>> On Thu, Feb 1, 2018

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-02 Thread Ravi Kerur
On Fri, Feb 2, 2018 at 2:28 AM, Burakov, Anatoly wrote: > On 01-Feb-18 7:26 PM, Ravi Kerur wrote: > >> >> >> On Thu, Feb 1, 2018 at 2:10 AM, Burakov, Anatoly < >> anatoly.bura...@intel.com <mailto:anatoly.bura...@intel.com>> wrote: >&g

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-01 Thread Ravi Kerur
On Thu, Feb 1, 2018 at 2:10 AM, Burakov, Anatoly wrote: > On 31-Jan-18 9:51 PM, Ravi Kerur wrote: > >> >> Hi Anatoly, >> >> Thanks. I am following wiki link below which uses vIOMMU with DPDK as a >> use-case and instantiate VM as specified with Q35 chipset

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-01-31 Thread Ravi Kerur
On Wed, Jan 31, 2018 at 1:59 AM, Burakov, Anatoly wrote: > On 29-Jan-18 10:35 PM, Ravi Kerur wrote: > >> Hi Burakov, >> >> When using vfio-pci on host both VF and PF interfaces works fine with >> dpdk i.e. I don't see DMAR fault messages anymore. However, when

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-01-29 Thread Ravi Kerur
Virtual Function Control: I/O- Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- wrote: > On 24-Jan-18 7:13 PM, Ravi Kerur wrote: > >> Hi Burakov, Thank you. I

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-01-24 Thread Ravi Kerur
Hi Burakov, Thank you. I will try with vfio-pci driver. I am assuming it will work for both PF and VF interfaces since I am using both in my setup? Thanks. On Wed, Jan 24, 2018 at 2:31 AM, Burakov, Anatoly wrote: > On 23-Jan-18 5:25 PM, Ravi Kerur wrote: > >> Hi, >> >&

[dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-01-23 Thread Ravi Kerur
Hi, I am running into an issue when DPDK is started with iommu on via GRUB command. Problem is not seen with regular kernel driver, error messages show when DPDK is started and happens for both PF and VF interfaces. I am using DPDK 17.05 so the patch proposed in the following link is available ht

Re: [dpdk-dev] [PATCH v2] doc: Merge l3fwd and l3fwd-acl documentation files

2017-05-10 Thread Ravi Kerur
On Wed, May 10, 2017 at 3:14 AM, Mcnamara, John wrote: > > > > -Original Message- > > From: Ravi Kerur [mailto:rke...@gmail.com] > > Sent: Monday, May 8, 2017 10:00 PM > > To: dev@dpdk.org > > Cc: Mcnamara, John ; tho...@monjalon.net; Ravi > >

[dpdk-dev] [PATCH v3] doc: Merge l3fwd and l3fwd-acl documentation files

2017-05-10 Thread Ravi Kerur
Merge l3fwd and l3fwd-acl documentation to reflect the code. Add examples of LPM and Exact Match rules as text. Signed-off-by: Ravi Kerur --- v3: Incorporate John's comments. Remove svg files, instead include text format. v2: Remove binary PNG from .svg files

Re: [dpdk-dev] [PATCH v1] doc: Merge l3fwd and l3fwd-acl documentation files

2017-05-08 Thread Ravi Kerur
On Sun, May 7, 2017 at 1:50 PM, Thomas Monjalon wrote: > Hi, > > 25/04/2017 20:39, Ravi Kerur: > > Merge relevant contents of l3fwd and l3fwd-acl documentation. > > Modify l3fwd document with ACL specific information. > > Remove l3fwd-acl documentation file. > &

[dpdk-dev] [PATCH v2] doc: Merge l3fwd and l3fwd-acl documentation files

2017-05-08 Thread Ravi Kerur
Merge l3fwd and l3fwd-acl documentation to reflect the code. Add examples of LPM and Exact Match rules in .svg files. Signed-off-by: Ravi Kerur --- v2: Remove binary PNG from .svg files. v1: Merge relevant contents of l3fwd and l3fwd-acl documentation. Modify l3fwd

[dpdk-dev] [PATCH v1] doc: Merge l3fwd and l3fwd-acl documentation files

2017-04-25 Thread Ravi Kerur
Merge relevant contents of l3fwd and l3fwd-acl documentation. Modify l3fwd document with ACL specific information. Remove l3fwd-acl documentation file. Signed-off-by: Ravi Kerur --- doc/guides/sample_app_ug/img/ipv4_hash_rule.svg| 158 + doc/guides/sample_app_ug/img

Re: [dpdk-dev] Q on IXGBE and I40E vector Tx processing

2017-04-17 Thread Ravi Kerur
Hi Konstantin, On Sun, Apr 16, 2017 at 3:26 PM, Ananyev, Konstantin < konstantin.anan...@intel.com> wrote: > > Hi Ravi, > > > > > Hi, > > > > The reason I am asking I because I have tried different combinations of > > scalar and vector Tx and Rx processing for both IXGBE and I40E with > > followi

Re: [dpdk-dev] Q on IXGBE and I40E vector Tx processing

2017-04-16 Thread Ravi Kerur
t so kindly let me know. Thanks. On Fri, Apr 14, 2017 at 10:35 AM, Ravi Kerur wrote: > Hi, > > We are using dpdk 16.04 and by looking at the ixgbe and > i40e(i40e_xmit_pkts_vec) and ixgbe(ixgbe_xmit_pkts_vec) driver vector tx > processing code I see they both don't handle sca

[dpdk-dev] Q on IXGBE and I40E vector Tx processing

2017-04-14 Thread Ravi Kerur
Hi, We are using dpdk 16.04 and by looking at the ixgbe and i40e(i40e_xmit_pkts_vec) and ixgbe(ixgbe_xmit_pkts_vec) driver vector tx processing code I see they both don't handle scattered packet processing. For any packets greater than 2048 bytes which will basically contain multiple rte_mbuf segs

Re: [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd

2017-03-14 Thread Ravi Kerur
Hi John, Konstantin, On Thu, Mar 9, 2017 at 4:07 PM, Ravi Kerur wrote: > Hi John, > > On Thu, Mar 9, 2017 at 2:23 AM, Mcnamara, John > wrote: > >> > From: Ravi Kerur [mailto:rke...@gmail.com] >> > Sent: Monday, March 6, 2017 11:21 PM >> > To: Mcna

[dpdk-dev] [PATCH v6 3/3] examples/l3fwd: add config file support for exact

2017-03-10 Thread Ravi Kerur
:fe91:3805 102 12 0x06 1 ... Signed-off-by: Ravi Kerur --- examples/l3fwd/l3fwd_em.c | 376 +- 1 file changed, 303 insertions(+), 73 deletions(-) diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c index 6fdabf7..cd6b443 100

[dpdk-dev] [PATCH v6 1/3] examples/l3fwd: merge l3fwd-acl code into l3fwd

2017-03-10 Thread Ravi Kerur
: > Compiled successfully for x86_64-native-linuxapp-gcc > Tested LPM, EM and ACL basic functionality. Signed-off-by: Ravi Kerur --- examples/l3fwd-acl/Makefile | 56 - examples/l3fwd-acl/main.c | 2079

[dpdk-dev] [PATCH v6 2/3] examples/l3fwd: add config file support for lpm

2017-03-10 Thread Ravi Kerur
L:::::::/48 0 L2111:::::::/48 1 L3111:::::::/48 2 ... Signed-off-by: Ravi Kerur --- examples/l3fwd/l3fwd.h | 28 + examples/l3fwd/l3fwd_acl.c |

[dpdk-dev] [PATCH v6 0/3] examples/l3fwd: merge l3fwd-acl code into l3fwd

2017-03-10 Thread Ravi Kerur
This patchset merges l3fwd-acl and l3fwd code into common directory. Adds config file read option to build LPM and EM tables. Ravi Kerur (3): examples/l3fwd: merge l3fwd-acl code into l3fwd examples/l3fwd: add config file support for lpm examples/l3fwd: add config file support for exact

Re: [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd

2017-03-09 Thread Ravi Kerur
Hi John, On Thu, Mar 9, 2017 at 2:23 AM, Mcnamara, John wrote: > > From: Ravi Kerur [mailto:rke...@gmail.com] > > Sent: Monday, March 6, 2017 11:21 PM > > To: Mcnamara, John > > Cc: dev@dpdk.org; Ananyev, Konstantin ; > > Richardson, Bruce > > Subject:

Re: [dpdk-dev] [PATCH v5 3/3] examples/l3fwd: add config file support for EM

2017-03-09 Thread Ravi Kerur
Hi John, On Thu, Mar 9, 2017 at 2:45 AM, Mcnamara, John wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kerur > > Sent: Wednesday, March 8, 2017 9:32 PM > > To: dev@dpdk.org; Ananyev, Konstantin ; > > R

Re: [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd

2017-03-08 Thread Ravi Kerur
ar 6, 2017 at 3:20 PM, Ravi Kerur wrote: > Hi John, > > Should I work with documentation team to update the document? If yes, > please let me know the contact information. > > Thanks. > > On Mon, Mar 6, 2017 at 5:33 AM, Mcnamara, John > wrote: > >> >

[dpdk-dev] [PATCH v5 1/3] examples/l3fwd: merge l3fwd-acl code into l3fwd

2017-03-08 Thread Ravi Kerur
l3fwd-acl definitions. > Move specific setup functions (setup_acl, setup_lpm and setup_hash). Testing: > Compiled successfully for x86_64-native-linuxapp-gcc > Tested LPM, EM and ACL b

[dpdk-dev] [PATCH v5 3/3] examples/l3fwd: add config file support for EM

2017-03-08 Thread Ravi Kerur
0::::021e:67ff:fe00: fe80::::021b:21ff:fe91:3805 101 11 0x06 0 Efe90::::021e:67ff:fe00: fe90::::021b:21ff:fe91:3805 102 12 0x06 1 ... Signed-off-by: Ravi Kerur

[dpdk-dev] [PATCH v5 2/3] examples/l3fwd: add config file support for LPM

2017-03-08 Thread Ravi Kerur
::::/48 1 L3111:::::::/48 2 ... Signed-off-by: Ravi Kerur --- examples/l3fwd/l3fwd.h | 28 + examples/l3fwd/l3fwd_acl.c | 39 +- examples/l3fwd/l3fwd_acl.h | 29 - examples

[dpdk-dev] [PATCH v5 0/3] examples/l3fwd: merge l3fwd-acl code into l3fwd

2017-03-08 Thread Ravi Kerur
This patchset merges l3fwd-acl and l3fwd code into common directory. Adds file read options to build LPM and EM tables. Ravi Kerur (3): examples/l3fwd: Merge l3fwd-acl code into l3fwd examples/l3fwd: add config file support for LPM examples/l3fwd: add config file support for EM examples

Re: [dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd

2017-03-06 Thread Ravi Kerur
Hi John, Should I work with documentation team to update the document? If yes, please let me know the contact information. Thanks. On Mon, Mar 6, 2017 at 5:33 AM, Mcnamara, John wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Ke

Re: [dpdk-dev] [v3 2/3] LPM config file read option.

2017-03-06 Thread Ravi Kerur
Sure Stephen will make the changes. On Mon, Mar 6, 2017 at 8:46 AM, Stephen Hemminger < step...@networkplumber.org> wrote: > On Sat, 4 Mar 2017 12:44:18 -0800 > Ravi Kerur wrote: > > > +/* Bypass comment and empty lines */ > > +static inline int >

Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-03-05 Thread Ravi Kerur
h didn't show > > up in my run. > > > > 'v3' patch should have all fixed except the ones I mentioned in my > earlier email on which I need inputs from you. > > > > Thanks. > > > > On Sat, Mar 4, 2017 at 11:49 AM, Ravi Kerur wrote: > &g

[dpdk-dev] [v4 1/3] Merge l3fwd-acl and l3fwd code.

2017-03-05 Thread Ravi Kerur
cl, setup_lpm and setup_hash). Testing: > Compiled successfully for x86_64-native-linuxapp-gcc > Tested LPM, EM and ACL basic functionality. Signed-off-by: Ravi Kerur --- examples/l3fwd-acl/Makefil

[dpdk-dev] [v4 3/3] EM config file read option.

2017-03-05 Thread Ravi Kerur
3805 101 11 0x06 0 Efe90::::021e:67ff:fe00: fe90::::021b:21ff:fe91:3805 102 12 0x06 1 ... Signed-off-by: Ravi Kerur --- examples/l3fwd/l3fwd_em.c | 376 +- 1 file changed, 303

[dpdk-dev] [v4 0/3] Merge l3fwd-acl and l3fwd

2017-03-05 Thread Ravi Kerur
This patchset merges l3fwd-acl and l3fwd code into common directory. Adds file read options to build LPM and EM tables. Ravi Kerur (3): Merge l3fwd-acl and l3fwd code. LPM config file read option. EM config file read option. examples/l3fwd-acl/Makefile | 56 - examples/l3fwd-acl

[dpdk-dev] [v4 2/3] LPM config file read option.

2017-03-05 Thread Ravi Kerur
L3.1.1.0/24 2 ... #LPM6 route entries Dest-IP/Mask IF_OUT L:::::::/48 0 L2111:::::::/48 1 L3111:::::::/48 2 ... Signed-off-by: Ravi

Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-03-04 Thread Ravi Kerur
ts from you. Thanks. On Sat, Mar 4, 2017 at 11:49 AM, Ravi Kerur wrote: > Hi Konstantin, > > I have sent 'v2' patchset. I need clarifications on following things, if > they should be fixed I will send out 'v3' so please let me know. > > Following code chang

[dpdk-dev] [v3 3/3] EM config file read option.

2017-03-04 Thread Ravi Kerur
::::021e:67ff:fe00: fe90::::021b:21ff:fe91:3805 102 12 0x06 1 ... Signed-off-by: Ravi Kerur --- examples/l3fwd/l3fwd_em.c | 376 +- 1 file changed, 303 insertions(+), 73 deletions(-

[dpdk-dev] [v3 1/3] Merge l3fwd-acl and l3fwd code.

2017-03-04 Thread Ravi Kerur
Retain l3fwd-acl definitions. > Move specific setup functions (setup_acl, setup_lpm and setup_hash). Testing: > Compiled successfully for x86_64-native-linuxapp-gcc > Tested LPM, EM and AC

[dpdk-dev] [v3 2/3] LPM config file read option.

2017-03-04 Thread Ravi Kerur
#LPM6 route entries Dest-IP/Mask IF_OUT L:::::::/48 0 L2111:::::::/48 1 L3111:::::::/48 2 ... Signed-off-by: Ravi Kerur --- examples/l3fwd

[dpdk-dev] [v3 0/3] Merge l3fwd-acl and l3fwd

2017-03-04 Thread Ravi Kerur
This patchset merges l3fwd-acl and l3fwd code into common directory. Adds file read options to build LPM and EM tables. Ravi Kerur (3): Merge l3fwd-acl and l3fwd code. LPM config file read option. EM config file read option. examples/l3fwd-acl/Makefile | 56 - examples/l3fwd-acl

[dpdk-dev] [v2 2/3] LPM config file read option

2017-03-04 Thread Ravi Kerur
:::::::/48 0 L2111:::::::/48 1 L3111:::::::/48 2 ... Signed-off-by: Ravi Kerur --- examples/l3fwd/l3fwd.h | 43 +++ examples/l3fwd/l3fwd_acl.c | 39 +-

[dpdk-dev] [v2 1/3] Merge l3fwd-acl and l3fwd

2017-03-04 Thread Ravi Kerur
> Move specific setup functions (setup_acl, setup_lpm and setup_hash). Testing: Compiled successfully for x86_64-native-linuxapp-gcc Tested LPM, EM and ACL basic functionality. Signed-off-by: Ravi Kerur --- examples/l3fwd-acl

[dpdk-dev] [v2 3/3] EM config file read option

2017-03-04 Thread Ravi Kerur
00:::021b:21ff:fe91:3805 102 12 0x06 1 ... Signed-off-by: Ravi Kerur --- examples/l3fwd/l3fwd_em.c | 376 +- 1 file changed, 303 insertions(+), 73 deletions(-) diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c i

[dpdk-dev] [v2 0/3] Merge l3fwd-acl and l3fwd

2017-03-04 Thread Ravi Kerur
This patchset merges l3fwd-acl and l3fwd code into common directory. Add file read options to build LPM and EM tables. Ravi Kerur (3): Merge l3fwd-acl and l3fwd LPM config file read option EM config file read option examples/l3fwd-acl/Makefile | 56 - examples/l3fwd-acl/main.c

Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-03-04 Thread Ravi Kerur
't do it as I thought it may not be worth the change. Let me know your inputs. Thanks. On Wed, Mar 1, 2017 at 7:29 AM, Ravi Kerur wrote: > Hi Konstantin, > > Thank you for the review. > > RSS hash value changes could be due to merge, I didn't make that change. I >

Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-03-01 Thread Ravi Kerur
Hi Konstantin, Thank you for the review. RSS hash value changes could be due to merge, I didn't make that change. I will go through the changes and fix it in 'v2' patch along with RFC removed and checkpatch fix. Thanks. On Tue, Feb 28, 2017 at 2:36 AM, Ananyev, Konstantin < konstantin.anan...@i

[dpdk-dev] [RFC 17.05 v1 1/3] Merge l3fwd-acl and l3fwd

2017-01-27 Thread Ravi Kerur
asic functionality. Signed-off-by: Ravi Kerur --- examples/l3fwd-acl/Makefile | 56 - examples/l3fwd-acl/main.c | 2079 - examples/l3fwd/Makefile |2 +- examples/l3fwd/l3fwd.h| 49 + examples/l3fwd/l3fwd_acl.c|

[dpdk-dev] [RFC 17.05 v1 3/3] EM config file read option

2017-01-27 Thread Ravi Kerur
12 0x06 1 ... Signed-off-by: Ravi Kerur --- examples/l3fwd/l3fwd_em.c | 376 +- 1 file changed, 303 insertions(+), 73 deletions(-) diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c index 6fdabf7..3528947 100644 --- a/examp

[dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd

2017-01-27 Thread Ravi Kerur
Thanks to Konstantin and Bruce on first internal review comments. This patch is RFC for 17.05 to merge l3fwd-acl and l3fwd code and add file read options to build LPM and EM tables. Ravi Kerur (3): Merge l3fwd-acl and l3fwd LPM config file read option EM config file read option examples

[dpdk-dev] [RFC 17.05 v1 2/3] LPM config file read option

2017-01-27 Thread Ravi Kerur
3111:::::::/48 2 ... Signed-off-by: Ravi Kerur --- examples/l3fwd/l3fwd.h | 43 +++ examples/l3fwd/l3fwd_acl.c | 39 +- examples/l3fwd/l3fwd_acl.h | 29 - examples/l3fwd/l3fwd_lpm.c | 307 +

[dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions

2016-06-06 Thread Ravi Kerur
ginal Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kerur > > Sent: Tuesday, March 8, 2016 7:01 AM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions > > > > v1: > > This

[dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions

2016-03-07 Thread Ravi Kerur
v1: This patch adds test cases for rte_memcmp functions. New rte_memcmp functions can be tested via 'make test' and 'testpmd' utility. Compiled and tested on Ubuntu 14.04(non-NUMA) and 15.10(NUMA) systems. Signed-off-by: Ravi Kerur --

[dpdk-dev] [PATCH v1 1/2] rte_memcmp functions using Intel AVX and SSE intrinsics

2016-03-07 Thread Ravi Kerur
v1: This patch adds memcmp functionality using AVX and SSE intrinsics provided by Intel. For other architectures supported by DPDK regular memcmp function is used. Compiled and tested on Ubuntu 14.04(non-NUMA) and 15.10(NUMA) systems. Signed-off-by: Ravi

[dpdk-dev] [PATCH v1 0/2] rte_memcmp functions

2016-03-07 Thread Ravi Kerur
512,45.8233 *** *** 1024, 103.4597 *** *** 2048, 163.5588 *** *** 4096, 232.7368 *** *** 8192, 368.1143 *** *** 16384, 649.0326 *** Test OK RTE>>quit Ravi Kerur (2): rte_memcmp functions using Intel AVX and SSE intrinsics Test cases fo

[dpdk-dev] [PATCH v2] I217 and I218 changes

2016-03-02 Thread Ravi Kerur
Hi, Wenzhuo, Bruce, I have superseded old patch with a new submission. Please let me know if that approach is ok. Thanks, Ravi On Tue, Mar 1, 2016 at 5:21 PM, Lu, Wenzhuo wrote: > Hi Ravi, > > > > >Do you want me to resend it as 'v1' and include your comments in commit > message? let me know. >

[dpdk-dev] [PATCH v1] I217 and I218 changes

2016-03-02 Thread Ravi Kerur
target x86_64-native-linuxapp-clang M. Jay(Intel) had used the patch for DPDK demo. Signed-off-by: Ravi Kerur Acked-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_osdep.h| 26 +++- drivers/net/e1000/em_ethdev.c | 32 ++

[dpdk-dev] [PATCH v1] I217 and I218 changes

2016-03-02 Thread Ravi Kerur
target x86_64-native-linuxapp-clang M. Jay(Intel) had used the patch for DPDK demo. Signed-off-by: Ravi Kerur Acked-by: Wenzhuo Lu --- drivers/net/e1000/base/e1000_osdep.h| 26 +++- drivers/net/e1000/em_ethdev.c | 32 ++

[dpdk-dev] [PATCH v2] I217 and I218 changes

2016-03-01 Thread Ravi Kerur
On Mon, Feb 29, 2016 at 9:18 PM, Lu, Wenzhuo wrote: > Hi, > > > -Original Message- > > From: Ravi Kerur [mailto:rkerur at gmail.com] > > Sent: Tuesday, March 1, 2016 2:31 AM > > To: Lu, Wenzhuo; dev at dpdk.org > > Cc: Ravi Kerur > > Subject: [

[dpdk-dev] [PATCH v2] I217 and I218 changes

2016-02-29 Thread Ravi Kerur
7 and I218 Intel NICs. Compiled and tested (via testpmd) on Ubuntu 14.04 for target x86_64-native-linuxapp-gcc Compiled for target x86_64-native-linuxapp-clang Signed-off-by: Ravi Kerur --- drivers/net/e1000/base/e1000_osdep.h| 26 +++- dr

[dpdk-dev] [dpdk-dev,v2] Clean up rte_memcpy.h file

2016-02-27 Thread Ravi Kerur
results match the results with baseline. > > > > Signed-off-by: Ravi Kerur > > Acked-by: Stephen Hemminger > > > > --- > > .../common/include/arch/x86/rte_memcpy.h | 340 > +++-- > > 1 file changed, 175 insertions(+), 165

[dpdk-dev] [dpdk-dev, v3] Implement memcmp using Intel SIMD instrinsics.

2016-02-23 Thread Ravi Kerur
On Tue, Feb 23, 2016 at 4:22 AM, Wang, Zhihong wrote: > > > It'd be great if you could format this patch into a patch set with > several > > > little ones. :-) > > > Also, the kernel checkpatch is very helpful. > > > Good coding style and patch organization make it easy for in-depth > reviews. >

[dpdk-dev] [dpdk-dev, v3] Implement memcmp using Intel SIMD instrinsics.

2016-02-19 Thread Ravi Kerur
On Wed, Jan 27, 2016 at 7:08 PM, Zhihong Wang wrote: > > diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcmp.h b/lib > > /librte_eal/common/include/arch/x86/rte_memcmp.h > > [...] > > > +#ifdef __cplusplus > > +extern "C" { > > +#endif > > + > > +/** > > + * Compare bytes between two l

[dpdk-dev] [dpdk-dev,v2] Clean up rte_memcpy.h file

2016-02-19 Thread Ravi Kerur
results match the results with baseline. > > > > Signed-off-by: Ravi Kerur > > Acked-by: Stephen Hemminger > > > > --- > > .../common/include/arch/x86/rte_memcpy.h | 340 > +++-- > > 1 file changed, 175 insertions(+), 165

[dpdk-dev] [PATCH v1] Modify and modularize l3fwd code

2015-12-21 Thread Ravi Kerur
4_2 > Compiled for > i686-native-linuxapp-gcc > x86_64-native-linuxapp-gcc > x86_x32-native-linuxapp-gcc > x86_64-native-bsdapp-gcc > Tested on > Ubuntu 14.04 (GCC 4.8.4)

[dpdk-dev] [PATCH v1] Modify and modularize l3fwd code

2015-12-21 Thread Ravi Kerur
wd -c 0x1 -n 1 -- -p 0x1 -E ... (EM) > l3fwd -c 0x1 -n 1 -- -p 0x1 -L ... (LPM) Options "E" and "L" are mutualy-exclusive. If none selected, "L" is default. Ravi Kerur (1): Modify and modularize l3fwd code examples/l3fwd/Makefi

[dpdk-dev] [PATCH v4] Move rte_mbuf macros to common header file

2015-10-01 Thread Ravi Kerur
> x86_64-native-linuxapp-clang > x86_64-native-linuxapp-gcc > i686-native-linuxapp-gcc > x86_64-native-bsdapp-gcc > x86_64-native-bsdapp-clang Tested on: > x86_64 Ubuntu 14.04, testpmd a

[dpdk-dev] [PATCH v4] Move rte_mbuf macros to common header file

2015-10-01 Thread Ravi Kerur
t; x86_64-native-linuxapp-gcc > i686-native-linuxapp-gcc > x86_64-native-bsdapp-gcc > x86_64-native-bsdapp-clang Tested on: > x86_64 Ubuntu 14.04, testpmd and 'make test' > FreeBSD 10.1, tes

[dpdk-dev] [PATCH v2] Move rte_mbuf macros to common header file

2015-09-30 Thread Ravi Kerur
On Wed, Sep 30, 2015 at 12:41 PM, Aaron Conole wrote: > Ravi Kerur writes: > > > Macros RTE_MBUF_DATA_DMA_ADDR and RTE_MBUF_DATA_DMA_ADDR_DEFAULT > > are defined in each PMD driver file. Move those macros into common > > lib/librte_mbuf/rte_mbuf.h file. PMD drivers inc

[dpdk-dev] [PATCH v3] Move rte_mbuf macros to common header file

2015-09-30 Thread Ravi Kerur
ive-bsdapp-gcc > x86_64-native-bsdapp-clang Tested on: > x86_64 Ubuntu 14.04, testpmd and 'make test' > FreeBSD 10.1, testpmd Signed-off-by: Ravi Kerur --- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/bnx2x/bnx2x

[dpdk-dev] [PATCH v2] Move rte_mbuf macros to common header file

2015-09-30 Thread Ravi Kerur
_64-native-bsdapp-gcc > x86_64-native-bsdapp-clang Tested on: > x86_64 Ubuntu 14.04, testpmd and 'make test' > FreeBSD 10.1, testpmd Signed-off-by: Ravi Kerur --- drivers/net/bnx2x/bnx2x.h | 3 --- drivers/net/cxgbe/sge.c| 3 ---

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-09-30 Thread Ravi Kerur
Hi Tetsuya, On Mon, Sep 28, 2015 at 8:32 PM, Tetsuya Mukawa wrote: > On 2015/09/24 6:22, Ravi Kerur wrote: > > Hi David, Tetsuya, > > > > I have sent V3 (changes isolated to rte_ether component) for formal > review. > > Please look into it and let me know your

[dpdk-dev] [PATCH v1] Move rte_mbuf macros to common header file

2015-09-30 Thread Ravi Kerur
Thanks Konstantin. I will send out v2 shortly. On Tue, Sep 29, 2015 at 2:55 AM, Ananyev, Konstantin < konstantin.ananyev at intel.com> wrote: > > Hi Ravi, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kerur >

[dpdk-dev] [PATCH v1] Move rte_mbuf macros to common header file

2015-09-25 Thread Ravi Kerur
On Thu, Sep 24, 2015 at 4:25 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Thu, 24 Sep 2015 15:50:41 -0700 > Ravi Kerur wrote: > > > Macros RTE_MBUF_DATA_DMA_ADDR and RTE_MBUF_DATA_DMA_ADDR_DEFAULT > > are defined in each PMD driver file. Mo

[dpdk-dev] [PATCH v1] Add support for Intel chipsets

2015-09-25 Thread Ravi Kerur
On Fri, Sep 25, 2015 at 1:04 AM, Lu, Wenzhuo wrote: > Hi all, > > > -Original Message- > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Friday, September 25, 2015 3:08 PM > > To: Ravi Kerur > > Cc: dev at dpdk.org; Lu, Wenzhu

[dpdk-dev] [PATCH v1] Move rte_mbuf macros to common header file

2015-09-24 Thread Ravi Kerur
: > x86_64-native-linuxapp-clang > x86_64-native-linuxapp-gcc > i686-native-linuxapp-gcc > x86_64-native-bsdapp-gcc > x86_64-native-bsdapp-clang Tested on: > x86_64 Ubuntu 14.04, testpmd and 'make test' > FreeBSD 10.1, testpmd Signed-off-b

[dpdk-dev] [PATCH v1] Move rte_mbuf macros to common header file

2015-09-24 Thread Ravi Kerur
Macros RTE_MBUF_DATA_DMA_ADDR and RTE_MBUF_DATA_DMA_ADDR_DEFAULT are defined in each PMD driver file. Move those macros into common lib/librte_mbuf/rte_mbuf.h file. All PMD drivers include rte_mbuf.h file directly/indirectly hence no additionl header file inclusion is necessary. Ravi Kerur (1

[dpdk-dev] [PATCH v1] Add support for I217 and I218 Intel 1G chipsets.

2015-09-24 Thread Ravi Kerur
This patch adds I217 and I218 Intel chipsets. Compiled for: > i686-native-linuxapp-gcc > x86_64-native-linuxapp-clang > x86_64-native-linuxapp-gcc > x86_x32-native-linuxapp-gcc Tested on: > x86_64 Ubuntu 14.04 with Intel I218-V and I217-LM chipsets. Signed-off

[dpdk-dev] [PATCH v1] Add support for Intel chipsets

2015-09-24 Thread Ravi Kerur
the mainline. Ravi Kerur (1): Add support for I217 and I218 Intel 1G chipsets. drivers/net/e1000/base/e1000_api.c | 1 + drivers/net/e1000/base/e1000_hw.h | 1 + drivers/net/e1000/base/e1000_ich8lan.c | 30 +++- drivers/net/e1000/base

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-09-23 Thread Ravi Kerur
e logic. Let me know if this not correct I can fix both. Thanks, Ravi On Tue, Sep 15, 2015 at 4:28 AM, Ravi Kerur wrote: > Hi David, > > > On Thu, Sep 3, 2015 at 7:04 AM, David Marchand > wrote: > >> Hello Ravi, Tetsuya, >> >> On Tue, Aug 25, 2015 at 7:59 P

[dpdk-dev] [PATCH v3] Change rte_eal_vdev_init to update port_id

2015-09-23 Thread Ravi Kerur
alidate_abi on Linux for following targets > x86_64-native-linuxapp-gcc > x86_64-native-linuxapp-clang Signed-off-by: Ravi Kerur --- lib/librte_ether/rte_ethdev.c | 116 +++--- 1 file changed, 63 insertions(+), 53 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH v3] Send updated port_id in vdev_init functions

2015-09-23 Thread Ravi Kerur
Instead of executing following functions before and after vdev_init > rte_eth_dev_save and > rte_eth_dev_get_changed_port update following functions to return allocated port_id. > rte_eal_vdev_init > rte_eal_probe_one Ravi Kerur (1): Change rte_eal_vdev_init to update p

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-09-15 Thread Ravi Kerur
Hi David, On Thu, Sep 3, 2015 at 7:04 AM, David Marchand wrote: > Hello Ravi, Tetsuya, > > On Tue, Aug 25, 2015 at 7:59 PM, Ravi Kerur wrote: > >> Let us know how you want us to fix this? To fix rte_eal_vdev_init and >> rte_eal_pci_probe_one to return allocated por

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-08-25 Thread Ravi Kerur
attaching diffs (preliminary) with this email. Please let us know your inputs since it involves EAL component. Thanks, Ravi On Thu, Aug 20, 2015 at 8:33 PM, Tetsuya Mukawa wrote: > On 2015/08/21 4:16, Ravi Kerur wrote: > > > > > /** > > > * Uninitalize

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-08-20 Thread Ravi Kerur
On Wed, Aug 19, 2015 at 7:07 PM, Tetsuya Mukawa wrote: > On 2015/08/20 4:42, Ravi Kerur wrote: > > v2: > >> Remove rte_pmd_mpipe_devinit changes > >> Use rte_eal_compare_pci_addr for address comparison > >> Use dpdk_2.2 in version map file for n

[dpdk-dev] [PATCH v2] Move common functions in eal_thread.c

2015-08-19 Thread Ravi Kerur
u 14.04, testpmd functionality > FreeBSD 10.1, testpmd functionality Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/Makefile| 3 +- lib/librte_eal/bsdapp/eal/eal_thread.c| 153 -- lib/librte_eal/common/eal_common_thread.c | 147 +++

[dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure

2015-08-19 Thread Ravi Kerur
In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate fails return error which is inline with other drivers. Signed-off-by: Ravi Kerur --- drivers/net/mpipe/mpipe_tilegx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mpipe/mpipe_tilegx.c b/drivers/net/mpipe

[dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id

2015-08-19 Thread Ravi Kerur
rgets > x86_64-native-linuxapp-gcc > x86_64-native-linuxapp-clang Signed-off-by: Ravi Kerur --- drivers/net/enic/enic_ethdev.c | 2 +- lib/librte_eal/common/eal_common_dev.c | 13 ++-- lib/librte_eal/common/eal_common_pci.c | 6 +- lib/librte_eal/common/include/rte

  1   2   3   >