RE: [EXT] [PATCH v2 19/20] remove repeated word 'be'

2022-07-26 Thread Rasesh Mody
> From: Stephen Hemminger > Sent: Tuesday, July 26, 2022 9:05 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Rasesh Mody > ; Devendra Singh Rawat > Subject: [EXT] [PATCH v2 19/20] remove repeated word 'be' > > Found by doing duplicate word scan. > > Sig

RE: [EXT] [PATCH v2 09/20] remove repeated word 'only'

2022-07-26 Thread Rasesh Mody
> From: Stephen Hemminger > Sent: Tuesday, July 26, 2022 9:05 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Rasesh Mody > ; Shahed Shaikh > Subject: [EXT] [PATCH v2 09/20] remove repeated word 'only' > > Found by doing duplicate word scan. > > Sig

RE: [EXT] [PATCH v1 1/1] net/qede: fix redundant condition in debug code

2022-01-10 Thread Rasesh Mody
ion of > a literal in code. > > Cc: sta...@dpdk.org > > Fixes: ec55c118792b ("net/qede: add infrastructure for debug data > collection") > Cc: rm...@marvell.com > > Signed-off-by: Anatoly Burakov Acked-by: Rasesh Mody Thanks! > --- > > Notes: &

Re: [dpdk-dev] [EXT] [PATCH v3 1/5] net/qede: fix minsize build

2021-08-09 Thread Rasesh Mody
> From: Devendra Singh Rawat > Sent: Monday, August 9, 2021 10:46 AM > > > > -Original Message- > From: Thomas Monjalon > Sent: Sunday, August 8, 2021 6:22 PM > To: dev@dpdk.org > Cc: bruce.richard...@intel.com; david.march...@redhat.com; Rasesh

Re: [dpdk-dev] [EXT] Re: [PATCH v6 1/8] ether: refine debug build option

2021-05-06 Thread Rasesh Mody
> From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday, May 5, 2021 8:09 PM > > On 5/5/2021 1:21 PM, Michał Krawczyk wrote: > > śr., 5 maj 2021 o 13:45 Ferruh Yigit napisał(a): > >> > >> On 4/1/2021 3:30 PM, Ferruh Yigit wrote: > >>> On 3/31/2021 10:52 AM, Qi Zhang wrote: > PMDs use RTE_LI

Re: [dpdk-dev] [EXT] [PATCH] drivers/net: fix FW version get

2021-04-22 Thread Rasesh Mody
> Fixes: 4d9f5b8adc02 ("net/octeontx2: add FW version get operation") > Fixes: f97b56f9f12e ("net/qede: support FW version query") > Fixes: 83fef46a22b2 ("net/sfc: add callback to retrieve FW version") > Fixes: bc84ac0fadef ("net/txgbe: support get

Re: [dpdk-dev] [EXT] Re: [PATCH] drivers: add missing headers

2021-04-13 Thread Rasesh Mody
m. > > > > "arpa/inet.h" is included for 'htons' and friends. > > "netinet/in.h" is included for 'IPPROTO_IP'. > > > > Signed-off-by: Ferruh Yigit > > Any comment/review? Acked-by: Rasesh Mody

Re: [dpdk-dev] [PATCH v2 0/2] qede: 2020-02 minor fixes

2021-03-21 Thread Rasesh Mody
rivers/net/qede/base/ecore_int.c | 2 +- > drivers/net/qede/qede_ethdev.c| 6 -- > 2 files changed, 5 insertions(+), 3 deletions(-) > > -- > 2.25.1 For the series, Acked-by: Rasesh Mody Thanks, Rasesh

Re: [dpdk-dev] [PATCH 0/7] net/qede: add support for new HW

2021-02-19 Thread Rasesh Mody
> From: Rasesh Mody > Sent: Friday, February 19, 2021 3:44 PM > > Hi, > > This patch series adds support for new HW while modifying existing driver to > continue supporting previous HWs. > Highlights of changes: > - Registers, HW specific and initialization updates

[dpdk-dev] [PATCH 7/7] net/qede/base: clean unnecessary ifdef and comments

2021-02-19 Thread Rasesh Mody
Removed #ifdef LINUX_REMOVE, #ifndef LINUX_REMOVE, TODO comments and TBD comments. Lots of TODOs and TBDs are not relevant. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/base/bcm_osal.c| 1 - drivers/net/qede/base/bcm_osal.h| 3

[dpdk-dev] [PATCH 6/7] net/qede: add support for new HW

2021-02-19 Thread Rasesh Mody
This patch adds PMD support for new hardware (adding new PCI IDs) 50xxx family of Marvell fastlinq adapters. The PMD version is updated to 3.0.0.1. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_debug.c | 3 +-- drivers/net/qede/qede_ethdev.c | 8

[dpdk-dev] [PATCH 5/7] net/qede: changes for DMA page chain allocation and free

2021-02-19 Thread Rasesh Mody
This patch changes the DMA page chain allocation and free mechanism used for fast path resources. It introduces addr_shadow() structure to maintain virtual address and DMA mapping. The ecore_chain_params() is used to maintain all the DMA page chain parameters. Signed-off-by: Rasesh Mody Signed

[dpdk-dev] [PATCH 3/7] net/qede/base: add OS abstracted changes

2021-02-19 Thread Rasesh Mody
The patch includes OS abstracted changes required to support new hardware and the new feature supported by it. It also adds new bit ops to RTE library. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/base/bcm_osal.c| 2 +- drivers/net/qede/base/bcm_osal.h

[dpdk-dev] [PATCH 0/7] net/qede: add support for new HW

2021-02-19 Thread Rasesh Mody
driver. Thus, a lot of fast path and slow path code is expected to be the same. Please note for checkpatch 100 character max_line_length was used. Thanks, Rasesh Rasesh Mody (7): net/qede/base: update and add register definitions net/qede/base: changes for HSI to support new HW net/qede/base

Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed

2021-01-11 Thread Rasesh Mody
> From: Jerin Jacob > Sent: Tuesday, January 12, 2021 10:21 AM > > On Mon, Jan 4, 2021 at 7:47 PM Rasesh Mody wrote: > > > > > From: dev On Behalf Of Igor Russkikh > > > Sent: Monday, January 4, 2021 6:15 PM > > > > > > > Whe

Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed

2021-01-04 Thread Rasesh Mody
> From: dev On Behalf Of Igor Russkikh > Sent: Monday, January 4, 2021 6:15 PM > > > When calling rte_eth_promiscuous_enable(port_id) followed by > > rte_eth_allmulticast_enable(port_id), the port is not in promisc mode > > anymore. This patch ensures that promisc mode takes precedence over > > a

Re: [dpdk-dev] [PATCH] net/qede: change driver's default load parameter

2020-12-03 Thread Rasesh Mody
Hi Devendra, >From: Devendra Singh Rawat >Sent: Thursday, December 03, 2020 5:30 AM > >Loading ecore clients (PMD or linux kernel driver) having different ecore >versions concurrently, is problematic from device's init/config perspective. >This fix changes driver's default load parameter to have

[dpdk-dev] [PATCH] devtools: increase column width to 100

2020-10-16 Thread Rasesh Mody
In line with Linux, increase the default column width from 80 to 100 characters for patch line length check. Linux upstream commit reference bdc48fa11e46f867ea4d75fa59ee87a7f48be144 Signed-off-by: Rasesh Mody --- devtools/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[dpdk-dev] [PATCH] net/bnx2x: fix to add QLogic vendor id

2020-10-12 Thread Rasesh Mody
Add QLogic vendor id support for BCM57840 device ids. Fixes: 9fb557035d90 ("bnx2x: enable PMD build") Cc: sta...@dpdk.org Reported-by: Souvik Dey Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers

Re: [dpdk-dev] [EXT] [PATCH v6 03/14] doc: remove references to make from NICs guides

2020-10-11 Thread Rasesh Mody
>From: Thomas Monjalon >Sent: Sunday, October 11, 2020 2:02 PM > >09/10/2020 14:00, Igor Russkikh: >> > --- a/doc/guides/nics/qede.rst >> > +++ b/doc/guides/nics/qede.rst >> > @@ -106,22 +106,9 @@ Performance note Config File Options >> > ~~~ >> > >> > -The following options can b

Re: [dpdk-dev] [PATCH] net/qede: fix get link details

2020-10-02 Thread Rasesh Mody
Hi Jerin - please use v2, which addresses the build issues. On 10/1/20, 3:41 PM, "Rasesh Mody" wrote: This patch fixes get current link details, without this change the link details can be inaccurate if proper lock is not acquired. Fixes: 739a5b2f2b49 ("net/qede/b

[dpdk-dev] [PATCH v2] net/qede: fix get link details

2020-10-02 Thread Rasesh Mody
This patch fixes get current link details, without this change the link details can be inaccurate if proper lock is not acquired. Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler") Cc: sta...@dpdk.org Reported-by: Ferruh Yigit Signed-off-by: Rasesh Mody Signed-off-by: Igo

[dpdk-dev] [PATCH] net/qede: fix get link details

2020-10-01 Thread Rasesh Mody
This patch fixes get current link details, without this change the link details can be inaccurate if proper lock is not acquired. Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler") Cc: sta...@dpdk.org Reported-by: Ferruh Yigit Signed-off-by: Rasesh Mody Signed-off-by: Igo

[dpdk-dev] [PATCH] net/bnx2x: release port upon close

2020-09-27 Thread Rasesh Mody
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback. Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 17 +++-- 1

[dpdk-dev] [PATCH] net/qede: release port upon close

2020-09-27 Thread Rasesh Mody
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback. Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 25

Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: enhance old ethdev close behavior

2020-09-25 Thread Rasesh Mody
Hi Thomas, >From: Thomas Monjalon >Sent: Friday, September 25, 2020 12:11 AM > >25/09/2020 06:17, Rasesh Mody: >> Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources >> for the port can be freed by rte_eth_dev_close(). With this change the >> priva

Re: [dpdk-dev] [PATCH 16/20] ethdev: remove old close behaviour

2020-09-24 Thread Rasesh Mody
rivers/mempool/dpaa2/ >> @@ -816,27 +816,27 @@ F: drivers/net/dpaa2/ >> F: doc/guides/nics/dpaa2.rst >> F: doc/guides/nics/features/dpaa2.ini >> >> -NXP enetc >> +NXP enetc - UNMAINTAINED >> M: Gagandeep Singh >> M: Sachin Saxena >>

Re: [dpdk-dev] [EXT] [PATCH 1/4] net/qede: fix build with gcc 11

2020-09-24 Thread Rasesh Mody
Hi Ferruh, >From: Ferruh Yigit >Sent: Monday, September 21, 2020 6:38 AM > >Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920 >(experimental) > >build error: >../drivers/net/qede/qede_main.c: In function ‘qed_get_current_link’: >../drivers/net/qede/qede_main.c:587:17: >

Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port

2020-09-24 Thread Rasesh Mody
Hi Thomas, >From: dev On Behalf Of Thomas Monjalon >Sent: Sunday, September 13, 2020 3:16 PM > >The patches for removing RTE_ETH_DEV_CLOSE_REMOVE are sent: > https://urldefense.proofpoint.com/v2/url?u=https- >3A__patches.dpdk.org_project_dpdk_list_-3Fseries- >3D12173&d=DwICAg&c=nKjWec2b6R0m

[dpdk-dev] [PATCH] net/qede: enhance old ethdev close behavior

2020-09-24 Thread Rasesh Mody
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback. Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 13 + 1 file

[dpdk-dev] [PATCH] net/bnx2x: enhance old ethdev close behavior

2020-09-24 Thread Rasesh Mody
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback. Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 20

Re: [dpdk-dev] [EXT] [PATCH] net/qede: remove dead code

2020-07-21 Thread Rasesh Mody
@dpdk.org > >Signed-off-by: Yunjian Wang >--- Acked-by: Rasesh Mody Thanks!

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/4] net/qede: add infrastructure for debug data collection

2020-07-09 Thread Rasesh Mody
>From: Ferruh Yigit >Sent: Thursday, July 09, 2020 9:37 AM > >On 7/8/2020 11:50 PM, Rasesh Mody wrote: >> The patch adds QEDE PMD ops and APIs to calculate the size and collect >> the debug dump for various firmware components. The patch adds new >> files qede_debug.

Re: [dpdk-dev] [EXT] Re: [PATCH v5 4/4] net/qede: add support for get register operation

2020-07-09 Thread Rasesh Mody
>From: Ferruh Yigit >Sent: Thursday, July 09, 2020 9:33 AM > >On 7/8/2020 11:50 PM, Rasesh Mody wrote: >> Add support for .get_reg eth_dev ops which will be used to collect the >> firmware debug data. >> >> PMD on detecting on some HW errors will collect the F

[dpdk-dev] [PATCH v5 4/4] net/qede: add support for get register operation

2020-07-08 Thread Rasesh Mody
rte_dev_reg_info and passes it to the application. It’s the responsibility of the application to save the FW/HW Dump to a file. We recommendation using the file name format used by qede_save_fw_dump(). Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- doc/guides/nics/features/qede.ini | 1

[dpdk-dev] [PATCH v5 0/4] net/qede: add FW debug data collection support

2020-07-08 Thread Rasesh Mody
features. Thanks! -Rasesh Rasesh Mody (4): net/qede/base: re-arrange few structures for DDC net/qede/base: add changes for debug data collection net/qede: add infrastructure for debug data collection net/qede: add support for get register operation doc/guides/nics/features/qede.ini

[dpdk-dev] [PATCH v5 2/4] net/qede/base: add changes for debug data collection

2020-07-08 Thread Rasesh Mody
This patch adds base driver APIs required for debug data collection. It adds support for dumping internal lookup tables(ilt), reading nvram image, register definitions. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/base/bcm_osal.c | 6 + drivers

[dpdk-dev] [PATCH v5 1/4] net/qede/base: re-arrange few structures for DDC

2020-07-08 Thread Rasesh Mody
This patch rearranges some of the base driver structures which will be also used by debug data collection (DDC) implementation. It adds a new file ecore_hsi_func_common.h with Physical, Virtual memory descriptors. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/4] net/qede/base: re-arrange few structures for DDC

2020-07-07 Thread Rasesh Mody
>From: Jerin Jacob >Sent: Tuesday, June 30, 2020 10:47 AM > >On Tue, Jun 30, 2020 at 2:03 PM Rasesh Mody wrote: >> >> This patch rearranges some of the base driver structures which will be >> also used by debug data collection (DDC) implementation. It adds a new &

[dpdk-dev] [PATCH v4 4/4] net/qede: add support for get register operation

2020-07-07 Thread Rasesh Mody
rte_dev_reg_info and passes it to the application. It’s the responsibility of the application to save the FW/HW Dump to a file. We recommendation using the file name format used by qede_save_fw_dump(). Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- doc/guides/nics/features/qede.ini | 1

[dpdk-dev] [PATCH v4 2/4] net/qede/base: add changes for debug data collection

2020-07-07 Thread Rasesh Mody
This patch adds base driver APIs required for debug data collection. It adds support for dumping internal lookup tables(ilt), reading nvram image, register definitions. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/base/bcm_osal.c | 6 + drivers

[dpdk-dev] [PATCH v4 1/4] net/qede/base: re-arrange few structures for DDC

2020-07-07 Thread Rasesh Mody
This patch rearranges some of the base driver structures which will be also used by debug data collection (DDC) implementation. It adds a new file ecore_hsi_func_common.h with Physical, Virtual memory descriptors. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede

[dpdk-dev] [PATCH v4 0/4] net/qede: add FW debug data collection support

2020-07-07 Thread Rasesh Mody
Rasesh Mody (4): net/qede/base: re-arrange few structures for DDC net/qede/base: add changes for debug data collection net/qede: add infrastructure for debug data collection net/qede: add support for get register operation doc/guides/nics/features/qede.ini |1 + drivers

[dpdk-dev] [PATCH v3 4/4] net/qede: add support for get register operation

2020-07-07 Thread Rasesh Mody
rte_dev_reg_info and passes it to the application. It’s the responsibility of the application to save the FW/HW Dump to a file. We recommendation using the file name format used by qede_save_fw_dump(). Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- doc/guides/nics/features/qede.ini | 1

[dpdk-dev] [PATCH v3 2/4] net/qede/base: add changes for debug data collection

2020-07-07 Thread Rasesh Mody
This patch adds base driver APIs required for debug data collection. It adds support for dumping internal lookup tables(ilt), reading nvram image, register definitions. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/base/bcm_osal.c | 6 + drivers

[dpdk-dev] [PATCH v3 1/4] net/qede/base: re-arrange few structures for DDC

2020-07-07 Thread Rasesh Mody
This patch rearranges some of the base driver structures which will be also used by debug data collection (DDC) implementation. It adds a new file ecore_hsi_func_common.h with Physical, Virtual memory descriptors. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede

[dpdk-dev] [PATCH v3 0/4] net/qede: add FW debug data collection support

2020-07-07 Thread Rasesh Mody
saved to a file and sent to Marvell for analysis. Please apply to dpdk-next-net-mrvl and dpdk-next-net trees. v3: Fixed gcc-10 compilation issue. v2: Addressed checkpatch issues and updated supported features. Thanks! -Rasesh Rasesh Mody (4): net/qede/base: re-arrange few structures for DDC

[dpdk-dev] [PATCH v2 2/4] net/qede/base: add changes for debug data collection

2020-06-30 Thread Rasesh Mody
This patch adds base driver APIs required for debug data collection. It adds support for dumping internal lookup tables(ilt), reading nvram image, register definitions. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/base/bcm_osal.c | 6 + drivers

[dpdk-dev] [PATCH v2 1/4] net/qede/base: re-arrange few structures for DDC

2020-06-30 Thread Rasesh Mody
This patch rearranges some of the base driver structures which will be also used by debug data collection (DDC) implementation. It adds a new file ecore_hsi_func_common.h with Physical, Virtual memory descriptors. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede

[dpdk-dev] [PATCH v2 4/4] net/qede: add support for get register operation

2020-06-30 Thread Rasesh Mody
rte_dev_reg_info and passes it to the application. It’s the responsibility of the application to save the FW/HW Dump to a file. We recommendation using the file name format used by qede_save_fw_dump(). Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- doc/guides/nics/features/qede.ini | 1

[dpdk-dev] [PATCH v2 0/4] net/qede: add FW debug data collection support

2020-06-30 Thread Rasesh Mody
saved to a file and sent to Marvell for analysis. Please apply to dpdk-next-net-mrvl and dpdk-next-net trees. v2: Addressed checkpatch issues and updated supported features. Thanks! -Rasesh Rasesh Mody (4): net/qede/base: re-arrange few structures for DDC net/qede/base: add changes for

Re: [dpdk-dev] bnx2x pmd crash when launching testpmd using BCM57840 Nic.

2020-06-30 Thread Rasesh Mody
Hi Anil, It seems like this adapter has 8 PFs. Can you confirm that rest of PFs are not attached to any of the kernel drivers? You can view that by checking binding status. When using bnx2x PMD, it needs all the remaining PFs detached from kernel drivers. Please refer to " Co-existence considerat

Re: [dpdk-dev] [EXT] Re: [PATCH 3/4] net/qede: add infrastructure for debug data collection

2020-06-30 Thread Rasesh Mody
>From: Jerin Jacob >Sent: Sunday, June 28, 2020 5:30 AM > >-- >On Sun, Jun 28, 2020 at 11:29 AM Rasesh Mody wrote: >> >> The patch adds QEDE PMD ops and APIs to calculate the size and collect &g

Re: [dpdk-dev] [EXT] Re: [PATCH 4/4] net/qede: add support for get register operation

2020-06-30 Thread Rasesh Mody
Hi Jerin, >From: Jerin Jacob >Sent: Sunday, June 28, 2020 5:23 AM > >-- >On Sun, Jun 28, 2020 at 11:29 AM Rasesh Mody wrote: >> >> Add support for .get_reg eth_dev ops which will be used to collect

[dpdk-dev] [PATCH 4/4] net/qede: add support for get register operation

2020-06-27 Thread Rasesh Mody
rte_dev_reg_info and passes it to the application. It’s the responsibility of the application to save the FW/HW Dump to a file. We recommendation using the file name format used by qede_save_fw_dump(). Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/Makefile| 1

[dpdk-dev] [PATCH 1/4] net/qede/base: re-arrange few structures for DDC

2020-06-27 Thread Rasesh Mody
This patch rearranges some of the base driver structures which will be also used by debug data collection (DDC) implementation. It adds a new file ecore_hsi_func_common.h with Physical, Virtual memory descriptors. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede

[dpdk-dev] [PATCH 2/4] net/qede/base: add changes for debug data collection

2020-06-27 Thread Rasesh Mody
This patch adds base driver APIs required for debug data collection. It adds support for dumping internal lookup tables(ilt), reading nvram image, register definitions. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/base/bcm_osal.c | 6 + drivers

[dpdk-dev] [PATCH 0/4] net/qede: add FW debug data collection support

2020-06-27 Thread Rasesh Mody
saved to a file and sent to Marvell for analysis. Please apply to dpdk-next-net-mrvl and dpdk-next-net trees. Thanks! -Rasesh Rasesh Mody (4): net/qede/base: re-arrange few structures for DDC net/qede/base: add changes for debug data collection net/qede: add infrastructure for debug data

Re: [dpdk-dev] [EXT] [PATCH] examples/kni: fix crash during MTU set

2020-05-21 Thread Rasesh Mody
etup Tx queue") >Cc: sta...@dpdk.org > >Signed-off-by: Ferruh Yigit >--- Acked-by: Rasesh Mody

[dpdk-dev] [PATCH v3 2/2] net/qede: fix port reconfiguration

2020-05-14 Thread Rasesh Mody
other scenarios like KNI MTU change we'd keep existing configuration. Fixes: 8de0c4201926 ("net/qede: fix odd number of queues usage in 100G mode") Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody Sig

[dpdk-dev] [PATCH v3 1/2] net/qede: fix assignment of Rx/Tx handlers

2020-05-14 Thread Rasesh Mody
mode") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_ethdev.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] net/qede: restore Tx queue setup

2020-05-14 Thread Rasesh Mody
>From: Ferruh Yigit >Sent: Thursday, May 14, 2020 7:33 AM > >On 5/6/2020 3:43 AM, Rasesh Mody wrote: >> Hi, >> >>> From: Thomas Monjalon >>> Sent: Tuesday, May 05, 2020 2:15 AM >>> >>> 05/05/2020 10:59, Ferruh Yigit: >>>> O

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] net/qede: restore Tx queue setup

2020-05-13 Thread Rasesh Mody
Hi Jerin, >From: Jerin Jacob >Sent: Sunday, May 10, 2020 12:04 AM > >On Wed, May 6, 2020 at 8:13 AM Rasesh Mody wrote: >> >> Hi, >> >> >From: Thomas Monjalon >> >Sent: Tuesday, May 05, 2020 2:15 AM >> > >> >05/05/2020

Re: [dpdk-dev] [EXT] Re: [PATCH] net/qede: fix link state configuration

2020-05-13 Thread Rasesh Mody
Hi Jerin, >From: Jerin Jacob >Sent: Wednesday, May 13, 2020 9:25 AM > >On Tue, May 12, 2020 at 6:16 AM Rasesh Mody wrote: >> >> Move link state enable/disable to dev_start() and dev_stop() >> respectively. This will ensure when devices are stopped, link status >

[dpdk-dev] [PATCH v2 2/2] examples/kni: fix MTU change to setup Tx queue

2020-05-13 Thread Rasesh Mody
This patch adds a fix to setup Tx queue when changing KNI interface MTU. It ensures device can safely start txq post MTU change operation. Fixes: fc9ee41b7016 ("examples/kni: convert to new ethdev offloads API") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- examples/kni/m

[dpdk-dev] [PATCH v2 1/2] net/qede: fix assignment of Rx/Tx handlers

2020-05-13 Thread Rasesh Mody
mode") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_ethdev.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index

[dpdk-dev] [PATCH v2] net/qede: fix link state configuration

2020-05-13 Thread Rasesh Mody
ned-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_ethdev.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index e71fa1e6a..0b1fca9ac 100644 --- a/drivers/net/qede/qed

[dpdk-dev] [PATCH] net/qede: fix link state configuration

2020-05-11 Thread Rasesh Mody
ned-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_ethdev.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index bcd8252d9..9a5847076 100644 --- a/drivers/net/qede/qed

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] net/qede: restore Tx queue setup

2020-05-05 Thread Rasesh Mody
Hi, >From: Thomas Monjalon >Sent: Tuesday, May 05, 2020 2:15 AM > >05/05/2020 10:59, Ferruh Yigit: >> On 5/5/2020 7:44 AM, Jerin Jacob wrote: >> > On Tue, May 5, 2020 at 8:39 AM Rasesh Mody >wrote: >> >> >> >> Some applications do not e

Re: [dpdk-dev] [EXT] Re: [PATCH 1/2] net/qede: fix assignment of Rx/Tx handlers

2020-05-05 Thread Rasesh Mody
Hi Ferruh, >From: Ferruh Yigit >Sent: Tuesday, May 05, 2020 2:01 AM > >On 5/5/2020 4:09 AM, Rasesh Mody wrote: >> Fix to assign dummy Rx/Tx handlers in dev_stop. >> For MTU set, assignment of the appropriate Rx/Tx handlers will be >> handled by dev_start/dev_stop. &

[dpdk-dev] [PATCH 1/2] net/qede: fix assignment of Rx/Tx handlers

2020-05-04 Thread Rasesh Mody
mode") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_ethdev.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index

[dpdk-dev] [PATCH 2/2] net/qede: restore Tx queue setup

2020-05-04 Thread Rasesh Mody
Some applications do not explicitly restore Tx queues setup during port re-configuration. This patch adds changes to check for released Tx queues and restore the setup if application doesn't explicitly does that. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net

[dpdk-dev] [PATCH] net/bnx2x: add Rx desc MTU segment limitation

2020-05-04 Thread Rasesh Mody
logs the message. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- doc/guides/nics/bnx2x.rst| 17 + drivers/net/bnx2x/bnx2x_ethdev.c | 1 + drivers/net/bnx2x/bnx2x_rxtx.c | 20 ++-- 3 files changed, 36 insertions(+), 2 deletions(-) diff --

[dpdk-dev] [PATCH 1/2] net/qede: add flush support to rte flow ops

2020-04-24 Thread Rasesh Mody
This patch adds suppot to flush the RTE FLOWs. Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_filter.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c index b7ad59ad6

[dpdk-dev] [PATCH 2/2] net/qede: add support for get FW version

2020-04-24 Thread Rasesh Mody
Add support for get firmware version operation. Get and dump multi boot image (MBI) version as part of get firmware version string along with Management fimrware (MFW) version. Use qede_fw_version_get() for PMD info logs. Signed-off-by: Yash Sharma Signed-off-by: Rasesh Mody Signed-off-by

[dpdk-dev] [PATCH v2] net/bnx2x: add multicast MAC address filtering

2020-04-13 Thread Rasesh Mody
Wrong tag issue with check-git-log.sh Signed-off-by: Souvik Dey Acked-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.h| 4 +++ drivers/net/bnx2x/bnx2x_ethdev.c | 35 ++- drivers/net/bnx2x/bnx2x_vfpf.c | 58 drivers/net/bnx2x/bnx2x_vfpf.h

[dpdk-dev] [PATCH v3] net/bnx2x: handle guest VLAN for SR-IOV case

2020-04-13 Thread Rasesh Mody
the headline. v2: * Fix compilation issues. * Changed the Subject Line as recommended. Signed-off-by: Souvik Dey Acked-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/

Re: [dpdk-dev] [EXT] [PATCH] net/bnx2x: add multicast MAC address filtering

2020-03-03 Thread Rasesh Mody
: Friday, February 28, 2020 12:05 PM To: Rasesh Mody ; Shahed Shaikh ; Jerin Jacob Kollanukkaran ; ferruh.yi...@intel.com; tho...@monjalon.net Cc: dev@dpdk.org; sta...@dpdk.org; Dey, Souvik Subject: [EXT] [PATCH] net/bnx2x: add multicast MAC address filtering External Email

Re: [dpdk-dev] [PATCH v2] net/bnx2x: handle guest vlan for SR-IOV case

2020-03-03 Thread Rasesh Mody
to just the ethertype in case of VF. > > >Signed-off-by: "Dey, Souvik" >--- May be it would be good to use --in-reply-to when generating the patch and resubmit. This will ensure it lands up in the same thread as the first patch. http://mails.dpdk.org/archives/test-report/20

Re: [dpdk-dev] [EXT] [PATCH] bnx2x: handle guest vlan for SR-IOV case

2020-02-26 Thread Rasesh Mody
Hi Dey, The changes look good, however rte/RTE prefix need to be used. The patch doesn’t compile with latest dpdk. s/ether_type/rte_ether_type/ s/ETHER_TYPE_VLAN/RTE_ETHER_TYPE_VLAN/ s/vlan_hdr/rte_vlan_hdr/ For the subject line, s/bnx2x/net\/bnx2x/ is preferred. Also, the inclusion footer in t

Re: [dpdk-dev] [PATCH 1/2] net/qede: Fix VF re-load failure after ungraceful termination of DPDK

2020-02-06 Thread Rasesh Mody
it by allowing VF to request the PF for soft FLR during the >load >in such cases so that it can get cleanly re-loaded. > >Fixes: 2ea6f76aff40 ("qede: add core driver") Cc: sta...@dpdk.org > >Signed-off-by: Manish Chopra >Signed-off-by: Shahed Shaikh >Signed-off-by: Rasesh Mody >--- Acked-by: Rasesh Mody

[dpdk-dev] [PATCH] net/bnx2x: fix to set stripped flag for VLAN packet

2020-01-28 Thread Rasesh Mody
stripped VLAN") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c index ae97dfee36..ea2b53dff8 100644 --- a/drivers/net/bnx2x/bnx

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] net/bnx2x: fix to use required mem barriers in Rx path

2020-01-26 Thread Rasesh Mody
HI Jerin, >From: Rasesh Mody >Sent: Tuesday, January 14, 2020 5:57 PM > >Hi Jerin, > >>From: Jerin Jacob >>Sent: Tuesday, January 14, 2020 5:49 AM >>To: Rasesh Mody ; Gavin Hu >>Cc: dpdk-dev ; Jerin Jacob Kollanukkaran >>; Ferruh Yigit ; >>GR

[dpdk-dev] [PATCH v2 2/2] net/bnx2x: fix to sync fastpath Rx queue access

2020-01-26 Thread Rasesh Mody
and trying to updating Rx Producer. Add a fastpath Rx lock between these two paths to close this race. Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 12 drivers/net/bnx2x/bnx2x.h | 3 ++

[dpdk-dev] [PATCH v2 1/2] net/bnx2x: fix reset of scan FP flag

2020-01-26 Thread Rasesh Mody
The fastpath task queue handler resets the fastpath scan flag unconditionally, this patch changes that to reset the flag only if it was set. Fixes: 08a6e472c3d7 ("net/bnx2x: fix packet drop") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 4 ++-- 1 fi

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] net/bnx2x: fix to use required mem barriers in Rx path

2020-01-14 Thread Rasesh Mody
Hi Jerin, >From: Jerin Jacob >Sent: Tuesday, January 14, 2020 5:49 AM >To: Rasesh Mody ; Gavin Hu >Cc: dpdk-dev ; Jerin Jacob Kollanukkaran >; Ferruh Yigit ; GR-Everest- >DPDK-Dev ; dpdk stable > >Subject: [EXT] Re: [dpdk-dev] [PATCH 1/3] net/bnx2x: fix to use required

Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: add support for secondary process

2020-01-14 Thread Rasesh Mody
Hi Kevin, >From: Kevin Traynor >Sent: Tuesday, January 14, 2020 10:52 AM > >On 14/01/2020 04:51, Jerin Jacob wrote: >> On Sat, Dec 21, 2019 at 7:12 AM Rasesh Mody >wrote: >>> >>> Skip the device re-initialization for secondary process. >>>

[dpdk-dev] [PATCH 2/3] net/bnx2x: fix reset of scan FP flag

2020-01-13 Thread Rasesh Mody
The fastpath task queue handler resets the fastpath scan flag unconditionally, this patch changes that to reset the flag only if it was set. Fixes: 08a6e472c3d7 ("net/bnx2x: fix packet drop") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 4 ++-- 1 fi

[dpdk-dev] [PATCH 1/3] net/bnx2x: fix to use required mem barriers in Rx path

2020-01-13 Thread Rasesh Mody
or update indices. Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 5 + drivers/net/bnx2x/bnx2x_rxtx.c | 22 ++ 2 files changed, 27 insertions(+) diff --git a/drivers/net/bnx2x

[dpdk-dev] [PATCH 3/3] net/bnx2x: fix to sync fastpath Rx queue access

2020-01-13 Thread Rasesh Mody
and trying to updating Rx Producer. Add a fastpath Rx lock between these two paths to close this race. Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 12 drivers/net/bnx2x/bnx2x.h | 3 ++

[dpdk-dev] [PATCH] net/bnx2x: add support for secondary process

2019-12-20 Thread Rasesh Mody
Skip the device re-initialization for secondary process. Cc: sta...@dpdk.com Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c index 20b045ff87..7864b5b80a

[dpdk-dev] [PATCH] net/qede/base: fix number of ports per engine

2019-12-20 Thread Rasesh Mody
Fix the way in which the number of ports per engine of an adapter is determined by reading port mode register. Set default value to 1. Fixes: 3b307c55f2ac ("net/qede/base: update FW to 8.40.25.0") Cc: sta...@dpdk.com Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_

[dpdk-dev] [PATCH v2] doc: update qede PMD guide

2019-11-22 Thread Rasesh Mody
- Add note for sharing an adapter between DPDK and Linux drivers. - Update the firmware version in example. - Add Config note for potential error due to lack of memzone desciptor count. Signed-off-by: Rasesh Mody --- doc/guides/nics/qede.rst | 27 ++- 1 file

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: update qede PMD guide

2019-11-22 Thread Rasesh Mody
Hi Ferruh, >From: Ferruh Yigit >Sent: Friday, November 22, 2019 6:33 AM > >External Email > >-- >On 11/22/2019 7:51 AM, Rasesh Mody wrote: >> - Add note for Co-existence of DPDK and Linux drivers

[dpdk-dev] [PATCH] doc: update qede PMD guide

2019-11-21 Thread Rasesh Mody
- Add note for Co-existence of DPDK and Linux drivers. - Update the firmware version in example. - Add Config note for potential error due to lack of memzone desciptor count. Signed-off-by: Rasesh Mody --- doc/guides/nics/qede.rst | 25 - 1 file changed, 20

[dpdk-dev] [PATCH v2] net/bnx2x: fix meson build failure

2019-11-05 Thread Rasesh Mody
of ‘uint64_t’ was here typedef __uint64_t uint64_t; ^~~~ Fixes: 38dff79ba736 ("net/bnx2x: update HSI") v2: Use RTE_EXEC_ENV_FREEBSD in place of __FreeBSD__ Signed-off-by: Rasesh Mody Tested-by: Dharmik Thakkar Tested-by: Gavin Hu --- drivers/net/bnx

Re: [dpdk-dev] [PATCH] net/bnx2x: fix meson build failure

2019-11-05 Thread Rasesh Mody
>From: Thomas Monjalon >Sent: Tuesday, November 05, 2019 10:15 AM > >01/11/2019 07:02, Rasesh Mody: >> Use kernel headers for __le* types to avoid potential conflicts >> resulting in redefinition errors during Linux builds. Add check for >> BSD builds. > >I don

[dpdk-dev] [PATCH] net/bnx2x: fix meson build failure

2019-10-31 Thread Rasesh Mody
Use kernel headers for __le* types to avoid potential conflicts resulting in redefinition errors during Linux builds. Add check for BSD builds. Fixes: 38dff79ba736 ("net/bnx2x: update HSI") Signed-off-by: Rasesh Mody Tested-by: Dharmik Thakkar Tested-by: Gavin Hu --- drivers

Re: [dpdk-dev] [PATCH 1/3] net/qede/base: fix for FW bug

2019-10-30 Thread Rasesh Mody
Hi Kevin, >From: Rasesh Mody >Sent: Monday, October 21, 2019 11:53 AM > >Hi Kevin, > >>From: Kevin Traynor >>Sent: Monday, October 21, 2019 3:58 AM >> >>On 20/10/2019 06:20, Rasesh Mody wrote: >>> In our testing we have identified a critical FW bu

Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: fix the meson compile issue

2019-10-30 Thread Rasesh Mody
>From: Ferruh Yigit >Sent: Wednesday, October 30, 2019 4:23 AM > >On 10/29/2019 11:09 AM, Gavin Hu wrote: >> The definition is conflicting with that of the compiler, as show the >> following error: ../drivers/net/bnx2x/bnx2x_osal.h:27:17: error: >> conflicting types for ‘uint64_t’ #define __le64

  1   2   3   4   5   6   7   8   9   10   >