RE: [PATCH 2/5] crypto/openssl: fix output of RSA verify op

2022-01-13 Thread Ramkumar Balu
Thank you for the comments. I agree that OpenSSL PMD needs a major refactoring in asym crypto. I have asked Akhil to reject this patch series. -Original Message- From: Kusztal, ArkadiuszX Sent: Tuesday, December 28, 2021 2:41 PM To: Ramkumar Balu ; Akhil Goyal ; Anoob Joseph

RE: [RFC] cryptodev: asymmetric crypto random number source

2021-12-13 Thread Ramkumar Balu
r from user (which could > > be useful for other things like RSA padding as well) I think the previous solution itself is more straightforward and simpler unless we want to have functionality to configure random number generator for each device. Thanks, Ramkumar Balu

[PATCH 5/5] crypto/cnxk: fix output field for RSA verify

2021-11-29 Thread Ramkumar Balu
From: Ramkumar During RSA sign verification, this PMD returns the decrypted plaintext in 'sign' field of rte_crypto_rsa_op_param. The 'sign' field is actually used to pass input to the operation. This PMD overwrites the 'sign' field buffer. This is non-compliance to lib cryptodev. This patch fix

[PATCH 4/5] crypto/octeontx2: fix output field for RSA verify

2021-11-29 Thread Ramkumar Balu
From: Ramkumar During RSA sign verification, the OCTEONTX2 PMD returns the decrypted plaintext in 'sign' field of rte_crypto_rsa_op_param. The 'sign' field is actually used to pass input to the operation. This PMD overwrites the 'sign' field buffer. This is non-compliance to lib cryptodev. This

[PATCH 3/5] crypto/octeontx: fix output field for RSA verify

2021-11-29 Thread Ramkumar Balu
From: Ramkumar During RSA sign verification, the OCTEONTX PMD returns the decrypted plaintext in 'sign' field of rte_crypto_rsa_op_param. The 'sign' field is actually used to pass input to the operation. This PMD overwrites the 'sign' field buffer. This is non-compliance to lib cryptodev. This p

[PATCH 2/5] crypto/openssl: fix output of RSA verify op

2021-11-29 Thread Ramkumar Balu
From: Ramkumar During RSA verify, the OpenSSL PMD fails to return the plaintext after public key decryption. This patch fixes the OpenSSL PMD to return the decrypted plaintext in cipher.data / cipher.length fields Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations") Fixes: fe1

[PATCH 1/5] cryptodev: fix RSA op cipher field description

2021-11-29 Thread Ramkumar Balu
From: Ramkumar The description for 'struct rte_crypto_rsa_op_param' failed to specify a field for returning the plaintext from RSA public key decryption. This patch fixes the rte_crypto_rsa_op_param description to specify 'cipher' field to be used for returning plaintext during RSA op_type == RT

[PATCH 0/5] cryptodev: fix inconsistency in RSA op usage

2021-11-29 Thread Ramkumar Balu
From: Ramkumar The RSA verify operation is performed in two stages: 1. decrypt using public key (output: plaintext message) 2. Compare resultant plaintext message with the expected plaintext message to verify. (return succ/fail in status field) Some applications need the decrypted plaintext (stag