RE: [PATCH] net/virtio: remove address width limit for modern devices

2023-03-09 Thread Pei, Andy
Hi David, The case is just want to enable ASAN to scan customer developed code. > -Original Message- > From: David Marchand > Sent: Thursday, March 9, 2023 11:08 PM > To: Maxime Coquelin > Cc: dev@dpdk.org; Pei, Andy ; Xia, Chenbo > > Subject: Re: [PATCH] net/v

RE: [PATCH] net/virtio: remove address width limit for modern devices

2023-03-09 Thread Pei, Andy
HI > -Original Message- > From: David Marchand > Sent: Thursday, March 9, 2023 10:36 PM > To: dev@dpdk.org > Cc: Pei, Andy ; Maxime Coquelin > ; Xia, Chenbo > Subject: [PATCH] net/virtio: remove address width limit for modern devices > > Modern devices don

RE: [PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices

2022-12-15 Thread Pei, Andy
Hi Code looks good to me. > -Original Message- > From: Abhishek Maheshwari > Sent: Thursday, December 15, 2022 11:48 AM > To: Wang, Xiao W > Cc: dev@dpdk.org; sta...@dpdk.org; Xia, Chenbo ; > Mandal, Purna Chandra ; Maheshwari, > Abhishek > Subject: [PATCH v4] vdpa/ifc: Match default s

RE: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices

2022-12-08 Thread Pei, Andy
v@dpdk.org; sta...@dpdk.org; Xia, Chenbo ; > Mandal, Purna Chandra ; Pei, Andy > > Subject: RE: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio > devices > > Hi Abhishek, > > Please see comments inline. > > BRs, > Xiao > > > -Original Messa

RE: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-08 Thread Pei, Andy
> -Original Message- > From: Taekyung Kim > Sent: Tuesday, November 8, 2022 4:56 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Pei, Andy ; > kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; > sta...@dpdk.org; Wang, Xiao W > Subject: [PATCH v4] vdpa/ifc: f

RE: [PATCH v3] vdpa/ifc: fix update_datapath error handling

2022-11-07 Thread Pei, Andy
Hi See my reply inline. > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, November 8, 2022 9:47 AM > To: Taekyung Kim ; dev@dpdk.org > Cc: sta...@dpdk.org; maxime.coque...@redhat.com; Wang, Xiao W > > Subject: RE: [PATCH v3] vdpa/ifc: fix update_datapath error handling > > > -

RE: [PATCH v3] vdpa/ifc/base: wait for queue disable before saving q-state

2022-11-02 Thread Pei, Andy
> -Original Message- > From: Maheshwari, Abhishek > Sent: Wednesday, November 2, 2022 5:55 PM > To: maxime.coque...@redhat.com; Wang, Xiao W > Cc: dev@dpdk.org; sta...@dpdk.org; Xia, Chenbo ; > Mandal, Purna Chandra ; Pei, Andy > ; Maheshwari, Abhishek > &g

RE: [PATCH v9 00/12] vdpa/ifc: add multi queue support

2022-10-26 Thread Pei, Andy
> -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 26, 2022 5:00 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v9 00/12] vdpa/ifc: add multi queue support > &

RE: [PATCH v9 09/12] vdpa/ifc: improve internal list logic

2022-10-19 Thread Pei, Andy
Hi Chenbo, Thanks. > -Original Message- > From: Xia, Chenbo > Sent: Thursday, October 20, 2022 11:22 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v9 09/12] vdpa/ifc: improv

RE: [PATCH v8 07/12] vdpa/ifc: change internal function name

2022-10-19 Thread Pei, Andy
HI Chenbo, Thanks for your review. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 2:59 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v8 07/12] vdpa

RE: [PATCH v8 08/12] vdpa/ifc: add internal API to get device

2022-10-19 Thread Pei, Andy
Hi Chenbo, Thanks for your review. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 3:04 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v8 08/12] vdpa/ifc

RE: [PATCH v8 09/12] vdpa/ifc: change some driver logic

2022-10-19 Thread Pei, Andy
Hi Chenbo, Thanks for your review, I will send v9 to do this. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 5:13 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE:

RE: [PATCH v7 10/12] vhost: add vdpa device type to rte vdpa device

2022-10-19 Thread Pei, Andy
Hi Chebo, Thanks for your review. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 5:14 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v7 10/12] vhost: ad

RE: [PATCH v8 12/12] vhost: improve vDPA blk device configure condition

2022-10-19 Thread Pei, Andy
Hi Chenbo, Thanks for your review. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 5:15 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v8 12/12] vhost: im

RE: [PATCH v8 11/12] vhost: vDPA blk device gets ready when the first queue is ready

2022-10-19 Thread Pei, Andy
Hi Chenbo, Thanks for your review. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 5:15 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v8 11/12] vhost:

RE: [PATCH v8 12/12] vhost: improve vDPA blk device configure condition

2022-10-18 Thread Pei, Andy
Hi Maxime, Thanks for your review. > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 18, 2022 10:15 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang > Subject: Re: [PATCH v8 12/12] vhost: improve vDPA

RE: [PATCH v8 11/12] vhost: vDPA blk device gets ready when the first queue is ready

2022-10-18 Thread Pei, Andy
HI Maxime, Thanks for your review. > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 18, 2022 10:09 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang > Subject: Re: [PATCH v8 11/12] vhost: vDPA blk devic

RE: [PATCH v8 09/12] vdpa/ifc: change some driver logic

2022-10-18 Thread Pei, Andy
Hi Maxime, Thanks. > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 18, 2022 9:57 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang > Subject: Re: [PATCH v8 09/12] vdpa/ifc: change some driver logic >

RE: [PATCH v8 08/12] vdpa/ifc: add internal API to get device

2022-10-18 Thread Pei, Andy
Hi Maxime, Thanks for your efforts. > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 18, 2022 9:48 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang > Subject: Re: [PATCH v8 08/12] vdpa/ifc: add inter

RE: [PATCH v8 07/12] vdpa/ifc: change internal function name

2022-10-18 Thread Pei, Andy
Hi Maxime, Thanks for your efforts. > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 18, 2022 9:45 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang > Subject: Re: [PATCH v8 07/12] vdpa/ifc: change i

RE: [PATCH v8 10/12] vhost: add type to rte vdpa device

2022-10-18 Thread Pei, Andy
Hi Maxime, Thanks for your efforts. > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 18, 2022 9:15 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang > Subject: Re: [PATCH v8 10/12] vhost: add ty

RE: [PATCH v7 10/12] vhost: add vdpa device type to rte vdpa device

2022-10-18 Thread Pei, Andy
Hi Maxime, Thanks for your reply. I think your suggestion is good, I will send a new version to do it. > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 18, 2022 3:15 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huan

RE: [PATCH v4 8/8] vhost: improve vDPA blk device configure condition

2022-10-17 Thread Pei, Andy
Hi Chenbo, Thanks for your efforts. > -Original Message- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:35 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v4 8/8] vhost: im

RE: [PATCH v4 7/8] vhost: vDPA blk device gets ready when any queue is ready

2022-10-16 Thread Pei, Andy
Hi Chenbo, Thanks for your efforts, my reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:34 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v4

RE: [PATCH v4 6/8] vdpa/ifc: support dynamic enable/disable queue

2022-10-16 Thread Pei, Andy
Hi Chenbo, Thanks for your efforts. > -Original Message- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:26 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v4 6/8] vdpa/ifc: s

RE: [PATCH v4 5/8] vdpa/ifc: only configure enabled queue

2022-10-16 Thread Pei, Andy
Hi Chenbo, Thanks for your efforts. > -Original Message- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:24 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v4 5/8] vdpa/ifc: o

RE: [PATCH v4 4/8] vdpa/ifc: write queue count to MQ register

2022-10-16 Thread Pei, Andy
Hi Chenbo, Thanks for your effort. I will send a new version to fix this. > -Original Message- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:24 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subje

RE: [PATCH v4 3/8] vdpa/ifc: set max queues based on virtio spec

2022-10-16 Thread Pei, Andy
Hi Chenbo, Thanks for your effort. > -Original Message- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:22 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v4 3/8] vdpa/ifc: se

RE: [PATCH v4 2/8] vdpa/ifc: add multi-queue support

2022-10-16 Thread Pei, Andy
Hi Chenbo, Thanks for your effort. > -Original Message- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:21 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v4 2/8] vdpa/ifc: ad

RE: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any queue is ready

2022-10-13 Thread Pei, Andy
Hi Maxime, Sorry, I did not notice your email before I send out V4 version. My reply is inline. > -Original Message- > From: Maxime Coquelin > Sent: Thursday, October 13, 2022 3:17 PM > To: Xia, Chenbo ; Pei, Andy ; > dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; >

RE: [PATCH v3 8/8] vhost: improve vDPA blk device readiness condition

2022-10-13 Thread Pei, Andy
> -Original Message- > From: Pei, Andy > Sent: Thursday, October 13, 2022 3:56 PM > To: Xia, Chenbo ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 8/8] vhost: improve vDPA blk device readiness >

RE: [PATCH v3 8/8] vhost: improve vDPA blk device readiness condition

2022-10-13 Thread Pei, Andy
Hi Chenbo, Thanks for your reply, my reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 5:36 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v

RE: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any queue is ready

2022-10-12 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Thursday, October 13, 2022 9:00 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3

RE: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any queue is ready

2022-10-12 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 5:09 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3

RE: [PATCH v3 6/8] vdpa/ifc: support dynamic enable/disable queue

2022-10-12 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 4:20 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [P

RE: [PATCH v3 5/8] vdpa/ifc: only configure enabled queue

2022-10-12 Thread Pei, Andy
Hi Chenbo, Thanks for your effort. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 4:12 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 5/8] vdpa/ifc: o

RE: [PATCH v3 4/8] vdpa/ifc: write queue count to MQ register

2022-10-12 Thread Pei, Andy
Hi Chenbo Thanks for your reply, my reply inline. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 4:08 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3

RE: [PATCH v3 2/8] vdpa/ifc: add multi-queue support

2022-10-12 Thread Pei, Andy
Hi Chenbo, Sure. I will address in next version. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 11:02 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 2/8

RE: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec

2022-10-12 Thread Pei, Andy
Hi Chenbo, Sure. I will address in next version. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 2:09 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 3

RE: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec

2022-10-12 Thread Pei, Andy
Hi Chenbo, Sure. I will address in next version. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 2:09 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 3

RE: [PATCH v3 1/8] vdpa/ifc: add new device ID for legacy network device

2022-10-11 Thread Pei, Andy
Hi Chenbo, Thanks for your effort. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 11:00 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 1/8] vdpa/ifc:

RE: [PATCH v3 1/8] vdpa/ifc: add new device ID for legacy network device

2022-10-11 Thread Pei, Andy
Hi Maxime, Thanks for your effort. > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, October 12, 2022 12:49 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang > Subject: Re: [PATCH v3 1/8] vdpa/ifc: add new

RE: [PATCH v2] vhost: use dedicated variable for vhost message result code

2022-09-29 Thread Pei, Andy
Hi Chenbo, Thanks for your efforts. > -Original Message- > From: Xia, Chenbo > Sent: Thursday, September 29, 2022 4:38 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com > Subject: RE: [PATCH v2] vhost: use dedicated variable for vhost mes

RE: [PATCH] vhost: use another variable to store vhost msg result code

2022-09-22 Thread Pei, Andy
HI Chenbo, Thanks for your reply. I think your suggestion is good, and I will send a V2 patch to address this. > -Original Message- > From: Xia, Chenbo > Sent: Thursday, September 22, 2022 9:27 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Ma, WenwuX

RE: [PATCH v2 7/8] vhost: configure device when any queue is ready for BLK device

2022-09-14 Thread Pei, Andy
HI Chenbo, Thanks for your reply, my reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, September 14, 2022 10:51 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; Cao, > Gang ; maxime.coque...@redhat.com > Subject: RE:

RE: [PATCH v2 6/8] vdpa/ifc: support dynamic enable/disable queue

2022-09-13 Thread Pei, Andy
Hi Chenbo, See my reply inline. > -Original Message- > From: Huang, Wei > Sent: Wednesday, September 14, 2022 11:04 AM > To: Xia, Chenbo ; Pei, Andy ; > dev@dpdk.org > Cc: Xu, Rosen ; Cao, Gang ; > maxime.coque...@redhat.com; Huang Wei > Subject: RE: [PATCH v

RE: [PATCH v2 3/8] vdpa/ifc: set max queues according to HW spec

2022-09-13 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Friday, September 9, 2022 1:56 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; Cao, > Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v2 3

RE: [PATCH v2 4/8] vdpa/ifc: write queue count to MQ register

2022-09-09 Thread Pei, Andy
Hi Chenbo, For BLK devices, ifc driver does not have VHOST_USER_SET_VRING_ENABLE msg. So it does not need to dynamic configuration. But now I think it is fine to use the same logic. > -Original Message- > From: Xia, Chenbo > Sent: Friday, September 9, 2022 3:35 PM > T

RE: [PATCH v2 2/8] vdpa/ifc: add multi queue support

2022-09-09 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Friday, September 9, 2022 8:29 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; Cao, > Gang ; maxime.coque...@redhat.com; Huang Wei > > Su

RE: [PATCH v2 1/8] vdpa/ifc: add new device ID

2022-09-09 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. I will send V3 patch to address your 2 comments. > -Original Message- > From: Xia, Chenbo > Sent: Friday, September 9, 2022 8:29 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; Cao, > Gang ; maxime.coque...@red

RE: [PATCH v3] vhost: fix deadlock when message handling failed

2022-07-11 Thread Pei, Andy
check the function is returned successfully or not while it is also used to store vhost msg return code like "RTE_VHOST_MSG_RESULT_XXX". > -Original Message- > From: Xia, Chenbo > Sent: Monday, July 11, 2022 4:54 PM > To: Pei, Andy ; Maxime Coquelin > ; Ma, Wenwu

RE: [PATCH v3] vhost: fix deadlock when message handling failed

2022-07-11 Thread Pei, Andy
HI ALL, I see that in function vhost_user_msg_handler. We use "ret" to store both vhost msg return code like "RTE_VHOST_MSG_RESULT_XXX" and function return value. I wonder if it is better to use two different variable to make it easy to read. > -Original Message- > From: Maxime Coquelin

RE: [PATCH] vdpa/ifc/base: fix null pointer dereference

2022-07-08 Thread Pei, Andy
Hi Maxime, Thanks for your efforts. > -Original Message- > From: Maxime Coquelin > Sent: Friday, July 8, 2022 5:11 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Wang, Xiao W > > Subject: Re: [PATCH] vdpa/ifc/base: fix null pointer dereference > > >

RE: [PATCH] vhost: fix virtio blk vDPA live migration IO drop

2022-07-03 Thread Pei, Andy
HI Maxime, Thanks. > -Original Message- > From: Maxime Coquelin > Sent: Friday, July 1, 2022 9:55 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Xiao, QimaiX > Subject: Re: [PATCH] vhost: fix virtio blk vDPA live migration IO drop > >

RE: [PATCH] vdpa/ifc: fix vhost message size check issue

2022-07-03 Thread Pei, Andy
Hi Maxime, Thanks for your effort. > -Original Message- > From: Maxime Coquelin > Sent: Friday, July 1, 2022 9:55 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Xiao, QimaiX > Subject: Re: [PATCH] vdpa/ifc: fix vhost message size check issue

RE: [PATCH v2] vdpa/ifc: fix null pointer dereference

2022-06-18 Thread Pei, Andy
Hi Maxime, Thanks for your effort. > -Original Message- > From: Maxime Coquelin > Sent: Friday, June 17, 2022 10:08 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Wang, Xiao W > ; Xu, Rosen ; Xiao, QimaiX > > Subject: Re: [PATCH v2] vdpa/ifc: fix

RE: [PATCH] vdpa/ifc: fix null pointer dereference

2022-06-15 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. I will fix this in next version. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, June 15, 2022 10:04 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Wang, Xiao W ; > Xu, Rosen ; Xiao, QimaiX > Subj

RE: [PATCH v10 00/13] add virtio_blk device support to vdpa/ifc

2022-06-01 Thread Pei, Andy
Thanks Maxime > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 1, 2022 6:11 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Cao, Gang ; > Liu, Changpeng ; Xu, Rosen > ; Xiao, QimaiX > Subject: Re: [PATCH v10 00/13] add virtio_blk de

RE: [PATCH v10 04/13] vdpa/ifc: add blk ops for ifc device

2022-05-23 Thread Pei, Andy
Hi Chenbo, Thanks for your effort. > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, May 24, 2022 2:28 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subject: RE: [PATCH

RE: [PATCH v9 04/13] vdpa/ifc: add blk ops for ifc device

2022-05-23 Thread Pei, Andy
> -Original Message- > From: Xia, Chenbo > Sent: Tuesday, May 24, 2022 10:55 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subject: RE: [PATCH v9 04/13] vdpa/ifc: ad

RE: [PATCH v9 03/13] vhost: add vhost msg support for get/set config

2022-05-23 Thread Pei, Andy
> -Original Message- > From: Xia, Chenbo > Sent: Tuesday, May 24, 2022 10:52 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subject: RE: [PATCH v9 03/13] vhost: add vhost msg supp

RE: [PATCH v9 13/13] vdpa/ifc/base: access correct register for blk device

2022-05-23 Thread Pei, Andy
Hi Chenbo, Sure. Thanks for your review. I will address in V10. > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, May 24, 2022 11:10 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao,

RE: [PATCH v8 13/13] vdpa/ifc/base: access correct register for blk device

2022-05-23 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. I will address in next version. > -Original Message- > From: Xia, Chenbo > Sent: Monday, May 23, 2022 3:56 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao,

RE: [PATCH v8 10/13] usertools: add support for virtio blk device

2022-05-23 Thread Pei, Andy
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Monday, May 23, 2022 3:43 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subject: RE: [PATCH v8 10/13] usertools: ad

RE: [PATCH v8 09/13] examples/vdpa: add add virtio blk support

2022-05-23 Thread Pei, Andy
Hi Chenbo, Thanks for your reply, my reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Monday, May 23, 2022 3:40 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subj

RE: [PATCH v8 08/13] vdpa/ifc: add get device type ops to ifc driver

2022-05-23 Thread Pei, Andy
Sure > -Original Message- > From: Xia, Chenbo > Sent: Monday, May 23, 2022 3:30 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subject: RE: [PATCH v8 08/13] vdpa/ifc: add get devic

RE: [PATCH v8 07/13] vhost: add API to get vDPA device type

2022-05-23 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. I will send a new version to address these. > -Original Message- > From: Xia, Chenbo > Sent: Monday, May 23, 2022 3:26 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rose

RE: [PATCH v8 06/13] vdpa/ifc: add block device SW live-migration

2022-05-22 Thread Pei, Andy
Hi Chenbo, Thanks for your reply, I will fix them in next version. > -Original Message- > From: Xia, Chenbo > Sent: Monday, May 23, 2022 1:25 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao,

RE: [PATCH v8 04/13] vdpa/ifc: add blk ops for ifc device

2022-05-22 Thread Pei, Andy
HI Chenbo, Thanks for your reply, my reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Monday, May 23, 2022 12:08 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subj

RE: [PATCH v8 03/13] vhost: add vhost msg support for get/set config

2022-05-22 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. I will check it in next version patch. > -Original Message- > From: Xia, Chenbo > Sent: Monday, May 23, 2022 11:55 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xi

RE: [PATCH v8 02/13] vhost: add vDPA ops for blk device

2022-05-22 Thread Pei, Andy
Hi Chenbo, Thanks for your reply, I will send out a new version to address this. > -Original Message- > From: Xia, Chenbo > Sent: Monday, May 23, 2022 11:46 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rose

RE: [PATCH v8 01/13] vdpa/ifc: add support for virtio blk device

2022-05-22 Thread Pei, Andy
Hi Chenbo, Thanks for your reply, my reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Monday, May 23, 2022 11:42 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subj

RE: [PATCH v7 17/18] vdpa/ifc: blk device pause without no inflight IO

2022-05-15 Thread Pei, Andy
Hi Chenbo, Thanks for reply. This will be addressed in next version. > -Original Message- > From: Xia, Chenbo > Sent: Friday, May 13, 2022 10:59 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PAT

RE: [PATCH v7 16/18] vdpa/ifc/base: access correct register for blk device

2022-05-15 Thread Pei, Andy
HI Chenbo, Thanks for your reply. I will send out a new version to fix this. > -Original Message- > From: Xia, Chenbo > Sent: Friday, May 13, 2022 10:58 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE:

RE: [PATCH v7 15/18] vdpa/ifc: add is blk flag to ifcvf HW struct

2022-05-15 Thread Pei, Andy
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Friday, May 13, 2022 10:55 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 15/18] vdpa/ifc: add is blk flag to ifcvf HW struct

RE: [PATCH v7 12/18] vdpa/ifc: add some log at vDPA launch before qemu connect

2022-05-15 Thread Pei, Andy
Hi Stephen, Thanks for your reply. I will change to DEBUG level log in next version. > -Original Message- > From: Stephen Hemminger > Sent: Friday, May 13, 2022 11:38 PM > To: Pei, Andy > Cc: Xia, Chenbo ; dev@dpdk.org; > maxime.coque...@redhat.com; Cao, Gang

RE: [PATCH v7 14/18] vdpa/ifc: add interrupt and handle for virtio blk

2022-05-13 Thread Pei, Andy
HI Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Friday, May 13, 2022 10:53 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 14/18] vdpa/i

RE: [PATCH v7 13/18] vdpa/ifc: read virtio max queues from hardware

2022-05-13 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. This patch will be omitted in next version. > -Original Message- > From: Xia, Chenbo > Sent: Thursday, May 12, 2022 9:55 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject

RE: [PATCH v7 12/18] vdpa/ifc: add some log at vDPA launch before qemu connect

2022-05-13 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Thursday, May 12, 2022 9:53 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 12/18] vdpa

RE: [PATCH v7 09/18] examples/vdpa: add vDPA blk support in example

2022-05-13 Thread Pei, Andy
HI Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Thursday, May 12, 2022 9:34 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 09/18] ex

RE: [PATCH v7 08/18] vdpa/ifc: add get device type ops to ifc driver

2022-05-13 Thread Pei, Andy
rsday, May 12, 2022 9:41 PM > To: Xia, Chenbo ; Pei, Andy ; > dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 08/18] vdpa/ifc: add get device type ops to ifc driver > > > -Original Message- > > From: Xia

RE: [PATCH v7 07/18] vhost: add API to get vDPA device type

2022-05-12 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Thursday, May 12, 2022 9:14 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 07/18] vhost

RE: [PATCH v7 06/18] vdpa/ifc: add block device SW live-migration

2022-05-12 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. Your suggestion is good. I will fix in next version. > -Original Message- > From: Xia, Chenbo > Sent: Thursday, May 12, 2022 8:55 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > S

RE: [PATCH v7 03/18] vhost: add vhost msg support

2022-05-11 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, May 11, 2022 10:24 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 03/18] vhost:

RE: [PATCH v7 05/18] vdpa/ifc: add vDPA interrupt for blk device

2022-05-11 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. Sure, I will use your commit log suggestion, and I will also change subject to "vdpa/ifc: add vDPA interrupt relay for blk device" > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, May 11, 2022 10:36 PM > To: Pei, An

RE: [PATCH v6 03/16] vhost: add vhost msg support

2022-04-26 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, April 26, 2022 5:17 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v6 03/16]

RE: [PATCH v6 07/16] examples/vdpa: add vDPA blk support in example

2022-04-26 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Monday, April 25, 2022 9:39 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v6 07/16] ex

RE: [PATCH v6 06/16] vdpa/ifc: add block device SW live-migration

2022-04-26 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Monday, April 25, 2022 9:10 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v6 06/16] vdpa/

RE: [PATCH v6 05/16] vdpa/ifc: add vDPA interrupt for blk device

2022-04-26 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Monday, April 25, 2022 8:58 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v6 05/1

RE: [PATCH v6 03/16] vhost: add vhost msg support

2022-04-26 Thread Pei, Andy
HI Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Monday, April 25, 2022 8:42 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v6 03/16]

RE: [PATCH v6 03/16] vhost: add vhost msg support

2022-04-26 Thread Pei, Andy
HI David, Thanks for your reply. I will send out a version to address that. > -Original Message- > From: David Marchand > Sent: Monday, April 25, 2022 9:05 PM > To: Pei, Andy > Cc: dev ; Xia, Chenbo ; Maxime > Coquelin ; Cao, Gang > ; Liu, Changpeng > Subj

RE: [PATCH v6 08/16] usertools: add support for virtio blk device

2022-04-25 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. I will send out a new version, and put blk device into misc devices. > -Original Message- > From: Xia, Chenbo > Sent: Monday, April 25, 2022 9:53 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; L

RE: [PATCH v5 03/16] vhost: add support for VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG

2022-04-21 Thread Pei, Andy
HI Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, April 20, 2022 9:53 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v5 03/16] v

RE: [PATCH v3 06/15] example/vdpa:add vdpa blk support in example

2022-03-23 Thread Pei, Andy
Hi Maxime, I seems a lot of problem with the example. I think I will re-work the example according to your comments. Thanks for your comments. -Original Message- From: Maxime Coquelin Sent: Tuesday, March 22, 2022 7:30 PM To: Pei, Andy ; dev@dpdk.org Cc: Xia, Chenbo ; Cao, Gang ; Liu

RE: [PATCH v3 05/15] vdpa/ifc: add blk dev sw live migration

2022-03-23 Thread Pei, Andy
Hi Maxime, Thanks for your reply and reply is inline. -Original Message- From: Maxime Coquelin Sent: Tuesday, March 22, 2022 7:10 PM To: Pei, Andy ; dev@dpdk.org Cc: Xia, Chenbo ; Cao, Gang ; Liu, Changpeng Subject: Re: [PATCH v3 05/15] vdpa/ifc: add blk dev sw live migration Hi

RE: [PATCH v3 04/15] vdpa/ifc: add vdpa interrupt for blk device

2022-03-23 Thread Pei, Andy
Hi Maxime, I think it is better to change the commit log to your description. "For the block device type, we have to relay the commands on all queues." In the next version of patch set. -Original Message----- From: Pei, Andy Sent: Wednesday, March 23, 2022 3:08 PM To: Maxime Coqu

RE: [PATCH v3 04/15] vdpa/ifc: add vdpa interrupt for blk device

2022-03-23 Thread Pei, Andy
Hi Maxime, Thanks for your reply and my reply is inline. -Original Message- From: Maxime Coquelin Sent: Tuesday, March 22, 2022 6:05 PM To: Pei, Andy ; dev@dpdk.org Cc: Xia, Chenbo ; Cao, Gang ; Liu, Changpeng Subject: Re: [PATCH v3 04/15] vdpa/ifc: add vdpa interrupt for blk device

RE: [PATCH v2 15/15] vhost: make sure each queue callfd is configured

2022-01-28 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. I will send out a V3 patch set to address that. -Original Message- From: Xia, Chenbo Sent: Thursday, January 27, 2022 3:13 PM To: Pei, Andy ; dev@dpdk.org Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, Changpeng Subject: RE: [PATCH v2 15/15] vhost

RE: [PATCH] vhost: add some log for vhost message VHOST_USER_SET_VRING_BASE

2022-01-13 Thread Pei, Andy
Hi Chenbo, Thanks for you reply. I will send a V2 patch to address it. -Original Message- From: Xia, Chenbo Sent: Friday, January 14, 2022 3:40 PM To: Pei, Andy ; dev@dpdk.org Subject: RE: [PATCH] vhost: add some log for vhost message VHOST_USER_SET_VRING_BASE > -Original Mess

RE: [PATCH v2] vdpa/ifc: fix log info mismatch

2021-12-12 Thread Pei, Andy
Hi Xiao, Thanks for your reply. I will send a V3 patch to address this. -Original Message- From: Wang, Xiao W Sent: Monday, December 13, 2021 3:30 PM To: Pei, Andy ; dev@dpdk.org Cc: Xia, Chenbo Subject: RE: [PATCH v2] vdpa/ifc: fix log info mismatch Hi Andy, BRs, Xiao

  1   2   >