[dpdk-dev] [RFC v2 7/7] app/testpmd: macsec adding RX/TX SC using rte_security interface

2019-10-25 Thread Pavel Belous
From: Pavel Belous Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- app/test-pmd/cmdline.c | 11 +- app/test-pmd/macsec.c | 56 ++ app/test-pmd/macsec.h | 2 ++ 3 files changed, 63 insertions(+), 6 deletions(-) diff --git

[dpdk-dev] [RFC v2 4/7] net/atlantic: add MACSEC internal HW data declaration and functions

2019-10-25 Thread Pavel Belous
From: Pavel Belous MACSEC configuration is done by configuring multiple tables of MACSEC block: - Ingress Pre-Security Classification table - Ingress SC/SA/SAK lookup tables - Ingress Post-Security Classification table - Egress Packet Classifier table - Egress Control Filter table - Egress SC

[dpdk-dev] [RFC v2 5/7] net/atlantic: implementation of the MACSEC using rte_security interface

2019-10-25 Thread Pavel Belous
From: Pavel Belous Signed-off-by: Pavel Belous --- drivers/net/atlantic/Makefile | 2 +- drivers/net/atlantic/atl_ethdev.c | 316 ++- drivers/net/atlantic/atl_sec.c| 615 ++ drivers/net/atlantic/atl_sec.h

[dpdk-dev] [RFC v2 6/7] app/testpmd: macsec on/off commands using rte_security interface

2019-10-25 Thread Pavel Belous
From: Pavel Belous Here we create/get security mempool, get sec_ctx, and then request session creation with macsec specific session configuration. encrypt and replay_protection parameters are really not a global macsec attributes, they are related to tx and rx security connection properties

[dpdk-dev] [RFC v2 3/7] net/atlantic: Add helper functions for PHY access

2019-10-25 Thread Pavel Belous
From: Pavel Belous Aquantia AQC107/AQC108 ethernet controllers includes MAC and PHY part. Some network features, like MACSec, are configured directly in the PHY part. This patch adds helper functions for accessing PHY part via internal MDIO interface. Signed-off-by: Pavel Belous --- drivers

[dpdk-dev] [RFC v2 1/7] security: MACSEC infrastructure data declarations

2019-10-25 Thread Pavel Belous
From: Pavel Belous This patch extends rte_security framework to support MACSEC operations. Signed-off-by: Igor Russkikh Signed-off-by: Pavel Belous --- lib/librte_security/rte_security.h | 143 +++-- 1 file changed, 138 insertions(+), 5 deletions(-) diff

[dpdk-dev] [RFC v2 2/7] security: Update rte_security documentation

2019-10-25 Thread Pavel Belous
From: Pavel Belous Signed-off-by: Pavel Belous --- doc/guides/prog_guide/rte_security.rst | 4 1 file changed, 4 deletions(-) diff --git a/doc/guides/prog_guide/rte_security.rst b/doc/guides/prog_guide/rte_security.rst index 7d0734a..4b9b186 100644 --- a/doc/guides/prog_guide

[dpdk-dev] [RFC v2 0/7] RFC: Support MACSEC offload in the RTE_SECURITY infrastructure.

2019-10-25 Thread Pavel Belous
From: Pavel Belous This RFC suggest possible API to implement generic MACSEC HW offload in DPDK infrastructure. Right now two PMDs implementing MACSEC hw offload via private API: ixgbe (Intel) and atlantic (Aquantia). During that private API discussion it was decided to go further with well

[dpdk-dev] [PATCH v2 2/3] net/atlantic: fix reported flow control mode

2019-09-20 Thread Pavel Belous
From: Pavel Belous Driver reports current flow control mode based on internal flow control settings. Currently this logic works incorrectly. Fixes: 921eb6b8ce31 ("net/atlantic: fix flow control by sync settings on Rx") Cc: sta...@dpdk.org Signed-off-by: Pavel Belous Signed-of

[dpdk-dev] [PATCH v2 3/3] net/atlantic: add FW mailbox guard mutex

2019-09-20 Thread Pavel Belous
From: Pavel Belous Driver uses the Firmware mailbox to read statistics and configure some features. This patch introduces a mutex to provide consistent access to the FW mailbox to prevent potential data corruption. Fixes: 86d36773bd42 ("net/atlantic: implement firmware operations")

[dpdk-dev] [PATCH v2 0/3] net/atlantic: Atlantic PMD updates

2019-09-20 Thread Pavel Belous
From: Pavel Belous This patchset provides the various fixes for Atlantic Driver. v2 changes: - compile errors on some environments fixed Pavel Belous (3): net/atlantic: exclude MACSEC counters from xstats net/atlantic: fix reported flow control mode net/atlantic: add FW mailbox guard

[dpdk-dev] [PATCH v2 1/3] net/atlantic: exclude MACSEC counters from xstats

2019-09-20 Thread Pavel Belous
From: Pavel Belous Currently, driver always return full set of xstats counters, including MACSEC counters. But this driver also supports AQC100 chips, which does not have MACSEC feature. This fix adds checking for MACSEC availability (based on FW capability bits) and returns xstats without

[dpdk-dev] [PATCH 3/3] net/atlantic: add FW mailbox guard mutex

2019-09-05 Thread Pavel Belous
From: Pavel Belous Driver uses the Firmware mailbox to read statistics and configure some features. This patch introduces a mutex to provide consistent access to the FW mailbox to prevent potential data corruption. Fixes: 86d36773bd42 ("net/atlantic: implement firmware operations")

[dpdk-dev] [PATCH 2/3] net/atlantic: fix reported flow control mode

2019-09-05 Thread Pavel Belous
From: Pavel Belous Driver reports current flow control mode based on internal flow control settings. Currently this logic works incorrectly. Fixes: 921eb6b8ce31 ("net/atlantic: fix flow control by sync settings on Rx") Cc: sta...@dpdk.org Signed-off-by: Pavel Belous Signed-of

[dpdk-dev] [PATCH 0/3] net/atlantic: Atlantic PMD updates

2019-09-05 Thread Pavel Belous
From: Pavel Belous This patchset provides the various fixes for Atlantic Driver. Pavel Belous (3): net/atlantic: exclude MACSEC counters from xstats net/atlantic: fix reported flow control mode net/atlantic: add FW mailbox guard mutex drivers/net/atlantic/atl_ethdev.c | 60

[dpdk-dev] [PATCH 1/3] net/atlantic: exclude MACSEC counters from xstats

2019-09-05 Thread Pavel Belous
From: Pavel Belous Currently, driver always return full set of xstats counters, including MACSEC counters. But this driver also supports AQC100 chips, which does not have MACSEC feature. This fix adds checking for MACSEC availability (based on FW capability bits) and returns xstats without