Re: [EXTERNAL] [PATCH v0 1/1] doc: announce inter-device DMA capability support in dmadev

2025-07-13 Thread Pavan Nikhilesh Bhagavatula
>> From: Vamsi Attunuru >> >> Modern DMA hardware supports data transfer between multiple >> DMA devices, enabling data communication across isolated domains or >> containers. To facilitate this, the ``dmadev`` library requires changes >> to allow devices to register

Re: [PATCH v1] app/eventdev: fix number of releases sent during cleanup

2025-06-25 Thread Pavan Nikhilesh Bhagavatula
>During cleanup, only send releases for events app was >not able to enqueue. Current code is sending releases for >entire dequeue burst. > >Fixes: f0b68c0b2af7 ("app/eventdev: clean up worker state before exit") >Cc: sta...@dpdk.org > >Signed-off-by: Pravin Pathak Acked-by: Pavan Nikhilesh >---

Re: [PATCH] test/event: fix event vector adapter timeouts

2025-06-19 Thread Pavan Nikhilesh Bhagavatula
>Sent: Thursday, June 12, 2025 05:43 >To: Jerin Jacob; tho...@monjalon.net; david.march...@redhat.com; Pavan >Nikhilesh Bhagavatula >Cc: dev@dpdk.org >Subject: [PATCH] test/event: fix event vector adapter timeouts > >From: Pavan Nikhilesh > >Update event vector adapte

Re: [EXTERNAL] [PATCH v2] examples/l3fwd: adjust Tx burst size based on Rx burst

2025-06-10 Thread Pavan Nikhilesh Bhagavatula
>Previously, the TX burst size was fixed at 256, leading to performance >degradation in certain scenarios. > >This patch introduces logic to set the TX burst size to match the >configured RX burst size (--burst option, default 32, max 512) >for better efficiency. > >Fixes: d5c4897ecfb2 ("examples/l

Re: [EXTERNAL] Re: [25.11 PATCH v3 0/5] Introduce DMA enqueue/dequeue operations

2025-06-09 Thread Pavan Nikhilesh Bhagavatula
Hi Bruce, >On Sat, May 24, 2025 at 02:43:10PM +0530, pbhagavat...@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Introduce DMA enqueue/dequeue operations to the DMA device library. >> >> Add configuration flags to rte_dma_config instead of boolean for >> individual features. >> >> The enqueue

RE: [EXTERNAL] [PATCH] drivers: remove __rte_used from functions for compatibility with MSVC

2025-05-27 Thread Pavan Nikhilesh Bhagavatula
> > From: Andre Muezerie > > Sent: Friday, April 4, 2025 7: 18 AM > > To: Nithin Kumar Dabilpuram ; Kiran Kumar > > Kokkilagadda ; ZjQcmQRYFpfptBannerStart Prioritize security for external emails: Confirm sender and content safety before clicking links or o

RE: rte_lcore_has_role() return value

2025-05-19 Thread Pavan Nikhilesh Bhagavatula
My bad, I got it confused with lcore topology patches. I will look into this. Thanks, Pavan. > -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Monday, May 19, 2025 7:32 PM > To: Morten Brørup ; Varghese, Vipin > > Cc: dev > Subject: RE: rte_lcore_ha

RE: rte_lcore_has_role() return value

2025-05-19 Thread Pavan Nikhilesh Bhagavatula
Hi Morten, Looks like this is meant for Vipin. +Vipin Thanks, Pavan. > Pavan, > > The rte_lcore_has_role() documentation says it returns bool. > > Its implementation returns a true value (-1) if given a non-compliant > lcore_id, > e.g. LCORE_ID_ANY. > > I think it should behave like rte_lc

RE: [PATCH v6 2/2] node: use node mbuf dynfield in ip4 nodes

2025-05-09 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Nitin Saxena > Sent: Monday, April 28, 2025 4:07 PM > To: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > Bhagavatula ; Robin Jarry > ; Christophe Fontaine > Cc: dev@dpdk.org; Jerin Jacob ; Nitin Saxena > > Subject: [PATCH v6 2/2] n

RE: [PATCH v6 1/2] node: add global node mbuf dynfield

2025-05-09 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Nitin Saxena > Sent: Monday, April 28, 2025 4:07 PM > To: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > Bhagavatula ; Robin Jarry > ; Christophe Fontaine > Cc: dev@dpdk.org; Jerin Jacob ; Nitin Saxena > > Subject: [PATCH v6 1/2]

RE: [PATCH v6 0/2] node: add mbuf dynamic field for nodes

2025-05-05 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Nitin Saxena > Sent: Monday, April 28, 2025 4:07 PM > To: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > Bhagavatula ; Robin Jarry > ; Christophe Fontaine > Cc: dev@dpdk.org; Jerin Jacob ; Nitin Saxena > > Subject: [PATCH v6 0/2] n

RE: [EXTERNAL] Re: [25.11 PATCH 1/3] dmadev: add enqueue dequeue operations

2025-05-02 Thread Pavan Nikhilesh Bhagavatula
Hi Fengchengwen, > Hi Pavan, > > On 2025/4/16 18:09, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Add enqueue/dequeue operations that use struct rte_dma_op > > to communicate with the dma device. > > These operations need to be enabled at dma device configuration > > time b

RE: [PATCH v5 1/2] node: add global node mbuf dynfield

2025-04-18 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Nitin Saxena > Sent: Wednesday, April 9, 2025 7:26 PM > To: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > Bhagavatula ; Robin Jarry > ; Christophe Fontaine > Cc: dev@dpdk.org; Jerin Jacob ; Nitin Saxena > > Subject: [PATCH v5 1/2]

RE: [EXTERNAL] Re: [PATCH 1/2] node: add global node mbuf dynfield

2025-04-04 Thread Pavan Nikhilesh Bhagavatula
> Hi Stephen, > > Thanks for commenting. See response inline. > > Regards, > Nitin > > On Tue, Apr 1, 2025 at 7:45 PM Stephen Hemminger > wrote: > > > > On Tue, 1 Apr 2025 09:50:46 +0530 > > Nitin Saxena wrote: > > > > > +int rte_node_mbuf_dynfield_register(void) > > > +{ > > > + struct no

RE: [EXTERNAL] [PATCH] config/arm: fix meson for native instruction set Arm CPUs

2025-03-27 Thread Pavan Nikhilesh Bhagavatula
> Hi Gregory, > > > Arm meson.build unconditionally relays on the `extra_features` > > member of SoC configuration. > > > > SoC dictionary is populated for Arm CPUs with generic instruction set > > only. > > For Arm CPUs with native CPU instruction set the SoC dictionary is > > empty. > > > > meso

RE: [RFC v2 0/3] Introduce DMA enqueue/dequeue operations

2025-03-26 Thread Pavan Nikhilesh Bhagavatula
++ > -Original Message- > From: pbhagavat...@marvell.com > Sent: Thursday, March 27, 2025 1:07 AM > To: Jerin Jacob > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [RFC v2 0/3] Introduce DMA enqueue/dequeue operations > > From: Pavan Nikhilesh

RE: [EXTERNAL] Re: [RFC 2/2] eventdev: add default software vector adapter

2025-03-26 Thread Pavan Nikhilesh Bhagavatula
> On Wed, 26 Mar 2025 18:44:36 +0530 > wrote: > > > +struct sw_vector_adapter_service_data { > > + uint32_t service_id; > > + RTE_ATOMIC(rte_mcslock_t *) lock; > > + RTE_TAILQ_HEAD(, sw_vector_adapter_data) adapter_list; > > +}; > > Why the indirect pointer to the lock? rather than embeddi

RE: [RFC 0/2] introduce event vector adapter

2025-03-26 Thread Pavan Nikhilesh Bhagavatula
++ > -Original Message- > From: pbhagavat...@marvell.com > Sent: Wednesday, March 26, 2025 6:45 PM > To: Jerin Jacob > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [RFC 0/2] introduce event vector adapter > > From: Pavan Nikhilesh > >

RE: [EXTERNAL] [PATCH] config/arm: fix meson for native instruction set Arm CPUs

2025-03-19 Thread Pavan Nikhilesh Bhagavatula
Hi Gregory, > Arm meson.build unconditionally relays on the `extra_features` > member of SoC configuration. > > SoC dictionary is populated for Arm CPUs with generic instruction set > only. > For Arm CPUs with native CPU instruction set the SoC dictionary is > empty. > > meson setup failed for

RE: [PATCH] config/arm: fix march features not being set

2025-03-18 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, March 13, 2025 10:13 AM > To: Wathsala Wathawana Vithanage ; Jerin > Jacob ; Bruce Richardson > Cc: dev@dpdk.org; nd > Subject: RE: [PATCH] config/arm: fix march features not being set >

RE: [PATCH] config/arm: fix march features not being set

2025-03-12 Thread Pavan Nikhilesh Bhagavatula
> Hi Pavan, > > I think this patch does the right thing. I have a minor comment on the > cc.has_argument you have added. > > > --- > > config/arm/meson.build | 11 --- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build

RE: [EXTERNAL] Re: [PATCH] devtools: fix regex of cnxk skip files

2025-03-06 Thread Pavan Nikhilesh Bhagavatula
> 06/03/2025 16:25, pbhagavat...@marvell.com: > > From: Pavan Nikhilesh > > > > SKIP_FILES should include the path of the file. > > Update the regex to match the path. > > Can you please also check this one: > -v SKIP_FILES='osdep.h$' > Is it really working without the full path? > Sure,

RE: [EXTERNAL] Re: [PATCH] devtools: fix regex of cnxk skip files

2025-03-06 Thread Pavan Nikhilesh Bhagavatula
> 06/03/2025 16:25, pbhagavat...@marvell.com: > > From: Pavan Nikhilesh > > > > SKIP_FILES should include the path of the file. > > Update the regex to match the path. > > > > Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver") > > > > Signed-off-by: Pavan Nikhilesh > > --- > >

RE: [PATCH v3 02/14] eventdev: remover unnecessary deref on function pointers

2025-02-25 Thread Pavan Nikhilesh Bhagavatula
> > -Original Message- > > From: Stephen Hemminger > > Sent: Thursday, February 20, 2025 10:25 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; Morten Brørup > > ; Richardson, Bruce > > ; Gujjar, Abhinandan S > > ; Jerin Jacob ; Amit > > Prakash Shukla ; Naga Harish K, S V > > > > Sub

RE: [PATCH] test/event: fix number of queues in eventdev conf

2025-02-25 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Shijith Thotton > Sent: Thursday, February 6, 2025 8:03 PM > To: Jerin Jacob > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > ; Shijith Thotton ; > sta...@dpdk.org; Naga Harish K S V > Subject: [PATCH] test/event: fix number of

RE: [EXTERNAL] [RFC v7 0/4] eventdev: atomic tests to test-eventdev app

2025-02-20 Thread Pavan Nikhilesh Bhagavatula
> Add atomic tests to the test-eventdev app which correspond to the order > tests but use exclusively atomic queues. > > The test detects if port maintenance is required, and so they are compatible > with event devices such as the distributed software eventdev. > > To verify atomicity, a spinlock

RE: [EXTERNAL] [RFC PATCH v6 1/2] eventdev: add atomic queue to test-eventdev app

2025-02-14 Thread Pavan Nikhilesh Bhagavatula
> On Tue, 2025-02-04 at 16:11 +0000, Pavan Nikhilesh Bhagavatula wrote: > > > Add an atomic queue test to the test-eventdev app, which is based on the > > > order queue test that exclusively uses atomic queues. > > > > > > This makes it compatible with even

RE: [EXTERNAL] [RFC PATCH v6 1/2] eventdev: add atomic queue to test-eventdev app

2025-02-04 Thread Pavan Nikhilesh Bhagavatula
> Add an atomic queue test to the test-eventdev app, which is based on the > order queue test that exclusively uses atomic queues. > > This makes it compatible with event devices such as the > distributed software eventdev. > > The test detects if port maintenance is required. > > To verify atom

RE: [EXTERNAL] [RFC v5 1/2] eventdev: add atomic queue to test-eventdev app

2025-01-22 Thread Pavan Nikhilesh Bhagavatula
> Add an atomic queue test based on the order queue test that exclusively uses > atomic queues. > This makes it compatible with event devices such as the distributed software > eventdev. > > The test detects if port maintenance is required. > > To verify atomicity, a spinlock is set up for each c

RE: [EXTERNAL] [RFC v3 3/3] examples: add lcore topology API calls

2024-10-30 Thread Pavan Nikhilesh Bhagavatula
> > Hi Pavan, > > > > Snipped > > > > > > > > I see compilation failure on ARM platforms due to missing header include. > > > > > > ../examples/helloworld/main.c: In function 'parse_topology': > > > ../examples/helloworld/main.c:83:13: error: implicit declaration of > > > function 'strtoul'; did yo

RE: [EXTERNAL] [RFC v3 2/3] test/lcore: enable tests for topology

2024-10-30 Thread Pavan Nikhilesh Bhagavatula
> add functional test cases to validate topology supported lcore > API. > > v3 changes: > - fix test test-report/2024-October/817748.html > > Signed-off-by: Vipin Varghese > --- Test fails on ARM platform: lcore 19, socket 0, role RTE, cpuset 19 Control thread running successfully INFO: lco

RE: [EXTERNAL] [RFC v3 3/3] examples: add lcore topology API calls

2024-10-30 Thread Pavan Nikhilesh Bhagavatula
> Enhance example code to allow topology based lcores API, while > retaining default behaviour. > > - helloworld: allow lcoes to send hello to lcores in selected topology. > - l2fwd: allow use of IO lcores topology. > - skeleton: choose the lcore from IO topology which has more ports. > > v3 c

RE: [EXTERNAL] Re: [PATCH 07/20] event/cnxk: add CN20K SSO dequeue fast path

2024-10-22 Thread Pavan Nikhilesh Bhagavatula
> On Thu, 3 Oct 2024 18:52:24 +0530 > wrote: > > > +static __rte_always_inline uint16_t > > +cn20k_sso_hws_get_work(struct cn20k_sso_hws *ws, struct rte_event > *ev, const uint32_t flags) > > +{ > > + union { > > + __uint128_t get_work; > > + uint64_t u64[2]; > > + } gw; >

RE: [EXTERNAL] Re: [PATCH 01/20] common/cnxk: implement SSO HW info

2024-10-22 Thread Pavan Nikhilesh Bhagavatula
> On Thu, 3 Oct 2024 18:52:18 +0530 > wrote: > > > From: Pavan Nikhilesh > > > > Add SSO HW info mbox to get hardware capabilities, and reuse > > them instead of depending on hardcoded values. > > Remove redundant includes. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > You need to fix dir

RE: [PATCH] event/cnxk: remove single dequeue functions

2024-10-21 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Tuesday, October 22, 2024 10:30 AM > To: Jerin Jacob ; mattias.ronnb...@ericsson.com; > Pavan Nikhilesh Bhagavatula ; Shijith Thotton > > Cc: dev@dpdk.org > Subject: [PATCH] event/cnxk: remove

RE: [EXTERNAL] [PATCH] event/octeontx: resolve possible integer overflow

2024-10-18 Thread Pavan Nikhilesh Bhagavatula
> The last argument passed to ssovf_parsekv() is an > unsigned char*, but it is accessed as an integer. > This can lead to an integer overflow. > > Hence, make ensure the argument is accessed as a char > and for better error handling use strtol instead of atoi. > > Signed-off-by: Hanumanth Pothul

RE: [EXTERNAL] Re: [PATCH v5 0/3] Introduce node-specific errors in graph library

2024-10-14 Thread Pavan Nikhilesh Bhagavatula
> Hi Pavan, > > I am resending my review here. It seems you didn't get it. > > , Oct 14, 2024 at 13:58: > > From: Pavan Nikhilesh > > > > > > Introduce the ability for nodes to advertise error counters during > > registration and increment them during the node process function in > > the graph l

RE: [EXTERNAL] Re: [PATCH v4 3/5] graph: add stats for node specific errors

2024-10-12 Thread Pavan Nikhilesh Bhagavatula
> > From: Robin Jarry > > Sent: Friday, October 11, 2024 3:24 PM > > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > > ; Nithin Kumar Dabilpuram > > ; Kiran Kumar Kokkilagadda > > ; zhirun@intel.com; Zhirun Yan > > > > Cc: dev@dpdk.org >

RE: [RFC] Define well known packet burst sizes

2024-10-12 Thread Pavan Nikhilesh Bhagavatula
> We should define some "well known" packet burst sizes in rte_config.h. > A while back we had the same idea, except that it should be platform specific Ex., for CNXK optimal burst size across workloads is 64. Instead of rte_config.h maybe we should have it as a meson option in meson_options.tx

RE: [EXTERNAL] Re: [PATCH v4 1/5] graph: add support for node specific errors

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> On Fri, Aug 16, 2024 at 5:10 PM wrote: > > > > From: Pavan Nikhilesh > > > > Add ability for Nodes to advertise error counters > > during registration. > > > > Signed-off-by: Pavan Nikhilesh > > Such a series deserve a cover letter. > > It also deserves a RN update, and I see no removal of t

RE: [EXTERNAL] Re: [PATCH v4 1/5] graph: add support for node specific errors

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> I forgot to mention. > > If you submit a v5, could you squash all commits that deal with > lib/graph into a single patch? Including the public API to increment the > nodes xstats? I will squash (2/5, 3/5), (4/5, 5/5) and leave 1/5 alone as it is a very big patch containing updates to svg fil

RE: [EXTERNAL] Re: [PATCH v4 4/5] node: add error stats for ip4 lookup node

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Robin Jarry > Sent: Friday, October 11, 2024 3:19 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; zhirun@intel.com; Wathsala Vithanage > ; Bruce Richardson > ;

RE: [EXTERNAL] Re: [PATCH v4 3/5] graph: add stats for node specific errors

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Robin Jarry > Sent: Friday, October 11, 2024 3:24 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; zhirun@intel.com; Zhirun Yan > > Cc: dev@dpdk.org > Subject

RE: [EXTERNAL] [PATCH v9 04/17] event/cnxk: fix free of non-heap in cleanup code

2024-10-08 Thread Pavan Nikhilesh Bhagavatula
> The code to cleanup in case of error would derefence null pointer > then pass that result to rte_free. > > Fixes: 97a05c1fe634 ("event/cnxk: add port config") > Cc: sthot...@marvell.com > Cc: sta...@dpdk.org > > Signed-off-by: Stephen Hemminger Thanks Stephen, Acked-by: Pavan Nikhilesh

RE: [EXTERNAL] Re: [PATCH v8 04/17] event/cnxk: fix pointer mismatch in cleanup

2024-10-08 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 8, 2024 10:10 PM > To: dev@dpdk.org > Cc: Shijith Thotton ; sta...@dpdk.org; Pavan > Nikhilesh Bhagavatula > Subject: [EXTERNAL] Re: [PATCH v8 04/17] event/cnxk: fix pointer mismatch > i

RE: [EXTERNAL] Re: [PATCH v7 1/6] eventdev: introduce event pre-scheduling

2024-10-06 Thread Pavan Nikhilesh Bhagavatula
> On Sat, 5 Oct 2024 13:29:56 +0530 > wrote: > > > +static int > > +preschedule_test(enum rte_event_dev_preschedule_type > preschedule_type, const char *preschedule_name) > > +{ > > +#define NB_EVENTS 1024 > > + uint64_t start, total; > > + struct rte_event ev; > > + int rc, cnt; > > +

RE: [EXTERNAL] Re: [PATCH v5 0/6] Introduce event pre-scheduling

2024-10-04 Thread Pavan Nikhilesh Bhagavatula
> > From: Pavan Nikhilesh > > > > Event pre-scheduling improves scheduling performance by assigning events > > to event ports in advance when dequeues are issued. > > This series introduces various types and levels of pre-scheduling to the > > eventdev library. > > > > pre-scheduling Types: > > *

RE: [EXTERNAL] [PATCH v7 04/16] event/cnxk: fix pointer mismatch in cleanup

2024-10-02 Thread Pavan Nikhilesh Bhagavatula
> The code to cleanup in case of error was passing incorrect > value to rte_free. The ports[] entry was allocated with > rte_malloc and that should be used instead of the offset > in that object. > > Fixes: 97a05c1fe634 ("event/cnxk: add port config") > Cc: sthot...@marvell.com > Cc: sta...@dpdk.o

RE: [EXTERNAL] Re: [PATCH v4 0/6] Introduce event pre-scheduling

2024-10-02 Thread Pavan Nikhilesh Bhagavatula
> > From: Pavan Nikhilesh > > > > Event pre-scheduling improves scheduling performance by assigning events > > to event ports in advance when dequeues are issued. > > This series introduces various types and levels of pre-scheduling to the > > eventdev library. > > Any numbers on how much this im

RE: [EXTERNAL] Re: [PATCH v2 1/3] eventdev: introduce event pre-scheduling

2024-09-26 Thread Pavan Nikhilesh Bhagavatula
> > -Original Message- > > From: Pavan Nikhilesh Bhagavatula > > Sent: Wednesday, September 25, 2024 6:30 AM > > To: Mattias Rönnblom ; Pathak, Pravin > > ; Jerin Jacob ; Shijith > Thotton > > ; Sevincer, Abdullah > ; > > hemant.agra..

RE: [EXTERNAL] Re: [PATCH v2 1/3] eventdev: introduce event pre-scheduling

2024-09-25 Thread Pavan Nikhilesh Bhagavatula
> On 2024-09-19 15:13, Pavan Nikhilesh Bhagavatula wrote: > >>> From: pbhagavat...@marvell.com > >>> Sent: Tuesday, September 17, 2024 3:11 AM > >>> To: jer...@marvell.com; sthot...@marvell.com; Sevincer, Abdullah > >>> ; hemant.agra...@nxp.com;

RE: [PATCH v2 1/3] eventdev: introduce event pre-scheduling

2024-09-19 Thread Pavan Nikhilesh Bhagavatula
> > From: pbhagavat...@marvell.com > > Sent: Tuesday, September 17, 2024 3:11 AM > > To: jer...@marvell.com; sthot...@marvell.com; Sevincer, Abdullah > > ; hemant.agra...@nxp.com; > > sachin.sax...@oss.nxp.com; Van Haaren, Harry > ; > > mattias.ronnb...@ericsson.com; lian...@liangbit.com; Mccarthy

RE: [EXTERNAL] Re: [RFC 0/3] Introduce event prefetching

2024-09-10 Thread Pavan Nikhilesh Bhagavatula
> On 2024-09-10 10:31, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Event prefetching improves scheduling performance by pre-scheduling > events to > > event ports when dequeues are issued. This series introduces various types > and > > levels of prefetching to the eventdev li

RE: [PATCH] examples/eventdev: fix segment fault with generic pipeline

2024-08-18 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Van Haaren, Harry > Sent: Thursday, August 1, 2024 6:14 PM > To: Chengwen Feng ; tho...@monjalon.net; > dev@dpdk.org > Cc: wangchenxin...@huawei.com; Pavan Nikhilesh Bhagavatula > > Subject: [EXTERNAL] Re: [PATCH] examples/eventdev

RE: [PATCH] doc: deprecate graph data structures

2024-07-18 Thread Pavan Nikhilesh Bhagavatula
Thomas, Ping can this deprecation notice be merged > Acked-by: Zhirun Yan > > > -Original Message- > > From: Nithin Dabilpuram > > Sent: Tuesday, March 19, 2024 1:21 PM > > To: pbhagavat...@marvell.com > > Cc: jer...@marvell.com; ndabilpu...@marvell.com; > kirankum...@marvell.com; >

RE: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

2024-07-05 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Wathsala Wathawana Vithanage > Sent: Friday, July 5, 2024 9:32 PM > To: Pavan Nikhilesh Bhagavatula ; > tho...@monjalon.net > Cc: Tyler Retzlaff ; Ruifeng Wang > ; dev@dpdk.org; nd ; Dhruv > Tripathi ; Honnappa Nagarahalli >

RE: [EXTERNAL] Re: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

2024-07-05 Thread Pavan Nikhilesh Bhagavatula
> 04/07/2024 16:55, Stephen Hemminger: > > On Thu, 04 Jul 2024 16:14:42 +0200 > > Thomas Monjalon wrote: > > > > > > > Let’s ask Pavan why this flag is used in cn10k driver. > > > > > > > > > > From our perspective, WFE is available on all the supported arm > platforms in > > > > > DPDK. > > > > >

RE: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

2024-07-04 Thread Pavan Nikhilesh Bhagavatula
> > 03/07/2024 15:27, Wathsala Wathawana Vithanage: > > > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED #ifdef block. > > > > > This patch fixes this issue by moving __RTE_ARM_WFE out of > > > > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED block. > > > > > > > > > > Perhaps we should change RTE_ARM_USE_WFE to somethi

RE: [EXTERNAL] Re: [PATCH v3 1/2] eventdev/dma: reorganize event DMA ops

2024-05-30 Thread Pavan Nikhilesh Bhagavatula
msi Krishna Attunuru > > > > > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > > > > > Subject: [PATCH v3 1/2] eventdev/dma: reorganize event DMA ops > > > > > > From: Pavan Nikhilesh > > > > > > Re-organize event DMA ops

RE: [EXTERNAL] Re: [PATCH v5] cnxk: disable building template files

2024-05-28 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, May 28, 2024 3:10 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; Sunil Kumar Kori ; Satha > Koteswara Rao Kottidi ; Harman K

RE: [EXTERNAL] Re: [PATCH v5] cnxk: disable building template files

2024-05-28 Thread Pavan Nikhilesh Bhagavatula
> On Mon, May 27, 2024 at 09:04:29PM +0530, pbhagavat...@marvell.com > wrote: > > From: Pavan Nikhilesh > > > > Disable building template files when CNXK_DIS_TMPLT_FUNC > > is defined as a part of c_args. > > This option can be used when reworking datapath or debugging > > issues to reduce Rx/Tx p

RE: [EXTERNAL] [PATCH v7 2/4] hash: optimize compare signature for NEON

2024-03-20 Thread Pavan Nikhilesh Bhagavatula
> Upon a successful comparison, NEON sets all the bits in the lane to 1 > We can skip shifting by simply masking with specific masks. > > Signed-off-by: Yoan Picchi > Reviewed-by: Ruifeng Wang > Reviewed-by: Nathan Brown > --- > lib/hash/arch/arm/compare_signatures.h | 24 +++--

RE: [EXTERNAL] Re: [PATCH] doc: deprecate graph data structures

2024-03-20 Thread Pavan Nikhilesh Bhagavatula
> On Tue, 19 Mar 2024 08:52:13 +0530 > Jerin Jacob wrote: > > > On Wed, Feb 21, 2024 at 9:43 PM wrote: > > > > > > From: Pavan Nikhilesh > > > > > > Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats > > > structures as will be extended to include node specific error counter

RE: [PATCH v7 1/3] config/arm: avoid mcpu and march conflicts

2024-03-06 Thread Pavan Nikhilesh Bhagavatula
: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [PATCH v7 1/3] config/arm: avoid mcpu and march conflicts > > From: Pavan Nikhilesh > > The compiler options march and mtune are a subset > of mcpu and will lead to conflicts if improper march > is chosen for a g

RE: [PATCH v3] app/eventdev: support DMA adapter test

2024-03-06 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Amit Prakash Shukla > Sent: Thursday, March 7, 2024 12:36 AM > To: Jerin Jacob > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > ; Vamsi Krishna Attunuru > ; Nithin Kumar Dabilpuram > ; Anoob Joseph ; Aakash > Sasidharan ; Amit

RE: [EXTERNAL] [PATCH] examples/l3fwd: fix Rx over not ready port

2024-03-01 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Konstantin Ananyev > Sent: Friday, March 1, 2024 10:43 PM > To: Pavan Nikhilesh Bhagavatula ; Konstantin > Ananyev ; dev@dpdk.org > Cc: Jerin Jacob ; sta...@dpdk.org > Subject: RE: [EXTERNAL] [PATCH] examples/l3fwd: fix R

RE: [EXTERNAL] [PATCH] examples/l3fwd: fix Rx over not ready port

2024-03-01 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Konstantin Ananyev > Sent: Friday, March 1, 2024 10:10 PM > To: dev@dpdk.org > Cc: Jerin Jacob ; Pavan Nikhilesh Bhagavatula > ; Konstantin Ananyev > ; sta...@dpdk.org > Subject: [EXTERNAL] [PATCH] examples/l3fwd: fix Rx over not re

RE: [PATCH v2] app/eventdev: support DMA adapter test

2024-03-01 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Amit Prakash Shukla > Sent: Wednesday, February 28, 2024 11:31 AM > To: Jerin Jacob > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > ; Vamsi Krishna Attunuru > ; Nithin Kumar Dabilpuram > ; Anoob Joseph ; Aakash > Sasid

RE: [EXT] [PATCH v1] app/test: fix segfault in Tx adapter autotest

2024-02-26 Thread Pavan Nikhilesh Bhagavatula
> Uninitialized mbufs are enqueued to eventdev which causes segfault > on freeing the mbuf in tx adapter. > Fixed by initializing mbufs before enqueuing to eventdev. > > Fixes: 46cf97e4bbfa ("eventdev: add test for eth Tx adapter") > > Signed-off-by: Ganapati Kundapura Acked-by: Pavan Nikhilesh

RE: [24.11 PATCH v3 1/5] graph: add support for node specific errors

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> > -Original Message- > > From: pbhagavat...@marvell.com > > Sent: Thursday, February 22, 2024 8:24 PM > > To: jer...@marvell.com; ndabilpu...@marvell.com; > kirankum...@marvell.com; > > Yan, Zhirun > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [24.11 PATCH v3 1/5] graph: add suppo

RE: [24.11 PATCH v3 4/5] node: add error stats for ip4 lookup node

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> > -Original Message- > > From: pbhagavat...@marvell.com > > Sent: Thursday, February 22, 2024 8:24 PM > > To: jer...@marvell.com; ndabilpu...@marvell.com; > kirankum...@marvell.com; > > Yan, Zhirun ; Pavan Nikhilesh > > ; Ruifeng Wang ; > > Richardson, Bruce ; Konstantin Ananyev > > > >

RE: [EXT] Re: [PATCH v5 2/3] config/arm: add support for fallback march

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> On Thu, Feb 22, 2024 at 1:45 PM wrote: > > > > From: Pavan Nikhilesh > > > > Some ARM CPUs have specific march requirements and > > are not compatible with the supported march list. > > Add fallback march in case the mcpu and the march > > advertised in the part_number_config are not supported

RE: [EXT] Re: [PATCH v5 1/3] config/arm: avoid mcpu and march conflicts

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Other than the one point below, > Reviewed-by: Juraj Linkeš > > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > index 36f21d2259..d05d54b564 100644 > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > > @@ -695,13 +698,37 @@ if update_flags > > > > mach

RE: [EXT] [PATCH v4 12/12] eventdev: fix doxygen processing of event vector struct

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> The event vector struct was missing comments on two members, and also > was inadvertently creating a local variable called "__rte_aligned" in > the doxygen output. > > Correct the comment markers to fix the former issue, and fix the latter > by putting "#ifdef __DOXYGEN" around the alignment con

RE: [EXT] [PATCH v4 11/12] eventdev: drop comment for anon union from doxygen

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Make the comments on the unnamed unions in the rte_event structure > regular comments rather than doxygen ones. The comments do not add > anything meaningful to the doxygen output. > > Signed-off-by: Bruce Richardson Acked-by: Pavan Nikhilesh > --- > lib/eventdev/rte_eventdev.h | 4 ++-- >

RE: [EXT] [PATCH v4 10/12] eventdev: clarify docs on event object fields and op types

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Clarify the meaning of the NEW, FORWARD and RELEASE event types. > For the fields in "rte_event" struct, enhance the comments on each to > clarify the field's use, and whether it is preserved between enqueue and > dequeue, and it's role, if any, in scheduling. > > Signed-off-by: Bruce Richardson

RE: [EXT] [PATCH v4 09/12] eventdev: improve comments on scheduling types

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> The description of ordered and atomic scheduling given in the eventdev > doxygen documentation was not always clear. Try and simplify this so > that it is clearer for the end-user of the application > > Signed-off-by: Bruce Richardson > Acked-by: Pavan Nikhilesh > --- > V4: reworked follow

RE: [EXT] [PATCH v4 07/12] eventdev: improve doxygen comments on config fns

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Monday, February 26, 2024 12:13 PM > To: Bruce Richardson ; dev@dpdk.org; Jerin > Jacob ; mattias.ronnb...@ericsson.com > Subject: RE: [EXT] [PATCH v4 07/12] eventdev: improve doxygen comments > on conf

RE: [EXT] [PATCH v4 08/12] eventdev: improve doxygen comments for control APIs

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> The doxygen comments for the port attributes, start and stop (and > related functions) are improved. > > Signed-off-by: Bruce Richardson Acked-by: Pavan Nikhilesh > > --- > V3: add missing "." on end of sentences/lines. > --- > lib/eventdev/rte_eventdev.h | 47 +++--

RE: [EXT] [PATCH v4 07/12] eventdev: improve doxygen comments on config fns

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Improve the documentation text for the configuration functions and > structures for configuring an eventdev, as well as ports and queues. > Clarify text where possible, and ensure references come through as links > in the html output. > > Signed-off-by: Bruce Richardson Pavan Nikhilesh > >

RE: [EXT] [PATCH v4 06/12] eventdev: improve doxygen comments on configure struct

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> General rewording and cleanup on the rte_event_dev_config structure. > Improved the wording of some sentences and created linked > cross-references out of the existing references to the dev_info > structure. > > As part of the rework, fix issue with how single-link port-queue pairs > were counte

RE: [EXT] [PATCH v4 05/12] eventdev: improve function documentation for query fns

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> General improvements to the doxygen docs for eventdev functions for > querying basic information: > * number of devices > * id for a particular device > * socket id of device > * capability information for a device > > Signed-off-by: Bruce Richardson > Acked-by: Pavan Nikhilesh > --- > V3:

RE: [EXT] [PATCH v4 04/12] eventdev: cleanup doxygen comments on info structure

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Some small rewording changes to the doxygen comments on struct > rte_event_dev_info. > > Signed-off-by: Bruce Richardson Acked-by: Pavan Nikhilesh > > --- > V3: reworked following feedback > - added closing "." on comments > - added more cross-reference links > - reworded priority level com

RE: [EXT] [PATCH v4 03/12] eventdev: update documentation on device capability flags

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Update the device capability docs, to: > > * include more cross-references > * split longer text into paragraphs, in most cases with each flag having > a single-line summary at the start of the doc block > * general comment rewording and clarification as appropriate > > Signed-off-by: Bruce R

RE: [EXT] [PATCH v4 02/12] eventdev: move text on driver internals to proper section

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Inside the doxygen introduction text, some internal details of how > eventdev works was mixed in with application-relevant details. Move > these details on probing etc. to the driver-relevant section. > > Signed-off-by: Bruce Richardson Acked-by: Pavan Nikhilesh > --- > lib/eventdev/rte_eve

RE: [EXT] [PATCH v4 01/12] eventdev: improve doxygen introduction text

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Make some textual improvements to the introduction to eventdev and event > devices in the eventdev header file. This text appears in the doxygen > output for the header file, and introduces the key concepts, for > example: events, event devices, queues, ports and scheduling. > > This patch makes

RE: [EXT] Re: [PATCH v4 2/3] config/arm: add support for fallback march

2024-02-22 Thread Pavan Nikhilesh Bhagavatula
> On Wed, Feb 21, 2024 at 9:20 PM wrote: > > > > From: Pavan Nikhilesh > > > > Some ARM CPUs have specific march requirements and > > are not compatible with the supported march list. > > Add fallback march in case the mcpu and the march > > advertised in the part_number_config are not supported

RE: [EXT] Re: [PATCH v4 1/3] config/arm: avoid mcpu and march conflicts

2024-02-22 Thread Pavan Nikhilesh Bhagavatula
> > diff --git a/config/arm/meson.build b/config/arm/meson.build > > index 36f21d2259..e77b696d8e 100644 > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > > @@ -695,13 +698,31 @@ if update_flags > > > > machine_args = [] # Clear previous machine args > > > > +candidate

RE: [PATCH v2 3/3] config/arm: allow WFE to be enabled config time

2024-02-10 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Honnappa Nagarahalli > Sent: Saturday, February 10, 2024 10:07 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob ; juraj.lin...@pantheon.tech; nd > ; Ruifeng Wang ; Bruce Richardson > ; dev@dpdk.org; Chengwen Feng > ; Wath

RE: [PATCH v3 1/3] config/arm: avoid mcpu and march conflicts

2024-02-09 Thread Pavan Nikhilesh Bhagavatula
> > > wrote: > > > > > > > > Hi Pavan, > > > > > > > >> The compiler options march and mtune are a subset of mcpu and will > > > >> lead > > > to > > > >> conflicts if improper march is chosen for a given mcpu. > > > >> To avoid conflicts, force part number march when mcpu is available > > > >> a

RE: [PATCH v2 3/3] config/arm: allow WFE to be enabled config time

2024-02-09 Thread Pavan Nikhilesh Bhagavatula
> > On Feb 1, 2024, at 3:57 PM, pbhagavat...@marvell.com wrote: > > > > From: Pavan Nikhilesh > > > > Allow RTE_ARM_USE_WFE to be enabled at meson configuration > > time by passing it via c_args instead of modifying > > `config/arm/meson.build`. > > > > Example usage: > > meson build -Dc_args='-DR

RE: [EXT] Re: [PATCH] dmadev: standardize alignment and allocation

2024-02-09 Thread Pavan Nikhilesh Bhagavatula
> Hi Pavan, > > Alloc fp_objects from rte_memory is a good idea, but this may cause > the rte_memory memory leak, especially in multi-process scenario. > > Currently, there is no mechanism for releasing such a rte_memory which > don't belong to any driver. > Yeah, secondary process will leak rte

RE: [PATCH v3 1/3] config/arm: avoid mcpu and march conflicts

2024-02-06 Thread Pavan Nikhilesh Bhagavatula
> > On Feb 5, 2024, at 10:10 PM, Wathsala Wathawana Vithanage > wrote: > > > > Hi Pavan, > > > >> The compiler options march and mtune are a subset of mcpu and will lead > to > >> conflicts if improper march is chosen for a given mcpu. > >> To avoid conflicts, force part number march when mcpu is

RE: [EXT] Re: [PATCH 1/2] config/arm: avoid mcpu and march conflicts

2024-01-30 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Juraj Linkeš > Sent: Monday, January 29, 2024 2:15 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob ; ruifeng.w...@arm.com; > n...@arm.com; Bruce Richardson ; > dev@dpdk.org > Subject: Re: [EXT] Re: [PATCH 1/2] config/a

RE: [EXT] Re: [PATCH 2/2] config/arm: add support for fallback march

2024-01-24 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Juraj Linkeš > Sent: Monday, January 22, 2024 9:59 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob ; ruifeng.w...@arm.com; > n...@arm.com; Bruce Richardson ; > dev@dpdk.org > Subject: Re: [EXT] Re: [PATCH 2/2] config/arm:

RE: [EXT] Re: [PATCH 1/2] config/arm: avoid mcpu and march conflicts

2024-01-24 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Juraj Linkeš > Sent: Monday, January 22, 2024 9:57 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob ; ruifeng.w...@arm.com; > n...@arm.com; Bruce Richardson ; > dev@dpdk.org > Subject: Re: [EXT] Re: [PATCH 1/2] config/a

RE: [EXT] Re: [PATCH 2/2] config/arm: add support for fallback march

2024-01-22 Thread Pavan Nikhilesh Bhagavatula
> On Sun, Jan 21, 2024 at 10:37 AM wrote: > > > > From: Pavan Nikhilesh > > > > Some ARM CPUs have specific march requirements and > > are not compatible with the supported march list. > > Add fallback march in case the mcpu and the march > > advertised in the part_number_config are not supported

RE: [EXT] Re: [PATCH 1/2] config/arm: avoid mcpu and march conflicts

2024-01-22 Thread Pavan Nikhilesh Bhagavatula
> On Sun, Jan 21, 2024 at 10:37 AM wrote: > > > > From: Pavan Nikhilesh > > > > The compiler options march and mtune are a subset > > of mcpu and will lead to conflicts if improper march > > is chosen for a given mcpu. > > To avoid conflicts, force part number march when > > mcpu is available and

RE: [EXT] Re: [PATCH 2/2] config/arm: add armv9-a march

2024-01-19 Thread Pavan Nikhilesh Bhagavatula
> On 2024/1/4 5:18 PM, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Now that major versions of GCC recognize armv9-a march option, > > add it to the list of supported march. > > Update neoverse-n2 part number to include march as armv9-a. > > > > Signed-off-by: Pavan Nikhilesh

RE: [EXT] Re: [PATCH 1/2] config/arm: fix CN10K minimum march requirement

2024-01-19 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Ruifeng Wang > Sent: Thursday, January 18, 2024 7:32 AM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > ; Bruce Richardson > Cc: dev@dpdk.org; sta...@dpdk.org; n...@arm.com > Subject: [EXT] Re: [PATCH 1/2] config/arm: fix CN10K minimu

  1   2   3   4   5   6   >