Re: [PATCH] maintainers: update for DTS

2025-07-23 Thread Paul Szczepanek
Don't think I can "elect" anyone but we did discuss it with other maintainers during the recent release meeting and motion was seconded by Bruce (I think) and run unopposed. Acked-by: Paul Szczepanek On 22/07/2025 17:04, Patrick Robb wrote: > Acked-by: Patrick Robb mailto

[RFC] Proposal for stable developer-friendly DTS API

2025-07-14 Thread Paul Szczepanek
Hi all, Now that we've written a significant number of tests and developed a consistent usage pattern, I think it's a good time to take the next step toward project maturity: establishing a stable, well-defined API that developers can rely on across releases. We got some comments from the devs pr

Re: [PATCH 1/1] dts: fix deterministic doc

2025-06-09 Thread Paul Szczepanek
Thanks. This needs to pass the linter, see my suggestions below. On 06/06/2025 10:35, Clemens Famulla-Conrad wrote: > +capture_name: str = None, +capture_name: str = "", > +if capture_name is None: > +capture_name = _get_default_capture_name() > + +if

Re: [PATCH v1 1/3] dts: rewrite README

2025-05-29 Thread Paul Szczepanek
Pls fix warning and I will merge On 27/05/2025 16:37, Dean Marx wrote: > Remove unnecessary information from README.md, and add new sections to clarify > the purpose/use of DTS along with clear setup instructions. > > Signed-off-by: Dean Marx > --- > dts/README.md | 104 +++-

Re: [PATCH v1 3/3] dts: fix doc generation bug

2025-05-29 Thread Paul Szczepanek
Patrick is right but it's OK, I'll merge as part of the series - in the end it's a separate commit. Reviewed-by: Paul Szczepanek On 28/05/2025 21:28, Patrick Robb wrote: > > > On Tue, May 27, 2025 at 11:37 AM Dean Marx <mailto:dm...@iol.unh.edu>> wrote: >

Re: [PATCH v1 1/3] dts: rewrite README

2025-05-29 Thread Paul Szczepanek
Reviewed-by: Paul Szczepanek On 28/05/2025 21:40, Patrick Robb wrote: > > > On Tue, May 27, 2025 at 11:37 AM Dean Marx <mailto:dm...@iol.unh.edu>> wrote: > > Remove unnecessary information from README.md, and add new sections > to clarify > the purpo

Re: [PATCH v1 2/3] dts: rewrite dts rst

2025-05-29 Thread Paul Szczepanek
I think shortening it is great, less maintenance overhead and avoids going out of sync with code which is already plenty documented. Reviewed-by: Paul Szczepanek On 28/05/2025 22:25, Patrick Robb wrote: > > > On Tue, May 27, 2025 at 11:37 AM Dean Marx <mailto:dm...@iol.unh

Re: [PATCH] dts: automatically bring up link on interfaces

2025-01-27 Thread Paul Szczepanek
Reviewed-by: Paul Szczepanek

Re: [PATCH v1] dts: bug fixes for paramiko timeout and buffered_pipe issues

2025-01-24 Thread Paul Szczepanek
Reviewed-by: Paul Szczepanek

Re: [PATCH v1] dts: fix multicast set function in testpmd shell

2025-01-24 Thread Paul Szczepanek
> +if on ^ all(stats.is_allmulticast_mode_enabled for stats in > port_stats): > self._logger.debug( > f"Failed to set multicast mode on all ports.: > \n{multicast_cmd_output}" > ) Reviewed-by: Paul Szczepanek

Re: [PATCH v1] dts: fix checksum suite docstring/variable format

2025-01-22 Thread Paul Szczepanek
Reviewed-by: Paul Szczepanek On 16/01/2025 18:43, Dean Marx wrote: > Fixes checksum offload test suite docstring format > by adding steps and verify sections. Changes variables > formatted in camel case to snake case to fit python standards. > > Fixes: 8c9a7471a0e6 ("dts:

Re: [PATCH v5] dts: reform hello world test suite

2025-01-15 Thread Paul Szczepanek
I think it makes sense to keep logger private and separate. I can see one reason - we can change the logger in the framework without affecting the tests. We can also decide to not use the logger to print test suites messages - for example save per test artifacts. On 15/01/2025 10:17, Luca Vizzarro

[PATCH v9] dts: add offload version of buffer scatter test

2025-01-10 Thread Paul Szczepanek
testing without the offload, so an expansion of coverage is needed to cover the second case as well. Signed-off-by: Jeremy Spewock Signed-off-by: Paul Szczepanek Reviewed-by: Luca Vizzarro --- dts/tests/TestSuite_pmd_buffer_scatter.py | 49 ++- 1 file changed, 30 insertions

[PATCH v4 2/2] dts: add dual VLAN test suite

2025-01-09 Thread Paul Szczepanek
From: Jeremy Spewock Test functionality of VLAN functions such as stripping, inserting and filtering with two tags present. Signed-off-by: Jeremy Spewock Signed-off-by: Paul Szczepanek --- dts/tests/TestSuite_dual_vlan.py | 287 +++ 1 file changed, 287 insertions

[PATCH v4 1/2] dts: add stop ports decorator for VLAN functions

2025-01-09 Thread Paul Szczepanek
Testpmd functions manipulating the VLAN options require the ports to be stopped when applying changes. Signed-off-by: Paul Szczepanek --- dts/framework/remote_session/testpmd_shell.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts

Re: [RFC v1 1/1] dts: split enums from primary json schema

2025-01-08 Thread Paul Szczepanek
On 07/08/2024 15:08, Nicholas Pratte wrote: > Separating enums from the primary json schema might make it easier for > incoming DTS developers and users to quickly identify what values are > allowed in the config yaml file with relative ease. Moreover, separating > values, such as available test su

Re: [PATCH v4] dts: reform hello world test suite

2025-01-08 Thread Paul Szczepanek
On 07/01/2025 21:34, Dean Marx wrote:> +with TestPmdShell(node=self.sut_node) as testpmd: > +testpmd.start() > +self._logger.log(1, "Hello World!") You should not be using private members like _logger you can use get_dts_logger to get the logger but honestly I think we

[PATCH v3 3/3] dts: resolve mypy type errors

2025-01-03 Thread Paul Szczepanek
From: Luca Vizzarro The addition of scapy types yielded new errors in mypy, which could not previously be checked. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- .../interactive_remote_session.py | 4 ++-- .../single_active_interactive_shell.py| 2 +- dts

[PATCH v3 2/3] dts: add missing type stubs

2025-01-03 Thread Paul Szczepanek
Vizzarro Reviewed-by: Paul Szczepanek --- dts/poetry.lock| 27 ++- dts/pyproject.toml | 4 +++- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/dts/poetry.lock b/dts/poetry.lock index 1eae7ea2fb..29f9a18cd6 100644 --- a/dts/poetry.lock +++ b/dts

[PATCH v2 2/2] dts: add softnic test

2024-12-31 Thread Paul Szczepanek
Add test that uses a softnic virtual device to forward packets. Signed-off-by: Thomas Wilks Signed-off-by: Paul Szczepanek --- dts/tests/TestSuite_softnic.py | 119 + 1 file changed, 119 insertions(+) create mode 100644 dts/tests/TestSuite_softnic.py diff

[PATCH v2 1/2] dts: allow expected packets to come from the TG

2024-12-31 Thread Paul Szczepanek
Add sent_from_tg variable to get_expected_packets for when packets are sent from the TG. Signed-off-by: Thomas Wilks Signed-off-by: Paul Szczepanek --- dts/framework/test_suite.py | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/dts/framework

[PATCH v1 1/2] dts: allow expected packets to come from the TG

2024-12-31 Thread Paul Szczepanek
Add sent_from_tg variable to get_expected_packets for when packets are sent from the TG. Signed-off-by: Thomas Wilks Signed-off-by: Paul Szczepanek --- dts/framework/test_suite.py | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/dts/framework

[PATCH v1 2/2] dts: add softnic test

2024-12-31 Thread Paul Szczepanek
Add test that uses a softnic virtual device to froward packets. Signed-off-by: Thomas Wilks Signed-off-by: Paul Szczepanek --- dts/tests/TestSuite_softnic.py | 119 + 1 file changed, 119 insertions(+) create mode 100644 dts/tests/TestSuite_softnic.py diff

Re: [PATCH v2 0/7] dts: add Ruff and docstring linting

2024-12-27 Thread Paul Szczepanek
Looks like we missed each other, in which case I'll merge it on Monday. On 20/12/2024 23:14, Patrick Robb wrote: > Series-reviewed-by: Patrick Robb > > Tested-by: Patrick Robb mailto:pr...@iol.unh.edu>> > > Paul I will merge to next-dts now instead of waiting until afte

Re: [PATCH v1 1/1] dts: add EAL sanity check suite

2024-12-20 Thread Paul Szczepanek
estpmd session is alive after starting. > + """ > +with TestPmdShell(node=self.sut_node) as testpmd: > +testpmd.start() > +self.verify(True, "True") Not sure the self.verify(True, "True") is needed. Reviewed-by: Paul Szczepanek

Re: [PATCH v4] dts: remove nested html dir for API doc

2024-11-29 Thread Paul Szczepanek
On 29/11/2024 11:54, Thomas Monjalon wrote: > From: Paul Szczepanek > > To facilitate deploying docs to the website > and make paths more consistent remove the html > directory from docs nested in API html directory. > > Signed-off-by: Paul Szczepanek > Reviewed-by:

[PATCH v3] dts: remove html dir from nested docs

2024-11-28 Thread Paul Szczepanek
To facilitate deploying docs to the website and make paths more consistent remove the html directory from docs nested in html directories. Signed-off-by: Paul Szczepanek Reviewed-by: Luca Vizzarro --- buildtools/call-sphinx-build.py | 6 -- doc/api/meson.build | 2 +- 2 files

[PATCH v2] docs: remove html dir from nested docs

2024-11-27 Thread Paul Szczepanek
To facilitate deploying docs to the website and make paths more consistent remove the html directory from nested docs. Signed-off-by: Paul Szczepanek Reviewed-by: Luca Vizzarro --- buildtools/call-sphinx-build.py | 7 +-- doc/api/meson.build | 2 +- 2 files changed, 6

[PATCH] dts: remove html dir from dts doc path

2024-11-26 Thread Paul Szczepanek
To facilitate deploying docs to the website and make paths more consistent remove the html directory from the dts doc path. Signed-off-by: Paul Szczepanek Reviewed-by: Luca Vizzarro --- buildtools/call-sphinx-build.py | 5 +++-- doc/api/meson.build | 2 +- 2 files changed, 4

[PATCH] dts: remove redundant test suite

2024-11-15 Thread Paul Szczepanek
eš Signed-off-by: Paul Szczepanek --- dts/framework/test_suite.py | 36 - dts/framework/testbed_model/linux_session.py | 22 +--- dts/framework/testbed_model/node.py | 2 - dts/framework/testbed_model/os_session.py| 34 dts/framework/tes

[PATCH] dts: remove external dependency on python docs

2024-11-08 Thread Paul Szczepanek
Sphinx can link to online python docs but doing so creates a requirement for an internet connection. This commit removes this dependency. Signed-off-by: Paul Szczepanek Reviewed-by: Luca Vizzarro --- doc/guides/conf.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/doc

Re: [PATCH v1] dts: add time delay to async sniffer callback function

2024-11-06 Thread Paul Szczepanek
On 30/10/2024 17:08, Nicholas Pratte wrote: > There exists a bug within i40e NICs in which the async sniffer does not > catch send packets as a result of the callback function sending packets > too quickly before the NICs are ready to start capturing. > > There could be a multitude of reasons wh

[PATCH v2] dts: fix doxygen API link and DTS docs placement

2024-10-25 Thread Paul Szczepanek
ation") Signed-off-by: Paul Szczepanek Acked-by: Patrick Robb --- buildtools/call-sphinx-build.py | 3 +++ doc/api/dts/meson.build | 12 +--- doc/api/meson.build | 7 --- 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/buildtools/call-sphin

Re: [PATCH] dts: fix doxygen API link

2024-10-24 Thread Paul Szczepanek
On 24/10/2024 10:12, David Marchand wrote: >> >> Looking again while applying, something is fishy in doc/api/meson.build: >> >> if not doxygen.found() >> # process DTS API doc build even if DPDK API doc build can't be done >> cdata = configuration_data() >> subdir('dts') >> subdir_done() >>

[PATCH] dts: fix doxygen API link

2024-10-23 Thread Paul Szczepanek
Alias used to produce the link to the DTS API docs uses config data. The required value in config data was being added in the wrong scope. This moves the key addition to where the config data object is created. Fixes: 7f9326423a04 ("dts: add API doc generation") Signed-off-by: Paul

Re: [PATCH v2 0/7] DTS external DPDK build

2024-10-22 Thread Paul Szczepanek
On 21/10/2024 23:39, Dean Marx wrote: > Hi Luca, > > I noticed in the new version of this series the "improve statistics" > patch was taken out, was there any reason for this? I believe Juraj > wanted to create a feature that wrote all of the test suite/case > summaries in a JSON/text output file

Re: [PATCH] maintainers: update for dts

2024-10-09 Thread Paul Szczepanek
(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 812463fe9f..5c8402707a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1889,7 +1889,8 @@ F: app/proc-info/ > F: doc/guides/tools/proc_info.rst > > DTS > -M: Juraj Linkeš > +M: Paul Szczepanek > +M: Patric

Re: [PATCH v7 4/4] test-pmd: add more packet verbose decode options

2024-08-22 Thread Paul Szczepanek
On 20/08/2024 16:54, Stephen Hemminger wrote: > On Tue, 20 Aug 2024 14:42:56 +0100 > Alex Chapman wrote: > >> Hi Stephen, >> >> I have gone through your patch series and the hexdump option would be >> quite valuable for use in DTS. >> >> However I am currently facing the issue of distinguishing

[PATCH v1] ptr_compress: fix offset to use portable type

2024-06-19 Thread Paul Szczepanek
Fix the type of offset to use portable uintptr_t instead of uint64_t. Fixes: 077596a4b077 ("ptr_compress: add pointer compression library") Reviewed-by: Nick Connolly Signed-off-by: Paul Szczepanek --- lib/ptr_compress/rte_ptr_compress.h | 6 +++--- 1 file changed, 3 insert

Re: [PATCH v15 0/6] add pointer compression API

2024-06-17 Thread Paul Szczepanek
On 17/06/2024 11:02, David Marchand wrote: > Hello Paul, > > On Fri, Jun 14, 2024 at 12:28 PM David Marchand > wrote: >> Even if this library only contains a header, with no tie to other >> public DPDK API, this library should be optional. >> If no objection, please work on this change for -rc

Re: [PATCH v14 3/6] ptr_compress: add pointer compression library

2024-06-11 Thread Paul Szczepanek
On 10/06/2024 16:18, David Marchand wrote: > Hello, > > On Fri, Jun 7, 2024 at 5:10 PM Paul Szczepanek > wrote: >> >> Add a new utility header for compressing pointers. The provided >> functions can store pointers as 32-bit or 16-bit offsets. >> >> T

Re: [PATCH v14 2/6] mempool: add functions to get extra mempool info

2024-06-11 Thread Paul Szczepanek
On 10/06/2024 15:24, Konstantin Ananyev wrote: [snip] > > With that changes in place: > Acked-by: Konstantin Ananyev > I have applied your comments in v15. [snip] >> + >> +size_t rte_mempool_get_obj_alignment(const struct rte_mempool *mp) >> +{ >> +if (mp == NULL) >> +retur

[PATCH v15 6/6] test: add unit test for ptr compression

2024-06-11 Thread Paul Szczepanek
Test compresses and decompresses pointers with various combinations of memory regions and alignments and verifies the pointers are recovered correctly. Additionally tests helper macros perform calculations correctly. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by

[PATCH v15 4/6] test: add pointer compress tests to ring perf test

2024-06-11 Thread Paul Szczepanek
. Added more bulk sizes to showcase their effects on compression. Adjusted loop iteration numbers to take into account bulk sizes to keep runtime constant (instead of number of operations). Adjusted old printfs to match new ones which have aligned numbers. Signed-off-by: Paul Szczepanek Reviewed-by

[PATCH v15 5/6] docs: add pointer compression guide

2024-06-11 Thread Paul Szczepanek
Documentation added in the prog guide for the new utility functions for pointer compression showing example code and potential usecases. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by: Nathan Brown Reviewed-by: Jack Bond-Preston --- MAINTAINERS

[PATCH v15 3/6] ptr_compress: add pointer compression library

2024-06-11 Thread Paul Szczepanek
from a base memory address. Offsets can be stored in fewer bytes (dictated by the memory region size and alignment of the pointer). For example: an 8 byte aligned pointer which is part of a 32GB memory pool can be stored in 4 bytes. Suggested-by: Honnappa Nagarahalli Signed-off-by: Paul Szczepanek

[PATCH v15 2/6] mempool: add functions to get extra mempool info

2024-06-11 Thread Paul Szczepanek
Add two functions: - rte_mempool_get_mem_range - get virtual memory range of the objects in the mempool, - rte_mempool_get_obj_alignment - get alignment of objects in the mempool. Add two tests that test these new functions. Signed-off-by: Paul Szczepanek Reviewed-by: Jack Bond-Preston

[PATCH v15 0/6] add pointer compression API

2024-06-11 Thread Paul Szczepanek
rte_mempool_get_mem_range in a struct * added consts to function parameters where appropriate v15 * fix whitespace in rel notes * move parameter check to after variable declaration * change the naming of the range variable in macros * improve doxygen Paul Szczepanek (6): lib: allow libraries with no

[PATCH v15 1/6] lib: allow libraries with no sources

2024-06-11 Thread Paul Szczepanek
Allow header only libraries. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Acked-by: Bruce Richardson --- lib/meson.build | 16 1 file changed, 16 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 179a272932..7c90602bf5 100644 --- a/lib

Re: [PATCH v13 2/6] mempool: add functions to get extra mempool info

2024-06-07 Thread Paul Szczepanek
On 06/06/2024 13:28, Konstantin Ananyev wrote: > > >> Add two functions: >> - rte_mempool_get_mem_range - get virtual memory range >> of the objects in the mempool, >> - rte_mempool_get_obj_alignment - get alignment of >> objects in the mempool. >> >> Add two tests that test these new functions

[PATCH v14 6/6] test: add unit test for ptr compression

2024-06-07 Thread Paul Szczepanek
Test compresses and decompresses pointers with various combinations of memory regions and alignments and verifies the pointers are recovered correctly. Additionally tests helper macros perform calculations correctly. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by

[PATCH v14 5/6] docs: add pointer compression guide

2024-06-07 Thread Paul Szczepanek
Documentation added in the prog guide for the new utility functions for pointer compression showing example code and potential usecases. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by: Nathan Brown Reviewed-by: Jack Bond-Preston --- MAINTAINERS

[PATCH v14 4/6] test: add pointer compress tests to ring perf test

2024-06-07 Thread Paul Szczepanek
. Added more bulk sizes to showcase their effects on compression. Adjusted loop iteration numbers to take into account bulk sizes to keep runtime constant (instead of number of operations). Adjusted old printfs to match new ones which have aligned numbers. Signed-off-by: Paul Szczepanek Reviewed-by

[PATCH v14 3/6] ptr_compress: add pointer compression library

2024-06-07 Thread Paul Szczepanek
from a base memory address. Offsets can be stored in fewer bytes (dictated by the memory region size and alignment of the pointer). For example: an 8 byte aligned pointer which is part of a 32GB memory pool can be stored in 4 bytes. Suggested-by: Honnappa Nagarahalli Signed-off-by: Paul Szczepanek

[PATCH v14 2/6] mempool: add functions to get extra mempool info

2024-06-07 Thread Paul Szczepanek
Add two functions: - rte_mempool_get_mem_range - get virtual memory range of the objects in the mempool, - rte_mempool_get_obj_alignment - get alignment of objects in the mempool. Add two tests that test these new functions. Signed-off-by: Paul Szczepanek Reviewed-by: Jack Bond-Preston

[PATCH v14 1/6] lib: allow libraries with no sources

2024-06-07 Thread Paul Szczepanek
Allow header only libraries. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Acked-by: Bruce Richardson --- lib/meson.build | 16 1 file changed, 16 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 179a272932..7c90602bf5 100644 --- a/lib

[PATCH v14 0/6] add pointer compression API

2024-06-07 Thread Paul Szczepanek
rte_mempool_get_mem_range in a struct * added consts to function parameters where appropriate Paul Szczepanek (6): lib: allow libraries with no sources mempool: add functions to get extra mempool info ptr_compress: add pointer compression library test: add pointer compress tests to ring perf test

Re: [PATCH v13 6/6] test: add unit test for ptr compression

2024-06-04 Thread Paul Szczepanek
Recheck-request: iol-unit-amd64-testing

Re: [PATCH v13 6/6] test: add unit test for ptr compression

2024-06-04 Thread Paul Szczepanek
Recheck-request: github-robot

Re: [PATCH v13 0/6] add pointer compression API

2024-06-04 Thread Paul Szczepanek
Recheck-request: iol-unit-amd64-testing

Re: [PATCH v13 0/6] add pointer compression API

2024-05-30 Thread Paul Szczepanek
Recheck-request: github-robot

[PATCH v13 5/6] docs: add pointer compression guide

2024-05-30 Thread Paul Szczepanek
Documentation added in the prog guide for the new utility functions for pointer compression showing example code and potential usecases. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by: Nathan Brown Reviewed-by: Jack Bond-Preston --- MAINTAINERS

[PATCH v13 4/6] test: add pointer compress tests to ring perf test

2024-05-30 Thread Paul Szczepanek
. Added more bulk sizes to showcase their effects on compression. Adjusted loop iteration numbers to take into account bulk sizes to keep runtime constant (instead of number of operations). Adjusted old printfs to match new ones which have aligned numbers. Signed-off-by: Paul Szczepanek Reviewed-by

[PATCH v13 6/6] test: add unit test for ptr compression

2024-05-30 Thread Paul Szczepanek
Test compresses and decompresses pointers with various combinations of memory regions and alignments and verifies the pointers are recovered correctly. Additionally tests helper macros perform calculations correctly. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by

[PATCH v13 3/6] ptr_compress: add pointer compression library

2024-05-30 Thread Paul Szczepanek
from a base memory address. Offsets can be stored in fewer bytes (dictated by the memory region size and alignment of the pointer). For example: an 8 byte aligned pointer which is part of a 32GB memory pool can be stored in 4 bytes. Suggested-by: Honnappa Nagarahalli Signed-off-by: Paul Szczepanek

[PATCH v13 2/6] mempool: add functions to get extra mempool info

2024-05-30 Thread Paul Szczepanek
Add two functions: - rte_mempool_get_mem_range - get virtual memory range of the objects in the mempool, - rte_mempool_get_obj_alignment - get alignment of objects in the mempool. Add two tests that test these new functions. Signed-off-by: Paul Szczepanek Reviewed-by: Jack Bond-Preston

[PATCH v13 0/6] add pointer compression API

2024-05-30 Thread Paul Szczepanek
* added doxygen and prefixes to macros * use rte_bitops for clz and ctz * added unit tests to verify macros * fixed incorrect letter case in docs v13 * added contiguous parameter to rte_mempool_get_mem_range * made rte_mempool_get_mem_range parameters optional Paul Szczepanek (6): lib: allow

[PATCH v13 1/6] lib: allow libraries with no sources

2024-05-30 Thread Paul Szczepanek
Allow header only libraries. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Acked-by: Bruce Richardson --- lib/meson.build | 16 1 file changed, 16 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 179a272932..7c90602bf5 100644 --- a/lib

Re: [PATCH v12 2/6] mempool: add functions to get extra mempool info

2024-05-29 Thread Paul Szczepanek
On 29/05/2024 14:56, Morten Brørup wrote: >> From: Paul Szczepanek [mailto:paul.szczepa...@arm.com] >> Sent: Wednesday, 29 May 2024 12.23 >> >> Add two functions: >> - rte_mempool_get_mem_range - get virtual memory range >> of the objects in the mempool, >

Re: [PATCH] mempool: dump includes list of memory chunks

2024-05-29 Thread Paul Szczepanek
common_count = rte_mempool_ops_get_count(mp); > if ((cache_count + common_count) > mp->size) It's useful information to dump. Maybe consider adding something akin to RTE_LIBRTE_MEMPOOL_STATS to gate this in case the prints are overwhelming due to high list element number. Reviewed-by: Paul Szczepanek

Re: [PATCH v5 0/4] add pointer compression API

2024-05-29 Thread Paul Szczepanek
On 28/05/2024 20:29, Paul Szczepanek wrote: > > > On 24/05/2024 10:09, Konstantin Ananyev wrote: >> >> >>> I have added macros to help find the parameters and I have added mempool >>> functions that allow you to determine if you can use the mempoo

[PATCH v12 5/6] docs: add pointer compression guide

2024-05-29 Thread Paul Szczepanek
Documentation added in the prog guide for the new utility functions for pointer compression showing example code and potential usecases. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by: Nathan Brown Reviewed-by: Jack Bond-Preston --- MAINTAINERS

[PATCH v12 6/6] test: add unit test for ptr compression

2024-05-29 Thread Paul Szczepanek
Test compresses and decompresses pointers with various combinations of memory regions and alignments and verifies the pointers are recovered correctly. Additionally tests helper macros perform calculations correctly. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by

[PATCH v12 3/6] ptr_compress: add pointer compression library

2024-05-29 Thread Paul Szczepanek
from a base memory address. Offsets can be stored in fewer bytes (dictated by the memory region size and alignment of the pointer). For example: an 8 byte aligned pointer which is part of a 32GB memory pool can be stored in 4 bytes. Suggested-by: Honnappa Nagarahalli Signed-off-by: Paul Szczepanek

[PATCH v12 4/6] test: add pointer compress tests to ring perf test

2024-05-29 Thread Paul Szczepanek
. Added more bulk sizes to showcase their effects on compression. Adjusted loop iteration numbers to take into account bulk sizes to keep runtime constant (instead of number of operations). Adjusted old printfs to match new ones which have aligned numbers. Signed-off-by: Paul Szczepanek Reviewed-by

[PATCH v12 0/6] add pointer compression API

2024-05-29 Thread Paul Szczepanek
* added doxygen and prefixes to macros * use rte_bitops for clz and ctz * added unit tests to verify macros * fixed incorrect letter case in docs Paul Szczepanek (6): lib: allow libraries with no sources mempool: add functions to get extra mempool info ptr_compress: add pointer compression

[PATCH v12 2/6] mempool: add functions to get extra mempool info

2024-05-29 Thread Paul Szczepanek
Add two functions: - rte_mempool_get_mem_range - get virtual memory range of the objects in the mempool, - rte_mempool_get_obj_alignment - get alignment of objects in the mempool. Add two tests that test these new functions. Signed-off-by: Paul Szczepanek Reviewed-by: Jack Bond-Preston

[PATCH v12 1/6] lib: allow libraries with no sources

2024-05-29 Thread Paul Szczepanek
Allow header only libraries. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Acked-by: Bruce Richardson --- lib/meson.build | 16 1 file changed, 16 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 179a272932..7c90602bf5 100644 --- a/lib

Re: [PATCH v11 2/6] mempool: add functions to get extra mempool info

2024-05-28 Thread Paul Szczepanek
On 24/05/2024 13:20, Morten Brørup wrote: >> From: Paul Szczepanek [mailto:paul.szczepa...@arm.com] >> Sent: Friday, 24 May 2024 10.37 >> >> +size_t rte_mempool_get_obj_alignment(struct rte_mempool *mp) >> +{ >> +if (mp == NULL) >> +

Re: [PATCH v5 0/4] add pointer compression API

2024-05-28 Thread Paul Szczepanek
On 24/05/2024 10:09, Konstantin Ananyev wrote: > > >> I have added macros to help find the parameters and I have added mempool >> functions that allow you to determine if you can use the mempool and >> what params it needs. The new mempool functions are mentioned in the >> docs for ptr compres

[PATCH v11 6/6] test: add unit test for ptr compression

2024-05-24 Thread Paul Szczepanek
Test compresses and decompresses pointers with various combinations of memory regions and alignments and verifies the pointers are recovered correctly. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by: Nathan Brown Reviewed-by: Jack Bond-Preston --- MAINTAINERS

[PATCH v11 5/6] docs: add pointer compression guide

2024-05-24 Thread Paul Szczepanek
Documentation added in the prog guide for the new utility functions for pointer compression showing example code and potential usecases. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by: Nathan Brown Reviewed-by: Jack Bond-Preston --- MAINTAINERS

[PATCH v11 4/6] test: add pointer compress tests to ring perf test

2024-05-24 Thread Paul Szczepanek
. Added more bulk sizes to showcase their effects on compression. Adjusted loop iteration numbers to take into account bulk sizes to keep runtime constant (instead of number of operations). Adjusted old printfs to match new ones which have aligned numbers. Signed-off-by: Paul Szczepanek Reviewed-by

[PATCH v11 3/6] ptr_compress: add pointer compression library

2024-05-24 Thread Paul Szczepanek
from a base memory address. Offsets can be stored in fewer bytes (dictated by the memory region size and alignment of the pointer). For example: an 8 byte aligned pointer which is part of a 32GB memory pool can be stored in 4 bytes. Suggested-by: Honnappa Nagarahalli Signed-off-by: Paul Szczepanek

[PATCH v11 2/6] mempool: add functions to get extra mempool info

2024-05-24 Thread Paul Szczepanek
Add two functions: - rte_mempool_get_mem_range - get virtual memory range of the objects in the mempool, - rte_mempool_get_obj_alignment - get alignment of objects in the mempool. Add two tests that test these new functions. Signed-off-by: Paul Szczepanek Reviewed-by: Jack Bond-Preston

[PATCH v11 1/6] lib: allow libraries with no sources

2024-05-24 Thread Paul Szczepanek
Allow header only libraries. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by: Jack Bond-Preston Acked-by: Bruce Richardson --- lib/meson.build | 16 1 file changed, 16 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 179a272932

[PATCH v11 0/6] add pointer compression API

2024-05-24 Thread Paul Szczepanek
Paul Szczepanek (6): lib: allow libraries with no sources mempool: add functions to get extra mempool info ptr_compress: add pointer compression library test: add pointer compress tests to ring perf test docs: add pointer compression guide test: add unit test for ptr compression

Re: [PATCH v5 0/4] add pointer compression API

2024-05-24 Thread Paul Szczepanek
I have added macros to help find the parameters and I have added mempool functions that allow you to determine if you can use the mempool and what params it needs. The new mempool functions are mentioned in the docs for ptr compress. Please take a look at v11. I did not add a new make pkt buf API

Re: [PATCH v5 0/4] add pointer compression API

2024-05-16 Thread Paul Szczepanek
On 15/05/2024 23:34, Morten Brørup wrote: >> From: Paul Szczepanek [mailto:paul.szczepa...@arm.com] >> >> AFAIK DPDK rte_mempool does require the addresses to be virtually >> contiguous as the memory reservation is done during creation of the >> mempool and a singl

Re: RE: [PATCH v5 0/4] add pointer compression API

2024-05-15 Thread Paul Szczepanek
On 04/03/2024 14:44, Konstantin Ananyev wrote: >> This feature is targeted for pipeline mode of applications. We see many >> customers using pipeline mode. This feature helps in reducing >> the cost of transferring the packets between cores by reducing the copies >> involved. > > I do understand

Re: [PATCH v9 1/5] lib: allow libraries with no sources

2024-03-15 Thread Paul Szczepanek
On 11/03/2024 15:23, Bruce Richardson wrote: > On Mon, Mar 11, 2024 at 02:47:02PM +0000, Paul Szczepanek wrote: >> Allow header only libraries. >> >> Signed-off-by: Paul Szczepanek >> Reviewed-by: Honnappa Nagarahalli >> --- >> lib/meson.build | 1

[PATCH v10 5/5] test: add unit test for ptr compression

2024-03-11 Thread Paul Szczepanek
Test compresses and decompresses pointers with various combinations of memory regions and alignments and verify the pointers are recovered correctly. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by: Nathan Brown --- MAINTAINERS | 1 + app/test

[PATCH v10 4/5] docs: add pointer compression guide

2024-03-11 Thread Paul Szczepanek
Documentation added in the prog guide for the new utility functions for pointer compression showing example code and potential usecases. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by: Nathan Brown --- MAINTAINERS| 1 + doc

[PATCH v10 3/5] test: add pointer compress tests to ring perf test

2024-03-11 Thread Paul Szczepanek
. Added more bulk sizes to showcase their effects on compression. Adjusted loop iteration numbers to take into account bulk sizes to keep runtime constant (instead of number of operations). Adjusted old printfs to match new ones which have aligned numbers. Signed-off-by: Paul Szczepanek Reviewed-by

[PATCH v10 2/5] ptr_compress: add pointer compression library

2024-03-11 Thread Paul Szczepanek
from a base memory address. Offsets can be stored in fewer bytes (dictated by the memory region size and alignment of the pointer). For example: an 8 byte aligned pointer which is part of a 32GB memory pool can be stored in 4 bytes. Suggested-by: Honnappa Nagarahalli Signed-off-by: Paul Szczepanek

[PATCH v10 1/5] lib: allow libraries with no sources

2024-03-11 Thread Paul Szczepanek
Allow header only libraries. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli --- lib/meson.build | 16 1 file changed, 16 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 179a272932..7c90602bf5 100644 --- a/lib/meson.build +++ b/lib

[PATCH v10 0/5] add pointer compression API

2024-03-11 Thread Paul Szczepanek
deps to static deps Paul Szczepanek (5): lib: allow libraries with no sources ptr_compress: add pointer compression library test: add pointer compress tests to ring perf test docs: add pointer compression guide test: add unit test for ptr compression MAINTAINERS

[PATCH v9 5/5] test: add unit test for ptr compression

2024-03-11 Thread Paul Szczepanek
Test compresses and decompresses pointers with various combinations of memory regions and alignments and verify the pointers are recovered correctly. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by: Nathan Brown --- MAINTAINERS | 1 + app/test

[PATCH v9 4/5] docs: add pointer compression guide

2024-03-11 Thread Paul Szczepanek
Documentation added in the prog guide for the new utility functions for pointer compression showing example code and potential usecases. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by: Nathan Brown --- MAINTAINERS| 1 + doc

[PATCH v9 3/5] test: add pointer compress tests to ring perf test

2024-03-11 Thread Paul Szczepanek
. Added more bulk sizes to showcase their effects on compression. Adjusted loop iteration numbers to take into account bulk sizes to keep runtime constant (instead of number of operations). Adjusted old printfs to match new ones which have aligned numbers. Signed-off-by: Paul Szczepanek Reviewed-by

  1   2   >