On 10/12/2017 10:46 PM, Ferruh Yigit wrote:
This patch partially reverts the commit d196343a258e and adds some
functions from Markus' previous version of the patch [1].
igb_uio uses pci_msi_unmask_irq() and pci_msi_mask_irq() kernel APIs
when kernel version is >= 3.19 because these APIs are impl
Hi, Markus,
This commit appears to cause a regression on CentOS 7.4 with the in-box
Linux 3.10.0-639-2.2.el7.x86_64 kernel. Although the kernel module
appears to build correctly, when I attempt to load the module with
insmod, it fails and I see the following errors in dmesg:
[620323.805125]
Signed-off-by: Kuba Kozak
Acked-by: Anatoly Burakov
FWIW:
Acked-by: Patrick MacArthur
On 09/20/2017 10:39 AM, Burakov, Anatoly wrote:
On 20-Sep-17 3:34 PM, Patrick MacArthur wrote:
On 09/20/2017 05:59 AM, Kuba Kozak wrote:
Add file descriptor value check before calling close() function.
Coverity issue: 141297
Fixes: 811b6b25060f ("vfio: fix file descriptor leak in
n_sock, fd);
- close(fd);
+ if (fd != -1)
+ close(fd);
IMHO this should be:
if (fd >= 0)
What specifically is Coverity complaining about here? Is there a
specific code path that leads to fd being -1 here?
Thanks,
Patrick MacArthur
these buffers as there is nowhere to free them. Using static
buffers is an option but would make these strings have a fixed maximum
length whereas there is currently no limit defined by the API.
[1] http://spdk.io
[2] https://github.com/zrlio/urdma
Fixes: af75078fece3 ("first public release"
ned-off-by: Patrick MacArthur
---
lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c
b/lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c
index 00cf919b64d0..fb4a2f84b180 100644
--- a/lib/librte_eal/li
7 matches
Mail list logo
