[dpdk-dev] [PATCH] net/axgbe: fix double unlock coverity issue

2019-09-19 Thread Pallantla Poornima
ct 'phy_data->comm_owned' in the identified case ensuring locks/unlocks properly exist. Coverity issue: 340835 Fixes: a5c7273771 ("net/axgbe: add phy programming APIs") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- drivers/net/axgbe/axgbe_phy_impl.c | 6 +++---

[dpdk-dev] [PATCH] app/test: add unit test cases to mempool library

2019-09-10 Thread Pallantla Poornima
Added UT in mempool.c to cover below functions: rte_mempool_populate_anon() rte_mempool_memchunk_anon_free() get_anon_size() rte_mempool_mem_iter() Signed-off-by: Pallantla Poornima --- app/test/test_mempool.c | 74 + 1 file changed, 74 insertions

[dpdk-dev] [PATCH v4] test/eal: add ut cases for in-memory and single-file-segment

2019-07-03 Thread Pallantla Poornima
Added unit test case for eal command line '--in-memory' option which will cover below functions. get_seg_memfd() test_memfd_create() pagesz_flags() Added unit test case for eal command line '--single-file-segments' option which will cover resize_hugefile(). Signed-off-by

[dpdk-dev] [PATCH v3] test/eal: add ut cases for in-memory and single-file-segment

2019-06-27 Thread Pallantla Poornima
Added unit test case for eal command line 'in-memory' option which will cover below functions. get_seg_memfd() test_memfd_create() pagesz_flags() Added unit test case for eal command line 'single-file-segments' option which will cover resize_hugefile(). Signed-off-by

[dpdk-dev] [PATCH v2] test/eal: add ut cases for in-memory and single-file-segment

2019-06-26 Thread Pallantla Poornima
Added unit test case for eal command line 'in-memory' option which will cover below functions. get_seg_memfd() test_memfd_create() pagesz_flags() Added unit test case for eal command line 'single-file-segments' option which will cover resize_hugefile(). Signed-off-by

[dpdk-dev] [PATCH] test/eal: add ut cases for in-memory and single-file-segment

2019-06-14 Thread Pallantla Poornima
Added unit test case for eal command line 'in-memory' option which will cover below functions. get_seg_memfd() test_memfd_create() pagesz_flags() Added unit test case for eal command line 'single-file-segments' option which will cover resize_hugefile(). Signed-off-by

[dpdk-dev] [PATCH v3] app/testbbdev: fix sprintf with snprintf or strlcpy

2019-04-09 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf and strlcpy is used. Fixes: f714a18885 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima Acked-by: Amr Mokhtar --- v3

[dpdk-dev] [PATCH v3] app/test/hash: fix sprintf with snprintf

2019-03-26 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 473d1bebce ("hash: allow to store data in hash table") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima Acked-by: Yipeng Wang --- v3: Rebased. v2: A

[dpdk-dev] [PATCH v2] app/test: fix sprintf with strlcat

2019-03-13 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function strlcat is used. Fixes: 727909c592 ("app/test: introduce dynamic commands list") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- v2: Used strlcat to avoid buffer overflow

[dpdk-dev] [PATCH v2] net/nfp: fix possible buffer overflow

2019-03-08 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 896c265ef9 ("net/nfp: use new CPP interface") Fixes: c4171b520b ("net/nfp: support PF multiport") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima

[dpdk-dev] [PATCH v2] app/testbbdev: fix sprintf with snprintf or strlcpy

2019-02-18 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf and strlcpy is used. Fixes: f714a18885 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- v2: Used strlcpy instead

[dpdk-dev] [PATCH v3] power: fix to remove unused variable

2019-02-15 Thread Pallantla Poornima
Variable pfi_str is removed since it is unused. Fixes: 450f0791312c ("power: add traffic pattern aware power control") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima Reviewed-by: Rami Rosen --- v3: Updated fixes line. v2: Removed unused variable as suggested. --- lib/li

[dpdk-dev] [PATCH v2] power: fix to remove unused variable

2019-02-14 Thread Pallantla Poornima
Variable pfi_str is removed since it is unused. Fixes: 450f079131 ("power: add traffic pattern aware power control") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- v2: Removed unused variable as suggested. --- lib/librte_power/rte_power_empty_poll.c | 3 --- 1 file

[dpdk-dev] [PATCH v2] hash: fix sprintf with snprintf

2019-02-14 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 473d1bebce ("hash: allow to store data in hash table") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- v2: Addressed review comment to correct the form

[dpdk-dev] [PATCH v2] test/distributor: fix sprintf with strlcpy

2019-02-14 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. replaced sprintf with strlcpy. Fixes: f74df2c57e ("test/distributor: test single and burst API") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- v2: Addressed review comment to replace snpr

[dpdk-dev] [PATCH] test: fix sprintf with snprintf

2019-02-08 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 727909c592 ("app/test: introduce dynamic commands list") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- test/test/commands.c | 7 ++- 1

[dpdk-dev] [PATCH] hash: fix sprintf with snprintf

2019-02-06 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 473d1bebce ("hash: allow to store data in hash table") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- test/test/test_hash_perf.c | 6 -- 1

[dpdk-dev] [PATCH] test/eventdev: fix sprintf with snprintf

2019-02-06 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 2a9c83ae3b ("test/eventdev: add multi-ports test") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- test/test/test_event_eth_rx_adapter.c | 3 ++- 1

[dpdk-dev] [PATCH] test/distributor: fix sprintf with snprintf

2019-02-06 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: f74df2c57e ("test/distributor: test single and burst API") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- test/test/test_distributor.c | 6 -- 1

[dpdk-dev] [PATCH] vhost: fix sprintf with snprintf

2019-02-03 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: d7280c9fff ("vhost: support selective datapath") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- lib/librte_vhost/vdpa.c | 2 +- 1 file changed, 1

[dpdk-dev] [PATCH] power: fix sprintf with snprintf

2019-02-03 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 450f079131 ("power: add traffic pattern aware power control") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- lib/librte_power/rte_power_empty_poll.c

[dpdk-dev] [PATCH] net/softnic: fix sprintf with snprintf

2019-02-03 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: daabf2fb94 ("net/softnic: map flow action to table action") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- drivers/net/softnic/rte_eth_softnic_flow

[dpdk-dev] [PATCH] net/nfp: fix sprintf with snprintf

2019-02-03 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 896c265ef9 ("net/nfp: use new CPP interface") Fixes: c4171b520b ("net/nfp: support PF multiport") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poorn

[dpdk-dev] [PATCH] event/opdl: fix sprintf with snprintf

2019-02-03 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 3c7f3dcfb0 ("event/opdl: add PMD main body and helper function") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- drivers/event/opdl/opdl_evd

[dpdk-dev] [PATCH] app/testbbdev: fix sprintf with snprintf

2019-02-03 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: f714a18885 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- app/test-bbdev/test_bbdev.c | 8

[dpdk-dev] [PATCH] kni: fix sprintf with snprintf

2019-02-03 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 3fc5ca2f63 ("kni: initial import") Fixes: b9ee370557 ("kni: update kernel driver ethtool baseline") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poorni

[dpdk-dev] [PATCH] drivers: fix sprintf with snprintf

2019-01-07 Thread Pallantla Poornima
("crypto/caam_jr: add device basic operations") Fixes: 7e3e2954e0 ("crypto/dpaa_sec: move mempool allocation to config") Fixes: c3e85bdcc6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- drivers/

[dpdk-dev] [PATCH v2] test: fix to skip power kvm vm autotest

2018-11-14 Thread Pallantla Poornima
power_kvm_vm_autotest should run on kvm vm and virtio-ports should exist, if not test should skip. Hence changed return as TEST_SKIPPED. Fixes: 0ea2dd4409 ("test: skip when required lib not available") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima Acked-by: Reshma Patta

[dpdk-dev] [PATCH] test: fix to skip power kvm vm autotest

2018-11-14 Thread Pallantla Poornima
Power_kvm_vm_autotest should run on kvm vm and virtio-ports should exist,if not test should skip. Hence changed return as TEST_SKIPPED. Fixes: 0ea2dd4409 ("test: skip when required lib not available") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- test/test/test_power_kv

[dpdk-dev] [PATCH] test: fix to skip kni autotest

2018-11-13 Thread Pallantla Poornima
Kni_autotest should be skipped if rte_kni.ko module is not loaded. Hence changed return as TEST_SKIPPED. Fixes: ee1caebc4d ("test/kni: check module dependency") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- test/test/test_kni.c | 2 +- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH] test: fix to skip power acpi cpufreq autotest

2018-11-13 Thread Pallantla Poornima
Power_acpi_cpufreq_autotest should not be run on VM and platforms which dont have acpi_cpufreq module loaded. Hence changed return as TEST_SKIPPED Fixes: 0ea2dd4409 ("test: skip when required lib not available") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima ---

[dpdk-dev] [PATCH] test: disable alarm autotest in FreeBSD

2018-09-20 Thread Pallantla Poornima
Disabled the alarm_autotest UT in FreeBSD Interrupts are not supported in FreeBSD. Alarm API depends on interrupts, so disabled alarm test on FreeBSD. Signed-off-by: Pallantla Poornima --- test/test/test_alarm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/test

[dpdk-dev] [PATCH] test: disable alarm autotest in FreeBSD

2018-09-20 Thread Pallantla Poornima
Disabled the alarm_autotest UT in FreeBSD Interrupts are not supported in FreeBSD. Alarm API depends on interrupts, so disabled alarm test on FreeBSD. Signed-off-by: Pallantla Poornima --- test/test/test_alarm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/test