[dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci

2019-08-09 Thread Damian Nowak
When running auth NULL cases while using vfio_pci, DMAR read/write faults appear. It happens even if digest_length is set to 0. This is caused by auth_res_addr initialized as 0x0. Fixes: 4e0955bddb08 Cc: Fiona Trahe Signed-off-by: Damian Nowak --- drivers/crypto/qat/qat_sym.c | 5 ++--- 1

Re: [dpdk-dev] [PATCH 1/3] vfio: revert change that does intr eventfd setup at probe

2019-07-19 Thread Nowak, DamianX
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nithin Dabilpuram > Sent: Wednesday, July 17, 2019 13:59 > To: Hyong Youb Kim ; David Marchand > ; Thomas Monjalon > ; Yigit, Ferruh ; Burakov, > Anatoly > Cc: jer...@marvell.com; John Daley ; Shahed Shaikh >

Re: [dpdk-dev] [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto

2019-07-18 Thread Nowak, DamianX
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 17, 2019 14:51 > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; > shal...@marvell.com; Nowak, DamianX ; > Kusztal, ArkadiuszX > Subject: [PATCH v4 00/11] Rework API for RSA

[dpdk-dev] [PATCH] test/crypto: add capability check for ZUC test cases

2019-07-15 Thread Damian Nowak
This patch adds checking if device support ZUC algorithms before running ZUC test cases. It also removes unnecessary checks of digest appended space and fixes some comments wording. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 28 1 file changed, 20

Re: [dpdk-dev] [PATCH] crypto/qat: fix seg-fault

2019-07-10 Thread Nowak, DamianX
> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, July 10, 2019 11:53 > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Nowak, > DamianX ; Ananyev, Konstantin > > Subject: [PATCH] crypto/qat: fix seg-fault > > Fix for seg-fault

[dpdk-dev] [PATCH v3 8/8] test/crypto: return correct value if feature not supported

2019-07-03 Thread Damian Nowak
This patch makes unsupported tests visible in the testsuite summary. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 336cfd0..05422da 100644 --- a

[dpdk-dev] [PATCH v3 6/8] test/crypto: add kasumi test cases for auth-cipher

2019-07-03 Thread Damian Nowak
This patch adds test cases for kasumi in-place and out-of-place auth-cipher operations. Test cases include buffer appended digest generation with encryption and buffer decryption with appended digest verification. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c

[dpdk-dev] [PATCH v3 7/8] test/crypto: add sgl test cases for ip and oop

2019-07-03 Thread Damian Nowak
digest is encrypted only partially. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 783 +- app/test/test_cryptodev_snow3g_test_vectors.h | 67 +++ 2 files changed, 830 insertions(+), 20 deletions(-) diff --git a/app/test/test_cryptodev.c b/app

[dpdk-dev] [PATCH v3 4/8] test/crypto: add snow3g test cases for auth-cipher

2019-07-03 Thread Damian Nowak
Nowak --- app/test/test_cryptodev.c | 305 +- app/test/test_cryptodev_snow3g_test_vectors.h | 167 +- 2 files changed, 414 insertions(+), 58 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 7a3a3d1

[dpdk-dev] [PATCH v3 5/8] test/crypto: add zuc test cases for auth-cipher

2019-07-03 Thread Damian Nowak
This patch adds test cases for zuc in-place and out-of-place auth-cipher operations. Test cases include buffer appended digest generation with encryption and buffer decryption with appended digest verification. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 204

[dpdk-dev] [PATCH v3 2/8] cryptodev: add digest encrypted feature flag

2019-07-03 Thread Damian Nowak
about new feature flag to the release notes. Signed-off-by: Damian Nowak --- doc/guides/cryptodevs/features/default.ini | 1 + doc/guides/cryptodevs/overview.rst | 3 +++ doc/guides/rel_notes/release_19_08.rst | 3 +++ lib/librte_cryptodev/rte_cryptodev.c | 2 ++ lib

[dpdk-dev] [PATCH v3 0/8] cryptodev: support encrypted-digest use-cases

2019-07-03 Thread Damian Nowak
in comments and documentation - add zuc test cases - add support for partial digest encryption - update support for sgl buffers v2: - extend support for partial digest encryption - add release notes - document limitations on QAT - reorder patches - update patchset name Damian Nowak (8

[dpdk-dev] [PATCH v3 1/8] cryptodev: document usage of digest-appended operations

2019-07-03 Thread Damian Nowak
This patch explains what are the conditions and how to use digest appended for auth-cipher operations. Signed-off-by: Damian Nowak --- lib/librte_cryptodev/rte_crypto_sym.h | 44 +++ 1 file changed, 44 insertions(+) diff --git a/lib/librte_cryptodev

[dpdk-dev] [PATCH v3 3/8] crypto/qat: extend support for digest-encrypted auth-cipher

2019-07-03 Thread Damian Nowak
extends PMD buffers accordingly. It also adds feature flag for QuickAssist Technology to emphasize it's support for digest appended auth-cipher operations. Signed-off-by: Damian Nowak --- doc/guides/cryptodevs/features/qat.ini | 1 + doc/guides/rel_notes/release_19_08.rst | 5 +++ drivers/c

[dpdk-dev] [PATCH v2 09/10] doc/crypto: document digest-encrypted limitations in qat

2019-06-07 Thread Damian Nowak
This patch adds description of limitation when using digest-appended auth-cipher operations on QuickAssist Technology driver. Signed-off-by: Damian Nowak --- doc/guides/cryptodevs/qat.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs

[dpdk-dev] [PATCH v2 06/10] test/crypto: add kasumi test cases for auth-cipher

2019-06-07 Thread Damian Nowak
This patch adds test cases for kasumi in-place and out-of-place auth-cipher operations. Test cases include buffer appended digest generation with encryption and buffer decryption with appended digest verification. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c

[dpdk-dev] [PATCH v2 10/10] doc: update release notes for 19.08

2019-06-07 Thread Damian Nowak
This patch adds release note entries for hash-cipher digest-encrypted operations and new digest_encrypted feature flag. Signed-off-by: Damian Nowak --- doc/guides/rel_notes/release_19_08.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b

[dpdk-dev] [PATCH v2 08/10] test/crypto: return correct value if feature not supported

2019-06-07 Thread Damian Nowak
This patch makes unsupported tests visible in the testsuite summary. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index fa2b5df..ac63bc6 100644 --- a

[dpdk-dev] [PATCH v2 07/10] test/crypto: add sgl test cases for ip and oop

2019-06-07 Thread Damian Nowak
is encrypted only partially. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 262 ++ app/test/test_cryptodev_snow3g_test_vectors.h | 67 +++ 2 files changed, 329 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test

[dpdk-dev] [PATCH v2 03/10] crypto/qat: handle buffer size for digest-encrypted auth-cipher

2019-06-07 Thread Damian Nowak
encrypted or decrypted partially and extends PMD buffers accordingly. Signed-off-by: Damian Nowak --- drivers/crypto/qat/qat_sym.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c

[dpdk-dev] [PATCH v2 05/10] test/crypto: add snow3g test cases for auth-cipher

2019-06-07 Thread Damian Nowak
Nowak --- app/test/test_cryptodev.c | 281 +- app/test/test_cryptodev_snow3g_test_vectors.h | 167 ++- 2 files changed, 392 insertions(+), 56 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 9f31aaa

[dpdk-dev] [PATCH v2 04/10] crypto/qat: add digest encrypted feature flag

2019-06-07 Thread Damian Nowak
This patch adds feature flag for QuickAssist Technology to emphasize it's support for digest appended auth-cipher operations. Signed-off-by: Damian Nowak --- drivers/crypto/qat/qat_sym_pmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_sym_pm

[dpdk-dev] [PATCH v2 01/10] cryptodev: document usage of digest-appended operations

2019-06-07 Thread Damian Nowak
This patch explains what are the conditions and how to use digest appended for auth-cipher operations. Signed-off-by: Damian Nowak --- lib/librte_cryptodev/rte_crypto_sym.h | 43 +++ 1 file changed, 43 insertions(+) diff --git a/lib/librte_cryptodev

[dpdk-dev] [PATCH v2 00/10] cryptodev: support encrypted-digest use-cases

2019-06-07 Thread Damian Nowak
- add release notes - document limitations on QAT - reorder patches - update patchset name Damian Nowak (10): cryptodev: document usage of digest-appended operations cryptodev: add digest encrypted feature flag crypto/qat: handle buffer size for digest-encrypted auth-cipher crypto/qat: add

[dpdk-dev] [PATCH v2 02/10] cryptodev: add digest encrypted feature flag

2019-06-07 Thread Damian Nowak
Some PMDs can only support digest being encrypted separately in auth-cipher operations. Thus it is required to add feature flag in PMD to reflect if it does support digest-appended both: digest generation with encryption and decryption with digest verification. Signed-off-by: Damian Nowak

[dpdk-dev] [PATCH 9/9] test/crypto: return correct value if feature not supported

2019-06-03 Thread Nowak
From: Damian Nowak This patch makes unsupported tests visible in the testsuite summary. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 937849e

[dpdk-dev] [PATCH 8/9] test/crypto: add digest encrypted feature flag check

2019-06-03 Thread Nowak
From: Damian Nowak This patch adds checking of digest encrypted feature flag for auth-cipher out-of-place operations test cases to determine if the operations are supported. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 40 ++-- 1 file changed

[dpdk-dev] [PATCH 7/9] crypto/qat: add digest encrypted feature flag

2019-06-03 Thread Nowak
From: Damian Nowak This patch adds feature flag for QuickAssist Technology to emphasize it's support for digest appended auth-cipher operations. Signed-off-by: Damian Nowak --- drivers/crypto/qat/qat_sym_pmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dr

[dpdk-dev] [PATCH 6/9] cryptodev: add digest encrypted feature flag

2019-06-03 Thread Nowak
From: Damian Nowak Some PMDs can only support digest being encrypted separately in auth-cipher operations. Thus it is required to add feature flag in PMD to reflect if it does support digest-appended both: digest generation with encryption and decryption with digest verification. Signed-off-by

[dpdk-dev] [PATCH 5/9] cryptodev: document usage of digest-appended operations

2019-06-03 Thread Nowak
From: Damian Nowak This patch explains what are the conditions and how to use digest appended for auth-cipher operations. Signed-off-by: Damian Nowak --- lib/librte_cryptodev/rte_crypto_sym.h | 43 +++ 1 file changed, 43 insertions(+) diff --git a/lib

[dpdk-dev] [PATCH 4/9] test/crypto: add sgl test cases for ip and oop

2019-06-03 Thread Nowak
From: Damian Nowak This patch adds test cases for snow3g in-place and out-of-place auth-cipher operations with scatter-gather lists as input and output mbufs. Test cases include digest generation with buffer encryption and buffer decryption with digest verification. Signed-off-by: Damian Nowak

[dpdk-dev] [PATCH 3/9] test/crypto: add kasumi test cases for oop operation

2019-06-03 Thread Nowak
From: Damian Nowak This patch adds test cases for kasumi out of place auth-cipher operations. Test cases include digest generation with buffer encryption and buffer decryption with digest verification. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 190

[dpdk-dev] [PATCH 2/9] test/crypto: add snow3g test cases for oop operation

2019-06-03 Thread Nowak
From: Damian Nowak This patch adds test cases for snow3g out of place auth-cipher operations. Test cases include digest generation with buffer encryption and buffer decryption with digest verification. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 228

[dpdk-dev] [PATCH 1/9] crypto/qat: check buffer size for oop auth-cipher

2019-06-03 Thread Nowak
From: Damian Nowak This patch adds condition to be met when using wireless algorithms (SNOW3G, KASUMI, ZUC) in out-of-place auth-cipher operations. It verifies if there is enough room for the digest in the output buffer. Conditions rewritten for better readibility and possible SGL support

[dpdk-dev] [PATCH 0/9] add QAT support for digest encrypted

2019-06-03 Thread Nowak
From: Damian Nowak This patchset adds digest appended and encrypted auth-cipher operations support for QAT, with dedicated feature flag and a set of tests for KASUMI and SNOW3G in-place, out-of-place and SGL using operations. Damian Nowak (9): crypto/qat: check buffer size for oop auth-cipher

[dpdk-dev] [PATCH v5 1/1] test: new test structure for asymmetric crypto

2019-03-27 Thread Damian Nowak
This patch adds new test structure for modexp and modinv for asymmetric cryptography Signed-off-by: Damian Nowak --- app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_asym.c | 318 ++ app/test/test_cryptodev_mod_test_vectors.h | 967

[dpdk-dev] [PATCH v5 0/1] test: new test structure for asymmetric crypto

2019-03-27 Thread Damian Nowak
: - rebase - remove unused variable v3: - add QuickAssist Technology support v2: - fix checkpatch issues Damian Nowak (1): test: new test structure for asymmetric crypto app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_asym.c | 318 ++ app/test

[dpdk-dev] [PATCH v4 1/1] test: new test structure for asymmetric crypto

2019-03-26 Thread Damian Nowak
This patch adds new test structure for modexp and modinv for asymmetric cryptography Signed-off-by: Damian Nowak --- app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_asym.c | 318 ++ app/test/test_cryptodev_mod_test_vectors.h | 967

[dpdk-dev] [PATCH v4 0/1] test: new test structure for asymmetric crypto

2019-03-26 Thread Damian Nowak
unused variable v3: - add QuickAssist Technology support v2: - fix checkpatch issues Damian Nowak (1): test: new test structure for asymmetric crypto app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_asym.c | 318 ++ app/test

[dpdk-dev] [PATCH v2 1/1] fips_validation: Add plain SHA support

2019-03-19 Thread Damian Nowak
This patch enables plain SHA algorithm CAVP test support in fips_validation sample application. Signed-off-by: Damian Nowak Acked-by: Fan Zhang Acked-by: Marko Kovacevic --- examples/fips_validation/Makefile | 1 + examples/fips_validation/fips_validation.c | 17

[dpdk-dev] [PATCH v2 0/1] fips_validation: Add plain SHA support

2019-03-19 Thread Damian Nowak
This patch enables plain SHA algorithm CAVP test support in fips_validation sample application. --- v2: fix checkpatches issues Damian Nowak (1): fips_validation: Add plain SHA support examples/fips_validation/Makefile | 1 + examples/fips_validation/fips_validation.c

[dpdk-dev] [PATCH v2 3/3] cryptodev: remove XTS text duplication

2019-03-13 Thread Damian Nowak
This patch removes duplicated text about AES-XTS mode. Signed-off-by: Damian Nowak --- lib/librte_cryptodev/rte_crypto_sym.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h index eb5afc5

[dpdk-dev] [PATCH v2 1/3] test/crypto: add tests for XTS on QAT

2019-03-13 Thread Damian Nowak
This patch adds test vectors for AES XTS mode on QAT. It uses different plaintext sizes and AES keys sizes of 128 and 256 bits. Signed-off-by: Damian Nowak --- app/test/test_cryptodev_aes_test_vectors.h | 223 - 1 file changed, 222 insertions(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v2 2/3] crypto/qat: add XTS for QAT session config

2019-03-13 Thread Damian Nowak
This patch adds XTS capabilities and enables XTS cipher mode on QAT. It also updates the documentation for newly supported AES XTS mode on QAT. Signed-off-by: Damian Nowak --- doc/guides/cryptodevs/features/qat.ini| 2 ++ doc/guides/cryptodevs/qat.rst | 3 ++- doc/guides

[dpdk-dev] [PATCH v2 0/3] add XTS support for Intel QAT

2019-03-13 Thread Damian Nowak
This patchset adds XTS support for Intel QuickAssist Technology. Following cipher algorithms are available with this patchset: * AES XTS (128) * AES XTS (256) --- v2: - update release notes Damian Nowak (3): test/crypto: add tests for XTS on QAT crypto/qat: add XTS for QAT

[dpdk-dev] [PATCH v3 0/1] test: new test structure for asymmetric crypto

2019-03-12 Thread Damian Nowak
QuickAssist Technology devices (http://patchwork.dpdk.org/cover/50660/) v3: - add QuickAssist Technology support v2: - fix checkpatch issues Damian Nowak (1): test: new test structure for asymmetric crypto test/test/test_cryptodev.h | 1 + test/test/test_cryptodev_asym.c

[dpdk-dev] [PATCH v3 1/1] test: new test structure for asymmetric crypto

2019-03-12 Thread Damian Nowak
This patch adds new test structure for modexp and modinv for asymmetric cryptography Signed-off-by: Damian Nowak --- test/test/test_cryptodev.h | 1 + test/test/test_cryptodev_asym.c | 319 + test/test/test_cryptodev_mod_test_vectors.h | 966

[dpdk-dev] [PATCH v2] test: add new test structure for asymmetric cryptography

2019-03-04 Thread Damian Nowak
This patch adds new test structure for modexp and modinv Signed-off-by: Damian Nowak --- v2: - coding style improved --- test/test/test_cryptodev_asym.c | 278 ++ test/test/test_cryptodev_mod_test_vectors.h | 954 2 files changed, 1232 insertions(+) diff

[dpdk-dev] [PATCH] test: add new test structure for asymmetric cryptography

2019-03-01 Thread Damian Nowak
This patch adds new test structure for modexp and modinv Change-Id: I01de09e65565a4ab3547fbff8c9d1e5f3d2bed1f Signed-off-by: Damian Nowak --- test/test/test_cryptodev_asym.c | 279 ++ test/test/test_cryptodev_mod_test_vectors.h | 946 2 files changed, 1225

[dpdk-dev] [PATCH 0/3] Add XTS support for Intel QuickAssist Technology

2019-02-28 Thread Damian Nowak
This patchset adds XTS support for Intel QuickAssist Technology. Following cipher algorithms are available with this patchset: * AES XTS (128) * AES XTS (256) Damian Nowak (3): test/crypto: add tests for XTS on QAT crypto/qat: add XTS for QAT session config cryptodev: remove

[dpdk-dev] [PATCH 3/3] cryptodev: remove XTS text duplication

2019-02-28 Thread Damian Nowak
This patch removes duplicated text about AES-XTS mode. Signed-off-by: Damian Nowak --- lib/librte_cryptodev/rte_crypto_sym.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h index eb5afc5

[dpdk-dev] [PATCH 2/3] crypto/qat: add XTS for QAT session config

2019-02-28 Thread Damian Nowak
This patch adds XTS capabilities and enables XTS cipher mode on QAT. It also updates the documentation for newly supported AES XTS mode on QAT. Signed-off-by: Damian Nowak --- doc/guides/cryptodevs/features/qat.ini| 2 ++ doc/guides/cryptodevs/qat.rst | 3 ++- drivers/crypto

[dpdk-dev] [PATCH 1/3] test/crypto: add tests for XTS on QAT

2019-02-28 Thread Damian Nowak
This patch adds test vectors for AES XTS mode on QAT. It uses different plaintext sizes and AES keys sizes of 128 and 256 bits. Signed-off-by: Damian Nowak --- test/test/test_cryptodev_aes_test_vectors.h | 223 +++- 1 file changed, 222 insertions(+), 1 deletion(-) diff

[dpdk-dev] [PATCH 0/3] Add XTS support for Intel QuickAssist Technology

2019-02-28 Thread Damian Nowak
This patchset adds XTS support for Intel QuickAssist Technology. Following cipher algorithms are available with this patchset: * AES XTS (128) * AES XTS (256) Damian Nowak (3): test/crypto: add tests for XTS on QAT crypto/qat: add XTS for QAT session config cryptodev: remove