This commit adds counters support when creating flows via direct
verbs. The implementation uses devx interface in order to create
query and delete the counters.
This support requires MLNX_OFED_LINUX-4.5-0.1.0.1 installation.
Signed-off-by: Moti Haimovsky
---
---
v2:
* Modifications according to c
This patch adds glue functions for operations:
- dv_open_device.
- devx object create, destroy, query and modify.
- devx general command
The new operations depend on HAVE_IBV_DEVX_OBJ.
Signed-off-by: Moti Haimovsky
---
v2:
* Modifications according to review inputs.
see message Id: 154574
This commit fixes the logic for searching and allocating a shared
counter in mlx5_flow_verbs.
Now only the shared counters in the counters list are checked for
a match and not all the counters as before.
Fixes: 84c406e74524 ("net/mlx5: add flow translate function")
Cc: sta...@dpdk.org
Signed-off-
This series of commits add support for creating, allocating, querying
and destroying flow counters in mlx5 PMD using the devx interface.
Moti Haimovsky (3):
net/mlx5: fix shared counter allocation logic
net/mlx5: add devx functions to glue
net/mlx5: support flow counters using devx
drivers
This commit adds counters support when creating flows via direct
verbs. The implementation uses devx interface in order to create
query and delete the counters.
This support requires MLNX_OFED_LINUX-4.5-0.1.0.1 installation.
Signed-off-by: Moti Haimovsky
---
v2:
* Modifications according to code
This commit fixes the logic for searching and allocating a shared
counter in mlx5_flow_verbs.
Now only the shared counters in the counters list are checked for
a match and not all the counters as before.
Fixes: 84c406e74524 ("net/mlx5: add flow translate function")
Cc: sta...@dpdk.org
Signed-off-
This series of commits add support for creating, allocating, querying
and destroying flow counters in mlx5 PMD using the devx interface.
Moti Haimovsky (3):
net/mlx5: fix shared counter allocation logic
net/mlx5: add devx functions to glue
net/mlx5: support flow counters using devx
drivers
This patch adds glue functions for operations:
- dv_open_device.
- devx object create, destroy, query and modify.
- devx general command
The new operations depend on HAVE_IBV_DEVX_OBJ.
Signed-off-by: Moti Haimovsky
---
v2:
* Modifications according to review inputs.
see message Id: 154574
December 29, 2018 10:13 PM
> To: Mordechay Haimovsky ; dev@dpdk.org
> Cc: Mordechay Haimovsky ; sta...@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix shared counter
> allocation logic
>
> Moti, don't you forget to update flow_verbs_counter_release() ?
This patch adds glue functions for operations:
- dv_open_device.
- devx object create, destroy, query and modify.
- devx general command
The new operations depend on HAVE_IBV_DEVX_OBJ.
Signed-off-by: Moti Haimovsky
---
v2:
* Modifications according to review inputs.
see message Id: 154574
This commit adds counters support when creating flows via direct
verbs. The implementation uses devx interface in order to create
query and delete the counters.
This support requires MLNX_OFED_LINUX-4.5-0.1.0.1 installation.
Signed-off-by: Moti Haimovsky
---
v2:
* Modifications according to revir
This commit fixes the logic for searching and allocating a shared
counter in mlx5_flow_verbs.
Now only the shared counters in the counters list are checked for
a match and not all the counters as before.
Fixes: 84c406e74524 ("net/mlx5: add flow translate function")
Cc: sta...@dpdk.org
Signed-off-
This series of commits add support for creating, allocating, querying
and destroying flow counters in mlx5 PMD using the devx interface.
Moti Haimovsky (3):
net/mlx5: fix shared counter allocation logic
net/mlx5: add devx functions to glue
net/mlx5: support flow counters using devx
drivers
This commit modifies the logic for searching an allocating a shared
counter in mlx5_flow_verbs.
modifies commit 84c406e74524 ("net/mlx5: add flow translate function")
Signed-off-by: Moti Haimovsky
---
drivers/net/mlx5/mlx5_flow_verbs.c | 14 +++---
1 file changed, 7 insertions(+), 7 del
This series of commits add support for creating, allocating, querying
and destroying flow counters in mlx5 PMD using the devx interface.
Moti Haimovsky (3):
net/mlx5: modify shared counter allocation logic
net/mlx5: add devx functions to glue
net/mlx5: support flow counters using devx
driv
This patch adds glue functions for operations:
- dv_open_device.
- devx object create, destroy, query and modify.
- devx general command
The new operations depend on HAVE_IBV_DEVX_OBJ.
Signed-off-by: Moti Haimovsky
---
drivers/net/mlx5/Makefile| 5 +++
drivers/net/mlx5/meson.build |
This commit adds counters support when creating flows via direct
verbs. The implementation uses devx interface in order to create
query and delete the counters.
This support requires MLNX_OFED_LINUX-4.5-0.1.0.1 installation.
Signed-off-by: Moti Haimovsky
---
drivers/net/mlx5/Makefile |
This patch replaces the rte_exit routine with error printing when
init_power_library() fails and by that restores the previous behavior
of the program (which was to issue an error message and continue
working if init_power_library fails). This allows the user to still
experience the Rx interrupts f
This commit adds counters support when creating flows via direct
verbs. The implementation uses devx interface in order to create
query and delete the counters.
This support requires MLNX_OFED_LINUX-4.5-0.1.0.1 installation.
devx support in the firmware is enabled via the
"mcra /dev/mst/ 0x3ce4.7:1
The following patches add support in mlx5 PMD for configuring and
reading flow counters from the device e-switch.
Moti Haimovsky (2):
net/mlx5: refactor TC-flow infrastructure
net/mlx5: support e-switch flow count action
drivers/net/mlx5/mlx5.c| 18 +-
drivers/net/mlx5/mlx5.h
This commit refactors tc_flow as a preparation to coming commits
that sends different type of messages and expect differ type of replies
while still using the same underlying routines.
Signed-off-by: Moti Haimovsky
---
v3:
* Rebase on top of
d80c8167c4fe ("net/mlx5: fix compilation issue on A
This commit adds support for configuring flows destined to the mlx5
eswitch with 'count' action and for querying these counts at runtime.
Each flow rule configured by the mlx5 driver is implicitly assigned
with flow counters. These counters can be retrieved when querying
the flow rule via Netlink,
This commit adds support for configuring flows destined to the mlx5
eswitch with 'count' action and for querying these counts at runtime.
It is possible to offload an interface flow rules to the hardware
using DPDK flow commands.
With mlx5 it is also possible to offload a limited set of flow rules
This commit refactors tc_flow as a preparation to coming commits
that sends different type of messages and expect differ type of replies
while still using the same underlying routines.
Signed-off-by: Moti Haimovsky
---
drivers/net/mlx5/mlx5.c | 18 +++
drivers/net/mlx5/mlx5.h
The following patches add support in mlx5 PMD for configuring and
reading flow counters from the device e-switch.
Moti Haimovsky (2):
net/mlx5: refactor TC-flow infrastructure
net/mlx5: support e-switch flow count action
drivers/net/mlx5/mlx5.c| 18 +-
drivers/net/mlx5/mlx5.h
This patch adds support for offloading flow rules with TCP-flags
filter to mlx5 eswitch Hardwrae.
With mlx5 it is possible to offload a limited set of flow rules to
the mlxsw (or e-switch) using the DPDK flow commands using the
"transfer" attribute. This set of flow rules also supports filtering
a
Already done by Ferruh.
See attachment.
Thanks
Moti H.
> -Original Message-
> From: John Daley (johndale) [mailto:johnd...@cisco.com]
> Sent: Wednesday, October 10, 2018 9:56 PM
> To: Mordechay Haimovsky ; Adrien Mazarguil
> ; Shahaf Shuler ;
> Ori Kam ; ferruh.yi...@i
end much time on rte_flow at the
> > moment, please see below.
> >
> > On Tue, Oct 09, 2018 at 02:21:23PM +0100, Ferruh Yigit wrote:
> >> On 10/7/2018 5:31 PM, Ori Kam wrote:
> >>>
> >>>
> >>>> -Original Message-
> >
This patch fixes a bug found in port_flow_query routine which caused
flow query command to fail with the following error "Caught error
type 1 (cause unspecified): unknown object type to retrieve the name
of: Invalid argument".
Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion function
Hi Adrien,
You are correct, the bug is not where we thought it is, moreover the fix breaks
the CLI and should be rejected.
We investigated more and found that the bug is in the port_flow_query routine
Which passes an incorrect argument to rte_flow_conv as follows:
ret = rte_flow_conv(
This patch adds support for offloading flow rules with TCP-flags
filter to mlx5 eswitch Hardwrae.
With mlx5 it is possible to offload a limited set of flow rules to
the mlxsw (or e-switch) using the DPDK flow commands using the
"transfer" attribute. This set of flow rules also supports filtering
a
This patch adds support for offloading flow rules with tcp-flags
filter to mlx5 eswitch hardwrae.
Today, it is possible to offload an interface flow rules to the hardware
using DPDK flow commands.
With mlx5 it is also possible to offload a limited set of flow rules to
the mlxsw (or e-switch) using
This patch fixes a typecast bug found in rte_flow_conv_name routine
used in rte_flow item/action name conversion.
Fixes: 0c2640cbfa7a ("ethdev: add flow API item/action name conversion")
Signed-off-by: Moti Haimovsky
---
v1:
Fixed wrong hash number in "Fixes" message.
---
lib/librte_ethdev/rt
This patch fixes a typecast bug found in rte_flow_conv_name routine
used in rte_flow item/action name conversion.
Fixes: ae6b2cf49505 ("ethdev: add flow API item/action name conversion")
Signed-off-by: Moti Haimovsky
---
lib/librte_ethdev/rte_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 del
:konstantin.anan...@intel.com]
> Sent: Wednesday, July 25, 2018 2:39 PM
> To: Dumitrescu, Cristian ; Mordechay
> Haimovsky ; Thomas Monjalon
> ; Singh, Jasvinder
> Cc: dev@dpdk.org; Iremonger, Bernard ;
> Pattan, Reshma ; olivier.m...@6wind.com; Van
> Haaren, Harry
> Sub
Singh, Jasvinder [mailto:jasvinder.si...@intel.com]
> Sent: Wednesday, July 25, 2018 11:31 AM
> To: Thomas Monjalon ; Dumitrescu, Cristian
>
> Cc: dev@dpdk.org; Mordechay Haimovsky ;
> Iremonger, Bernard ; Pattan, Reshma
> ; olivier.m...@6wind.com
> Subject: RE: [dpdk-dev] [PATCH] ap
bernard.iremon...@intel.com;
> reshma.pat...@intel.com; Mordechay Haimovsky ;
> olivier.m...@6wind.com; cristian.dumitre...@intel.com
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d
>
> Important note:
> testpmd is currently really broken.
> We
Hi,
When starting testpmd after applying the above patch and pressing CTRL+D in the
command prompts, testpmd exits abnormally
Whit the following message :
PANIC in prompt():
CLI poll error (-1)
And a dump trace is displayed.
Issue is traced to the following section in your commit:
- cmdline
inline
> -Original Message-
> From: Matan Azrad
> Sent: Monday, July 9, 2018 4:07 PM
> To: Mordechay Haimovsky ; Adrien Mazarguil
>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v5] net/mlx4: support hardware TSO
>
>
>
> Hi Moti
>
> Please see so
Hi Ferruh,
Can you please send me the output of "gcc -v" on your system ?
Moti
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Wednesday, July 4, 2018 4:49 PM
> To: Mordechay Haimovsky ; Shahaf Shuler
>
> Cc: Adrien Mazarg
-core. - Moti H.
2. Provide a workaround for the problem. - Moti H.
3. Verify that this is actually the issue by running the above scripts
In Ferruh setup and verifying the SSE3 flag is set. - Ferruh Yigit
Moti H.
> -Original Message-
> From: dev [mailto:dev-boun...
Hi,
Didn’t see it in our setups (not an excuse), Investigating
Moti
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Wednesday, July 4, 2018 4:49 PM
> To: Mordechay Haimovsky ; Shahaf Shuler
>
> Cc: Adrien Mazarguil ; dev@dpdk
Inline
> -Original Message-
> From: Shahaf Shuler
> Sent: Monday, July 2, 2018 10:05 AM
> To: Mordechay Haimovsky ; Yongseok Koh
> ; Adrien Mazarguil
> Cc: dev@dpdk.org; Mordechay Haimovsky
> Subject: RE: [dpdk-dev] [PATCH] net/mlx5: add support for 32bit systems
&
Message-
> From: Shahaf Shuler
> Sent: Thursday, January 25, 2018 5:38 PM
> To: Mordechay Haimovsky ; Adrien Mazarguil
>
> Cc: dev@dpdk.org; Mordechay Haimovsky ;
> sta...@dpdk.org
> Subject: RE: [dpdk-stable] [PATCH] net/mlx4: fix no broadcasts reception in
> promis
nd.com; konstantin.anan...@intel.com;
shreyansh.j...@nxp.com; jingjing...@intel.com; helin.zh...@intel.com; Mordechay
Haimovsky ; harry.van.haa...@intel.com
Subject: Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug
On 1/9/2018 8:39 AM, Thomas Monjalon wrote:
Hi Jeff,
I am surpris
Thanks Jeff,
Do you have an estimation on when will these patches be ready ?
Moti H.
> -Original Message-
> From: Guo, Jia [mailto:jia@intel.com]
> Sent: Friday, December 22, 2017 2:16 AM
> To: Gaëtan Rivet ; Mordechay Haimovsky
>
> Cc: dev@dpdk.org
> Subject:
Hello,
I would like to apply this patch in order to review it.
Trying to apply it on 17.11 (and latest) fails due to missing
lib/librte_eal/common/eal_common_vdev.c
Trying to apply it on 17.08.1 fails on missing drivers/bus/pci/bsd/pci.c file
So, on what DPDK version should I apply
Thank you Stephen,
Will gather more review inputs and send a fix.
Moti
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Tuesday, December 12, 2017 3:34 AM
> To: Mordechay Haimovsky
> Cc: gaetan.ri...@6wind.com; dev@dpdk.or
Hello Jeff,
I've failed to apply the patch on latest DPDK (git://dpdk.org/dpdk),
Due to missing eal_common_vdev.c file
What am I doing wrong ?
Moti
$ patch -p1 < dpdk-dev-v6-1-2-eal-add-uevent-monitor-for-hot-plug.patch
patching file drivers/bus/pci/bsd/pci.c
Hunk
Inline
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> Sent: Wednesday, November 8, 2017 4:58 PM
> To: Mordechay Haimovsky
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v1] net/mlx4: improve Rx packet type offloads report
>
> Hi M
See inline
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> Sent: Friday, November 3, 2017 4:23 PM
> To: Mordechay Haimovsky
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v2] net/mlx4: enhance Rx packet type offloads
>
> On Thu, No
51 matches
Mail list logo