[PATCH v7] app/testpmd: expand noisy neighbour forward mode support

header files were added. Signed-off-by: Mike Pattrick --- v2: Reverted changes to random memory lookup v3: Refactored entire patch v4: Implemented recommended formatting changes v5: Corrected copyright statement and formatting changes v6: Reordered some variables, preserved noisy subtype for

Re: [PATCH v6] app/testpmd: expand noisy neighbour forward mode support

On Thu, Jun 8, 2023 at 6:25 AM Ferruh Yigit wrote: > > On 6/8/2023 10:59 AM, Mike Pattrick wrote: > > Previously the noisy neighbour vnf simulation would only operate in io > > mode, forwarding packets as is. However, this limited the usefulness of > > noisy neighbour

[PATCH v6] app/testpmd: expand noisy neighbour forward mode support

header files were added. Signed-off-by: Mike Pattrick --- v2: Reverted changes to random memory lookup v3: Refactored entire patch v4: Implemented recommended formatting changes v5: Corrected copyright statement and formatting changes v6: Reordered some variables, preserved noisy subtype for

Re: [PATCH v5] app/testpmd: expand noisy neighbour forward mode support

On Tue, Jun 6, 2023 at 6:23 PM Ferruh Yigit wrote: > > On 6/6/2023 10:12 PM, Mike Pattrick wrote: > > Previously the noisy neighbour vnf simulation would only operate in io > > mode, forwarding packets as is. However, this limited the usefulness of > > noisy neighbour

[PATCH v5] app/testpmd: expand noisy neighbour forward mode support

header files were added. Signed-off-by: Mike Pattrick --- v2: Reverted changes to random memory lookup v3: Refactored entire patch v4: Implemented recommended formatting changes v5: Corrected copyright statement and formatting changes --- app/test-pmd/5tswap.c | 118

[PATCH v4] app/testpmd: expand noisy neighbour forward mode support

header files were added. Signed-off-by: Mike Pattrick --- v2: Reverted changes to random memory lookup v3: Refactored entire patch v4: Implemented recommended formatting changes --- app/test-pmd/5tswap.c | 118 +-- app/test-pmd/5tswap.h | 130

Re: [PATCH v3] app/testpmd: expand noisy neighbour forward mode support

On Fri, May 26, 2023 at 11:34 AM Kevin Traynor wrote: > > On 17/04/2023 19:55, Mike Pattrick wrote: > > Previously the noisy neighbour vnf simulation would only operate in io > > mode, forwarding packets as is. However, this limited the usefulness of > > noisy neighbour

Re: [RFC 06/27] vhost: don't dump unneeded pages with IOTLB

quot;) > Cc: sta...@dpdk.org > > Signed-off-by: Maxime Coquelin Looks good to me. Acked-by: Mike Pattrick

Re: [RFC 05/27] vhost: add helper for IOTLB entries shared page check

On Wed, Apr 19, 2023 at 5:35 AM Maxime Coquelin wrote: > > Hi Mike, > > On 4/17/23 21:39, Mike Pattrick wrote: > > Hi Maxime, > > > > On Fri, Mar 31, 2023 at 11:43 AM Maxime Coquelin > > wrote: > >> > >> This patch introduces a helpe

Re: [RFC 05/27] vhost: add helper for IOTLB entries shared page check

Hi Maxime, On Fri, Mar 31, 2023 at 11:43 AM Maxime Coquelin wrote: > > This patch introduces a helper to check whether two IOTLB > entries share a page. > > Signed-off-by: Maxime Coquelin > --- > lib/vhost/iotlb.c | 25 - > 1 file changed, 20 insertions(+), 5 deletions(-

Re: [RFC 03/27] vhost: fix IOTLB entries overlap check with previous entry

ent") > Cc: sta...@dpdk.org > > Signed-off-by: Maxime Coquelin Hi Maxime, This makes sense. Acked-by: Mike Pattrick > --- > lib/vhost/iotlb.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c > in

[PATCH v3] app/testpmd: expand noisy neighbour forward mode support

header files were added. Signed-off-by: Mike Pattrick --- v2: Reverted changes to random memory lookup v3: Refactored entire patch --- app/test-pmd/5tswap.c | 118 +-- app/test-pmd/5tswap.h | 130 ++ app/test-pmd/macfwd.c

[PATCH v3] vhost: fix madvise arguments alignment

de VM hugepages from coredumps") Signed-off-by: Mike Pattrick --- Since v1: - Corrected a cast for 32bit compiles Since v2: - Removed changes from rte_vhost.h - Restored set_mem_dump in ioctl remove/evict functions --- lib/vhost/iotlb.c | 68 +++---

Re: [PATCH v2] vhost: fix madvise arguments alignment

On Thu, Feb 23, 2023 at 11:12 AM Maxime Coquelin wrote: > > Hi Mike, > > Thanks for looking into this issue. > > On 2/23/23 05:35, Mike Pattrick wrote: > > The arguments passed to madvise should be aligned to the alignment of > > the backing memory. Now we keep t

[PATCH v2] vhost: fix madvise arguments alignment

de VM hugepages from coredumps") Signed-off-by: Mike Pattrick --- Since v1: - Corrected a cast for 32bit compiles --- lib/vhost/iotlb.c | 9 +++--- lib/vhost/rte_vhost.h | 1 + lib/vhost/vhost.h | 12 ++-- lib/vhost/vhost_user.c | 63 +++--

[PATCH] vhost: fix madvise arguments alignment

de VM hugepages from coredumps") Signed-off-by: Mike Pattrick --- lib/vhost/iotlb.c | 9 +++--- lib/vhost/rte_vhost.h | 1 + lib/vhost/vhost.h | 12 ++-- lib/vhost/vhost_user.c | 63 +++--- 4 files changed, 60 insertions(+), 25 deletions(-) di

Re: [PATCH v3] vhost: exclude VM hugepages from coredumps

On Tue, Feb 21, 2023 at 11:26 AM Maxime Coquelin wrote: > > Hi Mike, > > On 2/10/23 22:12, Mike Pattrick wrote: > > On Fri, Feb 10, 2023 at 10:53 AM David Marchand > > wrote: > >> > >> Hello Mike, > >> > >> On Wed, Dec 7, 2022

Re: [PATCH v3] vhost: exclude VM hugepages from coredumps

On Fri, Feb 10, 2023 at 10:53 AM David Marchand wrote: > > Hello Mike, > > On Wed, Dec 7, 2022 at 5:54 PM Mike Pattrick wrote: > > > > Currently if an application wants to include shared hugepages in > > coredumps in conjunction with the vhost library, the co

Re: [PATCH v2] vhost: exclude VM hugepages from coredumps

On Fri, Feb 3, 2023 at 12:45 PM Stephen Hemminger wrote: > > On Tue, 6 Dec 2022 10:05:09 -0500 > Mike Pattrick wrote: > > > + > > +static __rte_always_inline void > > +mem_set_dump(__rte_unused void *ptr, __rte_unused size_t size, > > __rte_unused bool enab

Re: [PATCH v2] app/testpmd: expand noisy neighbour forward mode support

On Wed, Feb 1, 2023 at 10:19 AM Singh, Aman Deep wrote: > > Hi Mike, > > Thanks a lot for the patch. > > On 1/26/2023 10:25 AM, Mike Pattrick wrote: > > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, thi

[PATCH v2] app/testpmd: expand noisy neighbour forward mode support

which would otherwise be duplicative of noisy mode. Signed-off-by: Mike Pattrick --- v2: - Included header that was incorrectly excluded from v1 - Restored calls to rte_rand() --- app/test-pmd/5tswap.c | 29 ++- app/test-pmd/csumonly.c | 36 +++- app/tes

[PATCH] app/testpmd: expand noisy neighbour forward mode support

esigned to exercise. Signed-off-by: Mike Pattrick --- app/test-pmd/5tswap.c | 29 ++ app/test-pmd/csumonly.c | 36 ++- app/test-pmd/flowgen.c| 24 + app/test-pmd/icmpecho.c | 28 +- app/test-pmd/macfwd.c

[PATCH v4] net/iavf: add lock for vf commands

lbacks") Fixes: 48de41ca11f0 ("net/avf: enable link status update") Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel message") Cc: sta...@dpdk.org Signed-off-by: Mike Pattrick --- v2: - Added locks around some iavf_execute_vf_cmd calls which were

[PATCH v3] net/iavf: add lock for vf commands

lbacks") Fixes: 48de41ca11f0 ("net/avf: enable link status update") Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel message") Cc: sta...@dpdk.org Signed-off-by: Mike Pattrick --- v2: - Added locks around some iavf_execute_vf_cmd calls which were

[PATCH v2] net/iavf: add lock for vf commands

lbacks") Fixes: 48de41ca11f0 ("net/avf: enable link status update") Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel message") Cc: sta...@dpdk.org Signed-off-by: Mike Pattrick --- v2: - Added locks around some iavf_execute_vf_cmd calls which were

[PATCH] net/iavf: add lock for vf commands

108425054a ("net/iavf: support asynchronous virtual channel message") Cc: sta...@dpdk.org Signed-off-by: Mike Pattrick --- drivers/net/iavf/iavf.h | 1 + drivers/net/iavf/iavf_vchnl.c | 76 +++ 2 files changed, 77 insertions(+) diff --git a/dr

[PATCH v3] vhost: exclude VM hugepages from coredumps

. Signed-off-by: Mike Pattrick --- v2: * Removed warning on unsupported platforms v3: * Removed pointer warning on 32bit platforms --- lib/vhost/iotlb.c | 5 + lib/vhost/vhost.h | 12 lib/vhost/vhost_user.c | 10 ++ 3 files changed, 27 insertions(+) diff

[PATCH v2] vhost: exclude VM hugepages from coredumps

. Signed-off-by: Mike Pattrick --- v2: * Removed warning on unsupported platforms --- lib/vhost/iotlb.c | 5 + lib/vhost/vhost.h | 12 lib/vhost/vhost_user.c | 10 ++ 3 files changed, 27 insertions(+) diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c index

[PATCH] vhost: exclude VM hugepages from coredumps

. Signed-off-by: Mike Pattrick --- lib/vhost/iotlb.c | 5 + lib/vhost/vhost.h | 11 +++ lib/vhost/vhost_user.c | 10 ++ 3 files changed, 26 insertions(+) diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c index 6a729e8804..2f89f88817 100644 --- a/lib/vhost/iotlb.c

[PATCH] net/i40e: Populate error in flow_parse_fdir_pattern

Errors from i40e_flow_parse_fdir_pattern() can bubble up to rte_flow_create. If rte_flow_error is not initialized a caller may dereference error->message. This may be uninitialized memory, leading to a segemntation fault. Signed-off-by: Mike Pattrick Fixes: 4a072ad43442 ("net/i40e: