[PATCH] maintainers: update ENA PMD maintainers list

2022-12-27 Thread Michal Krawczyk
The main driver maintenance is now handled by Amazon, and the new Amazon maintainer has been added (Ron Beider). As Semihalf interaction with the ENA PMD is going to be limited, Marcin Wojtas was removed from the maintainers list. Signed-off-by: Michal Krawczyk --- MAINTAINERS | 2 +- 1 file

[PATCH 4/4] net/ena: update version to 2.7.0

2022-06-07 Thread Michal Krawczyk
This release contains changes listed below. - Fast mbuf free feature support. - Device argument to disable the LLQ. - Simplification of the MTU verification. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/4] net/ena: add an option to disable LLQ

2022-06-07 Thread Michal Krawczyk
all for the ENA was updated with all the available devargs (including ENA_DEVARG_MISS_TXC_TO, which wasn't added previously). Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes Reviewed-by: Amit Bernstein --- doc/guides/nics/ena.rst| 9 +++

[PATCH 2/4] net/ena: skip MTU verification

2022-06-07 Thread Michal Krawczyk
From: Dawid Gorecki Remove MTU verification from ena_mtu_set() and ena_start(). It is done by rte_ethdev already, so there is no reason to repeat it inside the ENA driver. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes Reviewed-by: Amit Bernstein

[PATCH 1/4] net/ena: add fast mbuf free support

2022-06-07 Thread Michal Krawczyk
From: Dawid Gorecki Add support for RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE offload. It can be enabled if all the mbufs for a given queue belong to the same mempool and their reference count is equal to 1. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes Reviewed

[PATCH 0/4] net/ena: v2.7.0 driver release

2022-06-07 Thread Michal Krawczyk
ki (2): net/ena: add fast mbuf free support net/ena: skip MTU verification Michal Krawczyk (2): net/ena: add an option to disable LLQ net/ena: update version to 2.7.0 doc/guides/nics/ena.rst| 9 +++ doc/guides/nics/features/ena.ini | 1 + doc/guides/rel_notes/release_

[PATCH v3 21/21] net/ena: update version to 2.6.0

2022-02-23 Thread Michal Krawczyk
get xstat names by ID. - Configurable Tx completions timeout. - Proper setting of the meta-descriptor's DF flag. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/ne

[PATCH v3 20/21] net/ena: don't indicate bad csum for L4 csum error

2022-02-23 Thread Michal Krawczyk
previously. Fixes: 05817057faba ("net/ena: fix indication of bad L4 Rx checksums") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/en

[PATCH v3 19/21] net/ena: don't initialize LLQ when membar isn't exposed

2022-02-23 Thread Michal Krawczyk
check before ena_com_config_dev_mode() call. This prevents the unnecessary operations from being performed. Fixes: 2fca2a98c0d1 ("net/ena: support LLQv2") Cc: sta...@dpdk.org Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/en

[PATCH v3 18/21] net/ena: extend debug prints for invalid req ID resets

2022-02-23 Thread Michal Krawczyk
From: Dawid Gorecki Add information about port id, queue id and req_id to error logs in validate_tx_req_id. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v3 17/21] net/ena: fix meta-desc DF flag setup

2022-02-23 Thread Michal Krawczyk
s definition for the given platform/compiler, for safety DF field is being set explicitly to 1. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev

[PATCH v3 16/21] net/ena: make Tx completion timeout configurable

2022-02-23 Thread Michal Krawczyk
the user. Also specyfing default Tx completion timeout value was moved from the configuration to init phase in order to simplify default value assignment. Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- doc/guides/nics/ena.rst| 9 +

[PATCH v3 15/21] net/ena: check if reset was already triggered

2022-02-23 Thread Michal Krawczyk
reset wasn't triggered yet. Replace all occurrences of manually setting the reset with ena_trigger_reset call. Fixes: 2081d5e2e92d ("net/ena: add reset routine") Cc: sta...@dpdk.org Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/e

[PATCH v3 14/21] net/ena: add API for probing xstat names by ID

2022-02-23 Thread Michal Krawczyk
ENA was only supporting retrieval of all the xstats name and wasn't implementing the eth_xstats_get_names_by_id API. As this API may be more efficient than retrieving all the names, it tries to avoid excessive string copying. Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Rev

[PATCH v3 13/21] net/ena: expose Tx cleanup function

2022-02-23 Thread Michal Krawczyk
packets that was freed. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- doc/guides/nics/features/ena.ini | 1 + doc/guides/rel_notes/release_22_03.rst | 1 + drivers/net/ena/ena_ethdev.c | 27 ++ 3 files changed, 21

[PATCH v3 12/21] net/ena/base: make IO memzone unique per port

2022-02-23 Thread Michal Krawczyk
ation. The memzone is now being identified by the local to port memzone counter and the port ID - both of those information can be found in the shared data, so it can be probed easily. Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- doc/guides/nics/fea

[PATCH v3 11/21] net/ena: enable stats get function for MP mode

2022-02-23 Thread Michal Krawczyk
From: Stanislaw Kardach Since statistic gathering is now proxied safely to primary process, it can be enabled in secondary processes. Signed-off-by: Stanislaw Kardach Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 3 --- 1 file changed, 3 deletions

[PATCH v3 10/21] net/ena: proxy AQ calls to primary process

2022-02-23 Thread Michal Krawczyk
arguments as used). 4. Adding request handling logic to ena_mp_primary_handle() 5. Replacing proxied function calls with ENA_PROXY(adapter, , ...) Signed-off-by: Stanislaw Kardach Reviewed-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- v3: * Fix FreeBSD build

[PATCH v3 09/21] net/ena/base: use optimized memcpy version also on Arm

2022-02-23 Thread Michal Krawczyk
when the flag RTE_ARCH_ARM64_MEMCPY was defined * For arm only when the flag RTE_ARCH_ARM_NEON_MEMCPY was defined Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- doc/guides/rel_notes/release_22_03.rst | 1 + drivers/net/ena/base/ena_plat_dpdk.h | 7

[PATCH v3 08/21] net/ena: perform Tx cleanup before sending pkts

2022-02-23 Thread Michal Krawczyk
To increase likehood that current burst will fit in the HW rings, perform Tx cleanup before pushing packets to the HW. It may increase latency a bit for sparse bursts, but the Tx flow now should be more smooth. It's also common order in the Tx burst function for other PMDs. Signed-off-by: M

[PATCH v3 07/21] net/ena: skip timer if the reset is triggered

2022-02-23 Thread Michal Krawczyk
. Fixes: d9b8b106bf9d ("net/ena: add watchdog and keep alive AENQ handler") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drive

[PATCH v3 06/21] net/ena: make LSC configurable

2022-02-23 Thread Michal Krawczyk
with the possibility to configure the LSC, ENA should respect that. AENQ groups are now being updated upon configure step, thus LSC can be activated or disabled between ENA PMD reconfigurations. Moreover, the LSC capability for the device is being determined dynamically. Signed-off-by: Michal Krawczyk

[PATCH v3 05/21] net/ena: add extra Rx checksum related xstats

2022-02-23 Thread Michal Krawczyk
* Split 'bad_csum' Rx statistic into 'l3_csum_bad' and 'l4_csum_bad' to be able to check which checksum was not calculated properly. * Add l4_csum_good statistic, which shows how many times L4 Rx checksum was properly offloaded. Signed-off-by: Michal Krawcz

[PATCH v3 04/21] net/ena: remove unused offloads variables

2022-02-23 Thread Michal Krawczyk
Those variables are being set, but never read. As they seem to be leftover from the old offloads API and don't have any purpose right now, they are simply being removed. Signed-off-by: Michal Krawczyk Reviewed-by: Artur Rojek Reviewed-by: Dawid Gorecki Reviewed-by: Igor Chauskin Review

[PATCH v3 03/21] net/ena: remove unused enumeration

2022-02-23 Thread Michal Krawczyk
The enumeration seems to be leftover from porting the Linux driver to the DPDK. It was used nowhere and refers to the ethtool which is not present in the DPDK. Signed-off-by: Michal Krawczyk Reviewed-by: Artur Rojek Reviewed-by: Dawid Gorecki Reviewed-by: Igor Chauskin Reviewed-by: Shai

[PATCH v3 02/21] net/ena: add assertion on Tx info mbuf

2022-02-23 Thread Michal Krawczyk
To make sure there is no outstanding mbuf in the reused Tx queue (due to unproper cleanup, or some invalid logic on Tx path), the assertion was added on the Tx path. As it's being compiled out in the release version, it won't affect the IO path performance. Signed-off-by: Micha

[PATCH v3 01/21] net/ena: remove linearization function

2022-02-23 Thread Michal Krawczyk
ause of those 2 circumstances, it may be safer to avoid modifying mbuf on PMD's Tx side and remove linearization at all. Instead, add verification of the number of segments to the eth_ena_prep_pkts(). Signed-off-by: Michal Krawczyk Reviewed-by: Artur Rojek Reviewed-by: Dawid Gorecki Review

[PATCH v3 00/21] net/ena: v2.6.0 driver update

2022-02-23 Thread Michal Krawczyk
nd by the checkpatch. Dawid Gorecki (4): net/ena: expose Tx cleanup function net/ena: check if reset was already triggered net/ena: extend debug prints for invalid req ID resets net/ena: don't initialize LLQ when membar isn't exposed Michal Krawczyk (15): net/ena: remov

[PATCH v2 21/21] net/ena: update version to 2.6.0

2022-02-22 Thread Michal Krawczyk
get xstat names by ID. - Configurable Tx completions timeout. - Proper setting of the meta-descriptor's DF flag. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/ne

[PATCH v2 20/21] net/ena: don't indicate bad csum for L4 csum error

2022-02-22 Thread Michal Krawczyk
previously. Fixes: 05817057faba ("net/ena: fix indication of bad L4 Rx checksums") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/en

[PATCH v2 19/21] net/ena: don't initialize LLQ when membar isn't exposed

2022-02-22 Thread Michal Krawczyk
check before ena_com_config_dev_mode() call. This prevents the unnecessary operations from being performed. Fixes: 2fca2a98c0d1 ("net/ena: support LLQv2") Cc: sta...@dpdk.org Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/en

[PATCH v2 18/21] net/ena: extend debug prints for invalid req ID resets

2022-02-22 Thread Michal Krawczyk
From: Dawid Gorecki Add information about port id, queue id and req_id to error logs in validate_tx_req_id. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v2 17/21] net/ena: fix meta-desc DF flag setup

2022-02-22 Thread Michal Krawczyk
s definition for the given platform/compiler, for safety DF field is being set explicitly to 1. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev

[PATCH v2 16/21] net/ena: make Tx completion timeout configurable

2022-02-22 Thread Michal Krawczyk
the user. Also specyfing default Tx completion timeout value was moved from the configuration to init phase in order to simplify default value assignment. Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- doc/guides/nics/ena.rst| 9 +

[PATCH v2 15/21] net/ena: check if reset was already triggered

2022-02-22 Thread Michal Krawczyk
reset wasn't triggered yet. Replace all occurrences of manually setting the reset with ena_trigger_reset call. Fixes: 2081d5e2e92d ("net/ena: add reset routine") Cc: sta...@dpdk.org Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/e

[PATCH v2 14/21] net/ena: add API for probing xstat names by ID

2022-02-22 Thread Michal Krawczyk
ENA was only supporting retrieval of all the xstats name and wasn't implementing the eth_xstats_get_names_by_id API. As this API may be more efficient than retrieving all the names, it tries to avoid excessive string copying. Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Rev

[PATCH v2 13/21] net/ena: expose Tx cleanup function

2022-02-22 Thread Michal Krawczyk
packets that was freed. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- doc/guides/nics/features/ena.ini | 1 + doc/guides/rel_notes/release_22_03.rst | 1 + drivers/net/ena/ena_ethdev.c | 27 ++ 3 files changed, 21

[PATCH v2 12/21] net/ena/base: make IO memzone unique per port

2022-02-22 Thread Michal Krawczyk
ation. The memzone is now being identified by the local to port memzone counter and the port ID - both of those information can be found in the shared data, so it can be probed easily. Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- doc/guides/nics/fea

[PATCH v2 11/21] net/ena: enable stats get function for MP mode

2022-02-22 Thread Michal Krawczyk
From: Stanislaw Kardach Since statistic gathering is now proxied safely to primary process, it can be enabled in secondary processes. Signed-off-by: Stanislaw Kardach Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 3 --- 1 file changed, 3 deletions

[PATCH v2 10/21] net/ena: proxy AQ calls to primary process

2022-02-22 Thread Michal Krawczyk
arguments as used). 4. Adding request handling logic to ena_mp_primary_handle() 5. Replacing proxied function calls with ENA_PROXY(adapter, , ...) Signed-off-by: Stanislaw Kardach Reviewed-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- doc/guides/rel_notes

[PATCH v2 09/21] net/ena/base: use optimized memcpy version also on Arm

2022-02-22 Thread Michal Krawczyk
when the flag RTE_ARCH_ARM64_MEMCPY was defined * For arm only when the flag RTE_ARCH_ARM_NEON_MEMCPY was defined Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- doc/guides/rel_notes/release_22_03.rst | 1 + drivers/net/ena/base/ena_plat_dpdk.h | 7

[PATCH v2 08/21] net/ena: perform Tx cleanup before sending pkts

2022-02-22 Thread Michal Krawczyk
To increase likehood that current burst will fit in the HW rings, perform Tx cleanup before pushing packets to the HW. It may increase latency a bit for sparse bursts, but the Tx flow now should be more smooth. It's also common order in the Tx burst function for other PMDs. Signed-off-by: M

[PATCH v2 07/21] net/ena: skip timer if the reset is triggered

2022-02-22 Thread Michal Krawczyk
. Fixes: d9b8b106bf9d ("net/ena: add watchdog and keep alive AENQ handler") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drive

[PATCH v2 06/21] net/ena: make LSC configurable

2022-02-22 Thread Michal Krawczyk
with the possibility to configure the LSC, ENA should respect that. AENQ groups are now being updated upon configure step, thus LSC can be activated or disabled between ENA PMD reconfigurations. Moreover, the LSC capability for the device is being determined dynamically. Signed-off-by: Michal Krawczyk

[PATCH v2 05/21] net/ena: add extra Rx checksum related xstats

2022-02-22 Thread Michal Krawczyk
* Split 'bad_csum' Rx statistic into 'l3_csum_bad' and 'l4_csum_bad' to be able to check which checksum was not calculated properly. * Add l4_csum_good statistic, which shows how many times L4 Rx checksum was properly offloaded. Signed-off-by: Michal Krawcz

[PATCH v2 04/21] net/ena: remove unused offloads variables

2022-02-22 Thread Michal Krawczyk
Those variables are being set, but never read. As they seem to be leftover from the old offloads API and don't have any purpose right now, they are simply being removed. Signed-off-by: Michal Krawczyk Reviewed-by: Artur Rojek Reviewed-by: Dawid Gorecki Reviewed-by: Igor Chauskin Review

[PATCH v2 03/21] net/ena: remove unused enumeration

2022-02-22 Thread Michal Krawczyk
The enumeration seems to be leftover from porting the Linux driver to the DPDK. It was used nowhere and refers to the ethtool which is not present in the DPDK. Signed-off-by: Michal Krawczyk Reviewed-by: Artur Rojek Reviewed-by: Dawid Gorecki Reviewed-by: Igor Chauskin Reviewed-by: Shai

[PATCH v2 02/21] net/ena: add assertion on Tx info mbuf

2022-02-22 Thread Michal Krawczyk
To make sure there is no outstanding mbuf in the reused Tx queue (due to unproper cleanup, or some invalid logic on Tx path), the assertion was added on the Tx path. As it's being compiled out in the release version, it won't affect the IO path performance. Signed-off-by: Micha

[PATCH v2 01/21] net/ena: remove linearization function

2022-02-22 Thread Michal Krawczyk
ause of those 2 circumstances, it may be safer to avoid modifying mbuf on PMD's Tx side and remove linearization at all. Instead, add verification of the number of segments to the eth_ena_prep_pkts(). Signed-off-by: Michal Krawczyk Reviewed-by: Artur Rojek Reviewed-by: Dawid Gorecki Review

[PATCH v2 00/21] net/ena: v2.6.0 driver update

2022-02-22 Thread Michal Krawczyk
rints for invalid req ID resets net/ena: don't initialize LLQ when membar isn't exposed Michal Krawczyk (15): net/ena: remove linearization function net/ena: add assertion on Tx info mbuf net/ena: remove unused enumeration net/ena: remove unused offloads variables net/en

[PATCH 21/21] net/ena: update version to 2.6.0

2022-02-22 Thread Michal Krawczyk
get xstat names by ID. - Configurable Tx completions timeout. - Proper setting of the meta-descriptor's DF flag. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/ne

[PATCH 20/21] net/ena: don't indicate bad csum for L4 csum error

2022-02-22 Thread Michal Krawczyk
previously. Fixes: 05817057faba ("net/ena: fix indication of bad L4 Rx checksums") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/en

[PATCH 19/21] net/ena: don't initialize LLQ when membar isn't exposed

2022-02-22 Thread Michal Krawczyk
check before ena_com_config_dev_mode() call. This prevents the unnecessary operations from being performed. Fixes: 2fca2a98c0d1 ("net/ena: support LLQv2") Cc: sta...@dpdk.org Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/en

[PATCH 18/21] net/ena: extend debug prints for invalid req ID resets

2022-02-22 Thread Michal Krawczyk
From: Dawid Gorecki Add information about port id, queue id and req_id to error logs in validate_tx_req_id. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH 17/21] net/ena: fix meta-desc DF flag setup

2022-02-22 Thread Michal Krawczyk
s definition for the given platform/compiler, for safety DF field is being set explicitly to 1. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev

[PATCH 16/21] net/ena: make Tx completion timeout configurable

2022-02-22 Thread Michal Krawczyk
the user. Also specyfing default Tx completion timeout value was moved from the configuration to init phase in order to simplify default value assignment. Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- doc/guides/nics/ena.rst| 9 +

[PATCH 15/21] net/ena: check if reset was already triggered

2022-02-22 Thread Michal Krawczyk
wasn't triggered yet. Replace all occurences of manually setting the reset with ena_trigger_reset call. Fixes: 2081d5e2e92d ("net/ena: add reset routine") Cc: sta...@dpdk.org Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/e

[PATCH 14/21] net/ena: add API for probing xstat names by ID

2022-02-22 Thread Michal Krawczyk
ENA was only supporting retrieval of all the xstats name and wasn't implementing the eth_xstats_get_names_by_id API. As this API may be more efficient than retrieving all the names, it tries to avoid excessive string copying. Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Rev

[PATCH 13/21] net/ena: expose Tx cleanup function

2022-02-22 Thread Michal Krawczyk
packets that was freed. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- doc/guides/nics/features/ena.ini | 1 + doc/guides/rel_notes/release_22_03.rst | 1 + drivers/net/ena/ena_ethdev.c | 27 ++ 3 files changed, 21

[PATCH 12/21] net/ena/base: make IO memzone unique per port

2022-02-22 Thread Michal Krawczyk
ation. The memzone is now being identified by the local to port memzone counter and the port ID - both of those information can be found in the shared data, so it can be probed easily. Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- doc/guides/nics/fea

[PATCH 11/21] net/ena: enable stats get function for MP mode

2022-02-22 Thread Michal Krawczyk
From: Stanislaw Kardach Since statistic gathering is now proxied safely to primary process, it can be enabled in secondary processes. Signed-off-by: Stanislaw Kardach Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 3 --- 1 file changed, 3 deletions

[PATCH 10/21] net/ena: proxy AQ calls to primary process

2022-02-22 Thread Michal Krawczyk
arguments as used). 4. Adding request handling logic to ena_mp_primary_handle() 5. Replacing proxied function calls with ENA_PROXY(adapter, , ...) Signed-off-by: Stanislaw Kardach Reviewed-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- doc/guides/rel_notes

[PATCH 09/21] net/ena/base: use optimized memcpy version also on Arm

2022-02-22 Thread Michal Krawczyk
when the flag RTE_ARCH_ARM64_MEMCPY was defined * For arm only when the flag RTE_ARCH_ARM_NEON_MEMCPY was defined Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- doc/guides/rel_notes/release_22_03.rst | 1 + drivers/net/ena/base/ena_plat_dpdk.h | 7

[PATCH 08/21] net/ena: perform Tx cleanup before sending pkts

2022-02-22 Thread Michal Krawczyk
To increase likehood that current burst will fit in the HW rings, perform Tx cleanup before pushing packets to the HW. It may increase latency a bit for sparse bursts, but the Tx flow now should be more smooth. It's also common order in the Tx burst function for other PMDs. Signed-off-by: M

[PATCH 07/21] net/ena: skip timer if the reset is triggered

2022-02-22 Thread Michal Krawczyk
. Fixes: d9b8b106bf9d ("net/ena: add watchdog and keep alive AENQ handler") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drive

[PATCH 06/21] net/ena: make LSC configurable

2022-02-22 Thread Michal Krawczyk
with the possibility to configure the LSC, ENA should respect that. AENQ groups are now being updated upon configure step, thus LSC can be activated or disabled between ENA PMD reconfigurations. Moreover, the LSC capability for the device is being determined dynamically. Signed-off-by: Michal Krawczyk

[PATCH 05/21] net/ena: add extra Rx checksum related xstats

2022-02-22 Thread Michal Krawczyk
* Split 'bad_csum' Rx statistic into 'l3_csum_bad' and 'l4_csum_bad' to be able to check which checksum was not calculated properly. * Add l4_csum_good statistic, which shows how many times L4 Rx checksum was properly offloaded. Signed-off-by: Michal Krawcz

[PATCH 04/21] net/ena: remove unused offloads variables

2022-02-22 Thread Michal Krawczyk
Those variables are being set, but never read. As they seem to be leftover from the old offloads API and don't have any purpose right now, they are simply being removed. Signed-off-by: Michal Krawczyk Reviewed-by: Artur Rojek Reviewed-by: Dawid Gorecki Reviewed-by: Igor Chauskin Review

[PATCH 03/21] net/ena: remove unused enumeration

2022-02-22 Thread Michal Krawczyk
The enumeration seems to be leftover from porting the Linux driver to the DPDK. It was used nowhere and refers to the ethtool which is not present in the DPDK. Signed-off-by: Michal Krawczyk Reviewed-by: Artur Rojek Reviewed-by: Dawid Gorecki Reviewed-by: Igor Chauskin Reviewed-by: Shai

[PATCH 02/21] net/ena: add assertion on Tx info mbuf

2022-02-22 Thread Michal Krawczyk
To make sure there is no outstanding mbuf in the reused Tx queue (due to unproper cleanup, or some invalid logic on Tx path), the assertion was added on the Tx path. As it's being compiled out in the release version, it won't affect the IO path performance. Signed-off-by: Micha

[PATCH 01/21] net/ena: remove linearization function

2022-02-22 Thread Michal Krawczyk
ause of those 2 circumstances, it may be safer to avoid modifying mbuf on PMD's Tx side and remove linearization at all. Instead, add verification of the number of segments to the eth_ena_prep_pkts(). Signed-off-by: Michal Krawczyk Reviewed-by: Artur Rojek Reviewed-by: Dawid Gorecki Review

[PATCH 00/21] net/ena: v2.6.0 driver update

2022-02-22 Thread Michal Krawczyk
DPDK API support and extra error checks. Dawid Gorecki (4): net/ena: expose Tx cleanup function net/ena: check if reset was already triggered net/ena: extend debug prints for invalid req ID resets net/ena: don't initialize LLQ when membar isn't exposed Michal Krawczyk (15): net/e

[PATCH] bus/pci: assign driver's pointer before mapping

2022-01-19 Thread Michal Krawczyk
c: sta...@dpdk.org Signed-off-by: Michal Krawczyk --- drivers/bus/pci/pci_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 4a3a87f24f..def372b67e 100644 --- a/drivers/bus/pci/pci_common.c +++

[PATCH] doc: remove custom kernel patch link in ENA's guide

2021-11-22 Thread Michal Krawczyk
A PMD documentation, which describes vfio-pci and ENAv2 issue more deeply with possible workarounds on how to resolve it. Signed-off-by: Michal Krawczyk --- doc/guides/nics/ena.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/en

[dpdk-dev] [PATCH v3 7/7] net/ena: update version to 2.5.0

2021-10-19 Thread Michal Krawczyk
. * Check for the missing Tx completions. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 1a70cd781c..4d2f7d727c 100644 --- a/drivers/net/ena/ena_ethdev.c

[dpdk-dev] [PATCH v3 6/7] net/ena: add check for missing Tx completions

2021-10-19 Thread Michal Krawczyk
the missing Tx completion. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/net/ena/ena_ethdev.c | 118 + drivers/net/ena/ena_ethdev.h | 15 3 files

[dpdk-dev] [PATCH v3 5/7] net/ena: add NUMA aware allocations

2021-10-19 Thread Michal Krawczyk
Only the IO rings memory was allocated with taking the socket ID into the respect, while the other structures was allocated using the regular rte_zmalloc() API. Ring specific structures are now being allocated using the ring's socket ID. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Cha

[dpdk-dev] [PATCH v3 4/7] net/ena: indicate missing scattered Rx capability

2021-10-19 Thread Michal Krawczyk
polling-mode driver") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 655c

[dpdk-dev] [PATCH v3 3/7] net/ena: fix per-queue offload capabilities

2021-10-19 Thread Michal Krawczyk
;net/ena: convert to new Rx offloads API") Fixes: 56b8b9b7e5d2 ("net/ena: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 89

[dpdk-dev] [PATCH v3 2/7] net/ena: support Tx/Rx free thresholds

2021-10-19 Thread Michal Krawczyk
anup budget as it can be inadequate to the used burst. Now the PMD tries to release mbufs for the ring until it will be depleted. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- v2: * Fix calculations of the default tx_free_thresh if it wasn't prov

[dpdk-dev] [PATCH v3 1/7] net/ena: fix verification of the offload capabilities

2021-10-19 Thread Michal Krawczyk
ments. With the RTE_LIBRTE_ETHDEV_DEBUG enabled, the function will do even more verifications, to help the user find any issues with the mbuf configuration. Fixes: b3fc5a1ae10d ("net/ena: add Tx preparation") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin

[dpdk-dev] [PATCH v3 0/7] net/ena: update ENA PMD to v2.5.0

2021-10-19 Thread Michal Krawczyk
]x_free_thresh configuration parameters Regards, Michal v3: * Rebase series on top of recent changed to resolve conflicts regarding the driver's offload flags (especially the DEV_RX_OFFLOAD_JUMBO_FRAME). Michal Krawczyk (7): net/ena: fix verification of the offload capabilities net/ena: support

[dpdk-dev] [PATCH v2 7/7] net/ena: update version to 2.5.0

2021-10-15 Thread Michal Krawczyk
. * Check for the missing Tx completions. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 5554057ed3..cad9d46198 100644 --- a/drivers/net/ena/ena_ethdev.c

[dpdk-dev] [PATCH v2 6/7] net/ena: add check for missing Tx completions

2021-10-15 Thread Michal Krawczyk
the missing Tx completion. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/net/ena/ena_ethdev.c | 118 + drivers/net/ena/ena_ethdev.h | 15 3 files

[dpdk-dev] [PATCH v2 5/7] net/ena: add NUMA aware allocations

2021-10-15 Thread Michal Krawczyk
Only the IO rings memory was allocated with taking the socket ID into the respect, while the other structures was allocated using the regular rte_zmalloc() API. Ring specific structures are now being allocated using the ring's socket ID. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Cha

[dpdk-dev] [PATCH v2 4/7] net/ena: indicate missing scattered Rx capability

2021-10-15 Thread Michal Krawczyk
polling-mode driver") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_

[dpdk-dev] [PATCH v2 3/7] net/ena: fix per-queue offload capabilities

2021-10-15 Thread Michal Krawczyk
;net/ena: convert to new Rx offloads API") Fixes: 56b8b9b7e5d2 ("net/ena: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 90

[dpdk-dev] [PATCH v2 2/7] net/ena: support Tx/Rx free thresholds

2021-10-15 Thread Michal Krawczyk
anup budget as it can be inadequate to the used burst. Now the PMD tries to release mbufs for the ring until it will be depleted. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- v2: * Fix calculations of the default tx_free_thresh if it wasn't prov

[dpdk-dev] [PATCH v2 1/7] net/ena: fix verification of the offload capabilities

2021-10-15 Thread Michal Krawczyk
ments. With the RTE_LIBRTE_ETHDEV_DEBUG enabled, the function will do even more verifications, to help the user find any issues with the mbuf configuration. Fixes: b3fc5a1ae10d ("net/ena: add Tx preparation") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin

[dpdk-dev] [PATCH 0/7] net/ena: update ENA PMD to v2.5.0

2021-10-15 Thread Michal Krawczyk
]x_free_thresh configuration parameters Regards, Michal Michal Krawczyk (7): net/ena: fix verification of the offload capabilities net/ena: support Tx/Rx free thresholds net/ena: fix per-queue offload capabilities net/ena: indicate missing scattered Rx capability net/ena: add NUMA aware allocations

[dpdk-dev] [PATCH 7/7] net/ena: update version to 2.5.0

2021-10-14 Thread Michal Krawczyk
. * Check for the missing Tx completions. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 7e2086617a..9e2f1bcc09 100644 --- a/drivers/net/ena/ena_ethdev.c

[dpdk-dev] [PATCH 6/7] net/ena: add check for missing Tx completions

2021-10-14 Thread Michal Krawczyk
the missing Tx completion. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/net/ena/ena_ethdev.c | 118 + drivers/net/ena/ena_ethdev.h | 15 3 files

[dpdk-dev] [PATCH 5/7] net/ena: add NUMA aware allocations

2021-10-14 Thread Michal Krawczyk
Only the IO rings memory was allocated with taking the socket ID into the respect, while the other structures was allocated using the regular rte_zmalloc() API. Ring specific structures are now being allocated using the ring's socket ID. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Cha

[dpdk-dev] [PATCH 4/7] net/ena: indicate missing scattered Rx capability

2021-10-14 Thread Michal Krawczyk
polling-mode driver") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_

[dpdk-dev] [PATCH 3/7] net/ena: fix per-queue offload capabilities

2021-10-14 Thread Michal Krawczyk
;net/ena: convert to new Rx offloads API") Fixes: 56b8b9b7e5d2 ("net/ena: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 90

[dpdk-dev] [PATCH 2/7] net/ena: support Tx/Rx free thresholds

2021-10-14 Thread Michal Krawczyk
anup budget as it can be inadequate to the used burst. Now the PMD tries to release mbufs for the ring until it will be depleted. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- doc/guides/rel_notes/release_21_11.rst | 7 drivers/

[dpdk-dev] [PATCH 1/7] net/ena: fix verification of the offload capabilities

2021-10-14 Thread Michal Krawczyk
ments. With the RTE_LIBRTE_ETHDEV_DEBUG enabled, the function will do even more verifications, to help the user find any issues with the mbuf configuration. Fixes: b3fc5a1ae10d ("net/ena: add Tx preparation") Cc: sta...@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin

[dpdk-dev] [PATCH 0/7] net/ena: update ENA PMD to v2.5.0

2021-10-14 Thread Michal Krawczyk
]x_free_thresh configuration parameters Regards, Michal Michal Krawczyk (7): net/ena: fix verification of the offload capabilities net/ena: support Tx/Rx free thresholds net/ena: fix per-queue offload capabilities net/ena: indicate missing scattered Rx capability net/ena: add NUMA aware allocations

[dpdk-dev] [PATCH] maintainers: update for ena

2021-07-23 Thread Michal Krawczyk
Remove Guy Tzalik as the driver's maintainer and add Shai Brandes who will now be another maintainer of the ENA DPDK driver. Signed-off-by: Michal Krawczyk --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8b5a3f0249..8013b

[dpdk-dev] [PATCH v4 6/6] net/ena: update version to v2.4.0

2021-07-23 Thread Michal Krawczyk
This version update contains: * Rx interrupts feature, * Support for the RSS hash function reconfiguration, * Small rework of the works, * Reset trigger on Tx path fix. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

  1   2   3   4   5   >