[dpdk-dev] [PATCH] test/pmd_perf: fix for segmentation fault

2017-10-13 Thread Michal Jastrzebski
From: Daniel Mrzyglod Error can be reproduce if we run pmd_perf_autotest with more then one device in such way: RTE>>set_rxtx_sc poll_before_xmit RTE>>pmd_perf_autotest two threads are working without synchronization and we are unable to say on which port in the index will came packet. Fixes: 0

[dpdk-dev] [PATCH v2] net/vmxnet3: fix dereference before null check

2017-09-29 Thread Michal Jastrzebski
vel up the callstack (function vmxnet3_dev_clear_queues). Coverity issue: 143468 Fixes: 5aecdc17a97d ("vmxnet3: fix stop/restart") Cc: yongw...@vmware.com Cc: sta...@dpdk.org Signed-off-by: Tomasz Kulasek Signed-off-by: Michal Jastrzebski --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 8 +++

[dpdk-dev] [PATCH] app/testpmd: fix runtime dead code

2017-09-29 Thread Michal Jastrzebski
From: Tomasz Kulasek Coverity reports DEADCODE, as assumes that RTE_LIBRTE_I40E_PMD is defined and function compiles entirely. The fix is about to place printf function into #else branch of conditional compilation, since it is known at compile time if i40e is supported. No need to check it at ru

[dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not terminated

2017-09-22 Thread Michal Jastrzebski
From: Jacek Piasecki Fix size of buffer in strcpy. There was possible to get not terminated string after copy operation. Coverity issue: 158629 Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app") Cc: changpeng@intel.com Cc: sta...@dpdk.org Signed-off-by: Jacek Piasecki

[dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not terminated

2017-09-22 Thread Michal Jastrzebski
From: Jacek Piasecki Fix size of buffer in strcpy. There was possible to get not terminated string after copy operation. Coverity issue: 158631 Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app") Cc: changpeng@intel.com Cc: sta...@dpdk.org Signed-off-by: Jacek Piasecki

[dpdk-dev] [PATCH] net/vmxnet3: fix dereference before null check

2017-09-22 Thread Michal Jastrzebski
From: Tomasz Kulasek Coverity error: check_after_deref: Null-checking rq suggests that it may be null, but it has already been dereferenced on all paths leading to the check. This patch moves NULL checking of "rq" at the very beginning of the path before an

[dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not terminated

2017-09-22 Thread Michal Jastrzebski
From: Jacek Piasecki Fix size of buffer in strcpy. There was possible to get not terminated string after copy operation. Coverity issue: 158631 Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app") Cc: changpeng@intel.com Cc: sta...@dpdk.org Signed-off-by: Jacek Piasecki

[dpdk-dev] [PATCH] net/vmxnet3: fix dereference before null check

2017-09-22 Thread Michal Jastrzebski
From: Tomasz Kulasek Coverity error: check_after_deref: Null-checking rq suggests that it may be null, but it has already been dereferenced on all paths leading to the check. This patch moves NULL checking of "rq" at the very beginning of the path before an

[dpdk-dev] [PATCH] net/i40e: fix assignment of enum values

2017-09-22 Thread Michal Jastrzebski
From: Tomasz Kulasek mixed_enums: Mixing enum types enum i40e_vsi_type and enum virtchnl_vsi_type for type Coverity issue 158651 Fixes: a58860f68929 ("net/i40e/base: use new virtchnl header file") Cc: jingjing...@intel.com Cc: sta...@dpdk.org Signed-off-by: Tomasz Kulasek --- dri

[dpdk-dev] [PATCH v2] vfio: fix close unchecked file descriptor

2017-09-21 Thread Michal Jastrzebski
From: Kuba Kozak Add file descriptor value check before calling close() function. Coverity issue: 141297 Fixes: 811b6b25060f ("vfio: fix file descriptor leak in multi-process") Cc: patr...@patrickmacarthur.net Cc: sta...@dpdk.org Signed-off-by: Kuba Kozak Acked-by: Anatoly Burakov --- v2:

[dpdk-dev] [PATCH] app/testpmd: fix bonding initialization due to unproper name

2017-07-13 Thread Michal Jastrzebski
t;bus/vdev: remove probe with driver name option") Signed-off-by: Michal Jastrzebski --- app/test-pmd/cmdline.c |2 +- drivers/net/bonding/rte_eth_bond_alb.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd

[dpdk-dev] [PATCH] cryptodev: make crypto session device independent

2017-05-26 Thread Michal Jastrzebski
From: Slawomir Mrozowicz Change crypto device's session management to make it device independent and simplify architecture when session is intended to be used on more than one device. Sessions private data is agnostic to underlying device by adding an indirection in the sessions private data usi

[dpdk-dev] [PATCH] cryptodev: make crypto session device independent

2017-05-26 Thread Michal Jastrzebski
From: Slawomir Mrozowicz Change crypto device's session management to make it device independent and simplify architecture when session is intended to be used on more than one device. Sessions private data is agnostic to underlying device by adding an indirection in the sessions private data usi

[dpdk-dev] [PATCH 3/3] drivers/net: add support for IF-MIB and EtherLike-MIB for ixgbe

2017-05-22 Thread Michal Jastrzebski
Signed-off-by: Piotr Azarewicz Signed-off-by: Michal Jastrzebski --- drivers/net/ixgbe/ixgbe_ethdev.c | 275 +++--- drivers/net/ixgbe/ixgbe_ethdev.h | 59 2 files changed, 317 insertions(+), 17 deletions(-) diff --git a/drivers/net/ixgbe

[dpdk-dev] [PATCH 2/3] drivers/net: add support for IF-MIB and EtherLike-MIB for i40e

2017-05-22 Thread Michal Jastrzebski
Signed-off-by: Piotr Azarewicz Signed-off-by: Michal Jastrzebski --- drivers/net/i40e/i40e_ethdev.c | 171 +++- drivers/net/i40e/i40e_ethdev.h | 60 ++ 2 files changed, 230 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e

[dpdk-dev] [PATCH 1/3] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000

2017-05-22 Thread Michal Jastrzebski
Signed-off-by: Piotr Azarewicz Signed-off-by: Michal Jastrzebski --- drivers/net/e1000/e1000_ethdev.h | 59 drivers/net/e1000/igb_ethdev.c | 296 ++ 2 files changed, 331 insertions(+), 24 deletions(-) diff --git a/drivers/net/e1000

[dpdk-dev] [PATCH 0/3] drivers/net: add support for IF-MIB and EtherLike-MIB

2017-05-22 Thread Michal Jastrzebski
dot3StatsRateControlAbility dot3StatsRateControlStatus dot3ControlFunctionsSupported Michal Jastrzebski (3): drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 drivers/net: add support for IF-MIB and EtherLike-MIB for i40e drivers/net: add support for IF-MIB and EtherLike-MIB for ixgbe

[dpdk-dev] [PATCH v1 6/6] net/ixgbe: support xstats by ID

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak To achieve functionality of retrieving only specific statistics given by application there are two new functions added: ixgbe_dev_xstats_get_by_ids() which retrieve values of statistics specified by ids array and ixgbe_dev_xstats_get_names_by_ids() which retrieve names of statist

[dpdk-dev] [PATCH v1 5/6] net/e1000: support xstats by ID

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak To achieve functionality of retrieving only specific statistics given by application there are two new functions added: eth_igb_xstats_get_by_id() which retrieve values of statistics specified by ids array and eth_igb_xstats_get_names_by_id() which retrieve names of statistics sp

[dpdk-dev] [PATCH v1 4/6] app/proc-info: support xstats by ID and by name

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak There are new arguments --xstats-ids and --xstats-name in proc_info command line to retrieve statistics given by ids and by name. E.g. --xstats-ids="1,3,5,7,8" E.g. --xstats-name rx_errors Signed-off-by: Kuba Kozak --- app/proc_info/main.c | 150 +++

[dpdk-dev] [PATCH v1 3/6] ethdev: get xstats ID by name

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak Introduced new function: rte_eth_xstats_get_id_by_name to retrieve xstats ids by its names. doc: added release note Signed-off-by: Kuba Kozak --- doc/guides/rel_notes/release_17_05.rst | 2 ++ lib/librte_ether/rte_ethdev.c | 44 ++ li

[dpdk-dev] [PATCH v1 2/6] ethdev: retrieve xstats by ID

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak Extended xstats API in ethdev library to allow grouping of stats logically so they can be retrieved per logical grouping managed by the application. Added new functions rte_eth_xstats_get_names_by_id and rte_eth_xstats_get_by_id using additional arguments (in compare to rte_eth_

[dpdk-dev] [PATCH v1 1/6] ethdev: revert patches extending xstats API in ethdev

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak Revert patches to provide clear view for upcoming changes. Reverted patches are listed below: commit ea85e7d711b6 ("ethdev: retrieve xstats by ID") commit a954495245c4 ("ethdev: get xstats ID by name") commit 1223608adb9b ("app/proc-info: support xstats by ID") commit 25e38f09af9

[dpdk-dev] [PATCH v1 0/6] Extended xstats API in ethdev library to allow grouping of stats

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak This patchset fixes following patches: commit ea85e7d711b6 ("ethdev: retrieve xstats by ID") commit a954495245c4 ("ethdev: get xstats ID by name") commit 1223608adb9b ("app/proc-info: support xstats by ID") commit 25e38f09af9c ("net/e1000: support xstats by ID")

[dpdk-dev] [PATCH] app/proc-info: fix proc-info xstats-name description string

2017-04-21 Thread Michal Jastrzebski
fix proc-info xstats-name description string Fixes: 1223608adb9b ("app/proc-info: support xstats by ID") Signed-off-by: Michal Jastrzebski --- app/proc_info/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/proc_info/main.c b/app/proc_info/main.c ind

[dpdk-dev] [PATCH v5 3/3] net/ixgbe: new xstats API add ID support for ixgbe

2017-04-11 Thread Michal Jastrzebski
From: Jacek Piasecki To achieve functionality of retrieving only specific statistics given by application there are two new functions added: ixgbe_dev_xstats_get_by_ids() which retrieve values of statistics specified by ids array and ixgbe_dev_xstats_get_names_by_ids() which retrieve names of sta

[dpdk-dev] [PATCH v5 2/3] net/e1000: new xstats API add ID support for e1000

2017-04-11 Thread Michal Jastrzebski
From: Jacek Piasecki To achieve functionality of retrieving only specific statistics given by application there are two new functions added: eth_igb_xstats_get_by_ids() which retrieve values of statistics specified by ids array and eth_igb_xstats_get_names_by_ids() which retrieve names of statist

[dpdk-dev] [PATCH v5 1/3] ethdev: new xstats API add retrieving by ID

2017-04-11 Thread Michal Jastrzebski
From: Jacek Piasecki Extended xstats API in ethdev library to allow grouping of stats logically so they can be retrieved per logical grouping managed by the application. Changed existing functions rte_eth_xstats_get_names and rte_eth_xstats_get to use a new list of arguments: array of ids and ar

[dpdk-dev] [PATCH v5 0/3] Extended xstats API in ethdev library to allow grouping of stats

2017-04-11 Thread Michal Jastrzebski
From: Jacek Piasecki Extended xstats API in ethdev library to allow grouping of stats logically so they can be retrieved per logical grouping managed by the application. Changed existing functions rte_eth_xstats_get_names and rte_eth_xstats_get to use a new list of arguments: array of ids and ar

[dpdk-dev] [PATCH v2 5/5] add support for new xstats API retrieving by id

2017-03-30 Thread Michal Jastrzebski
Add support for new xstats API retrieving by id in testpmd application Signed-off-by: Jacek Piasecki Signed-off-by: Kuba Kozak --- app/test-pmd/config.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 804

[dpdk-dev] [PATCH v2 4/5] add support for new xstats API retrieving by id

2017-03-30 Thread Michal Jastrzebski
Add support for new xstats API retrieving by id to proc_info application Signed-off-by: Jacek Piasecki Signed-off-by: Kuba Kozak --- app/proc_info/main.c | 56 +--- 1 file changed, 45 insertions(+), 11 deletions(-) diff --git a/app/proc_info/main

[dpdk-dev] [PATCH v2 3/5] add new xstats API id support for ixgbe

2017-03-30 Thread Michal Jastrzebski
add new xstats API id support for ixgbe Signed-off-by: Jacek Piasecki Signed-off-by: Kuba Kozak --- drivers/net/ixgbe/ixgbe_ethdev.c | 178 +++ 1 file changed, 178 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c

[dpdk-dev] [PATCH v2 2/5] add new xstats API id support for e1000

2017-03-30 Thread Michal Jastrzebski
Add new xstats API id support for e1000 Signed-off-by: Jacek Piasecki Signed-off-by: Kuba Kozak --- drivers/net/e1000/igb_ethdev.c | 92 +- 1 file changed, 90 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/i

[dpdk-dev] [PATCH v2 1/5] add new xstats API retrieving by id

2017-03-30 Thread Michal Jastrzebski
Extended xstats API in ethdev library to allow grouping of stats logically so they can be retrieved per logical grouping – managed by the application. Changed existing functions rte_eth_xstats_get_names and rte_eth_xstats_get to use a new list of arguments: array of ids and array of values. ABI ver

[dpdk-dev] [PATCH v2 0/5] Extended xstats API in ethdev library to allow grouping of stats

2017-03-30 Thread Michal Jastrzebski
Extended xstats API in ethdev library to allow grouping of stats logically so they can be retrieved per logical grouping – managed by the application. Changed existing functions rte_eth_xstats_get_names and rte_eth_xstats_get to use a new list of arguments: array of ids and array of values. ABI ver

[dpdk-dev] [PATCH v2] crypto/aesni_gcm: migration from MB library to ISA-L

2016-12-27 Thread Michal Jastrzebski
From: Piotr Azarewicz Current Cryptodev AESNI-GCM PMD is implemented using AESNI-MB library.This patch reimplement Cryptodev AESni-GCM using ISA-L Crypto library: https://github.com/01org/isa-l_crypto. In new version 256-bit key support and AAD variable length is available. Verified current unit

[dpdk-dev] [PATCH 2/2] app/crypto-perf: Introduce new performance test application

2016-12-02 Thread Michal Jastrzebski
This patchset introduce new application which allows measuring performance parameters of PMDs available in crypto tree. The goal of this application is to replace existing performance tests in app/test. Parameters available are: throughput (--ptest throughput) and latency (--ptest latency). User ca

[dpdk-dev] [PATCH 1/2] lib/librte_cryptodev: functions for new performance test application

2016-12-02 Thread Michal Jastrzebski
This patch adds helper functions for new performance application. Application can be used to measute throughput and latency of cryptography operation performed by crypto device. Signed-off-by: Declan Doherty Signed-off-by: Slawomir Mrozowicz Signed-off-by: Marcin Kerlin --- lib/librte_cryptode

[dpdk-dev] [PATCH 0/2] Introduce new performance test application

2016-12-02 Thread Michal Jastrzebski
This patchset introduce new application which allows measuring performance parameters of PMDs available in crypto tree. The goal of this application is to replace existing performance tests in app/test. Parameters available are: throughput (--ptest throughput) and latency (--ptest latency). User ca

[dpdk-dev] [PATCH] crypto/aesni_gcm: migration from MB library to ISA-L

2016-12-02 Thread Michal Jastrzebski
From: Piotr Azarewicz Current Cryptodev AESNI-GCM PMD is implemented using AESNI-MB library.This patch reimplement Cryptodev AESni-GCM using ISA-L Crypto library: https://github.com/01org/isa-l_crypto. In new version 256-bit key support and AAD variable lenght is available. Verified current unit

[dpdk-dev] [PATCH v2 4/4] examples/l2fwd-crypto: updated example for libcrypto PMD

2016-09-19 Thread Michal Jastrzebski
From: Slawomir Mrozowicz To verify real traffic l2fwd-crypto example can be used with this command: sudo ./build/l2fwd-crypto -c 0x3 -n 4 --vdev "cryptodev_libcrypto_pmd" --vdev "cryptodev_libcrypto_pmd" -- -p 0x3 --chain CIPHER_HASH --cipher_op ENCRYPT --cipher_algo AES_CBC --cipher_key 00:01:02

[dpdk-dev] [PATCH v2 3/4] app/test: added tests for libcrypto PMD

2016-09-19 Thread Michal Jastrzebski
From: Slawomir Mrozowicz This patch containes unit tests for libcrypto PMD. User can use app/test application to check how to use this pmd and to verify crypto processing. Test name is cryptodev_libcrypto_autotest. For performance test cryptodev_libcrypto_perftest can be used. Signed-off-by: Pi

[dpdk-dev] [PATCH v2 2/4] lib/cryptodev: added support to libcrypto PMD

2016-09-19 Thread Michal Jastrzebski
From: Slawomir Mrozowicz This patch adds libcrypto poll mode driver support to librte_cryptodev library. Signed-off-by: Slawomir Mrozowicz --- lib/librte_cryptodev/rte_cryptodev.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptode

[dpdk-dev] [PATCH v2 1/4] libcrypto_pmd: initial implementation of SW crypto device

2016-09-19 Thread Michal Jastrzebski
From: Slawomir Mrozowicz This code provides the initial implementation of the libcrypto poll mode driver. All cryptography operations are using Openssl library crypto API. Each algorithm uses EVP_ interface from openssl API - which is recommended by Openssl maintainers. LibCrypto PMD has support

[dpdk-dev] [PATCH v2 0/4] new crypto software based device

2016-09-19 Thread Michal Jastrzebski
From: Marcin Kerlin This code provides the initial implementation of the libcrypto poll mode driver. All cryptography operations are using Openssl library crypto API. Each algorithm uses EVP_ interface from openssl API which is recommended by Openssl maintainers. For more information about how t

[dpdk-dev] [PATCH v2 0/4] new crypto software based device

2016-09-19 Thread Michal Jastrzebski
From: Marcin Kerlin This code provides the initial implementation of the libcrypto poll mode driver. All cryptography operations are using Openssl library crypto API. Each algorithm uses EVP_ interface from openssl API which is recommended by Openssl maintainers. For more information about how t

[dpdk-dev] [PATCH v2] eal: fix check number of bytes from read function

2016-07-22 Thread Michal Jastrzebski
Signed-off-by: Michal Jastrzebski --- lib/librte_eal/linuxapp/eal/eal_memory.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index 42a29fa..e20a38c 100644 --- a/lib/

[dpdk-dev] [PATCH] eal: fix check number of bytes from read function

2016-07-20 Thread Michal Jastrzebski
issue: 13212 Fixes: 40b966a211ab ("ivshmem: library changes for mmaping using ivshmem"). Signed-off-by: Michal Jastrzebski --- lib/librte_eal/linuxapp/eal/eal_memory.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_memor

[dpdk-dev] [PATCH] lib/table: fix wrong type of nht field

2016-06-20 Thread Michal Jastrzebski
From: Michal Kobylinski Change type of nht field from uint32_t to uint8_t and increase max of next hops. Fixes: dc81ebbacaeb ("lpm: extend IPv4 next hop field") Signed-off-by: Michal Kobylinski Acked-by: Cristian Dumitrescu --- examples/ip_pipeline/pipeline/pipeline_routing_be.h | 2 +- lib/

[dpdk-dev] [PATCH] bond: replace rte_panic with errno code return

2016-05-27 Thread Michal Jastrzebski
This patch modifies bond_mode_alb_enable function. When mempool allocation fails errno code is returned instead of rte_panic. This allow to decide on application level if it should quit or retry for mempool allocation. Signed-off-by: Michal Jastrzebski --- drivers/net/bonding/rte_eth_bond_alb.c

[dpdk-dev] [PATCH] app/test: fix bond device name too long

2016-05-27 Thread Michal Jastrzebski
Bond device name was too long (grather than 32 signs) that cause mempool allocation to fail. Fixes: 92073ef961ee ("bond: unit tests") Signed-off-by: Michal Jastrzebski --- app/test/test_link_bonding.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 6/6] examples/ip_pipeline: modifies flow action pipeline CLI

2016-05-06 Thread Michal Jastrzebski
All commands merged into one: cmd_action_parsed. modified bulk command: action flow bulk File line format: flow meter 0 meter 1 meter 2 meter 3 policer 0policer 1 policer 2policer 3 port at least one meter needs to be provided (can be any meter ID) and at least one

[dpdk-dev] [PATCH 5/6] examples/ip_pipeline: modifies flow classifications pipeline CLI

2016-05-06 Thread Michal Jastrzebski
This patch modifies flow classifications pipeline command line interface. All commands are merged into one cmd_fc_parsed. Additionally a classification for ipv6, ipv4 and qinq can be added from configuration file. 1. flow add qinq bulk File line format: qinq port id File line example: qinq 1 2

[dpdk-dev] [PATCH 4/6] examples/ip_pipeline: modifies firewall pipeline CLI

2016-05-06 Thread Michal Jastrzebski
Each command are merged into one: cmd_firewall_parsed. ADD command format is changed: p firewall add priority ipv4 port and bulk command was modified: 1. firewall add bulk File line format: priority ipv4 port (protomask is a hex value) File line example: priority 0 ipv4 1.

[dpdk-dev] [PATCH 3/6] examples/ip_pipeline: modifies routing commands

2016-05-06 Thread Michal Jastrzebski
several routing commands are merged into two commands: route and arp - these two commands are handled by cli library. Rest of the commands are handled internaly by the pipeline code. Signed-off-by: Piotr Azarewicz --- examples/ip_pipeline/pipeline/pipeline_routing.c | 1774 ++

[dpdk-dev] [PATCH 2/6] examples/ip_pipeline: modifies common pipeline CLI

2016-05-06 Thread Michal Jastrzebski
All commands are merged into one command: cmd_link_parsed. Signed-off-by: Tomasz Kulasek --- examples/ip_pipeline/pipeline/pipeline_common_fe.c | 309 - 1 file changed, 111 insertions(+), 198 deletions(-) diff --git a/examples/ip_pipeline/pipeline/pipeline_common_fe.c b/exa

[dpdk-dev] [PATCH 1/6] examples/ip_pipeline: add helper functions for parsing string

2016-05-06 Thread Michal Jastrzebski
Add a couple of additional functions that will allow to parse many types of input parameters, i.e.: bool, 16, 32, 64 bits, hex, etc. Signed-off-by: Piotr Azarewicz --- examples/ip_pipeline/Makefile | 1 + examples/ip_pipeline/config_parse.c | 242 + examples/ip_pipeline/parse

[dpdk-dev] [PATCH 0/6] ip_pipeline: CLI rework and improvements

2016-05-06 Thread Michal Jastrzebski
Using the latest librte_cmdline improvements, the CLI implementation of the ip_pipeline application is streamlined and improved, which results in eliminating thousands of lines of code from the application, thus leading to code that is easier to maintain and extend. Michal Jastrzebski (6

[dpdk-dev] [PATCH v3] examples/qos_sched: fix bad bit shift operation

2016-04-21 Thread Michal Jastrzebski
From: Slawomir Mrozowicz Fix issue reported by Coverity. Coverity ID 30690: Bad bit shift operation large_shift: In expression 1ULL << i, left shifting by more than 63 bits has undefined behavior. The shift amount, i, is as much as 127. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-

[dpdk-dev] [PATCH v3] examples/qos_sched: fix copy-paste error

2016-04-21 Thread Michal Jastrzebski
From: Slawomir Mrozowicz Fix issue reported by Coverity. Coverity ID 30699: Copy-paste error; rx_port in pconf->rx_port looks like a copy-paste error. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: Slawomir Mrozowicz --- examples/qos_sched/args.c | 2 +- 1 file changed, 1 inser

[dpdk-dev] [PATCH v3] examples/qos_sched: fix negative loop bound

2016-04-21 Thread Michal Jastrzebski
From: Slawomir Mrozowicz Fix issue reported by Coverity. Coverity ID 30704: Negative loop bound negative_returns: Using unsigned variable n_tokens in a loop exit condition. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: Slawomir Mrozowicz --- examples/qos_sched/args.c | 2 +- 1

[dpdk-dev] [PATCH v2] examples/qos_sched: fix out-of-bounds read

2016-04-21 Thread Michal Jastrzebski
From: Slawomir Mrozowicz Fix issue reported by Coverity. Coverity ID 30708: Out-of-bounds read overrun-local: Overrunning array tokens of 8 8-byte elements at element index 4294967294 (byte offset 34359738352) using index i (which evaluates to 4294967294). Fixes: de3cfa2c9823 ("sched: initial i

[dpdk-dev] [PATCH v2] examples/qos_meter: fix unchecked return value

2016-04-21 Thread Michal Jastrzebski
From: Slawomir Mrozowicz Fix issue reported by Coverity. Coverity ID 30693: Unchecked return value check_return: Calling rte_meter_srtcm_config without checking return value. Fixes: e6541fdec8b2 ("meter: initial import") Signed-off-by: Slawomir Mrozowicz --- examples/qos_meter/main.c | 15 ++

[dpdk-dev] [PATCH v2] examples/qos_sched: fix negative loop bound

2016-04-21 Thread Michal Jastrzebski
Fix issue reported by Coverity. Date: Thu, 21 Apr 2016 13:47:35 +0200 Message-Id: <1461239256-8104-4-git-send-email-michalx.k.jastrzebski at intel.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1461239256-8104-1-git-send-email-michalx.k.jastrzebski at intel.com> References: <1461239256-8104-1-

[dpdk-dev] [PATCH v2] examples/qos_sched: fix copy-paste error

2016-04-21 Thread Michal Jastrzebski
Fix issue reported by Coverity. Date: Thu, 21 Apr 2016 13:47:34 +0200 Message-Id: <1461239256-8104-3-git-send-email-michalx.k.jastrzebski at intel.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1461239256-8104-1-git-send-email-michalx.k.jastrzebski at intel.com> References: <1461239256-8104-1-

[dpdk-dev] [PATCH v2] examples/qos_sched: fix bad bit shift operation

2016-04-21 Thread Michal Jastrzebski
Fix issue reported by Coverity. Date: Thu, 21 Apr 2016 13:47:33 +0200 Message-Id: <1461239256-8104-2-git-send-email-michalx.k.jastrzebski at intel.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1461239256-8104-1-git-send-email-michalx.k.jastrzebski at intel.com> References: <1461239256-8104-1-

[dpdk-dev] [PATCH] app: fix for lpm in ip_pipeline

2016-03-17 Thread Michal Jastrzebski
From: Michal Kobylinski Updated ip_pipeline app is using new changes from LPM library (Increased number of next hops and added new config structure for LPM IPv4). Fixes: 7164439d017d ("lpm: add a new config structure for IPv4") Signed-off-by: Michal Kobylinski Acked-by: Cristian Dumitrescu

[dpdk-dev] [PATCH v5 2/2] lpm: added a new rte_lpm_config structure for ipv4

2016-03-09 Thread Michal Jastrzebski
From: Michal Kobylinski This patch has depend on: lpm: extended ipv4 next_hop field (v4). A new rte_lpm_config structure is used so LPM library will allocate exactly the amount of memory which is necessary to hold application?s rules. Signed-off-by: Michal Kobylinski Acked-by: David Hunt ---

[dpdk-dev] [PATCH v5 1/2] lpm: extended ipv4 next_hop field

2016-03-09 Thread Michal Jastrzebski
From: Michal Kobylinski This patch extend next_hop field from 8-bits to 24-bits in LPM library for IPv4. Added versioning symbols to functions and updated library and applications that have a dependency on LPM library. Signed-off-by: Michal Kobylinski Acked-by: David Hunt --- app/test/test_l

[dpdk-dev] [PATCH v5 0/2] Increased number of next hops for LPM IPv4.

2016-03-09 Thread Michal Jastrzebski
From: Michal Kobylinski This patchset extend next_hop field from 8-bits to 24-bits in LPM library for IPv4. As next_hop field is increased now the maximum number of tbl8s is 2^24. A new rte_lpm_config structure is used so LPM library will allocate exactly the amount of memory which is necessar

[dpdk-dev] [PATCH v2] lpm: added a new rte_lpm_config structure for ipv4

2016-03-09 Thread Michal Jastrzebski
From: Michal Kobylinski This patch depends on: lpm: extended ipv4 next_hop field (v4). A new rte_lpm_config structure is used so LPM library will allocate exactly the amount of memory which is necessary to hold application?s rules. Signed-off-by: Michal Kobylinski Acked-by: David Hunt ---

[dpdk-dev] [PATCH v4] lpm: extended ipv4 next_hop field

2016-03-09 Thread Michal Jastrzebski
From: Michal Kobylinski This patch extend next_hop field from 8-bits to 24-bits in LPM library for IPv4. Added versioning symbols to functions and updated library and applications that have a dependency on LPM library. Signed-off-by: Michal Kobylinski Acked-by: David Hunt --- app/test/test_l

[dpdk-dev] [PATCH v1 0/3] lpm: increase number of next hops for lpm (ipv4)

2015-10-26 Thread Michal Jastrzebski
uint8_t next_hop; }; #endif /** @internal Rule structure. */ struct rte_lpm_rule { uint32_t ip; /**< Rule IP address. */ uint8_t next_hop; /**< Rule next hop. */ }; /** @internal Contains metadata about the rules table. */ error: patch failed: lib/librte_lpm

[dpdk-dev] [PATCH v1 3/3] doc: update release 2.2 after changes in librte_lpm

2015-10-23 Thread Michal Jastrzebski
From: Michal Kobylinski Signed-off-by: Michal Kobylinski --- doc/guides/rel_notes/release_2_2.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index ab1c25f..3c616ab 100644 --- a/doc/guides/rel_notes/release_2

[dpdk-dev] [PATCH v1 2/3] examples: update of apps using librte_lpm (ipv4)

2015-10-23 Thread Michal Jastrzebski
From: Michal Kobylinski This patch is adapting examples to use new rte_lpm structures. Signed-off-by: Michal Kobylinski --- examples/ip_fragmentation/main.c | 10 +- examples/ip_reassembly/main.c| 9 + examples/l3fwd-power/main.c | 2 +- examples/l3fwd-vf/main.c

[dpdk-dev] [PATCH v1 1/3] lpm: increase number of next hops for lpm (ipv4)

2015-10-23 Thread Michal Jastrzebski
From: Michal Kobylinski Main implementation - changes to lpm library regarding new data types. Additionally this patch implements changes required by test application. ABI versioning requirements are met only for lpm library, for table library it will be sent in v2 of this patch-set. Signed-of

[dpdk-dev] [PATCH v1 0/3] lpm: increase number of next hops for lpm (ipv4)

2015-10-23 Thread Michal Jastrzebski
From: Michal Kobylinski The current DPDK implementation for LPM for IPv4 and IPv6 limits the number of next hops to 256, as the next hop ID is an 8-bit long field. Proposed extension increase number of next hops for IPv4 to 2^24 and also allows 32-bits read/write operations. This patchset requi

[dpdk-dev] [PATCH v4 5/5] doc: modify release notes and deprecation notice for table and pipeline

2015-10-20 Thread Michal Jastrzebski
From: Marcin Kerlin The release notes is updated and the deprecation announce is removed. Signed-off-by: Maciej Gajdzica Signed-off-by: Marcin Kerlin Acked-by: Cristian Dumitrescu --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_2_2.rst | 2 +- 2 files changed,

[dpdk-dev] [PATCH v4 4/5] ip_pipline: added cli commands for bulk add/delete to firewall pipeline

2015-10-20 Thread Michal Jastrzebski
From: Marcin Kerlin Added two new cli commands to firewall pipeline. Commands bulk add and bulk delete takes as argument a file with rules to add/delete. The file is parsed, and then rules are passed to backend functions which add/delete records from pipeline tables. Signed-off-by: Maciej Gajdzi

[dpdk-dev] [PATCH v4 3/5] test_table: added check for bulk add/delete to acl table unit test

2015-10-20 Thread Michal Jastrzebski
From: Marcin Kerlin Added to acl table unit test check for bulk add and bulk delete. Signed-off-by: Maciej Gajdzica Acked-by: Cristian Dumitrescu --- app/test/test_table_acl.c | 166 ++ 1 file changed, 166 insertions(+) diff --git a/app/test/test_t

[dpdk-dev] [PATCH v4 2/5] pipeline: added bulk add/delete functions for table

2015-10-20 Thread Michal Jastrzebski
From: Marcin Kerlin Added functions for adding/deleting multiple records to table owned by pipeline. The LIBABIVER number is incremented for table and pipeline libraries. Signed-off-by: Maciej Gajdzica Signed-off-by: Marcin Kerlin Acked-by: Cristian Dumitrescu --- lib/librte_pipeline/Makefil

[dpdk-dev] [PATCH v4 1/5] table: added bulk add/delete functions for table

2015-10-20 Thread Michal Jastrzebski
From: Marcin Kerlin New functions prototypes for bulk add/delete added to table API. New functions allows adding/deleting multiple records with single function call. For now those functions are implemented only for ACL table. For other tables these function pointers are set to NULL. Signed-off-b

[dpdk-dev] [PATCH v4 0/5] pipeline: add bulk add/delete functions for table

2015-10-20 Thread Michal Jastrzebski
From: Marcin Kerlin This patch adds bulk add/delete functions for tables used by pipelines. It allows for adding/deleting many rules to pipeline tables in one function call. It is particulary useful for firewall pipeline which is using ACL table. After every add or delete, table is rebuild which

[dpdk-dev] [PATCH v2] test: fix test_tlb_tx_burst

2015-08-07 Thread Michal Jastrzebski
cient to verify that with high load (2 seconds transsmission) all slaves are trasnitting so the traffic is balanced. v2 changes: - improved description - reverted number of packets generated (in v1 it was decreased, but to achieve balancing it has to be high load). Signed-off-by: M

[dpdk-dev] [PATCH] test: fix test_tlb_tx_burst

2015-08-05 Thread Michal Jastrzebski
This patch fixes error in tlb_tx_burst function: Distribution is not even. A condition in TEST_ASSERT macro was changed, as the previous one was random. Also the time of generating packets can now be decreased. Signed-off-by: Michal Jastrzebski --- app/test/test_link_bonding.c | 12

[dpdk-dev] [PATCH] doc: fix doxygen warnings for QoS API

2015-06-17 Thread Michal Jastrzebski
This patch fix doxygen warnings when generating documentation for qos_meter and qos_sched Signed-off-by: Michal Jastrzebski --- lib/librte_meter/rte_meter.h | 8 lib/librte_sched/rte_bitmap.h | 10 +- lib/librte_sched/rte_red.h| 44

[dpdk-dev] [PATCH v4 1/1] pipeline: add statistics for librte_pipeline ports and tables

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica This patch adds statistics collection for librte_pipeline. Those statistics ale disabled by default during build time. Signed-off-by: Pawel Wodkowski --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_pipeline/rte_pipe

[dpdk-dev] [PATCH v4 10/10] table: added lpm table stats

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica Added lpm table statistics. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_lpm.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/lib/librte_table/rte_table_lpm.c b/lib/librte_table/rte_table_lpm.c index 64c684d..300

[dpdk-dev] [PATCH v4 09/10] table: added lpm_ipv6 table stats

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica Added lpm ipv6 table statistics. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_lpm_ipv6.c | 34 + 1 file changed, 34 insertions(+) diff --git a/lib/librte_table/rte_table_lpm_ipv6.c b/lib/librte_table/rte_table_lpm_ipv6.

[dpdk-dev] [PATCH v4 08/10] table: added hash_lru table stats

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for hash_lru table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_hash_lru.c | 44 + 1 file changed, 44 insertions(+) diff --git a/lib/librte_table/rte_table_hash_lru.c b/lib/librte_table/rte_table_hash_

[dpdk-dev] [PATCH v4 07/10] table: added hash_key8 table stats

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for hash key8 table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_hash_key8.c | 52 1 file changed, 52 insertions(+) diff --git a/lib/librte_table/rte_table_hash_key8.c b/lib/librte_table/rte_table_has

[dpdk-dev] [PATCH v4 06/10] table: added hash_key32 table stats

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for hash key32 table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_hash_key32.c | 41 +++ 1 file changed, 41 insertions(+) diff --git a/lib/librte_table/rte_table_hash_key32.c b/lib/librte_table/rte_table_h

[dpdk-dev] [PATCH v4 05/10] table: added hash_key16 table stats

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for hash key16 table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_hash_key16.c | 41 +++ 1 file changed, 41 insertions(+) diff --git a/lib/librte_table/rte_table_hash_key16.c b/lib/librte_table/rte_table_h

[dpdk-dev] [PATCH v4 04/10] table: added hash_ext table stats

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for hash ext table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_hash_ext.c | 44 + 1 file changed, 44 insertions(+) diff --git a/lib/librte_table/rte_table_hash_ext.c b/lib/librte_table/rte_table_hash_

[dpdk-dev] [PATCH v4 03/10] table: added array table stats

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for array table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_array.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/lib/librte_table/rte_table_array.c b/lib/librte_table/rte_tabl

[dpdk-dev] [PATCH v4 02/10] table: added acl table stats

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for ACL table. Signed-off-by: Maciej Gajdzica --- lib/librte_table/rte_table_acl.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/lib/librte_table/rte_table_acl.c b/lib/librte_table/rte_table_acl.c index 4416311

[dpdk-dev] [PATCH v4 01/10] table: added structure for storing table stats and config option

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica Added common structure for table statistics. Added config option to enable table stats collecting. Signed-off-by: Maciej Gajdzica --- config/common_bsdapp |1 + config/common_linuxapp |1 + lib/librte_table/rte_table.h | 25

[dpdk-dev] [PATCH v4 00/10] table: added table statistics

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for every type of table. By default all table statistics are disabled, user must activate them in config file. Changes in v2: - added missing signoffs Changes in v3: - removed new config options to enable/disable stats - using RTE_L

[dpdk-dev] [PATCH v4 13/13] port: added port_sink stats

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for sink port. Signed-off-by: Maciej Gajdzica --- lib/librte_port/rte_port_source_sink.c | 63 ++-- 1 file changed, 59 insertions(+), 4 deletions(-) diff --git a/lib/librte_port/rte_port_source_sink.c b/lib/librte_port/rte_

[dpdk-dev] [PATCH v4 12/13] port: added port_source stats

2015-06-08 Thread Michal Jastrzebski
From: Maciej Gajdzica Added statistics for source port. Signed-off-by: Maciej Gajdzica --- lib/librte_port/rte_port_source_sink.c | 35 1 file changed, 35 insertions(+) diff --git a/lib/librte_port/rte_port_source_sink.c b/lib/librte_port/rte_port_source_si

  1   2   3   >