Re: [dpdk-kmods v2] windows/netuio: fix BAR parsing

2022-08-19 Thread Menon, Ranjit
On 8/11/2022 3:17 PM, Pallavi Kadam wrote: Current code was always checking the 'prev_bar & PCI_TYPE_64BIT' though only the first BAR slot of a 64-bit BAR contains flags. Also for certain PCIe devices, BAR values were not continuous. This patch fixes this incorrectness and maps the BAR addresses

Re: [PATCH v2 1/4] eal/windows: translate Windows errors to errno-style errors

2022-04-12 Thread Menon, Ranjit
Hi, Tyler On 4/12/2022 3:43 AM, Tyler Retzlaff wrote: Add function to translate Windows error codes to errno-style error codes. The possible return values are chosen so that we have as much semantical compatibility between platforms as possible. Signed-off-by: Narcisa Vasile Signed-off-by: Tyl

Re: [PATCH] eal/windows: set pthread affinity

2022-01-26 Thread Menon, Ranjit
On 1/20/2022 4:17 PM, Pallavi Kadam wrote: Sometimes OS tries to switch the core. So, bind the lcore thread to a fixed core. Implement affinity call on Windows similar to Linux. Signed-off-by: Qiao Liu Signed-off-by: Pallavi Kadam --- lib/eal/windows/eal.c | 4 1 file changed, 4 insertio

Re: [dpdk-dev] [kmods PATCH 0/4] windows: independent fixes

2021-10-07 Thread Menon, Ranjit
On 10/2/2021 9:18 AM, Dmitry Kozlyuk wrote: Fixes for building with Windows Development Kit 22000.1 and some build configuration cleanup. Dmitry Kozlyuk (4): windows: specify signature hash algorithm windows/virt2phys: support only x86 configurations windows/virt2phys: change setup clas

Re: [dpdk-dev] [kmods PATCH v2 4/4] windows/virt2phys: add tracing

2021-09-30 Thread Menon, Ranjit
Typo below: On 9/30/2021 3:07 PM, Menon, Ranjit wrote: Hi Dmitry, On 5/26/2021 2:01 PM, Dmitry Kozlyuk wrote: WPP tracing [1] allows kernel drivers to print logs that can be viewed without attaching a debugger to the running system. Traces are colelcted only when enabled. Instrument virt2phys

Re: [dpdk-dev] [kmods PATCH v2 4/4] windows/virt2phys: add tracing

2021-09-30 Thread Menon, Ranjit
Hi Dmitry, On 5/26/2021 2:01 PM, Dmitry Kozlyuk wrote: WPP tracing [1] allows kernel drivers to print logs that can be viewed without attaching a debugger to the running system. Traces are colelcted only when enabled. Instrument virt2phys with traces: * ERROR: failures that prevent the driver

Re: [dpdk-dev] [PATCH] bus/pci: fix unknown NUMA node value on Windows

2021-09-27 Thread Menon, Ranjit
(Sending the ACK again since Outlook appeared to make the email address a smart link!) On 9/27/2021 11:43 AM, Pallavi Kadam wrote: Based on the rte_eth_dev_socket_id() documentation, set the default numa_node to -1. When the API is unsuccessful, set numa_node to 0. This change more correctly re

Re: [dpdk-dev] [PATCH] bus/pci: fix unknown NUMA node value on Windows

2021-09-27 Thread Menon, Ranjit
On 9/27/2021 11:43 AM, Pallavi Kadam wrote: Based on the rte_eth_dev_socket_id() documentation, set the default numa_node to -1. When the API is unsuccessful, set numa_node to 0. This change more correctly resembles the Linux code. Fixes: bf7cf1f947bd ("bus/pci: fix unknown NUMA node value on

Re: [dpdk-dev] [PATCH] windows/netuio: add Intel Virtual Function device IDs

2021-09-15 Thread Menon, Ranjit
Hi, Dmitry On 9/15/2021 12:07 PM, Dmitry Kozlyuk wrote: 2021-09-14 17:51 (UTC-0700), Pallavi Kadam: Add Intel Ethernet Virtual Function device IDs to netuio inf file to support Intel 40GbE and 100GbE deives on Windows VM. Nit: why only VM? Can't VF be used from the host? I'm not an expert he

Re: [dpdk-dev] [PATCH 0/2] eal/windows: restore mistakenly hidden API

2021-09-01 Thread Menon, Ranjit
On 8/28/2021 7:16 PM, Dmitry Kozlyuk wrote: Some functions were not exported, and UUID API not even built on Windows for no compelling reason. This hasn't been an issue so far, because only static build is currently available on Windows, however: 1) it's better to have fewer differences between p

Re: [dpdk-dev] [PATCH] eal/windows: cleanup virt2phys handle

2021-07-26 Thread Menon, Ranjit
On 7/26/2021 2:36 PM, Dmitry Kozlyuk wrote: eal_mem_virt2phys_init() opens a handle for use by rte_mem_virt2phy(). Close this handle on EAL cleanup. Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") Cc: sta...@dpdk.org Signed-off-by: Dmitry Kozlyuk --- lib/eal/windows/ea

Re: [dpdk-dev] [PATCH] bus/pci: support segment value as address domain on Windows

2020-09-10 Thread Menon, Ranjit
On 9/10/2020 12:30 AM, Tal Shnaiderman wrote: Subject: Re: [PATCH] bus/pci: support segment value as address domain on Windows On Tue, Aug 25, 2020 at 02:43:16PM +0300, Tal Shnaiderman wrote: Set the domain value for rte_pci_addr probing on Windows to the value of the PCI segment returned by

Re: [dpdk-dev] [EXTERNAL] Windows Support Plan

2020-02-03 Thread Menon, Ranjit
Cc: Thomas Monjalon ; Kadam, Pallavi ; Burakov, Anatoly ; Menon, Ranjit ; Harini Ramakrishnan Subject: Re: [EXTERNAL] Windows Support Plan You should talk to the Windows DPDK developers. They have been presenting regularly at dpdk summits. Look up videos for more info. The initial port is

Re: [dpdk-dev] Generating Debug information in Windows using Clang (PDB files)

2019-05-20 Thread Menon, Ranjit
Can you try it with just the -Z7 option? I'm also adding some persons from Microsoft to this thread, hoping they can help... +Harini +Omar +Jeffrey ranjit m. From: Adham Masarwah Sent: Monday, May 20, 2019 3:27 AM To: dev@dpdk.org Cc: Menon, Ranjit ; Kadam, Pallavi ; Yohad Tor ; Rani S

Re: [dpdk-dev] Compiler for Windows

2019-02-13 Thread Menon, Ranjit
o. We hope to get them out soon. ranjit m. -Original Message- From: Thomas Monjalon Sent: Wednesday, February 13, 2019 8:11 AM To: Menon, Ranjit ; 'Jason Messer' Cc: dev@dpdk.org; 'Harini Ramakrishnan' ; 'Omar Cardona' ; Burakov, Anatoly ; Richardso

Re: [dpdk-dev] Compiler for Windows

2019-01-30 Thread Menon, Ranjit
ed to make sure that they can compile with clang-win64. Thanks, Bruce for helping us out here. ranjit m. -Original Message- From: Thomas Monjalon Sent: Wednesday, January 30, 2019 6:21 AM To: 'Jason Messer' ; 'Harini Ramakrishnan' ; 'Omar Cardona' ; Menon