Re: [PATCH v9 2/2] net/af_xdp: Refactor af_xdp_tx_zc

Are you expecting anything from me? From what I understood, the series was acked. Still, patchwork labels it as* Change Requested.* http://patches.dpdk.org/project/dpdk/patch/20250207104552.1663519-3-ariel.otilib...@6wind.com/ Let me know, Ariel I was wanting for discussion to end, there seem

Re: [PATCH v9 2/2] net/af_xdp: Refactor af_xdp_tx_zc

On 07/02/2025 10:45, Ariel Otilibili wrote: Both legs of the loop share the same logic: the common parts are about reserving and filling both address and length into the description. This is moved into reserve_and_fill(). Bugzilla ID: 1440 Suggested-by: Maryam Tahhan Signed-off-by: Ariel

Re: [PATCH v8 2/2] net/af_xdp: Refactor af_xdp_tx_zc

On 06/02/2025 21:42, Stephen Hemminger wrote: On Thu, 6 Feb 2025 21:46:45 +0100 Ariel Otilibili wrote: +static inline struct xdp_desc * +reserve_and_fill(struct pkt_tx_queue *txq, struct rte_mbuf *mbuf, +struct xsk_umem_info *umem, void **pkt_ptr) +{ + struct xdp_desc

Re: [PATCH v8 2/2] net/af_xdp: Refactor af_xdp_tx_zc

> > > @@ -559,51 +587,30 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs, > uint16_t nb_pkts) > mbuf = bufs[i]; > > if (mbuf->pool == umem->mb_pool) { > - if (!xsk_ring_prod__reserve(&txq->tx, 1, &idx_tx)) > { > + if (!(des

Re: [PATCH v7 2/2] net/af_xdp: Refactor af_xdp_tx_zc

On Sat 1 Feb 2025, 10:03 Ariel Otilibili, wrote: > Both legs of the loop share the same logic: the common parts are about > reserving and filling both address and length into the description. > > This is moved into reserve_and_fill(). > > Bugzilla ID: 1440 > Suggested-by: Ma

Re: [PATCH v7 2/2] net/af_xdp: Refactor af_xdp_tx_zc

> > Sorry, just fixing my comment here: > > So I think i spotted one issue, you might need override desc->len after > the call to the reserve_and_fill function so that it's *not taken* from > local_mbuf here. >

Re: [PATCH v7 2/2] net/af_xdp: Refactor af_xdp_tx_zc

On Sat 1 Feb 2025, 10:03 Ariel Otilibili, wrote: > Both legs of the loop share the same logic: the common parts are about > reserving and filling both address and length into the description. > > This is moved into reserve_and_fill(). > > Bugzilla ID: 1440 > Suggested-by: Ma

Re: [PATCH v7 2/2] net/af_xdp: Refactor af_xdp_tx_zc

On 01/02/2025 10:03, Ariel Otilibili wrote: Both legs of the loop share the same logic: the common parts are about reserving and filling both address and length into the description. This is moved into reserve_and_fill(). Bugzilla ID: 1440 Suggested-by: Maryam Tahhan Signed-off-by: Ariel Otilib

Re: [PATCH v3 2/2] net/af_xdp: Refactor af_xdp_tx_zc()

On 28/01/2025 23:11, Ariel Otilibili wrote: Both legs of the loop share the same logic: either to go out of the function, or to fall through to the next instructions. For that, maybe_cpy_pkt() is introduced. Bugzilla ID: 1440 Signed-off-by: Ariel Otilibili --- drivers/net/af_xdp/rte_eth_af

Re: [PATCH v2 2/2] net/af_xdp: Refactor af_xdp_tx_zc()

On 16/01/2025 17:51, Ariel Otilibili wrote: Both legs of the loop share the same logic: either to go out of the function, or to fall through to the next instructions. Depends-on: patch-1 ("net/af_xdp: fix use after free in af_xdp_tx_zc()") Bugzilla ID: 1440 Signed-off-by: Ariel Otilibili ---

Re: [PATCH v2 1/2] net/af_xdp: fix use after free in af_xdp_tx_zc()

On 16/01/2025 17:51, Ariel Otilibili wrote: tx_bytes is computed after both legs are tested. This might produce a use after memory free. The computation is now moved into each leg. Bugzilla ID: 1440 Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") Signed-off-by: Ariel Otilibi

Re: [PATCH v6 06/14] net/af_xdp: use rte strerror

te_strerror(rte_errno)); return -1; } } Acked-by: Maryam Tahhan

Re: [PATCH v4 22/42] net/af_xdp: use rte strerror

The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Maryam Tahhan

Re: Can DPDK AF_XDP PMD support macvlan driver in container?

On 23/10/2024 07:07, Xiaohua Wang wrote: Hi, dpdk-testpmd with AF_XDP PMD can't work on p1p1 (macvlan) interface, but can work on eth0 (veth) interface. And is there a method to enable AF_XDP PMD to work in XDP SKB mode? Or add one option to set “SKB mode” in AF_XDP Options

Re: [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic

On 10/05/2024 16:06, Stephen Hemminger wrote: You don't have to use local statistic for this, there already is one in the dev struct i.e dev->data->rx_mbuf_alloc_failed. The problem is you need the DPDK port number to find what dev is. I think the diff id that dev->data->rx_mbuf_alloc_failed

Re: [PATCH 3/3] net/af_xdp: Fix stats reset

uint64_t alloc_failed; + + uint64_t imissed_offset; }; Minor nit (sorry) probably don't need the empty line between the `uint64_t alloc_failed` and `uint64_t imissed_offset` otherwise LGTM Acked-by: Maryam Tahhan struct pkt_rx_queue { @@ -884,7 +886,8 @@ eth_stats_get(struct r

Re: [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic

ned-off-by: Ciara Loftus Acked-by: Maryam Tahhan --- drivers/net/af_xdp/rte_eth_af_xdp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index fee0d5d5f3..968bbf6d45 100644 --- a/drivers/net/af_xdp/rte_et

Re: [PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf

On 10/05/2024 11:03, Ciara Loftus wrote: Record the port id in the af_xdp rx queue structure and use it to set the port id of the mbuf of a received packed. Bugzilla ID: 1428 Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") cc: sta...@dpdk.og Reported-by: Stephen Hemminger Signed-off-b

[v2 1/1] docs: af_xdp device plugin repo update

Fixup the references to the AF_XDP Device Plugin repo. Fixes: 66a2aca4f512 ("docs: fix AF_XDP device plugin howto") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- v2: make changes against net-next rather than main --- doc/guides/howto/af_xdp_dp.rst | 14 +++--- doc/g

Re: [v1 1/1] docs: af_xdp device plugin repo update

On 26/04/2024 15:54, Ferruh Yigit wrote: On 4/25/2024 4:08 PM, Maryam Tahhan wrote: Fixup the references to the AF_XDP Device Plugin repo. Fixes: 66a2aca4f512 ("docs: fix AF_XDP device plugin howto") Cc:sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cn

[v1 1/1] docs: af_xdp device plugin repo update

Fixup the references to the AF_XDP Device Plugin repo. Fixes: 66a2aca4f512 ("docs: fix AF_XDP device plugin howto") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cni.rst | 12 ++-- doc/guides/nics/af_xdp.rst | 2 +- 2 files changed, 7

[v1 1/1] MAINTAINERS: add another AF_XDP maintainer

Add Maryam Tahhan as an additional maintainer for AF_XDP PMD and it's documentation. Signed-off-by: Maryam Tahhan --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7abb3aee49..f0d6a36abd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -

Re: [v14 1/3] docs: AF_XDP Device Plugin

On 19/04/2024 11:13, Ferruh Yigit wrote: On 4/8/2024 2:09 PM, Maryam Tahhan wrote: diff --git a/doc/guides/howto/af_xdp_cni.rst b/doc/guides/howto/af_xdp_cni.rst deleted file mode 100644 index a1a6d5b99c..00 --- a/doc/guides/howto/af_xdp_cni.rst +++ /dev/null @@ -1,253 +0,0 @@ -.. SPDX

Re: [v13 2/3] net/af_xdp: fix multi interface support for K8s

On 08/04/2024 11:46, Loftus, Ciara wrote: +#ifdef ETH_AF_XDP_UPDATE_XSKMAP +static __rte_always_inline int +update_xskmap(struct xsk_socket *xsk, int map_fd, int xsk_queue_idx __rte_unused) +{ + return xsk_socket__update_xskmap(xsk, map_fd); +} +#else +static __rte_always_inline int +update

[v14 3/3] net/af_xdp: support AF_XDP DP pinned maps

Enable the AF_XDP PMD to retrieve the xskmap from a pinned eBPF map. This map is expected to be pinned by an external entity like the AF_XDP Device Plugin. This enabled unprivileged pods to create and use AF_XDP sockets. Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst

[v14 2/3] net/af_xdp: fix multi interface support for K8s

oth single and multiple interfaces. [1] https://github.com/intel/afxdp-plugins-for-kubernetes/pull/81 Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst | 62 ++-- doc/guide

[v14 1/3] docs: AF_XDP Device Plugin

") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cni.rst | 253 --- doc/guides/howto/af_xdp_dp.rst | 299 doc/guides/howto/index.rst | 2 +- doc/guides/nics/af_xdp.rst | 4 +- 4 files ch

[v14 0/3] net/af_xdp: fix multi interface support for K8s

The original `use_cni` implementation was limited to supporting only a single netdev in a DPDK pod. This patchset aims to fix this limitation transparently to the end user. It will also enable compatibility with the latest AF_XDP Device Plugin. Signed-off-by: Maryam Tahhan --- v14: * Fixup

Re: [v13 2/3] net/af_xdp: fix multi interface support for K8s

On 08/04/2024 11:46, Loftus, Ciara wrote: +#ifdef ETH_AF_XDP_UPDATE_XSKMAP +static __rte_always_inline int +update_xskmap(struct xsk_socket *xsk, int map_fd, int xsk_queue_idx __rte_unused) +{ + return xsk_socket__update_xskmap(xsk, map_fd); +} +#else +static __rte_always_inline int +update

[v13 3/3] net/af_xdp: support AF_XDP DP pinned maps

Enable the AF_XDP PMD to retrieve the xskmap from a pinned eBPF map. This map is expected to be pinned by an external entity like the AF_XDP Device Plugin. This enabled unprivileged pods to create and use AF_XDP sockets. Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst

[v13 2/3] net/af_xdp: fix multi interface support for K8s

oth single and multiple interfaces. [1] https://github.com/intel/afxdp-plugins-for-kubernetes/pull/81 Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst | 62 ++-- doc/guide

[v13 1/3] docs: AF_XDP Device Plugin

") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cni.rst | 253 --- doc/guides/howto/af_xdp_dp.rst | 299 doc/guides/howto/index.rst | 2 +- doc/guides/nics/af_xdp.rst | 4 +- 4 files ch

[v13 0/3] net/af_xdp: fix multi interface support for K8s

The original `use_cni` implementation was limited to supporting only a single netdev in a DPDK pod. This patchset aims to fix this limitation transparently to the end user. It will also enable compatibility with the latest AF_XDP Device Plugin. Signed-off-by: Maryam Tahhan --- v13: * Fixup

[v12 2/3] net/af_xdp: fix multi interface support for K8s

oth single and multiple interfaces. [1] https://github.com/intel/afxdp-plugins-for-kubernetes/pull/81 Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst | 62 ++-- doc/guide

[v12 3/3] net/af_xdp: support AF_XDP DP pinned maps

Enable the AF_XDP PMD to retrieve the xskmap from a pinned eBPF map. This map is expected to be pinned by an external entity like the AF_XDP Device Plugin. This enabled unprivileged pods to create and use AF_XDP sockets. Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst

[v12 1/3] docs: AF_XDP Device Plugin

") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cni.rst | 253 --- doc/guides/howto/af_xdp_dp.rst | 299 doc/guides/howto/index.rst | 2 +- doc/guides/nics/af_xdp.rst | 4 +- 4 files ch

[v12 0/3] net/af_xdp: fix multi interface support for K8s

The original `use_cni` implementation was limited to supporting only a single netdev in a DPDK pod. This patchset aims to fix this limitation transparently to the end user. It will also enable compatibility with the latest AF_XDP Device Plugin. Signed-off-by: Maryam Tahhan --- v12: * Ensure

Re: [v11 2/3] net/af_xdp: fix multi interface support for K8s

On 01/03/2024 15:43, Loftus, Ciara wrote: snip @@ -1695,17 +1699,16 @@ xsk_configure(struct pmd_internals *internals, struct pkt_rx_queue *rxq, } if (internals->use_cni) { - int err, fd, map_fd; + int err, map_fd; - /* get socket fd fr

[v11 3/3] net/af_xdp: support AF_XDP DP pinned maps

Enable the AF_XDP PMD to retrieve the xskmap from a pinned eBPF map. This map is expected to be pinned by an external entity like the AF_XDP Device Plugin. This enabled unprivileged pods to create and use AF_XDP sockets. Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst

[v11 2/3] net/af_xdp: fix multi interface support for K8s

oth single and multiple interfaces. [1] https://github.com/intel/afxdp-plugins-for-kubernetes/pull/81 Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst | 62 +++---

[v11 1/3] docs: AF_XDP Device Plugin

") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cni.rst | 253 --- doc/guides/howto/af_xdp_dp.rst | 299 doc/guides/howto/index.rst | 2 +- doc/guides/nics/af_xdp.rst | 4 +- 4 files ch

[v11 0/3] net/af_xdp: fix multi interface support for K8s

The original `use_cni` implementation was limited to supporting only a single netdev in a DPDK pod. This patchset aims to fix this limitation transparently to the end user. It will also enable compatibility with the latest AF_XDP Device Plugin. Signed-off-by: Maryam Tahhan --- v11: * Fixed up

Re: [v10 2/3] net/af_xdp: fix multi interface support for K8s

On 29/02/2024 13:01, Maryam Tahhan wrote: The original 'use_cni' implementation, was added to enable support for the AF_XDP PMD in a K8s env without any escalated privileges. However 'use_cni' used a hardcoded socket rather than a configurable one. If a DPDK pod is req

[v10 2/3] net/af_xdp: fix multi interface support for K8s

oth single and multiple interfaces. [1] https://github.com/intel/afxdp-plugins-for-kubernetes/pull/81 Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst | 62 +++---

[v10 3/3] net/af_xdp: support AF_XDP DP pinned maps

Enable the AF_XDP PMD to retrieve the xskmap from a pinned eBPF map. This map is expected to be pinned by an external entity like the AF_XDP Device Plugin. This enabled unprivileged pods to create and use AF_XDP sockets. Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst

[v10 1/3] docs: AF_XDP Device Plugin

") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cni.rst | 253 --- doc/guides/howto/af_xdp_dp.rst | 299 doc/guides/howto/index.rst | 2 +- doc/guides/nics/af_xdp.rst | 4 +- 4 files ch

[v10 0/3] net/af_xdp: fix multi interface support for K8s

The original `use_cni` implementation was limited to supporting only a single netdev in a DPDK pod. This patchset aims to fix this limitation transparently to the end user. It will also enable compatibility with the latest AF_XDP Device Plugin. Signed-off-by: Maryam Tahhan --- v10: * Add UDS

Re: [PATCH] net/af_xdp: fix resources leak when xsk configure fails

On 22/02/2024 03:07, Yunjian Wang wrote: In xdp_umem_configure() allocated some resources for the xsk umem, we should delete them when xsk configure fails, otherwise it will lead to resources leak. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Cc:sta...@dpdk.org Signed-off-by: Yunjia

[v9 3/3] net/af_xdp: support AF_XDP DP pinned maps

Enable the AF_XDP PMD to retrieve the xskmap from a pinned eBPF map. This map is expected to be pinned by an external entity like the AF_XDP Device Plugin. This enabled unprivileged pods to create and use AF_XDP sockets. Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst

[v9 2/3] net/af_xdp: fix multi interface support for K8s

h both single and multiple interfaces. Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst | 43 ++-- doc/guides/nics/af_xdp.rst | 14 doc/guides/rel_n

[v9 1/3] docs: AF_XDP Device Plugin

") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cni.rst | 253 --- doc/guides/howto/af_xdp_dp.rst | 299 doc/guides/howto/index.rst | 2 +- doc/guides/nics/af_xdp.rst | 4 +- 4 files ch

[v9 0/3] net/af_xdp: fix multi interface support for K8s

The original `use_cni` implementation was limited to supporting only a single netdev in a DPDK pod. This patchset aims to fix this limitation transparently to the end user. It will also enable compatibility with the latest AF_XDP Device Plugin. Signed-off-by: Maryam Tahhan --- v9: * Fixup

Re: [v8 0/3] net/af_xdp: fix multi interface support for K8s

Sorry folks Just spotted the checkpatch warnings :( I will fix these now. BR Maryam On 14/02/2024 16:06, Maryam Tahhan wrote: The original `use_cni` implementation was limited to supporting only a single netdev in a DPDK pod. This patchset aims to fix this limitation transparently to the end

[v8 3/3] net/af_xdp: support AF_XDP DP pinned maps

Enable the AF_XDP PMD to retrieve the xskmap from a pinned eBPF map. This map is expected to be pinned by an external entity like the AF_XDP Device Plugin. This enabled unprivileged pods to create and use AF_XDP sockets. Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst

[v8 2/3] net/af_xdp: fix multi interface support for K8s

h both single and multiple interfaces. Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_dp.rst | 43 ++-- doc/guides/nics/af_xdp.rst | 14 doc/guides/rel_n

[v8 1/3] docs: AF_XDP Device Plugin

") Cc: sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cni.rst | 253 --- doc/guides/howto/af_xdp_dp.rst | 299 doc/guides/howto/index.rst | 2 +- doc/guides/nics/af_xdp.rst | 4 +- 4 files ch

[v8 0/3] net/af_xdp: fix multi interface support for K8s

The original `use_cni` implementation was limited to supporting only a single netdev in a DPDK pod. This patchset aims to fix this limitation transparently to the end user. It will also enable compatibility with the latest AF_XDP Device Plugin. Signed-off-by: Maryam Tahhan --- v8: * Go back to

Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s

On 07/02/2024 23:24, Ferruh Yigit wrote: Hi Maryam, How do you want to continue with the patch, I think options we considered: 1. Fix 'use_cni' documentation (which we can backport to LTS) and overload the argument for new purpose. This will enable new feature by keeping backward compatibility.

Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s

On 09/02/2024 12:40, Loftus, Ciara wrote: Hi Maryam, How do you want to continue with the patch, I think options we considered: 1. Fix 'use_cni' documentation (which we can backport to LTS) and overload the argument for new purpose. This will enable new feature by keeping backward compatibility

Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s

On 11/01/2024 11:35, Ferruh Yigit wrote: Devarg is user interface, changing it impacts the user. Assume that user of '22.11.3' using 'use_cni' dev_arg, it will be broken when user upgrades DPDK to '22.11.4', which is not expected. dev_arg is not API/ABI but as it impacts the user, it is in the

Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s

On 10/01/2024 15:21, Ferruh Yigit wrote: On 1/10/2024 2:58 PM, Maryam Tahhan wrote: Hi folks Just wondering if there's any other comments re this patch after all the review comments were addressed? Hi Maryam, There was a request from David, to the previous version, that fixes (eith

Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s

Hi folks Just wondering if there's any other comments re this patch after all the review comments were addressed? Thanks Maryam On 22/12/2023 11:04, Maryam Tahhan wrote: The original 'use_cni' implementation, was added to enable support for the AF_XDP PMD in a K8s env withou

[v7 1/1] net/af_xdp: fix multi interface support for K8s

s patch adds this feature to the release notes. [1] https://github.com/intel/afxdp-plugins-for-kubernetes/pull/81 Signed-off-by: Maryam Tahhan Reviewed-by: Ciara Loftus Reviewed-by: Shibin Koikkara Reeny --- v7: * Give a more descriptive commit msg headline. * Fixup typos in documentation. v6: * A

Re: [v6] net/af_xdp: enable uds_path instead of use_cni

On 21/12/2023 11:36, David Marchand wrote: Hello, On Fri, Dec 15, 2023 at 4:40 PM Maryam Tahhan wrote: With the original 'use_cni' implementation, (using a hardcoded socket rather than a configurable one), if a DPDK pod is requesting multiple net devices and these devices are from

[v6] net/af_xdp: enable uds_path instead of use_cni

ded. * Fix testpmd arguments in the provided example for Pods. * Use AF_XDP API to update the xskmap entry. Signed-off-by: Maryam Tahhan Reviewed-by: Ciara Loftus --- doc/guides/howto/af_xdp_cni.rst| 253 -- doc/guides/howto/af_xdp_dp.rst | 278

Re: [v1] doc/rel-notes: Add AF_XDP DP integration

On 15/12/2023 12:24, Ferruh Yigit wrote: On 12/15/2023 11:15 AM, Maryam Tahhan wrote: Add a new feature item that references the AF_XDP DP integration. Signed-off-by: Maryam Tahhan Hi Maryam, Better to have documentation (including release note update) and code in same patch. If there

[v1] doc/rel-notes: Add AF_XDP DP integration

Add a new feature item that references the AF_XDP DP integration. Signed-off-by: Maryam Tahhan --- doc/guides/rel_notes/release_24_03.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst index 6f8ad27808

[v5] net/af_xdp: enable uds_path instead of use_cni

simple example with the AF_XDP DP plugin in K8s. v2: * Rename sock_path to uds_path. * Update documentation to reflect when CAP_BPF is needed. * Fix testpmd arguments in the provided example for Pods. * Use AF_XDP API to update the xskmap entry. Signed-off-by: Maryam Tahhan --- doc/gu

Re: [v4] net/af_xdp: enable uds_path instead of use_cni

Use AF_XDP API to update the xskmap entry. Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cni.rst | 253 - doc/guides/howto/af_xdp_dp.rst | 278 doc/guides/howto/index.rst | 2 +- drivers/net/af_xdp/rte_et

[v4] net/af_xdp: enable uds_path instead of use_cni

pdate documentation to reflect when CAP_BPF is needed. * Fix testpmd arguments in the provided example for Pods. * Use AF_XDP API to update the xskmap entry. Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cni.rst | 253 - doc/guides/howto/af_xdp_dp.rst | 27

Re: [v3] net/af_xdp: enable uds-path instead of use_cni

On 12/12/2023 14:25, Koikkara Reeny, Shibin wrote: Thank you Maryam updating the document. I have added some comment below. Also what do you think about changing the name of the document file "af_xdp_cni.rst" to "af_xdp_dp.rst" ? Yes - I can update. Background -- -The standar

[v3] net/af_xdp: enable uds-path instead of use_cni

pdate documentation to reflect when CAP_BPF is needed. * Fix testpmd arguments in the provided example for Pods. * Use AF_XDP API to update the xskmap entry. Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cni.rst | 334 +++- drivers/net/af_xdp/rte_eth_af_xdp.c

Re: [v2] net/af_xdp: enable a sock path alongside use_cni

On 08/12/2023 18:10, Maryam Tahhan wrote: Thanks Stephen,  I will have a look. I've seen a few places mention that abstract sockets are attached to the network namespace of a process. For our use case the 2 processes (pods) will have separate network namespaces. So I'm not sure it

Re: [v2] net/af_xdp: enable a sock path alongside use_cni

On 05/12/2023 18:30, Stephen Hemminger wrote: On Mon, 4 Dec 2023 05:31:01 -0500 Maryam Tahhan wrote: With the original 'use_cni' implementation, (using a hardcoded socket rather than a configurable one), if a single pod is requesting multiple net devices and these devices are from

Re: [v2] net/af_xdp: enable a sock path alongside use_cni

On 05/12/2023 13:43, Loftus, Ciara wrote: also be provided\n", Thanks for the patch Maryam. Do we really need the use_cni devarg anymore if we must also always pair it with a uds_path string? I am in favour of removing it if both yourself and Shibin think that makes sense too. Ciara Hey Cia

Re: [v2] net/af_xdp: enable a sock path alongside use_cni

On 04/12/2023 17:18, Koikkara Reeny, Shibin wrote: Prerequisites @@ -223,8 +224,7 @@ Howto run dpdk-testpmd with CNI plugin: securityContext: capabilities: add: - - CAP_NET_RAW - - CAP_BPF + - NET_RAW Need to updat

Re: [v2] net/af_xdp: enable a sock path alongside use_cni

l/afxdp-plugins-for-kubernetes/blob/main/internal/deviceplugin/poolManager_test.go#L99 I had added 2 small comment earlier in the code. Regards, Shibin *From:*Maryam Tahhan *Sent:* Monday, December 4, 2023 6:41 PM *To:* Koikkara Reeny, Shibin ; ferruh.yi...@amd.com; step...@networkplumb

Re: [v2] net/af_xdp: enable a sock path alongside use_cni

com/intel/afxdp-plugins-for-kubernetes/blob/main/constants/constants.go#L84 [2]https://github.com/intel/afxdp-plugins-for-kubernetes/blob/main/internal/deviceplugin/poolManager_test.go#L78 If we are able to create path in the program then user won't have to pass along argument value

[v2] net/af_xdp: enable a sock path alongside use_cni

lect when CAP_BPF is needed. * Fix testpmd arguments in the provided example for Pods. * Use AF_XDP API to update the xskmap entry. Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cni.rst | 24 ++- drivers/net/af_xdp/rte_eth_af_xdp.c | 62 ++---

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

On 01/12/2023 10:31, Maryam Tahhan wrote: Yeah - I actually will remove the `--no-mlockall --in-memory` in the v2 respin (it's a typo). I'm only interested in showing the multiple af_xdp device (vdev) arguments. I think it's useful for anyone who is looking for a quick referen

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

On 01/12/2023 10:26, David Marchand wrote: Hello, On Thu, Nov 30, 2023 at 10:13 AM Maryam Tahhan wrote: [snip] diff --git a/doc/guides/howto/af_xdp_cni.rst b/doc/guides/howto/af_xdp_cni.rst index a1a6d5b99c..a2d90c665d 100644 --- a/doc/guides/howto/af_xdp_cni.rst +++ b/doc/guides/howto

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

[snip] Prerequisites @@ -224,7 +225,6 @@ Howto run dpdk-testpmd with CNI plugin:    capabilities:   add:     - CAP_NET_RAW -       - CAP_BPF Why the CAP_BPF is removed?

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

. Regrads, Shibin -Original Message- From: Maryam Tahhan Sent: Thursday, November 30, 2023 9:14 AM To: ferruh.yi...@amd.com; step...@networkplumber.org; lihuis...@huawei.com; fengcheng...@huawei.com; liuyongl...@huawei.com Cc: dev@dpdk.org; Tahhan, Maryam Subject: [v1] net/af_xdp

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

Hi Shibin No problem. Answer below. BR Maryam On 30/11/2023 13:56, Koikkara Reeny, Shibin wrote: Hi Maryam, I have one more question. Regards, Shibin -Original Message- From: Koikkara Reeny, Shibin Sent: Thursday, November 30, 2023 12:14 PM To: Tahhan, Maryam;ferruh.yi...@amd.com;

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

Hi Shibin Thanks for the review. Comments inline. BR Maryam On 30/11/2023 12:14, Koikkara Reeny, Shibin wrote: Hi Maryam, I have added some suggestion below. Regrads, Shibin [snip] NOTICE); #define UDS_MAX_CMD_LEN 64 #define UDS_MAX_CMD_RESP 128 #d

[v1] net/af_xdp: enable a sock path alongside use_cni

hich means that at best only 1 netdev will handshake correctly with the AF_XDP DP. This patch addresses this by making the socket parameter configurable alongside the 'use_cni' param. Tested with the AF_XDP DP CNI PR 81. Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_

[dpdk-dev] [PATCH 1/1] testpmd_ug: update userguide with xstats commands

Update the testpmd user guide with instructions for retrieving extended NIC statistics. Signed-off-by: Maryam Tahhan --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst

[dpdk-dev] [PATCH v2 1/1] dpdk_procinfo: check for primary process

Add a check to see if the primary process is running and exit gracefully if it is not. v2: * Updated to tone down message and remove unnecessary brackets. Suggested-by: Patrick Kutch Signed-off-by: Maryam Tahhan --- app/proc_info/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a

[dpdk-dev] [PATCH] dpdk_procinfo: check for primary process

Add a check to see if the primary process is running and exit gracefully if it is not. Suggested-by: Patrick Kutch Signed-off-by: Maryam Tahhan --- app/proc_info/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/proc_info/main.c b/app/proc_info/main.c index 6dc0bbb..ddc8cf8

[dpdk-dev] [PATCH v2 1/1] ethdev: remove the imissed deprecation tag

emove driver specific stats") Signed-off-by: Maryam Tahhan --- v2: - Clarify why imissed is no longer deprecated. - Improve definition of imissed in the documentation. --- doc/guides/rel_notes/deprecation.rst | 2 +- lib/librte_ether/rte_ethdev.h| 4 +++- 2 files changed, 4 insert

[dpdk-dev] [PATCH v2 1/1] ethdev: distinguish between drop and error stats

ets. Where the # of errors can be >= the packets received (without overlap between registers), this is because there may be multiple errors associated with a packet. v2: - Added detailed descriptions for ierrors and ipkterrors. Signed-off-by: Maryam Tahhan --- lib/librte_ether/rte_ethdev.

[dpdk-dev] [PATCH] ethdev: distinguish between drop and error stats

ets. Where the # of errors can be >= the packets received (without overlap between registers), this is because there may be multiple errors associated with a packet. Signed-off-by: Maryam Tahhan --- lib/librte_ether/rte_ethdev.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH] ethdev: remove the imissed deprecation tag

Remove the deprecation tag and notice for imissed. Signed-off-by: Maryam Tahhan --- doc/guides/rel_notes/deprecation.rst | 2 +- lib/librte_ether/rte_ethdev.h| 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides

[dpdk-dev] [PATCH v1 1/1] ixgbe: Fix oerrors by setting it to 0

maintain a persistent value per port oerrors has now been set to 0. References to txdgpc is now removed as we don't use it. This patch also removes rxnfgpc as it's not used anywhere. Signed-off-by: Maryam Tahhan --- drivers/net/ixgbe/ixgbe_ethdev.c | 17 +++-- 1 file changed

[dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats->ierrors

ckets to the interface without forwarding enabled - packets should be dropped and the error counters incremented. v2: - specified the commit that this bug fix fixes. Signed-off-by: Maryam Tahhan --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[dpdk-dev] [PATCH v1 1/1] ixgbe: Fix phy errors in stats->ierrors

ed - packets should be dropped and the error counters incremented. Signed-off-by: Maryam Tahhan --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 3a8cff0..09fac25

[dpdk-dev] [PATCH v6 9/9] doc: Add documentation for proc_info

Add a guide for the proc_info application. Signed-off-by: Maryam Tahhan --- doc/guides/sample_app_ug/index.rst | 1 + doc/guides/sample_app_ug/proc_info.rst | 71 ++ 2 files changed, 72 insertions(+) create mode 100644 doc/guides/sample_app_ug/proc_info.rst

[dpdk-dev] [PATCH v6 8/9] app: add a new app proc_info

proc_info displays statistics information including extended stats for given DPDK ports and dumps the memory information for DPDK. Signed-off-by: Maryam Tahhan --- MAINTAINERS| 4 + app/Makefile | 1 + app/proc_info/Makefile | 45 +++ app/proc_info/main.c | 354

[dpdk-dev] [PATCH v6 7/9] app: remove dump_cfg

Remove the dump_cfg application, this will be replaced by a new app called proc_info that will implement the same functionality as dump_cfg and extend it to retrieve statistics for DPDK ports. Signed-off-by: Maryam Tahhan --- app/Makefile | 1 - app/dump_cfg/Makefile | 45

[dpdk-dev] [PATCH v6 6/9] ixgbe: return more errors in ierrors

ierrors only included a base set of error statistics, this patch adds additional error registers to ierrors. Signed-off-by: Maryam Tahhan --- drivers/net/ixgbe/ixgbe_ethdev.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b

  1   2   >