[PATCH] net/mlx5: fix panic for non template age rules flush

2025-07-09 Thread Maayan Kashani
: 04a4de756e14 ("net/mlx5: support flow age action with HWS") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_hws_cnt.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/driver

[PATCH] examples/multi_process: fix cleanup on exit

2025-07-08 Thread Maayan Kashani
Device was started but not stopped on exit signal. Added port stop and close on exit. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani --- examples/multi_process/symmetric_mp/main.c | 27 ++ 1 file changed, 22 insert

[PATCH v2] app/testpmd: cross NUMA support

2025-06-26 Thread Maayan Kashani
instead of port socket id. Replace mbuf pools allocations to any socket when --no-numa flag is set. Signed-off-by: Maayan Kashani --- app/test-pmd/testpmd.c | 8 lib/ethdev/ethdev_private.c | 2 +- lib/pdump/rte_pdump.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions

[PATCH v2] net/mlx5: support NUMA node fallback

2025-06-25 Thread Maayan Kashani
to support cross NUMA in device probing and port start stage. For Tx/Rx initializations, use socket-num given by the user and when SOCKET_ID_ANY is passed, default to device NUMA node with fallback to SOCKET_ID_ANY. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/common

[PATCH] net/mlx5: fix segfault in counter pool destroy

2025-06-25 Thread Maayan Kashani
;) Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_hws_cnt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/drivers/net/mlx5/mlx5_hws_cnt.c index 83db242bf90..fce7a7e815f 100644 --- a/driver

[PATCH] net/mlx5: mlx5 malloc NUMA fallback

2025-06-19 Thread Maayan Kashani
will be enabled only if this flag is set. Add a NUMA tolerant wraper to mlx5 malloc calls in ipool and devx/memory region initializations to support cross NUMA in device probing and port start stage. Signed-off-by: Maayan Kashani --- drivers/common/mlx5/mlx5_common_devx.c | 8 ++--- drivers

[PATCH] app/testpmd: cross NUMA support

2025-06-17 Thread Maayan Kashani
Cross NUMA support means that if the current NUMA is out of memory, use another available NUMA memory. Replace socket id specific initializations with SOCKET_ID_ANY needed for testpmd init when --no-numa flag is set. Signed-off-by: Maayan Kashani --- app/test-pmd/testpmd.c | 8

[PATCH 3/3] app/testpmd: cross NUMA support for gro init

2025-06-17 Thread Maayan Kashani
If gro context allocation with specified socket failed, Testpmd init function would return an error. With current change, if --no-numa option is used, testpmd init will use SOCKET_ID_ANY for gro init. Signed-off-by: Maayan Kashani --- app/test-pmd/testpmd.c | 11 ++- 1 file changed, 6

[PATCH 1/3] doc: gro API changes notice

2025-06-17 Thread Maayan Kashani
input. Signed-off-by: Maayan Kashani --- doc/guides/rel_notes/deprecation.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 36489f6e68f..5d534f49d53 100644 --- a/doc/guides/rel_notes/deprecation.rst

[PATCH 2/3] gro: cross NUMA support

2025-06-17 Thread Maayan Kashani
when using --no-numa option, gro should be initiated with SOCKET_ID_ANY to allow using cross NUMA. Changed socket_id field in struct rte_gro_param from uint16 to int32 to support negative value -1 (== SOCKET_ID_ANY). Signed-off-by: Maayan Kashani --- lib/gro/gro_tcp4.c | 2 +- lib/gro

RE: [PATCH] net/mlx5: fix transceiver warning when not exist

2025-06-09 Thread Maayan Kashani
Sometimes it’s just a failure in the testing system and needs to retrigger the tests. Regards, Maayan Kashani From: Yogev Chaimovich Sent: Monday, 9 June 2025 16:11 To: Maayan Kashani ; Stephen Hemminger Cc: Dariusz Sosnowski ; Slava Ovsiienko ; Bing Zhao ; Ori Kam ; Suanming Mou ; Matan

RE: [PATCH] net/mlx5: fix transceiver warning when not exist

2025-06-04 Thread Maayan Kashani
Hi, Yogev, Thank you for contributing, Can you fix the failing CI TEST? https://patches.dpdk.org/project/dpdk/patch/20250506133107.4432-1-yo...@cgstowernetworks.com/ Regards, Maayan Kashani > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, 20 May 2025 21:49 &g

RE: [PATCH v2 2/2] net/mlx5: enhance log file path

2025-06-03 Thread Maayan Kashani
Hi, Yang, Thanks for contributing, There are some failing CI tests. Can you fix it? https://patches.dpdk.org/project/dpdk/patch/20250321132750.4237-2-ming.1.y...@nokia-sbell.com/ Regards, Maayan Kashani > -Original Message- > From: Moses Young > Sent: Monday, 12 May 2025 1

[PATCH] ethdev: fix null error struct in flow configure

2025-05-28 Thread Maayan Kashani
RTE flow configure returned error value w/o filling the error struct which caused a crash on complain function. Filling the error struct fixed the issue. Signed-off-by: Maayan Kashani Fixes: 4ff58b734bc9 ("ethdev: introduce flow engine configuration") Cc: sta...@dpdk.org ---

RE: [PATCH 1/2] common/mlx5: read SWS capability bits

2025-05-27 Thread Maayan Kashani
Hi. Please revert this patch as it is causing a degradation(mark SWS as not supported while it is supported). Regards, Maayan Kashani > -Original Message- > From: Raslan Darawsheh > Sent: Tuesday, 13 May 2025 9:23 > To: Maayan Kashani ; dev@dpdk.org > Cc: Dariusz So

RE: [PATCH] net/mlx5: declare size of rte_v128u32_t

2025-05-25 Thread Maayan Kashani
Hi, Andre, Thanks for your contribution and patches, This fix should be handled diff and not by const, as the typedef might change in future and the const value will stay and cause a bug. Regards, Maayan Kashani > -Original Message- > From: Andre Muezerie > Sent: Monday, 5 Ma

[PATCH] net/mlx5/hws: fix send queue drain on FW WQE destroy

2025-04-27 Thread Maayan Kashani
f-by: Alex Vesker Signed-off-by: Maayan Kashani --- drivers/net/mlx5/hws/mlx5dr_send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index e121c7f7ed5..d01fc7ef2ca 100644 --- a/drivers/net/mlx5/hws/mlx

[PATCH 1/2] net/mlx5: non template - fix validation for GENEVE options

2025-04-27 Thread Maayan Kashani
rule create. Fixes: 80c676259a04 ("net/mlx5: validate HWS template items") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_hw.c | 35 - 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/d

[PATCH] net/mlx5: add match on IPv6 fragment extension header

2025-04-27 Thread Maayan Kashani
Add HWS support for IPv6 fragment extension header matching for HWS. Supported field is next_header. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- doc/guides/rel_notes/release_25_07.rst | 4 ++ drivers/net/mlx5/hws/mlx5dr_definer.c | 51 ++ drivers/net

[PATCH 2/2] net/mlx5: fix coverity warning

2025-04-27 Thread Maayan Kashani
gre_item was dereferenced w/o checking it's value. added a check to verify if null before using the pointer. Fixes: 80c676259a04 ("net/mlx5: validate HWS template items") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow.c

[PATCH 2/2] net/mlx5: update devarg according to SWS support

2025-04-27 Thread Maayan Kashani
SWS will be disabled in future HW generation. Update default for dv_flow_en/allow_duplicate_pattern devargs and return relevant error if user configuration is not supported. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst | 10 +++--- drivers/net/mlx5

[PATCH 1/2] common/mlx5: read SWS capability bits

2025-04-27 Thread Maayan Kashani
SWS will be disabled in future HW generation. Checking SWS capability bits and returning relevant error. if user configuration is not supported, will be added in the follow up commit. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/common/mlx5/mlx5_devx_cmds.c | 2

NVIDIA roadmap for 25.07

2025-04-14 Thread Maayan Kashani
feature description and usage examples. Regards, Maayan Kashani

RE: ConnectX-7 performance anomaly

2025-04-10 Thread Maayan Kashani
Hi, Kamil, Thanks for reaching out. After short sync with our performance team, I can tell we did not observe such anomality and it seems to be some local server issue/configurations. Regards, Maayan Kashani > -Original Message- > From: Kamil Vojanec > Sent: Thursday, 3 Apri

[PATCH] net/mlx5: fix failed to match on empty gre on root table

2025-03-12 Thread Maayan Kashani
the IP next header field in previous header in packet. Fixes: 25ab2cbba31d ("net/mlx5: fix GRE flow item translation for root table") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] net/mlx5: fix failed to match on empty gre on root table

2025-03-12 Thread Maayan Kashani
the IP next header field in previous header in packet. Fixes: 25ab2cbba31d ("net/mlx5: fix GRE flow item translation for root table") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v2] net/mlx5: fix flow create failure with GENEVE options match

2025-03-03 Thread Maayan Kashani
;) Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- doc/guides/nics/mlx5.rst| 5 +++ drivers/net/mlx5/mlx5_flow.h| 17 +++ drivers/net/mlx5/mlx5_flow_dv.c | 69 - drivers/net/mlx5/mlx5_flow_geneve.c | 2 +- driver

[PATCH] net/mlx5: fix using wrong group ID for action translation

2025-03-03 Thread Maayan Kashani
From: Bing Zhao In HWS non-template API, the actual group ID is calculated in the flow_hw_translate_flow_actions(). This would be set into the dummy template table for the following usage. Since __flow_hw_translate_actions_template() is also called for the dummy action template and some fixed ac

[PATCH 1/2] net/mlx5: fix non template flow validation on validate

2025-03-03 Thread Maayan Kashani
.@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 56 - 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 03cbf53f492..9efe41b1

[PATCH 2/2] net/mlx5: fix non template flow validation on create

2025-03-03 Thread Maayan Kashani
;) Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 98 - 1 file changed, 12 insertions(+), 86 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 9

[PATCH] net/mlx5: fix flow create failure with GENEVE options match

2025-03-03 Thread Maayan Kashani
;) Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- doc/guides/nics/mlx5.rst| 5 +++ drivers/net/mlx5/mlx5_flow.h| 17 +++ drivers/net/mlx5/mlx5_flow_dv.c | 69 - drivers/net/mlx5/mlx5_flow_geneve.c | 2 +- driver

[PATCH] net/mlx5: fix GTP flags matching

2025-02-27 Thread Maayan Kashani
Support gtp flags in non template on top of HWS. Currently, only extension flag was supported, Added support to all bits under v_pt_rsv_flags. Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- d

[PATCH 2/2] net/mlx5: fix error info in actions construct

2025-02-27 Thread Maayan Kashani
In some cases in debug it misses the error info. Fix to update the error structure. Fixes: 654ebd8cb7a3 ("net/mlx5: support flow table resizing") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 7 --- 1 file

[PATCH 1/2] net/mlx5: fix non template set VLAN VID

2025-02-27 Thread Maayan Kashani
n non-template setup") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_

[PATCH] net/mlx5: fix crash when using represented port w/o port ID

2025-02-27 Thread Maayan Kashani
Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/hws/mlx5dr_definer.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 98d670fc1ce..a4b9306d2b8 10

[PATCH] doc: add limitation under unified FDB

2025-02-27 Thread Maayan Kashani
Add limitation for unified FDB group 0 table creation. Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- doc/guides/nics/mlx5.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 190c58b54d6..efa4c708d51 100644 --- a/doc

[PATCH] net/mlx5: fix LACP packets handling in isolated mode

2025-02-27 Thread Maayan Kashani
default rules in isolated mode. Fixes: 87e4384d2662 ("net/mlx5: fix condition of LACP miss flow") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_trigger.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH] net/mlx5: fix assert failure on hairpin queue release

2025-02-27 Thread Maayan Kashani
Assert was triggered because of ctrl_ref mismatch on hairpin queue. Fixed the mismatch. Fixes: 09c2555 ("net/mlx5: support shared Rx queue") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_f

[PATCH 2/2] net/mlx5: add MPLSoGRE matching in HWS

2025-02-26 Thread Maayan Kashani
Remove limitations in validation and MPLS match translation. For non relaxed mode, assume MPLSoUDP if no protocol is mentioned. Set UDP dest port to MPLS type only for UDP protocol. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst | 2

[PATCH 1/2] doc: fix MPLS limitations under HWS

2025-02-26 Thread Maayan Kashani
Update missing limitations. Fixes: 1e2a51f545b6 ("net/mlx5: support MPLS tunnel with HWS") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/nics/mlx5

[PATCH] net/mlx5: fix GRE open matcher does not match packet

2025-01-28 Thread Maayan Kashani
the SWS case as before the GRE fix, and HWS according to the latest fix. Also, combined common logic. Fixes: 25ab2cbba31d ("net/mlx5: fix GRE flow item translation for root table") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow

[PATCH 2/3] net/mlx5: fix crash in non template metadata split

2025-01-27 Thread Maayan Kashani
t for compatibility") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_nta_split.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/net/mlx5/mlx5_nta_split.c b/drivers/net/mlx5/mlx5_nta_spl

[PATCH 3/3] net/mlx5: fix flow flush for non-template flows

2025-01-27 Thread Maayan Kashani
.@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 9203643300d..3d3b422f057 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/m

[PATCH 1/3] net/mlx5: fix limitation of actions per rule

2025-01-27 Thread Maayan Kashani
HWS implementation added a limitation of 16 actions per rule, which was incompatible with SWS limitation of 32 actions per rule. Changing the hard coded limitation in PMD to 32. Fixes: f13fab23922b ("net/mlx5: add flow jump action") Signed-off-by: Maayan Kashani Acked-by: Dariusz

[PATCH 0/3] Non template to HWS fixes

2025-01-27 Thread Maayan Kashani
Few fixes for non template mode on top of HWS. Maayan Kashani (3): net/mlx5: fix limitation of actions per rule net/mlx5: fix crash in non template metadata split net/mlx5: fix flow flush for non-template flows drivers/net/mlx5/mlx5_flow.c | 1 - drivers/net/mlx5/mlx5_flow.h

NVIDIA roadmap for 25.03

2024-12-25 Thread Maayan Kashani
checks for double malloc/free operations to enhance reliability and debuggability. Test apps updates =    Support the changes in rte_flow listed above in testpmd.    Regards, Maayan Kashani

NVIDIA roadmap for 24.11

2024-08-25 Thread Maayan Kashani
testpmd only allows consecutive pair for hairpin. This feature is intended to allow use of any pair.  Regards, Maayan Kashani

[PATCH v2] doc: document mlx5 HWS actions order

2024-07-24 Thread Maayan Kashani
Add actions order supported in mlx5 PMD when HW steering flow engine is used. This limitation existed since HW Steering flow engine was introduced. Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz

[PATCH] doc: document mlx5 HWS actions order

2024-07-17 Thread Maayan Kashani
Add actions order supported in mlx5 PMD when HW steering flow engine is used. This limitation existed since HW Steering flow engine was introduced. Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz

[PATCH] doc: document mlx5 HWS actions order

2024-07-17 Thread Maayan Kashani
Add actions order supported in mlx5 PMD when HW steering flow engine is used. This limitation existed since HW Steering flow engine was introduced. Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Dariusz

RE: [PATCH] app/testpmd: fix parsing for connection tracking item

2024-06-17 Thread Maayan Kashani
in the flow items list i got from the parsing of testpmd for the second flow created. I just aligned the parsing of connection tracking to be the same as other items.(e.g ITEM_PORT_REPRESENTOR) Regards, Maayan Kashani > -Original Message- > From: Ferruh Yigit > Sent: Wednesday

[PATCH v5 6/6] net/mlx5: support FDB in non-template mode

2024-06-10 Thread Maayan Kashani
From: Gregory Etelson Support non-template flows API in FDB mode: dpdk-testpmd -a $PCI,dv_flow_en=2,representor=vf0-1 -- -i testpmd> flow create 0 group 0 transfer \ pattern eth / end \ actions count / drop / end Signed-off-by: Gregory Etelson Acked-by: Dariusz Sos

[PATCH v5 5/6] net/mlx5: update HWS ASO actions validation

2024-06-10 Thread Maayan Kashani
From: Gregory Etelson HWS ASO actions validation required PMD to allocate resources during the port configuration, before the action validation was called. That approach does not work in the HWS non-template setup, because non-template setup does not have explicit port configuration procedure an

[PATCH v5 4/6] net/mlx5: update ASO resources in non-template setup

2024-06-10 Thread Maayan Kashani
From: Gregory Etelson Non-template PMD implementation allocates ASO flow actions resources on-demand. Current PMD implementation iterated over actions array in search for actions that required ASO resources allocations. The patch replaced the iteration with actions flags bitmap queries. Signed

[PATCH v5 3/6] net/mlx5: support indirect actions in non-template setup

2024-06-10 Thread Maayan Kashani
From: Gregory Etelson Add support for the RSS, AGE, COUNT and CONNTRACK indirect flow actions for the non-template flow rules. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 111 +--- 1 file changed, 89 insertions(+

[PATCH v5 2/6] net/mlx5: support RSS expansion in non-template HWS setup

2024-06-10 Thread Maayan Kashani
From: Gregory Etelson The MLX5 PMD expands flow rule with the RSS action in the non-template environment. The patch adds RSS flow rule expansion for legacy flow rules in the template setup. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/hws/mlx5dr_definer.c |

[PATCH v5 1/6] net/mlx5: update NTA rule pattern and actions flags

2024-06-10 Thread Maayan Kashani
From: Gregory Etelson Move pattern flags bitmap to flow_hw_list_create. Create actions flags bitmap in flow_hw_list_create. PMD uses pattern and actions bitmaps for direct queries instead of iterating arrays. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx

[PATCH v7 11/11] net/mlx5: initial design changes

2024-06-09 Thread Maayan Kashani
Change flow_drv_list_create/destroy to mlx5_flow_list_create/destroy. Remove resource release function inlining. Check number of queues in template mode in hw configure function. Use user priority to calculate matcher priority. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski

[PATCH v7 10/11] net/mlx5: use non const max number for ASO actions

2024-06-09 Thread Maayan Kashani
For ASO max allocations in non-template mode, Read FW capabilities instead of using consts. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h| 17 - drivers/net/mlx5/mlx5_flow_hw.c| 13 + drivers/net/mlx5

[PATCH v7 09/11] net/mlx5: support bulk actions in non template mode

2024-06-09 Thread Maayan Kashani
Add support for encap/decap/modify header action for non template API. Save 1 action per bulk according to action data. Reuse action if possible. Store actions same as for SWS today, use same key structure. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5

[PATCH v7 08/11] common/mlx5: read connection tracking attributes

2024-06-09 Thread Maayan Kashani
Need to read maximum connection tracking objects from HCA attributes. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/common/mlx5

[PATCH v7 07/11] net/mlx5: abstract action handling and enable reconfigure

2024-06-09 Thread Maayan Kashani
pointer is the flow data pointer. Currently the return value of non template code did not Enable destroy or quary. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h | 25 +- drivers/net/mlx5/mlx5_flow.c| 31 +- drivers/net/mlx5/mlx5_flow.h| 14

[PATCH v7 06/11] net/mlx5: fix segfault on counter pool destroy

2024-06-09 Thread Maayan Kashani
s the cpool's next field is initialized and SEGVs if not. So, added a guard against cases where the entry was uninitialized (checking le_prev field is not NULL). Fixes: 6ac2104ac125 ("net/mlx5: fix counter query during port close") Cc: sta...@dpdk.org Signed-off-by: Maay

[PATCH v7 04/11] net/mlx5: add default miss action support in nt2hws mode

2024-06-09 Thread Maayan Kashani
From: Bing Zhao The validation will be handled later. Now it only supports the SEND_TO_KERNEL on non-root tables. Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git

[PATCH v7 03/11] net/mlx5: add basic actions support for non-template API

2024-06-09 Thread Maayan Kashani
From: Bing Zhao Support JUMP / DROP / QUEUE / MARK / FLAG now. Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 154 1 file changed, 136 insertions(+), 18 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/dr

[PATCH v7 05/11] net/mlx5: add ASO actions support to non-template mode

2024-06-09 Thread Maayan Kashani
allocated, allocate half of the maximum, and then allocate same number of AGE objects. Also extracted the shared host handling to the configure function. And align all ASO actions to have init function for future code improvement. This patch does not affect SW Steering flow engine. Signed-off-by: Maayan

[PATCH v7 02/11] net/mlx5: add dummy last action

2024-06-09 Thread Maayan Kashani
From: Bing Zhao The RTE_FLOW_ACTION_TYPE_END action needs to be translated into the MLX5DR_ACTION_TYP_LAST for the future usage. It is only needed in the hardware steering backward compatible API. Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h | 1 +

[PATCH v7 01/11] net/mlx5: initial design of non template to hws

2024-06-09 Thread Maayan Kashani
eeded. Added rte_flow_nt2hws structure for non-template rule data. Signed-off-by: Maayan Kashani squash to net/mlx5: initial design of non template to hws Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/linux/mlx5_os.c | 8 +- drivers/net/mlx5/mlx5.h| 9 + drivers/net

[PATCH v6 11/11] net/mlx5: initial design changes

2024-06-09 Thread Maayan Kashani
Change flow_drv_list_create/destroy to mlx5_flow_list_create/destroy. Remove resource release function inlining. Check number of queues in template mode in hw configure function. Use user priority to calculate matcher priority. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski

[PATCH v6 10/11] net/mlx5: use non const max number for ASO actions

2024-06-09 Thread Maayan Kashani
For ASO max allocations in non-template mode, Read FW capabilities instead of using consts. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h| 17 - drivers/net/mlx5/mlx5_flow_hw.c| 13 + drivers/net/mlx5

[PATCH v6 09/11] net/mlx5: support bulk actions in non template mode

2024-06-09 Thread Maayan Kashani
Add support for encap/decap/modify header action for non template API. Save 1 action per bulk according to action data. Reuse action if possible. Store actions same as for SWS today, use same key structure. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5

[PATCH v6 08/11] common/mlx5: read connection tracking attributes

2024-06-09 Thread Maayan Kashani
Need to read maximum connection tracking objects from HCA attributes. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/common/mlx5

[PATCH v6 07/11] net/mlx5: abstract action handling and enable reconfigure

2024-06-09 Thread Maayan Kashani
pointer is the flow data pointer. Currently the return value of non template code did not Enable destroy or quary. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h | 25 +- drivers/net/mlx5/mlx5_flow.c| 31 +- drivers/net/mlx5/mlx5_flow.h| 14

[PATCH v6 04/11] net/mlx5: add default miss action support in nt2hws mode

2024-06-09 Thread Maayan Kashani
From: Bing Zhao The validation will be handled later. Now it only supports the SEND_TO_KERNEL on non-root tables. Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --gi

[PATCH v6 05/11] net/mlx5: add ASO actions support to non-template mode

2024-06-09 Thread Maayan Kashani
allocated, allocate half of the maximum, and then allocate same number of AGE objects. Also extracted the shared host handling to the configure function. And align all ASO actions to have init function for future code improvement. This patch does not affect SW Steering flow engine. Signed-off-by: Maayan

[PATCH v6 02/11] net/mlx5: add dummy last action

2024-06-09 Thread Maayan Kashani
From: Bing Zhao The RTE_FLOW_ACTION_TYPE_END action needs to be translated into the MLX5DR_ACTION_TYP_LAST for the future usage. It is only needed in the hardware steering backward compatible API. Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h | 1 +

[PATCH v6 06/11] net/mlx5: fix segfault on counter pool destroy

2024-06-09 Thread Maayan Kashani
s the cpool's next field is initialized and SEGVs if not. So, added a guard against cases where the entry was uninitialized (checking le_prev field is not NULL). Fixes: 6ac2104ac125 ("net/mlx5: fix counter query during port close") Cc: sta...@dpdk.org Signed-off-by: Maay

[PATCH v6 01/11] net/mlx5: initial design of non template to hws

2024-06-09 Thread Maayan Kashani
eeded. Added rte_flow_nt2hws structure for non-template rule data. Signed-off-by: Maayan Kashani squash to net/mlx5: initial design of non template to hws Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/linux/mlx5_os.c | 8 +- drivers/net/mlx5/mlx5.h| 9 + drivers/net

[PATCH v6 03/11] net/mlx5: add basic actions support for non-template API

2024-06-09 Thread Maayan Kashani
From: Bing Zhao Support JUMP / DROP / QUEUE / MARK / FLAG now. Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 153 1 file changed, 135 insertions(+), 18 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/dr

[PATCH v5 11/11] net/mlx5: initial design changes

2024-06-06 Thread Maayan Kashani
Change flow_drv_list_create/destroy to mlx5_flow_list_create/destroy. Remove resource release function inlining. Check number of queues in template mode in hw configure function. Use user priority to calculate matcher priority. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski

[PATCH v5 10/11] net/mlx5: use non const max number for ASO actions

2024-06-06 Thread Maayan Kashani
For ASO max allocations in non-template mode, Read FW capabilities instead of using consts. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h| 17 - drivers/net/mlx5/mlx5_flow_hw.c| 13 + drivers/net/mlx5

[PATCH v5 09/11] net/mlx5: support bulk actions in non template mode

2024-06-06 Thread Maayan Kashani
Add support for encap/decap/modify header action for non template API. Save 1 action per bulk according to action data. Reuse action if possible. Store actions same as for SWS today, use same key structure. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5

[PATCH v5 08/11] common/mlx5: read connection tracking attributes

2024-06-06 Thread Maayan Kashani
Need to read maximum connection tracking objects from HCA attributes. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/common/mlx5

[PATCH v5 07/11] net/mlx5: abstract action handling and enable reconfigure

2024-06-06 Thread Maayan Kashani
pointer is the flow data pointer. Currently the return value of non template code did not Enable destroy or quary. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h | 25 +- drivers/net/mlx5/mlx5_flow.c| 31 +- drivers/net/mlx5/mlx5_flow.h| 14

[PATCH v5 06/11] net/mlx5: fix segfault on counter pool destroy

2024-06-06 Thread Maayan Kashani
s the cpool's next field is initialized and SEGVs if not. So, added a guard against cases where the entry was uninitialized (checking le_prev field is not NULL). Fixes: 6ac2104ac125 ("net/mlx5: fix counter query during port close") Cc: sta...@dpdk.org Signed-off-by: Maay

[PATCH v5 05/11] net/mlx5: add ASO actions support to non-template mode

2024-06-06 Thread Maayan Kashani
allocated, allocate half of the maximum, and then allocate same number of AGE objects. Also extracted the shared host handling to the configure function. And align all ASO actions to have init function for future code improvement. This patch does not affect SW Steering flow engine. Signed-off-by: Maayan

[PATCH v5 04/11] net/mlx5: add default miss action support in nt2hws mode

2024-06-06 Thread Maayan Kashani
From: Bing Zhao The validation will be handled later. Now it only supports the SEND_TO_KERNEL on non-root tables. Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --gi

[PATCH v5 03/11] net/mlx5: add basic actions support for non-template API

2024-06-06 Thread Maayan Kashani
From: Bing Zhao Support JUMP / DROP / QUEUE / MARK / FLAG now. Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 153 1 file changed, 135 insertions(+), 18 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/dr

[PATCH v5 02/11] net/mlx5: add dummy last action

2024-06-06 Thread Maayan Kashani
From: Bing Zhao The RTE_FLOW_ACTION_TYPE_END action needs to be translated into the MLX5DR_ACTION_TYP_LAST for the future usage. It is only needed in the hardware steering backward compatible API. Signed-off-by: Bing Zhao Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h | 1 +

[PATCH v5 01/11] net/mlx5: initial design of non template to hws

2024-06-06 Thread Maayan Kashani
eeded. Added rte_flow_nt2hws structure for non-template rule data. Signed-off-by: Maayan Kashani squash to net/mlx5: initial design of non template to hws Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/linux/mlx5_os.c | 8 +- drivers/net/mlx5/mlx5.h| 9 + drivers/net

[PATCH v4 3/3] net/mlx5/hws: add support for backward-compatible API

2024-06-06 Thread Maayan Kashani
From: Yevgeny Kliteynik HWS API is very different from SWS and has limitations: - Queue based async insertion/deletion - Doesn’t handle complex rules - Requires the user to specify fixed matcher size – no rehash - Requires the user to specify action combination on matcher creation - Matching

[PATCH v4 2/3] net/mlx5/hws: add support for action type LAST

2024-06-06 Thread Maayan Kashani
From: Yevgeny Kliteynik Add support for MLX5DR_ACTION_TYP_LAST action type. Signed-off-by: Yevgeny Kliteynik Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/hws/mlx5dr.h| 12 drivers/net/mlx5/hws/mlx5dr_action.c | 9 + 2 files changed, 21 insertions(+) diff --g

[PATCH v4 0/3] HWS non-template support

2024-06-06 Thread Maayan Kashani
Initial coding to support non-template in mlxdr layer. Yevgeny Kliteynik (3): net/mlx5/hws: split the root rule creation and destruction net/mlx5/hws: add support for action type LAST net/mlx5/hws: add support for backward-compatible API drivers/net/mlx5/hws/meson.build | 1 + driv

[PATCH v4 1/3] net/mlx5/hws: split the root rule creation and destruction

2024-06-06 Thread Maayan Kashani
From: Yevgeny Kliteynik Split the root rule creation/destruction into two stages: - do the job (create/destroy rule) - generate completion Completion generation is required for the usual HWS API. The create/destroy functions that don't generate completion are exposed in header file and will be

[PATCH v4 10/11] net/mlx5: use non const max number for ASO actions

2024-06-06 Thread Maayan Kashani
For ASO max allocations in non-template mode, Read FW capabilities instead of using consts. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h| 17 - drivers/net/mlx5/mlx5_flow_hw.c| 13 + drivers/net/mlx5

[PATCH v4 11/11] net/mlx5: initial design changes

2024-06-06 Thread Maayan Kashani
Change flow_drv_list_create/destroy to mlx5_flow_list_create/destroy. Remove resource release function inlining. Check number of queues in template mode in hw configure function. Use user priority to calculate matcher priority. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski

[PATCH v4 09/11] net/mlx5: support bulk actions in non template mode

2024-06-06 Thread Maayan Kashani
Add support for encap/decap/modify header action for non template API. Save 1 action per bulk according to action data. Reuse action if possible. Store actions same as for SWS today, use same key structure. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5

[PATCH v4 07/11] net/mlx5: abstract action handling and enable reconfigure

2024-06-06 Thread Maayan Kashani
pointer is the flow data pointer. Currently the return value of non template code did not Enable destroy or quary. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h | 25 +- drivers/net/mlx5/mlx5_flow.c| 31 +- drivers/net/mlx5/mlx5_flow.h| 14

[PATCH v4 08/11] common/mlx5: read connection tracking attributes

2024-06-06 Thread Maayan Kashani
Need to read maximum connection tracking objects from HCA attributes. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/common/mlx5

[PATCH v4 06/11] net/mlx5: fix segfault on counter pool destroy

2024-06-06 Thread Maayan Kashani
s the cpool's next field is initialized and SEGVs if not. So, added a guard against cases where the entry was uninitialized (checking le_prev field is not NULL). Fixes: 6ac2104ac125 ("net/mlx5: fix counter query during port close") Cc: sta...@dpdk.org Signed-off-by: Maay

  1   2   3   >