Re: [dpdk-dev] [EXT] RE: [PATCH] examples/ipsec-secgw: fix dropping of initial IPsec pkts

2020-04-29 Thread Lukas Bartosik [C]
>> >> 1. "DPDK does not keep track of flow rules definitions or flow rule objects >> automatically. Applications may keep track of the former and >> must keep track of the latter." >> DPDK rte_flow spec d

Re: [dpdk-dev] [EXT] RE: [PATCH] examples/ipsec-secgw: fix dropping of initial IPsec pkts

2020-04-21 Thread Lukas Bartosik [C]
, Lukasz On 16.04.2020 14:28, Lukas Bartosik [C] wrote: > Hi Konstantin, > > Please see my answer below. > > Thanks, > Lukasz > > On 16.04.2020 01:47, Ananyev, Konstantin wrote: >> External Email >> >> ---

Re: [dpdk-dev] [PATCH v3] ipsec: use hash lookup with hash sigs in sad lookup

2020-04-21 Thread Lukas Bartosik [C]
Hi Vladimir, How does this patch relate to http://patches.dpdk.org/patch/66715/. Both patches replace lookup function rte_hash_lookup_bulk_data used in __ipsec_sad_lookup with rte_hash_lookup_with_hash_bulk_data or rte_dwk_hash_lookup. Is the plan for both solutions to coexist or will only one

Re: [dpdk-dev] [EXT] RE: [PATCH] examples/ipsec-secgw: fix dropping of initial IPsec pkts

2020-04-16 Thread Lukas Bartosik [C]
Hi Konstantin, Please see my answer below. Thanks, Lukasz On 16.04.2020 01:47, Ananyev, Konstantin wrote: > External Email > > -- > > > Hi Lukasz, > >> Hi Konstantin, >> >> In this patch I moved the sa_init() before rte_eth

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix dropping of initial IPsec pkts

2020-04-15 Thread Lukas Bartosik [C]
Hi Konstantin, In this patch I moved the sa_init() before rte_eth_dev_start() in order to avoid dropping of IPsec pkts when a traffic flows and the ipsec-secgw application is started. However I remember that during review of event mode patches you mentioned that moving sa_init() before rte_eth_d

Re: [dpdk-dev] [EXT] RE: [PATCH v5 00/15] add eventmode to ipsec-secgw

2020-03-12 Thread Lukas Bartosik
merging the patchset. > > Regards, > Akhil >> >> Hi Akhil, >> >> Reminder. >> >> Do you have any further review comments? >> >> Thanks, >> Anoob >> >>> -Original Message----- >>> From: Ananyev, Konstantin >>>

Re: [dpdk-dev] [EXT] RE: [PATCH v4 12/15] examples/ipsec-secgw: add app mode worker

2020-02-27 Thread Lukas Bartosik
Hi Akhil, Please see my answer below. Thanks, Lukasz On 27.02.2020 13:07, Akhil Goyal wrote: >> >> Hi Lukasz, >> Is it not possible to use the existing functions for finding routes, checking >>> packet types and checking security policies. It will be very difficult to manage

Re: [dpdk-dev] [EXT] RE: [PATCH v4 12/15] examples/ipsec-secgw: add app mode worker

2020-02-26 Thread Lukas Bartosik
Hi Akhil, Please see my answer below. Thanks, Lukasz On 26.02.2020 07:04, Akhil Goyal wrote: > Hi Lukasz, > >>> >>> Is it not possible to use the existing functions for finding routes, >>> checking >> packet types and checking security policies. >>> It will be very difficult to manage two sepa

Re: [dpdk-dev] [EXT] RE: [PATCH v4 00/15] add eventmode to ipsec-secgw

2020-02-25 Thread Lukas Bartosik
Hi Akhil, Please see my answer below. Thanks, Lukasz On 24.02.2020 14:40, Akhil Goyal wrote: > External Email > > -- > Hi Anoob/Lukasz, > >> >> This series introduces event-mode additions to ipsec-secgw. >> >> With this series

Re: [dpdk-dev] [EXT] RE: [PATCH v4 12/15] examples/ipsec-secgw: add app mode worker

2020-02-25 Thread Lukas Bartosik
Hi Akhil, Please see my answers below. Thanks, Lukasz On 24.02.2020 15:13, Akhil Goyal wrote: > External Email > > -- > Hi Lukasz/Anoob, > >> >> Add application inbound/outbound worker thread and >> IPsec application processin

Re: [dpdk-dev] [EXT] RE: [PATCH v3 13/13] examples/ipsec-secgw: make number of buffers dynamic

2020-02-05 Thread Lukas Bartosik
Hi Konstantin, Please see inline. Thanks, Lukasz On 05.02.2020 14:42, Ananyev, Konstantin wrote: > External Email > > -- > > Hi Lukasz, > >> Make number of buffers in a pool nb_mbuf_in_pool dependent on number >> of ports, c

Re: [dpdk-dev] [EXT] RE: [PATCH v2 09/12] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-02-02 Thread Lukas Bartosik
Hi Konstantin, On 31.01.2020 02:09, Lukasz Bartosik wrote: > Hi Konstantin, > > On 30.01.2020 23:21, Ananyev, Konstantin wrote: >> >> >>> -Original Message- >>> From: Ananyev, Konstantin >>> Sent: Thursday, January 30, 2020 11:13 AM &g

Re: [dpdk-dev] [EXT] RE: [PATCH v2 09/12] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-01-30 Thread Lukas Bartosik
Hi Konstantin, On 30.01.2020 23:21, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Ananyev, Konstantin >> Sent: Thursday, January 30, 2020 11:13 AM >> To: Lukas Bartosik ; Anoob Joseph >> ; Akhil Goyal ; Nicolau, Radu >

Re: [dpdk-dev] [EXT] RE: [PATCH v2 09/12] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-01-30 Thread Lukas Bartosik
Hi Konstantin, Please see inline. Thanks, Lukasz On 30.01.2020 00:31, Ananyev, Konstantin wrote: > External Email > > -- >> Add eventmode support to ipsec-secgw. With the aid of event helper >> configure and use the eventmode ca

Re: [dpdk-dev] [EXT] RE: [PATCH 11/14] examples/ipsec-secgw: add app processing code

2020-01-10 Thread Lukas Bartosik
Hi Konstantin, Please see inline. Thanks, Lukasz On 24.12.2019 14:13, Ananyev, Konstantin wrote: > External Email > > -- > >> --- a/examples/ipsec-secgw/ipsec_worker.c >> +++ b/examples/ipsec-secgw/ipsec_worker.c >> @@ -15,6 +

Re: [dpdk-dev] [EXT] RE: [PATCH 11/14] examples/ipsec-secgw: add app processing code

2020-01-10 Thread Lukas Bartosik
Hi Konstantin, Please see inline. Thanks, Lukasz On 23.12.2019 17:49, Ananyev, Konstantin wrote: > External Email > > -- > > >> >> Add IPsec application processing code for event mode. >> >> Signed-off-by: Anoob Joseph >> Si

Re: [dpdk-dev] [PATCH 01/14] examples/ipsec-secgw: add default rte_flow for inline Rx

2020-01-09 Thread Lukas Bartosik
Sent: Monday, December 16, 2019 7:51 PM >> To: Anoob Joseph ; Akhil Goyal ; >> Nicolau, Radu ; Thomas Monjalon >> >> Cc: Ankur Dwivedi ; Jerin Jacob Kollanukkaran >> ; Narayana Prasad Raju Athreya >> ; Archana Muniganti ; >> Tejasree Kondoj ; Vamsi Krishna

Re: [dpdk-dev] [PATCH v2] ipsec: include high order bytes of esn in pkt len

2019-05-31 Thread Lukas Bartosik
Hi Konstantin On 30.05.2019 18:51, Ananyev, Konstantin wrote: > Hi Lukasz, > >> diff --git a/lib/librte_ipsec/esp_outb.c b/lib/librte_ipsec/esp_outb.c >> index c798bc4..ed5974b 100644 >> --- a/lib/librte_ipsec/esp_outb.c >> +++ b/lib/librte_ipsec/esp_outb.c >> @@ -126,11 +126,11 @@ outb_tun_pkt_p

Re: [dpdk-dev] [PATCH] ipsec: include high order bytes of esn in pkt len

2019-05-20 Thread Lukas Bartosik
Hi Konstantin, Thank you for the review. I will send a revised patch which addresses your comments. Thanks, Lukasz On 19.05.2019 16:47, Ananyev, Konstantin wrote: > > Hi Lukasz, > Thanks for clarifications. > Looks good in general. > Few small comments below. > Konstantin > >> When esn is use

Re: [dpdk-dev] [EXT] Re: [PATCH] ipsec: include high order bytes of esn in pkt len

2019-05-14 Thread Lukas Bartosik
On 14.05.2019 15:52, Ananyev, Konstantin wrote: > Hi Lukasz, > When esn is used then high-order 32 bits are included in ICV calculation however are not transmitted. Update packet length to be consistent with auth data offset and length before crypto operation. High-order

Re: [dpdk-dev] [EXT] Re: [PATCH] ipsec: include high order bytes of esn in pkt len

2019-05-07 Thread Lukas Bartosik
On 30.04.2019 17:38, Lukas Bartosik wrote: > External Email > > -- > > > > > From: Ananyev, Konstantin > Sent: Tuesday, April 30, 2019 5:05 PM > To: Lukas Bart

Re: [dpdk-dev] [PATCH] ipsec: include high order bytes of esn in pkt len

2019-04-30 Thread Lukas Bartosik
From: Ananyev, Konstantin Sent: Tuesday, April 30, 2019 5:05 PM To: Lukas Bartosik Cc: dev@dpdk.org; Anoob Joseph Subject: RE: [PATCH] ipsec: include high order bytes of esn in pkt len > -Original Message- > From: Lukasz Bartosik [mailto: