Re: [dpdk-dev] [PATCH] raw/ioat: extend python script functionality

2021-05-27 Thread Laatz, Kevin
<...> > Hi Kevin, > > since you list out two changes here, it's a good indication that this might > be better as two separate patches. Can you please split it, thanks. > > Couple of minor comments inline below too. > > Regards, > /Bruce > Thanks for the feedback, Bruce. I'll split the changes a

Re: [dpdk-dev] [PATCH 2/2] raw/ioat: remove special case for no status reporting

2021-05-12 Thread Laatz, Kevin
> The special fast-path for returning completed descriptors without > reporting status or user-handles returns the number of completed ring > slots used, rather than the number of actual user-submitted jobs. This > means that the counts returned are too high, as the batch descriptor > slots would b

Re: [dpdk-dev] [PATCH 1/2] raw/ioat: fix ring space checks

2021-05-12 Thread Laatz, Kevin
> When enqueuing a descriptor, when checking that there is at least one > slot free for the current descriptor and a later batch descriptor, we > need to test for both two free and one free, in case the last write > was a batch descriptor which is allowed to use the "spare" slot. > > Similarly, wh

Re: [dpdk-dev] [PATCH] raw/ioat: fix parameter shadow warning

2021-05-10 Thread Laatz, Kevin
> On Fri, May 07, 2021 at 05:20:25PM +, Kevin Laatz wrote: > > In the function __idxd_completed_ops() we have a parameter shadow > warning > > due to a local variable having the same name as one of the function > > parameters. This is fixed by simply renaming the local variable. > > > > Fixes

Re: [dpdk-dev] [PATCH v4 15/31] app: remove references to make-based config

2020-09-14 Thread Laatz, Kevin
On 07/09/2020 23:06, Thomas Monjalon wrote: From: Ciara Power Make is no longer supported, RTE_SDK, RTE_TARGET and CONFIG options are no longer in use. Signed-off-by: Ciara Power --- app/test-bbdev/test-bbdev.py | 11 + app/test/test_cryptodev.c | 89 +---

Re: [dpdk-dev] [PATCH v4 18/31] doc: remove references to make from howto guides

2020-09-14 Thread Laatz, Kevin
On 07/09/2020 23:06, Thomas Monjalon wrote: From: Ciara Power Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/howto/lm_bond_virtio_sriov.rst | 4 +-- doc/guides/howto/lm_virtio_vhost_user.rst

Re: [dpdk-dev] [PATCH v4 20/31] doc: remove references to make from platforms guides

2020-09-14 Thread Laatz, Kevin
On 07/09/2020 23:07, Thomas Monjalon wrote: From: Ciara Power Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/platform/bluefield.rst | 22 - doc/guides/platform/octeontx.rst | 33

Re: [dpdk-dev] [PATCH v4 21/31] doc: remove references to make from mempool guide

2020-09-14 Thread Laatz, Kevin
On 07/09/2020 23:07, Thomas Monjalon wrote: From: Ciara Power Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/mempool/octeontx.rst | 28 +++- doc/guides/mempool/octeontx2.rst

Re: [dpdk-dev] [PATCH v2 1/3] raw/ioat: support multiple devices being tested

2020-09-14 Thread Laatz, Kevin
On 10/09/2020 17:47, Bruce Richardson wrote: The current selftest function uses a single global variable to track state which implies that only a single instance can have the selftest function called on it. Change this to an array to allow multiple instances to be tested. Signed-off-by: Bruce Ri

Re: [dpdk-dev] [PATCH v2 3/3] app/test: remove ioat-specific autotest

2020-09-14 Thread Laatz, Kevin
On 10/09/2020 17:47, Bruce Richardson wrote: Since the rawdev autotest can now be used to test all rawdevs on the system, there is no need for a dedicated ioat autotest command. Signed-off-by: Bruce Richardson --- app/test/test_rawdev.c | 20 doc/guides/r

Re: [dpdk-dev] [PATCH v2 2/3] app/test: change rawdev autotest to run selftest on all devs

2020-09-14 Thread Laatz, Kevin
On 10/09/2020 17:47, Bruce Richardson wrote: Rather than having each rawdev provide its own autotest command, we can instead just use the generic rawdev_autotest to test any and all available rawdevs. Signed-off-by: Bruce Richardson --- app/test/test_rawdev.c | 34

Re: [dpdk-dev] [PATCH v2 37/37] doc: update quick build doc to remove make references

2020-09-02 Thread Laatz, Kevin
On 20/08/2020 13:41, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/build-sdk-quick.txt | 55 - 1 file changed, 21 insertions(+), 34 deletions(-)

Re: [dpdk-dev] [PATCH v2 36/37] doc: remove references to make in testpmd guides

2020-09-02 Thread Laatz, Kevin
On 20/08/2020 13:41, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/testpmd_app_ug/run_app.rst | 6 +++--- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 + 2 files

Re: [dpdk-dev] [PATCH v2 35/37] doc: remove reference to make in tools guides

2020-09-02 Thread Laatz, Kevin
On 20/08/2020 13:41, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/tools/comp_perf.rst| 10 ++--- doc/guides/tools/cryptoperf.rst | 20 +++-- doc/guides/tool

Re: [dpdk-dev] [PATCH v2 08/18] raw/ioat: create rawdev instances on idxd PCI probe

2020-08-25 Thread Laatz, Kevin
On 21/08/2020 17:29, Bruce Richardson wrote: When a matching device is found via PCI probe create a rawdev instance for each queue on the hardware. Use empty self-test function for these devices so that the overall rawdev_autotest does not report failures. Signed-off-by: Bruce Richardson ---

Re: [dpdk-dev] [PATCH v2 13/18] raw/ioat: add data path for idxd devices

2020-08-25 Thread Laatz, Kevin
On 21/08/2020 17:29, Bruce Richardson wrote: Add support for doing copies using DSA hardware. This is implemented by just switching on the device type field at the start of the inline functions. Since there is no hardware which will have both device types present this branch will always be predic

Re: [dpdk-dev] [PATCH v2 10/18] raw/ioat: add datapath data structures for idxd devices

2020-08-25 Thread Laatz, Kevin
On 21/08/2020 17:29, Bruce Richardson wrote: Add in the relevant data structures for the data path for DSA devices. Also include a device dump function to output the status of each device. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/idxd_pci.c| 3 +- drivers/raw/ioat/id

Re: [dpdk-dev] [PATCH v2 02/18] raw/ioat: split header for readability

2020-08-25 Thread Laatz, Kevin
On 21/08/2020 17:29, Bruce Richardson wrote: Rather than having a single long complicated header file for general use we can split things so that there is one header with all the publically needed information - data structs and function prototypes - while the rest of the internal details are put

Re: [dpdk-dev] [PATCH v2 17/18] raw/ioat: add xstats tracking for idxd devices

2020-08-24 Thread Laatz, Kevin
On 21/08/2020 17:29, Bruce Richardson wrote: Add update of the relevant stats for the data path functions and point the overall device struct xstats function pointers to the existing ioat functions. At this point, all necessary hooks for supporting the existing unit tests are in place so call th

Re: [dpdk-dev] [PATCH v2 31/37] doc: remove references to make in prog guides

2020-08-20 Thread Laatz, Kevin
On 20/08/2020 13:41, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- MAINTAINERS | 3 +- doc/guides/prog_guide/build_app.rst | 48 +-- .../prog_g

Re: [dpdk-dev] [PATCH v2 23/37] doc: remove references to make in cryptodev guides

2020-08-20 Thread Laatz, Kevin
On 20/08/2020 13:41, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/cryptodevs/aesni_gcm.rst | 4 +- doc/guides/cryptodevs/aesni_mb.rst | 4 +- doc/guides/cryptodevs/armv8.rst

Re: [dpdk-dev] [PATCH 20.11 16/19] doc: remove references to make in prog guides

2020-08-19 Thread Laatz, Kevin
On 07/08/2020 13:30, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/prog_guide/build_app.rst | 46 +--- .../prog_guide/dev_kit_build_system.rst | 218 +-

Re: [dpdk-dev] [PATCH 20.11 06/19] doc: remove references to make in compressdev guides

2020-08-18 Thread Laatz, Kevin
On 07/08/2020 13:29, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/compressdevs/isal.rst | 4 doc/guides/compressdevs/octeontx.rst | 16 doc/guides/comp

Re: [dpdk-dev] [PATCH 20.11 08/19] doc: remove references to make in cryptodev guides

2020-08-18 Thread Laatz, Kevin
On 07/08/2020 13:29, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/cryptodevs/aesni_gcm.rst | 2 -- doc/guides/cryptodevs/aesni_mb.rst | 2 -- doc/guides/cryptodevs/armv8.rst

Re: [dpdk-dev] [PATCH 20.11 09/19] doc: remove references to make in eventdev guides

2020-08-18 Thread Laatz, Kevin
On 07/08/2020 13:29, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/eventdevs/dpaa.rst | 20 doc/guides/eventdevs/dpaa2.rst | 20

Re: [dpdk-dev] [PATCH 20.11 17/19] doc: remove references to make in rawdev guides

2020-08-18 Thread Laatz, Kevin
On 07/08/2020 13:30, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/rawdevs/dpaa2_cmdif.rst | 21 - doc/guides/rawdevs/dpaa2_qdma.rst| 21 -

Re: [dpdk-dev] [PATCH 20.11 05/19] doc: remove references to make in bbdev guides

2020-08-18 Thread Laatz, Kevin
On 07/08/2020 13:29, Ciara Power wrote: Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/bbdevs/fpga_5gnr_fec.rst | 5 + doc/guides/bbdevs/fpga_lte_fec.rst | 5 + doc/guides/bbdevs/turbo_sw.

Re: [dpdk-dev] [PATCH] doc/guides: fix telemetry register command example

2020-05-22 Thread Laatz, Kevin
On 22/05/2020 17:27, Ciara Power wrote: The example shown for registering telemetry commands was previously missing the help text parameter. Fixes: 24cd1b529f35 ("doc: update telemetry guides") Signed-off-by: Ciara Power --- doc/guides/prog_guide/telemetry_lib.rst | 14 +- 1 fil

Re: [dpdk-dev] [PATCH 3/5] telemetry: fix closing socket fd on error

2020-05-18 Thread Laatz, Kevin
On 12/05/2020 16:29, Ciara Power wrote: The socket fd is now being closed when the connection fails. Coverity issue: 358444 Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc: ciara.po...@intel.com Signed-off-by: Ciara Power --- lib/librte_telemetry/telemetry_legacy.c | 1

Re: [dpdk-dev] [PATCH 5/5] telemetry: fix buffer overrun if max bytes read

2020-05-18 Thread Laatz, Kevin
On 12/05/2020 16:29, Ciara Power wrote: If 1024 bytes were received over the socket, this caused buffer_recvf[bytes] to overrun the array. The size of the buffer - 1 is now passed to the read function. Coverity issue: 358442 Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc:

Re: [dpdk-dev] [PATCH 1/5] telemetry: keep telemetry threads separate from data plane

2020-05-18 Thread Laatz, Kevin
On 12/05/2020 16:28, Ciara Power wrote: The threads for listening on the telemetry sockets are control threads and should be separated from those on the data plane. Since telemetry cannot use the rte_ctrl_thread_create() API, as it does not depend on EAL, we pass the ctrl thread cpu_set to teleme

Re: [dpdk-dev] [PATCH 2/5] telemetry: fix error checking for strchr function

2020-05-18 Thread Laatz, Kevin
On 12/05/2020 16:28, Ciara Power wrote: The strchr function return was not being checked which could lead to NULL deferencing later in the function. Coverity issue: 358438 Coverity issue: 358445 Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc: ciara.po...@intel.com Signed

Re: [dpdk-dev] [PATCH 4/5] telemetry: fix checking error return for socket creation

2020-05-18 Thread Laatz, Kevin
On 12/05/2020 16:29, Ciara Power wrote: The return value from the socket function is now checked, as it can return a negative value on error. Coverity issue: 358443 Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc: ciara.po...@intel.com Signed-off-by: Ciara Power --- li

Re: [dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags

2020-04-28 Thread Laatz, Kevin
> > --- > > devtools/libabigail.abignore | 5 + > > lib/librte_eal/x86/include/rte_cpuflags.h | 19 +++ > > lib/librte_eal/x86/rte_cpuflags.c | 18 ++ > > 3 files changed, 42 insertions(+) > > > > diff --git a/devtools/libabigail.abignore

Re: [dpdk-dev] [PATCH v4] eal/cpuflags: add x86 based cpu flags

2020-04-27 Thread Laatz, Kevin
> On 27/04/2020 10:31, Laatz, Kevin wrote: > > > >> (replying this time to the list) > >> > >> On 25/04/2020 17:04, Thomas Monjalon wrote: > >>> 16/04/2020 13:00, Kevin Laatz: > >>>> This patch adds CPU flags which will enable the dete

Re: [dpdk-dev] [PATCH v4] eal/cpuflags: add x86 based cpu flags

2020-04-27 Thread Laatz, Kevin
> (replying this time to the list) > > On 25/04/2020 17:04, Thomas Monjalon wrote: > > 16/04/2020 13:00, Kevin Laatz: > >> This patch adds CPU flags which will enable the detection of ISA > >> features available on more recent x86 based CPUs. > > [...] > >> --- a/devtools/libabigail.abignore > >

Re: [dpdk-dev] [PATCH] telemetry: fix struct reset after value assignment

2020-02-27 Thread Laatz, Kevin
> The ep struct is used to track what type of stats are required by the client. > For PORT_STATS type, it contains the lists of port and metric ids to query, > and > the number of ids in each list. > > The ep struct has values set (num of port and metric ids) when a request for > port stats value

Re: [dpdk-dev] [PATCH v3 3/3] lib: use RTE_DIM to calculate array size

2020-01-24 Thread Laatz, Kevin
> From: Pavan Nikhilesh > > use RTE_DIM to calculate array size. > > Suggested-by: David Marchand > Signed-off-by: Pavan Nikhilesh > Acked-by: Cristian Dumitrescu > --- > lib/librte_ethdev/rte_ethdev.c | 8 +++- > lib/librte_ip_frag/ip_frag_internal.c| 5 ++-

Re: [dpdk-dev] [PATCH v2] usertools: fix telemetry python3 compatibility

2020-01-24 Thread Laatz, Kevin
> The client script for use with the telemetry library did not support > Python3, as the data being sent over the socket was in string format. > Python3 requires the data be explicitly converted to bytes before being > sent. Similarily, the received bytes need to be decoded into string > format. >

Re: [dpdk-dev] [PATCH] ci: update travis to use bionic

2019-12-19 Thread Laatz, Kevin
On 17/12/2019 18:03, Aaron Conole wrote: "Laatz, Kevin" writes: On 17/12/2019 14:44, Aaron Conole wrote: Kevin Laatz writes: Currently, the Travis CI is using Ubuntu 16.04 LTS (Xenial) which is becoming increasingly outdated. This patch updates Travis to use Ubuntu 18.04 L

Re: [dpdk-dev] [PATCH 2/2] devtools: add path to additional shared object files

2019-12-18 Thread Laatz, Kevin
On 18/12/2019 08:23, David Marchand wrote: On Wed, Dec 18, 2019 at 6:39 AM Ruifeng Wang wrote: librte_mempool_ring.so and librte_pmd_null.so are in 'drivers' folder. Add 'drivers' into LD_LIBRARY_PATH so that testpmd can find and make use of these shared libraries. Signed-off-by: Ruifeng Wang

Re: [dpdk-dev] [PATCH] ci: update travis to use bionic

2019-12-17 Thread Laatz, Kevin
On 17/12/2019 14:44, Aaron Conole wrote: Kevin Laatz writes: Currently, the Travis CI is using Ubuntu 16.04 LTS (Xenial) which is becoming increasingly outdated. This patch updates Travis to use Ubuntu 18.04 LTS (Bionic) which will give us the benefit of more up-to-date packages being availble

Re: [dpdk-dev] [PATCH v3] build: fix soname info for 19.11 compatiblity

2019-12-16 Thread Laatz, Kevin
On 12/12/2019 11:58, Bruce Richardson wrote: The soname for each stable ABI version should be just the ABI version major number without the minor number. Unfortunately both major and minor were used causing version 20.1 to be incompatible with 20.0. This patch fixes the issue by switching from 2

Re: [dpdk-dev] [PATCH v4 1/3] build: add dump files for v20.0 ABI

2019-12-12 Thread Laatz, Kevin
On 12/12/2019 09:36, David Marchand wrote: On Thu, Dec 12, 2019 at 9:43 AM David Marchand wrote: You missed some drivers, which makes my tests fail right away: $ for file in $(find lib/ drivers/ -name "*.map") do pattern=$(basename ${file/_version.map}) [ $(find lib/ drivers/ -name "*$pa

Re: [dpdk-dev] [PATCH v4 1/3] build: add dump files for v20.0 ABI

2019-12-12 Thread Laatz, Kevin
On 12/12/2019 08:43, David Marchand wrote: On 11/12/2019 19:21, Kevin Laatz wrote: This patch adds the .dump files generated for the v20.0 ABI. These files will be used to compare the ABI during the meson build when the compat_checks meson is enabled. If there is a mismatch between the .dump

Re: [dpdk-dev] [PATCH v3 0/7] Add ABI compatibility checks to the meson build

2019-12-10 Thread Laatz, Kevin
On 10/12/2019 11:07, David Marchand wrote: On Tue, Dec 3, 2019 at 4:27 PM Laatz, Kevin wrote: On 03/12/2019 11:03, David Marchand wrote: On Fri, Nov 29, 2019 at 10:09 PM Kevin Laatz wrote: With the recent changes made to stabilize ABI versioning in DPDK, it will become increasingly

Re: [dpdk-dev] [PATCH v3 0/7] Add ABI compatibility checks to the meson build

2019-12-03 Thread Laatz, Kevin
On 03/12/2019 11:03, David Marchand wrote: On Fri, Nov 29, 2019 at 10:09 PM Kevin Laatz wrote: With the recent changes made to stabilize ABI versioning in DPDK, it will become increasingly important to check patches for ABI compatibility. We propose adding the ABI compatibility checking to be d

Re: [dpdk-dev] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg

2019-07-19 Thread Laatz, Kevin
On 15/07/2019 11:54, Sean Morrissey wrote: Added telemetry to EAL long options so that when --telemetry is passed as an EAL arg that there is no unrecognized argument error message printed. Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") Cc: ciara.po...@intel.com Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v2] telemetry: fix build warnings seen when using gcc 9

2019-07-03 Thread Laatz, Kevin
On 03/07/2019 10:23, Flavia Musatescu wrote: Suppress the unaligned packed member address warnings by extending the telemetry library build flags with -Wno-address-of-packed-member option, through the WERROR_FLAGS makefile variable. With this change additional warnings are turned on to be treate

Re: [dpdk-dev] [PATCH 8/9] remove experimental tags from all symbol definitions

2019-07-01 Thread Laatz, Kevin
On 29/06/2019 07:19, David Marchand wrote: On Sat, Jun 29, 2019 at 7:57 AM David Marchand mailto:david.march...@redhat.com>> wrote: On Fri, Jun 28, 2019 at 9:20 PM David Marchand mailto:david.march...@redhat.com>> wrote: On Fri, Jun 28, 2019 at 5:57 PM Thomas Monjalon

Re: [dpdk-dev] [PATCH] telemetry: fix build

2019-06-28 Thread Laatz, Kevin
On 27/06/2019 20:51, Ferruh Yigit wrote: Build error: ../lib/librte_telemetry/rte_telemetry.c:558:28: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare] Build error not observed in default make build because telemetry library disabled by default

Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global metrics

2019-06-20 Thread Laatz, Kevin
> Hi Reshma, Kevin, > > Not related to this patch, but when telemetry library enabled, it is causing > some warnings [1] with gcc9 > > The [-Waddress-of-packed-member] warnings already disable for gcc, but > you need following update to "lib/librte_telemetry/Makefile": > -CFLAGS += -I$(SRCDIR)

Re: [dpdk-dev] [PATCH] lib/telemetry: add support to fetch global metrics

2019-05-31 Thread Laatz, Kevin
On 17/05/2019 17:07, Reshma Pattan wrote: telemetry has support for fetching port based stats from metrics library. Metrics library also has global stats which are not fetched by telemetry, so extend telemetry to fetch the global metrics. Signed-off-by: Reshma Pattan --- doc/guides/howto/t

Re: [dpdk-dev] [PATCH] lib/telemetry: fix memory leak

2019-05-31 Thread Laatz, Kevin
On 29/05/2019 13:43, Reshma Pattan wrote: Free the `values` pointer before returning from rte_telemetry_command_ports_all_stat_values() to avoid memory leak. Fixes: c12cefa379 ("telemetry: fix mapping of statistics") CC: sta...@dpdk.org CC: bruce.richard...@intel.com Signed-off-by: Reshma Patta

Re: [dpdk-dev] [PATCH] usertools: replace unsafe input function

2019-04-03 Thread Laatz, Kevin
On 20/03/2019 16:43, Andrius Sirvys wrote: LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.po...@inte

Re: [dpdk-dev] [PATCH] telemetry: fix incorrect stat name to id mapping

2019-04-01 Thread Laatz, Kevin
On 28/03/2019 15:30, Bruce Richardson wrote: If we have two NIC ports which have a different set of NIC stats we can end up having two different stats registered with xstats with the same name. [Since the stats are updated in bulk as a contiguous set, the second driver re-using the registration

Re: [dpdk-dev] [PATCH] telemetry: fix error when using ports of different types

2018-12-21 Thread Laatz, Kevin
On 19/12/2018 11:59, Bruce Richardson wrote: Different NIC ports can have different numbers of xstats on them, which means that we can't just use the xstats list from the first port registered in the telemetry library. Instead, we need to check the type of each port - by checking its ops structur

Re: [dpdk-dev] Question about telemetry on 18.11 release

2018-11-22 Thread Laatz, Kevin
On 21/11/2018 11:38, Ferruh Yigit wrote: On 11/21/2018 7:48 AM, Hideyuki Yamashita wrote: Hello, I have some basic questions about telemetry API which is planned to be relaesed in 18.11. Note that I have read the follwoing document. https://doc.dpdk.org/guides/howto/telemetry.html Q1. In gene

Re: [dpdk-dev] [PATCH] telemetry: fix shared build for make

2018-11-08 Thread Laatz, Kevin
On 07/11/2018 21:08, Thomas Monjalon wrote: 07/11/2018 19:10, Kevin Laatz: Currently, telemetry is not working for shared builds in make. The --as-needed flag is preventing telemetry from being linked as there are no direct API calls from the app to telemetry. This is causing the --telemetry op

Re: [dpdk-dev] [PATCH v7 01/13] eal: add option register infrastructure

2018-10-24 Thread Laatz, Kevin
On 24/10/2018 15:52, Laatz, Kevin wrote: On 24/10/2018 15:33, Thomas Monjalon wrote: 24/10/2018 16:01, Gaëtan Rivet: Hi Kevin, On Wed, Oct 24, 2018 at 02:27:13PM +0100, Kevin Laatz wrote: This commit adds infrastructure to EAL that allows an application to register it's init function

Re: [dpdk-dev] [PATCH v7 01/13] eal: add option register infrastructure

2018-10-24 Thread Laatz, Kevin
On 24/10/2018 15:33, Thomas Monjalon wrote: 24/10/2018 16:01, Gaëtan Rivet: Hi Kevin, On Wed, Oct 24, 2018 at 02:27:13PM +0100, Kevin Laatz wrote: This commit adds infrastructure to EAL that allows an application to register it's init function with EAL. This allows libraries to be initialized

Re: [dpdk-dev] [PATCH v7 00/13] introduce telemetry library

2018-10-24 Thread Laatz, Kevin
On 24/10/2018 15:13, Thomas Monjalon wrote: 24/10/2018 15:27, Kevin Laatz: This patchset introduces a Telemetry library for DPDK Service Assurance. This library provides an easy way to query DPDK Ethdev metrics. This new library is not defined as experimental. Is it on purpose? We are supposed

Re: [dpdk-dev] [PATCH v6 05/13] telemetry: add client feature and sockets

2018-10-23 Thread Laatz, Kevin
Thanks for the review Mattias. Will address the comments both here and in the 4/13 review. Best regards, Kevin On 22/10/2018 15:05, Mattias Rönnblom wrote: On 2018-10-22 13:00, Kevin Laatz wrote:   @@ -131,6 +217,38 @@ rte_telemetry_initial_accept(struct telemetry_impl *telemetry)   }  

Re: [dpdk-dev] [PATCH v5 00/13] introduce telemetry library

2018-10-22 Thread Laatz, Kevin
Hi Mattias, Thanks for the input and clarification. I will include these changes in the v6. Regards, Kevin On 22/10/2018 08:11, Mattias Rönnblom wrote: On 2018-10-19 12:16, Laatz, Kevin wrote: On 03/10/2018 20:06, Mattias Rönnblom wrote: On 2018-10-03 19:36, Kevin Laatz wrote: From

Re: [dpdk-dev] [PATCH v5 00/13] introduce telemetry library

2018-10-19 Thread Laatz, Kevin
Hi Mattias, On 18/10/2018 09:07, Mattias Rönnblom wrote: Most of the issues I pointed out in v2 of this patchset is still here. Will recheck feedback for the next version. With regards to comments on v2, 3/10, could you please help provide clarification on the below? On 03/10/2018 20:06,

Re: [dpdk-dev] [PATCH v5 01/13] eal: add param register infrastructure

2018-10-18 Thread Laatz, Kevin
Hi Gaetan, Thanks for reviewing and providing suggestions. On 17/10/2018 16:56, Gaëtan Rivet wrote: + +int +rte_param_parse(char *option) +{ + /* Check if the option is in the registered inits */ + TAILQ_FOREACH(param, &rte_param_list, next) { + if (strcmp(option, pa

Re: [dpdk-dev] [PATCH v5 01/13] eal: add param register infrastructure

2018-10-17 Thread Laatz, Kevin
Hi Thomas, On 17/10/2018 14:46, Thomas Monjalon wrote: 17/10/2018 13:45, Gaëtan Rivet: Hi Thomas, On Wed, Oct 17, 2018 at 11:41:53AM +0200, Thomas Monjalon wrote: I still think all the wording is incorrect. Please start by describing what is "param", "flag" and "option" in your mind. They ar

Re: [dpdk-dev] [PATCH v5 01/13] eal: add param register infrastructure

2018-10-17 Thread Laatz, Kevin
Hi Thomas, On 17/10/2018 12:45, Gaëtan Rivet wrote: Hi Thomas, On Wed, Oct 17, 2018 at 11:41:53AM +0200, Thomas Monjalon wrote: I still think all the wording is incorrect. Please start by describing what is "param", "flag" and "option" in your mind. They are all mentioned in this file. Are you

Re: [dpdk-dev] [PATCH v4 01/13] eal: add param register infrastructure

2018-10-16 Thread Laatz, Kevin
Hi Thomas, Thanks for reviewing, see replies below. On 16/10/2018 14:42, Thomas Monjalon wrote: Hi, 11/10/2018 18:58, Kevin Laatz: This commit adds infrastructure to EAL that allows an application to register it's init function with EAL. This allows libraries to be initialized at the end of

Re: [dpdk-dev] [PATCH 11/11] telemetry: add collectd plugin patch

2018-09-19 Thread Laatz, Kevin
On 18/09/2018 10:52, Thomas Monjalon wrote: 23/08/2018 14:08, Ciara Power: This patch adds the patch for the collectd plugin developed for use with the DPDK Telemetry library. The patch is included here to allow users to apply the patch to collectd when using DPDK Telemetry. Further details on a

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: add link show to the cli

2018-06-15 Thread Laatz, Kevin
Hi Cristian, > > + > > + link_list = links_get(); > > We don't need this function, the lined list of links is a global public > object, > please access it directly. link_list is declared as a static struct in link.c so it is not accessible from cli.c I can either leave this function in to p

Re: [dpdk-dev] [PATCH] cryptodev: convert to SPDX license tag

2018-06-14 Thread Laatz, Kevin
Acked-by: Kevin Laatz On 11/06/2018 09:56, Pablo de Lara wrote: Converted the license header of the files that still have the old full header. Signed-off-by: Pablo de Lara --- lib/librte_cryptodev/rte_cryptodev.h | 31 ++-- lib/librte_cryptodev/rte_cryptodev_pmd.h |

Re: [dpdk-dev] [PATCH] event/sw: code refractor for counter set

2018-03-14 Thread Laatz, Kevin
On 27/02/2018 21:10, Vipin Varghese wrote: Counter variable 'out_pkts' had been set to 0, then updated. Current code change elimates double assignment to direct assignment. Signed-off-by: Vipin Varghese <...> Acked-by: Kevin Laatz

Re: [dpdk-dev] [PATCH] event/sw: move stats code for better cache access

2018-03-14 Thread Laatz, Kevin
On 27/02/2018 20:17, Vipin Varghese wrote: variables 'out_pkts_total' and 'out_pkts_total' will be in registers. Hence shifting the code after the loop, helps the update from registers. Signed-off-by: Vipin Varghese <...> Acked-by: Kevin Laatz

Re: [dpdk-dev] [PATCH] event/sw: add unlikely branch predict

2018-03-14 Thread Laatz, Kevin
On 27/02/2018 20:08, Vipin Varghese wrote: For most run cases 'sw->started' holds true. Adding a branch prediction suggestion to compiler helps as this is first conditional check just after entering the function. Signed-off-by: Vipin Varghese --- drivers/event/sw/sw_evdev_scheduler.c | 2 +-

Re: [dpdk-dev] [PATCH v2 2/2] meson: add tests app to build

2017-12-20 Thread Laatz, Kevin
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Harry van Haaren > Sent: Wednesday, December 20, 2017 11:17 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > > Subject: [dpdk-dev] [PATCH v2 2/2] meson: add tests app to build > +test_names = [ > + 'acl_autotest', > +

Re: [dpdk-dev] [PATCH] meson: add tests to build

2017-12-19 Thread Laatz, Kevin
> From: Laatz, Kevin > Sent: Tuesday, December 19, 2017 5:32 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Laatz, Kevin > > Subject: [PATCH] meson: add tests to build > > This commit adds most of the remaining tests to the meson build. > They can be run using test b

Re: [dpdk-dev] [PATCH 13/13] doc: update example eventdev_pipeline

2017-12-11 Thread Laatz, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh > Sent: Thursday, December 7, 2017 8:37 PM > To: Eads, Gage ; > jerin.jacobkollanukka...@cavium.com; Van Haaren, Harry > ; Rao, Nikhil ; > hemant.agra...@nxp.com; Ma, Liang J > Cc: dev@dpdk.org; Pa

Re: [dpdk-dev] [PATCH] eventdev: fix doxygen comments

2017-12-11 Thread Laatz, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh > Sent: Saturday, December 9, 2017 2:40 PM > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH] eventdev: fix doxygen comments > > Fix doxygen ret

Re: [dpdk-dev] [PATCH v3 0/4] increase port_id range

2017-09-18 Thread Laatz, Kevin
> > -Original Message- > > From: Matej Vido [mailto:v...@cesnet.cz] > > Sent: Wednesday, September 13, 2017 4:14 PM > > To: Yigit, Ferruh ; Yang, Zhiyong > > ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3 0/4] increase port_id range > > > > On 11.09.2017 12:23, Ferruh Yigit wrote: >