Re: [PATCH v4 00/11] dts: add test skipping based on capabilities

2024-09-30 Thread Juraj Linkeš
On 24. 9. 2024 10:20, Juraj Linkeš wrote: Add an automated way to gather available capabilities of the tested hardware and skip test suites or cases which require capabilities that are not available. This is done through two decorators: 1. The first marks a test suite method as test case

Re: [PATCH v3 0/2] dts: add driver binding on TG

2024-09-30 Thread Juraj Linkeš
On 24. 9. 2024 18:28, jspew...@iol.unh.edu wrote: From: Jeremy Spewock v3: * removed _remote from _remote_tmp_dir in node * switched to using Path where appropriate * added symlink to dpdk-devbind to dts/ and excluded from the the formatting script Jeremy Spewock (2): dts: add

Re: [PATCH v7 1/1] dts: add text parser for testpmd verbose output

2024-09-30 Thread Juraj Linkeš
On 26. 9. 2024 17:47, jspew...@iol.unh.edu wrote: From: Jeremy Spewock Multiple test suites from the old DTS framework rely on being able to consume and interpret the verbose output of testpmd. The new framework doesn't have an elegant way for handling the verbose output, but test suites are

Re: [PATCH v5 1/1] dts: use PythonShell for Scapy instead of XML-RPC

2024-09-30 Thread Juraj Linkeš
On 26. 9. 2024 18:50, jspew...@iol.unh.edu wrote: From: Jeremy Spewock Previously all scapy commands were handled using an XML-RPC server that ran on the TGNode. This unnecessarily enforces a minimum Python version of 3.10 on the server that is being used as a traffic generator and complicat

Re: [PATCH v5 0/2] dts: adjust packet addressing and add send_packets to test_suite

2024-09-30 Thread Juraj Linkeš
On 26. 9. 2024 20:18, jspew...@iol.unh.edu wrote: From: Jeremy Spewock v5: * add send_packets patch back into this series but as its own patch Jeremy Spewock (2): dts: rework packet addressing dts: add send_packets to test_suite dts/framework/test_suite.py| 83 +++

Re: [PATCH v5 1/1] dts: use PythonShell for Scapy instead of XML-RPC

2024-09-27 Thread Juraj Linkeš
to the interactive session on the TG Node. Bugzilla ID: 1374 Signed-off-by: Jeremy Spewock --- Reviewed-by: Juraj Linkeš

Re: [PATCH v5 1/2] dts: rework packet addressing

2024-09-27 Thread Juraj Linkeš
content of their packets when sending them through the framework. Signed-off-by: Jeremy Spewock --- Reviewed-by: Juraj Linkeš

Re: [PATCH v4 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell

2024-09-27 Thread Juraj Linkeš
+Note that the order of inheritance is important for this class. In order to instantiate this +class, the abstract methods of :class:`~.capturing_traffic_generator.CapturingTrafficGenerator` +must be implemented. Since some of these methods are implemented in the underlying inter

Re: [PATCH v7 1/1] dts: add text parser for testpmd verbose output

2024-09-27 Thread Juraj Linkeš
uites are starting to be written that rely on it. This patch creates a TextParser class that can be used to extract the verbose information from any testpmd output and also adjusts the `stop` method of the shell to return all output that it collected. Signed-off-by: Jeremy Spewock --- Reviewed-by:

Re: [PATCH v3 1/1] dts: rework packet addressing

2024-09-26 Thread Juraj Linkeš
diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py +def _adjust_addresses(self, packets: list[Packet], expected: bool = False) -> list[Packet]: +# The packet is routed from TG egress to TG ingress regardless of whether it is +# expected or no

Re: [PATCH v2 1/1] dts: add send_packets to test suites and rework packet addressing

2024-09-26 Thread Juraj Linkeš
diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py @@ -243,41 +255,74 @@ def get_expected_packet(self, packet: Packet) -> Packet: Returns: `packet` with injected L2/L3 addresses. """ -return self._adjust_addresses(packet, expec

Re: [PATCH v1] dts: add send_packets to test_suite

2024-09-26 Thread Juraj Linkeš
should be here, below the three hyphens. [0] [0] https://doc.dpdk.org/guides/contributing/patches.html#patch-dependencies Other than that, Reviewed-by: Juraj Linkeš

Re: [PATCH v4 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell

2024-09-26 Thread Juraj Linkeš
The subject line should start with a lowercase character and it's also over the character limit. This fits and basically says the same: use PythonShell for Scapy instead of XML-RPC Scapy TG didn't fit but I think the above still works. diff --git a/dts/framework/remote_session/single_active_in

Re: [PATCH v6 1/1] dts: add text parser for testpmd verbose output

2024-09-26 Thread Juraj Linkeš
diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py @@ -581,6 +581,506 @@ class TestPmdPortStats(TextParser): tx_bps: int = field(metadata=TextParser.find_int(r"Tx-bps:\s+(\d+)")) +class PacketOffloadFlag(Flag): +#: R

Re: [PATCH v2 1/1] dts: add send_packets to test suites and rework packet addressing

2024-09-26 Thread Juraj Linkeš
+if num_ip_layers > 0: +ip_src_is_unset = "src" not in l3_to_use.fields +ip_dst_is_unset = "dst" not in l3_to_use.fields +else: +ip_src_is_unset = None +ip_dst_is_unset = None -# The packet is r

Re: [PATCH v4 5/5] dts: add functions for managing VFs to Node

2024-09-25 Thread Juraj Linkeš
I'm wondering whether we should move some of the functionality to the Port class, such as creating VFs and related logic. I wanted to move update_port and such there, but I ran into problems with imports. Maybe if we utilize the if TYPE_CHECKING: guard the imports would work. Seems like a lot

Re: [PATCH v4 4/5] dts: add OS abstractions for creating virtual functions

2024-09-25 Thread Juraj Linkeš
diff --git a/dts/framework/testbed_model/linux_session.py b/dts/framework/testbed_model/linux_session.py @@ -210,3 +214,37 @@ def configure_ipv4_forwarding(self, enable: bool) -> None: """Overrides :meth:`~.os_session.OSSession.configure_ipv4_forwarding`.""" state = 1 i

Re: [PATCH v4 3/5] dts: add class for virtual functions

2024-09-25 Thread Juraj Linkeš
On 23. 9. 2024 20:42, jspew...@iol.unh.edu wrote: From: Jeremy Spewock In DPDK applications virtual functions are treated the same as ports, but within the framework there are benefits to differentiating the two in order to add more metadata to VFs about where they originate from. For this r

Re: [PATCH v4 2/5] dts: parameterize what ports the TG sends packets to

2024-09-25 Thread Juraj Linkeš
On 23. 9. 2024 20:42, jspew...@iol.unh.edu wrote: From: Jeremy Spewock Previously in the DTS framework the helper methods in the TestSuite class designated ports as either ingress or egress ports and would wrap the methods of the traffic generator to allow packets to only flow to those desig

Re: [PATCH v4 1/5] dts: allow binding only a single port to a different driver

2024-09-25 Thread Juraj Linkeš
On 23. 9. 2024 20:42, jspew...@iol.unh.edu wrote: From: Jeremy Spewock Previously the DTS framework only included methods that bind all ports that the test run was aware of to either the DPDK driver or the OS driver. There are however some cases, like creating virtual functions, where you wo

Re: [PATCH v4 0/5] dts: add VFs to the framework

2024-09-25 Thread Juraj Linkeš
On 23. 9. 2024 20:42, jspew...@iol.unh.edu wrote: From: Jeremy Spewock This is no longer an RFC, the body should be there so that we know what the state after it stopped being an RFC is. v4: * apply to next-dts Jeremy Spewock (5): dts: allow binding only a single port to a differ

Re: [PATCH v3] dts: add flow rule dataclass to testpmd shell

2024-09-25 Thread Juraj Linkeš
On 13. 8. 2024 16:41, Dean Marx wrote: add dataclass for passing in flow rule creation arguments, as well as a Capitalize please. __str__ method for converting to a sendable testpmd command. Add flow_create method to TestPmdShell class for initializing flow rules. Signed-off-by: Dean Marx

Re: [PATCH v3 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell

2024-09-25 Thread Juraj Linkeš
On 24. 9. 2024 18:34, Jeremy Spewock wrote: On Tue, Sep 24, 2024 at 6:55 AM Juraj Linkeš wrote: I like how this looks. I have a number of minor comments (mainly wording and naming), but overall it looks very good. On 19. 9. 2024 21:02, jspew...@iol.unh.edu wrote: From: Jeremy Spewock

Re: [PATCH v3 2/2] dts: add binding to different drivers to TG node

2024-09-24 Thread Juraj Linkeš
abstract method for getting the path to the devbind script into the node class. Then, binding ports to the correct drivers is moved into the build target setup and run on both nodes. Bugzilla ID: 1420 Signed-off-by: Jeremy Spewock --- Reviewed-by: Juraj Linkeš

Re: [PATCH v3 1/2] dts: add symbolic link to dpdk-devbind script

2024-09-24 Thread Juraj Linkeš
ewock --- Reviewed-by: Juraj Linkeš

Re: [PATCH v2 1/1] dts: add send_packets to test suites and rework packet addressing

2024-09-24 Thread Juraj Linkeš
On 20. 9. 2024 20:08, jspew...@iol.unh.edu wrote: From: Jeremy Spewock Currently the only method provided in the test suite class for sending packets sends a single packet and then captures the results. There is, in some cases, a need to send multiple packets at once while not really needing

Re: [PATCH v2 1/1] dts: add binding to different drivers to TG node

2024-09-24 Thread Juraj Linkeš
On 24. 9. 2024 15:57, Jeremy Spewock wrote: On Tue, Sep 24, 2024 at 5:12 AM Juraj Linkeš wrote: I have some thoughts for the future: 1a. The traffic generator is specified per-node, so maybe we could also change the binding to be for the whole lifetime of the TG node, 1b. But the same is

Re: [PATCH v2] dts: add VLAN methods to testpmd shell

2024-09-24 Thread Juraj Linkeš
We should bring up the exact names of method used in this patch and talk through them in the call. On 18. 9. 2024 21:41, Dean Marx wrote: added the following methods to testpmd shell class: Capitalize please. vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, tx vlan set/reset,

Re: [PATCH v3 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell

2024-09-24 Thread Juraj Linkeš
I like how this looks. I have a number of minor comments (mainly wording and naming), but overall it looks very good. On 19. 9. 2024 21:02, jspew...@iol.unh.edu wrote: From: Jeremy Spewock Previously all scapy commands were handled using an XML-RPC server that ran on the TGNode. This unnecess

Re: [PATCH v2 1/1] dts: add binding to different drivers to TG node

2024-09-24 Thread Juraj Linkeš
s is moved into the build target setup and run on both nodes. Bugzilla ID: 1420 Signed-off-by: Jeremy Spewock --- With the two minor comments, Reviewed-by: Juraj Linkeš diff --git a/dts/framework/testbed_model/node.py b/dts/framework/testbed_model/node.py @@ -58,8 +65,10 @@ clas

[PATCH v4 00/11] dts: add test skipping based on capabilities

2024-09-24 Thread Juraj Linkeš
r for setting and reverting 9000 MTU to be parametrized. Added references to DPDK libraries and testpmd code to testpmd command parsing methods. Updated capability docstrings. Moved the capability decorator to NicCapability. Juraj Linkeš (11): dts: add the aenum dependency dts: add test

Re: [PATCH v4 06/11] dts: add NIC capability support

2024-09-24 Thread Juraj Linkeš
On 23. 9. 2024 21:26, Jeremy Spewock wrote: On Mon, Sep 23, 2024 at 11:02 AM Juraj Linkeš wrote: Some test cases or suites may be testing a NIC feature that is not supported on all NICs, so add support for marking test cases or suites as requiring NIC capabilities. The marking is done

Re: [PATCH v4 02/11] dts: add test case decorators

2024-09-24 Thread Juraj Linkeš
On 23. 9. 2024 21:26, Jeremy Spewock wrote: One super nit-pick comment below, even without that though I still think this looks good. Reviewed-by: Jeremy Spewock On Mon, Sep 23, 2024 at 11:02 AM Juraj Linkeš wrote: +def is_test_case(function: Callable) -> bool: +

[PATCH v4 11/11] dts: add NIC capabilities from show port info

2024-09-23 Thread Juraj Linkeš
e existing DeviceCapabilitiesFlag class. Dynamic addition of Enum members runs into problems with typing (mypy doesn't know about the members) and documentation generation (Sphinx doesn't know about the members). Signed-off-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Dean Marx --- dts/fram

[PATCH v4 09/11] doc: add DTS capability doc sources

2024-09-23 Thread Juraj Linkeš
Add new files to generate DTS API documentation from. Signed-off-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Dean Marx --- doc/api/dts/framework.testbed_model.capability.rst | 6 ++ doc/api/dts/framework.testbed_model.rst| 2 ++ doc/api/dts

[PATCH v4 10/11] dts: add Rx offload capabilities

2024-09-23 Thread Juraj Linkeš
) and documentation generation (Sphinx doesn't know about the members). Signed-off-by: Juraj Linkeš Reviewed-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 233 ++ dts/tests/TestSuite_pmd_buffer_scatter.py | 1 + 2 files changed, 234 insertions(+) di

[PATCH v4 08/11] dts: add topology capability

2024-09-23 Thread Juraj Linkeš
test suite is or isn't decorated). Signed-off-by: Juraj Linkeš Reviewed-by: Dean Marx --- dts/framework/test_suite.py | 6 +- dts/framework/testbed_model/capability.py | 193 +- dts/framework/testbed_model/topology.py | 35 +++- dts/

[PATCH v4 07/11] dts: add NIC capabilities from show rxq info

2024-09-23 Thread Juraj Linkeš
Add parsing for the show rxq info tespmd command and add support for the Scattered Rx capability. Signed-off-by: Juraj Linkeš Reviewed-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 137 +- dts/framework/testbed_model/capability.py | 12 ++ dts/tests

[PATCH v4 06/11] dts: add NIC capability support

2024-09-23 Thread Juraj Linkeš
. Everything else (even the actual capability object creation) is done internally. Signed-off-by: Juraj Linkeš Reviewed-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 55 +- dts/framework/testbed_model/capability.py | 167 +- 2 files changed, 220

[PATCH v4 03/11] dts: add mechanism to skip test cases or suites

2024-09-23 Thread Juraj Linkeš
uites and test cases with additional attributes that track whether the test case or suite should be skipped the reason for skipping it. Also update the results module with the new SKIP result. Signed-off-by: Juraj Linkeš Reviewed-by: Dean Marx --- dts/framework/runner.py

[PATCH v4 05/11] dts: add basic capability support

2024-09-23 Thread Juraj Linkeš
suite or case stores the capabilities it requires) * Integration with the runner which calls the new APIs to get which capabilities are supported. Signed-off-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Dean Marx --- dts/framework/runner.py | 26 + dts

[PATCH v4 04/11] dts: add support for simpler topologies

2024-09-23 Thread Juraj Linkeš
that don't require any links won't be using methods that use ports. Any test suites or cases requiring links will be skipped in topologies with no links, but this feature is not implemented in this commit. Signed-off-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Dean

[PATCH v4 02/11] dts: add test case decorators

2024-09-23 Thread Juraj Linkeš
added with one of the decorators. The decorators allow us to add further variables to test cases. Also move the test case filtering to TestSuite while changing the mechanism to separate the logic in a more sensible manner. Bugzilla ID: 1460 Signed-off-by: Juraj Linkeš Reviewed-by: Dean Marx

[PATCH v4 01/11] dts: add the aenum dependency

2024-09-23 Thread Juraj Linkeš
capabilities with different names to the same function that retrieves the capabilities. Signed-off-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Dean Marx Reviewed-by: Nicholas Pratte --- dts/poetry.lock| 14 +- dts/pyproject.toml | 1 + 2 files changed, 14 insertions

Re: [PATCH v5 1/1] dts: add text parser for testpmd verbose output

2024-09-23 Thread Juraj Linkeš
The question is when the exception would be raised, or, in other words, what should we do when hasattr(cls, name) is False. If I understand this correctly, is it's False, then name is not among the flags and that means testpmd returned an unsupported flag, which shouldn't happen, but if it doe

Re: [PATCH v3] dts: fix runner target in the Dockerfile

2024-09-19 Thread Juraj Linkeš
On 19. 9. 2024 16:24, jspew...@iol.unh.edu wrote: From: Jeremy Spewock Currently the runner target in the Dockerfile attempts to run the `poetry install` command when building the image, but this fails due to poetry not being found in the container. Poetry is installed in a previous step wit

Re: [PATCH v5 1/1] dts: add text parser for testpmd verbose output

2024-09-19 Thread Juraj Linkeš
diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py @@ -577,6 +577,497 @@ class TestPmdPortStats(TextParser): tx_bps: int = field(metadata=TextParser.find_int(r"Tx-bps:\s+(\d+)")) +class PacketOffloadFlag(Flag): +"""Flag r

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-19 Thread Juraj Linkeš
On 19. 9. 2024 11:36, Juraj Linkeš wrote: diff --git a/dts/Dockerfile b/dts/Dockerfile @@ -24,9 +27,12 @@ FROM base AS runner   # It bakes DTS into the image during the build.   COPY . /dpdk/dts -RUN poetry install --no-dev +# Adds ~/.local/bin to PATH so that packages installed with

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-19 Thread Juraj Linkeš
diff --git a/dts/Dockerfile b/dts/Dockerfile @@ -24,9 +27,12 @@ FROM base AS runner # It bakes DTS into the image during the build. COPY . /dpdk/dts -RUN poetry install --no-dev +# Adds ~/.local/bin to PATH so that packages installed with pipx are callable. `pipx ensurepath` +# fixe

Re: [PATCH v3] dts: correct typos in user config docstrings

2024-09-19 Thread Juraj Linkeš
my Spewock Reviewed-by: Juraj Linkeš --- Applied to next-dts, thanks.

Re: [PATCH v2] dts: add package mode config and updated docs

2024-09-19 Thread Juraj Linkeš
n a future poetry version. Signed-off-by: Dean Marx Reviewed-by: Nicholas Pratte Reviewed-by: Luca Vizzarro --- Reviewed-by: Juraj Linkeš Applied to next-dts, thanks.

Re: [PATCH v5 1/1] dts: add text parser for testpmd verbose output

2024-09-19 Thread Juraj Linkeš
diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py @@ -577,6 +577,497 @@ class TestPmdPortStats(TextParser): tx_bps: int = field(metadata=TextParser.find_int(r"Tx-bps:\s+(\d+)")) +class PacketOffloadFlag(Flag): +"""Flag r

Re: [PATCH 1/1] dts: add binding to different drivers to TG node

2024-09-19 Thread Juraj Linkeš
On 18. 9. 2024 20:50, Jeremy Spewock wrote: On Mon, Sep 16, 2024 at 6:04 AM Juraj Linkeš wrote: On 9. 9. 2024 17:55, Jeremy Spewock wrote: On Mon, Sep 9, 2024 at 8:16 AM Juraj Linkeš wrote: On 12. 8. 2024 19:22, jspew...@iol.unh.edu wrote: From: Jeremy Spewock The DTS framework

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-19 Thread Juraj Linkeš
On 18. 9. 2024 16:16, Jeremy Spewock wrote: On Wed, Sep 18, 2024 at 3:57 AM Juraj Linkeš wrote: diff --git a/dts/Dockerfile b/dts/Dockerfile @@ -24,9 +27,12 @@ FROM base AS runner +# Adds ~/.local/bin to PATH so that packages installed with pipx are callable. `pipx ensurepath

Re: [PATCH v3 11/12] dts: add Rx offload capabilities

2024-09-18 Thread Juraj Linkeš
On 29. 8. 2024 17:40, Jeremy Spewock wrote: On Wed, Aug 28, 2024 at 1:44 PM Jeremy Spewock wrote: On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index 48c31124d1..f83569669e

Re: [PATCH v3 11/12] dts: add Rx offload capabilities

2024-09-18 Thread Juraj Linkeš
On 26. 8. 2024 19:24, Jeremy Spewock wrote: On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index 48c31124d1..f83569669e 100644 --- a/dts/framework/remote_session

Re: [PATCH v3 11/12] dts: add Rx offload capabilities

2024-09-18 Thread Juraj Linkeš
On 3. 9. 2024 21:49, Dean Marx wrote: On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: The scatter Rx offload capability is needed for the pmd_buffer_scatter test suite. The command that retrieves the capability is: show port rx_offload capabilities The command also

Re: [PATCH v3 08/12] dts: add NIC capability support

2024-09-18 Thread Juraj Linkeš
On 27. 8. 2024 18:36, Jeremy Spewock wrote: On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: diff --git a/dts/framework/testbed_model/capability.py b/dts/framework/testbed_model/capability.py index 8899f07f76..9a79e6ebb3 100644 --- a/dts/framework/testbed_model/capability.py +++ b/dts

Re: [PATCH v3 1/1] dts: add text parser for testpmd verbose output

2024-09-18 Thread Juraj Linkeš
On 17. 9. 2024 15:40, Jeremy Spewock wrote: On Mon, Sep 9, 2024 at 7:44 AM Juraj Linkeš wrote: diff --git a/dts/framework/parser.py b/dts/framework/parser.py index 741dfff821..0b39025a48 100644 --- a/dts/framework/parser.py +++ b/dts/framework/parser.py @@ -160,6 +160,36 @@ def _find

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-18 Thread Juraj Linkeš
diff --git a/dts/Dockerfile b/dts/Dockerfile @@ -24,9 +27,12 @@ FROM base AS runner +# Adds ~/.local/bin to PATH so that packages installed with pipx are callable. `pipx ensurepath` +# fixes this issue, but requires the shell to be re-opened which isn't an option for this target. Let'

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-18 Thread Juraj Linkeš
On 17. 9. 2024 17:22, Patrick Robb wrote: Dean actually just came down with an illness. Since the changes in his series are minimal (I see the only ones left are updating dts.rst and the devcontainer json) I think that one of us at UNH should submit a patch which is essentially a v2 of his ser

Re: [PATCH v19 0/5] DTS API docs generation

2024-09-18 Thread Juraj Linkeš
On 21. 8. 2024 17:02, Juraj Linkeš wrote: The generation is done with Sphinx, which DPDK already uses, with slightly modified configuration of the sidebar present in an if block. DTS dependencies do not need to be installed, but there is the option to install doc build dependencies with

Re: [PATCH v19 5/5] dts: add API doc generation

2024-09-17 Thread Juraj Linkeš
On 16. 9. 2024 14:48, Thomas Monjalon wrote: 16/09/2024 10:51, Juraj Linkeš: On 12. 9. 2024 22:09, Thomas Monjalon wrote: 21/08/2024 17:02, Juraj Linkeš: +req_deps = _get_dependencies(_DTS_DEP_FILE_PATH) +req_deps.pop('python') + +for req_dep, dep_data in

Re: [PATCH 5/5] dts: add JSON schema generation script

2024-09-17 Thread Juraj Linkeš
create mode 100755 dts/generate-schema.py Could it be worth putting this into devtools? It is a devtool. diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst @@ -430,6 +430,16 @@ Refer to the script for usage: ``devtools/dts-check-format.sh -h``. Configuration Schema

Re: [PATCH 4/5] dts: use TestSuiteSpec class imports

2024-09-17 Thread Juraj Linkeš
diff --git a/dts/framework/runner.py b/dts/framework/runner.py @@ -229,139 +221,34 @@ def _get_test_suites_with_cases( +filtered_test_cases: list[TestCase] = [ +test_case +for test_case in test_suite_spec.test_cases +if not test_

Re: [PATCH 3/5] dts: use Pydantic in the configuration

2024-09-17 Thread Juraj Linkeš
On 22. 8. 2024 18:39, Luca Vizzarro wrote: This change brings in Pydantic in place of Warlock. Pydantic offers a built-in model validation system in the classes, which allows for a more resilient and simpler code. As a consequence of this change: - most validation is now built-in - further va

Re: [PATCH 2/5] dts: add Pydantic and remove Warlock

2024-09-16 Thread Juraj Linkeš
On 22. 8. 2024 18:39, Luca Vizzarro wrote: Add Pydantic to the project dependencies while dropping Warlock. We should explain what pydantic is and why it's replacing warlock (and I think make them lowercase as that's how they appear in pyproject.toml). But maybe we shouldn't remove warlo

Re: [PATCH 1/5] dts: add TestSuiteSpec class and discovery

2024-09-16 Thread Juraj Linkeš
There are some elements which seem to be present in https://patches.dpdk.org/project/dpdk/patch/20240821145315.97974-4-juraj.lin...@pantheon.tech/, which is an attempt at decorating test cases (buzgilla 1460) as part of the capabilities series. Looks like we could create a separate patch with

Re: [PATCH v1] dts: add verify argument to set forward mode

2024-09-16 Thread Juraj Linkeš
On 12. 8. 2024 16:23, Dean Marx wrote: Add optional verify argument to the set_forward_mode method in testpmd shell. This doesn't add the method, just fixes it's use. Don't forget to fix the subject as well. And also add the tags that Jeremy mentioned. Signed-off-by: Dean Marx --- dt

Re: [PATCH v1] dts: fix runner target in the Dockerfile

2024-09-16 Thread Juraj Linkeš
On 11. 9. 2024 17:50, jspew...@iol.unh.edu wrote: From: Jeremy Spewock Currently the runner target in the Dockerfile attempts to run the `poetry install` command when building the image, but this fails due to poetry not being found in the container. Poetry is installed in a previous step wit

Re: [PATCH v1] dts: add package mode config and updated README

2024-09-16 Thread Juraj Linkeš
On 12. 8. 2024 18:35, Dean Marx wrote: In the current DTS setup description, the user installs poetry with the --no-root option. However, adding 'package-mode = false' to the pyproject.toml sets the same configuration, and running poetry install --no-root will become an error in a future poetr

Re: [PATCH 1/1] dts: add binding to different drivers to TG node

2024-09-16 Thread Juraj Linkeš
On 9. 9. 2024 17:55, Jeremy Spewock wrote: On Mon, Sep 9, 2024 at 8:16 AM Juraj Linkeš wrote: On 12. 8. 2024 19:22, jspew...@iol.unh.edu wrote: From: Jeremy Spewock The DTS framework in its current state supports binding ports to different drivers on the SUT node but not the TG node

Re: [PATCH v19 5/5] dts: add API doc generation

2024-09-16 Thread Juraj Linkeš
On 12. 9. 2024 22:09, Thomas Monjalon wrote: 21/08/2024 17:02, Juraj Linkeš: +if 'dts' in src: +os.environ['DTS_BUILD'] = "y" That's more precisely "DTS doc build". I think the variable name DTS_BUILD may be confusing. Ack, I'll

Re: [PATCH v2 6/6] doc: dpdk documentation changes for new dts config

2024-09-10 Thread Juraj Linkeš
On 5. 7. 2024 19:13, Nicholas Pratte wrote: Adjusted DPDK documentation to reflect the changes made to the dts conf.yaml configuration file. Looking at the changes to conf.yaml, looks like there are missing pieces (such as moved vdevs and memory_channels), but the patch no longer applies

Re: [PATCH v2 5/6] dts: add conditional behavior for test suite

2024-09-10 Thread Juraj Linkeš
On 5. 7. 2024 19:13, Nicholas Pratte wrote: There is some odd functionality/behavior in how the --test-suite parameters interacts in conjunction with the 'test_suites' attribute in the config file. If a user leaves an empty list underneath 'test_suites,' or if they negate the attribute entirel

Re: [PATCH v2 4/6] dts: Rework DPDK Attributes In SUT Node Config

2024-09-10 Thread Juraj Linkeš
diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index e65ea45058..b31f4d8dbe 100644 --- a/dts/framework/config/conf_yaml_schema.json +++ b/dts/framework/config/conf_yaml_schema.json @@ -150,14 +150,21 @@ "os": { "$r

Re: [PATCH v2 3/6] dts: Self-Discovering Architecture Change

2024-09-10 Thread Juraj Linkeš
On 5. 7. 2024 19:13, Nicholas Pratte wrote: The 'arch' attribute in the conf.yaml is unnecessary, as this can be readily discovered within the constructor of any given node. Since OS is determined within user configuration, finding system arch can be done both reliably and easily within the fr

Re: [PATCH v2 2/6] dts: Use First Core Logic Change

2024-09-10 Thread Juraj Linkeš
On 5. 7. 2024 19:13, Nicholas Pratte wrote: Removed use_first_core from the conf.yaml in favor of determining this within the framework. use_first_core continue to serve a purpose in that it is only enabled when core 0 is explicitly provided in the configuration. Any other configuration, inclu

Re: [PATCH v2 1/6] dts: Remove build target config and list of devices

2024-09-10 Thread Juraj Linkeš
The subject line should be all lowercase (except for abbreviations and maybe some other exceptions). On 5. 7. 2024 19:13, Nicholas Pratte wrote: Remove the list of devices from the schema, as these are unuesed. Typo: unuesed Likewise, removed build-target information since these is not curr

Re: [PATCH v1 3/3] dts: rework test suite and dts runner to include test_run configs

2024-09-10 Thread Juraj Linkeš
On 4. 9. 2024 20:18, Jeremy Spewock wrote: On Wed, Aug 21, 2024 at 2:43 PM Nicholas Pratte wrote: diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py index 694b2eba65..fd51796a06 100644 --- a/dts/framework/test_suite.py +++ b/dts/framework/test_suite.py @@ -20,6 +20,7 @@

Re: [PATCH v1 2/3] dts: rework testbed_model Port objects to contain unique identifiers

2024-09-10 Thread Juraj Linkeš
On 21. 8. 2024 20:43, Nicholas Pratte wrote: In order to leverage the usability of unique identifiers on ports, the testbed_model Port object needs some refactoring/trimming of obsolete or needless attributes. Bugzilla ID: 1478 Signed-off-by: Nicholas Pratte --- dts/framework/testbed_mode

Re: [PATCH v1 1/3] dts: rework port attributes in config module

2024-09-10 Thread Juraj Linkeš
As a general note, it's possible we should wait with these changes for the Pydantic changes which could simplify a lot of what we want to do with the config (not just this, but also the split and removing excess attributes). On 21. 8. 2024 20:43, Nicholas Pratte wrote: The current design requ

Re: [RFC v1 0/1] dts: separate allowed values from json schema

2024-09-10 Thread Juraj Linkeš
On 7. 8. 2024 17:01, Luca Vizzarro wrote: Hi Nicholas, Thank you for the proposal. The way I see it is that JSON schema can be very developer unfriendly to read, therefore I would not rely on it for this purpose. Adding $refs as well could start making it more complicated for this purpose.

Re: [PATCH v2] dts: Testbed And Node Configuration Split

2024-09-10 Thread Juraj Linkeš
create mode 100644 dts/execution_conf.yaml As Jeremy mentioned, this is a duplicate. I guess this patch needs to be rebased as it mentions executions all over the place. create mode 100644 dts/node_conf.yaml create mode 100644 dts/testbed_conf.yaml And this should be named test_run_c

Re: [PATCH v1] dts: Testbed And Node Configuration Split

2024-09-10 Thread Juraj Linkeš
On 14. 6. 2024 20:27, Jeremy Spewock wrote: I think this is definitely a step in the right direction in terms of how we structure the config files. Something that I think could also be a cool improvement for how we handle configs is just making a `conf/` directory and then taking all of the co

Re: [PATCH v1] dts: Testbed And Node Configuration Split

2024-09-10 Thread Juraj Linkeš
On 14. 6. 2024 20:32, Jeremy Spewock wrote: On Mon, Jun 10, 2024 at 3:37 PM Nicholas Pratte wrote: -def load_config(config_file_path: Path) -> Configuration: +def load_config(node_config_file_path: Path, exec_config_file_path: Path) -> Configuration: """Load DTS test run configura

Re: [PATCH v1] dts: correct typos in conf.yaml

2024-09-10 Thread Juraj Linkeš
r and ends with a dot Signed-off-by: Dean Marx With those two changes, Reviewed-by: Juraj Linkeš

Re: [PATCH v1 0/1] dts: fix hugepage mounting

2024-09-09 Thread Juraj Linkeš
Applied to next-dts, thanks. On 12. 8. 2024 17:04, jspew...@iol.unh.edu wrote: From: Jeremy Spewock Currently in the DTS framework there are some commands used for remounting hugepages that require super-user privileges but do not use them, causing them to throw errors whenever they are run as

Re: [PATCH v4 0/1] dts: allow for updating MTU with testpmd

2024-09-09 Thread Juraj Linkeš
Applied to next-dts, thanks. On 6. 9. 2024 20:00, jspew...@iol.unh.edu wrote: From: Jeremy Spewock v4: * add dependency on port caching patch to avoid the need for the if-statement that was added in the last version. Jeremy Spewock (1): dts: add methods for modifying MTU to testpmd s

Re: [PATCH v1] dts: add testpmd port information caching

2024-09-09 Thread Juraj Linkeš
Applied to next-dts, thanks. On 23. 8. 2024 9:41, Juraj Linkeš wrote: When using port information multiple times in a testpmd shell instance lifespan, it's desirable to not get the information each time, so caching is added. In case the information changes, there's a way to force

Re: [PATCH v1] dts: fix testpmd port device error handling mode

2024-09-09 Thread Juraj Linkeš
Applied to next-dts, thanks. On 23. 8. 2024 9:45, Juraj Linkeš wrote: Make device_error_handling_mode of testpmd port optional as it may not be present, e.g. in VM ports. Fixes: 61d5bc9bf974 ("dts: add port info command to testpmd shell") Signed-off-by: Juraj Linkeš --- dts

Re: [PATCH 0/4] dts: add pktgen and testpmd changes

2024-09-09 Thread Juraj Linkeš
Series applied to next-dts, thanks. On 6. 8. 2024 14:14, Luca Vizzarro wrote: From: Luca Vizzarro Hello, sending some framework changes that will be required in my upcoming l2fwd test suite. Best, Luca Luca Vizzarro (5): dts: add ability to send/receive multiple packets dts: add rando

Re: [PATCH v1 1/1] dts: add admin privileges to hugepage mounting

2024-09-09 Thread Juraj Linkeš
permissions for both of these actions. Bugzilla ID: 1439 Fixes: b8bdc4c58f57 ("dts: replace pexpect with fabric") Cc: juraj.lin...@pantheon.tech Signed-off-by: Jeremy Spewock Reviewed-by: Juraj Linkeš

Re: [PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-09-09 Thread Juraj Linkeš
On 9. 9. 2024 16:20, Jeremy Spewock wrote: On Fri, Sep 6, 2024 at 12:46 PM Luca Vizzarro wrote: On 23/08/2024 13:16, Juraj Linkeš wrote: As Jeremy mentioned, adding the verify argument may be worthwhile, but maybe only if we actually identify a usecase where we wouldn't want to d

Re: [PATCH 1/1] dts: add binding to different drivers to TG node

2024-09-09 Thread Juraj Linkeš
On 12. 8. 2024 19:22, jspew...@iol.unh.edu wrote: From: Jeremy Spewock The DTS framework in its current state supports binding ports to different drivers on the SUT node but not the TG node. The TG node already has the information that it needs about the different drivers that it has availab

Re: [PATCH v3 5/5] dts: add testpmd set ports queues

2024-09-09 Thread Juraj Linkeš
On 9. 9. 2024 13:01, Luca Vizzarro wrote: Add a facility to update the number of TX/RX queues during the runtime of testpmd. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš

Re: [PATCH v3 4/5] dts: add ability to start/stop testpmd ports

2024-09-09 Thread Juraj Linkeš
this logic from the test writer's duty. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš

Re: [PATCH v3 1/1] dts: add text parser for testpmd verbose output

2024-09-09 Thread Juraj Linkeš
diff --git a/dts/framework/parser.py b/dts/framework/parser.py index 741dfff821..0b39025a48 100644 --- a/dts/framework/parser.py +++ b/dts/framework/parser.py @@ -160,6 +160,36 @@ def _find(text: str) -> Any: return ParserFn(TextParser_fn=_find) +@staticmethod +def find

Re: [PATCH] app/testpmd: add L4 port to verbose output

2024-09-09 Thread Juraj Linkeš
On 16. 8. 2024 13:46, Luca Vizzarro wrote: On 15/08/2024 16:22, Stephen Hemminger wrote: The verbose output is already too verbose. Maybe you would like the simpler format (which does include the port number) see the network packet dissector patches. Hi Stephen, Thank you for the reply y

Re: [PATCH v1 0/1] dts: fix hugepage mounting

2024-09-09 Thread Juraj Linkeš
Reviewed-by: Juraj Linkeš On 12. 8. 2024 17:04, jspew...@iol.unh.edu wrote: From: Jeremy Spewock Currently in the DTS framework there are some commands used for remounting hugepages that require super-user privileges but do not use them, causing them to throw errors whenever they are run as

  1   2   3   4   5   6   7   8   9   10   >