Re: [dpdk-dev] [PATCH] doc: cryptodev deprecation notice for sym session changes

2018-11-14 Thread Joseph, Anoob
> -Original Message- > From: Ananyev, Konstantin > Sent: 14 November 2018 15:38 > To: Joseph, Anoob ; Akhil Goyal > ; dev@dpdk.org; Ravi Kumar ; > Jacob, Jerin ; Doherty, Declan > ; Trahe, Fiona ; Tomasz > Duszynski ; Dmitri Epshtein ; Natalie > Samsono

Re: [dpdk-dev] [PATCH] security: remove experimental tag

2018-11-14 Thread Joseph, Anoob
Acked-by: Anoob Joseph > -Original Message- > From: Akhil Goyal > Sent: 13 November 2018 16:58 > To: dev@dpdk.org > Cc: tho...@monjalon.net; konstantin.anan...@intel.com; Jacob, Jerin > ; Joseph, Anoob > ; radu.nico...@intel.com; > declan.dohe...@intel.com;

Re: [dpdk-dev] [PATCH] doc: cryptodev deprecation notice for sym session changes

2018-11-13 Thread Joseph, Anoob
other? Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: 12 November 2018 17:34 > To: Konstantin Ananyev ; dev@dpdk.org; Ravi > Kumar ; Jacob, Jerin > ; Joseph, Anoob > ; Declan Doherty ; > Fiona Trahe ; Tomasz Duszynski ; > Dmitri Epshtein ; Natalie Sams

Re: [dpdk-dev] [PATCH 2/3] crypto/octeontx: fix null pointer dereferencing

2018-11-12 Thread Joseph, Anoob
Hi Akhil, You can squash the entire series. Or should I send a revised patch? Either way is fine. Anoob > -Original Message- > From: Akhil Goyal > Sent: 12 November 2018 16:51 > To: Joseph, Anoob ; Pablo de Lara > > Cc: Joseph, Anoob ; Jacob, Jerin > ; Ath

Re: [dpdk-dev] [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues

2018-10-28 Thread Joseph, Anoob
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: 29 October 2018 07:49 > To: Joseph, Anoob > Cc: dev@dpdk.org; Ferruh Yigit ; Bruce Richardson > ; Pablo de Lara > ; Jacob, Jerin > ; Athreya, Narayana Prasad > > Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-10-23 Thread Joseph, Anoob
work. Thanks, Anoob > -Original Message- > From: Thomas Monjalon > Sent: 22 October 2018 12:22 > To: Joseph, Anoob > Cc: Trahe, Fiona ; dev@dpdk.org; Akhil Goyal > ; De Lara Guarch, Pablo > ; Murthy, Nidadavolu > ; Jacob, Jerin > ; Athreya, Narayana Prasad &

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-10-21 Thread Joseph, Anoob
plan is to follow the same approach for asym support, maybe we will also follow suit and submit the required patches. @Akhil, Thomas, thoughts? Thanks, Anoob > -Original Message- > From: Trahe, Fiona > Sent: 20 October 2018 02:40 > To: Joseph, Anoob ; Thomas Monjalon >

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-10-16 Thread Joseph, Anoob
Hi Fiona, Reminder!! Thanks, Anoob > -Original Message- > From: Joseph, Anoob > Sent: 10 October 2018 11:10 > To: Thomas Monjalon ; Trahe, Fiona > > Cc: dev@dpdk.org; Akhil Goyal ; Joseph, Anoob > ; De Lara Guarch, Pablo > ; Murthy, Nidadavolu > ; Jacob,

Re: [dpdk-dev] [PATCH] devtools: add exception for OCTEON TX

2018-10-16 Thread Joseph, Anoob
Hi Thomas, Can you review this patch and let me know your comments? Thanks, Anoob > -Original Message- > From: Joseph, Anoob > Sent: 10 October 2018 18:31 > To: Thomas Monjalon > Cc: Joseph, Anoob ; Jacob, Jerin > ; Athreya, Narayana Prasad > ; dev@dpdk.org > S

Re: [dpdk-dev] [PATCH v5 1/3] security: support pdcp protocol

2018-10-16 Thread Joseph, Anoob
I think the same issue is observed if you go through the following doc, https://doc.dpdk.org/api/structrte__security__ipsec__sa__options.html Check for the description of field copy_df in rte_security.h Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: 16 October 201

Re: [dpdk-dev] [PATCH v5 1/3] security: support pdcp protocol

2018-10-16 Thread Joseph, Anoob
al > Sent: 16 October 2018 16:09 > To: dev@dpdk.org > Cc: pablo.de.lara.gua...@intel.com; radu.nico...@intel.com; Jacob, Jerin > ; Athreya, Narayana Prasad > ; Verma, Shally > ; Joseph, Anoob ; > Velumuri, Vidya ; Hemant Agrawal > ; Akhil Goyal > Subject: [PATCH v5 1/

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-10-09 Thread Joseph, Anoob
with varying capability. Thanks, Anoob On 09-10-2018 01:57, Thomas Monjalon wrote: External Email 08/10/2018 17:59, Trahe, Fiona: Hi Akhil, Joseph, Thomas, Just spotted this now. See below. From: Thomas Monjalon [mailto:tho...@monjalon.net] 24/09/2018 13:36, Joseph, Anoob: Hi Fiona, Ca

Re: [dpdk-dev] [PATCH 1/3] security: support pdcp protocol

2018-10-09 Thread Joseph, Anoob
Hi Akhil, Please see inline. Thanks, Anoob On 08-10-2018 15:19, Akhil Goyal wrote: External Email Hi Anoob, @@ -494,6 +553,23 @@ IPsec related configuration parameters are defined in ``rte_security_ipsec_xform    /**< Tunnel parameters, NULL for transport mode */    }; +PDCP relat

Re: [dpdk-dev] [PATCH v3 01/32] common/cpt: add common logging support

2018-10-08 Thread Joseph, Anoob
Hi Thomas, On 08-10-2018 17:57, Thomas Monjalon wrote: External Email 05/10/2018 14:58, Anoob Joseph: +Cavium OCTEON TX +M: Anoob Joseph +F: drivers/common/cpt/ What is the real wording for this device family? Sometimes I read OcteonTX with lowercases and no space, sometimes OCTEONTX without

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-08 Thread Joseph, Anoob
Hi Thomas, On 08-10-2018 18:03, Thomas Monjalon wrote: External Email 05/10/2018 14:58, Anoob Joseph: Ankur Dwivedi (5): common/cpt: add common logging support config: add Cavium OCTEONTX crypto PMD skeleton crypto/octeontx: add register addresses common/cpt: add common code for in

Re: [dpdk-dev] [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues

2018-10-08 Thread Joseph, Anoob
Hi Ferruh, On 08-10-2018 16:30, Ferruh Yigit wrote: External Email On 10/8/2018 11:41 AM, Anoob Joseph wrote: This patchset fixes multiple issues reported by checkpatch in l2fwd code base. These issues would be flagged for any new copy of the file and hence, fixing at the source. Anoob Joseph

Re: [dpdk-dev] [PATCH 1/3] security: support pdcp protocol

2018-10-07 Thread Joseph, Anoob
Hi Akhil, Please see inline. Thanks, Anoob On 05-10-2018 17:35, Akhil Goyal wrote: External Email On 9/6/2018 9:45 AM, Joseph, Anoob wrote: Hi Akhil, Hi Anoob, Thanks for the comments. Please see inline. Thanks, Anoob On 28-08-2018 18:31, akhil.go...@nxp.com wrote: External Email From

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-05 Thread Joseph, Anoob
oyal wrote: External Email On 10/5/2018 6:43 PM, Joseph, Anoob wrote: Hi Akhil, Do you want me to send revised cover letter patch or just summarizing it over email would do? You could do it as you prefer. Just wanted to know the changes that were done in every version that are sent. Thanks, A

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-05 Thread Joseph, Anoob
Hi Akhil, Do you want me to send revised cover letter patch or just summarizing it over email would do? Thanks, Anoob On 05-10-2018 18:34, Akhil Goyal wrote: External Email Hi Anoob, Could you please add the change log in the cover note. Thanks, Akhil On 10/5/2018 6:28 PM, Anoob Joseph wr

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-09-28 Thread Joseph, Anoob
Hi Fiona, Did you get a chance to look at this? Thanks, Anoob On 24-09-2018 17:06, Joseph, Anoob wrote: Hi Fiona, Can you please comment on this? We are adding all capabilities of octeontx-crypto PMD as a macro in otx_cryptodev_capabilites.h file and then we are using it from

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix wrong session size

2018-09-25 Thread Joseph, Anoob
Hi Akhil, Radu, Can you please review this patch and let me know your thoughts? Anoob On 07-09-2018 11:25, Anoob Joseph wrote: Crypto devices, which support lookaside protocol, exposes security session size in addition to the crypto private symmetric session data size. For applications using t

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-09-24 Thread Joseph, Anoob
on to a header and include it from the .c file. I believe, the QAT approach was to avoid variable definition in the header. What do you think would be a better approach here? Thanks, Anoob On 17-09-2018 18:05, Joseph, Anoob wrote: Hi Akhil, On 17-09-2018 17:31, Akhil Goyal wrote: External

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-17 Thread Joseph, Anoob
Hi Thomas, On 17-09-2018 20:06, Thomas Monjalon wrote: External Email 17/09/2018 16:13, Joseph, Anoob: On 17-09-2018 17:50, Akhil Goyal wrote: On 9/17/2018 5:12 PM, Joseph, Anoob wrote: On 17-09-2018 16:07, Akhil Goyal wrote: I think it would be better to squash the makefile related

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-17 Thread Joseph, Anoob
Hi Konstantin, On 17-09-2018 16:06, Ananyev, Konstantin wrote: External Email Hi Anoob, Hi Konstantin, Please see inline. This RFC introduces a new library within DPDK: librte_ipsec. The aim is to provide DPDK native high performance library for IPsec data-path processing. The library is s

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-17 Thread Joseph, Anoob
Hi Akhil, On 17-09-2018 17:50, Akhil Goyal wrote: External Email On 9/17/2018 5:12 PM, Joseph, Anoob wrote: Hi Akhil, On 17-09-2018 16:07, Akhil Goyal wrote: External Email I think it would be better to squash the makefile related changes in the 3/33 patch as the code is actually added in

Re: [dpdk-dev] [PATCH v2 10/33] common/cpt: add PMD ops helper functions

2018-09-17 Thread Joseph, Anoob
HI Akhil, On 17-09-2018 18:17, Akhil Goyal wrote: External Email On 9/4/2018 9:28 AM, Anoob Joseph wrote: From: Murthy NSSR Adding pmd ops helper functions. Control path accessed APIs would be added as helper functions. Adding microcode defined macros etc as dependencies to the helper funct

Re: [dpdk-dev] [PATCH v2 07/33] common/cpt: add hardware register defines

2018-09-17 Thread Joseph, Anoob
Hi Akhil, On 17-09-2018 16:48, Akhil Goyal wrote: External Email +typedef union cpt_res_s { + uint64_t u[2]; + struct cpt_res_s_8s { +#if (RTE_BYTE_ORDER == RTE_BIG_ENDIAN) /* Word 0 - Big Endian */ + uint64_t reserved_17_63    : 47; + uint64_t doneint 

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-09-17 Thread Joseph, Anoob
Hi Akhil, On 17-09-2018 17:31, Akhil Goyal wrote: External Email diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c index d25f9c1..cc0030e 100644 --- a/drivers/crypto/octeontx/otx_cryptodev_ops.c +++ b/drivers/crypto/octeontx/otx_cryptodev_o

Re: [dpdk-dev] [PATCH v2 05/33] common/cpt: add common code for init routine

2018-09-17 Thread Joseph, Anoob
Hi Thomas, On 17-09-2018 17:16, Thomas Monjalon wrote: External Email 17/09/2018 12:45, Akhil Goyal: On 9/4/2018 9:28 AM, Anoob Joseph wrote: +struct pending_queue { + uint16_t enq_tail; + uint16_t deq_head; + uint16_t soft_qlen; + /**< Software expected queue length */ + ui

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-17 Thread Joseph, Anoob
Hi Akhil, On 17-09-2018 16:07, Akhil Goyal wrote: External Email I think it would be better to squash the makefile related changes in the 3/33 patch as the code is actually added in that and here the code is not getting compiled here. So the changes in the following files has to be moved t

Re: [dpdk-dev] [PATCH v2 03/33] crypto/octeontx: add PCI probe and remove

2018-09-17 Thread Joseph, Anoob
Hi Akhil, On 17-09-2018 16:04, Akhil Goyal wrote: External Email +static struct rte_pci_driver otx_cryptodev_pmd = { + .id_table = pci_id_cpt_table, + .drv_flags = RTE_PCI_DRV_NEED_MAPPING, + .probe = otx_cpt_pci_probe, + .remove = otx_cpt_pci_re

Re: [dpdk-dev] [PATCH v2 03/33] crypto/octeontx: add PCI probe and remove

2018-09-16 Thread Joseph, Anoob
Hi Akhil, See inline. Thanks, Anoob On 14-09-2018 18:09, Akhil Goyal wrote: External Email On 9/4/2018 9:28 AM, Anoob Joseph wrote: From: Ankur Dwivedi Adding basic PCI probe/remove functions for OcteonTX crypto device. Initialization function for logging is also added. Signed-off-by: A

Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

2018-09-16 Thread Joseph, Anoob
Hi Akhil, Please see inline. Thanks, Anoob On 14-09-2018 17:41, Akhil Goyal wrote: External Email Hi Anoob, On 9/4/2018 9:28 AM, Anoob Joseph wrote: From: Ankur Dwivedi This adds Makefile, meson.build and config file options. Also adds the version map files and maintainers file to claim

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-15 Thread Joseph, Anoob
Hi Konstantin See inline. Thanks, Anoob On 12-09-2018 23:39, Ananyev, Konstantin wrote: External Email Hi Anoob, Hi Konstantin, Please see inline. This RFC introduces a new library within DPDK: librte_ipsec. The aim is to provide DPDK native high performance library for IPsec data-path

Re: [dpdk-dev] [PATCH v2 00/33] Adding Cavium's OcteonTX crypto PMD

2018-09-14 Thread Joseph, Anoob
Hi Akhil, Pablo, Did you get a chance to look at the patches? Anoob On 04-09-2018 09:28, Anoob Joseph wrote: Ankur Dwivedi (5): config: add Cavium OcteonTX crypto PMD skeleton common/cpt: add common logging support crypto/octeontx: add PCI probe and remove crypto/octeontx: add regi

Re: [dpdk-dev] [PATCH 1/3] security: support pdcp protocol

2018-09-05 Thread Joseph, Anoob
Hi Akhil, Please see inline. Thanks, Anoob On 28-08-2018 18:31, akhil.go...@nxp.com wrote: External Email From: Akhil Goyal Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- doc/guides/prog_guide/rte_security.rst | 90 -- lib/librte_security/rte_secur

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-05 Thread Joseph, Anoob
Hi Konstantin, Please see inline. On 03-09-2018 23:51, Ananyev, Konstantin wrote: External Email Hi Anoob, Hi Konstantin, Few comments. Please see inline. Thanks, Anoob On 24-08-2018 22:23, Konstantin Ananyev wrote: External Email This RFC introduces a new library within DPDK: librte_

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-03 Thread Joseph, Anoob
Hi Konstantin, Few comments. Please see inline. Thanks, Anoob On 24-08-2018 22:23, Konstantin Ananyev wrote: External Email This RFC introduces a new library within DPDK: librte_ipsec. The aim is to provide DPDK native high performance library for IPsec data-path processing. The library is s

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-08-18 Thread Joseph, Anoob
Hi Bruce, On 14-08-2018 16:03, Bruce Richardson wrote: External Email On Mon, Aug 13, 2018 at 09:29:01PM +0530, Joseph, Anoob wrote: Hi Bruce, The reason why l2fwd was chosen was to allow everyone to chip in their ideas while preparing the framework. This framework would be extended to other

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-08-13 Thread Joseph, Anoob
p as l2fwd? Thanks, Anoob On 13-08-2018 14:57, Bruce Richardson wrote: External Email On Mon, Aug 13, 2018 at 12:52:19PM +0530, Joseph, Anoob wrote: Hi Bruce, Pablo, If there are no more issues about the approach, can you review the patches and give the feedback? Please do note that this series doesn

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-08-13 Thread Joseph, Anoob
Hi Bruce, Pablo, If there are no more issues about the approach, can you review the patches and give the feedback? Please do note that this series doesn't add any event mode specific code. That will come as a different patch series after incorporating Jerin's comments. Thanks, Anoob On 02-

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-08-01 Thread Joseph, Anoob
Hi Thomas, On 26-07-2018 22:27, Thomas Monjalon wrote: External Email Anoob Joseph (12): examples/l2fwd: move macro definitions to common header examples/l2fwd: move structure definitions to common header examples/l2fwd: move globally accessed vars to common header examples/l2fwd:

Re: [dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions

2018-07-03 Thread Joseph, Anoob
Hi, Gentle reminder! Thanks, Anoob On 19-06-2018 19:37, Anoob Joseph wrote: External Email Hi Bruce, Thanks for the feedback. Please see inline. + Hemant, Nikhil, Sunil, Gage, Harry, Narender, Pavan, Thomas, Akhil On 19/06/18 15:39, Bruce Richardson wrote: On Tue, Jun 19, 2018 at 03:34

Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-07-03 Thread Joseph, Anoob
Hi Sunil, Please see inline. Thanks, Anoob On 03-07-2018 11:57, Sunil Kumar Kori wrote: External Email Hello Anoob, Regards Sunil Kumar -Original Message- From: Joseph, Anoob [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, June 28, 2018 4:13 PM To: Sunil Kumar Kori

Re: [dpdk-dev] [PATCH 1/2] cryptodev: add min headroom and tailroom requirement

2018-06-28 Thread Joseph, Anoob
Hi Pablo, On 28-06-2018 17:11, De Lara Guarch, Pablo wrote: External Email Hi Anoob, -Original Message- From: Joseph, Anoob [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, June 28, 2018 3:56 AM To: Doherty, Declan ; De Lara Guarch, Pablo Cc: Akhil Goyal ; Ankur Dwivedi

Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-06-28 Thread Joseph, Anoob
Hi Konstantin, On 28-06-2018 17:14, Ananyev, Konstantin wrote: -Original Message- From: Joseph, Anoob [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, June 28, 2018 11:59 AM To: Ananyev, Konstantin ; Sunil Kumar Kori ; Richardson, Bruce ; Jerin Jacob ; De Lara Guarch, Pablo

Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-06-28 Thread Joseph, Anoob
Hi Konstantin, On 28-06-2018 16:17, Ananyev, Konstantin wrote: Hi Anoob, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Joseph, Anoob Sent: Thursday, June 28, 2018 11:43 AM To: Sunil Kumar Kori ; Richardson, Bruce ; Jerin Jacob ; De Lara Guarch, Pablo Cc

Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-06-28 Thread Joseph, Anoob
Hi Sunil, On 27-06-2018 11:50, Sunil Kumar Kori wrote: External Email Regards Sunil Kumar -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Friday, June 8, 2018 10:54 PM To: Bruce Richardson ; Jerin Jacob ; Pablo de Lara Cc: Anoob Joseph ; Hemant Ag

Re: [dpdk-dev] [PATCH 1/2] cryptodev: add min headroom and tailroom requirement

2018-06-27 Thread Joseph, Anoob
Hi Declan, Please see inline. Thanks, Anoob On 26-06-2018 15:42, Doherty, Declan wrote: External Email On 19/06/2018 7:26 AM, Anoob Joseph wrote: Enabling crypto devs to specify the minimum headroom and tailroom it expects in the mbuf. For net PMDs, standard headroom has to be honoured by

Re: [dpdk-dev] [PATCH 1/2] cryptodev: add min headroom and tailroom requirement

2018-06-21 Thread Joseph, Anoob
Hi Akhil, The change adds couple of entries in cryptodev_info structure. I was under the impression this will be an ABI change and would need one release cycle. If we can get this through in 18.08, it would be great. Do you want me to revise the patch stating it that way? Thanks, Anoob On 21