Reviewed-by: John Daley
Thanks,
John
From: Weiguo Li
Date: Wednesday, November 1, 2023 at 12:28 AM
To: John Daley (johndale)
Cc: dev@dpdk.org , sta...@dpdk.org , Weiguo Li
Subject: [PATCH] net/enic: avoid extra unlock when setting MTU in enic
The 'set_mtu_done' goto statemen
Acked-by: John Daley
From: Thomas Monjalon
Date: Thursday, October 19, 2023 at 8:41 AM
To: dev@dpdk.org
Cc: David Marchand , chen...@nvidia.com
, Jerin Jacob , Michal Krawczyk
, Shai Brandes , Evgeny Schemeilin
, Igor Chauskin , Ron Beider
, John Daley (johndale) , Hyong Youb
Kim
o: Jie Hai , dev@dpdk.org , John Daley
(johndale) , Hyong Youb Kim (hyonkim)
Cc: lihuis...@huawei.com , fengcheng...@huawei.com
, liudongdo...@huawei.com
Subject: Re: [PATCH v5 14/40] net/enic: check RSS hash algorithms
On 10/11/2023 10:27 AM, Jie Hai wrote:
> A new field 'algorithm
Reviewed-by: John Daley johnd...@cisco.com<mailto:johnd...@cisco.com>
From: Chengwen Feng
Date: Monday, March 20, 2023 at 2:28 AM
To: tho...@monjalon.net , ferruh.yi...@amd.com
, John Daley (johndale) , Hyong Youb
Kim (hyonkim)
Cc: dev@dpdk.org
Subject: [PATCH v2 13/44] net/eni
Thank you, I will take a look and get back to you.
-john
From: Kevin Traynor
Date: Wednesday, March 15, 2023 at 10:47 AM
To: John Daley (johndale) , Hyong Youb Kim (hyonkim)
Cc: Luca Boccassi , David Marchand
, dev@dpdk.org
Subject: Fwd: [Bug 1185] enic: no longer accepting 2048 descriptor
Acked-by: John Daley
From: Stephen Hemminger
Date: Friday, January 13, 2023 at 1:52 PM
To: dev@dpdk.org
Cc: Stephen Hemminger , John Daley (johndale)
, Hyong Youb Kim (hyonkim)
Subject: [PATCH 6/7] enic: replace zero length array with flex array
Zero length arrays are GNU extension. Replace
806eea59fe ("net/enic: support GENEVE flow item")
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/enic_fm_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c
index f0bda19a7
Newer VIC adapters have the max number of supported RX and TX
descriptors in their configuration. Use these values as the
maximums.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/base/cq_enet_desc.h | 6 -
drivers/net/enic/enic_res.c | 20
Update the configuration structure used between the adapter and
driver. The structure is compatible with all Cisco VIC adapters.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/base/vnic_enet.h | 22 ++
1 file changed, 22 insertions(+)
diff --git
eCPRI message can be over Ethernet layer (.1Q supported also) or over
UDP layer. Message header formats are the same in these two variants.
Only up though the first packet header in the PDU can be matched.
RSS on the eCPRI payload is not supported.
Signed-off-by: John Daley
Reviewed-by: Hyong
Newer VIC adapters have the max number of supported RX and TX
descriptors in their configuration. Use these values as the
maximums.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
v3: add line just below so 0-day bot applies dependency
Depends-on: patch-105799 ("net/enic: updat
eCPRI message can be over Ethernet layer (.1Q supported also) or over
UDP layer. Message header formats are the same in these two variants.
Only up though the first packet header in the PDU can be matched.
RSS on the eCPRI payload is not supported.
Signed-off-by: John Daley
Reviewed-by: Hyong
Reviewed-by: John Daley
Thanks,
John
-Original Message-
From: Weiguo Li
Sent: Tuesday, January 25, 2022 4:01 AM
To: John Daley (johndale)
Cc: dev@dpdk.org
Subject: [PATCH] net/enic: adjust memory check and use in proper order
Fixes: bb66d562aefc ("net/enic: share flow actions
Newer VIC adapters have the max number of supported RX and TX
descriptors in their configuration. Use these values as the
maximums.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
v2: fix RTE_ASSERT
drivers/net/enic/base/cq_enet_desc.h | 6 -
drivers/net/enic/enic_res.c
eCPRI message can be over Ethernet layer (.1Q supported also) or over
UDP layer. Message header formats are the same in these two variants.
Only up though the first packet header in the PDU can be matched.
RSS on the eCPRI header fields is not supported.
Signed-off-by: John Daley
Reviewed-by
Newer VIC adapters have the max number of supported RX and TX
descriptors in their configuration. Use these values as the
maximums.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/base/cq_enet_desc.h | 6 -
drivers/net/enic/enic_res.c | 20
Update the configuration structure used between the adapter and
driver. The structure is compatible with all Cisco VIC adapters.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/base/vnic_enet.h | 22 ++
1 file changed, 22 insertions(+)
diff --git
eCPRI message can be over Ethernet layer (.1Q supported also) or over
UDP layer. Message header formats are the same in these two variants.
Only up though the first packet header in the PDU can be matched.
RSS on the eCPRI header fields is not supported.
Signed-off-by: John Daley
Reviewed-by
Here are a couple patches to the enic PMD that should apply on top of
the patch:
'net/enic: support GENEVE flow item' by Hyong Youb Kim.
John Daley (3):
net/enic: add support for eCPRI matching
net/enic: update VIC firmware API
net/enic: support max descriptors allowed
must be specified but its value is not enforced.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
v2: Fixed specification of the max enic flowman item
v3: Fixed endianness of UDP dst port
doc/guides/nics/enic.rst | 2 +
doc/guides/nics/features/enic.ini | 3 +
doc
must be specified but its value is not enforced.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
v2: Fixed specification of the max enic flowman item
doc/guides/nics/enic.rst | 2 +
doc/guides/nics/features/enic.ini | 3 +
doc/guides/rel_notes/release_21_11.rst
must be specified but its value is not enforced.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
doc/guides/nics/enic.rst | 2 +
doc/guides/nics/features/enic.ini | 3 +
doc/guides/rel_notes/release_21_11.rst | 4 +
drivers/net/enic/enic_fm_flow.c| 119
nnel_port_{add,del} to accept Geneve port, in
addition to VXLAN.
Fixes: 93fb21fdbe23 ("net/enic: enable overlay offload for VXLAN and GENEVE")
Cc: sta...@dpdk.org
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
v1: update release notes
doc/guides/nics/enic.rst
nnel_port_{add,del} to accept Geneve port, in
addition to VXLAN.
Fixes: 93fb21fdbe23 ("net/enic: enable overlay offload for VXLAN and GENEVE")
Cc: sta...@dpdk.org
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
doc/guides/nics/enic.rst | 32 +++---
drivers/net/
/enic: use 64B completion queue entries if available")
Cc: sta...@dpdk.org
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
v1: fix typo
drivers/net/enic/enic_rxtx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/enic/enic_rxtx.c b/driver
/enic: use 64B completion queue entries if available")
Cc: sta...@dpdk.org
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/enic_rxtx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/enic/enic_rxtx.c b/drivers/net/enic/enic_rx
Fix a rare case in rte_flow initialization where the action hash table
is not freed if allocating a NIC match table fails.
Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager
API")
Cc: sta...@dpdk.org
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
--
The Flow Director (FDIR) API was removed in release 20.11.
This patch removes the remainder of the FDIR code in the
PMD.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/enic.h | 23 --
drivers/net/enic/enic_clsf.c | 334
Coverity issue: 363046
Fixes: bb66d562aefc ("net/enic: share flow actions with same signature")
Signed-off-by: John Daley
---
drivers/net/enic/enic_fm_flow.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/enic/enic_fm_flow.c b/driver
Flow actions are a limited resource on the Cisco VIC, but they
can be shared between flows if they are exactly the same.
Use a hash table and a reference count in the PMD to enable sharing
actions with the same signature between flows.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
1400 series adapters support multiple MARK and FLAG action types.
e.g.: mark id 10 / queue index 2 / mark id 11 / queue index 3
Remove the restriction in the Flow Manager implementation.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/enic_fm_flow.c | 9
number of queues is not a power
of 2.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
doc/guides/nics/enic.rst| 4 +++
drivers/net/enic/enic_fm_flow.c | 56 ++---
2 files changed, 41 insertions(+), 19 deletions(-)
diff --git a/doc/guides/nics
Update the VIC Flow Manager API. The extentions will allow support for:
- Decap and strip VLAN
- Remove outer VLAN
- Set Egress port
- Set VLAN when replicating encapped packets
- RSS queue ranges on outer header
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net
Each RTE RQ is represented on enic as a Start Of Packet (SOP) queue and
and overflow queue (DATA). There were arranged SOP0/DATA0, SOP1/DATA1,...
but need to be arranged SOP0, SOP1,..., DATA0, DATA1... so that
rte_flow RSS queue ranges work.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
steer and decap.
Also, allow just one decap action per flow.
Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager
API")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Signed-off-by: John Daley
---
drivers/net/enic/enic_fm_f
Use the RTE_MIN and RTE_MAX macros instead of private macros.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
v2 - remove the min_t and max_t macros all together
drivers/net/enic/enic_compat.h | 10 --
drivers/net/enic/enic_res.c| 20
2 files
You are right, just need to cast #define parameters, then can use the RTE_MIN
and MAX.
Will do a patch.
Thanks,
john
> -Original Message-
> From: Thomas Monjalon
> Sent: Sunday, January 19, 2020 12:24 PM
> To: John Daley (johndale) ; Hyong Youb Kim
> (hyonkim)
Move a macro from a widely included header file to a header file
used only by the one caller of the macro.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/enic_compat.h | 10 --
drivers/net/enic/enic_res.h| 11 ++-
2 files changed, 10 insertions
Use the memzone namesize, Ethernet address length defines from the RTE
header files instead of locally defined versions.
Use the RTE byte swap functions instead of the x86 specific locally
defined versions.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/base
There were defines which originally allowed sharing of some code with
the enic kernel driver. The code has long since diverged and now the
abstraction just makes the code harder to read. Mostly mechanical
replacement of defines and reformatting.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb
The legacy filter API "flow director" has been superseded by rte_flow
since 2017. Remove comments in the enic guide regarding the deprecated
feature.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
doc/guides/nics/enic.rst | 33 +++--
1 file
vNic" mode or "SN" mode.
Also, minor formatting changes.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/enic.h| 2 ++
drivers/net/enic/enic_ethdev.c | 5 +++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/enic/enic.
> -Original Message-
> From: Stephen Hemminger
> Sent: Friday, July 26, 2019 1:51 PM
> To: Hyong Youb Kim (hyonkim)
> Cc: John Daley (johndale) ; Ferruh Yigit
> ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging
>
> O
> -Original Message-
> From: Ferruh Yigit
> Sent: Friday, July 26, 2019 3:01 AM
> To: John Daley (johndale)
> Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim)
> Subject: Re: [PATCH] net/enic: retain previous message logging
>
> On 7/26/2019 9:17 AM, Joh
to suddenly hide these messages is not a good
idea.
This patch changes the default log level to RTE_LOG_INFO for enic so
messages are printed as before the fix.
Fixes: bbd8ecc05434 ("net/enic: remove PMD log type references")
Signed-off-by: John Daley
---
v2: Change default lo
fd.io.
-john
> -Original Message-
> From: John Daley (johndale)
> Sent: Thursday, July 25, 2019 1:26 PM
> To: Ferruh Yigit
> Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim)
> Subject: RE: [PATCH] net/enic: retain previous message logging
>
> Ok, lets NAK this patch.
Ok, lets NAK this patch. See comment inline.
Thanks,
John
> -Original Message-
> From: Ferruh Yigit
> Sent: Thursday, July 25, 2019 3:07 AM
> To: John Daley (johndale)
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] net/enic: retain previous message logging
>
> On
and some tests failed because
messages were no longer displayed. Other apps may also depend on
the messages.
Fixes: bbd8ecc05434 ("net/enic: remove PMD log type references")
Signed-off-by: John Daley
---
drivers/net/enic/enic_compat.h | 2 +-
drivers/net/enic/enic_mai
Don't use RTE_LOGTYPE_PMD as it is too general.
Also, just use 1 log type for all of enic PMD (pmd.net.enic)
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/enic_compat.h| 13 ++--
drivers/net/enic/enic_ethdev.c| 32 -
drivers/net
Due to time zone differences, I'll answer for Hyong (below).
-john
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, March 13, 2019 1:36 PM
> To: Ferruh Yigit ; Hyong Youb Kim (hyonkim)
>
> Cc: Andrew Rybchenko ; Qi Zhang
> ; dev@dpdk.org; John D
ction")
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
v2 - fix typo
drivers/net/enic/base/vnic_dev.c| 40 -
drivers/net/enic/base/vnic_dev.h| 2 +-
drivers/net/enic/base/vnic_devcmd.h | 1 +
drivers/net/enic/enic.h
Ok, makes sense now, both flow query and flow list work with this patch, yeah.
Tested-by: John Daley
Remember that https://patches.dpdk.org/patch/46221/ still needs to be reverted
out of dpdk-next-net/master otherwise we are still broken. The patch was
squished into e5b652ea34.
-johnd
ction")
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/base/vnic_dev.c| 40 -
drivers/net/enic/base/vnic_dev.h| 2 +-
drivers/net/enic/base/vnic_devcmd.h | 1 +
drivers/net/enic/enic.h | 4 +++-
driver
This patch fixes the 'flow list ' command which caused a
segfault when passing the action or item 'type' field instead
of the action or item struct pointer in the call to rte_flow_conv.
Fixes: 7d94dcedf7ce ("app/testpmd: rely on flow API conversion function")
Signe
s not
selected by default. So add a new devarg enable-avx2-rx to allow the
user to request the use of the new handler. When enable-avx2-rx=1, the
driver will consider using the new handler.
Also update the guide doc and introduce the vectorized handler.
Signed-off-by: Hyong Youb Kim
Reviewed-by:
From: Hyong Youb Kim
Move a number of Rx functions to the header file so that the avx2
based Rx handler can use them.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
v2: remove bool type from stucture (found by checkpatch)
v3: re-add Reviewed-by
v4: Address Ferruh's com
s not
selected by default. So add a new devarg enable-avx2-rx to allow the
user to request the use of the new handler. When enable-avx2-rx=1, the
driver will consider using the new handler.
Also update the guide doc and introduce the vectorized handler.
Signed-off-by: Hyong Youb Kim
Reviewed-by:
From: Hyong Youb Kim
Move a number of Rx functions to the header file so that the avx2
based Rx handler can use them.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
v3: re-add Reviewed-by
drivers/net/enic/enic_rxtx.c| 263 +-
drivers/net
From: Hyong Youb Kim
Add the vectorized version of the no-scatter Rx handler. It aims to
process 8 descriptors per loop using AVX2 SIMD instructions. This
handler is in its own file enic_rxtx_vec_avx2.c, and makefile and
meson.build are modified to compile it when the compiler supports
AVX2. Unde
From: Hyong Youb Kim
Move a number of Rx functions to the header file so that the avx2
based Rx handler can use them.
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_rxtx.c| 263 +-
drivers/net/enic/enic_rxtx_common.h | 271 ++
Add counter action support
Signed-off-by: John Daley
---
doc/guides/nics/enic.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/nics/enic.rst b/doc/guides/nics/enic.rst
index 438a83d5f..86941fdb2 100644
--- a/doc/guides/nics/enic.rst
+++ b/doc/guides/nics/enic.rst
also be deleted.
Counters are DMAd to pre-allocated consistent memory periodically,
controlled by the define VNIC_FLOW_COUNTER_UPDATE_MSECS. The default is
100 milliseconds.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
v2: fix parens (coding style)
drivers/net/enic/base/vnic_dev.c
rte_flow structures were not being freed when destroyed or flushed.
Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters
enabled")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Signed-off-by: John Daley
---
v2: fix signoff
drivers/net/enic/enic_flow.c | 2
From: Hyong Youb Kim
Move a number of Rx functions to the header file so that the avx2
based Rx handler can use them.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_rxtx.c| 263 +-
drivers/net/enic/enic_rxtx_common.h
s not
selected by default. So add a new devarg enable-avx2-rx to allow the
user to request the use of the new handler. When enable-avx2-rx=1, the
driver will consider using the new handler.
Also update the guide doc and introduce the vectorized handler.
Signed-off-by: Hyong Youb Kim
Reviewed-by:
Add counter action support
Signed-off-by: John Daley
---
doc/guides/nics/enic.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/nics/enic.rst b/doc/guides/nics/enic.rst
index 438a83d5f..86941fdb2 100644
--- a/doc/guides/nics/enic.rst
+++ b/doc/guides/nics/enic.rst
also be deleted.
Counters are DMAd to pre-allocated consistent memory periodically,
controlled by the define VNIC_FLOW_COUNTER_UPDATE_MSECS. The default is
100 milliseconds.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/net/enic/base/vnic_dev.c| 93
rte_flow structures were not being freed when destroyed or flushed.
Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters
enabled")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_flow.c | 2 ++
1 file
From: Hyong Youb Kim
Since the following commit, PKT_RX_VLAN indicates the presence of
mbuf's vlan_tci, not PKT_RX_VLAN_STRIPPED.
commit 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
Cc: olivier.m...@6wind.com
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
--
.
Fixes: 93fb21fdbe23 ("net/enic: enable overlay offload for VXLAN and GENEVE")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_main.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/net/enic/enic_main.c b/d
: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_main.c | 14 +++---
drivers/net/enic/enic_rxtx.c | 21 +
2 files changed, 32 insertions(+), 3 deletions(-)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index fd940c583
From: Hyong Youb Kim
Replace PKT_TX_VLAN_PKT (deprecated) with PKT_TX_VLAN.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_res.c | 2 +-
drivers/net/enic/enic_rxtx.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/enic
sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_rxtx.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/enic/enic_rxtx.c b/drivers/net/enic/enic_rxtx.c
index 7129e1217..0eb113d75 100644
--- a/drivers/net/enic/en
From: Hyong Youb Kim
Bugzilla ID: 39
Fixes: 9913fbb91df0 ("enic/base: common code")
Fixes: 322b355f2183 ("net/enic/base: bring NIC interface functions up to date")
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/base/vnic_devcmd.h | 16
From: Hyong Youb Kim
Cisco VIC models support RTE_IOVA_VA, so enable it. This change allows
the driver to work properly when --no-huge is used, in combination
with vfio and iommu.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_ethdev.c | 3 ++-
1 file changed
ned-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
v2: fix signoff
drivers/net/enic/enic_main.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index f04dc0878..03bde76b2 100644
--- a/drivers/net/enic/enic_main.c
+++
ned-off-by: Hyong Youb Kim
Reviewed-by: John Daley johnd...@cisco.com>
---
drivers/net/enic/enic_main.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index f04dc0878..03bde76b2 100644
--- a/drivers/net/enic/enic
ned-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
doc/guides/nics/features/enic.ini | 1 -
doc/guides/rel_notes/release_18_08.rst | 3 +--
drivers/net/enic/enic_main.c | 7 +++
drivers/net/enic/enic_res.c| 2 +-
drivers/net/enic/enic_rxtx.c
Hi Kevin,
Inline.
-john
> -Original Message-
> From: Kevin Traynor
> Sent: Wednesday, July 25, 2018 11:37 AM
> To: John Daley (johndale) ; ferruh.yi...@intel.com
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 00/15] enic PMD fixes and performa
: John Daley
---
doc/guides/nics/enic.rst | 76 +++
doc/guides/nics/features/enic.ini | 3 ++
2 files changed, 48 insertions(+), 31 deletions(-)
diff --git a/doc/guides/nics/enic.rst b/doc/guides/nics/enic.rst
index 7764c8648..438a83d5f 100644
--- a/doc
From: Hyong Youb Kim
enic_set_mtu always reverts to the default Rx handler after changing
MTU. Try to use the simpler, non-scatter handler in this case as well.
Fixes: 35e2cb6a1795 ("net/enic: add simple Rx handler")
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
v2: r
From: Hyong Youb Kim
enic_set_mtu always reverts to the default Rx handler after changing
MTU. Try to use the simpler, non-scatter handler in this case as well.
Fixes: 1187012c1ede ("net/enic: add simple Rx handler")
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
driver
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
doc/guides/rel_notes/release_18_08.rst | 8
1 file changed, 8 insertions(+)
diff --git a/doc/guides/rel_notes/release_18_08.rst
b/doc/guides/rel_notes/release_18_08.rst
index bc0124295..903f046c8 100644
--- a/doc/guides
Add an optimized Rx handler for non-scattered Rx.
Signed-off-by: Hyong Youb Kim
Signed-off-by: John Daley
---
drivers/net/enic/base/cq_desc.h | 1 +
drivers/net/enic/base/vnic_rq.h | 2 +
drivers/net/enic/enic.h | 2 +
drivers/net/enic/enic_ethdev.c | 3 +-
drivers/net/enic
In the default Rx handler stop processing packets at the end of
the completion ring so that wrapping doesn't have to be checked
in the inner while loop.
Also, check the color bit in the completion without using a conditional.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
dr
From: Hyong Youb Kim
The default tx handler checks the maximum packet size. Check it in the
prepare handler too. WQ stops working if the app/driver tries to send
oversized packets, so these checks are unavoidable.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic
/simplified handlers is from the Intel
and Mellanox drivers.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
v2: removed devarg to disable handler
drivers/net/enic/enic.h| 2 ++
drivers/net/enic/enic_compat.h | 5 +++
drivers/net/enic/enic_ethdev.c | 4 ---
drivers/net
From: Hyong Youb Kim
Request one completion update per roughly 32 buffers. It saves DMA
resources on the NIC, PCIe utilization, and cache miss rates.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/base/vnic_wq.c | 1 +
drivers/net/enic/base/vnic_wq.h | 1
From: Hyong Youb Kim
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
v2: documented new feature in enic.ini file
doc/guides/nics/features/enic.ini | 1 +
drivers/net/enic/base/vnic_wq.h | 1 +
drivers/net/enic/enic.h | 1 +
drivers/net/enic/enic_ethdev.c| 11
: John Daley
---
drivers/net/enic/base/vnic_wq.c | 8
drivers/net/enic/base/vnic_wq.h | 10 ++
drivers/net/enic/enic_main.c| 6 +++---
drivers/net/enic/enic_rxtx.c| 18 ++
4 files changed, 15 insertions(+), 27 deletions(-)
diff --git a/drivers/net/enic
From: Hyong Youb Kim
Report min/max ring sizes, alignments, and so on, and rely on the
common checks implemented in the rte_ethdev layer.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_ethdev.c | 24
drivers/net/enic/enic_main.c
Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic.h| 4 +++
drivers/net/enic/enic_ethdev.c | 75 ++
drivers/net/enic/enic_main.c | 1 +
3 files changed, 80 insertions(+)
diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h
index
n ingress
packet if it matches vNIC's default VLAN.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
v2: documented new devarg in enic driver documentation.
doc/guides/nics/enic.rst | 15 +++---
drivers/net/enic/enic.h| 1 +
From: Hyong Youb Kim
The fetch index must be initialized only when RQ is
disabled. Otherwise, it may lead to stale entries in IG descriptor
cache on the VIC.
Fixes: a74629cfa3a1 ("net/enic: enable RQ first and then post Rx buffers")
Signed-off-by: Hyong Youb Kim
Reviewed-by:
(enic_alloc_rq) does not this problem.
Fixes: fefed3d1e62c ("enic: new driver")
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_ethdev.c | 5 +++--
drivers/net/enic/enic_main.c | 30 ++
2 files changed, 17 inserti
: 94c351895888 ("net/enic: update UDP RSS controls")
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/base/vnic_dev.c| 16
drivers/net/enic/base/vnic_dev.h| 4
drivers/net/enic/base/vnic_devcmd.h | 23 ++-
d
erlay offload for VXLAN and GENEVE")
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_rxtx.c | 42 --
1 file changed, 36 insertions(+), 6 deletions(-)
diff --git a/drivers/net/enic/enic_rxtx.c b/drivers/net/enic/enic_rx
Tx completion updates
net/enic: add the simple version of Tx handler
net/enic: check maximum packet size in Tx prepare handler
John Daley (3):
net/enic: add simple Rx handler
net/enic: cap Rx packet processing to end of desc ring
doc: update release notes with new enic features
doc
In the default Rx handler stop processing packets at the end of
the completion ring so that wrapping doesn't have to be checked
in the inner while loop.
Also, check the color bit in the completion without using a conditional.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
dr
Add an optimized Rx handler for non-scattered Rx.
Signed-off-by: Hyong Youb Kim
Signed-off-by: John Daley
---
drivers/net/enic/base/cq_desc.h | 1 +
drivers/net/enic/base/vnic_rq.h | 2 +
drivers/net/enic/enic.h | 2 +
drivers/net/enic/enic_ethdev.c | 3 +-
drivers/net/enic
1 - 100 of 375 matches
Mail list logo
