[dpdk-dev] [PATCH v2] power: fix unused-but-set variable error

2021-11-05 Thread Jim Harris
array in struct priority_worker wasn't useful and should be removed. This allows us to also remove num_dequeue_pkts_prev and pc from struct priority_worker since they are only used in conjunction with the ppi_av array. Signed-off-by: Jim Harris --- lib/power/rte_power_empty_poll.c | 12 +--

[dpdk-dev] [PATCH] test-compress-perf: fix unused-but-set-variable error

2021-10-29 Thread Jim Harris
clang-13 rightfully complains that the total_deq_ops variable in cperf_cyclecount_op_setup is set but not used, since the final accumulated total_deq_ops results isn't used anywhere. So just remove the total_deq_ops variable. Signed-off-by: Jim Harris --- app/test-compress

[dpdk-dev] [PATCH] power: fix unused-but-set variable error

2021-10-29 Thread Jim Harris
clang-13 rightfully complains that the tot_ppi variable in update_stats is set but not used, since the final accumulated tot_ppi results isn't used anywhere. So just remove the tot_ppi variable. Signed-off-by: Jim Harris --- lib/power/rte_power_empty_poll.c | 3 +-- 1 file changed, 1 inse

[dpdk-dev] [PATCH] eal: fix unused-but-set-variable error

2021-10-29 Thread Jim Harris
clang-13 rightfully complains that the total_mem variable in eal_parse_socket_arg is set but not used, since the final accumulated total_mem result isn't used anywhere. So just remove the total_mem variable. Signed-off-by: Jim Harris --- lib/eal/linux/eal.c | 2 -- 1 file changed, 2 dele

[dpdk-dev] [PATCH v5] pci/linux: copy new id for inserted device

2020-10-13 Thread Jim Harris
When a device is inserted into an existing BDF slot that has not been probed, we must overwrite the old PCI ID with the ID of the new function. Otherwise we may not probe the function with the correct driver, if at all. Signed-off-by: Jim Harris --- drivers/bus/pci/linux/pci.c | 4 +++- 1 file

[dpdk-dev] [PATCH v4] pci/linux: copy new id for inserted device

2020-10-13 Thread Jim Harris
When a device is inserted into an existing BDF slot that has not been probed, we must overwrite the old PCI ID with the ID of the new function. Otherwise we may not probe the function with the correct driver, if at all. Signed-off-by: Jim Harris --- drivers/bus/pci/linux/pci.c | 4 +++- 1 file

[dpdk-dev] [PATCH v3] pci/linux: copy new id for inserted device

2020-10-12 Thread Jim Harris
When a device is inserted into an existing BDF slot that has not been probed, we must overwrite the old PCI ID with the ID of the new function. Otherwise we may not probe the function with the correct driver, if at all. Signed-off-by: Jim Harris --- drivers/bus/pci/linux/pci.c | 4 +++- 1 file

[dpdk-dev] [PATCH v2] pci/linux: copy new id for inserted device

2020-08-24 Thread Jim Harris
When a device is inserted into an existing BDF slot that has not been probed, we must overwrite the old PCI ID with the ID of the new function. Otherwise we may not probe the function with the correct driver, if at all. Signed-off-by: Jim Harris --- drivers/bus/pci/linux/pci.c | 4 +++- 1 file

[dpdk-dev] [PATCH] pci/linux: copy new id for inserted device

2020-08-21 Thread Jim Harris
When a device is inserted into an existing BDF slot that has not been probed, we must overwrite the old PCI ID with the ID of the new function. Otherwise we may not probe the function with the correct driver, if at all. Signed-off-by: Jim Harris --- drivers/bus/pci/linux/pci.c | 4 +++- 1 file

[dpdk-dev] [PATCH] contigmem: cleanup properly when load fails

2020-03-09 Thread Jim Harris
ned-off-by: Jim Harris --- kernel/freebsd/contigmem/contigmem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/freebsd/contigmem/contigmem.c b/kernel/freebsd/contigmem/contigmem.c index 64e0a7fec..abb76f241 100644 --- a/kernel/freebsd/contigmem/contigmem.c +++ b/kern

[dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()

2019-10-07 Thread Jim Harris
;s just remove it. While the warning has no functional meaning, the /proc/cpuinfo parsing consumes a non-trivial amount of time which is especially noticeable in secondary processes. On my test system, it consumes 21ms out of the 66ms total execution time for rte_eal_init() in a secondary pro

[dpdk-dev] [PATCH v6 RESEND] eal: add tsc_hz to rte_mem_config

2019-10-07 Thread Jim Harris
sc_hz without ABI breakage concerns. Reduces rte_eal_init() execution time in a secondary process from 165ms to 66ms on my test system. Signed-off-by: Jim Harris --- lib/librte_eal/common/eal_common_timer.c | 15 +++ lib/librte_eal/common/eal_memcfg.h |3 +++ 2 files ch

[dpdk-dev] [PATCH v2] vhost: add experimental flag

2019-09-24 Thread Jim Harris
case, since the function is declared __rte_always_inline. This also requires updating the vhost_scsi example to allow use of this newly marked experimental API. Signed-off-by: Jim Harris --- examples/vhost_scsi/Makefile|2 ++ examples/vhost_scsi/meson.build |1 + lib/librte_vhost/rte_vh

[dpdk-dev] [PATCH v6] eal: add tsc_hz to rte_mem_config

2019-08-27 Thread Jim Harris
sc_hz without ABI breakage concerns. Reduces rte_eal_init() execution time in a secondary process from 165ms to 66ms on my test system. Signed-off-by: Jim Harris --- lib/librte_eal/common/eal_common_timer.c | 15 +++ lib/librte_eal/common/eal_memcfg.h |3 +++ 2 files ch

[dpdk-dev] [PATCH v5] eal: use memzone to share tsc hz with secondary processes

2019-08-26 Thread Jim Harris
process can lookup. Reduces rte_eal_init() execution time in a secondary process from 165ms to 66ms on my test system. Signed-off-by: Jim Harris --- lib/librte_eal/common/eal_common_timer.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH v4] eal: use memzone to share tsc hz with secondary processes

2019-08-26 Thread Jim Harris
process can lookup. Reduces rte_eal_init() execution time in a secondary process from 165ms to 66ms on my test system. Signed-off-by: Jim Harris --- lib/librte_eal/common/eal_common_timer.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH v3] timer: use rte_mp_msg to get freq from primary process

2019-08-22 Thread Jim Harris
primary process instead using rte_mp_msg. This is much faster than 100ms. Reduces rte_eal_init() execution time in a secondary process from 165ms to 66ms on my test system. Signed-off-by: Jim Harris --- lib/librte_eal/common/eal_common_timer.c | 62 ++ 1 file

[dpdk-dev] [PATCH v2] timer: use rte_mp_msg to get freq from primary process

2019-08-21 Thread Jim Harris
primary process instead using rte_mp_msg. This is much faster than 100ms. Reduces rte_eal_init() execution time in a secondary process from 165ms to 66ms on my test system. Signed-off-by: Jim Harris Change-Id: I584419ed1c7d6f47841e0a0eb23f34c9f1186d35 --- lib/librte_eal/common

[dpdk-dev] [PATCH] timer: use rte_mp_msg to get freq from primary process

2019-08-21 Thread Jim Harris
primary process instead using rte_mp_msg. This is much faster than 100ms. Reduces rte_eal_init() execution time in a secondary process from 165ms to 66ms on my test system. Signed-off-by: Jim Harris Change-Id: I584419ed1c7d6f47841e0a0eb23f34c9f1186d35 --- lib/librte_eal/common

[dpdk-dev] [PATCH v2] timer: remove check_tsc_flags()

2019-08-21 Thread Jim Harris
;s just remove it. While the warning has no functional meaning, the /proc/cpuinfo parsing consumes a non-trivial amount of time which is especially noticeable in secondary processes. On my test system, it consumes 21ms out of the 66ms total execution time for rte_eal_init() in a secondary pro

[dpdk-dev] [PATCH] timer: remove check_tsc_flags()

2019-08-21 Thread Jim Harris
s no functional meaning, the /proc/cpuinfo parsing consumes a non-trivial amount of time which is especially noticeable in secondary processes. On my test system, it consumes 21ms out of the 66ms total execution time for rte_eal_init() in a secondary process. Signed-off-by: Jim Harris --- lib/librt

[dpdk-dev] [PATCH] vhost: add __rte_experimental to rte_vhost_va_from_guest_pa

2019-08-20 Thread Jim Harris
case, since the function is declared __rte_always_inline. Signed-off-by: Jim Harris --- lib/librte_vhost/rte_vhost.h |1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h index 7fb172912..fc27bc21e 100644 --- a/lib/librte_vhost/rte_vhost.h

[dpdk-dev] [PATCH] vhost: remove rte_vhost_va_from_guest_pa from map file

2019-08-19 Thread Jim Harris
-finstrument-functions. Signed-off-by: Jim Harris --- lib/librte_vhost/rte_vhost_version.map |1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map index 5f1d4a75c..4908b9b21 100644 --- a/lib/librte_vhost

[dpdk-dev] [PATCH v4] timer: don't check tsc flags in secondary processes

2019-08-19 Thread Jim Harris
e for rte_eal_init(). So let's just skip checking these flags in secondary processes. Since the primary process is already parsing the entirety of /proc/cpuinfo, the warning printed in the primary process should be sufficient. Signed-off-by: Jim Harris --- lib/librte_eal/linux/eal/eal_time

[dpdk-dev] [PATCH v3 2/2] timer: don't check tsc flags in secondary processes

2019-08-16 Thread Jim Harris
e for rte_eal_init(). So let's just skip checking these flags in secondary processes. Since the primary process is already parsing the entirety of /proc/cpuinfo, the warning printed in the primary process should be sufficient. Signed-off-by: Jim Harris --- lib/librte_eal/linux/eal/eal_time

[dpdk-dev] [PATCH v3 1/2] timer: use rte_mp_msg to pass TSC hz to secondary procs

2019-08-16 Thread Jim Harris
the TSC hz from the primary process. This cuts rte_eal_init() execution time in a secondary process from 165ms to 66ms in my test program. Signed-off-by: Jim Harris --- lib/librte_eal/common/eal_common_timer.c | 70 +- 1 file changed, 68 insertions(+), 2 deletion

[dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases

2019-08-16 Thread Jim Harris
template for using rte_mp_request_sync(). Signed-off-by: Jim Harris --- lib/librte_eal/linux/eal/eal_vfio.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c index 501c74f23..d9541b122

[dpdk-dev] [PATCH v2 2/2] timer: don't check tsc flags in secondary processes

2019-08-16 Thread Jim Harris
e for rte_eal_init(). So let's just skip checking these flags in secondary processes. Since the primary process is already parsing the entirety of /proc/cpuinfo, the warning printed in the primary process should be sufficient. Signed-off-by: Jim Harris --- lib/librte_eal/linux/eal/eal_time

[dpdk-dev] [PATCH v2 1/2] timer: use rte_mp_msg to pass TSC hz to secondary procs

2019-08-16 Thread Jim Harris
the TSC hz from the primary process. This cuts rte_eal_init() execution time in a secondary process from 165ms to 66ms in my test program. Signed-off-by: Jim Harris --- lib/librte_eal/common/eal_common_timer.c | 70 +- 1 file changed, 68 insertions(+), 2 deletion

[dpdk-dev] [PATCH 1/2] timer: use rte_mp_msg to pass TSC hz to secondary procs

2019-08-15 Thread Jim Harris
the TSC hz from the primary process. This cuts rte_eal_init() execution time in a secondary process from 165ms to 66ms in my test program. Signed-off-by: Jim Harris --- lib/librte_eal/common/eal_common_timer.c | 70 +- 1 file changed, 68 insertions(+), 2 deletion

[dpdk-dev] [PATCH 2/2] timer: don't check tsc flags in secondary processes

2019-08-15 Thread Jim Harris
e for rte_eal_init(). So let's just skip checking these flags in secondary processes. Since the primary process is already parsing the entirety of /proc/cpuinfo, the warning printed in the primary process should be sufficient. Signed-off-by: Jim Harris --- lib/librte_eal/linux/eal/eal_time

[dpdk-dev] [PATCH v2] mem: add --match-allocations

2018-12-14 Thread Jim Harris
) exactly as it was originally allocated. Since part of this patch is extending the size of struct malloc_elem, we also fix up the malloc autotests so they do not assume its size exactly fits in one cacheline. Signed-off-by: Jim Harris --- doc/guides/linux_gsg/linux_eal_parameters.rst | 4 doc

[dpdk-dev] [PATCH] mem: add --match-allocations

2018-12-13 Thread Jim Harris
callback) exactly as it was originally allocated. Since part of this patch is extending the size of struct malloc_elem, we also fix up the malloc autotests so they do not assume its size exactly fits in one cacheline. Signed-off-by: Jim Harris --- doc/guides/prog_guide/env_abstraction_layer.rst | 13

[dpdk-dev] [RFC] mem: do not merge elems from different heap allocs

2018-11-29 Thread Jim Harris
tered - implementation of one of those is deferred pending feedback on this RFC. Signed-off-by: Jim Harris --- lib/librte_eal/common/malloc_elem.c | 14 ++ lib/librte_eal/common/malloc_elem.h | 6 +- lib/librte_eal/common/malloc_heap.c | 7 ++- 3 files changed, 21 insertions(+), 6 dele

[dpdk-dev] [PATCH v2] contigmem: zero all pages during mmap

2016-08-16 Thread Jim Harris
Verkamp Tested-by: Daniel Verkamp Acked-by: Sergio Gonzalez Monroy Signed-off-by: Jim Harris --- lib/librte_eal/bsdapp/contigmem/contigmem.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/bsdapp/contigmem/contigmem.c b/lib/librte_eal/bsdapp/contig

[dpdk-dev] [PATCH] contigmem: zero all pages during mmap

2016-08-15 Thread Jim Harris
was OK on Linux because the kernel zeroes the pages during app start, but this broke FreeBSD. So this patch explicitly zeroes the pages before they are mmap'd, to ensure equivalent behavior to Linux Reported-by: Daniel Verkamp Tested-by: Daniel Verkamp Signed-off-by: Jim Harris ---

[dpdk-dev] [PATCH] i40e: fix i40e_reset_tx_queue cmd_type_offset_bsz init

2014-10-01 Thread Jim Harris
Fix the descriptor initialization loop, so that it initializes the i40e_tx_desc::cmd_type_offset_bsz for the correct index into the tx_ring array. Previously it would use the index once to initialize the txd local variable, then again when setting cmd_type_offset_bsz. Signed-off-by: Jim Harris