RE: [PATCH v3 01/17] net/txgbe: support flow filter for VF

> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, July 1, 2025 10:39 PM > To: Jiawen Wu > Cc: dev@dpdk.org; zaiyuw...@trustnetic.com > Subject: Re: [PATCH v3 01/17] net/txgbe: support flow filter for VF > > On Fri, 13 Jun 2025 16:41:43

[PATCH v3 14/17] net/ngbe: fix incorrect device statistics

_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: fdb1e851975a ("net/ngbe: support basic statistics") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions

[PATCH v3 12/17] net/ngbe: fix MAC control frame forwarding

Test failure on the case "test_pause_fwd_port_stop_start", which expect MAC control frame forwarding setting still working after port stop/start. Fix the bug to pass the test case. Fixes: f40e9f0e2278 ("net/ngbe: support flow control") Cc: sta...@dpdk.org Signed-off-by: Jia

[PATCH v3 17/17] net/txgbe: add missing LRO flag in mbuf when LRO enabled

When LRO is enabled, the driver must set the LRO flag in received aggregated packets to indicate LRO processing to upper-layer applications. Add the missing LRO flag into the ol_flags field of mbuf to fix it. Fixes: 0e484278c85f ("net/txgbe: support Rx") Cc: sta...@dpdk.org Signed-off-

[PATCH v3 16/17] net/ngbe: restrict VLAN strip configuration on VF

affic will cause ring get stuck. So restrict the configuration of VLAN strip offload only if device is started. Fixes: f47dc03c706f ("net/ngbe: add VLAN ops for VF device") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev_vf.c | 24 ++--

[PATCH v3 15/17] net/txgbe: restrict VLAN strip configuration on VF

affic will cause ring get stuck. So restrict the configuration of VLAN strip offload only if device is started. Fixes: aa1ae7941e71 ("net/txgbe: support VF VLAN") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev_vf.c | 31 +

[PATCH v3 13/17] net/txgbe: fix incorrect device statistics

_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: c9bb590d4295 ("net/txgbe: support device statistics") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(

[PATCH v3 11/17] net/txgbe: fix MAC control frame forwarding

Test Failure on the case "test_pause_fwd_port_stop_start", which expect MAC control frame forwarding setting still working after port stop/start. Fix the bug to pass the test case. Fixes: 69ce8c8a4ce3 ("net/txgbe: support flow control") Cc: sta...@dpdk.org Signed-off-by: Jia

[PATCH v3 10/17] net/ngbe: support RSS offload for SCTP port

Add support for IPv4/IPv6 SCTP RSS offload. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 2 ++ drivers/net/ngbe/ngbe_ethdev.h| 2 ++ drivers/net/ngbe/ngbe_rxtx.c | 8 3 files changed, 12 insertions(+) diff --git a/drivers/net/ngbe/base/ngbe_regs.h b

[PATCH v3 09/17] net/txgbe: support RSS offload for SCTP port

Add support for IPv4/IPv6 SCTP RSS offload. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 4 drivers/net/txgbe/txgbe_ethdev.h| 2 ++ drivers/net/txgbe/txgbe_rxtx.c | 16 3 files changed, 22 insertions(+) diff --git a/drivers/net/txgbe/base

[PATCH v3 04/17] net/txgbe: fix packet type for FDIR filters

To match the packet type more flexibly when the pattern is default, add packet type mask for FDIR filters. Fixes: b973ee26747a ("net/txgbe: parse flow director filter") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 20 +-- drivers

[PATCH v3 05/17] net/txgbe: fix to create FDIR filters for SCTP packets

The check for the mask of SCTP item is repeated and wrong, fix it to make it work. Fixes: b973ee26747a ("net/txgbe: parse flow director filter") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 13 - 1 file changed, 13 deletions(-) di

[PATCH v3 07/17] net/txgbe: fix to create FDIR filters for tunnel packets

Fix to create FDIR rules for VXLAN/GRE/NVGRE/GENEVE packets, they will match the rules in the inner layers. Fixes: b973ee26747a ("net/txgbe: parse flow director filter") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + drivers

[PATCH v3 08/17] net/txgbe: fix reserved extra FDIR headroom

;) Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/txgbe/base/txgbe_hw.c b/drivers/net/txgbe/base/txgbe_hw.c index ae2ad87c83..76b9ee3c0a 100644 --- a/drivers/net/txgbe/base/txgbe_

[PATCH v3 06/17] net/txgbe: fix FDIR perfect mode for IPv6 packets

Perfect mode of FDIR rules to filter IPv6 packets is supported by hardware. Remove the restriction and fix the setting. Fixes: b973ee26747a ("net/txgbe: parse flow director filter") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_f

[PATCH v3 02/17] net/txgbe: fix incorrect parsing to ntuple filter

tuple filter") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index 1d854d0767..269f0b54e3 100644 --- a/drivers/net/txgbe/tx

[PATCH v3 03/17] net/txgbe: fix raw pattern match for FDIR rules

ector filter") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.h | 5 ++- drivers/net/txgbe/txgbe_fdir.c | 24 +-- drivers/net/txgbe/txgbe_flow.c | 53 3 files changed, 67 insertions(+), 15 deletions(-) di

[PATCH v3 01/17] net/txgbe: support flow filter for VF

Add 5-tuple filter for VF driver, which request PF driver to write the hardware configurations. So add new PF-VF mailbox API version 2.1 to implement it. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 10 drivers/net/txgbe/base/txgbe_hw.h | 1 + drivers/net/txgbe

[PATCH v3 00/17] Fixes and supports for Wangxun NICs

Fix some bugs and improve flow filters. v2 -> v3: - Split the patch 2/12 for various changes v1 -> v2: - Add new flow feature geneve and gre into txgbe.ini Jiawen Wu (17): net/txgbe: support flow filter for VF net/txgbe: fix incorrect parsing to ntuple filter net/txgbe: fix raw p

RE: [PATCH 02/12] net/txgbe: refactor FDIR filter to improve functionality

> -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 12, 2025 8:30 AM > To: Jiawen Wu > Cc: dev@dpdk.org; zaiyuw...@trustnetic.com; Stephen Hemminger > > Subject: Re: [PATCH 02/12] net/txgbe: refactor FDIR filter to improve > functionality >

[PATCH v2 05/12] net/ngbe: support RSS offload for SCTP port

Add support for IPv4/IPv6 SCTP RSS offload. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 2 ++ drivers/net/ngbe/ngbe_ethdev.h| 2 ++ drivers/net/ngbe/ngbe_rxtx.c | 8 3 files changed, 12 insertions(+) diff --git a/drivers/net/ngbe/base/ngbe_regs.h b

[PATCH v2 03/12] net/txgbe: fix reserved extra FDIR headroom

;) Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/txgbe/base/txgbe_hw.c b/drivers/net/txgbe/base/txgbe_hw.c index ae2ad87c83..76b9ee3c0a 100644 --- a/drivers/net/txgbe/base/txgbe_

[PATCH v2 02/12] net/txgbe: refactor FDIR filter to improve functionality

packets if the pattern is default. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + drivers/net/txgbe/base/txgbe_type.h | 20 +- drivers/net/txgbe/txgbe_ethdev.h| 9 +- drivers/net/txgbe/txgbe_fdir.c | 62 +- drivers/net/txgbe/txgbe_flow.c | 847

[PATCH v2 06/12] net/txgbe: fix MAC control frame forwarding

Test Failure on the case "test_pause_fwd_port_stop_start", which expect MAC control frame forwarding setting still working after port stop/start. Fix the bug to pass the test case. Fixes: 69ce8c8a4ce3 ("net/txgbe: support flow control") Cc: sta...@dpdk.org Signed-off-by: Jia

[PATCH v2 10/12] net/txgbe: restrict VLAN strip configuration on VF

affic will cause ring get stuck. So restrict the configuration of VLAN strip offload only if device is started. Fixes: aa1ae7941e71 ("net/txgbe: support VF VLAN") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev_vf.c | 31 +

[PATCH v2 11/12] net/ngbe: restrict VLAN strip configuration on VF

affic will cause ring get stuck. So restrict the configuration of VLAN strip offload only if device is started. Fixes: f47dc03c706f ("net/ngbe: add VLAN ops for VF device") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev_vf.c | 24 ++--

[PATCH v2 08/12] net/txgbe: fix incorrect device statistics

_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: c9bb590d4295 ("net/txgbe: support device statistics") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(

[PATCH v2 12/12] net/txgbe: add missing LRO flag in mbuf when LRO enabled

When LRO is enabled, the driver must set the LRO flag in received aggregated packets to indicate LRO processing to upper-layer applications. Add the missing LRO flag into the ol_flags field of mbuf to fix it. Fixes: 0e484278c85f ("net/txgbe: support Rx") Cc: sta...@dpdk.org Signed-off-

[PATCH v2 07/12] net/ngbe: fix MAC control frame forwarding

Test failure on the case "test_pause_fwd_port_stop_start", which expect MAC control frame forwarding setting still working after port stop/start. Fix the bug to pass the test case. Fixes: f40e9f0e2278 ("net/ngbe: support flow control") Cc: sta...@dpdk.org Signed-off-by: Jia

[PATCH v2 09/12] net/ngbe: fix incorrect device statistics

_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: fdb1e851975a ("net/ngbe: support basic statistics") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions

[PATCH v2 04/12] net/txgbe: support RSS offload for SCTP port

Add support for IPv4/IPv6 SCTP RSS offload. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 4 drivers/net/txgbe/txgbe_ethdev.h| 2 ++ drivers/net/txgbe/txgbe_rxtx.c | 16 3 files changed, 22 insertions(+) diff --git a/drivers/net/txgbe/base

[PATCH v2 01/12] net/txgbe: support flow filter for VF

Add 5-tuple filter for VF driver, which request PF driver to write the hardware configurations. So add new PF-VF mailbox API version 2.1 to implement it. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 10 drivers/net/txgbe/base/txgbe_hw.h | 1 + drivers/net/txgbe

[PATCH v2 00/12] Fixes and supports for Wangxun NICs

Fix some bugs and improve flow filters. v1 -> v2: - Add new flow feature geneve and gre into txgbe.ini Jiawen Wu (12): net/txgbe: support flow filter for VF net/txgbe: refactor FDIR filter to improve functionality net/txgbe: fix reserved extra FDIR headroom net/txgbe: support RSS offl

[PATCH 04/12] net/txgbe: support RSS offload for SCTP port

Add support for IPv4/IPv6 SCTP RSS offload. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 4 drivers/net/txgbe/txgbe_ethdev.h| 2 ++ drivers/net/txgbe/txgbe_rxtx.c | 16 3 files changed, 22 insertions(+) diff --git a/drivers/net/txgbe/base

[PATCH 12/12] net/txgbe: add missing LRO flag in mbuf when LRO enabled

When LRO is enabled, the driver must set the LRO flag in received aggregated packets to indicate LRO processing to upper-layer applications. Add the missing LRO flag into the ol_flags field of mbuf to fix it. Fixes: 0e484278c85f ("net/txgbe: support Rx") Cc: sta...@dpdk.org Signed-off-

[PATCH 11/12] net/ngbe: restrict VLAN strip configuration on VF

affic will cause ring get stuck. So restrict the configuration of VLAN strip offload only if device is started. Fixes: f47dc03c706f ("net/ngbe: add VLAN ops for VF device") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev_vf.c | 24 ++--

[PATCH 10/12] net/txgbe: restrict VLAN strip configuration on VF

affic will cause ring get stuck. So restrict the configuration of VLAN strip offload only if device is started. Fixes: aa1ae7941e71 ("net/txgbe: support VF VLAN") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev_vf.c | 31 +

[PATCH 06/12] net/txgbe: fix MAC control frame forwarding

Test Failure on the case "test_pause_fwd_port_stop_start", which expect MAC control frame forwarding setting still working after port stop/start. Fix the bug to pass the test case. Fixes: 69ce8c8a4ce3 ("net/txgbe: support flow control") Cc: sta...@dpdk.org Signed-off-by: Jia

[PATCH 09/12] net/ngbe: fix incorrect device statistics

_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: fdb1e851975a ("net/ngbe: support basic statistics") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions

[PATCH 08/12] net/txgbe: fix incorrect device statistics

_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: c9bb590d4295 ("net/txgbe: support device statistics") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(

[PATCH 07/12] net/ngbe: fix MAC control frame forwarding

Test failure on the case "test_pause_fwd_port_stop_start", which expect MAC control frame forwarding setting still working after port stop/start. Fix the bug to pass the test case. Fixes: f40e9f0e2278 ("net/ngbe: support flow control") Cc: sta...@dpdk.org Signed-off-by: Jia

[PATCH 05/12] net/ngbe: support RSS offload for SCTP port

Add support for IPv4/IPv6 SCTP RSS offload. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 2 ++ drivers/net/ngbe/ngbe_ethdev.h| 2 ++ drivers/net/ngbe/ngbe_rxtx.c | 8 3 files changed, 12 insertions(+) diff --git a/drivers/net/ngbe/base/ngbe_regs.h b

[PATCH 02/12] net/txgbe: refactor FDIR filter to improve functionality

packets if the pattern is default. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 20 +- drivers/net/txgbe/txgbe_ethdev.h| 9 +- drivers/net/txgbe/txgbe_fdir.c | 62 +- drivers/net/txgbe/txgbe_flow.c | 847 4 files changed, 669

[PATCH 03/12] net/txgbe: fix reserved extra FDIR headroom

;) Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/txgbe/base/txgbe_hw.c b/drivers/net/txgbe/base/txgbe_hw.c index ae2ad87c83..76b9ee3c0a 100644 --- a/drivers/net/txgbe/base/txgbe_

[PATCH 01/12] net/txgbe: support flow filter for VF

Add 5-tuple filter for VF driver, which request PF driver to write the hardware configurations. So add new PF-VF mailbox API version 2.1 to implement it. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 10 drivers/net/txgbe/base/txgbe_hw.h | 1 + drivers/net/txgbe

[PATCH 00/12] Fixes and supports for Wangxun NICs

Fix some bugs and improve flow filters. Jiawen Wu (12): net/txgbe: support flow filter for VF net/txgbe: refactor FDIR filter to improve functionality net/txgbe: fix reserved extra FDIR headroom net/txgbe: support RSS offload for SCTP port net/ngbe: support RSS offload for SCTP port

RE: [RFC 2/5] net/ngbe: fix query handling in xstats_get

Cc: Zaiyu Wang > -Original Message- > From: Stephen Hemminger > Sent: Thursday, December 5, 2024 6:19 AM > To: dev@dpdk.org > Cc: jiawe...@trustnetic.com > Subject: Re: [RFC 2/5] net/ngbe: fix query handling in xstats_get > > On Tue, 8 Oct 2024 08:59:56 -0700 > Stephen Hemminger wrote

RE: txgbe: vlan offload setting errors

> > > Hello everyone, > > > I recently added a txgbe port and enabled vlan offload. > > > However, when I checked the dpdk logs, I noticed the following error: > > > "2024-12-09T10:32:26.420709+08:00 txgbe_vlan_offload_set(): > > > Please stop port first." > > > > You should stop the device first,

RE: txgbe: vlan offload setting errors

> -Original Message- > From: Wangyunjian(wangyunjian,TongTu) > Sent: Monday, December 9, 2024 8:30 PM > To: dev@dpdk.org; jiawe...@trustnetic.com; jianw...@trustnetic.com > Cc: liwei (DT) ; xiawei (H) > Subject: txgbe: vlan offload setting errors > > Hello everyone, > I recently added a

RE: [PATCH] net/txgbe: fix a mass of interrupts

On Tue, Nov 19, 2024 3:59 AM, Ferruh Yigit wrote: > On 11/15/2024 8:33 AM, Jiawen Wu wrote: > > Since firmware version 0x20010, GPIO interrupt enable is set to 0xd by > > default, which means enable bit 0 'tx_fault'. And GPIO interrupt polarity > > is set to 0xd by

[PATCH] net/txgbe: fix a mass of interrupts

ault' is 0 -> 1 triggers the interrupt. However, the interrupt is not cleared. And GPIO interrupt mask is enabled and disabled to trigger the MISC interrupt repeatedly. Since this 'tx_fault' interrupt does not make much sense, simply clear it to fix the issue. Signed-off-by:

[PATCH v3 12/13] net/ngbe: fix interrupt lost in legacy or MSI mode

When interrupt is legacy or MSI mode, shared interrupt may cause the interrupt cannot be re-enabled. So fix to read the shared interrupt. Fixes: b9246b8fa280 ("net/ngbe: support link update") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 13 ++

[PATCH v3 06/13] net/txgbe: check length of Tx packets

Add checking of the Tx packet length to avoid TDM fatal error as far as possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, and drop it directly in featured Tx code path. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_rxtx.c | 33

[PATCH v3 13/13] net/ngbe: restrict configuration of VLAN strip offload

: 59b46438fdaa ("net/ngbe: support VLAN offload and VLAN filter") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 49 ++ 1 file changed, 20 insertions(+), 29 deletions(-) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/driver

[PATCH v3 10/13] net/ngbe: fix driver load bit to inform firmware

evice") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index 353d17acc8..238533f2b8 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c ++

[PATCH v3 11/13] net/ngbe: reconfigure more MAC Rx registers

onfigure MAC Rx when link update") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 2 ++ drivers/net/ngbe/ngbe_ethdev.c| 6 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/net/ngbe/base/ngbe_regs.h b/drivers/net/ngbe/base/ngbe_reg

[PATCH v3 08/13] net/ngbe: check length of Tx packets

Add checking of the Tx packet length to avoid TDM fatal error as far as possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, and drop it directly in featured Tx code path. Althrough the hardware does not support TDM desc check. Signed-off-by: Jiawen Wu --- drivers/net/ngbe

[PATCH v3 09/13] net/ngbe: add Tx descriptor error statistics

Count the number of packets not sent due to Tx descriptor error. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 13 + drivers/net/ngbe/ngbe_rxtx.c | 2 ++ drivers/net/ngbe/ngbe_rxtx.h | 1 + 3 files changed, 16 insertions(+) diff --git a/drivers/net/ngbe

[PATCH v3 07/13] net/txgbe: add Tx descriptor error statistics

Count the number of packets not sent due to Tx descriptor error. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 13 + drivers/net/txgbe/txgbe_rxtx.c | 6 ++ drivers/net/txgbe/txgbe_rxtx.h | 1 + 3 files changed, 20 insertions(+) diff --git a/drivers/net

[PATCH v3 05/13] net/txgbe: enable Tx descriptor error interrupt

of packet type. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 6 ++ drivers/net/txgbe/txgbe_ethdev.c| 64 ++ drivers/net/txgbe/txgbe_ethdev.h| 3 + drivers/net/txgbe/txgbe_rxtx.c | 100 drivers/net/txgbe/tx

[PATCH v3 04/13] net/txgbe: fix driver load bit to inform firmware

Drv_load bit will be reset to default 0 after hardware LAN reset, reconfigure it to inform firmware that driver is loaded. And set it to 0 when device is closed. Fixes: b1f596677d8e ("net/txgbe: support device start") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers

[PATCH v3 01/13] net/txgbe: fix swfw mbox failure

ned-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_mng.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/txgbe/base/txgbe_mng.c b/drivers/net/txgbe/base/txgbe_mng.c index 20db982891..7dc8f21183 100644 --- a/drivers/net/txgbe/base/txgbe_mng.c +++ b/drivers/net/txgbe/base/txgbe_mng.

[PATCH v3 03/13] net/txgbe: remove outer UDP checksum capability

The hardware does not support outer UDP checksum for tunnel packets. It's wrong to claim this Tx offload capability, so fix it. Bugzilla ID: 1529 Fixes: b950203be7f1 ("net/txgbe: support VXLAN-GPE") Fixes: 295968d17407 ("ethdev: add namespace") Cc: sta...@dpdk.org

[PATCH v3 02/13] net/txgbe: fix VF-PF mbox interrupt

There was a incorrect bit to define TXGBE_ICRMISC_VFMBX that prevents the interrupt from being handled correctly. Fixes: a6712cd029a4 ("net/txgbe: add PF module init and uninit for SRIOV") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 2

[PATCH v3 00/13] Wangxun fixes

Fix some bugs in txgbe/ngbe, and optimize the Tx flow. v2 -> v3: - Reset Tx desc error statistics in .stats_reset(). - Add comment for Tx desc error count. v1 -> v2: - Fix build errors on ARM platform. Jiawen Wu (13): net/txgbe: fix swfw mbox failure net/txgbe: fix VF-PF mbox int

RE: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

> -Original Message- > From: Ferruh Yigit > Sent: Friday, November 1, 2024 10:46 AM > To: Jiawen Wu ; dev@dpdk.org > Subject: Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics > > On 11/1/2024 2:06 AM, Jiawen Wu wrote: >

RE: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

> > @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_error(void *param) > > if (!txq->resetting) > > continue; > > > > + txq->desc_error++; > > > > Why error value is increased in this function, which resets the Tx queue? > Is the intention to reset the error va

RE: [PATCH v2 06/13] net/txgbe: check length of Tx packets

On Fri, Nov 1, 2024 9:23 AM, Ferruh Yigit wrote: > On 10/28/2024 2:31 AM, Jiawen Wu wrote: > > Add checking of the Tx packet length to avoid TDM fatal error as far as > > possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, > > and drop it directly in

[PATCH v2 02/13] net/txgbe: fix VF-PF mbox interrupt

There was a incorrect bit to define TXGBE_ICRMISC_VFMBX that prevents the interrupt from being handled correctly. Fixes: a6712cd029a4 ("net/txgbe: add PF module init and uninit for SRIOV") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 2

[PATCH v2 01/13] net/txgbe: fix swfw mbox failure

ned-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_mng.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/txgbe/base/txgbe_mng.c b/drivers/net/txgbe/base/txgbe_mng.c index 20db982891..7dc8f21183 100644 --- a/drivers/net/txgbe/base/txgbe_mng.c +++ b/drivers/net/txgbe/base/txgbe_mng.

[PATCH v2 13/13] net/ngbe: restrict configuration of VLAN strip offload

: 59b46438fdaa ("net/ngbe: support VLAN offload and VLAN filter") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 49 ++ 1 file changed, 20 insertions(+), 29 deletions(-) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/driver

[PATCH v2 12/13] net/ngbe: fix interrupt lost in legacy or MSI mode

When interrupt is legacy or MSI mode, shared interrupt may cause the interrupt cannot be re-enabled. So fix to read the shared interrupt. Fixes: b9246b8fa280 ("net/ngbe: support link update") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 13 ++

[PATCH v2 05/13] net/txgbe: enable Tx descriptor error interrupt

of packet type. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 6 ++ drivers/net/txgbe/txgbe_ethdev.c| 64 ++ drivers/net/txgbe/txgbe_ethdev.h| 3 + drivers/net/txgbe/txgbe_rxtx.c | 100 drivers/net/txgbe/tx

[PATCH v2 06/13] net/txgbe: check length of Tx packets

Add checking of the Tx packet length to avoid TDM fatal error as far as possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, and drop it directly in featured Tx code path. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_rxtx.c | 33

[PATCH v2 11/13] net/ngbe: reconfigure more MAC Rx registers

onfigure MAC Rx when link update") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 2 ++ drivers/net/ngbe/ngbe_ethdev.c| 6 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/net/ngbe/base/ngbe_regs.h b/drivers/net/ngbe/base/ngbe_reg

[PATCH v2 10/13] net/ngbe: fix driver load bit to inform firmware

evice") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index d9d2daf656..ba46dcf2a5 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c ++

[PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

Count the number of packets not sent due to Tx descriptor error. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 6 ++ drivers/net/txgbe/txgbe_rxtx.c | 3 +++ drivers/net/txgbe/txgbe_rxtx.h | 1 + 3 files changed, 10 insertions(+) diff --git a/drivers/net/txgbe

[PATCH v2 09/13] net/ngbe: add Tx descriptor error statistics

Count the number of packets not sent due to Tx descriptor error. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 6 ++ drivers/net/ngbe/ngbe_rxtx.c | 2 ++ drivers/net/ngbe/ngbe_rxtx.h | 1 + 3 files changed, 9 insertions(+) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b

[PATCH v2 08/13] net/ngbe: check length of Tx packets

Add checking of the Tx packet length to avoid TDM fatal error as far as possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, and drop it directly in featured Tx code path. Althrough the hardware does not support TDM desc check. Signed-off-by: Jiawen Wu --- drivers/net/ngbe

[PATCH v2 03/13] net/txgbe: remove outer UDP checksum capability

The hardware does not support outer UDP checksum for tunnel packets. It's wrong to claim this Tx offload capability, so fix it. Bugzilla ID: 1529 Fixes: b950203be7f1 ("net/txgbe: support VXLAN-GPE") Fixes: 295968d17407 ("ethdev: add namespace") Cc: sta...@dpdk.org

[PATCH v2 00/13] Wangxun fixes

Fix some bugs in txgbe/ngbe, and optimize the Tx flow. v1 -> v2: - Fix build errors on ARM platform. Jiawen Wu (13): net/txgbe: fix swfw mbox failure net/txgbe: fix VF-PF mbox interrupt net/txgbe: remove outer UDP checksum capability net/txgbe: fix driver load bit to inform firmw

[PATCH v2 04/13] net/txgbe: fix driver load bit to inform firmware

Drv_load bit will be reset to default 0 after hardware LAN reset, reconfigure it to inform firmware that driver is loaded. And set it to 0 when device is closed. Fixes: b1f596677d8e ("net/txgbe: support device start") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers

[PATCH 13/13] net/ngbe: restrict configuration of VLAN strip offload

: 59b46438fdaa ("net/ngbe: support VLAN offload and VLAN filter") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 49 ++ 1 file changed, 20 insertions(+), 29 deletions(-) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/driver

[PATCH 12/13] net/ngbe: fix interrupt lost in legacy or MSI mode

When interrupt is legacy or MSI mode, shared interrupt may cause the interrupt cannot be re-enabled. So fix to read the shared interrupt. Fixes: b9246b8fa280 ("net/ngbe: support link update") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 13 ++

[PATCH 11/13] net/ngbe: reconfigure more MAC Rx registers

onfigure MAC Rx when link update") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 2 ++ drivers/net/ngbe/ngbe_ethdev.c| 6 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/net/ngbe/base/ngbe_regs.h b/drivers/net/ngbe/base/ngbe_reg

[PATCH 10/13] net/ngbe: fix driver load bit to inform firmware

evice") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index d9d2daf656..ba46dcf2a5 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c ++

[PATCH 09/13] net/ngbe: add Tx descriptor error statistics

Count the number of packets not sent due to Tx descriptor error. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 6 ++ drivers/net/ngbe/ngbe_rxtx.c | 2 ++ drivers/net/ngbe/ngbe_rxtx.h | 1 + 3 files changed, 9 insertions(+) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b

[PATCH 08/13] net/ngbe: check length of Tx packets

Add checking of the Tx packet length to avoid TDM fatal error as far as possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, and drop it directly in featured Tx code path. Althrough the hardware does not support TDM desc check. Signed-off-by: Jiawen Wu --- drivers/net/ngbe

[PATCH 07/13] net/txgbe: add Tx descriptor error statistics

Count the number of packets not sent due to Tx descriptor error. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 6 ++ drivers/net/txgbe/txgbe_rxtx.c | 3 +++ drivers/net/txgbe/txgbe_rxtx.h | 1 + 3 files changed, 10 insertions(+) diff --git a/drivers/net/txgbe

[PATCH 05/13] net/txgbe: enable Tx descriptor error interrupt

of packet type. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 6 ++ drivers/net/txgbe/txgbe_ethdev.c| 64 ++ drivers/net/txgbe/txgbe_ethdev.h| 3 + drivers/net/txgbe/txgbe_rxtx.c | 100 drivers/net/txgbe/tx

[PATCH 06/13] net/txgbe: check length of Tx packets

Add checking of the Tx packet length to avoid TDM fatal error as far as possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, and drop it directly in featured Tx code path. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_rxtx.c | 33

[PATCH 04/13] net/txgbe: fix driver load bit to inform firmware

Drv_load bit will be reset to default 0 after hardware LAN reset, reconfigure it to inform firmware that driver is loaded. And set it to 0 when device is closed. Fixes: b1f596677d8e ("net/txgbe: support device start") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers

[PATCH 03/13] net/txgbe: remove outer UDP checksum capability

The hardware does not support outer UDP checksum for tunnel packets. It's wrong to claim this Tx offload capability, so fix it. Bugzilla ID: 1529 Fixes: b950203be7f1 ("net/txgbe: support VXLAN-GPE") Fixes: 295968d17407 ("ethdev: add namespace") Cc: sta...@dpdk.org

[PATCH 02/13] net/txgbe: fix VF-PF mbox interrupt

There was a incorrect bit to define TXGBE_ICRMISC_VFMBX that prevents the interrupt from being handled correctly. Fixes: a6712cd029a4 ("net/txgbe: add PF module init and uninit for SRIOV") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 2

[PATCH 01/13] net/txgbe: fix swfw mbox failure

ned-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_mng.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/txgbe/base/txgbe_mng.c b/drivers/net/txgbe/base/txgbe_mng.c index 20db982891..7dc8f21183 100644 --- a/drivers/net/txgbe/base/txgbe_mng.c +++ b/drivers/net/txgbe/base/txgbe_mng.

[PATCH 00/13] Wangxun fixes

Fix some bugs in txgbe/ngbe, and optimize the Tx flow. Jiawen Wu (13): net/txgbe: fix swfw mbox failure net/txgbe: fix VF-PF mbox interrupt net/txgbe: remove outer UDP checksum capability net/txgbe: fix driver load bit to inform firmware net/txgbe: enable Tx descriptor error interrupt

RE: [RFC 1/5] net/txgbe: fix query handling in xstats_get

or (i = 0; i < limit; i++) { > + for (i = 0; i < count; i++) { > uint32_t offset = 0; > > if (txgbe_get_offset_by_id(i, &offset)) { > -- > 2.45.2 > > Thanks! Reviewed-by: Jiawen Wu

RE: [PATCH 07/11] net/txgbe: move wrapper to base driver

On Mon, Sep 9, 2024 2:51 PM, David Marchand wrote: > On Mon, Sep 9, 2024 at 8:18 AM Jiawen Wu wrote: > > > > On Sat, Sep 7, 2024 10:54 PM, David Marchand wrote: > > > BP_LOG() is only used in the base driver. > > > > > > Signed-off-by: David Marchan

RE: [PATCH 07/11] net/txgbe: move wrapper to base driver

On Sat, Sep 7, 2024 10:54 PM, David Marchand wrote: > BP_LOG() is only used in the base driver. > > Signed-off-by: David Marchand > --- > drivers/net/txgbe/base/txgbe_osdep.h | 8 > drivers/net/txgbe/txgbe_logs.h | 7 --- > 2 files changed, 8 insertions(+), 7 deletions(-) >

RE: Bug 1531

> Hello Jianwen, > > In reference to https://bugs.dpdk.org/show_bug.cgi?id=1531#c3 reported > by Yopper, is there is a fix needed for dpdk main branch or LTS branches ? Sure. But adding a 10 us delay seems like a rude way to fix it. Actually, 1 us delay is also effective. So I'll take a moment to

  1   2   3   4   5   6   7   8   9   10   >