Hi Chas,
Could you help to review the v2 of the patch? I have addressed the “Fixes”
requirement in commit message, and modified slave_tx_fail_count’s definition.
Thanks,
Jia
From: Chas Williams <3ch...@gmail.com>
Date: Sunday, August 19, 2018 at 5:07 PM
To: Jia Yu
Cc: "dev@dpdk.or
invalid addresses,
application will crash.
The fix is avoid shifting mbufs, and directly write un-transmitted
packets back to bufs array.
Fixes: 09150784a776 ("net/bonding: burst mode hash calculation")
Cc: sta...@dpdk.org
Signed-off-by: Jia Yu
---
drivers/net/bonding/rte_eth_bond_p
nt == 0, j == 0
}
}
}
Thanks,
Jia
From: Chas Williams <3ch...@gmail.com>
Date: Saturday, August 18, 2018 at 4:50 PM
To: Jia Yu
Cc: "dev@dpdk.org" , Declan Doherty ,
Chas Williams
Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix buf corruption in merging
un-transmitted packets
On Fri,
invalid addresses,
application will crash.
The fix is avoid shifting mbufs, and directly write un-transmitted
packets back to bufs array.
Signed-off-by: Jia Yu
---
drivers/net/bonding/rte_eth_bond_pmd.c | 98 +-
1 file changed, 14 insertions(+), 84 deletions
There exists case that software sets mtu (i.e jumbo frame) of
ixgbe device when it's stopped. Before the fix, scattered_rx
is cleared during device stop, and setting jumbo frame mtu
after device stop will always fail as scattered_rx is 0.
Signed-off-by: Jia Yu
---
drivers/net/
There exists case that software sets mtu (i.e jumbo frame) of
ixgbe device when it's stopped. Before the fix, scattered_rx
is cleared during device stop, and setting jumbo frame mtu
after device stop will always fail as scattered_rx is 0.
---
drivers/net/ixgbe/ixgbe_ethdev.c | 6 --
1 file cha
Hello,
DPDK drivers support tx_stop_queue, but they don't use it for flow control,
I.e. Stop upper layer calling the device tx_pkt_burst routine when there is no
resource. I wonder if flow control is needed here, if yes, is there plan to add
this support?
Thanks,
Jia
eth_driver already contains rte_pci_driver data structure.
Allocating rte_pci_driver without referencing it after bond
creation causes memory leakage.
Added signed off information.
Signed-off-by: Jia Yu
---
lib/librte_pmd_bond/rte_eth_bond_api.c | 11 ++-
1 file changed, 2 insertions
eth_driver already contains rte_pci_driver data structure.
Allocating rte_pci_driver without referencing it after bond
creation causes memory leakage.
---
lib/librte_pmd_bond/rte_eth_bond_api.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/lib/librte_pmd_bond/rte_
c != 0). Therefore, for hardware NIC
(e.g. 82599) that disabled lsc by default, the link_update callback will
not be executed. Please let me know if you have other concerns.
Thanks,
Jia
On 2/3/15, 12:35 AM, "Zhang, Helin" wrote:
>
>
>> -Original Message-
>> From
t;2014-11-12 03:57, Zhang, Helin:
>> Hi Jia
>>
>> > -Original Message-
>> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jia Yu
>> > Sent: Saturday, November 8, 2014 1:32 AM
>> > To: dev at dpdk.org
>> > Subject: [dpdk-dev
orman" wrote:
>On Tue, Dec 09, 2014 at 09:53:18AM +0100, Olivier MATZ wrote:
>> Hi Neil,
>>
>> On 12/08/2014 04:04 PM, Neil Horman wrote:
>> >On Fri, Nov 07, 2014 at 09:28:09AM -0800, Jia Yu wrote:
>> >>Include rte_memory.h for lib files that use __rte_ca
validated by parole).
For good practice, it?s better to explicitly include rte_memory.h to avoid
the problem.
Thanks,
Jia
On 12/9/14, 12:53 AM, "Olivier MATZ" wrote:
>Hi Neil,
>
>On 12/08/2014 04:04 PM, Neil Horman wrote:
>> On Fri, Nov 07, 2014 at 09:28:09AM -0800,
2014-11-07 09:28, Jia Yu:
>> Include rte_memory.h for lib files that use __rte_cache_aligned
>> attribute.
>
>Please could you explain what was the error?
>As I suspect it's a fix, it would be clearer to start your title with
>"fix".
>
>Thanks
>--
>Thomas
Thanks, Thomas.
The two patches are minor fixes. No new API is introduced. I will revise
the description.
Thanks,
Jia
On 11/10/14, 1:40 AM, "Thomas Monjalon" wrote:
>Hi Jia,
>
>2014-11-07 09:31, Jia Yu:
>> This patch series include a fix and an improvement
Adding this check is to avoid breakage from future data structure changes.
Signed-off-by: Jia Yu
---
lib/librte_kni/rte_kni.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c
index 31ecb33..f5c449c 100644
--- a/lib
n if some slave devices are unused (i.e. linked down, standby).
Signed-off-by: Jia Yu
---
lib/librte_pmd_bond/rte_eth_bond_api.c | 16
lib/librte_pmd_bond/rte_eth_bond_pmd.c | 5 +
lib/librte_pmd_bond/rte_eth_bond_private.h | 2 ++
3 files changed, 23 insertions(+)
d
-off-by: Jia Yu
---
lib/librte_ether/rte_ethdev.c | 7 ---
lib/librte_ether/rte_ethdev.h | 4 +++-
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 6c01b02..4ec9ca6 100644
--- a/lib/librte_ether/rte_ethdev.c
link status from hardware
register at device start time.
Issue:
Change-Id: Ib57a1c9114f922485c7b0f4338bfe7b3d3f87d65
Signed-off-by: Jia Yu
---
lib/librte_ether/rte_ethdev.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index
This patch series include a fix and an improvement to rte_ethdev lib.
Jia Yu (2):
rte_ethdev: update link status (speed, duplex, link_up) after
rte_eth_dev_start
rte_ethdev: add return status for rte_eth_stats_get
lib/librte_ether/rte_ethdev.c | 11 ---
lib/librte_ether
Include rte_memory.h for lib files that use __rte_cache_aligned
attribute.
Signed-off-by: Jia Yu
---
lib/librte_distributor/rte_distributor.c| 1 +
lib/librte_eal/common/include/rte_malloc_heap.h | 1 +
lib/librte_ip_frag/rte_ip_frag.h| 1 +
lib/librte_malloc
According to rss_hf definition in rte_eth_rss_conf, it shall be uint64 type.
Using uint16 will get truncated value, and cause incorrect output. This
fix corrected this issue.
Signed-off-by: Jia Yu
---
app/test-pmd/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app
22 matches
Mail list logo
