Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Jeff Shaw
On Wed, Mar 27, 2019 at 12:00:49AM +0100, Thomas Monjalon wrote: > 26/03/2019 23:34, Jeff Shaw: > > On Tue, Mar 26, 2019 at 11:23:50PM +0100, Thomas Monjalon wrote: > > > 26/03/2019 22:54, Jeff Shaw: > > > > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Jeff Shaw
On Tue, Mar 26, 2019 at 11:23:50PM +0100, Thomas Monjalon wrote: > 26/03/2019 22:54, Jeff Shaw: > > On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > > > 26/03/2019 22:14, Jeff Shaw: > > > > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalo

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Jeff Shaw
On Tue, Mar 26, 2019 at 10:47:54PM +0100, Thomas Monjalon wrote: > 26/03/2019 22:14, Jeff Shaw: > > On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > > > Even better would be to get it as a dependency outside of DPDK. > > > Where this code come from?

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-26 Thread Jeff Shaw
On Tue, Mar 26, 2019 at 09:52:57PM +0100, Thomas Monjalon wrote: > 26/03/2019 20:06, Stephen Hemminger: > > On Mon, 25 Mar 2019 23:02:34 -0700 > > Anand Rawat wrote: > > > > > +/*- > > > + * SPDX-License-Identifier: BSD-3-Clause > > > + * > > > + * Copyright (c) 1991, 1993 > > > + * The Reg

[dpdk-dev] [PATCH v3] eal: simplify RTE_PMD_DEBUG_TRACE

2018-12-21 Thread Jeff Shaw
: Jeff Shaw --- V3: - Fix checkpatch error: ERROR:SPACING: space required before the open parenthesis '(' V2: - Changed named variable "args..." to use "..." with ##__VA_LIST__. Pasting is necessary to support case where only the format string, with no a

[dpdk-dev] [PATCH v2] eal: simplify RTE_PMD_DEBUG_TRACE

2018-12-21 Thread Jeff Shaw
: Jeff Shaw --- V2: - Changed named variable "args..." to use "..." with ##__VA_LIST__. Pasting is necessary to support case where only the format string, with no arguments, is passed. --- lib/librte_eal/common/include/rte_dev.h | 44 +++-

Re: [dpdk-dev] [PATCH] eal: simplify RTE_PMD_DEBUG_TRACE

2018-12-14 Thread Jeff Shaw
_PRIMARY macros. > > Reported-by: Jeff Shaw > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/common/include/rte_dev.h | 43 ++--- > 1 file changed, 3 insertions(+), 40 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_dev.h >

[dpdk-dev] [PATCH v2] eal: remove variable length array

2018-12-14 Thread Jeff Shaw
vla] This commit removes the variable length array from the PMD debug trace function by allocating memory dynamically on the stack using alloca(). Signed-off-by: Jeff Shaw --- V2: - Reference C99 in commit message instead of C11. - Remove unnecessary cast of alloca() returning void *. --- lib/

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Jeff Shaw
On Fri, Dec 14, 2018 at 10:59:28AM -0800, Jeff Shaw wrote: > On Fri, Dec 14, 2018 at 10:36:03AM -0800, Stephen Hemminger wrote: > > On Fri, 14 Dec 2018 08:38:27 -0800 > > Jeff Shaw wrote: > > > > > Compilers that do not support the C11 standard, or do not implement

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Jeff Shaw
On Fri, Dec 14, 2018 at 07:36:38PM +0100, Mattias Rönnblom wrote: > On 2018-12-14 17:38, Jeff Shaw wrote: > > Compilers that do not support the C11 standard, or do not implement > > gcc extensions, may not support variable length arrays. > > > > VLAs are a C99 thing

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Jeff Shaw
On Fri, Dec 14, 2018 at 10:36:03AM -0800, Stephen Hemminger wrote: > On Fri, 14 Dec 2018 08:38:27 -0800 > Jeff Shaw wrote: > > > Compilers that do not support the C11 standard, or do not implement > > gcc extensions, may not support variable length arrays. > > > &

[dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Jeff Shaw
vla] This commit removes the variable length array from the PMD debug trace function by allocating memory dynamically on the stack using alloca(). Signed-off-by: Jeff Shaw --- lib/librte_eal/common/include/rte_dev.h | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff -

[dpdk-dev] [PATCH] eal: remove unnecessary dirent.h include

2018-12-14 Thread Jeff Shaw
Prior to this patch, the two affected .c files include unnecessarily. This commit removes the include lines. Signed-off-by: Jeff Shaw --- lib/librte_eal/common/eal_common_lcore.c | 1 - lib/librte_eal/common/rte_service.c | 1 - 2 files changed, 2 deletions(-) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH] hash: fix __rte_hash_lookup_bulk return value

2018-12-07 Thread Jeff Shaw
rning void [-Wpedantic] Fixes: 9eca8bd7a61c ("hash: separate lock-free and r/w lock lookup") Signed-off-by: Jeff Shaw --- lib/librte_hash/rte_cuckoo_hash.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte

[dpdk-dev] [PATCH v4 2/2] i40e: Enable bad checksum flags in i40e vPMD

2016-10-06 Thread Jeff Shaw
From: Damjan Marion Decode the checksum flags from the rx descriptor, setting the appropriate bit in the mbuf ol_flags field when the flag indicates a bad checksum. Signed-off-by: Damjan Marion Signed-off-by: Jeff Shaw --- drivers/net/i40e/i40e_rxtx_vec.c | 48

[dpdk-dev] [PATCH v4 1/2] i40e: Add packet_type metadata in the i40e vPMD

2016-10-06 Thread Jeff Shaw
From: Damjan Marion The ptype is decoded from the rx descriptor and stored in the packet type field in the mbuf using the same function as the non-vector driver. Signed-off-by: Damjan Marion Signed-off-by: Jeff Shaw Acked-by: Qi Zhang --- Changes in v2: - Add missing reference to

[dpdk-dev] [PATCH v3 1/2] i40e: Add packet_type metadata in the i40e vPMD

2016-10-06 Thread Jeff Shaw
From: Damjan Marion The ptype is decoded from the rx descriptor and stored in the packet type field in the mbuf using the same function as the non-vector driver. Signed-off-by: Damjan Marion Signed-off-by: Jeff Shaw Acked-by: Qi Zhang --- Changes in v2: - Add missing reference to

[dpdk-dev] [PATCH v2 2/2] i40e: Enable bad checksum flags in i40e vPMD

2016-10-05 Thread Jeff Shaw
From: Damjan Marion Decode the checksum flags from the rx descriptor, setting the appropriate bit in the mbuf ol_flags field when the flag indicates a bad checksum. Signed-off-by: Damjan Marion Signed-off-by: Jeff Shaw --- drivers/net/i40e/i40e_rxtx_vec.c | 48

[dpdk-dev] [PATCH v2 1/2] i40e: Add packet_type metadata in the i40e vPMD

2016-10-05 Thread Jeff Shaw
From: Damjan Marion The ptype is decoded from the rx descriptor and stored in the packet type field in the mbuf using the same function as the non-vector driver. Signed-off-by: Damjan Marion Signed-off-by: Jeff Shaw Acked-by: Qi Zhang --- Changes in v2: - Add missing reference to

[dpdk-dev] [PATCH v2 2/2] i40e: Enable bad checksum flags in i40e vPMD

2016-10-05 Thread Jeff Shaw
_flags field when the flag indicates a bad checksum. > > > > Signed-off-by: Damjan Marion > > Signed-off-by: Jeff Shaw > > --- > > drivers/net/i40e/i40e_rxtx_vec.c | 48 > > +++--- > > -- > > 1 file changed, 28 inse

[dpdk-dev] [PATCH 0/2] Add ptype and xsum handling in i40e rx vpmd

2016-09-01 Thread Jeff Shaw
On Fri, Jul 15, 2016 at 10:26:23PM +0200, Thomas Monjalon wrote: > 2016-07-14 09:59, Jeff Shaw: > > Our testing suggests minimal (in some cases zero) impact to core-bound > > forwarding throughput as measured by testpmd. Throughput increase is > > observed in l3fwd as now the

[dpdk-dev] [PATCH 2/2] i40e: Enable bad checksum flags in i40e vPMD

2016-07-14 Thread Jeff Shaw
From: Damjan Marion Decode the checksum flags from the rx descriptor, setting the appropriate bit in the mbuf ol_flags field when the flag indicates a bad checksum. Signed-off-by: Damjan Marion Signed-off-by: Jeff Shaw --- drivers/net/i40e/i40e_rxtx_vec.c | 48

[dpdk-dev] [PATCH 1/2] i40e: Add packet_type metadata in the i40e vPMD

2016-07-14 Thread Jeff Shaw
From: Damjan Marion The ptype is decoded from the rx descriptor and stored in the packet type field in the mbuf using the same function as the non-vector driver. Signed-off-by: Damjan Marion Signed-off-by: Jeff Shaw --- drivers/net/i40e/i40e_rxtx.c | 566

[dpdk-dev] [PATCH 0/2] Add ptype and xsum handling in i40e rx vpmd

2016-07-14 Thread Jeff Shaw
Our testing suggests minimal (in some cases zero) impact to core-bound forwarding throughput as measured by testpmd. Throughput increase is observed in l3fwd as now the vpmd can be used with hw_ip_checksum enabled and without needing '--parse-ptype'. The benefits to applications using this functio

[dpdk-dev] [PATCH] doc: fix mailing list address typo.

2016-07-13 Thread Jeff Shaw
The correct mailing list dev at dpdk.org, not dev at dpkg.org. Signed-off-by: Jeff Shaw --- doc/guides/contributing/patches.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst index 06af91d..16a21a5

[dpdk-dev] [PATCH] tools: Fix typo in dpdk_nic_bind.py script.

2016-02-08 Thread Jeff Shaw
We should call sys.exit(), not divide sys by exit(). Signed-off-by: Jeff Shaw --- tools/dpdk_nic_bind.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py index f02454e..a1923c5 100755 --- a/tools/dpdk_nic_bind.py +++ b/tools

[dpdk-dev] fm10k_rxtx.c does not compile

2015-02-18 Thread Jeff Shaw
On Wed, Feb 18, 2015 at 05:29:02PM +, Wiles, Keith wrote: > I believe Jeff @ Intel is going to submit a patch soon. I sent patches to fix these errors. Thanks, Jeff

[dpdk-dev] [PATCH] fm10k: fix clang unused function error

2015-02-18 Thread Jeff Shaw
This commit fixes the following error which was reported when compiling with clang by moving the function inside an RTE_LIBRTE_FM10K_DEBUG_RX ifdef block. error: unused function 'dump_rxd' Signed-off-by: Jeff Shaw --- lib/librte_pmd_fm10k/fm10k_rxtx.c | 5 ++--- 1 file changed, 2

[dpdk-dev] [PATCH] fm10k: fix clang warning flags

2015-02-18 Thread Jeff Shaw
This commit fixes the following error which was reported when compiling with clang by removing the option. error: unknown warning option '-Wno-unused-but-set-variable' Signed-off-by: Jeff Shaw --- lib/librte_pmd_fm10k/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[dpdk-dev] [PATCH v5 08/17] fm10k: add RX/TX single queue start/stop function

2015-02-13 Thread Jeff Shaw
Hi David, thanks for the review. On Fri, Feb 13, 2015 at 12:31:16PM +0100, David Marchand wrote: > Hello, > > On Fri, Feb 13, 2015 at 9:19 AM, Chen Jing D(Mark) > wrote: > > [snip] > > +/* > > + * Verify Rx packet buffer alignment is valid. > > + * > > + * Hardware requires specific alignment

[dpdk-dev] [PATCH v4 12/15] fm10k: Add scatter receive function

2015-02-11 Thread Jeff Shaw
On Wed, Feb 11, 2015 at 09:31:35AM +0800, Chen Jing D(Mark) wrote: > > +uint16_t > +fm10k_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > + uint16_t nb_pkts) > +{ > + struct rte_mbuf *mbuf; > + union fm10k_rx_desc desc; > + struct fm10k_rx_

[dpdk-dev] [PATCH v4 10/15] fm10k: add receive and tranmit function

2015-02-11 Thread Jeff Shaw
On Wed, Feb 11, 2015 at 09:31:33AM +0800, Chen Jing D(Mark) wrote: > +uint16_t > +fm10k_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > + uint16_t nb_pkts) > +{ > + struct rte_mbuf *mbuf; > + union fm10k_rx_desc desc; > + struct fm10k_rx_queue *q = rx_queue; > + uint16_t

[dpdk-dev] [PATCH 00/18] lib/librte_pmd_fm10k : fm10k pmd driver

2015-01-30 Thread Jeff Shaw
etween PF/VF and PF/Switch Manager. > > 5. Receive Side Scaling (RSS) for PF/VF. > > 6. Scatter receive function for PF/VF. > > 7. reta update/query for PF/VF. > > 8. VLAN filter set for PF. > > 9. Link status query for PF/VF. > > > > Jeff Shaw (18):

[dpdk-dev] Intel 82599 tx_conf setting

2014-11-05 Thread Jeff Shaw
On Wed, Nov 05, 2014 at 09:43:43AM +0900, Gyumin wrote: > Hi > > I've read the Intel 82599 official manual and I found that optimal > PTHRESH is the tx descriptor buffer size - N (N is CPU cache line > divided by 16). This is sometimes true, but not always. I believe you are referring to secti

[dpdk-dev] ixgbe_recv_pkts, ixgbe_recv_pkts_bulk_alloc. what is difference?

2014-10-22 Thread Jeff Shaw
On Wed, Oct 22, 2014 at 11:18:17PM +0900, GyuminHwang wrote: > Hi all > > I have several questions about ixgbe_rxtx.c especially Tx and Rx function. > What is the difference between ixgbe_recv_pkts and > ixgbe_recv_pkts_bulk_alloc? I already know the earlier function is > non-bulk function and the

[dpdk-dev] DPDK Demos at IDF conference using DDIO

2014-09-25 Thread Jeff Shaw
On Thu, Sep 25, 2014 at 03:19:31PM +, Anjali Kulkarni wrote: > Hi, > > There were a few DPDK demos at IDF, and from one of them I gathered that you > can use DDIO to enhance performance by using certain lookup APIs in DPDK. Can > someone shed light on this? Is DDIO enabled by default? It is

[dpdk-dev] TCP/IP stack for DPDK

2014-09-09 Thread Jeff Shaw
On Tue, Sep 09, 2014 at 08:49:44AM +0800, zimeiw wrote: > hi, > > > I have porting major FreeBSD tcp/ip stack to dpdk. new tcp/ip stack is based > on dpdk rte_mbuf, rte_ring, rte_memory and rte_table. it is faster to > forwarding packets. > > Below feature are ready: > > Netdp initialize > E

[dpdk-dev] Error while inserting module /build/kmod/igb_uio.ko

2014-07-10 Thread Jeff Shaw
On Thu, Jul 10, 2014 at 09:53:20PM +, Daniel, Christopher wrote: > 3) Having an issue with > # insmod build/kmod/igb_uio.ko > > I am getting > > insmod: error inserting './build/kmod/igb_uio.ko': -1 Unknown symbol in module > > dmesg: > igb_uio: Unknown symbol __fentry__ (err 0) >

[dpdk-dev] Ability to/impact of running with smaller page sizes

2014-06-30 Thread Jeff Shaw
Hi Matt, On Mon, Jun 30, 2014 at 05:43:39PM -0500, Matt Laswell wrote: > Hey Folks, > > In my application, I'm seeing some design considerations in a project I'm > working on that push me towards the use of smaller memory page sizes. I'm > curious - is it possible in practical terms to run DPDK