On Thu, Nov 28, 2024 at 12:32 PM Gowrishankar Muthukrishnan
wrote:
>
> Hi Jason,
> > Hello:
> >
> > On Fri, Nov 22, 2024 at 2:03 AM Gowrishankar Muthukrishnan
> > wrote:
> > >
> > > Hi,
> > > We are adding support for vDPA user backend for virtio-crypto PMD in DPDK.
> >
> > I wonder what kind of
Hello:
On Fri, Nov 22, 2024 at 2:03 AM Gowrishankar Muthukrishnan
wrote:
>
> Hi,
> We are adding support for vDPA user backend for virtio-crypto PMD in DPDK.
I wonder what kind of vDPA device you are using? Is there a marvell
specific vDPA or just a standard virtio-pci device via vp-vdpa.
Thank
On Fri, Apr 14, 2023 at 10:25 PM Ferruh Yigit wrote:
>
> On 4/14/2023 1:06 PM, Maxime Coquelin wrote:
> >
> >
> > On 4/14/23 12:48, Ferruh Yigit wrote:
> >> On 4/13/2023 8:59 AM, Maxime Coquelin wrote:
> >>> Hi,
> >>>
> >>> On 4/13/23 09:08, Xia, Chenbo wrote:
> > -Original Message-
>
On 2020/11/24 下午8:45, Maxime Coquelin wrote:
This patch fixes an overhead met with mlx5-vdpa Kernel
driver, where for every page in the mapped area, all the
memory tables gets updated. For example, with 2MB hugepages,
a single IOTLB_UPDATE for a 1GB region causes 512 memory
updates on mlx5-vdpa
On 2020/6/26 上午5:27, Vincent Li wrote:
Hi,
I found Qemu start to support virtio-net RX RSS:
List: qemu-devel
Subject:[PULL V2 02/33] virtio-net: implement RX RSS processing
From: Jason Wang
Date: 2020-06-18 13:21:17
Message-ID: 1592486508-6135-3-git-send-email-jasowang
On 2020/5/18 上午11:09, Wang, Xiao W wrote:
Hi,
Comments inline.
Best Regards,
Xiao
-Original Message-
From: Jason Wang
Sent: Friday, May 15, 2020 6:09 PM
To: Wang, Xiao W; Maxime Coquelin
; Ye, Xiaolong;
shah...@mellanox.com;ma...@mellanox.com;amore...@redhat.com;
viachesl
On 2020/5/15 下午5:42, Wang, Xiao W wrote:
Hi,
Best Regards,
Xiao
> -Original Message-
> From: Jason Wang
> Sent: Friday, May 15, 2020 5:09 PM
> To: Maxime Coquelin ; Ye, Xiaolong
> ; shah...@mellanox.com; ma...@mellanox.com;
> amore...@redhat.com; Wang, Xi
On 2020/5/15 下午5:42, Wang, Xiao W wrote:
Hi,
Best Regards,
Xiao
> -Original Message-
> From: Jason Wang
> Sent: Friday, May 15, 2020 5:09 PM
> To: Maxime Coquelin ; Ye, Xiaolong
> ; shah...@mellanox.com; ma...@mellanox.com;
> amore...@redhat.com; Wang, Xi
On 2020/5/14 下午4:02, Maxime Coquelin wrote:
This patch adds support to enabling and disabling
vrings on a per-vring granularity.
Signed-off-by: Maxime Coquelin
A question here, I see in qemu peer_attach() may try to generate
VHOST_USER_SET_VRING_ENABLE, but just from the name I think it s
On 2020/3/7 上午12:24, Alex Williamson wrote:
On Fri, 6 Mar 2020 11:35:21 +0800
Jason Wang wrote:
On 2020/3/6 上午1:14, Alex Williamson wrote:
On Tue, 25 Feb 2020 14:09:07 +0800
Jason Wang wrote:
On 2020/2/25 上午10:33, Tian, Kevin wrote:
From: Alex Williamson
Sent: Thursday, February 20
On 2020/3/6 上午1:14, Alex Williamson wrote:
On Tue, 25 Feb 2020 14:09:07 +0800
Jason Wang wrote:
On 2020/2/25 上午10:33, Tian, Kevin wrote:
From: Alex Williamson
Sent: Thursday, February 20, 2020 2:54 AM
Changes since v1 are primarily to patch 3/7 where the commit log is
rewritten, along
On 2020/2/25 上午10:33, Tian, Kevin wrote:
From: Alex Williamson
Sent: Thursday, February 20, 2020 2:54 AM
Changes since v1 are primarily to patch 3/7 where the commit log is
rewritten, along with option parsing and failure logging based on
upstream discussions. The primary user visible differe
On 2019/9/3 下午4:49, Tiwei Bie wrote:
On Tue, Sep 03, 2019 at 09:40:25AM +0200, Maxime Coquelin wrote:
On 9/3/19 7:30 AM, Tiwei Bie wrote:
On Thu, Aug 29, 2019 at 09:59:55AM +0200, Maxime Coquelin wrote:
In order to support multi-queue, we need to implement the control
path. The problem is th
On 2019/7/11 下午5:49, Liu, Yong wrote:
-Original Message-
From: Jason Wang [mailto:jasow...@redhat.com]
Sent: Thursday, July 11, 2019 12:11 PM
To: Liu, Yong ; Bie, Tiwei ;
maxime.coque...@redhat.com; dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast
On 2019/7/11 下午5:37, Liu, Yong wrote:
-Original Message-
From: Jason Wang [mailto:jasow...@redhat.com]
Sent: Thursday, July 11, 2019 4:35 PM
To: Liu, Yong ; Bie, Tiwei ;
maxime.coque...@redhat.com; dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast
On 2019/7/9 上午1:13, Marvin Liu wrote:
In fast enqueue function, will first check whether descriptors are
cache aligned. Fast enqueue function will check prerequisites in the
beginning. Fast enqueue function do not support chained mbufs, normal
function will handle that.
Signed-off-by: Marvin L
On 2019/7/10 下午3:30, Liu, Yong wrote:
-Original Message-
From: Jason Wang [mailto:jasow...@redhat.com]
Sent: Wednesday, July 10, 2019 12:28 PM
To: Liu, Yong ; Bie, Tiwei ;
maxime.coque...@redhat.com; dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast
On 2019/7/9 上午1:13, Marvin Liu wrote:
In fast enqueue function, will first check whether descriptors are
cache aligned. Fast enqueue function will check prerequisites in the
beginning. Fast enqueue function do not support chained mbufs, normal
function will handle that.
Signed-off-by: Marvin L
On 2019/3/12 下午5:42, Thanneeru Srinivasulu wrote:
Thanks Bruce..
On Tue, Mar 12, 2019 at 3:08 PM Bruce Richardson
wrote:
On Tue, Mar 12, 2019 at 10:57:55AM +0530, Thanneeru Srinivasulu wrote:
Hi Everyone.
I did attached pice to Guest VM using vfio-pci with qemu command, and then
tried bin
On 2019/2/25 下午3:51, Changpeng Liu wrote:
This patch adds new vhost user messages GET_CONFIG and SET_CONFIG
used to get/set virtio device's PCI configuration space.
I think it's better to describe the reason for doing this. I believe
vhost is transport independent.
Thanks
Signed-off-b
On 2019/2/19 下午6:59, Tiwei Bie wrote:
Below is a quick (unofficial) performance test (macfwd loop, 64B)
for the packed ring optimizations in this series on an Intel(R)
Xeon(R) Gold 6140 CPU @ 2.30GHz platform:
w/o this series:
packed ring normal/in-order: ~10.4 Mpps
w/ this series:
packed ri
On 2018/12/6 下午8:48, Ilya Maximets wrote:
On 06.12.2018 7:17, Jason Wang wrote:
On 2018/12/5 下午7:30, Ilya Maximets wrote:
On 05.12.2018 12:49, Maxime Coquelin wrote:
A read barrier is required to ensure the ordering between
available index and the descriptor reads is enforced.
Fixes
sta...@dpdk.org
Reported-by: Jason Wang
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/virtio_net.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index f11ebb54f..68b72e7a5 100644
--- a/lib/librte_vhost/virtio_
.@dpdk.org
Reported-by: Jason Wang
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/virtio_net.c | 12
1 file changed, 12 insertions(+)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 5e1a1a727..f11ebb54f 100644
--- a/lib/librte_vhost/virtio_n
evice_event->flags = VRING_EVENT_F_DISABLE;
+ return;
+ }
flags = VRING_EVENT_F_ENABLE;
if (dev->features & (1ULL << VIRTIO_RING_F_EVENT_IDX)) {
Acked-by: Jason Wang
On 2018年10月11日 21:06, Tiwei Bie wrote:
The notification can't be disabled in packed ring when
application tries to disable notification, because the
device event flags field is overwritten by an unexpected
value. This patch fixes this issue.
Fixes: b1cce26af1dc ("vhost: add notification for p
On 2018年09月12日 12:27, Tiwei Bie wrote:
On Wed, Sep 12, 2018 at 11:47:20AM +0800, Jason Wang wrote:
Hi:
Try to launch virtio_user + vhost_kernel with: testpmd
--vdev=virtio_user0,path=/dev/vhost-net -- -i
It seems we get a deadlock on
rte_rwlock_read_lock(&mcfg->memory_hotplug_loc
On 2018年09月12日 07:14, Stephen Hemminger wrote:
On Tue, 11 Sep 2018 19:07:47 -0300
Dan Gora wrote:
On Tue, Sep 11, 2018 at 6:52 PM, Stephen Hemminger
wrote:
The carrier state has no meaning when device is down, at least for physical
devices. Because often the PHY is powered off when the de
Hi:
Try to launch virtio_user + vhost_kernel with: testpmd
--vdev=virtio_user0,path=/dev/vhost-net -- -i
It seems we get a deadlock on
rte_rwlock_read_lock(&mcfg->memory_hotplug_lock)
calltrace:
Thread 1 "testpmd" received signal SIGINT, Interrupt.
rte_memseg_contig_walk (func=func@entry=0
On 2018年07月02日 16:16, Maxime Coquelin wrote:
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/vhost.c | 73
lib/librte_vhost/vhost.h | 71 ++
lib/librte_vhost/vhost_user.c| 24 +
On 2018年07月02日 16:16, Maxime Coquelin wrote:
+static inline int
+vhost_enable_notify_split(struct vhost_virtqueue *vq, int enable)
+{
+ if (enable)
+ vq->used->flags &= ~VRING_USED_F_NO_NOTIFY;
+ else
+ vq->used->flags |= VRING_USED_F_NO_NOTIFY;
+
+
On 2018年03月16日 23:21, Jens Freimann wrote:
This implements the transmit path for devices with
support for Virtio 1.1.
Add the feature bit for Virtio 1.1 and enable code to
add buffers to vring and mark descriptors as available.
This is based on a patch by Yuanhan Liu.
Signed-off-by: Jens Fre
On 2018年03月16日 23:21, Jens Freimann wrote:
From: Yuanhan Liu
Implement the receive part here. No support for mergeable buffers yet.
Signed-off-by: Jens Freimann
Signed-off-by: Yuanhan Liu
---
drivers/net/virtio/virtio_ethdev.c | 5 +-
drivers/net/virtio/virtio_ethdev.h | 2 +
drive
On 2018年03月01日 20:56, Zhang, Qi Z wrote:
BTW, performance test shows our PMD can reach 94%~98% of the
orignal benchmark when share memory is enabled.
Hi:
Looks like zero copy is not used in this series. Any plan to support that?
Zero copy is enabled in patch 5, if a mempool passed check_memp
On 2018年02月28日 22:53, Tan, Jianfeng wrote:
Hi Jason,
On 2/28/2018 10:10 PM, Jason Wang wrote:
On 2018年02月24日 17:35, Jianfeng Tan wrote:
Mostly likely, we will make UFO as a kind of GSO engine.
For short term, we can just call APIs in librte_ip_frag to fragment.
To test:
1. start
On 2018年03月01日 12:20, Zhang, Qi Z wrote:
+Magnus, since a typo in my first batch in email address.
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z
Sent: Thursday, March 1, 2018 12:19 PM
To: Jason Wang;dev@dpdk.org
Cc:magnus.karls...@intei.com
On 2018年02月27日 17:32, Qi Zhang wrote:
The RFC patches add a new PMD driver for AF_XDP which is a proposed
faster version of AF_PACKET interface in Linux, see below link for
detail AF_XDP introduction:
https://fosdem.org/2018/schedule/event/af_xdp/
https://lwn.net/Articles/745934/
This patchset
On 2018年02月24日 17:35, Jianfeng Tan wrote:
Mostly likely, we will make UFO as a kind of GSO engine.
For short term, we can just call APIs in librte_ip_frag to fragment.
To test:
1. start testpmd with two vhost port.
$ set fwd csum
$ start
2. start vm0 connected to vhost0;
$ ifconfig xx
On 2018年01月29日 22:11, Jens Freimann wrote:
+/* Cleanup from completed transmits. */
+static void
+virtio_xmit_cleanup(struct virtqueue *vq)
+{
+ uint16_t idx;
+ uint16_t size = vq->vq_nentries;
+ struct vring_desc_1_1 *desc = vq->vq_ring.desc_1_1;
+
+ idx = vq->vq_used_c
On 2018年02月06日 21:58, Jens Freimann wrote:
On Tue, Feb 06, 2018 at 02:20:02PM +0800, Jason Wang wrote:
On 2018???01???29??? 22:11, Jens Freimann wrote:
May I ask how do you test the patch? I believe you need some basic
packed ring support in both qemu and vhost-user protocol.
Yes, I have
On 2018年01月29日 22:11, Jens Freimann wrote:
This is a basic implementation of packed virtqueues as specified in the
Virtio 1.1 draft. A compiled version of the current draft is available
at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at
https://github.com/oasis-tcs/virtio-docs/blob/
On 2018年01月10日 23:34, Ophir Munk wrote:
I agree that classifying directly through eBPF using socket filter is easier
than building a set of rules in TC, however there are more concerns that
justify using eBPF with TC.
1. An RSS rule can come in the middle of non-RSS rules. It seems natural to
On 2018年01月10日 15:06, Ophir Munk wrote:
The patches of TAP RSS eBPF follow the RFC on this issue
https://dpdk.org/dev/patchwork/patch/31781/
v3 changes with respect to v2
=
* Add support for IPv6 RSS in BPF program
* Bug fixes
* Updated compatibility to kernel versi
On 2017年01月16日 22:46, Jianfeng Tan wrote:
This patch implements interrupt enable/disable functions for each
Rx queue. And we rely on flags of avail queue as the hint for virtio
device to interrupt virtio driver or not.
Signed-off-by: Jianfeng Tan
---
drivers/net/virtio/virtio_ethdev.c | 22
On 2017年01月12日 17:40, Tan, Jianfeng wrote:
Hi Jason,
Ok, just want to show its advantages. It can be added on top.
And two more suggestions:
- better to split tap support out of vhost file
Good suggestion! Will do that in next version.
- kernel support more than 8 queues on recent kernel,
On 2017年01月11日 11:13, Tan, Jianfeng wrote:
On 1/11/2017 10:42 AM, Jason Wang wrote:
On 2017年01月10日 14:11, Tan, Jianfeng wrote:
Hi Jason,
On 1/9/2017 12:39 PM, Jason Wang wrote:
On 2016年12月23日 15:14, Jianfeng Tan wrote:
This patch add support vhost kernel as the backend for
On 2017年01月11日 10:30, Tan, Jianfeng wrote:
Hi Jason,
On 1/9/2017 12:39 PM, Jason Wang wrote:
+if (!enable) {
+if (dev->tapfds[pair_idx]) {
+close(dev->tapfds[pair_idx]);
+dev->tapfds[pair_idx] = -1;
+}
+return vhost_kernel_se
On 2017年01月10日 14:11, Tan, Jianfeng wrote:
Hi Jason,
On 1/9/2017 12:39 PM, Jason Wang wrote:
On 2016年12月23日 15:14, Jianfeng Tan wrote:
This patch add support vhost kernel as the backend for virtio_user.
Three main hook functions are added:
- vhost_kernel_setup() to open char device
On 2017年01月04日 15:22, Tan, Jianfeng wrote:
Sorry, I forget to reply this comment.
On 12/26/2016 3:44 PM, Yuanhan Liu wrote:
[...]
+
+/* Does not work when VIRTIO_F_IOMMU_PLATFORM now, why? */
Because this feature need the vhost IOTLB support from the device
emulation. Patches for QEMU
On 2016年12月23日 15:14, Jianfeng Tan wrote:
This patch add support vhost kernel as the backend for virtio_user.
Three main hook functions are added:
- vhost_kernel_setup() to open char device, each vq pair needs one
vhostfd;
- vhost_kernel_ioctl() to communicate control messages with v
On 2016?10?11? 12:14, Yuanhan Liu wrote:
> On Fri, Oct 07, 2016 at 07:24:44AM +0300, Michael S. Tsirkin wrote:
>> On Wed, Sep 28, 2016 at 04:25:12PM +0800, Jason Wang wrote:
>>> Negotiate VIRTIO_F_IOMMU_PLATFORM to have IOMMU support.
>>>
>>> Signed-off-by:
On 2016?10?07? 12:24, Michael S. Tsirkin wrote:
> On Wed, Sep 28, 2016 at 04:25:12PM +0800, Jason Wang wrote:
>> Negotiate VIRTIO_F_IOMMU_PLATFORM to have IOMMU support.
>>
>> Signed-off-by: Jason Wang
>> ---
>> Changes from v1:
>> - remove unnecessary NE
Negotiate VIRTIO_F_IOMMU_PLATFORM to have IOMMU support.
Signed-off-by: Jason Wang
---
Changes from v1:
- remove unnecessary NEED_MAPPING flag
---
drivers/net/virtio/virtio_ethdev.h | 3 ++-
drivers/net/virtio/virtio_pci.h| 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git
Add modern device id and rename VIRTIO_PCI_DEVICEID_MIN to
VIRTIO_PCI_LEGACY_DEVICEID_NET. While at it, remove unused macros too.
Signed-off-by: Jason Wang
---
drivers/net/virtio/virtio_ethdev.c | 3 ++-
drivers/net/virtio/virtio_pci.h| 4 ++--
2 files changed, 4 insertions(+), 3 deletions
Seems something went wrong :(
>
> --yliu
>
> On Mon, Sep 05, 2016 at 03:16:26PM +0800, Yuanhan Liu wrote:
>> On Fri, Sep 02, 2016 at 02:37:00PM +0800, Jason Wang wrote:
>>> Virtio pmd doesn't support VFIO in the past since devices bypass IOMMU
>>> co
On 2016?09?02? 20:57, Thomas Monjalon wrote:
> 2016-09-02 14:36, Jason Wang:
>> Spec said "The PCI Device ID is calculated by adding 0x1040 to the
>> Virtio Device ID". So this patch makes pmd can recognize modern virtio
>> net id.
> Please could you descri
in <mailto:mst at redhat.com>> wrote:
>
> On Fri, Sep 02, 2016 at 03:04:56PM +0200, Thomas Monjalon wrote:
> > 2016-09-02 14:37, Jason Wang:
> > > Virtio pmd doesn't support VFIO in the past since devices
> bypass IOMMU
> > > c
On 2016?09?02? 21:04, Thomas Monjalon wrote:
> 2016-09-02 14:37, Jason Wang:
>> Virtio pmd doesn't support VFIO in the past since devices bypass IOMMU
>> completely. But recently, the work of making virtio device work with
>> IOMMU is near to complete.
> Good news
On 2016?09?02? 21:04, Thomas Monjalon wrote:
> 2016-09-02 14:37, Jason Wang:
>> Virtio pmd doesn't support VFIO in the past since devices bypass IOMMU
>> completely. But recently, the work of making virtio device work with
>> IOMMU is near to complete.
> Good news
ature VIRTIO_F_IOMMU_PLATFORM
Signed-off-by: Jason Wang
---
drivers/net/virtio/virtio_ethdev.c | 2 +-
drivers/net/virtio/virtio_ethdev.h | 3 ++-
drivers/net/virtio/virtio_pci.h| 3 ++-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/v
Spec said "The PCI Device ID is calculated by adding 0x1040 to the
Virtio Device ID". So this patch makes pmd can recognize modern virtio
net id.
Signed-off-by: Jason Wang
---
drivers/net/virtio/virtio_ethdev.c | 1 +
drivers/net/virtio/virtio_pci.h| 1 +
2 files changed, 2
On 01/14/2016 09:28 PM, Santosh Shukla wrote:
> So far virtio handle rw access for uio / ioport interface, This patch to
> extend
> the support for vfio interface. For that introducing private struct
> virtio_vfio_dev{
> - is_vfio
> - pci_dev
> };
> Signed-off-by: Santosh Shukl
On 11/17/2015 04:23 PM, Michael S. Tsirkin wrote:
> On Mon, Nov 16, 2015 at 02:20:57PM -0800, Flavio Leitner wrote:
>> > On Wed, Oct 28, 2015 at 11:12:25PM +0200, Michael S. Tsirkin wrote:
>>> > > On Wed, Oct 28, 2015 at 06:30:41PM -0200, Flavio Leitner wrote:
> > > On Sat, Oct 24, 2015 at 0
On 06/12/2015 05:35 PM, Zhou, Tianlin wrote:
> Hi Changchun,
>
> Thanks for your response.
> Please see my embedded comments.
>
> What kind of vhost in your test? Linux vhost or dpdk user space vhost?
> [tzhou] We use Linux vhost.
>
> Do you enable the dump/log in your test? It will decrease perf
64 matches
Mail list logo
