> On 9/28/2021 2:51 PM, Junxiao Shi wrote:
> > Previously, memif socket hash is always allocated on NUMA socket 0.
> > If the application is entirely running on another NUMA socket and EAL
> > --socket-limit prevents memory allocation on NUMA socket 0, memif
> > creation fails with "HASH: memory
chained mbuf
> > is actually present.
> >
> > Signed-off-by: Junxiao Shi
Looks ok to me. Thanks for the patch!
Reviewed-by: Jakub Grajciar
Signed-off-by: Jakub Grajciar jgraj...@cisco.com<mailto:jgraj...@cisco.com>
---
doc/guides/rel_notes/release_21_11.rst | 3 +++
lib/eal/include/rte_eal_memconfig.h| 4
lib/eal/version.map| 4 +---
3 files changed, 4 insertions(+), 7 deletions(-)
diff --git
> -Original Message-
> From: Nathan Skrzypczak
> Sent: Friday, July 23, 2021 11:19 AM
> To: dev@dpdk.org
> Cc: andrew.rybche...@oktetlabs.ru; Jakub Grajciar -X (jgrajcia - PANTHEON
> TECH SRO at Cisco)
> Subject: [PATCH v2] net/memif: fix abstract socket addr_len
Hi,
Sorry for the inconvenience, the thread got filtered so I only found it in spam
after Damjan notified me.
The patch looks good. Thanks for the fix!
Reviewd-By: Jakub Grajciar
> -Original Message-
> From: Ferruh Yigit
> Sent: Tuesday, May 18, 2021 2:09 PM
> To: Tiany
Abstract socket address has no connection with
filesystem pathnames and the socket disappears
once all open references are closed.
Memif pmd will use abstract socket address by default.
For backwards compatibility use new argument
'socket-abstract=no'
Signed-off-by: Jakub Grajciar
Abstract socket address has no connection with
filesystem pathnames and the socket disappears
once all open references are closed.
Memif pmd will use abstract socket address by default.
For backwards compatibility use new argument
'socket-abstract=no'
Signed-off-by: Jakub Grajciar
gt; transmitter and receiver affecting the performance.
Hi Honnappa,
The patch series is looking good.
Reviewed-by: Jakub Grajciar
Abstract socket address has no connection with
filesystem pathnames and the socket dissapears
once all open references are closed.
Memif pmd will use abstract socket address by default.
For backwards compatibility use new argument
'socket-abstract=no'
Signed-off-by: Jakub Grajciar
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, October 5, 2020 3:09 PM
> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
> ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/memif: use abstract socket address
>
> On 10/5/2020 1:39
Abstract socket address has no connection with
filesystem pathnames and the socket dissapears
once all open references are closed.
Memif pmd will use abstract socket address by default.
For backwards compatibility use new argument
'socket-abstract=no'
Signed-off-by: Jakub Grajciar
fore the store-release are observed before it.
Ok then, since the sync is there and the rest seems fine to me.
Thanks,
Jakub
Reviewed-by: Jakub Grajciar
Hi Honnappa,
Inline comments...
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Saturday, September 19, 2020 12:49 AM
> To: Phil Yang ; Jakub Grajciar -X (jgrajcia - PANTHEON
> TECH SRO at Cisco) ; dev@dpdk.org
> Cc: Ruifeng Wang ; nd ; Honnappa
> Nagara
> -Original Message-
> From: Sunil Kumar Kori
> Sent: Wednesday, June 10, 2020 12:01 PM
> To: Muhammad Bilal
> Cc: declan.dohe...@intel.com; tomasz.kante...@intel.com; Pavan Nikhilesh
> Bhagavatula ; dev@dpdk.org; Jakub Grajciar -X
> (jgrajcia - PANTH
enable promisc mode
Signed-off-by: Jakub Grajciar
---
drivers/net/memif/rte_eth_memif.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/memif/rte_eth_memif.c
b/drivers/net/memif/rte_eth_memif.c
index 81d71c53a..0ac38044e 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b
enable promisc mode
Signed-off-by: Jakub Grajciar
---
drivers/net/memif/rte_eth_memif.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/memif/rte_eth_memif.c
b/drivers/net/memif/rte_eth_memif.c
index 81d71c53a..0ac38044e 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b
Signed-off-by: Jakub Grajciar
---
drivers/net/memif/rte_eth_memif.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/memif/rte_eth_memif.c
b/drivers/net/memif/rte_eth_memif.c
index 81d71c53a..0ac38044e 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif
implement promisc enable/disable for memif PMD
Signed-off-by: Jakub Grajciar
---
drivers/net/memif/rte_eth_memif.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/net/memif/rte_eth_memif.c
b/drivers/net/memif/rte_eth_memif.c
index 81d71c53a..d138ec89e 100644
--- a
> -Original Message-
> From: Július Milan
> Sent: Wednesday, February 19, 2020 9:19 AM
> To: dev@dpdk.org; Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
>
> Subject: [dpdk-dev][PATCH 1/2] net/memif: enable loopback
>
> With this patch it is possible
> -Original Message-
> From: Július Milan
> Sent: Wednesday, February 19, 2020 9:19 AM
> To: dev@dpdk.org; Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
>
> Subject: [dpdk-dev][PATCH 2/2] net/memif: fix init handling when already
> connected
>
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, November 11, 2019 4:25 PM
> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
>
> Cc: dev@dpdk.org; Ferruh Yigit ; David Marchand
> ; Anatoly Burakov
>
> Subject: Re: [dpdk-dev] [PAT
Zero-copy slave support for memif PMD.
Slave interface exposes DPDK memory to
master interface. Only single file segments
are supported (EAL option --single-file-segments).
Signed-off-by: Jakub Grajciar
---
doc/guides/nics/memif.rst | 42 +-
drivers/net/memif/Makefile
> > On 8/22/2019 9:18 AM, Jakub Grajciar wrote:
> > > Zero-copy slave support for memif PMD.
> > > Slave interface exposes DPDK memory to master interface. Only single
> > > file segments are supported (EAL option --single-file-segments).
>
> Do you reall
> -Original Message-
> From: Anand Sunkad
> Sent: Thursday, October 17, 2019 3:21 PM
> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
>
> Cc: dev@dpdk.org; Vivek Gupta ; Thomas
> Mulamangalath ; Anand Sunkad
>
> Subject: [PATCH] net/mem
Define MEMIF_SOCKET_UN_SIZE to size of unix domain socket address.
Report error in case of longer path.
Fixes: b923866c6974 ("net/memif: allow for full key size in socket name")
Cc: step...@networkplumber.org
Signed-off-by: Jakub Grajciar
---
doc/guides/nics/memif.rst | 2 +
> Why does this not use abstract unix domain socket naming?
> That would be much less error prone, because then the socket would
> disappear when all applications using it are closed.
How would that work with containers? I'll consider that for a new patch, maybe
it could be optional?
> -Original Message-
> From: Ferruh Yigit
> Sent: Tuesday, October 22, 2019 6:33 PM
> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
> ; dev@dpdk.org
> Cc: step...@networkplumber.org
> Subject: Re: [dpdk-dev] [PATCH] net/memif: fix invalid unix do
Define MEMIF_SOCKET_UN_SIZE to size of unix domain socket address.
Report error in case of longer path.
Fixes: b923866c6974 ("net/memif: allow for full key size in socket name")
Cc: step...@networkplumber.org
Signed-off-by: Jakub Grajciar
---
doc/guides/nics/memif.rst | 2 +
> Hi Jakub,
>
> Just to double check if anyone is looking into the bind() error issue which is
> since following commit, I am waiting for more input on it.
>
> Commit b923866c6974 ("net/memif: allow for full key size in socket name")
> Cc: step...@networkplumber.org
Definitely an issue, I must
> -Original Message-
> From: Anand Sunkad
> Sent: Wednesday, October 16, 2019 3:22 PM
> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
>
> Cc: dev@dpdk.org; Vivek Gupta ; Thomas
> Mulamangalath ; Anand Sunkad
>
> Subject: [PATCH] net/mem
> -Original Message-
> From: Phil Yang
> Sent: Wednesday, October 9, 2019 4:05 AM
> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
> ; ferruh.yi...@intel.com; dev@dpdk.org
> Cc: tho...@monjalon.net; Damjan Marion (damarion)
> ; honnappa.nagarah
erformance gain.
> > > >
> > > > Signed-off-by: Phil Yang
> > > > Reviewed-by: Gavin Hu
> >
> > The patch is looking good, but 'MEMIF_VERSION_MAJOR' in memif.h needs
> > to be set to 3 as ring pointers are no longer volatile.
>
> Updated in v2.
> Thanks for your comments.
>
> Thanks,
> Phil
I jumped the gun with the version bump. The change doesn't break compatibility.
I'm putting reviewed label on v1.
Sorry for the inconvenience.
Reviewed-by: Jakub Grajciar
> > -Original Message-
> > From: dev On Behalf Of Phil Yang
> > Sent: Monday, August 26, 2019 7:00 PM
> > To: jgraj...@cisco.com; dev@dpdk.org
> > Cc: tho...@monjalon.net; jer...@marvell.com; Honnappa Nagarahalli
> > ; damar...@cisco.com; nd
>
> > Subject: [dpdk-dev] [PATCH v1] net/memif:
Hi Ferruh,
> Hi Jakub,
>
> While testing your zero-copy patch [1], I stuck to a bind() error [2].
> When provided a socket length bigger than "sizeof(struct sockaddr)", bind()
> fails. I am testing this on a Fedora system.
> I wonder if there is a check in glibc related to the length.
Z
> -Original Message-
> From: Stephen Hemminger
> Sent: Tuesday, July 16, 2019 7:21 PM
> To: dev@dpdk.org; Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at
> Cisco)
> Cc: Stephen Hemminger
> Subject: [RFC v3] net/memif: allow for full key size in socket n
Zero-copy slave support for memif PMD.
Slave interface exposes DPDK memory to
master interface. Only single file segments
are supported (EAL option --single-file-segments).
Signed-off-by: Jakub Grajciar
---
doc/guides/nics/memif.rst | 42 +-
drivers/net/memif/Makefile
fixes CID: 343440, 343459, 343464, 343394
Signed-off-by: Jakub Grajciar
---
drivers/net/memif/memif_socket.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
V2:
- fix coding style
diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c
index
fixes CID: 343440, 343459, 343464, 343394
Signed-off-by: Jakub Grajciar
---
drivers/net/memif/memif_socket.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c
index 01a935f87..65dff321c 100644
> -Original Message-
> From: Ferruh Yigit
> Sent: Wednesday, July 10, 2019 5:07 PM
> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
> ; dev@dpdk.org
> Cc: anatoly.bura...@intel.com
> Subject: Re: [dpdk-dev] [PATCH v4] net/memif: zero-copy slave
Zero-copy slave support for memif PMD.
Slave interface exposes DPDK memory to
master interface. Only single file segments
are supported (EAL option --single-file-segments).
Signed-off-by: Jakub Grajciar
---
doc/guides/nics/memif.rst | 29 ++
drivers/net/memif/Makefile
Zero-copy slave support for memif PMD.
Slave interface exposes DPDK memory to
master interface. Only single file segments
are supported (EAL option --single-file-segments).
Signed-off-by: Jakub Grajciar
---
doc/guides/nics/memif.rst | 29 ++
drivers/net/memif/Makefile| 1
Zero-copy slave support for memif PMD.
Slave interface exposes DPDK memory to
master interface. Only single file segments
are supported (EAL option --single-file-segments).
Signed-off-by: Jakub Grajciar
---
doc/guides/nics/memif.rst | 29 ++
drivers/net/memif/Makefile| 1
Zero-copy slave support for memif PMD.
Slave interface exposes DPDK memory to
master interface. Only single file segments
are supported (EAL option --single-file-segments).
Signed-off-by: Jakub Grajciar
---
doc/guides/nics/memif.rst | 29 ++
drivers/net/memif/Makefile| 1
Multi-process support for memif PMD.
Primary process handles connection establishment.
Secondary process queries for memory regions.
Signed-off-by: Jakub Grajciar
---
drivers/net/memif/Makefile| 3 +
drivers/net/memif/memif_socket.c | 45 +--
drivers/net/memif/meson.build | 3
Multi-process support for memif PMD.
Primary process handles connection establishment.
Secondary process queries for memory regions.
Signed-off-by: Jakub Grajciar
---
drivers/net/memif/Makefile| 3 +
drivers/net/memif/memif_socket.c | 45 +--
drivers/net/memif/meson.build | 3
Multi-process support for memif PMD.
Primary process handles connection establishment.
Secondary process queries for memory regions.
Signed-off-by: Jakub Grajciar
---
drivers/net/memif/Makefile| 4 +
drivers/net/memif/memif_socket.c | 45 ++--
drivers/net/memif/meson.build | 4
is supported in DPDK memif implementation. Memif is Linux
only.
Signed-off-by: Jakub Grajciar
---
MAINTAINERS |6 +
config/common_base |5 +
config/common_linux |1 +
doc/guides/nics/features/memif.ini
> -Original Message-
> From: Ferruh Yigit
> Sent: Thursday, June 6, 2019 11:24 AM
> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
> ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v10] net/memif: introduce memory interface
> (memif) PMD
>
is
supported in DPDK memif implementation. Memif is Linux only.
Signed-off-by: Jakub Grajciar
---
MAINTAINERS |6 +
config/common_base |5 +
config/common_linux |1 +
doc/guides/nics/features/memif.ini
> -Original Message-
> From: Ye Xiaolong
> Sent: Friday, May 31, 2019 9:43 AM
> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v10] net/memif: introduce memory interface
> (memif) PMD
>
Memory interface (memif), provides high performance
packet transfer over shared memory.
Signed-off-by: Jakub Grajciar
---
MAINTAINERS |6 +
config/common_base |5 +
config/common_linux |1 +
doc/guides
> -Original Message-
> From: Ferruh Yigit
> Sent: Wednesday, May 29, 2019 7:29 PM
> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
> ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC v9] /net: memory interface (memif)
> > +
> > +.. csv
Memory interface (memif), provides high performance
packet transfer over shared memory.
Signed-off-by: Jakub Grajciar
---
MAINTAINERS |6 +
config/common_base |5 +
config/common_linux |1 +
doc/guides
> -Original Message-
> From: Stephen Hemminger
> Sent: Thursday, May 16, 2019 5:22 PM
> To: Jakub Grajciar
>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC v8] /net: memory interface (memif)
>
> On Thu, 16 May 2019 13:46:58 +0200
> Jakub Grajciar wr
Memory interface (memif), provides high performance
packet transfer over shared memory.
Signed-off-by: Jakub Grajciar
---
MAINTAINERS |6 +
app/test-pmd/testpmd.c |2 +
config/common_base |5 +
config
Memory interface (memif), provides high performance
packet transfer over shared memory.
Signed-off-by: Jakub Grajciar
---
MAINTAINERS |6 +
app/test-pmd/testpmd.c |2 +
config/common_base |5 +
config
Memory interface (memif), provides high performance
packet transfer over shared memory.
Signed-off-by: Jakub Grajciar
---
MAINTAINERS |6 +
app/test-pmd/testpmd.c |2 +
config/common_base |5 +
config
From: Honnappa Nagarahalli
Sent: Friday, May 3, 2019 6:27 AM
To: Jakub Grajciar; Ferruh Yigit; dev@dpdk.org; Honnappa Nagarahalli
Cc: nd; nd
Subject: RE: [dpdk-dev] [RFC v5] /net: memory interface (memif)
> On 3/22/2019 11:57 AM, Jakub Grajciar wr
From: Ferruh Yigit
Sent: Monday, March 25, 2019 9:58 PM
To: Jakub Grajciar; dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC v5] /net: memory interface (memif)
On 3/22/2019 11:57 AM, Jakub Grajciar wrote:
> Memory interface (memif), provides high performa
Memory interface (memif), provides high performance
packet transfer over shared memory.
Signed-off-by: Jakub Grajciar
---
MAINTAINERS |6 +
config/common_base |5 +
config/common_linux |1 +
doc/guides
this
interrupt source.
Signed-off-by: Jakub Grajciar
---
.../common/include/rte_interrupts.h | 32 ++
lib/librte_eal/freebsd/eal/eal_interrupts.c | 105 +-
lib/librte_eal/linux/eal/eal_interrupts.c | 85 +-
lib/librte_eal/rte_eal_version.map
this
interrupt source.
Signed-off-by: Jakub Grajciar
---
.../common/include/rte_interrupts.h | 32 ++
lib/librte_eal/freebsd/eal/eal_interrupts.c | 102 +-
lib/librte_eal/linux/eal/eal_interrupts.c | 85 ++-
lib/librte_eal/rte_eal_version.map
this
interrupt source.
Signed-off-by: Jakub Grajciar
---
.../common/include/rte_interrupts.h | 32 ++
lib/librte_eal/freebsd/eal/eal_interrupts.c | 100 ++
lib/librte_eal/linux/eal/eal_interrupts.c | 85 ++-
lib/librte_eal/rte_eal_version.map
this
interrupt source.
Signed-off-by: Jakub Grajciar
---
lib/librte_eal/bsdapp/eal/eal_interrupts.c| 100 ++
.../common/include/rte_interrupts.h | 32 ++
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 85 ++-
lib/librte_eal/rte_eal_version.map
Memory interface (memif), provides high performance
packet transfer over shared memory.
Signed-off-by: Jakub Grajciar
---
MAINTAINERS |6 +
config/common_base |5 +
config/common_linuxapp |1 +
doc/guides
this
interrupt source.
Signed-off-by: Jakub Grajciar
---
.../common/include/rte_interrupts.h | 32 +++
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 85 ++-
lib/librte_eal/rte_eal_version.map| 1 +
3 files changed, 116 insertions(+), 2 deletions
this
interrupt source.
Signed-off-by: Jakub Grajciar
---
.../common/include/rte_interrupts.h | 31 +++
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 86 ++-
lib/librte_eal/rte_eal_version.map| 1 +
3 files changed, 116 insertions(+), 2 deletions
this
interrupt source.
Signed-off-by: Jakub Grajciar
---
.../common/include/rte_interrupts.h | 31 +++
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 86 ++-
lib/librte_eal/rte_eal_version.map| 1 +
3 files changed, 116 insertions(+), 2 deletions
this
interrupt source.
Signed-off-by: Jakub Grajciar
---
.../common/include/rte_interrupts.h | 30 +++
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 85 ++-
lib/librte_eal/rte_eal_version.map| 1 +
3 files changed, 114 insertions(+), 2 deletions
Memory interface (memif), provides high performance
packet transfer over shared memory.
Signed-off-by: Jakub Grajciar
---
config/common_base |5 +
config/common_linuxapp |1 +
doc/guides/nics/memif.rst | 80 ++
drivers
this
interrupt source.
Signed-off-by: Jakub Grajciar
---
.../common/include/rte_interrupts.h | 30 +++
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 85 ++-
lib/librte_eal/rte_eal_version.map| 7 ++
3 files changed, 120 insertions(+), 2 deletions
Signed-off-by: Jakub Grajciar
---
config/common_base |5 +
config/common_linuxapp |1 +
drivers/net/Makefile|1 +
drivers/net/memif/Makefile | 29 +
drivers/net/memif/memif.h
Signed-off-by: Jakub Grajciar
---
config/common_base |5 +
config/common_linuxapp |1 +
drivers/net/Makefile|1 +
drivers/net/memif/Makefile | 29 +
drivers/net/memif/memif.h
this
interrupt source.
Signed-off-by: Jakub Grajciar
---
.../common/include/rte_interrupts.h | 30 +++
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 85 ++-
2 files changed, 113 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/include
this
interrupt source.
Signed-off-by: Jakub Grajciar
---
.../common/include/rte_interrupts.h | 30 +++
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 83 ++-
2 files changed, 111 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/include
this
interrupt source.
Signed-off-by: Jakub Grajciar
---
.../common/include/rte_interrupts.h | 29 +++
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 84 ++-
2 files changed, 111 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/include
76 matches
Mail list logo
