Re: [PATCH v2] test/bitops: check worker lcore availability

Acked-by: Jack Bond-Preston On 25/10/2024 08:39, David Marchand wrote: Coverity is not able to understand that having 2 lcores means that rte_get_next_lcore(-1, 0, 1) can't return RTE_MAX_LCORE. Add a check. Coverity issue: 445382, 445383, 445384, 445387, 445389, 445391 Fixes: 35326b6

Re: [PATCH v2 2/6] crypto/openssl: support EDDSA

Hi, On 05/09/2024 14:39, Gowrishankar Muthukrishnan wrote: Support EDDSA crypto algorithm in OpenSSL PMD. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/openssl/openssl_pmd_private.h | 13 ++ drivers/crypto/openssl/rte_openssl_pmd.c | 223 +++ drivers/cry

Re: [PATCH v3 5/5] eal: extend bitops to handle volatile pointers

On 12/08/2024 13:49, Mattias Rönnblom wrote: Have rte_bit_[test|set|clear|assign|flip]() and rte_bit_atomic_*() handle volatile-marked pointers. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Jack Bond-Preston

Re: [PATCH v3 4/5] eal: add unit tests for atomic bit access functions

On 12/08/2024 13:49, Mattias Rönnblom wrote: Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston

Re: [PATCH v3 3/5] eal: add atomic bit operations

: Tyler Retzlaff Acked-by: Jack Bond-Preston

Re: [PATCH v3 2/5] eal: add unit tests for bit operations

Bond-Preston

Re: [PATCH v3 1/5] eal: extend bit manipulation functionality

-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston

Re: [PATCH v2 5/5] eal: extend bitops to handle volatile pointers

On 09/08/2024 10:58, Mattias Rönnblom wrote: +#define __RTE_GEN_BIT_ATOMIC_TEST(v, qualifier, size) \ __rte_experimental \ static inline bool \ - __rte_bit_atomic_test

Re: [PATCH v2 3/5] eal: add atomic bit operations

On 09/08/2024 10:58, Mattias Rönnblom wrote: + +#define __RTE_GEN_BIT_ATOMIC_OPS(size) \ + __RTE_GEN_BIT_ATOMIC_TEST(size) \ + __RTE_GEN_BIT_ATOMIC_SET(size) \ + __RTE_GEN_BIT_ATOMIC_CLEAR(size)\ + __RTE_GEN

Re: [PATCH v2 1/5] eal: extend bit manipulation functionality

On 09/08/2024 10:58, Mattias Rönnblom wrote: + +__RTE_GEN_BIT_TEST(, test,, 32) +__RTE_GEN_BIT_SET(, set,, 32) +__RTE_GEN_BIT_CLEAR(, clear,, 32) +__RTE_GEN_BIT_ASSIGN(, assign,, 32) +__RTE_GEN_BIT_FLIP(, flip,, 32) + +__RTE_GEN_BIT_TEST(, test,, 64) +__RTE_GEN_BIT_SET(, set,, 64) +__RTE_GEN_BIT

Re: [PATCH] doc: update Arm IPsec-MB dependency version

On 31/07/2024 22:26, Wathsala Vithanage wrote: Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.07.08 in snow3g and zuc documentation. Signed-off-by: Wathsala Vithanage Reviewed-by: Dhruv Tripathi Acked-by: Jack Bond-Preston --- .mailmap | 1 + doc

Re: [PATCH 2/2] doc: remove use of -n 4 option in documentation

On 18/07/2024 19:43, Stephen Hemminger wrote: Many places in the documentation are using -n 4 to set the number of memory channels. This should not be recommended since it is not always right and the default should be used instead. Signed-off-by: Stephen Hemminger Acked-by: Jack Bond-Preston

[PATCH] doc: clarify mempool striding optimisation on Arm

The mempool memory channel striding optimisation is not necessary on Arm platforms. Update the Programmer's Guide's mempool section to clarify this. Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- doc/guides/prog_guide/mempool_lib.rst | 6 ++ 1 file

Re: [EXTERNAL] [PATCH v4 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

On 03/07/2024 11:49, Jack Bond-Preston wrote: On 02/07/2024 16:39, Akhil Goyal wrote: I am seeing below errors when it is compiled with openssl 3.0 [1/30] Compiling C object 'drivers/a715181@@tmp_rte_crypto_openssl@sta/crypto_openssl_rte_openssl_pmd_ops.c.o'. FAILED: drive

[PATCH v5 5/5] crypto/openssl: only set cipher padding once

28.05 | 135.40 | 5.7% | |4096 |139.45 | 143.76 | 3.1% | Signed-off-by: Jack Bond-Preston Acked-by: Kai Ji Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[PATCH v5 4/5] crypto/openssl: per-qp auth context clones

Bond-Preston Acked-by: Kai Ji Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/compat.h | 26 +++ drivers/crypto/openssl/openssl_pmd_private.h | 25 ++- drivers/crypto/openssl/rte_openssl_pmd.c | 176 +++ drivers/crypto/openssl/rte_openssl_pmd_ops.c

[PATCH v5 3/5] crypto/openssl: per-qp cipher context clones

| 64.86 | 520.3% | |1024 | 40.97 | 113.80 | 177.7% | |2048 | 73.25 | 130.21 |77.8% | |4096 |103.89 | 140.62 |35.4% | Signed-off-by: Jack Bond-Preston Acked-by: Kai Ji Reviewed-by: Wathsala

[PATCH v5 2/5] crypto/openssl: only init 3DES-CTR key + impl once

| 1.77 | 2.6% | |2048 | 1.76 | 1.78 | 1.1% | |4096 | 1.79 | 1.80 | 0.6% | Signed-off-by: Jack Bond-Preston Acked-by: Kai Ji Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 21

[PATCH v5 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

2048 |147.69 | 80.91 | -45.2% | |4096 |167.39 | 121.25 | -27.6% | Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Jack Bond-Preston Acked-by: Kai Ji Reviewed-by: Wat

[PATCH v5 0/5] OpenSSL PMD Optimisations

s, so I haven't attached them for now. If you are interested in reviewing them, please reach out and I will find a way to get them to you. Jack Bond-Preston (5): crypto/openssl: fix GCM and CCM thread unsafe ctxs crypto/openssl: only init 3DES-CTR key + impl once crypto/openssl: pe

Re: [EXTERNAL] [PATCH v4 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

On 02/07/2024 16:39, Akhil Goyal wrote: I am seeing below errors when it is compiled with openssl 3.0 [1/30] Compiling C object 'drivers/a715181@@tmp_rte_crypto_openssl@sta/crypto_openssl_rte_openssl_pmd_ops.c.o'. FAILED: drivers/a715181@@tmp_rte_crypto_openssl@sta/crypto_openssl_rte_openssl_

[PATCH 2/2] maintainers: update maintainers

Update maintainers for Bitops, Ticketlock, and ARMv8 Crypto. Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index dfc022c0c6..6cfcf4cafe 100644 --- a

[PATCH 1/2] maintainers: update for ARMv7 and ARMv8

Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 533f707d5f..dfc022c0c6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -279,13 +279,13 @@ F: lib/eal/common

Re: [PATCH] app/test-crypto-perf: add shared session option

Hi Brian, Would be good to add a doc update too. Thanks. Acked-by: Brian Dooley Thanks for the suggestion! I totally missed that. I've uploaded v2 with a doc update. Thanks, Jack

[PATCH v2] app/test-crypto-perf: add shared session option

Add the option to create one session for the PMD, and share it across all of the queue pairs. This may help to discover/debug concurrency issues (both correctness and performance) that can occur when using this configuration. Signed-off-by: Jack Bond-Preston Acked-by: Brian Dooley Reviewed-by

[PATCH v4 5/5] crypto/openssl: only set cipher padding once

28.05 | 135.40 | 5.7% | |4096 |139.45 | 143.76 | 3.1% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/c

[PATCH v4 4/5] crypto/openssl: per-qp auth context clones

Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/compat.h | 26 +++ drivers/crypto/openssl/openssl_pmd_private.h | 25 ++- drivers/crypto/openssl/rte_openssl_pmd.c | 176 +++ drivers/crypto/openssl/rte_openssl_pmd_ops.c | 7 +- 4 files

[PATCH v4 3/5] crypto/openssl: per-qp cipher context clones

| 64.86 | 520.3% | |1024 | 40.97 | 113.80 | 177.7% | |2048 | 73.25 | 130.21 |77.8% | |4096 |103.89 | 140.62 |35.4% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage

[PATCH v4 2/5] crypto/openssl: only init 3DES-CTR key + impl once

| 1.77 | 2.6% | |2048 | 1.76 | 1.78 | 1.1% | |4096 | 1.79 | 1.80 | 0.6% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 21

[PATCH v4 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

2048 |147.69 | 80.91 | -45.2% | |4096 |167.39 | 121.25 | -27.6% | Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vi

[PATCH v4 0/5] OpenSSL PMD Optimisations

oss different sets of applied patches) - for both Intel and Arm platforms - are available. However, I'm not sure of the ettiquette regarding attachments of such files, so I haven't attached them for now. If you are interested in reviewing them, please reach out and I will find a way to get

[PATCH v3 5/5] crypto/openssl: only set cipher padding once

28.05 | 135.40 | 5.7% | |4096 |139.45 | 143.76 | 3.1% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/c

[PATCH v3 4/5] crypto/openssl: per-qp auth context clones

Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/compat.h | 26 drivers/crypto/openssl/openssl_pmd_private.h | 25 +++- drivers/crypto/openssl/rte_openssl_pmd.c | 144 ++- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 7 +- 4 files

[PATCH v3 3/5] crypto/openssl: per-qp cipher context clones

| 64.86 | 520.3% | |1024 | 40.97 | 113.80 | 177.7% | |2048 | 73.25 | 130.21 |77.8% | |4096 |103.89 | 140.62 |35.4% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage

[PATCH v3 2/5] crypto/openssl: only init 3DES-CTR key + impl once

| 1.77 | 2.6% | |2048 | 1.76 | 1.78 | 1.1% | |4096 | 1.79 | 1.80 | 0.6% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 21

[PATCH v3 0/5] OpenSSL PMD Optimisations

r, I'm not sure of the ettiquette regarding attachments of such files, so I haven't attached them for now. If you are interested in reviewing them, please reach out and I will find a way to get them to you. Jack Bond-Preston (5): crypto/openssl: fix GCM and CCM thread unsafe ctxs cryp

[PATCH v3 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

2048 |147.69 | 80.91 | -45.2% | |4096 |167.39 | 121.25 | -27.6% | Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vi

[PATCH] app/test-crypto-perf: add shared session option

Add the option to create one session for the PMD, and share it across all of the queue pairs. This may help to discover/debug concurrency issues (both correctness and performance) that can occur when using this configuration. Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage

[PATCH v2 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

| 42.46 | -64.5% | |2048 |147.69 | 80.91 | -45.2% | |4096 |167.39 | 121.25 | -27.6% | Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Jack Bond-

[PATCH v2 2/5] crypto/openssl: only init 3DES-CTR key + impl once

| 1.77 | 2.6% | |2048 | 1.76 | 1.78 | 1.1% | |4096 | 1.79 | 1.80 | 0.6% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 21

[PATCH v2 0/5] OpenSSL PMD Optimisations

additional bar charts showing the throughput comparison across different sets of applied patches) - for both Intel and Arm platforms - are available. However, I'm not sure of the ettiquette regarding attachments of such files, so I haven't attached them for now. If you are interested i

[PATCH v2 3/5] crypto/openssl: per-qp cipher context clones

| 64.86 | 520.3% | |1024 | 40.97 | 113.80 | 177.7% | |2048 | 73.25 | 130.21 |77.8% | |4096 |103.89 | 140.62 |35.4% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage

[PATCH v2 5/5] crypto/openssl: only set cipher padding once

28.05 | 135.40 | 5.7% | |4096 |139.45 | 143.76 | 3.1% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/c

[PATCH v2 4/5] crypto/openssl: per-qp auth context clones

Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/compat.h | 26 drivers/crypto/openssl/openssl_pmd_private.h | 25 +++- drivers/crypto/openssl/rte_openssl_pmd.c | 144 ++- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 7 +- 4 files

[PATCH v2 2/5] crypto/openssl: only init 3DES-CTR key + impl once

| 1.77 | 2.6% | |2048 | 1.76 | 1.78 | 1.1% | |4096 | 1.79 | 1.80 | 0.6% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 21

[PATCH v2 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

| 42.46 | -64.5% | |2048 |147.69 | 80.91 | -45.2% | |4096 |167.39 | 121.25 | -27.6% | Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Jack Bond-

[PATCH v2 4/5] crypto/openssl: per-qp auth context clones

Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/compat.h | 26 drivers/crypto/openssl/openssl_pmd_private.h | 25 +++- drivers/crypto/openssl/rte_openssl_pmd.c | 144 ++- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 7 +- 4 files

[PATCH v2 0/5] OpenSSL PMD Optimisations

additional bar charts showing the throughput comparison across different sets of applied patches) - for both Intel and Arm platforms - are available. However, I'm not sure of the ettiquette regarding attachments of such files, so I haven't attached them for now. If you are interested i

[PATCH v2 5/5] crypto/openssl: only set cipher padding once

28.05 | 135.40 | 5.7% | |4096 |139.45 | 143.76 | 3.1% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/c

[PATCH v2 3/5] crypto/openssl: per-qp cipher context clones

| 64.86 | 520.3% | |1024 | 40.97 | 113.80 | 177.7% | |2048 | 73.25 | 130.21 |77.8% | |4096 |103.89 | 140.62 |35.4% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage

Re: [PATCH 4/5] crypto/openssl: per-qp auth context clones

On 03/06/2024 17:01, Jack Bond-Preston wrote: diff --git a/drivers/crypto/openssl/openssl_pmd_private.h b/drivers/crypto/openssl/openssl_pmd_private.h index bad7dcf2f5..c3740ccc62 100644 --- a/drivers/crypto/openssl/openssl_pmd_private.h +++ b/drivers/crypto/openssl/openssl_pmd_private.h

Re: [PATCH 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

On 03/06/2024 17:01, Jack Bond-Preston wrote: + EVP_CIPHER_CTX *ctx = EVP_CIPHER_CTX_new(); + EVP_CIPHER_CTX_copy(ctx, sess->cipher.ctx); + This, and other patches in the set, are throwing a checkpatch error: _coding style issues_ ERROR:SPACING: need consistent spacing aro

[PATCH 5/5] crypto/openssl: only set cipher padding once

28.05 | 135.40 | 5.7% | |4096 |139.45 | 143.76 | 3.1% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/c

[PATCH 4/5] crypto/openssl: per-qp auth context clones

Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/compat.h | 26 drivers/crypto/openssl/openssl_pmd_private.h | 25 +++- drivers/crypto/openssl/rte_openssl_pmd.c | 144 ++- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 7 +- 4 files

[PATCH 3/5] crypto/openssl: per-qp cipher context clones

| 64.86 | 520.3% | |1024 | 40.97 | 113.80 | 177.7% | |2048 | 73.25 | 130.21 |77.8% | |4096 |103.89 | 140.62 |35.4% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage

[PATCH 1/5] crypto/openssl: fix GCM and CCM thread unsafe ctxs

| 42.46 | -64.5% | |2048 |147.69 | 80.91 | -45.2% | |4096 |167.39 | 121.25 | -27.6% | Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Jack Bond-

[PATCH 2/5] crypto/openssl: only init 3DES-CTR key + impl once

| 1.77 | 2.6% | |2048 | 1.76 | 1.78 | 1.1% | |4096 | 1.79 | 1.80 | 0.6% | Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- drivers/crypto/openssl/rte_openssl_pmd.c | 21

[PATCH 0/5] OpenSSL PMD Optimisations

t sets of applied patches) - for both Intel and Arm platforms - are available. However, I'm not sure of the ettiquette regarding attachments of such files, so I haven't attached them for now. If you are interested in reviewing them, please reach out and I will find a way to get them to you

[PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag

Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.12 in snow3g and zuc documentation. Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage --- .mailmap | 1 + doc/guides/cryptodevs/snow3g.rst | 2 +- doc/guides/cryptodevs/zuc.rst| 2 +- 3

Re: [PATCH v6 1/5] ci: replace IPsec-mb package install

Hi, On 08/03/2024 16:05, Power, Ciara wrote: I think, for basic compile to work for both repos, any functions in the ipsec_mb.h file need to be defined in a C file to avoid issues. But, I understand only SNOW3G + ZUC are the focus for the Arm ipsec-mb repo, so a HMAC related function like the on