Hi Stephen,
> The DPDK Atlantic driver has 6 API's marked as experimental.
> These API's were added back in 19.05 release.
> These API's should either be marked as stable or removed in 23.11 release.
> What do you want to do?
Unfortunately to my knowledge, this project is no more supported by Ma
> - Move "Supported Chipsets and NICs" section to top
> - Fix section indentation
> - Remove empty sections
>
> Signed-off-by: Ferruh Yigit
Thanks for taking care, Ferruh!
Reviewed-by: Igor Russkikh
92b ("net/qede: add infrastructure for debug data
>> collection")
>> Cc: rm...@marvell.com
>
> Hi @Rasesh Mody @Devendra Singh Rawat @Igor Russkikh
>
> Please review this patch to merge.
>
>
>>
>> Signed-off-by: Anatoly Burakov
Reviewed-by: Igor Russkikh
Thanks!
Adding Marvell prefix for qlogic drivers.
Removing myself as I'm no longer responsible for qede driver
Signed-off-by: Igor Russkikh
Signed-off-by: Rasesh Mody
---
MAINTAINERS | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4de75
Fixing ex-Aquantia email - it is now part of Marvell.
Removing Pavel Belous email - he is not in company now.
Adding Marvell tree to run this through.
Signed-off-by: Igor Russkikh
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
barchive is set as an optional dependency: without libarchive, a
> runtime warning is emitted so that users know there is a compressed
> firmware.
>
> Windows implementation is left as an empty stub.
>
> Signed-off-by: David Marchand
for QEDE,
Reviewed-by: Igor Russkikh
Deven
On 6/2/2021 1:05 PM, David Marchand wrote:
> On Wed, Jun 2, 2021 at 12:38 PM Igor Russkikh wrote:
>> We (Marvell QED) already provide packed version of FW in linux-firmware:
>>
>> But thats a custom name, and zlib.
>
> Whatever binary blob is available in linux
> Fedora 34 only provides compressed firmwares.
>
> Introduce an internal driver helper to handle transparently compression.
>
> I chose libarchive for decompressing as it seems widely available and
> DPDK had used it in the past.
>
> Windows support only matters for net/ice and firmware loadi
Adding my team members for that.
Strangely, even if by any reason we would get OOM condition - driver should
reject load gracefully.
Is there any possibility FW image could be corrupted/of bad size?
Regards,
Igor
On 5/26/2021 11:57 AM, Varghese, Vipin wrote:
> External Email
>
> --
family, so keeping it.
Signed-off-by: Igor Russkikh
Signed-off-by: Rasesh Mody
---
MAINTAINERS | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5877a16971..c25959b546 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -599,9 +599,8 @@ F
-
> drivers/net/qede/qede_rxtx.h | 21 +
> 2 files changed, 81 insertions(+), 88 deletions(-)
Series reviewed, for the series
Acked-by: Igor Russkikh
One checkpatch warn I see in patchwork output, probably worth fixing:
ERROR:POINTER_LOCATION: "(foo**)" should be "
>> Patch Series ACKed,
>> Acked-by: Devendra Singh Rawat
>
> Fixed the check-git-log.sh issues and Applied to
> dpdk-next-net-mrvl/for-main. Thanks
Thanks, Jerin, for taking care of that!
Igor
> IMO, it will be better if the log message also states that RSS key is trimmed
> to 'len' size.
Resent v2, thanks.
Devendra, please take these two patches into our internal codebase as well.
Igor
trace message.
CC: sta...@dpdk.org
Signed-off-by: Igor Russkikh
---
drivers/net/qede/qede_ethdev.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index ab5f5b106..bfd38a977 100644
--- a/drivers/net/qede
Signed-off-by: Igor Russkikh
---
drivers/net/qede/base/ecore_int.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/qede/base/ecore_int.c
b/drivers/net/qede/base/ecore_int.c
index 4207b1853..2c4aac941 100644
--- a/drivers/net/qede/base/ecore_int.c
+++ b/drivers/net
Two small fixes after customer feedback.
v2: improved abit log message
Igor Russkikh (2):
qede: reduce trace verbosity level
qede: make driver accept bigger rss tables
drivers/net/qede/base/ecore_int.c | 2 +-
drivers/net/qede/qede_ethdev.c| 6 --
2 files changed, 5 insertions
>>> Cc: rm...@marvell.com
>>> Cc: shsha...@marvell.com>
>>> Hi Rasesh, Shahed
>>> Could you review this series from Balazs?
>>
>> Shahed is not within marvell, adding Devendra from our DPKD support team.
>
> Could you update the MAINTAINERS to reflect that status?
Sure, done, just sent!
Igor
Removing Shahed, adding me and Devendra
Signed-off-by: Igor Russkikh
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e341bc81d..0f5e745cd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -866,7 +866,8 @@ F: doc/guides/nics
> On Fri, Mar 5, 2021 at 6:44 PM Balazs Nemeth wrote:
>>
>> This patch set optimizes qede_{rx,tx}_entry and introduces
>> rte_pktmbuf_free_bulk in qede_process_tx_compl. The overall performance
>> improvement depends on the use-case; in a physical-virtual-physical test
>> on a ThunderX2 99xx sy
trace message.
CC: sta...@dpdk.org
Signed-off-by: Igor Russkikh
---
drivers/net/qede/qede_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index ab5f5b106..7363d98f2 100644
--- a/drivers/net/qede
On some hardware units it was found this trace is flooding the output,
making any dpdk interactive usage kind of problematic.
It is only informational, without any consequences handling, so reducing
it to verbose from explicit notice level.
CC: sta...@dpdk.org
Signed-off-by: Igor Russkikh
Two small fixes after customer feedback.
Igor Russkikh (2):
qede: reduce trace verbosity level
qede: make driver accept bigger rss tables
drivers/net/qede/base/ecore_int.c | 2 +-
drivers/net/qede/qede_ethdev.c| 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
--
2.25.1
> > Signed-off-by: Igor Russkikh
>
> Reviewed-by: Ferruh Yigit
>
> Also a testpmd command to set the 'flowgen-clones' can be useful, for
> interactive mode. If you have time for it, can you please work on it too?
>
>
> Applied to dpdk-next-net/m
warning on uninit var
v1:
- fixes on Ferruh's comments
rfc v2: http://patchwork.dpdk.org/patch/78800/
- increment ref counter for each mbuf pointer copy
rfc v1: http://patchwork.dpdk.org/patch/78674/
Signed-off-by: Igor Russkikh
---
app/test-pmd/flowgen.c
>> Doing similar measurements per core, I see one core can do
>> 6.9MPPS (without clones) vs 11MPPS (with clones)
>>
>> Verified on Marvell qede and atlantic PMDs.
>
> Ubuntu 18.04 gcc complains:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ovsrobot_dpdk_runs_1713302522-3Fchec
:
- fixes on Ferruh's comments
rfc v2: http://patchwork.dpdk.org/patch/78800/
- increment ref counter for each mbuf pointer copy
rfc v1: http://patchwork.dpdk.org/patch/78674/
Signed-off-by: Igor Russkikh
---
app/test-pmd/flowgen.c| 105 ++
app/tes
> When calling rte_eth_promiscuous_enable(port_id) followed by
> rte_eth_allmulticast_enable(port_id), the port is not in promisc mode
> anymore. This patch ensures that promisc mode takes precedence over
> allmulticast mode fixing the regression introduced by b10231aed1ed.
>
> Signed-off-by: Ba
Hi Balazs,
This could be a regression for your specific usecase.
The commit itself tried to fix promisc as is.
Adding more people to comment/investigate here.
Devendra, could it be that we don't consider subsequent calls of
promisc_enabled + allmulti_enable ?
On 18/12/2020 2:34 pm, Balazs Neme
>> Here instead of recreating each packet separately, we use clones counter
>> to resend the same mbuf to the line multiple times.
>>
> Do you have any numbers on how much performance improvement gained?
Hi Ferruh,
Yes, I'll post that in v1. In general, on our 100G device in default
configurati
onfiguration Information
> -^
> -
> -- ``CONFIG_RTE_LIBRTE_ATLANTIC_PMD`` (default ``y``)
>
> Application Programming Interface
> -----
For atlantic,
Reviewed-by: Igor Russkikh
> diff --git a/doc/guides/nics/qede.rst
to reference counting inside of mbuf.
Verified on Marvell qede and atlantic PMDs.
v2: increment ref counter for each mbuf pointer copy
Signed-off-by: Igor Russkikh
---
app/test-pmd/flowgen.c| 101 ++
app/test-pmd/parameters.c | 12 +++
app
>> +} else {
>> +nb_clones--;
>> +}
>> +pkts_burst[nb_pkt] = pkt;
>>
>> next_flow = (next_flow + 1) % cfg_n_flows;
>> }
>
>
> This doesn't look safe. You can't just send same mbuf N times without
> incrementing
> the re
to reference counting inside of mbuf.
Verified on Marvell qede and atlantic PMDs.
Signed-off-by: Igor Russkikh
---
app/test-pmd/flowgen.c| 100 ++
app/test-pmd/parameters.c | 12
app/test-pmd/testpmd.c| 1 +
app/test
gt; > functions/defines implemented by drivers to find extended PCI
> > > > capabilities.
> > > >
> > > > Signed-off-by: Manish Chopra
> > > > Signed-off-by: Igor Russkikh
> > >
> > > LGTM,
> > > Reviewed-by: Gaetan Rivet
&g
eration.
>
> Signed-off-by: Thomas Monjalon
Thanks,
Acked-by: Igor Russkikh
I'll verify this soon on HW.
Igor
Thanks Ferruh,
> Adding BSD-3 SPDX license tag.
>
> Fixes: 519438f7c17f ("net/qede/base: re-arrange few structures for DDC")
> Cc: sta...@dpdk.org
>
> Reported-by: Stephen Hemminger
> Signed-off-by: Ferruh Yigit
> ---
> Cc: Jerin Jacob
Acked-by: Igor Russkikh
>
> [snip]
>
>> drivers/net/sfc/base/ef10_ev.c | 4 +--
>> drivers/net/sfc/base/ef10_filter.c | 12
>> drivers/net/sfc/base/ef10_mac.c | 18 +--
>> drivers/net/sfc/base/ef10_nic.c | 4 +--
>> drivers/net/sfc/base/ef1
On 01.09.2019 17:36, Andrew Rybchenko wrote:
> From: Ivan Ilchenko
>
> atl_dev_info_get() is declared twice in atl_ethdev.c.
> Delete one of these declararions.
>
> Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ivan Ilchenko
> Sign
---
drivers/net/atlantic/atl_ethdev.c | 116 ++
drivers/net/atlantic/meson.build | 1 +
2 files changed, 117 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b/drivers/net/atlantic/atl_ethdev.c
index c9c1795a1639..b6fcf36f0f27 100644
--- a/drivers/net/a
---
app/test-pmd/cmdline.c | 40
1 file changed, 32 insertions(+), 8 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index af7c2853fd2c..1bcf63e31ee3 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -14083,6 +14
draft on how macsec off command will looks like
Signed-off-by: Igor Russkikh
---
app/test-pmd/cmdline.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index dbee3d958c2e..af7c2853fd2c 100644
--- a/app
commands structure the same for now and will redesign
it in later commits.
Signed-off-by: Igor Russkikh
---
app/test-pmd/cmdline.c | 54 +++---
1 file changed, 46 insertions(+), 8 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index
atistics. The hard thing is that stats are
often available per SC/SA, a special API is required to fetch that.
Signed-off-by: Igor Russkikh
---
lib/librte_security/meson.build| 2 +-
lib/librte_security/rte_security.h | 115 -
2 files changed, 113 insertio
>>> TABLE 5-3 TRANSCEIVER COMPLIANCE CODES
>>> 10G Ethernet Compliance Codes
>>> 3 7 10G Base-ER
>>> 3 6 10G Base-LRM
>>> 3 5 10G Base-LR
>>> 3 4 10G Base-SR
>>> Infiniband Compliance Codes
>>> 3 3 1X SX
>>
>
> Hi - some of these that are fixes will apply on 18.11 stable branch with
> a little of rebasing, some will not. It will be cleaner to take the
> fixes as a series. Can you send backports for the series for the 18.11
> branch, or let me know if they are not needed.
Hi Kevin, I'll backport the
>>>
>>> The hw->allow_unsupported_sfp is used too late in
>>> https://git.dpdk.org/next/dpdk-next-net-intel/tree/drivers/net/ixgbe/b
>>> ase/ixgbe_phy.c#n1530 And if we've already got out earlier in
>>> https://git.dpdk.org/next/dpdk-next-net-intel/tree/drivers/net/ixgbe/b
>>> ase/ixgbe_phy.c#n150
flow control configuration")
cc: sta...@dpdk.org
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 24 +++
drivers/net/atlantic/atl_types.h | 1 +
drivers/net/atlantic/hw_atl/hw_atl_b0.c | 6 +
d
Found by coverity scan - dead code
Coverity issue: 337665
Fixes: 7943ba05f67c ("net/atlantic: add link status and interrupt management")
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_ethdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/atlantic/atl_e
Found by coverity scan, two pointer args should be not zero checked
Coverity issue: 337929
Fixes: 2f40244b39ba ("net/atlantic: implement MACsec firmware interface")
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 2 +-
1 file changed, 1 inser
Clients may not fillin magic field, thus causing garbage
to be passed as a device addr.
Limit that to maximum SMbus address.
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_ethdev.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b/drivers
Make indentation correct. No functional impact.
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/hw_atl/hw_atl_utils.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c
b/drivers/net/atlantic/hw_atl/hw_atl_utils.c
index
.@dpdk.org
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/hw_atl/hw_atl_utils.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c
b/drivers/net/atlantic/hw_atl/hw_atl_utils.c
index 19
From: Pavel Belous
Its better to use capability bits FW provides to detect whether
firmware has APIs for EEPROM access.
Before that explicit FW version comparison was used and that may
cause conflicts.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/hw_atl
Broadcast was not correctly and fully initialized
Signed-off-by: Igor Russkikh
Fixes: 7906661edac6 ("net/atlantic: add b0 hardware layer")
cc: sta...@dpdk.org
---
drivers/net/atlantic/hw_atl/hw_atl_b0.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/atlantic/hw_atl
Remove extra empty line at EOF
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_rxtx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c
index f1519594adad..fe0077044097 100644
--- a/drivers/net/atlantic/atl_rxtx.c
Maximum size should be 256 bytes.
Move declaration to the top of the file
Fixes: ce4e8d418097 ("net/atlantic: implement EEPROM get/set")
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
cc: sta...@dpdk.org
---
drivers/net/atlantic/atl_ethdev.c | 3 ++-
1 file changed, 2
t;net/atlantic: implement EEPROM get/set")
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c | 7 +-
drivers/net/atlantic/atl_types.h | 2 +-
drivers/net/atlantic/hw_atl/hw_atl_utils.h| 11 +--
.../net/atlan
This patchset contains various bugfixes found during verification
and integration testing.
Most notable is eeprom access cleanup, fix for broadcast filter,
flow control logic tracking, some code style cleanups.
Igor Russkikh (7):
net/atlantic: enable broadcast traffic
net/atlantic: extra
Hello Ferruh,
>> Pavel Belous (5):
>> net/atlantic: macsec hardware structures declaration
>> net/atlantic: enable macsec configuration
>> net/atlantic: macsec firmware interface
>> net/atlantic: interrupt handling and macsec configuration
>> net/atlantic: implement macsec statistics
>
Signed-off-by: Igor Russkikh
---
doc/guides/rel_notes/release_19_05.rst | 4
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/release_19_05.rst
b/doc/guides/rel_notes/release_19_05.rst
index dbdf07a0c05b..94d91bc5d311 100644
--- a/doc/guides/rel_notes/release_19_05.rst
Version is synced with internal Aquantia's driver versioning
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/atlantic/atl_common.h
b/drivers/net/atlantic/atl_com
From: Pavel Belous
We add extra xstat fields to include macsec counters and stats
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_ethdev.c | 82 +--
1 file changed, 77 insertions(+), 5 deletions(-)
diff --git a/drivers/net
From: Pavel Belous
Implementation of firmware interface for macsec configuration.
Structure with config data is written into FW memory, then we trigger
FW to execute the request and wait for result.
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_types.h
the upper layers.
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_ethdev.c | 189 --
drivers/net/atlantic/atl_ethdev.h | 2 +-
2 files changed, 180 insertions(+), 11 deletions(-)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b
From: Pavel Belous
Here we define hardware and software configuration structures
for macsec interface. MACSEC itself is implemented in Phy module,
but its configuration is done via firmware interface
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic
API wrappers.
Also update documentation with feature matrix for the
enabled feature.
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
doc/guides/nics/atlantic.rst | 6 +
doc/guides/nics/features/atlantic.ini | 1 +
drivers/net/atlantic/Makefile
h 2/4.
- Added documentation comments into the API header.
v2 changes:
- Removed public API changes for macsec, leave only PMD experimental
API for MACSEC in a form, similar to what ixgbe driver provides.
- Joined doc and features update into commit where macsec features
gets actually enabled
Version is synced with internal Aquantia's driver versioning
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/atlantic/atl_common.h
b/drivers/net/atlantic/atl_com
Add public visible macsec API functions.
These are wrappers over internal configuration routines,
validating and converting port no into dev pointer
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/Makefile | 1 +
drivers/net/atlantic/meson.build | 1
From: Pavel Belous
We add extra xstat fields to include macsec counters and stats
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_ethdev.c | 82 +--
1 file changed, 77 insertions(+), 5 deletions(-)
diff --git a/drivers/net
the upper layers.
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_ethdev.c | 66 ++-
drivers/net/atlantic/atl_ethdev.h | 2 +-
2 files changed, 57 insertions(+), 11 deletions(-)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b
From: Pavel Belous
Implementation of firmware interface for macsec configuration.
Structure with config data is written into FW memory, then we trigger
FW to execute the request and wait for result.
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_types.h
.
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
doc/guides/nics/atlantic.rst | 6 +
doc/guides/nics/features/atlantic.ini | 1 +
drivers/net/atlantic/atl_ethdev.c | 216 ++
drivers/net/atlantic/atl_ethdev.h | 12 ++
4 files changed, 235
MACSEC in a form, similar to what ixgbe driver provides.
- Joined doc and features update into commit where macsec features
gets actually enabled
Igor Russkikh (2):
net/atlantic: bump internal driver version
net/atlantic: public experimental macsec API
Pavel Belous (5):
net/atlantic
From: Pavel Belous
Here we define hardware and software configuration structures
for macsec interface. MACSEC itself is implemented in Phy module,
but its configuration is done via firmware interface
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic
> These are new ethdev APIs, not driver code, that have been sent after
> rc1, so
> these didn't go through a proper review cycle, we didn't get any comment
> on any
> other possible driver can use it, I am for postponing the series to next
> release.
>
> Also th
Hi Ferruh,
>> +int
>> +rte_eth_macsec_select_txsa(uint16_t port_id,
>> + uint8_t idx, uint8_t an,
>> + uint32_t pn, uint8_t *key);
>> +
>>
>> #include
>>
>
> These are new ethdev APIs, not driver code, that have been sent after rc1, so
> these did
>>> Please can you explain how it is related to rte_security?
>>
>> It is not.
>> Do you mean macsec control API could be moved and logically be a part of
>> rte_security api?
>> I can't comment now on how feasible is this. Moreover this depends on how
>> Intel considers
>> and uses the existing
Hello Thomas,
Thanks for the review!
On 10.04.2019 14:46, Thomas Monjalon wrote:
> 10/04/2019 13:18, Igor Russkikh:
>> MACSEC related device ops, API and parameters are taken from the
>> existing ixgbe PMD ops
>
> Please can you explain how it is related to rte_security?
I
From: Pavel Belous
Features matrix updated, RST doc is updated with macsec
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
doc/guides/nics/atlantic.rst | 1 +
doc/guides/nics/features/atlantic.ini | 1 +
2 files changed, 2 insertions(+)
diff --git a/doc/guides/nics
From: Pavel Belous
We add extra xstat fields to include macsec counters and stats
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_ethdev.c | 82 +--
1 file changed, 77 insertions(+), 5 deletions(-)
diff --git a/drivers/net
the upper layers.
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_ethdev.c | 66 ++-
drivers/net/atlantic/atl_ethdev.h | 2 +-
2 files changed, 57 insertions(+), 11 deletions(-)
diff --git a/drivers/net/atlantic/atl_ethdev.c
b
From: Pavel Belous
Version is synced with internal Aquantia's driver versioning
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/atlantic/atl_common.h
b/driver
From: Pavel Belous
This is a driver side of macsec configuration routines.
It fills in config structures and sends requests to FW
for configuration activities.
We also declare macsec offload bits in DPDK offload capabilities
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
From: Pavel Belous
Implementation of firmware interface for macsec configuration.
Structure with config data is written into FW memory, then we trigger
FW to execute the request and wait for result.
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_types.h
From: Pavel Belous
Here we define hardware and software configuration structures
for macsec interface. MACSEC itself is implemented in Phy module,
but its configuration is done via firmware interface
Signed-off-by: Pavel Belous
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic
Add new macsec generic callbacks to ixgbe driver.
Reuse existing rte_pmd_ driver API, keeping it to preserve
backward API compatibility
Signed-off-by: Igor Russkikh
---
drivers/net/ixgbe/ixgbe_ethdev.c | 55
1 file changed, 55 insertions(+)
diff --git a/drivers
Here we do repace testpmd direct usage of IXGBE driver calls
with generic ethdev macsec API calls
Signed-off-by: Igor Russkikh
---
app/test-pmd/cmdline.c | 20 ++--
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
MACSEC related device ops, API and parameters are taken from the
existing ixgbe PMD ops
Signed-off-by: Igor Russkikh
---
lib/librte_ethdev/rte_ethdev.c | 87 +
lib/librte_ethdev/rte_ethdev.h | 115
lib/librte_ethdev/rte_ethdev_core.h
.
Igor Russkikh (3):
ethdev: introduce MACSEC device ops
app/testpmd: use generic MACSEC API calls
net/ixgbe: macsec callbacks implementation
Pavel Belous (7):
net/atlantic: macsec hardware structures declaration
net/atlantic: macsec configuration code
net/atlantic: macsec firmware
Hi Ferruh,
Sorry forgot that.
Coverity issue: 187034
On 20.03.2019 16:24, Ferruh Yigit wrote:
> On 3/12/2019 3:24 PM, Igor Russkikh wrote:
>> Found by Coverity scan. Checks are useless
>> because at these code places err is always zero.
>
> Can you please add Coverit
Max number of xstats items was returned instead of actual number
of filled in records.
Cc: sta...@dpdk.org
Fixes: fbe059e87209 ("net/atlantic: implement device statistics")
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2
Original vlan offload code declared callbacks, but did not
enable the feature offload bit
Cc: sta...@dpdk.org
Fixes: f7c2c2c8c558 ("net/atlantic: implement VLAN filters and offloads")
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_ethdev.c | 3 ++-
1 file changed, 2 insert
Default rxtx logging used ERR level, that caused logger to always
trigger. That may cause perf degradation even if logger was not enabled but
compiled in.
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/atl_rxtx.c | 16
1 file changed, 4 insertions(+), 12 deletions
In case link speed is re configured after port start, it does not
takes the requested speed value, but instead just sets full autoneg
mask.
Cc: sta...@dpdk.org
Fixes: 7943ba05f67c ("net/atlantic: add link status and interrupt management")
Signed-off-by: Igor Russkikh
---
drivers/ne
From: Pavel Belous
Fixes: ce4e8d418097 ("net/atlantic: implement EEPROM get/set")
Cc: sta...@dpdk.org
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
.../net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 28 ---
1 file changed, 24 insertions(+), 4 deletion
From: Pavel Belous
Default dev addr is replaced with magic field from the request.
Length is allowed to be less than maximum.
SMBUS access bit definitions also better organised now.
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/atl_ethdev.c
ue: 323518
Coverity issue: 323520
Signed-off-by: Igor Russkikh
Signed-off-by: Pavel Belous
---
drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c
b/drivers/net/atlan
Found by Coverity scan. Checks are useless
because at these code places err is always zero.
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/hw_atl/hw_atl_utils.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c
b/drivers
Found by coverity scan.
Fixes: 7906661edac6 ("net/atlantic: add b0 hardware layer")
Coverity issue: 323512
Signed-off-by: Igor Russkikh
---
drivers/net/atlantic/hw_atl/hw_atl_b0.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/atlantic/hw_atl/hw_a
1 - 100 of 264 matches
Mail list logo
