[PATCH v3 3/3] net/enic: allow multicast in MAC address add callback

2024-08-09 Thread Hyong Youb Kim
unicast check in enic_set_mac_address(). Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_main.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index e59b0a5077..b755b15d92

[PATCH v3 2/3] net/enic: add speed capabilities for newer models

2024-08-09 Thread Hyong Youb Kim
Add 1400/14000 and 15000 models to the speed_capa list. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/nics/enic.rst | 3 ++- doc/guides/rel_notes/release_24_11.rst | 1 + drivers/net/enic/enic_ethdev.c | 21 + 3 files changed

[PATCH v3 1/3] net/enic: support SR-IOV VF using admin channel

2024-08-09 Thread Hyong Youb Kim
pport only VF_CAPABILITY_REQUEST message or not support the admin channel at all. When the VF driver detects such PF driver, it reverts to the compatibility mode and does not use the admin channel. In this mode, trust mode (e.g. enabling promiscuous mode) does not work. Signed-off-by: Hyong You

[PATCH v3 0/3] net/enic: support VF and fix minor issues

2024-08-09 Thread Hyong Youb Kim
Hyong Youb Kim (3): net/enic: support SR-IOV VF using admin channel net/enic: add speed capabilities for newer models net/enic: allow multicast in MAC address add callback doc/guides/nics/enic.rst | 123 ++-- doc/guides/rel_notes/release_24_11.rst | 5 + drivers/net/enic

RE: [PATCH v2 3/3] net/enic: allow multicast in MAC address add callback

2024-08-08 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, August 8, 2024 5:51 PM > To: Hyong Youb Kim (hyonkim) > Cc: dev@dpdk.org; John Daley (johndale) > Subject: Re: [PATCH v2 3/3] net/enic: allow multicast in MAC address add > callback > > On 8/8/2

RE: [PATCH v2 2/3] net/enic: add speed capabilities for newer models

2024-08-08 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, August 8, 2024 5:51 PM > To: Hyong Youb Kim (hyonkim) > Cc: dev@dpdk.org; John Daley (johndale) > Subject: Re: [PATCH v2 2/3] net/enic: add speed capabilities for newer models > > On 8/8/2024 7:14

RE: [PATCH v2 1/3] net/enic: support SR-IOV VF using admin channel

2024-08-08 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, August 8, 2024 5:50 PM > To: Hyong Youb Kim (hyonkim) > Cc: dev@dpdk.org; John Daley (johndale) > Subject: Re: [PATCH v2 1/3] net/enic: support SR-IOV VF using admin channel > > On 8/8/2024 7:14

[PATCH v2 3/3] net/enic: allow multicast in MAC address add callback

2024-08-07 Thread Hyong Youb Kim
unicast check in enic_set_mac_address(). Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_main.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index e59b0a5077..b755b15d92

[PATCH v2 2/3] net/enic: add speed capabilities for newer models

2024-08-07 Thread Hyong Youb Kim
Add 1400/14000 and 15000 models to the speed_capa list. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_ethdev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c index

[PATCH v2 1/3] net/enic: support SR-IOV VF using admin channel

2024-08-07 Thread Hyong Youb Kim
pport only VF_CAPABILITY_REQUEST message or not support the admin channel at all. When the VF driver detects such PF driver, it reverts to the compatibility mode and does not use the admin channel. In this mode, trust mode (e.g. enabling promiscuous mode) does not work. Signed-off-by: Hyong You

[PATCH v2 0/3] net/enic: support VF and fix minor issues

2024-08-07 Thread Hyong Youb Kim
This series contains minor updates for net/enic. The first patch supports SR-IOV VF, which now requires the use of admin channel. The other patches are not related to VF, but included here to ease review. --- v2: * fix compiler warnings Hyong Youb Kim (3): net/enic: support SR-IOV VF using

[PATCH 3/3] net/enic: allow multicast in MAC address add callback

2024-08-07 Thread Hyong Youb Kim
unicast check in enic_set_mac_address(). Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_main.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index e59b0a5077..b755b15d92

[PATCH 2/3] net/enic: add speed capabilities for newer models

2024-08-07 Thread Hyong Youb Kim
Add 1400/14000 and 15000 models to the speed_capa list. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_ethdev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c index

[PATCH 1/3] net/enic: support SR-IOV VF using admin channel

2024-08-07 Thread Hyong Youb Kim
pport only VF_CAPABILITY_REQUEST message or not support the admin channel at all. When the VF driver detects such PF driver, it reverts to the compatibility mode and does not use the admin channel. In this mode, trust mode (e.g. enabling promiscuous mode) does not work. Signed-off-by: Hyong You

[PATCH 0/3] net/enic: support VF and fix minor issues

2024-08-07 Thread Hyong Youb Kim
This series contains minor updates for net/enic. The first patch supports SR-IOV VF, which now requires the use of admin channel. The other patches are not related to VF, but included here to ease review. Hyong Youb Kim (3): net/enic: support SR-IOV VF using admin channel net/enic: add speed

RE: [PATCH 08/33] doc: update enic guide

2023-03-21 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, March 22, 2023 8:59 AM > To: John McNamara ; John Daley (johndale) > ; Hyong Youb Kim (hyonkim) > Cc: Thomas Monjalon ; Andrew Rybchenko > ; dev@dpdk.org > Subject: [PATCH 08/33] doc: update enic guid

[PATCH v2] net/enic: support GENEVE flow item

2022-01-20 Thread Hyong Youb Kim
Recent VIC models can parse GENEVE, including options, and inner packet headers. Enable GENEVE header and option flow items. Currently, only the first option that follows the GENEVE header can be matched, and the GENEVE header item must specify option length. Signed-off-by: Hyong Youb Kim

[PATCH] net/enic: support GENEVE flow item

2022-01-02 Thread Hyong Youb Kim
Recent VIC models can parse GENEVE, including options, and inner packet headers. Enable GENEVE header and option flow items. Currently, only the first option that follows the GENEVE header can be matched, and the GENEVE header item must specify option length. Signed-off-by: Hyong Youb Kim

Re: [dpdk-dev] [PATCH v4 3/6] net: advertise no support for keeping flow rules

2021-10-27 Thread Hyong Youb Kim (hyonkim)
Suggested-by: Ferruh Yigit > Signed-off-by: Dmitry Kozlyuk > --- For net/enic, Acked-by: Hyong Youb Kim -Hyong

[dpdk-dev] [PATCH] net/enic: fix unwanted error message

2021-10-25 Thread Hyong Youb Kim
advanced filtering is a prerequisite, check first if it is available and avoid the error message altogether. Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager API") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net

[dpdk-dev] [PATCH] net/enic: fix segfault caused by changing MTU

2021-10-25 Thread Hyong Youb Kim
e real Rx handler, not the dummy one set by (2). And, (3) causes a segfault in the real Rx handler (e.g. dereferencing freed structures). Fix the segfault by updating the fast-path pointer as well. Fixes: c87d435a4d79 ("ethdev: copy fast-path API into separate structure") Signed-off-b

Re: [dpdk-dev] [PATCH v4 5/7] drivers: remove direct access to interrupt handle

2021-10-19 Thread Hyong Youb Kim (hyonkim)
set APIs for the same. > Making changes to all the drivers and libraries access the > interrupt handle fields. > > Signed-off-by: Harman Kalra > --- For net/enic, Acked-by: Hyong Youb Kim Thanks. -Hyong

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: fix max Rx packet length

2021-10-14 Thread Hyong Youb Kim (hyonkim)
clarification done on scattered Rx configuration, in > relation to MTU and Rx buffer size. > MTU is used to configure the device for physical Rx/Tx size limitation, > Rx buffer is where to store Rx packets, many PMDs use mbuf data buffer > size as Rx buffer size. > PMDs compare MTU against Rx buffer size to decide enabling scattered Rx > or not. If scattered Rx is not supported by device, MTU bigger than Rx > buffer size should fail. > > Signed-off-by: Ferruh Yigit > Acked-by: Ajit Khaparde > Acked-by: Somnath Kotur > Acked-by: Huisong Li > --- For net/enic, Acked-by: Hyong Youb Kim Thanks. -Hyong

[dpdk-dev] [PATCH] net/enic: fix filter mode detection

2021-10-12 Thread Hyong Youb Kim
. So, treat ERR_EPERM as "no filtering available" instead of an unexpected error. Fixes: 322b355f2183 ("net/enic/base: bring NIC interface functions up to date") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/base/vnic_dev.c

Re: [dpdk-dev] [PATCH v5 3/7] ethdev: change input parameters for rx_queue_count

2021-10-12 Thread Hyong Youb Kim (hyonkim)
) to accept pointer to internal > queue data as input parameter. > While this change is transparent to user, it still counts as an ABI change, > as eth_rx_queue_count_t is used by ethdev public inline function > rte_eth_rx_queue_count(). > > Signed-off-by: Konstantin Ananyev

Re: [dpdk-dev] [PATCH v6 4/6] ethdev: remove jumbo offload flag

2021-10-12 Thread Hyong Youb Kim (hyonkim)
mtu' to > 'RTE_ETHER_MTU'. > > Removing this additional configuration for simplification. > > Suggested-by: Konstantin Ananyev > Signed-off-by: Ferruh Yigit > Acked-by: Andrew Rybchenko > Reviewed-by: Rosen Xu > Acked-by: Somnath Kotur > Acked-by: Konstantin Ananyev > Acked-by: Huisong Li > --- For net/enic, Acked-by: Hyong Youb Kim Thanks. -Hyong

Re: [dpdk-dev] [PATCH v3 09/12] net/enic: support meta flow actions to overrule destinations

2021-10-12 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Ivan Malov > Sent: Sunday, October 10, 2021 11:39 PM > To: dev@dpdk.org > Cc: Thomas Monjalon ; Ori Kam > ; Andrew Rybchenko > ; John Daley (johndale) > ; Hyong Youb Kim (hyonkim) > Subject: [PATCH v3 09/12] net/enic: support me

Re: [dpdk-dev] [PATCH v6 1/9] ethdev: introduce representor type

2021-02-14 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Xueming Li > Sent: Sunday, February 14, 2021 12:22 PM > Cc: dev@dpdk.org; Viacheslav Ovsiienko ; > xuemi...@nvidia.com; Asaf Penso ; Ajit Khaparde > ; Somnath Kotur > ; John Daley (johndale) > ; Hyong Youb Kim (hyonkim) ; > Beil

[dpdk-dev] [PATCH] net/enic: fix a typo in debug message

2021-02-04 Thread Hyong Youb Kim
A debug message for filter API is using a wrong flag. Use the correct one. Fixes: 936a9b9975e7 ("net/enic: flow API debug") Cc: sta...@dpdk.org Reported-by: Hanoch Haim Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_flow.c | 2 +- 1 file changed, 1

[dpdk-dev] [PATCH] net/enic: fix the filter type used for flow API

2021-02-01 Thread Hyong Youb Kim
director implementation (enic_clsf.c). Fixes: 26faa126d87e ("net/enic: flow API for NICs with advanced filters disabled") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/d

[dpdk-dev] [PATCH] net/enic: use 64B completion queue entries if available

2021-01-07 Thread Hyong Youb Kim
DDIO. As most UCS servers are based on Intel platforms, enable and use 64B CQ entries by default, if available. Also, add devarg 'cq64' so the user can explicitly disable 64B CQ. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/nics/enic.rst

[dpdk-dev] [PATCH] net/enic: fix header sizes when copying flow patterns

2020-10-30 Thread Hyong Youb Kim
(rte_ether_hdr) and sizeof(rte_ipv6_hdr) instead. Coverity issue: 363572, 363573 Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager API") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_fm_flow.c | 10 +++

Re: [dpdk-dev] [PATCH v2 12/14] ethdev: remove legacy FDIR filter type support

2020-10-22 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, October 22, 2020 6:43 PM > To: Wenzhuo Lu ; Beilei Xing > ; Bernard Iremonger > ; Jeff Guo ; Ray Kinsella > ; Neil Horman ; Ajit Khaparde > ; Somnath Kotur > ; John Daley (johndale) > ; Hyong

Re: [dpdk-dev] [PATCH v6 03/14] doc: remove references to make from NICs guides

2020-10-11 Thread Hyong Youb Kim (hyonkim)
vers can be disabled using the > -configuration file in config/ directory (e.g., config/common_linux). > This would help in bringing down the time taken for building the > libraries and the initialization time of the application. > Hi, Could you remove the remaining two lines as well ("This would ... application.")? For enic, Acked-by: Hyong Youb Kim Thanks. -Hyong

[dpdk-dev] [PATCH] bus/pci: fix mapping BAR containing MSI-X table

2020-09-24 Thread Hyong Youb Kim
D: 539 Fixes: e200535c1ca3 ("mem: drop mapping API workaround") Signed-off-by: Hyong Youb Kim --- drivers/bus/pci/linux/pci_vfio.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c

[dpdk-dev] [PATCH 6/6] net/enic: support VXLAN decap action combined with VLAN pop

2020-09-09 Thread Hyong Youb Kim
Flow Manager (flowman) provides DECAP_STRIP operation which decapsulates VXLAN header and then removes VLAN header from the inner packet. Use this operation to support vxlan_decap followed by of_pop_vlan. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/rel_notes

[dpdk-dev] [PATCH 4/6] net/enic: ignore vlan inner type when it is zero

2020-09-09 Thread Hyong Youb Kim
byproduct, the driver can support the usage like the above. Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager API") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_fm_flow.c | 13 + 1 file ch

[dpdk-dev] [PATCH 5/6] net/enic: generate VXLAN source port if it is zero in template

2020-09-09 Thread Hyong Youb Kim
transmitting packets with source port 0. Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager API") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_fm_flow.c | 21 + 1 file changed, 21

[dpdk-dev] [PATCH 3/6] net/enic: support priorities for TCAM flows

2020-09-09 Thread Hyong Youb Kim
Group 0 corresponds to TCAM which supports priorities. Accept non-zero priorities for group 0 flows. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/rel_notes/release_20_11.rst | 1 + drivers/net/enic/enic_fm_flow.c| 10 ++ 2 files changed, 7 insertions

[dpdk-dev] [PATCH 2/6] net/enic: support egress PORT_ID action

2020-09-09 Thread Hyong Youb Kim
Use Flow Manager (flowman) to support egress PORT_ID action. It can steer egress packets from PFs and VFs to any uplink port as long as they are all on the same VIC adapter. It can also steer packets between ports on the same VIC adapter (i.e. loopback). Signed-off-by: Hyong Youb Kim Reviewed-by

[dpdk-dev] [PATCH 1/6] net/enic: remove obsolete code

2020-09-09 Thread Hyong Youb Kim
The 'next' field in struct enic is unused. The comment in enic_cq_rq() is out-of-date. Remove them. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/en

[dpdk-dev] [PATCH 0/6] net/enic: minor updates to flow implementation

2020-09-09 Thread Hyong Youb Kim
.. -Hyong Hyong Youb Kim (6): net/enic: remove obsolete code net/enic: support egress PORT_ID action net/enic: support priorities for TCAM flows net/enic: ignore vlan inner type when it is zero net/enic: generate VXLAN source port if it is zero in template net/enic: support VXLAN decap

[dpdk-dev] [PATCH 5/5] net/enic: enable flow API for VF representor

2020-09-09 Thread Hyong Youb Kim
flowman to create internal flows for implicit VF-representor path. With that, representor Tx/Rx is now functional. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/rel_notes/release_20_11.rst | 4 + drivers/net/enic/enic_vf_representor.c | 160 + 2 fil

[dpdk-dev] [PATCH 4/5] net/enic: extend flow handler to support VF representors

2020-09-09 Thread Hyong Youb Kim
_flow() - enic_fm_add_vf2rep_flow() The flows created for representor paths are marked as internal. These are not visible to application, and the flush API does not destroy them. They are automatically deleted when the representor port stops (enic_fm_destroy). Signed-off-by: Hyong Youb Kim Review

[dpdk-dev] [PATCH 3/5] net/enic: add single-queue Tx and Rx to VF representor

2020-09-09 Thread Hyong Youb Kim
A VF representor allocates queues from PF's pool of queues and use them for its Tx and Rx. It supports 1 Tx queue and 1 Rx queue. Implicit packet forwarding between representor queues and VF does not yet exist. It will be enabled in subsequent commits using flowman API. Signed-off-by: Hyong

[dpdk-dev] [PATCH 2/5] net/enic: add minimal VF representor

2020-09-09 Thread Hyong Youb Kim
a vnic_dev lock to serialize concurrent devcmd calls PF and VF representor ports may invoke devcmd (e.g. dump stats) simultaneously. As they all share a single PF devcmd instance in the firmware, use a lock to serialize devcmd calls. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- d

[dpdk-dev] [PATCH 0/5] net/enic: add SR-IOV VF representor

2020-09-09 Thread Hyong Youb Kim
PF Tx/Rx queues for their implicit paths to/from VFs. Packet forwarding rules for these implicit paths are set up using firmware's Flow Manager (flowman), which is also used for rte_flow API. Thanks. -Hyong Hyong Youb Kim (5): net/enic: extend vnic dev API for VF representors net/enic

[dpdk-dev] [PATCH 1/5] net/enic: extend vnic dev API for VF representors

2020-09-09 Thread Hyong Youb Kim
UIF number (uplink index), respectively. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/base/vnic_dev.c | 112 ++- drivers/net/enic/base/vnic_dev.h | 4 ++ 2 files changed, 113 insertions(+), 3 deletions(-) diff --git a/drivers/net/enic

Re: [dpdk-dev] [PATCH 20.11 06/12] net/enic: add checks for max SIMD bitwidth

2020-08-09 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Ciara Power > Sent: Saturday, August 8, 2020 12:59 AM > To: dev@dpdk.org > Cc: bruce.richard...@intel.com; Ciara Power ; > John Daley (johndale) ; Hyong Youb Kim (hyonkim) > > Subject: [PATCH 20.11 06/12] net/enic: add checks for max

[dpdk-dev] [PATCH 2/2] net/enic: add new flow manager actions to the dump function

2020-07-02 Thread Hyong Youb Kim
The following commit introduced several new actions. Make the dump function to print those actions. commit 6faf81f1d2c3 ("net/enic: update flow manager API") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_fm_flow.c | 7 +++ 1 file changed, 7

[dpdk-dev] [PATCH 1/2] net/enic: support VLAN push and pop flow actions

2020-07-02 Thread Hyong Youb Kim
Flow manager API includes push/pop actions, so support corresponding DPDK flow actions. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/rel_notes/release_20_08.rst | 3 ++ drivers/net/enic/enic_fm_flow.c| 61 ++ 2 files changed, 64

[dpdk-dev] [PATCH 0/2] net/enic: minor flow manager changes

2020-07-02 Thread Hyong Youb Kim
Youb Kim (2): net/enic: support VLAN push and pop flow actions net/enic: add new flow manager actions to the dump function doc/guides/rel_notes/release_20_08.rst | 3 ++ drivers/net/enic/enic_fm_flow.c| 68 ++ 2 files changed, 71 insertions(+) -- 2.26.2

[dpdk-dev] [PATCH] net/enic: support burst mode info

2020-07-01 Thread Hyong Youb Kim
Add Rx/Tx burst mode getter handlers. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/nics/features/enic.ini | 1 + drivers/net/enic/enic.h | 1 + drivers/net/enic/enic_ethdev.c| 45 +++ drivers/net/enic

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-21 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Wei Hu (Xavier) > Sent: Monday, June 22, 2020 11:47 AM > To: tho...@monjalon.net; ferruh.yi...@intel.com; > arybche...@solarflare.com; anatoly.bura...@intel.com; > hemant.agra...@nxp.com; sachin.sax...@nxp.com; John Daley (johndale) > ; Hy

Re: [dpdk-dev] [PATCH v2] log: add API to check if a logtype can log in a given level

2020-03-03 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, March 4, 2020 3:18 AM > To: Hemant Agrawal ; Sachin Saxena > ; Fiona Trahe ; John > Griffin ; Deepak Kumar Jain > ; John Daley (johndale) ; > Hyong Youb Kim (hyonkim) ; Alfredo Cardigliano > ; Ma

Re: [dpdk-dev] [PATCH] net: replace IP VHL DEF macro with RTE IPV4 VHL DEF

2019-11-14 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 14, 2019 10:09 AM > To: John Daley (johndale) ; Hyong Youb Kim (hyonkim) > > Cc: Reshma Pattan ; dev@dpdk.org; > xiaoyun...@intel.com; Bernard Iremonger ; > David Harton (dharton) > Subject:

[dpdk-dev] [PATCH v2] net/enic: re-enable link status change interrupt

2019-11-07 Thread Hyong Youb Kim
, to re-enable INTx. Fixes: fefed3d1e62c ("enic: new driver") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- v2: spell out experimental APIs used drivers/net/enic/Makefile| 2 ++ drivers/net/enic/enic_main.c | 2 ++ drivers/net/enic/meson.build | 2 +

[dpdk-dev] [PATCH] net/enic: re-enable link status change interrupt

2019-11-01 Thread Hyong Youb Kim
, to re-enable INTx. Fixes: fefed3d1e62c ("enic: new driver") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/Makefile| 1 + drivers/net/enic/enic_main.c | 2 ++ drivers/net/enic/meson.build | 1 + 3 files changed, 4 insertions(+) di

[dpdk-dev] [PATCH 0/3] net/enic: fixes for cosmetic issues

2019-10-30 Thread Hyong Youb Kim
These patches fix 3 cosmetic issues discovered during rc1 testing. For example, removing useless/misleading error messages and adding a space in log messages. Thanks. -Hyong Hyong Youb Kim (3): net/enic: fix whitespaces in log macros net/enic: fix speed capabilities for the new VF net/enic

[dpdk-dev] [PATCH 2/3] net/enic: fix speed capabilities for the new VF

2019-10-30 Thread Hyong Youb Kim
VFs all have subsystem ID 0. VIC models with the latest VF are at least 40G, so report that as a more reasonable speed than 10G. Fixes: 57bb45b37bdf ("net/enic: add PCI id for new virtual function") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_et

[dpdk-dev] [PATCH 1/3] net/enic: fix whitespaces in log macros

2019-10-30 Thread Hyong Youb Kim
Add a space between the function name and message. Fixes: bbd8ecc05434 ("net/enic: remove PMD log type references") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_compat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH 3/3] net/enic: suppress unwanted error messages

2019-10-30 Thread Hyong Youb Kim
feature is provisioned but not enabled. Fixes: c02a96fc4aec ("net/enic: enable GENEVE with options offload") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/base/vnic_dev.c | 4 +++- drivers/net/enic/enic_main.c | 11 +++ 2 files changed, 10 insert

Re: [dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead of ARRAY_SIZE

2019-10-11 Thread Hyong Youb Kim (hyonkim)
_CMD_N(cmd) (((cmd) >> _CMD_NSHIFT) & _CMD_NMASK) > > -#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) > - > enum vnic_devcmd_cmd { > CMD_NONE= _CMDC(_CMD_DIR_NONE, > _CMD_VTYPE_NONE, 0), > [...] For enic. Acked-by: Hyong Youb Kim Thanks. -Hyong

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] net/enic: restrict several handlers to primary process

2019-10-09 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 9, 2019 6:28 PM > To: Hyong Youb Kim (hyonkim) > Cc: dev@dpdk.org; John Daley (johndale) ; Dirk- > Holger Lenz ; sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH 1/3] net/enic: restrict several

Re: [dpdk-dev] [PATCH 1/3] net/enic: restrict several handlers to primary process

2019-10-09 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 9, 2019 5:02 PM > To: Hyong Youb Kim (hyonkim) > Cc: dev@dpdk.org; John Daley (johndale) ; Dirk- > Holger Lenz ; sta...@dpdk.org > Subject: Re: [PATCH 1/3] net/enic: restrict several handlers

[dpdk-dev] [PATCH v2 2/2] net/enic: add flow implementation based on Flow Manager API

2019-09-23 Thread Hyong Youb Kim
and exact match tables. Add the new flow implementation using Flow Manager and use it when available. When Flow Manager is not available, the driver will continue to use the old filter-based flow implementation. Signed-off-by: John Daley Signed-off-by: Hyong Youb Kim --- doc/guides/nics/enic.rst

[dpdk-dev] [PATCH v2 1/2] net/enic: enable Geneve with options offload

2019-09-23 Thread Hyong Youb Kim
ned-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/nics/enic.rst | 12 doc/guides/rel_notes/release_19_11.rst | 4 drivers/net/enic/base/vnic_dev.c | 11 +++ drivers/net/enic/base/vnic_dev.h | 1 + drivers/net/enic/base/vnic_devcmd

[dpdk-dev] [PATCH v2 0/2] net/enic: a couple new features

2019-09-23 Thread Hyong Youb Kim
was missing in v1 Hyong Youb Kim (2): net/enic: enable Geneve with options offload net/enic: add flow implementation based on Flow Manager API doc/guides/nics/enic.rst | 21 + doc/guides/rel_notes/release_19_11.rst |5 + drivers/net/enic/Makefile |1

Re: [dpdk-dev] [PATCH 4/7] ethdev: change allmulticast callbacks to return status

2019-09-16 Thread Hyong Youb Kim (hyonkim)
> +static int enicpmd_dev_allmulticast_disable(struct rte_eth_dev *eth_dev) > { > struct enic *enic = pmd_priv(eth_dev); > + int ret; > > if (rte_eal_process_type() != RTE_PROC_PRIMARY) > - return; > + return -ENOTSUP; Here

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-15 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Andrew Rybchenko > Sent: Saturday, September 14, 2019 6:07 AM [...] > Subject: Re: [PATCH v2 04/13] ethdev: change promiscuous callbacks to > return status > > On 9/11/19 11:46 AM, Hyong Youb Kim (hyonkim) wrote: > >> -O

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-11 Thread Hyong Youb Kim (hyonkim)
ble); > } > > -void enic_add_packet_filter(struct enic *enic) > +int enic_add_packet_filter(struct enic *enic) > { > /* Args -> directed, multicast, broadcast, promisc, allmulti */ > - vnic_dev_packet_filter(enic->vdev, 1, 1, 1, > + return vnic_dev_packet_filter(enic->vdev, 1, 1, 1, > enic->promisc, enic->allmulti); > } > A couple minor comments above. Other than those, patch works fine for enic. Feel free to add my ack on v2.. Acked-by: Hyong Youb Kim Thanks. -Hyong

[dpdk-dev] [PATCH 2/2] net/enic: add flow implementation based on Flow Manager API

2019-09-10 Thread Hyong Youb Kim
and exact match tables. Add the new flow implementation using Flow Manager and use it when available. When Flow Manager is not available, the driver will continue to use the old filter-based flow implementation. Signed-off-by: John Daley Signed-off-by: Hyong Youb Kim --- doc/guides/nics/enic.rst

[dpdk-dev] [PATCH 1/2] net/enic: enable Geneve with options offload

2019-09-10 Thread Hyong Youb Kim
ned-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/nics/enic.rst | 12 doc/guides/rel_notes/release_19_11.rst | 4 drivers/net/enic/base/vnic_dev.c | 11 +++ drivers/net/enic/base/vnic_dev.h | 1 + drivers/net/enic/base/vnic_devcmd

[dpdk-dev] [PATCH 0/2] net/enic: a couple new features

2019-09-10 Thread Hyong Youb Kim
one patch. checkpatches complains about these errors. We checked and found it safe to ignore them (false positives). CHECK:CAMELCASE: Avoid CamelCase: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses Thanks. -Hyong Hyong Youb Kim (2): net/enic: enable Geneve

[dpdk-dev] [PATCH 3/3] net/enic: fix crash in secondary process

2019-09-05 Thread Hyong Youb Kim
pdk.org Reported-by: Dirk-Holger Lenz Signed-off-by: Hyong Youb Kim Tested-by: Dirk-Holger Lenz Reviewed-by: John Daley --- drivers/net/enic/enic.h| 3 ++- drivers/net/enic/enic_ethdev.c | 5 ++--- drivers/net/enic/enic_main.c | 22 +++--- 3 files changed,

[dpdk-dev] [PATCH 2/3] net/enic: fix two issues in probe for secondary process

2019-09-05 Thread Hyong Youb Kim
;) Cc: sta...@dpdk.org Reported-by: Dirk-Holger Lenz Signed-off-by: Hyong Youb Kim Tested-by: Dirk-Holger Lenz Reviewed-by: John Daley --- drivers/net/enic/enic.h | 5 - drivers/net/enic/enic_ethdev.c| 10 -- drivers/net/enic/enic_main.c

[dpdk-dev] [PATCH 1/3] net/enic: restrict several handlers to primary process

2019-09-05 Thread Hyong Youb Kim
pport multicast filtering") Fixes: 8a4efd17410c ("net/enic: add handlers to add/delete vxlan port number") Cc: sta...@dpdk.org Reported-by: Dirk-Holger Lenz Signed-off-by: Hyong Youb Kim Tested-by: Dirk-Holger Lenz Reviewed-by: John Daley --- drivers/net/enic/enic_ethdev.c | 12 ++

[dpdk-dev] [PATCH 0/3] net/enic: fix multi-process isseus

2019-09-05 Thread Hyong Youb Kim
original email thread. http://mails.dpdk.org/archives/dev/2019-August/141560.html This series replaces the earlier one. http://patches.dpdk.org/patch/58033/ Thanks. -Hyong Hyong Youb Kim (3): net/enic: restrict several handlers to primary process net/enic: fix two issues in probe for secondary

Re: [dpdk-dev] [PATCH 1/1] net/enic: enic driver doesn't work with 2nd process

2019-09-01 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: dev On Behalf Of dirk > Sent: Tuesday, August 27, 2019 6:03 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/1] net/enic: enic driver doesn't work with 2nd > process > > net/enic: enic driver doesn't work with 2nd process. the problem is that the > private

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-25 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: John Daley (johndale) > Sent: Friday, July 26, 2019 5:26 AM > To: Ferruh Yigit > Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim) > Subject: RE: [PATCH] net/enic: retain previous message logging > > Ok, lets NAK this patch. See comment

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/3] eal: add ack interrupt API

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Nithin Kumar Dabilpuram > Sent: Wednesday, July 17, 2019 11:36 PM [...] > > > Subject: [PATCH v2 2/3] eal: add ack interrupt API > > > > > > Add new ack interrupt API to avoid using > > > VFIO_IRQ_SET_ACTION_TRIGGER(rte_intr_enable()) for > > > acking interrupt

Re: [dpdk-dev] [PATCH v2 2/3] eal: add ack interrupt API

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Nithin Dabilpuram > Sent: Wednesday, July 17, 2019 9:44 PM > To: Hyong Youb Kim (hyonkim) ; David Marchand > ; Thomas Monjalon > ; Ferruh Yigit ; Bruce > Richardson > Cc: jer...@marvell.com; John Daley (johndale) ; > Shahed Sh

Re: [dpdk-dev] [PATCH 3/3] drivers/net: use ack API in interrupt handlers

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Nithin Dabilpuram > Sent: Wednesday, July 17, 2019 8:59 PM [...] > Subject: [PATCH 3/3] drivers/net: use ack API in interrupt handlers > > Replace rte_intr_enable() with rte_intr_ack() API > for acking an interrupt in interrupt handlers and > rx_queue_intr_ena

Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Wednesday, July 17, 2019 7:44 PM > To: Hyong Youb Kim (hyonkim) ; Nithin Kumar > Dabilpuram ; David Marchand > ; Thomas Monjalon > ; Ferruh Yigit ; Bruce > Richardson > Cc: John Daley (johnda

Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Wednesday, July 17, 2019 6:21 PM > To: Hyong Youb Kim (hyonkim) ; Nithin Kumar > Dabilpuram ; David Marchand > ; Thomas Monjalon > ; Ferruh Yigit ; Bruce > Richardson > Cc: John Daley (johnda

Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Wednesday, July 17, 2019 5:03 PM > To: Hyong Youb Kim (hyonkim) ; Nithin Kumar > Dabilpuram ; David Marchand > ; Thomas Monjalon > ; Ferruh Yigit ; Bruce > Richardson > Cc: John Daley (johnda

Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Wednesday, July 17, 2019 3:15 PM > To: Hyong Youb Kim (hyonkim) ; Nithin Kumar > Dabilpuram ; David Marchand > ; Thomas Monjalon > ; Ferruh Yigit ; Bruce > Richardson > Cc: John Daley (johnda

Re: [dpdk-dev] [RFC PATCH v3 3/3] drivers/net: use unmask API in interrupt handlers

2019-07-16 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Nithin Dabilpuram > Sent: Wednesday, July 17, 2019 1:44 AM [...] > Subject: [RFC PATCH v3 3/3] drivers/net: use unmask API in interrupt > handlers > > Replace rte_intr_enable() with rte_intr_unmask() API > for unmasking in interrupt handlers and rx_queue_intr_

Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-16 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Nithin Dabilpuram > Sent: Wednesday, July 17, 2019 1:44 AM > To: Hyong Youb Kim (hyonkim) ; David Marchand > ; Thomas Monjalon > ; Ferruh Yigit ; Bruce > Richardson > Cc: jer...@marvell.com; John Daley (johndale) ; > Shahed Sh

Re: [dpdk-dev] [RFC PATCH] vfio: avoid re-installing irq handler

2019-07-16 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Jerin Jacob Kollanukkaran [...] > > > > A rough patch for the approach mentioned earlier. It is only for > > discussion. > > > > http://mails.dpdk.org/archives/dev/2019-July/138113.html > > > > > > > > To try this out, first revert the following then apply. >

Re: [dpdk-dev] [RFC PATCH] vfio: avoid re-installing irq handler

2019-07-15 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Tuesday, July 16, 2019 1:51 AM > To: Hyong Youb Kim (hyonkim) ; David Marchand > ; Thomas Monjalon > ; Ferruh Yigit > Cc: dev@dpdk.org; John Daley (johndale) ; Shahed > Shaikh ; Nithin Kumar Dabilpura

[dpdk-dev] [RFC PATCH] vfio: avoid re-installing irq handler

2019-07-15 Thread Hyong Youb Kim
A rough patch for the approach mentioned earlier. It is only for discussion. http://mails.dpdk.org/archives/dev/2019-July/138113.html To try this out, first revert the following then apply. commit 89aac60e0be9 ("vfio: fix interrupts race condition") Signed-off-by: Hyong Youb Kim ---

Re: [dpdk-dev] [PATCH] vfio: fix interrupts race condition

2019-07-15 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Monday, July 15, 2019 2:35 PM [...] > Subject: RE: [dpdk-dev] [PATCH] vfio: fix interrupts race condition > > > > > > > > > This is a real bug which should be fixed in this release. > > > > As the patch is quite big and needs

Re: [dpdk-dev] [PATCH] vfio: fix interrupts race condition

2019-07-13 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, July 11, 2019 6:21 AM [...] > Subject: Re: [dpdk-dev] [PATCH] vfio: fix interrupts race condition > > 10/07/2019 14:33, David Marchand: > > Populating the eventfd in rte_intr_enable in each request to vfio > > triggers a recon

[dpdk-dev] [PATCH 4/4] net/enic: remove locks from rte flow code

2019-06-06 Thread Hyong Youb Kim
From: John Daley There is no requirement for thread safety in the flow PMD code and no need for the locks. Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled") Cc: sta...@dpdk.org Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/net/e

[dpdk-dev] [PATCH 3/4] net/enic: remove support for flow count action

2019-06-06 Thread Hyong Youb Kim
flow counter action") commit 1b4ce87dc5e6 ("net/enic: fix counter action") Cc: sta...@dpdk.org Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- doc/guides/nics/enic.rst| 6 -- drivers/net/enic/base/vnic_dev.c| 105 -- drivers/net/

[dpdk-dev] [PATCH 2/4] net/enic: report speed capabilities

2019-06-06 Thread Hyong Youb Kim
Available link speeds are based on VIC adapter model, which is encoded in PCI subsystem device ID. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/nics/features/enic.ini | 1 + drivers/net/enic/enic_ethdev.c| 51 +++ 2 files changed

[dpdk-dev] [PATCH 1/4] net/enic: set min and max MTU

2019-06-06 Thread Hyong Youb Kim
These values correspond to those used in the MTU handler (enic_set_mtu). Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c index

[dpdk-dev] [PATCH 0/4] net/enic: minor updates

2019-06-06 Thread Hyong Youb Kim
The first two patches report the min/max MTU and speed capabilities to support applications that rely on them. The other two patches remove unnecessary/unsupported code from the flow implementation. We do not expect more patches for 19.08. Hyong Youb Kim (2): net/enic: set min and max MTU net

[dpdk-dev] [PATCH] net/enic: fix VLAN inner type matching for older hardware

2019-04-09 Thread Hyong Youb Kim
shifted by that much. Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_flow.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) di

  1   2   >