On 22/07/2024 21:15, Stephen Hemminger wrote:
The number of uncore frequencies was defined in three places,
and two of them were too small leading to test failures.
All places should be using RTE_MAX_UNCORE_FREQS.
Bugzilla ID: 1499
Fixes: 60b8a661a957 ("power: add Intel uncore frequency control
On 20/07/2024 17:50, Sivaprasad Tummala wrote:
This patch introduces driver support for power management of uncore
components in AMD EPYC processors.
Signed-off-by: Sivaprasad Tummala
---
drivers/power/amd_uncore/amd_uncore.c | 321 ++
drivers/power/amd_uncore/amd_u
On 20/07/2024 17:50, Sivaprasad Tummala wrote:
This patch refactors the power management library, addressing uncore
power management. The primary changes involve the creation of dedicated
directories for each driver within 'drivers/power/uncore/*'. The
adjustment of meson.build files enables the
Hi Sivaprasad,
A couple of comments below:
On 20/07/2024 17:50, Sivaprasad Tummala wrote:
This patch introduces a comprehensive refactor to the core power
management library. The primary focus is on improving modularity
and organization by relocating specific driver implementations
from the 'li
On 20/07/2024 17:50, Sivaprasad Tummala wrote:
After refactoring the power library, power management operations are now
consistently supported regardless of the operating environment, making
function pointer checks unnecessary and thus removed from applications.
Signed-off-by: Sivaprasad Tummal
On 01/03/2024 02:56, lihuisong (C) wrote:
在 2024/2/20 23:33, Sivaprasad Tummala 写道:
This patch introduces a comprehensive refactor to the core power
management library. The primary focus is on improving modularity
and organization by relocating specific driver implementations
from the 'lib/po
On 11/12/2023 17:23, Stephen Hemminger wrote:
Be consistent for all the error printouts and use fprintf().
The EAL logtype is reserved for internal use by EAL.
Signed-off-by: Stephen Hemminger
---
examples/vm_power_manager/main.c | 11 ---
1 file changed, 4 insertions(+), 7 deletio
Hi Euan,
On 07/12/2023 16:18, Euan Bourke wrote:
Update to the l3fwd-power example application to call the arg parser
library for its 'combined core string parser' instead of implementing its
own corelist parser. The default_type passed into the function call is
a corelist.
Signed-off-by: Euan
Hi Sivaprasad, Karen,
On 27/10/2023 13:36, Kelly, Karen wrote:
On 26/10/2023 16:19, Sivaprasad Tummala wrote:
Updated the l3fwd-power app to configure the uncore env before invoking
any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is
too late because other APIs already cal
On 23/10/2023 05:27, Sivaprasad Tummala wrote:
Add co-maintainer for power library.
Signed-off-by: Sivaprasad Tummala
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
Thanks for the help, Sivaprasad.
Acked-by: David Hunt
On 19/10/2023 20:10, Stephen Hemminger wrote:
The power management API's were last changed in 22.11 release.
Therefore remove experimental for 23.11 release.
Signed-off-by: Stephen Hemminger
---
Acked-by: David Hunt
On 09/08/2023 01:10, Stephen Hemminger wrote:
The power management API's were last changed in 22.11 release.
Therefore remove experimental for 23.11 release.
Signed-off-by: Stephen Hemminger
---
Acked-by: David Hunt
On 15/06/2023 10:16, Anatoly Burakov wrote:
Add co-maintainer for power library.
Signed-off-by: Anatoly Burakov
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 906b31f97c..21c971a273 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1671,6 +
On 22/02/2023 16:07, Stephen Hemminger wrote:
Don't use static logtype in sample application.
Signed-off-by: Stephen Hemminger
---
examples/distributor/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/distributor/main.c b/examples/distributor/main.c
index
On 22/02/2023 16:07, Stephen Hemminger wrote:
Convert to using a dynamic logtype for the application.
Signed-off-by: Stephen Hemminger
---
examples/l3fwd-power/main.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/examples/l3fwd-power/main.c b/examples/
On 22/02/2023 16:07, Stephen Hemminger wrote:
Use dynamic log type for power library.
Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/power/guest_channel.c
On 15/02/2023 17:23, Stephen Hemminger wrote:
Use dynamic log type for power library.
Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h| 2 +-
lib/power/guest_channel.c
On 21/02/2023 19:01, Stephen Hemminger wrote:
Don't use static logtype in sample application.
Signed-off-by: Stephen Hemminger
---
examples/distributor/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/distributor/main.c b/examples/distributor/main.c
index
On 21/02/2023 19:01, Stephen Hemminger wrote:
Convert to using a dynamic logtype for the application.
Signed-off-by: Stephen Hemminger
---
examples/l3fwd-power/main.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/examples/l3fwd-power/main.c b/examples/
On 21/02/2023 19:01, Stephen Hemminger wrote:
Use dynamic log type for power library.
Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/power/guest_channel.c
On 22/02/2023 16:25, Stephen Hemminger wrote:
Found by doing duplicate word scan.
Signed-off-by: Stephen Hemminger
---
app/test/test_resource.c | 2 +-
lib/pipeline/rte_swx_ctl.c | 2 +-
lib/power/guest_channel.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/a
On 22/02/2023 16:25, Stephen Hemminger wrote:
Found by doing duplicate word scan.
Signed-off-by: Stephen Hemminger
---
drivers/net/bonding/rte_eth_bond_8023ad.h | 2 +-
examples/vm_power_manager/channel_monitor.h | 2 +-
examples/vm_power_manager/oob_monitor.h | 2 +-
3 files chang
On 22/02/2023 16:25, Stephen Hemminger wrote:
Found by doing duplicate word scan.
Signed-off-by: Stephen Hemminger
---
lib/distributor/rte_distributor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/distributor/rte_distributor.c
b/lib/distributor/rte_distributor.
On 22/02/2023 02:13, Jie Hai wrote:
Hi, David Hunt,
Kindly ping. Could you please take a look at this patch?
Thanks,
Jie Hai
On 2023/1/31 10:58, Jie Hai wrote:
Currently the l3fwd-power only supports ACPI cpufreq and Pstate
cpufreq, This patch adds CPPC cpufreq.
Signed-off-by: Jie Hai
On 20/12/2022 12:56, David Hunt wrote:
Remove calls to the experimental empty poll API. l3fwd-power
is the only app that uses this.
This API is no longer needed as it is superceded by the
monitor/pause/scale callback mechanism.
I did check the spelling against my spellchecker with checkpatc
On 06/10/2022 18:32, Stephen Hemminger wrote:
On Thu, 6 Oct 2022 09:38:01 +
Tadhg Kearney wrote:
Add API to allow uncore frequency adjustment. Uncore is a
term used by Intel to describe function of a microprocessor
that are closely connected to the core to achieve high
performance. This
Hi Tadhg,
On 28/09/2022 14:30, Tadhg Kearney wrote:
This is targeting 22.11 and aims to add an API to DPDK power library to allow
uncore frequency adjustment. This will be called through the l3fwd-power app
and gives the ability to set the minimum and maximum uncore frequency to both
min,
max o
Hi Tadhg,
On 28/09/2022 10:06, Tadhg Kearney wrote:
Add option for setting uncore frequency min/max/index, through uncore API.
This will be set for each package and die on the SKU. On exit, uncore min
and max frequency will be reverted back to previous frequencies.
Signed-off-by: Tadhg Kearney
Hi Tadhg,
On 20/09/2022 10:48, Tadhg Kearney wrote:
Add basic unit tests covering all nine uncore API's.
Signed-off-by: Tadhg Kearney
---
app/test/meson.build | 2 +
app/test/test_power_uncore.c | 299 +++
2 files changed, 301 insertions(+)
create
On 20/09/2022 10:48, Tadhg Kearney wrote:
Add API to allow uncore frequency adjustment. This is done through
manipulating related uncore frequency control sysfs entries to
adjust the minimum and maximum uncore frequency values.
Nine API's are being added that are all public and experimental.
S
On 20/09/2022 10:48, Tadhg Kearney wrote:
Add option for setting uncore frequency min/max/index, through uncore API.
This will be set for each package and die on the SKU. On exit, uncore min
and max frequency will be reverted back to previous frequencies.
Signed-off-by: Tadhg Kearney
---
..
Hi Tadhg,
On 13/07/2022 15:07, Tadhg Kearney wrote:
Add option for setting uncore frequency min/max/index, through uncore api.
This will be set for each package and die on the SKU. On exit, uncore
frequency will be reverted back to previous frequency.
Signed-off-by: Tadhg Kearney
---
.../sam
On 01/09/2022 15:09, omer.yamac at ceng.metu.edu.tr (Abdullah Ömer
Yamaç) wrote:
In this patch,
* It is possible to switch the running mode of the distributor
using the command line argument.
* With "-c" parameter, you can run RX and Distributor
on the same core.
* Without "-c"
On 02/09/2022 06:20, Omer Yamac wrote:
Hi David,
I applied the changes as new version (v3), Thank you
--snip--
With the above suggested changes to the commit message:
Reviewed-by: David Hunt
Hi Omer,
2 things:
Usually you submit subsequent versions of patches "in-reply-to" the
pre
Hi Ömer,
On 28/06/2022 20:54, omer.yamac at ceng.metu.edu.tr (Abdullah Ömer
Yamaç) wrote:
In this patch,
* It is possible to switch the running mode of the distributor
using the command line argument.
* With "-c" parameter, you can run RX and Distributor
on the same core.
* Witho
On 02/08/2022 16:22, Reshma Pattan wrote:
Add removal note for experimental empty poll API.
CC: David Hunt
Signed-off-by: Reshma Pattan
---
doc/guides/prog_guide/power_man.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/prog_guide/power_man.rst
b/doc/guides/prog
On 25/08/2022 07:42, Feifei Wang wrote:
For Arm aarch, power monitor uses WFE instruction to enable, which can
not exit automatically within the time limit. This means
'rte_power_monitor_wakeup' API needs to be called to wake up sleep cores
if there is no store operation to monitored address.
Hi Markus,
On 24/08/2022 20:28, Markus Theil wrote:
If DPDK applications should be used with a minimal set of privileges,
using the msr kernel module on linux should not be necessary.
Since at least kernel 4.4 the rdmsr call to obtain the last non-turbo
boost frequency can be left out, if the s
On 22/08/2022 11:58, Reshma Pattan wrote:
From: Hamza Khan
Currently, when vm_power_manager exits, we are using a LIST_FOREACH
macro to iterate over VM info structures while freeing them. This
leads to use-after-free error. To address this, replace all usages of
LIST_* with TAILQ_* macros, an
On 08/07/2022 09:51, Hamza Khan wrote:
Currently, when vm_power_manager exits, we are using a LIST_FOREACH
macro to iterate over VM info structures while freeing them. This
leads to use-after-free error. To address this, replace all usages of
LIST_* with TAILQ_* macros, and use the RTE_TAILQ_FO
On 01/06/2022 11:54, Hamza Khan wrote:
Currently, when vm_power_manager exits, we are using a LIST_FOREACH
macro to iterate over VM info structures while freeing them. This
leads to use-after-free error. To address this, use the newly added
LIST_FOREACH_SAFE macro.
Fixes: e8ae9b662506 ("exampl
On 28/06/2022 13:06, Omer Yamac wrote:
Hi,
Here is the final version. If it is ok, I will test the code and publish.
if (enable_lcore_rx_distributor){
// rx and distributor combined, 3 fixed function cores (stat, TX, at
least 1 worker)
min_cores = 4;
num_workers = rte_lcore_count() -
On 28/06/2022 12:06, Omer Yamac wrote:
Hi David,
I have one more question. When I was working on new patch, I just want
to make sure what we are doing.
On 27.06.2022 18:51, Hunt, David wrote:
Hi Ömer,
I've a few comments:
On 21/06/2022 21:15, Abdullah Ömer Yamaç wrote:
--cl
submit patch?
Yes, You can wait, or you can submit to the mailing list now and mark
the patch as "Deferred" in patchwork. Once 22.07 is released it will get
marked as "New", and under consideration for 22.11.
The other question is below,
On 27.06.2022 18:51, Hunt, D
Hi Ömer,
I've a few comments:
On 21/06/2022 21:15, Abdullah Ömer Yamaç wrote:
In this patch,
* It is possible to switch the running mode of the distributor
using the command line argument.
* With "-c" parameter, you can run RX and Distributor
on the same core.
* Without
Hi Ferruh,
On 20/06/2022 18:10, Ferruh Yigit wrote:
On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
This patch fixes the syntax error when using the single-core
for both rx and distributor functions.
Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
Cc: sta...@dpdk.org
Signed-
On 13/7/2020 1:15 PM, Anatoly Burakov wrote:
When perf-config option is specified, we are calling into the power
library even though it may not necessarily be enabled. It is
questionable whether perf-config option is even applicable to non-power
library modes, but for now, fix it just by avoidi
On 13/7/2020 1:15 PM, Anatoly Burakov wrote:
Anything coming from sysfs has a newline at the end. Cut it off before
comparing the strings.
Fixes: 20ab67608a39 ("power: add environment capability probing")
Signed-off-by: Anatoly Burakov
---
lib/librte_power/power_common.c | 5 +
1 file
On 18/5/2020 11:39 AM, Sexton, Rory wrote:
Signed-off-by: Rory Sexton
---
doc/guides/sample_app_ug/vm_power_management.rst | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/doc/guides/sample_app_ug/vm_power_management.rst
b/doc/guides/sample_app_ug/vm_power_
Hi Rory,
On 18/5/2020 11:39 AM, Sexton, Rory wrote:
This change is required to allow the branch ratio algorithm to
power manage cores with no workload running on them. This is
useful both when idle cores don't use C-states and for a number of
hyperthreading scenarios.
Signed-off-by: Rory Sexton
Hi Rory,
On 18/5/2020 11:39 AM, Sexton, Rory wrote:
This modification allows for the branch ratio threshold to be set
per core rather than system wide. This gives greater flexibility to
the branch ration monitoring allowing it to manage different
workloads with different characteristics on the s
On 27/5/2020 7:10 AM, oulijun wrote:
在 2020/5/26 16:36, Hunt, David 写道:
Hi Lijun,
On 26/5/2020 4:50 AM, oulijun wrote:
Hi，
I have update the code into 20.05-rc2. However， the l3fwd-power
startup fail.
[root@centos-C3 build]# l3fwd-power -w :7d:00.1 -c 0xc00 -n
4 -- -P -p
Hi Lijun,
On 26/5/2020 4:50 AM, oulijun wrote:
Hi，
I have update the code into 20.05-rc2. However， the l3fwd-power
startup fail.
[root@centos-C3 build]# l3fwd-power -w :7d:00.1 -c 0xc00 -n 4
-- -P -p 0x01 --config '(0,0,27)' --parse-ptype
--snip--
POWER: Attempting to initi
On 22/5/2020 9:17 AM, oulijun wrote:
在 2020/5/20 15:22, David Marchand 写道:
Hello,
On Wed, May 20, 2020 at 5:18 AM oulijun wrote:
I am using 20.05-rc2 version to test based on HNS3 NIC
hardware, and
found that after starting l3fwd-power,
using ctrl+c cannot force quit. But I revert
On 30/4/2020 11:49 AM, Anatoly Burakov wrote:
Currently, thread waiting on an interrupt does not have a timeout, so
it will not ever wake up until traffic arrives. This means that, when
time comes to exit the application, it will not quit unless there
happens to be traffic coming in and waking
On 29/4/2020 1:21 PM, Anatoly Burakov wrote:
Currently, thread waiting on an interrupt does not have a timeout, so
it will not ever wake up until traffic arrives. This means that, when
time comes to exit the application, it will not quit unless there
happens to be traffic coming in and waking u
Hi Anatoly,
On 8/4/2020 4:56 PM, Anatoly Burakov wrote:
Currently, shutdown for l3fwd-power application is all over the place
and may or may not happen either in the signal handler or in the main()
function. Fix this so that the signal handler will only set the exit
variable, thereby allowing a
Hi Anatoly,
On 8/4/2020 4:56 PM, Anatoly Burakov wrote:
Currently, if power library initialization fails, only a log message is
displayed. This is suboptimal for a number of reasons, but the main one
is that telemetry mode does not depend on the power library and can
therefore run in environment
Hi Thomas,
On 16/2/2020 11:13 AM, Thomas Monjalon wrote:
07/01/2020 10:13, David Hunt:
Review and re-work of vm_power_manager documentation. Hopefully this
is clearer, easier to follow.
Signed-off-by: David Hunt
checkpatch is reporting a typo done several times:
s/virutal/virtual/
On 21/1/2020 3:06 AM, Xiao Wang wrote:
Fixes: aee3bc79cc34 ("examples/l3fwd-power: enable one-shot Rx interrupt and polling
switch")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Wang
---
examples/l3fwd-power/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/l3
On 21/1/2020 3:06 AM, Xiao Wang wrote:
Fixes: aee3bc79cc34 ("examples/l3fwd-power: enable one-shot Rx interrupt and polling
switch")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Wang
---
examples/l3fwd-power/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/l3
On 30/1/2020 5:40 PM, Liang, Ma wrote:
On 20 Jan 22:06, Xiao Wang wrote:
Since all related queues' interrupts are turned on before epoll, we need
to turn off all the interrupts after wakeup. This patch fixes the issue
of only turning off the interrupted queues.
Fixes: b736d64787fc ("examples/
Hi Mattias,
On 14/11/2019 14:10, Mattias Rönnblom wrote:
Calling pstate's or acpi's rte_power_freq_up() when on the highest
non-turbo frequency results in an error, if turbo is disabled. The
error is in the form of a return code and a RTE_LOG() entry on the ERR
level.
According to the API docum
On 27/10/2019 18:35, Thomas Monjalon wrote:
06/08/2019 13:18, Thomas Monjalon:
26/07/2019 12:15, Burakov, Anatoly:
So it's biased towards scaling up quickly, but it's doing that over a
period. Please correct me if i'm wrong as i'm not really familiar with
this codebase, but, assuming the wind
On 25/10/2019 09:18, David Marchand wrote:
On Fri, Oct 25, 2019 at 10:11 AM Hunt, David wrote:
On 24/10/2019 20:31, David Marchand wrote:
On Tue, Oct 15, 2019 at 11:29 AM Ruifeng Wang wrote:
Bug 342 reported distributor_autotest execution suspension
on aarch64 platform.
Issue was due to
On 15/10/2019 10:28, Ruifeng Wang wrote:
Sanity test could spuriously fail with reporting flush count error.
It was caused by worker stat coherent issue between distributor and
worker thread.
Fix this issue by using atomic operations to update worker stat.
Fixes: c3eabff124e6 ("distributor: ad
On 15/10/2019 10:28, Ruifeng Wang wrote:
Distributor and worker threads rely on data structs in cache line
for synchronization. The shared data structs were not protected.
This caused deadlock issue on weaker memory ordering platforms as
aarch64.
Fix this issue by adding memory barriers to ensu
On 24/10/2019 20:31, David Marchand wrote:
On Tue, Oct 15, 2019 at 11:29 AM Ruifeng Wang wrote:
Bug 342 reported distributor_autotest execution suspension
on aarch64 platform.
Issue was due to lack of synchronization among threads. Distributor
thread and worker thread may get deadlocked.
Fixe
On 23/10/2019 15:32, Thomas Monjalon wrote:
+Cc Dave, the maintainer
Interrupt will not be received when disabling RX interrupt without
synchronization mechanism sometimes which leads to wake up issue,
add spinlock to fix it.
Fixes: b736d64787fc ("mples/l3fwd-power: disable Rx interrupt when
On 22/10/2019 16:43, Bruce Richardson wrote:
Building the example with clang gives the error:
error: expression which evaluates to zero treated as a null pointer
constant of type 'const char *' [-Werror,-Wnon-literal-null-conversion]
lcore_id, UINT8);
On 22/10/2019 16:43, Bruce Richardson wrote:
Signed-off-by: Bruce Richardson
---
examples/meson.build| 1 +
examples/vm_power_manager/guest_cli/meson.build | 4
2 files changed, 1 insertion(+), 4 deletions(-)
Acked-by: David Hunt
On 17/10/2019 15:31, Anatoly Burakov wrote:
From: Marcin Baran
The original ABI versioning was slightly misleading in that the
DPDK 2.0 ABI was really a single mode for the distributor, and is
used as such throughout the distributor code.
Fix this by renaming all _v20 API's to _single API's,
On 17/10/2019 15:31, Anatoly Burakov wrote:
From: Marcin Baran
Remove code for old ABI versions ahead of ABI version bump.
Signed-off-by: Marcin Baran
Signed-off-by: Anatoly Burakov
---
Notes:
v2:
- Moved this to before ABI version bump to avoid compile breakage
Hi Anatoly,
On 16/10/2019 18:03, Anatoly Burakov wrote:
From: Marcin Baran
Remove code for old ABI versions ahead of ABI version bump.
Signed-off-by: Marcin Baran
Signed-off-by: Anatoly Burakov
---
Notes:
v3:
- Removed single mode from distributor as per Dave's comments
Hi Anatoly,
Havi
On 16/10/2019 13:43, Anatoly Burakov wrote:
From: Marcin Baran
The functions and structures version 2.0 is
still in use in librte_distributor for single
packet mode but the version suffix "_v20" needs
to be changed to "_single" in order to avoid
confusion.
Signed-off-by: Marcin Baran
Signed
On 08/10/2019 10:55, Ruifeng Wang wrote:
Distributor and worker threads rely on data structs in cache line
for synchronization. The shared data structs were not protected.
This caused deadlock issue on weaker memory ordering platforms as
aarch64.
Fix this issue by adding memory barriers to ensu
On 30/09/2019 14:00, David Hunt wrote:
From: Marcin Hajkowski
Send request to power manager for core id provided
by user to get related capabilities.
Signed-off-by: Marcin Hajkowski
Tested-by: David Hunt
Acked-by: Lee Daly
---
.../guest_cli/vm_power_cli_guest.c| 119
On 27/09/2019 13:15, David Hunt wrote:
From: Marcin Hajkowski
Extend incoming packet reading API with new packet
type which carries CPU frequencies.
Signed-off-by: Marcin Hajkowski
Tested-by: David Hunt
Acked-by: Lee Daly
---
lib/librte_power/channel_commands.h | 21 +
On 27/09/2019 13:16, David Hunt wrote:
From: Marcin Hajkowski
Add command and related logic to query CPU frequencies
either for specified CPU or all cores.
Signed-off-by: Marcin Hajkowski
Tested-by: David Hunt
Acked-by: Lee Daly
---
.../guest_cli/vm_power_cli_guest.c| 150 ++
On 27/09/2019 11:19, Ferruh Yigit wrote:
On 9/27/2019 10:52 AM, Daly, Lee wrote:
-Original Message-
From: Hajkowski, MarcinX
Sent: Wednesday, April 3, 2019 6:16 PM
To: Hunt, David
Cc: dev@dpdk.org; Hajkowski, MarcinX
Subject: [PATCH 4/4] power: add cmd to query CPU freq.
From
On 05/04/2019 14:24, Hajkowski wrote:
From: Marcin Hajkowski
Use new guest channel API to send confirmation
message for received power command.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/channel_monitor.c | 68 +++--
1 file changed, 62 insertions(+), 6
On 05/04/2019 14:24, Hajkowski wrote:
From: Marcin Hajkowski
Extend vm_power_guest to check incoming confirmations
of messages previously sent to host.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/guest_cli/Makefile | 1 +
.../guest_cli/vm_power_cli_guest.c
On 05/04/2019 14:24, Hajkowski wrote:
From: Marcin Hajkowski
Added new experimental API rte_power_guest_channel_receive_msg
which gives possibility to receive messages send to guest.
Signed-off-by: Marcin Hajkowski
---
lib/librte_power/channel_commands.h| 5 +++
lib/librte_power/gue
Hi Harman,
On 05/07/2019 11:05, Harman Kalra wrote:
No of workers should never exceed RTE_MAX_LCORE.
RTE_DIST_ALG_SINGLE also require no of workers check.
Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
Cc: sta...@dpdk.org
Signed-off-by: Harman Kalra
---
lib/librte_distri
Hi Harman,
On 05/07/2019 11:05, Harman Kalra wrote:
On restarting worker 0 after shutdown, packets handled by
worker 0 must be incremented only when a packet is received by
it.
Fixes: c3eabff124e6 ("distributor: add unit tests")
Cc: sta...@dpdk.org
Signed-off-by: Harman Kalra
---
app/test/t
On 16/07/2019 12:05, Thomas Monjalon wrote:
16/07/2019 10:24, David Hunt:
replace strcpy with strlcpy to prevent buffer overrun
With fix, attempting to use a VERY lonng vm name results in a nicely
truncated 32 character name rather than a segfault:
Setting VM Name to [sdfdsfsfsdffdsdsasdsadasd
On 13/07/2019 00:23, Stephen Hemminger wrote:
On Fri, 12 Jul 2019 10:06:51 +0100
David Hunt wrote:
Samples apps that depend on the power library should not build if
the power library is not present. So now the following apps will
check to see if it's built, else skip building.
* l3fwd-pwer
* v
Hi Thomas,
Fyi, I am unable mark v4 as superseded in patchwork
(http://patches.dpdk.org/project/dpdk/list/?series=4997), although I've
done that with v5, v6 is the latest version.
Rgds,
Dave.
On 09/07/2019 16:21, David Hunt wrote:
From: Marcin Hajkowski
This patch implements a separat
Hi Anatoly,
On 09/07/2019 16:12, Burakov, Anatoly wrote:
On 09-Jul-19 4:07 PM, David Hunt wrote:
From: Marcin Hajkowski
This patch implements a separate FIFO for each cpu core to improve the
previous functionality where anyone with access to the FIFO could affect
any core on the system. By us
Hi Anatoly,
On 08/07/2019 14:34, Burakov, Anatoly wrote:
On 13-Jun-19 10:21 AM, Hajkowski wrote:
From: Marcin Hajkowski
Updated power management docs for fifo JSON API.
Removed from JSON API:
* 'name'
* 'resource_id'
* 'core_list'
Signed-off-by: Marcin Hajkowski
Signed-off-by: Lukasz Krako
On 8/4/2019 5:19 PM, Liang Ma wrote:
Fix the resource leaking issue
Coverity issue: 337668
Fixes: b60fd5f8b1ce8f0a2c ("power: add bit for high frequency cores")
Signed-off-by: Liang Ma
---
lib/librte_power/power_pstate_cpufreq.c | 11 ---
1 file changed, 8 insertions(+), 3 deleti
On 26/4/2019 11:29 AM, Burakov, Anatoly wrote:
On 26-Apr-19 9:44 AM, David Hunt wrote:
Coverity complains about the return of a value that may
possibly overflow because of a multiply. Limit the value
so it cannot overflow.
Coverity issue: 337677
Fixes: 4b1a631b8a ("examples/vm_power: add oob
Hi Anatoly,
On 26/4/2019 11:33 AM, Burakov, Anatoly wrote:
On 26-Apr-19 9:43 AM, David Hunt wrote:
coverity complains about a null-termination after a read,
so we terminate conditionally on whether idx is within
the buffer or at the end of the buffer.
Coverity issue: 337680
Fixes: a63504a90f (
Hi Anatoly,
On 26/4/2019 11:29 AM, Burakov, Anatoly wrote:
On 26-Apr-19 9:44 AM, David Hunt wrote:
Coverity complains about the return of a value that may
possibly overflow because of a multiply. Limit the value
so it cannot overflow.
Coverity issue: 337677
Fixes: 4b1a631b8a ("examples/vm_powe
On 22/4/2019 9:36 PM, Thomas Monjalon wrote:
05/04/2019 15:24, Hajkowski:
From: Marcin Hajkowski
Extend guest channel API to allow bidirectional
communication. Modify power manager host and guest
side to communicate in both directions.
This patchset is deferred to 19.08 because of a lack
of r
Hi Kevin,
On 23/4/2019 11:26 AM, Kevin Traynor wrote:
On 18/04/2019 16:14, Pattan, Reshma wrote:
Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host")
Coverity issue: 337660
Candidate for sta...@dpdk.org?
There is no reply to this comment - re-asking as I will probably have
t
On 23/4/2019 9:33 AM, Thomas Monjalon wrote:
23/04/2019 10:21, Hunt, David:
Hi Thomas,
On 22/4/2019 10:54 PM, Thomas Monjalon wrote:
10/04/2019 14:49, David Hunt:
The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements,
yet the code can attemtp to look at the index at
Hi Thomas,
On 22/4/2019 10:54 PM, Thomas Monjalon wrote:
10/04/2019 14:49, David Hunt:
The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements,
yet the code can attemtp to look at the index at POWER_MANAGER_MAX_CPUS,
which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index
On 9/4/2019 10:54 AM, Lukasz Krakowiak wrote:
Removed dependency to mac_list from policies:
* BRANCH_RATIO,
* WORKLOAD,
* TIME
in function update_policy.
Fixes: 1b897991473f ("power: update error handling")
Signed-off-by: Lukasz Krakowiak
---
examples/vm_power_manager/channel_monitor.c | 1
On 13/3/2019 7:21 PM, Hajkowski wrote:
From: Marcin Hajkowski
Function rte_power_set_env will no longer return
success on attempt to set env in initialized state.
Signed-off-by: Marcin Hajkowski
---
Acked-by: David Hunt
1 - 100 of 393 matches
Mail list logo
