[PATCH 2/3] rust: split main into example, refactor to lib.rs

2025-04-18 Thread Harry van Haaren
Signed-off-by: Harry van Haaren --- rust_api_example/examples/eth_poll.rs| 35 +++ rust_api_example/src/{main.rs => lib.rs} | 43 2 files changed, 35 insertions(+), 43 deletions(-) create mode 100644 rust_api_example/examples/eth_poll.rs ren

[PATCH 3/3] rust: showcase port Rxq return for stop() and reconfigure

2025-04-18 Thread Harry van Haaren
Since the refactor, use this command to run/test: cargo r --example eth_poll Signed-off-by: Harry van Haaren --- rust_api_example/examples/eth_poll.rs | 45 --- rust_api_example/src/lib.rs | 52 --- 2 files changed, 88 insertions(+), 9

[PATCH 1/3] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq

2025-04-18 Thread Harry van Haaren
t; and run $ cargo run This will compile the API, and spawn 2x threads to poll on two Rxq instances. The comments in the code explain how the "Send" and "Sync" attributes are captured per instances of a struct (e.g. how RxqHandle -> Rxq restricts thread movement).

[PATCH] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq

2025-04-17 Thread Harry van Haaren
t; and run $ cargo run This will compile the API, and spawn 2x threads to poll on two Rxq instances. The comments in the code explain how the "Send" and "Sync" attributes are captured per instances of a struct (e.g. how RxqHandle -> Rxq restricts thread movement).

[PATCH v3 2/2] event/sw: add selftest for ordered history list

2023-10-02 Thread Harry van Haaren
incorrectly be reordered. The existing unit-tests did not cover the RELEASE of an ORDERED queue, and then stress-test the history-list by iterating HIST_LIST times afterwards. Signed-off-by: Harry van Haaren Acked-by: Bruce Richardson --- v3: - Including Ack from v2 --- drivers/event/sw

[PATCH v3 1/2] event/sw: fix ordering corruption with op release

2023-10-02 Thread Harry van Haaren
ot;) Fixes: 617995dfc5b2 ("event/sw: add scheduling logic") Cc: sta...@dpdk.org Suggested-by: Bruce Richardson Signed-off-by: Harry van Haaren Acked-by: Bruce Richardson --- v3: - Fixup whitespace and line wrapping suggestions (Bruce) - Add Fixes lines (Bruce) - Cc stable, as this is a

[PATCH v2 2/2] event/sw: add selftest for ordered history list

2023-09-14 Thread Harry van Haaren
incorrectly be reordered. The existing unit-tests did not cover the RELEASE of an ORDERED queue, and then stress-test the history-list by iterating HIST_LIST times afterwards. Signed-off-by: Harry van Haaren --- drivers/event/sw/sw_evdev_selftest.c | 132 +++ 1 file changed

[PATCH v2 1/2] event/sw: fix ordering corruption with op release

2023-09-14 Thread Harry van Haaren
events with op type of forward could be incorrectly reordered. Suggested-by: Bruce Richardson Signed-off-by: Harry van Haaren --- v2: - Rework fix to simpler suggestion (Bruce) - Respin patchset to "apply order" (Bruce) --- drivers/event/sw/sw_evdev_scheduler.c | 15 +++--

[PATCH 1/2] event/sw: add selftest for ordered history list

2023-08-31 Thread Harry van Haaren
incorrectly be reordered. The existing unit-tests did not cover the RELEASE of an ORDERED queue, and then stress-test the history-list by iterating HIST_LIST times afterwards. Signed-off-by: Harry van Haaren --- drivers/event/sw/sw_evdev_selftest.c | 132 +++ 1 file changed

[PATCH 2/2] event/sw: fix ordering corruption with op release

2023-08-31 Thread Harry van Haaren
state, and future events with op type of forward could be incorrectly reordered. Signed-off-by: Harry van Haaren --- drivers/event/sw/sw_evdev_scheduler.c | 45 --- 1 file changed, 27 insertions(+), 18 deletions(-) diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers

[PATCH v2] service: split tests to perf and autotest to avoid spurious CI failures

2023-03-03 Thread Harry van Haaren
-by: Harry van Haaren --- v2: - Add "performance" to suite name (David) - Remove comment above perf-test suite (David) See DPDK ML discussion in this thread: http://mails.dpdk.org/archives/dev/2023-February/263523.html --- app/test/meson.build | 1 + app/test/test_service_co

[PATCH] service: split tests to perf and autotest to avoid spurious CI failures

2023-02-24 Thread Harry van Haaren
-by: Harry van Haaren --- See DPDK ML discussion in this thread: http://mails.dpdk.org/archives/dev/2023-February/263523.html --- app/test/meson.build | 1 + app/test/test_service_cores.c | 32 +++- 2 files changed, 28 insertions(+), 5 deletions(-) diff

[PATCH] event/sw: fix selftest xstats reset API usage

2022-10-12 Thread Harry van Haaren
Fixes: e21df4b062b5 ("test/eventdev: add SW xstats tests") Reported-by: Morten Brørup Signed-off-by: Harry van Haaren --- Note this is a fix for a potential build issue in 64-bit BE systems. --- drivers/event/sw/sw_evdev_selftest.c | 15 +-- 1 file changed, 9 insertions(+)

[PATCH v3] test/service: fix spurious failures by extending timeout

2022-10-06 Thread Harry van Haaren
code was duplicated in two tests, and is now refactored to a standalone function avoiding duplication. Reported-by: David Marchand Suggested-by: Mattias Ronnblom Signed-off-by: Harry van Haaren --- v3: - Use #define for timeout, and delay(1) (Mattias) - Rework slcore-wait to use TIMEOUT_MS as

[PATCH v2] test/service: fix spurious failures by extending timeout

2022-10-06 Thread Harry van Haaren
code was duplicated in two tests, and is now refactored to a standalone function avoiding duplication. Reported-by: David Marchand Suggested-by: Mattias Ronnblom Signed-off-by: Harry van Haaren --- Apologies for the quick respin noise; only the first diff-section is added, no changes to the rest

[PATCH] test/service: fix spurious failures by extending timeout

2022-10-06 Thread Harry van Haaren
avoiding duplication. Reported-by: David Marchand Suggested-by: Mattias Ronnblom Signed-off-by: Harry van Haaren --- app/test/test_service_cores.c | 43 --- 1 file changed, 20 insertions(+), 23 deletions(-) diff --git a/app/test/test_service_cores.c b/app/test

[PATCH v3 2/2] service: fix potential stats race-condition on MT services

2022-07-11 Thread Harry van Haaren
Suggested-by: Honnappa Nagarahalli Suggested-by: Morten Brørup Suggested-by: Bruce Richardson Signed-off-by: Harry van Haaren --- v3: - Fix 32-bit build, by forcing natural alignment of uint64_t in the struct that contains it, using __rte_aligned(8) macro. - Note: I'm seeing a checkpatch &

[PATCH v3 1/2] test/service: add perf measurements for with stats mode

2022-07-11 Thread Harry van Haaren
Suggested-by: Morten Brørup Signed-off-by: Harry van Haaren --- This is split out as a seperate patch from the fix to allow measuring the before/after of the service stats atomic fixup. --- app/test/test_service_cores.c | 36 --- 1 file changed, 25 insertions

[PATCH v2 1/2] test/service: add perf measurements for with stats mode

2022-07-11 Thread Harry van Haaren
Suggested-by: Morten Brørup Signed-off-by: Harry van Haaren --- This is split out as a seperate patch from the fix to allow measuring the before/after of the service stats atomic fixup. --- app/test/test_service_cores.c | 36 --- 1 file changed, 25 insertions

[PATCH v2 2/2] service: fix potential stats race-condition on MT services

2022-07-11 Thread Harry van Haaren
Suggested-by: Honnappa Nagarahalli Suggested-by: Morten Brørup Suggested-by: Bruce Richardson Signed-off-by: Harry van Haaren --- v2 (Thanks Honnappa, Morten, Bruce & Mattias for discussion): - Improved handling of stat stores to ensure they're atomic by using __atomic_store_n() wit

[PATCH 2/2] service: fix potential stats race-condition on MT services

2022-07-08 Thread Harry van Haaren
cycle-cost for polling a MT safe service when statistics are enabled. No change was seen for MT unsafe services, or when statistics are disabled. Reported-by: Mattias Rönnblom Suggested-by: Honnappa Nagarahalli Suggested-by: Morten Brørup Signed-off-by: Harry van Haaren --- --- lib/eal/common

[PATCH 1/2] test/service: add perf measurements for with stats mode

2022-07-08 Thread Harry van Haaren
Suggested-by: Morten Brørup Signed-off-by: Harry van Haaren --- This is split out as a seperate patch from the fix to allow measuring the before/after of the service stats atomic fixup. --- app/test/test_service_cores.c | 36 --- 1 file changed, 25 insertions

[PATCH] service: debug and fix lingering might_be_active() result

2022-07-05 Thread Harry van Haaren
topped. This is fixed by ensuring the "active on lcore" status of each service is set to 0 when an lcore is stopped. Fixes: e30dd31847d2 ("service: add mechanism for quiescing") Fixes: 8929de043eb4 ("service: retrieve lcore active state") Reported-by: S. V. Naga Haris

[PATCH 2/2] docs: improve ordering and remove old header titles

2022-05-27 Thread Harry van Haaren
Move the "source_org" page to after overview, where it fits better to explain the source-code layout of DPDK, before getting into details of specific libraries such as EAL. Also removes the older titles from the 3 documents which still had them. Signed-off-by: Harry van Haaren ---

[PATCH 1/2] docs/bpf: fix formatting and link

2022-05-27 Thread Harry van Haaren
Small improvements to the documentation based on Sphinx HTML doc output. Signed-off-by: Harry van Haaren --- Cc: konstantin.v.anan...@yandex.ru --- doc/guides/prog_guide/bpf_lib.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/prog_guide/bpf_lib.rst

[dpdk-dev] [PATCH v2 4/4] event/dlb2: optimize credit allocations using port hint flags

2021-10-14 Thread Harry van Haaren
From: "Pathak, Pravin" This commit implements the changes required for using suggested port type hint feature. Each port uses different credit quanta based on port type specified using port configuration flags. Each port has separate quanta defined in dlb2_priv.h Producer and consumer ports will

[dpdk-dev] [PATCH v2 3/4] test-eventdev: add event port hints for perf mode

2021-10-14 Thread Harry van Haaren
This commit adds producer, worker and consumer port hints for the test-eventdev application performance tests. Signed-off-by: Harry van Haaren --- app/test-eventdev/test_perf_common.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/app/test-eventdev

[dpdk-dev] [PATCH v2 2/4] examples/eventdev_pipeline: use port config hints

2021-10-14 Thread Harry van Haaren
This commit adds the per-port hints added to the eventdev API, indicating which eventdev ports will be used for producing, forwarding, or consuming events from the system. Signed-off-by: Harry van Haaren --- examples/eventdev_pipeline/pipeline_worker_generic.c | 2 ++ examples/eventdev_pipeline

[dpdk-dev] [PATCH v2 1/4] eventdev: add usage hints to port configure API

2021-10-14 Thread Harry van Haaren
) - RTE_EVENT_PORT_CFG_HINT_CONSUMER (mostly RTE_EVENT_OP_RELEASE events) - RTE_EVENT_PORT_CFG_HINT_WORKER (mostly RTE_EVENT_OP_FORWARD events) These flags are only hints, and the PMDs must operate under the assumption that any port can enqueue an event with any type of op. Signed-off-by: Harry van Haaren --- v2: - Add

[dpdk-dev] [PATCH] app/test-eventdev: fix terminal colour after control-c exit

2021-10-14 Thread Harry van Haaren
: 6b1a14a83a06 ("app/eventdev: add packet distribution logs") Signed-off-by: Harry van Haaren --- Given this is an aesthetic only fix, I feel its not worth backporting. Cc: pbhagavat...@marvell.com> --- app/test-eventdev/test_perf_common.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[dpdk-dev] [PATCH 2/2] examples/eventdev_pipeline: use port config hints

2021-09-09 Thread Harry van Haaren
This commit adds the per-port hints added to the eventdev API, indicating which eventdev ports will be used for producing, forwarding, or consuming events from the system. Signed-off-by: Harry van Haaren --- examples/eventdev_pipeline/pipeline_worker_generic.c | 2 ++ examples/eventdev_pipeline

[dpdk-dev] [PATCH 1/2] lib/eventdev: add usage hints to port configure API

2021-09-09 Thread Harry van Haaren
) - RTE_EVENT_PORT_CFG_HINT_CONSUMER (mostly RTE_EVENT_OP_RELEASE events) - RTE_EVENT_PORT_CFG_HINT_WORKER (mostly RTE_EVENT_OP_FORWARD events) These flags are only hints, and the PMDs must operate under the assumption that any port can enqueue an event with any type of op. Signed-off-by: Harry van Haaren --- lib/eventdev

[dpdk-dev] [PATCH 0/2] eventdev: add port usage hints

2021-09-09 Thread Harry van Haaren
*functionally* any combination of (NEW/FWD/RELEASE) is still allowed by any port. The reason to add these is to allow a PMD to allocate internal resource more efficiently. Note that this implementation does not change the ABI, as it gives a purpose to existing bits in an existing field. Regards

[dpdk-dev] [PATCH v5] event/sw: add xstats to expose progress details

2021-03-08 Thread Harry van Haaren
of scheduling, as well if forward progress was made by the scheduler. This patch implements an xstat for the SW PMD that exposes a bitmask of ports that were scheduled to. In the unlikely case that the SW PMD instance has 64 or more ports, return UINT64_MAX. Signed-off-by: Harry van Haaren

[dpdk-dev] [PATCH v4] event/sw: add xstats to expose progress details

2021-03-03 Thread Harry van Haaren
of scheduling, as well if forward progress was made by the scheduler. This patch implements an xstat for the SW PMD that exposes a bitmask of ports that were scheduled to. In the unlikely case that the SW PMD instance has 64 or more ports, return UINT64_MAX. Signed-off-by: Harry van Haaren

[dpdk-dev] [PATCH v3 2/3] event/sw: add useful work done attribute

2021-02-12 Thread Harry van Haaren
This commit exposes if useful work is done to the service instance. The normal service_attr_get() API can be used to retrieve the value of the attribute. Signed-off-by: Harry van Haaren --- drivers/event/sw/sw_evdev_scheduler.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers

[dpdk-dev] [PATCH v3 3/3] event/sw: add xstat for work done in last iteration

2021-02-12 Thread Harry van Haaren
ports, always report that a port got an event. Signed-off-by: Harry van Haaren --- Note most of the changes here are unit-test changes to add a statistic to the PMD. The actual "useful code" is a mere handful of lines in a lot of noise.. could split into 2 patches? --- driver

[dpdk-dev] [PATCH v3 1/3] service: add component useful work attribute

2021-02-12 Thread Harry van Haaren
seful, and a CPU load estimate can be deduced from that information. Signed-off-by: Harry van Haaren --- lib/librte_eal/common/rte_service.c | 19 +++ lib/librte_eal/include/rte_service.h | 5 + .../include/rte_service_component.h | 13

[dpdk-dev] [PATCH] eventdev: remove return value comment in pmd api

2021-02-01 Thread Harry van Haaren
The PMD info get API has a void return type. Remove the @return 0 Success doxygen comment as it doesn't make sense here. Reported-by: Fredrik A Lindgren Signed-off-by: Harry van Haaren --- lib/librte_eventdev/eventdev_pmd.h | 3 --- 1 file changed, 3 deletions(-) diff --git

[dpdk-dev] [PATCH v3] eal: add new prefetch write variants

2020-10-15 Thread Harry van Haaren
, targeting the different levels of cache. Signed-off-by: Harry van Haaren Reviewed-by: Jerin Jacob Reviewed-by: Ruifeng Wang --- v3: - Add reviewed by tags from Jerin and Ruifeng, thanks! - Add __rte_experimental as they are new functions (David) This required adding the rte_compat.h include

[dpdk-dev] [PATCH v2] eal: add new prefetch write variants

2020-09-14 Thread Harry van Haaren
This commit adds a new rte_prefetch0_write() variants, suggesting to the compiler to use a prefetch instruction with intention to write. As a compiler builtin, the compiler can choose based on compilation target what the best implementation for this instruction is. Signed-off-by: Harry van Haaren

[dpdk-dev] [PATCH v2 1/2] service: add component useful work attribute

2020-09-14 Thread Harry van Haaren
seful, and a CPU load estimate can be deduced from that information. Signed-off-by: Harry van Haaren --- v2: - Add experimental tag to new function. --- lib/librte_eal/common/rte_service.c | 19 +++ lib/librte_eal/include/rte_service.h | 5 + .

[dpdk-dev] [PATCH v2 2/2] event/sw: add useful work done attribute

2020-09-14 Thread Harry van Haaren
This commit exposes if useful work is done to the service instance. The normal service_attr_get() API can be used to retrieve the value of the attribute. Signed-off-by: Harry van Haaren --- drivers/event/sw/sw_evdev_scheduler.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers

[dpdk-dev] [PATCH v6 2/2] test/service: fix race condition on stopping lcore

2020-09-14 Thread Harry van Haaren
test continues finalizing and checking state. Fixes: f28f3594ded2 ("service: add attribute API") Reported-by: David Marchand Signed-off-by: Harry van Haaren Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- v6: - Fix CI issue on C99 style loop initializer (David) v4: - Upd

[dpdk-dev] [PATCH v6 1/2] service: add API to retrieve service core active

2020-09-14 Thread Harry van Haaren
to indicate if its thread is active. When zero the service thread has completed its service, and has returned from the service_runner_func() function. Suggested-by: Lukasz Wojciechowski Signed-off-by: Harry van Haaren Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- v5: - Fix

[dpdk-dev] [PATCH] eal: add new prefetch0_write variant

2020-09-11 Thread Harry van Haaren
This commit adds a new rte_prefetch0_write() variant, suggests to the compiler to use a prefetch instruction with intention to write. As a compiler builtin, the compiler can choose based on compilation target what the best implementation for this instruction is. Signed-off-by: Harry van Haaren

[dpdk-dev] [PATCH 1/2] service: add component useful work attribute

2020-09-07 Thread Harry van Haaren
seful, and a CPU load estimate can be deduced from that information. Signed-off-by: Harry van Haaren --- lib/librte_eal/common/rte_service.c | 19 +++ lib/librte_eal/include/rte_service.h | 5 + .../include/rte_service_component.h | 12 +++

[dpdk-dev] [PATCH 2/2] event/sw: add useful work done attribute

2020-09-07 Thread Harry van Haaren
This commit exposes if useful work is done to the service instance. The normal service_attr_get() API can be used to retrieve the value of the attribute. Signed-off-by: Harry van Haaren --- Cc: jer...@marvell.com CC due to event/sw change, could be picked up by main tree as depends on 1/2

[dpdk-dev] [PATCH v5 2/2] test/service: fix race condition on stopping lcore

2020-07-24 Thread Harry van Haaren
test continues finalizing and checking state. Fixes: f28f3594ded2 ("service: add attribute API") Reported-by: David Marchand Signed-off-by: Harry van Haaren Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- v4: - Update test to new _may_be_ style API (Honnappa) - Add reviewed

[dpdk-dev] [PATCH v5 1/2] service: add API to retrieve service core active

2020-07-24 Thread Harry van Haaren
to indicate if its thread is active. When zero the service thread has completed its service, and has returned from the service_runner_func() function. Suggested-by: Lukasz Wojciechowski Signed-off-by: Harry van Haaren Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- v5: - Fix

[dpdk-dev] [PATCH v4 2/2] test/service: fix race condition on stopping lcore

2020-07-24 Thread Harry van Haaren
test continues finalizing and checking state. Fixes: f28f3594ded2 ("service: add attribute API") Reported-by: David Marchand Signed-off-by: Harry van Haaren Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- v4: - Update test to new _may_be_ style API (Honnappa) - Add reviewed

[dpdk-dev] [PATCH v4 1/2] service: add API to retrieve service core active

2020-07-24 Thread Harry van Haaren
to indicate if its thread is active. When zero the service thread has completed its service, and has returned from the service_runner_func() function. Suggested-by: Lukasz Wojciechowski Signed-off-by: Harry van Haaren Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- v4: - Use

[dpdk-dev] [PATCH v3 2/2] test/service: fix race condition on stopping lcore

2020-07-22 Thread Harry van Haaren
test continues finalizing and checking state. Fixes: f28f3594ded2 ("service: add attribute API") Reported-by: David Marchand Signed-off-by: Harry van Haaren Reviewed-by: Phil Yang --- v3: - Refactor while() to for() to simplify (Harry) - Use SERVICE_DELAY instead of magic const 1 (Phi

[dpdk-dev] [PATCH v3 1/2] service: add API to retrieve service core active

2020-07-22 Thread Harry van Haaren
to indicate if its thread is active. When zero the service thread has completed its service, and has returned from the service_runner_func() function. Suggested-by: Lukasz Wojciechowski Signed-off-by: Harry van Haaren Reviewed-by: Phil Yang --- v3: - Change service lcore stores to SEQ_CST

[dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-20 Thread Harry van Haaren
to indicate if its thread is active. When zero the service thread has completed its service, and has returned from the service_runner_func() function. Suggested-by: Lukasz Wojciechowski Signed-off-by: Harry van Haaren --- Thanks for feedback Lukasz, please have a look and see if this was what

[dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on stopping lcore

2020-07-20 Thread Harry van Haaren
test continues finalizing and checking state. Fixes: f28f3594ded2 ("service: add attribute API") Reported-by: David Marchand Signed-off-by: Harry van Haaren --- Thanks for discussion on v1, this v2 fixup for the CI including previous feedback on ML. --- app/test/test_servi

[dpdk-dev] [PATCH] service: fix stop API to wait for service thread

2020-07-20 Thread Harry van Haaren
() function. This fixes a race condition observed in the DPDK CI, where the statistics of the service were not consistent with the expectation due to the service thread still running, and incrementing a stat after stop was called. Signed-off-by: Harry van Haaren --- This is one possible solution

[dpdk-dev] [PATCH] examples/eventdev_pipeline: fix 32-bit coremask logic

2020-06-16 Thread Harry van Haaren
eported-by: Jun Zhou Suggested-by: Mao Jiang Signed-off-by: Harry van Haaren --- examples/eventdev_pipeline/main.c| 10 +- examples/eventdev_pipeline/pipeline_common.h | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/examples/eventdev_pipeline

[dpdk-dev] [PATCH v2] test/service: add perf test for service on app lcore

2020-05-06 Thread Harry van Haaren
This commit adds a basic test to check the cycle cost of related to calling into a service. Signed-off-by: Harry van Haaren --- v2: - Add space at start of output (Phil Yang) - Fix compile error on older GCCs (David Marchand) --- app/test/test_service_cores.c | 13 - 1 file

[dpdk-dev] [PATCH] examples/eventdev_pipeline: fix segfault on exit

2020-05-05 Thread Harry van Haaren
: 085edac2ca38 ("examples/eventdev_pipeline: support Tx adapter") Signed-off-by: Harry van Haaren --- Cc: sta...@dpdk.org Cc: pbhagavat...@caviumnetworks.com --- examples/eventdev_pipeline/main.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

[dpdk-dev] [PATCH] test/service: add perf test for service on app lcore

2020-05-01 Thread Harry van Haaren
-off-by: Harry van Haaren --- I'm suggesting to merge this patch before the bugfix/C11 patch series, (v2 currently here: http://patches.dpdk.org/patch/69199/ ) as this would enable users to benchmark the "before" and "after" states of the bugfix/C11 patch

[dpdk-dev] [PATCH] test/flow-classify: fix failure on dual socket systems

2020-05-01 Thread Harry van Haaren
;) Signed-off-by: Harry van Haaren --- DPDK does not provide a RTE_SOCKETS_MAX #define, so we cannot easily statically allocate the array. As a bugfix patch, I'd prefer not add complexity of dynamically allocating based on rte_socket_count(), hence just increasing the value seems the mos

[dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-03-11 Thread Harry van Haaren
service memory, leading to a segfault. Fixes: 21698354c832 ("service: introduce service cores concept") Cc: sta...@dpdk.org Reported-by: David Marchand Reported-by: Aaron Conole Signed-off-by: David Marchand Signed-off-by: Harry van Haaren Acked-by: Aaron Conole --- v

[dpdk-dev] [PATCH] eal/service: fix exit by resetting service lcores

2020-03-10 Thread Harry van Haaren
service memory, leading to a segfault. Fixes: 21698354c832 ("service: introduce service cores concept") Reported-by: David Marchand Reported-by: Aaron Conole Signed-off-by: Harry van Haaren --- Please note that this patch is being sent to community for testing as I cannot reliably

[dpdk-dev] [PATCH] test/service: fix wait for service core

2019-11-27 Thread Harry van Haaren
ron Conole Signed-off-by: Harry van Haaren --- Given this is a fix in the unit test, and not a functional change I'm not sure its worth backporting to LTS / stable releases? I've not added stable on CC yet. --- app/test/test_service_cores.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[dpdk-dev] [PATCH v2 3/3] net/i40e: add flow director support to avx rx path

2019-10-09 Thread Harry van Haaren
This commit adds FDIR ID support to the AVX2 based recieve path routine. Support for both 16B and 32B descriptors is implemented. Signed-off-by: Harry van Haaren --- v2: - Fixup AVX2 RSS clearing to not pollute register --- drivers/net/i40e/i40e_rxtx_vec_avx2.c | 193

[dpdk-dev] [PATCH v2 2/3] net/i40e: add flow mark capability to SSE vector routine

2019-10-09 Thread Harry van Haaren
stored to in the RX path before this patch. The 32B descriptor requires loading the 2nd 16 bytes of each descriptor, to get the FLEXBH_STAT and FD Filter ID from qword3. The resulting data must also be stored to mbuf->fdir.hi, same as the 16B code path. Signed-off-by: Harry van Haaren ---

[dpdk-dev] [PATCH v2 1/3] net/i40e: cache fdir enable value in rx queue

2019-10-09 Thread Harry van Haaren
flag is set to 1 on configuration of a flow director rule. Signed-off-by: Harry van Haaren --- v2: - Disable FDIR processing on flush (Qi) - Disable FDIR processing on last rule deletion (Qi) - Moved enable/disable to seperate function to avoid code duplication - Added PMD_LOG INFO level print for

[dpdk-dev] [PATCH v2 0/3] net/i40e: add FDIR ID to vector rx

2019-10-09 Thread Harry van Haaren
functionality was sent in 19.08 timeframe, refer to the patch as archived on patchwork here: http://patches.dpdk.org/patch/53969/ Regards, -Harry Harry van Haaren (3): net/i40e: cache fdir enable value in rx queue net/i40e: add flow mark capability to SSE vector routine net/i40e: add flow

[dpdk-dev] [PATCH 0/3] net/i40e: add FDIR ID to vector rx

2019-10-07 Thread Harry van Haaren
: http://patches.dpdk.org/patch/53969/ Regards, -Harry Harry van Haaren (3): net/i40e: cache fdir enable value in rx queue net/i40e: add flow mark capability to SSE vector routine net/i40e: add flow director support to avx rx path drivers/net/i40e/i40e_ethdev.h| 1 + drivers/net/i40e

[dpdk-dev] [PATCH 2/3] net/i40e: add flow mark capability to SSE vector routine

2019-10-07 Thread Harry van Haaren
stored to in the RX path before this patch. The 32B descriptor requires loading the 2nd 16 bytes of each descriptor, to get the FLEXBH_STAT and FD Filter ID from qword3. The resulting data must also be stored to mbuf->fdir.hi, same as the 16B code path. Suggested-by: Mesut Ergin Signed-off-by:

[dpdk-dev] [PATCH 1/3] net/i40e: cache fdir enable value in rx queue

2019-10-07 Thread Harry van Haaren
flag is set to 1 on configuration of a flow director rule. Signed-off-by: Harry van Haaren --- drivers/net/i40e/i40e_ethdev.h | 1 + drivers/net/i40e/i40e_fdir.c | 20 drivers/net/i40e/i40e_flow.c | 4 drivers/net/i40e/i40e_rxtx.h | 1 + 4 files changed, 26

[dpdk-dev] [PATCH 3/3] net/i40e: add flow director support to avx rx path

2019-10-07 Thread Harry van Haaren
This commit adds FDIR ID support to the AVX2 based recieve path routine. Support for both 16B and 32B descriptors is implemented. Suggested-by: Mesut Ergin Signed-off-by: Harry van Haaren --- drivers/net/i40e/i40e_rxtx_vec_avx2.c | 188 +- 1 file changed, 184 insertions

[dpdk-dev] [PATCH v2] service: print errors to rte log

2019-08-21 Thread Harry van Haaren
Haaren Acked-by: Harry van Haaren --- lib/librte_eal/common/rte_service.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c index c3653ebae..fe0907720 100644 --- a/lib

[dpdk-dev] [PATCH] net/i40e: add flow mark support to sse path

2019-05-31 Thread Harry van Haaren
This commit enables the "FD ID" or flow-director mark capability with the SSE vector PMD for 32 byte descriptors. Suggested-by: Mesut Ergin Signed-off-by: Harry van Haaren --- Hey Folks, This v1 is expected to have some performance impact due to adding stores to the data path. Th

[dpdk-dev] [PATCH] event/sw: fix selftest enqueue return value checks

2019-03-27 Thread Harry van Haaren
enqueued, so in order to identify the error case, we must check for != the number of intended enqueues. Fixes: cd1a9e3eab55 ("test/eventdev: add SW tests for load balancing") Signed-off-by: Harry van Haaren --- Given this commit only changes the test-suite, and not production code I don&#

[dpdk-dev] [PATCH] meson: fix compilation with binutils version 2.30

2019-01-17 Thread Harry van Haaren
the build, the code in rte_memcpy is no longer attempted to be compiled. This commit also adds a message print in the meson configure stage to alert the user of the workaround being employed. Fixes: a32ca9a4ebc1 ("mk: fix scope of disabling AVX512F support") Signed-off-by: Harry

[dpdk-dev] [PATCH v3] mbuf: fix compile by making sched struct visible

2019-01-11 Thread Harry van Haaren
on the stack in rte_mbuf_sched_get() and as a cast in _set(). For this reason, it must be exposed as an available type. Fixes: 5d3f72100904 ("mbuf: implement generic format for sched field") Signed-off-by: Harry van Haaren --- v3: - Update comment in mbuf to state size of st

[dpdk-dev] [PATCH v2] mbuf: fix compile by removing struct from function

2019-01-10 Thread Harry van Haaren
++ compiler doesn't need to know about the struct, resolving the issue. Fixes: 5d3f72100904 ("mbuf: implement generic format for sched field") Signed-off-by: Harry van Haaren --- Cc: reshma.pat...@intel.com Cc: cristian.dumitre...@intel.com Cc: tho...@monjalon.net Cc: olivier.m...

[dpdk-dev] [PATCH] mbuf: fix compile by making sched struct visible

2019-01-10 Thread Harry van Haaren
on the stack in rte_mbuf_sched_get() and as a cast in _set(). For this reason, it must be exposed as an available type. Fixes: 5d3f72100904 ("mbuf: implement generic format for sched field") Signed-off-by: Harry van Haaren --- Cc: reshma.pat...@intel.com Cc: cristian.dumitre...@intel.c

[dpdk-dev] [PATCH v10 12/12] build: add dependency on telemetry to apps in meson

2018-10-27 Thread Harry van Haaren
Nicolau Acked-by: Harry van Haaren --- app/meson.build | 4 ++-- app/pdump/meson.build| 2 +- app/proc-info/meson.build| 2 +- app/test-bbdev/meson.build | 2 +- app/test-crypto-perf/meson.build | 2 +- app/test-pmd/meson.build | 2 +- config

[dpdk-dev] [PATCH v10 11/12] usertools: add client python script for telemetry

2018-10-27 Thread Harry van Haaren
nt.py ". This script is useful to see how the Telemetry API for DPDK is used, and how to make the initial connection. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- v10: - Add MAINTAINER entry for client script (Thomas) --- M

[dpdk-dev] [PATCH v10 10/12] doc: add telemetry documentation

2018-10-27 Thread Harry van Haaren
: Brian Archbold Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren Acked-by: Marko Kovacevic --- v10: - Add MAINTAINERS entry for documentation (Thomas) --- MAINTAINERS| 1 + doc/guides/howto/index.rst | 1 + doc/guides/howto/telemetry.rst | 85

[dpdk-dev] [PATCH v10 09/12] telemetry: add ability to disable selftest

2018-10-27 Thread Harry van Haaren
l) made to the library. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- lib/librte_telemetry/rte_telemetry.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/lib/librte

[dpdk-dev] [PATCH v10 08/12] telemetry: format json response when sending stats

2018-10-27 Thread Harry van Haaren
-by: Kevin Laatz Acked-by: Harry van Haaren --- lib/librte_telemetry/Makefile | 1 + lib/librte_telemetry/meson.build | 4 +- lib/librte_telemetry/rte_telemetry.c | 962 +- lib/librte_telemetry/rte_telemetry.h | 15 + lib

[dpdk-dev] [PATCH v10 07/12] telemetry: update metrics before sending stats

2018-10-27 Thread Harry van Haaren
patch. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- lib/librte_telemetry/rte_telemetry.c | 134 ++ lib/librte_telemetry/rte_telemetry_internal.h | 4 + lib/librte_telemetry/rte_telemetry_parser.c

[dpdk-dev] [PATCH v10 06/12] telemetry: add parser for client socket messages

2018-10-27 Thread Harry van Haaren
: Harry van Haaren --- lib/librte_telemetry/Makefile | 1 + lib/librte_telemetry/meson.build | 4 +- lib/librte_telemetry/rte_telemetry.c | 8 + lib/librte_telemetry/rte_telemetry_internal.h | 13 + lib/librte_telemetry/rte_telemetry_parser.c | 569

[dpdk-dev] [PATCH v10 05/12] telemetry: add client feature and sockets

2018-10-27 Thread Harry van Haaren
writing to client sockets, and sending error responses. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- v10: - remove error prone pkg-config detection (Thomas) - Re-add -ljansson to mk/rte.app.mk, was in patch 1 (Thomas

[dpdk-dev] [PATCH v10 04/12] telemetry: add initial connection socket

2018-10-27 Thread Harry van Haaren
-by: Brian Archbold Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- lib/librte_telemetry/rte_telemetry.c | 225 ++ lib/librte_telemetry/rte_telemetry_internal.h | 4 + 2 files changed, 229 insertions(+) diff --git a/lib/librte_telemetry/rte_telemetry.c b

[dpdk-dev] [PATCH v10 02/12] eal: make get runtime dir function public

2018-10-27 Thread Harry van Haaren
From: Kevin Laatz This patch makes the eal_get_runtime_dir() API public so it can be used from outside EAL. Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- lib/librte_eal/bsdapp/eal/eal.c | 2 +- lib/librte_eal/common/eal_filesystem.h | 15 --- lib/librte_eal

[dpdk-dev] [PATCH v10 00/12] Introduce Telemetry Library

2018-10-27 Thread Harry van Haaren
This patchset introduces a Telemetry library for DPDK Service Assurance. This library provides an easy way to query DPDK Ethdev metrics. The telemetry library provides a method for a service assurance component to retrieve metrics from a DPDK packet forwarding application. Communicating from the s

[dpdk-dev] [PATCH v10 03/12] telemetry: initial telemetry infrastructure

2018-10-27 Thread Harry van Haaren
. Control threads are used to get CPU cycles for telemetry, which are configured in this patch also. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by: Kevin Laatz Signed-off-by: Radu Nicolau Acked-by: Harry van Haaren --- v10: - change position of Telemetry in index

[dpdk-dev] [PATCH v10 01/12] eal: add option register infrastructure

2018-10-27 Thread Harry van Haaren
oving circular dependency issues. Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren Acked-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/bsdapp/eal/eal.c| 14 - lib/librte_eal/common/Makefile | 1 + lib/librte_eal/c

[dpdk-dev] [PATCH v9 10/12] doc: add telemetry documentation

2018-10-26 Thread Harry van Haaren
: Brian Archbold Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren Acked-by: Marko Kovacevic --- MAINTAINERS| 5 ++ doc/guides/howto/index.rst | 1 + doc/guides/howto/telemetry.rst | 85 ++ doc/guides/rel_notes

[dpdk-dev] [PATCH v9 09/12] telemetry: add ability to disable selftest

2018-10-26 Thread Harry van Haaren
l) made to the library. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- lib/librte_telemetry/rte_telemetry.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/lib/librte

[dpdk-dev] [PATCH v9 06/12] telemetry: add parser for client socket messages

2018-10-26 Thread Harry van Haaren
: Harry van Haaren v9: - Add rte_telemetry_parse() to version map file for shared builds --- lib/librte_telemetry/Makefile | 1 + lib/librte_telemetry/meson.build | 4 +- lib/librte_telemetry/rte_telemetry.c | 8 + lib/librte_telemetry

[dpdk-dev] [PATCH v9 12/12] build: add dependency on telemetry to apps in meson

2018-10-26 Thread Harry van Haaren
Nicolau Acked-by: Harry van Haaren --- app/meson.build | 4 ++-- app/pdump/meson.build| 2 +- app/proc-info/meson.build| 2 +- app/test-bbdev/meson.build | 2 +- app/test-crypto-perf/meson.build | 2 +- app/test-pmd/meson.build | 2 +- config

[dpdk-dev] [PATCH v9 11/12] usertools: add client python script for telemetry

2018-10-26 Thread Harry van Haaren
nt.py ". This script is useful to see how the Telemetry API for DPDK is used, and how to make the initial connection. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- usertools/dpdk-telemetry-client.py | 116 ++

[dpdk-dev] [PATCH v9 05/12] telemetry: add client feature and sockets

2018-10-26 Thread Harry van Haaren
writing to client sockets, and sending error responses. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- v9: - Meson build disables if jansson not available (Thomas/Bruce) - Add link to Jansson library (was in patch 3) (Thomas

[dpdk-dev] [PATCH v9 08/12] telemetry: format json response when sending stats

2018-10-26 Thread Harry van Haaren
-by: Kevin Laatz Acked-by: Harry van Haaren --- lib/librte_telemetry/Makefile | 1 + lib/librte_telemetry/meson.build | 4 +- lib/librte_telemetry/rte_telemetry.c | 962 +- lib/librte_telemetry/rte_telemetry.h | 15 + lib

  1   2   3   4   5   6   7   >