Re: [dpdk-dev] [PATCH 30/38] net/qede: Don't use eth_driver

| >vfio"); >-RTE_PMD_REGISTER_PCI(net_qede_vf, rte_qedevf_pmd.pci_drv); >+RTE_PMD_REGISTER_PCI(net_qede_vf, rte_qedevf_pmd); > RTE_PMD_REGISTER_PCI_TABLE(net_qede_vf, pci_id_qedevf_map); > RTE_PMD_REGISTER_KMOD_DEP(net_qede_vf, "* igb_uio | vfio"); >diff --git a/dri

Re: [dpdk-dev] [PATCH 17/38] net/bnx2x: Don't use eth_driver

_bnx2x, "* igb_uio | uio_pci_generic | >vfio"); >-RTE_PMD_REGISTER_PCI(net_bnx2xvf, rte_bnx2xvf_pmd.pci_drv); >+RTE_PMD_REGISTER_PCI(net_bnx2xvf, rte_bnx2xvf_pmd); > RTE_PMD_REGISTER_PCI_TABLE(net_bnx2xvf, pci_id_bnx2xvf_map); > RTE_PMD_REGISTER_KMOD_DEP(net_bnx2xvf, "* igb_uio | vfio"); >-- >2.7.4 > > Acked-by: Harish Patil

Re: [dpdk-dev] [PATCH] net/bnx2x: Fix transmit queue free threshold

7 +11,7 @@ > #ifndef _BNX2X_RXTX_H_ > #define _BNX2X_RXTX_H_ > >-#define DEFAULT_TX_FREE_THRESH 512 >+#define DEFAULT_TX_FREE_THRESH 64 > #define RTE_PMD_BNX2X_TX_MAX_BURST 1 > > /** >-- >2.1.4 > > Acked-by: Harish Patil

Re: [dpdk-dev] bnx2x and VFIO

> >This PMD driver doesn't seem to work with VFIO. I haven't had time >to look into it very closely, so I was going to ask here first just >in case someone had any ideas why this might be the case. Thanks >for any pointers here! > Hi Chas, Yes its a known issue - we haven’t looked at it yet, but

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/5] net/qede: fix scatter-gather issue

> >On 12/31/2016 8:16 AM, Rasesh Mody wrote: >> From: Harish Patil >> >> - Make qede_process_sg_pkts() inline and add unlikely check >> - Fix mbuf segment chaining logic in qede_process_sg_pkts() >> - Change qede_encode_sg_bd() to return total segment

[dpdk-dev] [PATCH v2 6/7] net/qede: fix reporting of SR-IOV PF driver as disabled

qede PMD does not support SR-IOV PF driver functionality, so max_vfs is set to 0 to imply the same. Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[dpdk-dev] [PATCH v2 5/7] net/qede: fix RSS related issue

use of existing RSS APIs for default RSS configuration Fixes: 6d9e26c42c0d ("net/qede: get RSS hash configuration") Fixes: 9c5d0a669f9b ("net/qede: fix RSS") Signed-off-by: Harish Patil --- drivers/net/qede/qede_eth_if.c | 79 + drivers/net/qede/qede_eth_if.h |

[dpdk-dev] [PATCH v2 7/7] net/qede: restrict maximum queues for PF/VF

;qede: add core driver") Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c | 13 ++--- drivers/net/qede/qede_ethdev.h |3 +++ drivers/net/qede/qede_main.c |5 - 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c

[dpdk-dev] [PATCH v2 4/7] net/qede: add fastpath support for VXLAN tunneling

- Support HW checksum and RSS offload for VXLAN traffic - Identify inner/outer packet_types using lookup table - Update documentation Signed-off-by: Harish Patil --- doc/guides/nics/features/qede.ini |3 + doc/guides/nics/qede.rst |3 +- drivers/net/qede/qede_eth_if.h|3

[dpdk-dev] [PATCH v2 1/7] net/qede: reduce noise in debug logs

Move DP_NOTICE msg under CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO. Signed-off-by: Harish Patil --- drivers/net/qede/qede_logs.h | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/net/qede/qede_logs.h b/drivers/net/qede/qede_logs.h index 45c4af0..13b76a7 100644

[dpdk-dev] [PATCH v2 2/7] net/qede: fix filtering code

other change is to remove filter_config from struct qed_eth_ops_pass and invoke the base APIs directly. This avoids the need to have multiple structs and function calls. Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Harish Patil --- drivers/net/qede/qede_eth_i

[dpdk-dev] [PATCH v2 3/7] net/qede: add slowpath support for VXLAN tunneling

- Enable/disable VXLAN tunneling - Add/remove VXLAN classification rules - Destination UDP port configuration Signed-off-by: Harish Patil --- drivers/net/qede/base/ecore_l2.c |3 + drivers/net/qede/base/ecore_l2_api.h |1 + drivers/net/qede/qede_ethdev.c | 400

Re: [dpdk-dev] [PATCH v4 12/23] bnx2x: localize mapping from eth_dev to pci

gt;pci_dev->intr_handle)); >- rte_intr_callback_unregister(&(dev->pci_dev->intr_handle), >+ rte_intr_disable(&sc->pci_dev->intr_handle); >+ rte_intr_callback_unregister(&sc->pci_dev->intr_handle, > bnx2x_interrupt_handler, (void *)dev); > } > >-- >2.7.4 > > Acked-by: Harish Patil

Re: [dpdk-dev] [PATCH v4 14/23] qede: localize mapping of eth_dev to pci

intr_handle, >+ rte_intr_callback_register(&pci_dev->intr_handle, > qede_interrupt_handler, (void *)eth_dev); > >- if (rte_intr_enable(ð_dev->pci_dev->intr_handle)) { >+ if (rte_intr_enable(&pci_dev->intr_handle)) { > DP_ERR(edev, "rte_intr_enable() failed\n"); > return -ENODEV; > } >-- >2.7.4 > > Acked-by: Harish Patil

Re: [dpdk-dev] [PATCH 6/7] net/qede: fix maximum VF count to 0

> >2016-12-12 18:13, Ferruh Yigit: >> On 12/12/2016 5:47 PM, Harish Patil wrote: >> >> btw, while checking feature list, I have seen qede_vf supports >>SR-IOV, >> >> is that correct? >> > >> > Yes. The supported combination for SR-I

Re: [dpdk-dev] [PATCH 7/7] net/qede: restrict maximum queues for PF/VF

> >On 12/12/2016 7:29 PM, Harish Patil wrote: >> >>> On 12/3/2016 2:43 AM, Harish Patil wrote: >>>> Fix to adverstise max_rx_queues by taking into account the number >>> >>> s/adverstise/advertise >> >> Will correct that, thanks.

Re: [dpdk-dev] [PATCH 2/7] net/qede: refactor filtering code

> >On 12/12/2016 5:36 PM, Harish Patil wrote: >> >>> On 12/3/2016 2:43 AM, Harish Patil wrote: >>>> The filter_config in qed_eth_ops_pass is a wrapper call driving all >>>>the >>>> filtering configuration. This requires defining mu

Re: [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs

> >On 12/12/2016 5:15 PM, Harish Patil wrote: >> Hi Ferruh, >> >>> On 12/3/2016 2:43 AM, Harish Patil wrote: >>>> From: Rasesh Mody >>>> >>>> Replace CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER with >>>> CONFIG_RTE_LIBRTE_QEDE_

Re: [dpdk-dev] [PATCH 7/7] net/qede: restrict maximum queues for PF/VF

>On 12/3/2016 2:43 AM, Harish Patil wrote: >> Fix to adverstise max_rx_queues by taking into account the number > >s/adverstise/advertise Will correct that, thanks. > >> of PF connections instead of returning max_queues supported by the >> HW. > >Can you plea

Re: [dpdk-dev] [PATCH] net/qede: fix resource leak

>On 11/30/2016 12:32 PM, Yong Wang wrote: >> Current code does not close 'fd' on function exit, leaking resources. >> >> Signed-off-by: Yong Wang >> --- > >Add new mail address of the maintainer. > >CC: Harish Patil > ><...> > Acked-by: Harish Patil

Re: [dpdk-dev] [PATCH 6/7] net/qede: fix maximum VF count to 0

>On 12/3/2016 2:43 AM, Harish Patil wrote: >> Set max_vfs to 0 since it is relevant only to SR-IOV PF >> which is not supported yet. >> >> Fixes: 2ea6f76a ("qede: add core driver") >> >> Signed-off-by: Harish Patil > >Can you please upda

Re: [dpdk-dev] [PATCH 2/7] net/qede: refactor filtering code

>On 12/3/2016 2:43 AM, Harish Patil wrote: >> The filter_config in qed_eth_ops_pass is a wrapper call driving all the >> filtering configuration. This requires defining multiple structures and >> passing different function arguments for each filter type which is >> unne

Re: [dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs

Hi Ferruh, >On 12/3/2016 2:43 AM, Harish Patil wrote: >> From: Rasesh Mody >> >> Replace CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER with >> CONFIG_RTE_LIBRTE_QEDE_DEBUG_VAL which is a 32-bit bitmapped value >> where each bit represent a particular submodule to debug. A

[dpdk-dev] [PATCH 7/7] net/qede: restrict maximum queues for PF/VF

Fix to adverstise max_rx_queues by taking into account the number of PF connections instead of returning max_queues supported by the HW. Fixes: 2ea6f76a ("qede: add core driver") Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c | 13 ++--- drivers/net/qede/qed

[dpdk-dev] [PATCH 6/7] net/qede: fix maximum VF count to 0

Set max_vfs to 0 since it is relevant only to SR-IOV PF which is not supported yet. Fixes: 2ea6f76a ("qede: add core driver") Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/qede/qede_

[dpdk-dev] [PATCH 5/7] net/qede: fix RSS related issue

use of existing RSS APIs for default RSS configuration Fixes: 6d9e26c4 ("net/qede: get RSS hash configuration") Fixes: 9c5d0a66 ("net/qede: fix RSS") Signed-off-by: Harish Patil --- drivers/net/qede/qede_eth_if.c | 79 + drivers/net/qede/qede_eth_if.h | 9

[dpdk-dev] [PATCH 4/7] net/qede: add fastpath support for VXLAN tunneling

- Support HW checksum and RSS offload for VXLAN traffic - Identify inner/outer packet_types using lookup table - Update documentation Signed-off-by: Harish Patil --- doc/guides/nics/features/qede.ini | 3 + doc/guides/nics/qede.rst | 3 +- drivers/net/qede/qede_eth_if.h| 3

[dpdk-dev] [PATCH 1/7] net/qede: reduce noise in debug logs

From: Rasesh Mody Replace CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER with CONFIG_RTE_LIBRTE_QEDE_DEBUG_VAL which is a 32-bit bitmapped value where each bit represent a particular submodule to debug. Also move notice messages under CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO. Signed-off-by: Harish Patil Signed

[dpdk-dev] [PATCH 2/7] net/qede: refactor filtering code

: add core driver") Signed-off-by: Harish Patil --- drivers/net/qede/qede_eth_if.c | 101 +- drivers/net/qede/qede_eth_if.h | 36 + drivers/net/qede/qede_ethdev.c | 303 - drivers/net/qede/qede_ethdev.h | 15 ++ 4 files changed, 230

[dpdk-dev] [PATCH 3/7] net/qede: add slowpath support for VXLAN tunneling

- Enable/disable VXLAN tunneling - Add/remove VXLAN classification rules - Destination UDP port configuration Signed-off-by: Harish Patil --- drivers/net/qede/base/ecore_l2.c | 3 + drivers/net/qede/base/ecore_l2_api.h | 1 + drivers/net/qede/qede_ethdev.c | 400

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

> > > >Hi Harish, >> >> >> >We need attention of every PMD developers on this thread. >> > >> >Reminder of what Konstantin suggested: >> >" >> >- if the PMD supports TX offloads AND >> >- if to be able use any of these offloads the upper layer SW would have >> >to: >> >* modify the contents o

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

>We need attention of every PMD developers on this thread. > >Reminder of what Konstantin suggested: >" >- if the PMD supports TX offloads AND >- if to be able use any of these offloads the upper layer SW would have >to: >* modify the contents of the packet OR >* obey HW specific restrict

[dpdk-dev] [PATCH v2] net/qede: fix unknown speed errmsg for 25G link

- Fix to use bitmapped values in NVM configuration for speed capability advertisement. This issue is specific to 25G NIC since it is capable of 25G and 10G speeds. - Update feature list. Fixes: 64c239b7f8b7 ("net/qede: fix advertising link speed capability") Signed-off-by: Ha

[dpdk-dev] [PATCH v3] net/qede: fix advertising link speed capability

> >2016-10-31 11:35, Rasesh Mody: >> From: Harish Patil >> >> Fix to advertise device's link speed capability based on NVM >> port configuration instead of returning driver supported speeds. >> >> Fixes: 95e67b479506 ("net/qede: add 100G

[dpdk-dev] [PATCH] scripts: remove zlib dependency to test qede build

,' $1/.config > test "$DPDK_DEP_PCAP" != y || \ > sed -ri 's,(PCAP=)n,\1y,' $1/.config >-- >2.7.0 > > Acked-by: Harish Patil

[dpdk-dev] [PATCH] net/qede: fix advertising link speed capability

>2016-10-27 23:42, Rasesh Mody: >> From: Harish Patil >> >> Fix to advertise device's link speed capability based on current >> link speed rather than returning driver supported speeds. >[...] >> -dev_info->speed_ca

[dpdk-dev] [PATCH v4 18/32] net/qede: add missing 100G link speed capability

>2016-10-18 21:11, Rasesh Mody: >> From: Harish Patil >> >> This patch fixes the missing 100G link speed advertisement >> when the 100G support was initially added. >> >> Fixes: 2af14ca79c0a ("net/qede: support 100G") >> >>

[dpdk-dev] [PATCH 1/2] bnx2x: fix maximum PF queues

> >On Wed, 2016-10-05 at 22:36 -0700, Rasesh Mody wrote: >> Fix the max number of PF rx/tx queues. Set the value based >> on BNX2X_MAX_RSS_COUNT() rather than hard coding it to 128. >> >> Fixes: 540a211 ("bnx2x: driver core") >> >> Signed-off-by: Rasesh Mody >> --- >> drivers/net/bnx2x/bnx2x.c

[dpdk-dev] [PATCH v2 10/10] bnx2x: Merge debug register operations into headers

uct bnx2x_softc *sc, size_t offset) >-{ >- uint16_t val; >- >- if ((offset % 2) != 0) { >- PMD_DRV_LOG(NOTICE, "Unaligned 16-bit read from 0x%08lx", >- (unsigned long)offset); >- } >- >- val = (uint16_t)(*((volatile >uint16_t*)((uintptr_t)sc->bar[BAR0].base_addr + offset))); >- PMD_DEBUG_PERIODIC_LOG(DEBUG, "offset=0x%08lx val=0x%08x", (unsigned >long)offset, val); >- >- return val; >-} >- >-uint32_t >-bnx2x_reg_read32(struct bnx2x_softc *sc, size_t offset) >-{ >- uint32_t val; >- >- if ((offset % 4) != 0) { >- PMD_DRV_LOG(NOTICE, "Unaligned 32-bit read from 0x%08lx", >- (unsigned long)offset); >- return 0; >- } >- >- val = (uint32_t)(*((volatile >uint32_t*)((uintptr_t)sc->bar[BAR0].base_addr + offset))); >- PMD_DEBUG_PERIODIC_LOG(DEBUG, "offset=0x%08lx val=0x%08x", (unsigned >long)offset, val); >- >- return val; >-} >-- >2.7.4 > > There is no cover letter. So please treat this acking the series. Acked-by: Harish Patil

[dpdk-dev] virtio PMD issue

> >it is fixed in 16.07-rc2 that I checked Great, thanks. > >Vincent > >On Fri, Jul 15, 2016 at 11:48 AM, Harish Patil >wrote: >> Hi Huawie/Yuanhan, >> I encounter segfault issue in virtio PMD driver when I run any DPDK >> application in the VM. The virtio

[dpdk-dev] virtio PMD issue

Hi Huawie/Yuanhan, I encounter segfault issue in virtio PMD driver when I run any DPDK application in the VM. The virtio devices should not have been probed in the first place since they are not attached to igb_uio driver (and managed by kernel driver). Network devices using DPDK-compatible drive

[dpdk-dev] [PATCH 01/10] bnx2x: Set cache line based on build configuration

RX_ALIGN_END (1 << BNX2X_RX_ALIGN_SHIFT) >+#define BNX2X_RX_ALIGN_SHIFT RTE_MAX(6, min(8, RTE_CACHE_LINE_SIZE_LOG2)) > > #define BNX2X_PXP_DRAM_ALIGN (BNX2X_RX_ALIGN_SHIFT - 5) > >-- >2.5.5 > > Acked-by: Harish Patil

[dpdk-dev] [PATCH] bnx2x: Correctly determine MSIX vector count

msix_cap_reg + PCIR_MSIX_CTRL), &val, >2); >- sc->igu_sb_cnt = (val & PCIM_MSIXCTRL_TABLE_SIZE); >+ sc->igu_sb_cnt = (val & PCIM_MSIXCTRL_TABLE_SIZE) + 1; > } else { > sc->igu_sb_cnt = 1; > } >-- >2.5.5 > > Acked-by: Harish Patil

[dpdk-dev] [PATCH] bnx2x: Don't reset buf_len in RX mbufs

t_len = rx_mb->data_len = len; > rx_mb->port = rxq->port_id; >- rx_mb->buf_len = len + pad; > rte_prefetch1(rte_pktmbuf_mtod(rx_mb, void *)); > > /* >-- >2.5.5 > > Acked-by: Harish Patil

[dpdk-dev] [PATCH 2/2] qede: return LAN stats to MFW

> > > >> -Original Message- >> From: Harish Patil [mailto:harish.patil at qlogic.com] >> Sent: Wednesday, June 1, 2016 3:16 PM >> To: Thomas Monjalon >> Cc: dev at dpdk.org; Richardson, Bruce ; >> Rasesh >> Mody ; Dept-Eng DPDK Dev &g

[dpdk-dev] [PATCH 2/2] qede: return LAN stats to MFW

> >2016-05-31 19:21, Harish Patil: >> >> >On Fri, May 06, 2016 at 09:21:31PM -0700, Rasesh Mody wrote: >> >> From: Harish Patil >> >> >> >> Under certain scenarios, MFW periodically polls the driver >> >> for LAN stati

[dpdk-dev] [PATCH 2/2] qede: return LAN stats to MFW

>On Fri, May 06, 2016 at 09:21:31PM -0700, Rasesh Mody wrote: >> From: Harish Patil >> >> Under certain scenarios, MFW periodically polls the driver >> for LAN statistics. This patch implements the osal hook to >> fill in the stats. >> >>

[dpdk-dev] KNI: Need for KNI-Ethtool support

Hello, Could you please let me know what is the use case for having ethtool support over KNI interfaces? Is it expected to be implemented by poll mode drivers? PMD APIs pretty much covers all the configuration/status retrieval needed from the nic, so not sure what is the the benefit of providing of

[dpdk-dev] [PATCH] qede: fix 32-bit build with debug enabled

"VF's Request mailbox [%p virt 0x%lx phys], Response" >- " mailbox [%p virt 0x%lx phys]\n", >+ "VF's Request mailbox [%p virt 0x%" PRIx64 " phys], " >+ "Response mailbox [%p virt 0x%" PRIx64 " phys]\n", > p_sriov->vf2pf_request, > (u64)p_sriov->vf2pf_request_phys, > p_sriov->pf2vf_reply, (u64)p_sriov->pf2vf_reply_phys); >@@ -339,7 +339,7 @@ enum _ecore_status_t ecore_vf_hw_prepare(struct >ecore_dev *p_dev) > p_sriov->bulletin. > size); > DP_VERBOSE(p_hwfn, ECORE_MSG_IOV, >- "VF's bulletin Board [%p virt 0x%lx phys 0x%08x bytes]\n", >+ "VF's bulletin Board [%p virt 0x%" PRIx64 " phys 0x%08x >bytes]\n", > p_sriov->bulletin.p_virt, (u64)p_sriov->bulletin.phys, > p_sriov->bulletin.size); > >-- >2.7.0 > > Looks good, thanks. Acked-by: Harish Patil

[dpdk-dev] [PATCH v4 1/3] bnx2x: refactor Tx routine for single doorbell mechanism

>> >> Fixes: 540a211084a7 ("bnx2x: driver core") >> >> Signed-off-by: Rasesh Mody >> Signed-off-by: Harish Patil > >Hi Rasesh, Harish, > >there is quite a bit of churn to the tx_encap routine in this patch, but >the >reason for that functio

[dpdk-dev] [PATCH] qede: fix icc build error

>-Werror -E - < /dev/null > /dev > CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion > endif > else >-#icc flags >+CFLAGS_BASE_DRIVER += -wd188 #188: enumerated type mixed with another >type > endif > > # >-- >2.5.5 > > Looks good. I hope its retested against gcc/clang also to make sure the change doesn?t cause build errors. Acked-by: Harish Patil

[dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build

>On Wed, Apr 20, 2016 at 10:51:06AM +0200, Thomas Monjalon wrote: >> 2016-04-20 00:14, Harish Patil: >> > >2016-03-31 19:15, Rasesh Mody: >> > >> --- a/config/common_base >> > >> +++ b/config/common_base >> > >> +CONFIG_RTE_LIBRT

[dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build

> >2016-04-20 00:14, Harish Patil: >> >2016-03-31 19:15, Rasesh Mody: >> >> --- a/config/common_base >> >> +++ b/config/common_base >> >> +CONFIG_RTE_LIBRTE_QEDE_RX_COAL_US=24 >> >> +CONFIG_RTE_LIBRTE_QEDE_TX_COAL_US=48 >> >

[dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build

> >2016-03-31 19:15, Rasesh Mody: >> --- a/config/common_base >> +++ b/config/common_base >> +CONFIG_RTE_LIBRTE_QEDE_RX_COAL_US=24 >> +CONFIG_RTE_LIBRTE_QEDE_TX_COAL_US=48 > >It looks to be some tuning which could be done at runtime. Isn't it? That?s right. Can you please suggest if there is any b

[dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build

> >2016-03-31 19:15, Rasesh Mody: >> --- a/scripts/test-build.sh >> +++ b/scripts/test-build.sh >> @@ -116,6 +116,7 @@ config () # >> test "$DPDK_DEP_ZLIB" != y || \ >> sed -ri 's,(BNX2X_PMD=)n,\1y,' $1/.config >> sed -ri's,(NFP_PMD=)n,

[dpdk-dev] [PATCH v5 01/10] qede: Add maintainers

> >2016-03-31 19:15, Rasesh Mody: >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -371,6 +371,13 @@ M: Declan Doherty >> F: drivers/crypto/aesni_gcm/ >> F: doc/guides/cryptodevs/aesni_gcm.rst >> >> +QLogic qede PMD >> +M: Harish Patil

[dpdk-dev] [PATCH v5 00/10] qede: Add qede PMD

> >On Thu, 31 Mar 2016 19:15:17 -0700 >Rasesh Mody wrote: > >> Hi Thomas, Bruce, >> >> The v5 series incorporates the following review comments: >> - move adapter_info logs under debug >> - implement qede_mac_addr_remove() >> - remove unused rc variable in qede_dev_configure() >> - fix indent

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

> >On Wed, 30 Mar 2016 22:16:51 + >Harish Patil wrote: > >> > >> >On Tue, 29 Mar 2016 22:28:20 -0700 >> >Rasesh Mody wrote: >> > >> >> + >> >> +static void qede_print_adapter_info(struct qede_dev *qdev) >> >>

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

> >On Tue, 29 Mar 2016 22:28:20 -0700 >Rasesh Mody wrote: > >> +static void >> +qede_alloc_etherdev(struct qede_dev *qdev, struct qed_dev_eth_info >>*info) >> +{ >> +rte_memcpy(&qdev->dev_info, info, sizeof(*info)); > >Why bother with rte_memcpy here? why not just assignment or memcpy()? Basi

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

> >On Tue, 29 Mar 2016 22:28:20 -0700 >Rasesh Mody wrote: > >> +static void >> +qede_mac_addr_remove(__rte_unused struct rte_eth_dev *eth_dev, >> + __rte_unused uint32_t index) >> +{ >> +struct qede_dev *qdev = eth_dev->data->dev_private; >> +struct ecore_dev *edev = &qdev-

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

> >On Tue, 29 Mar 2016 22:28:20 -0700 >Rasesh Mody wrote: > >> + >> +static void qede_print_adapter_info(struct qede_dev *qdev) >> +{ >> +struct ecore_dev *edev = &qdev->edev; >> +struct qed_dev_info *info = &qdev->dev_info.common; >> +char ver_str[QED_DRV_VER_STR_SIZE] = { 0 }; >> + >

[dpdk-dev] Question on examples/multi_process app

>> >> >> >> >> >>Hi Harish, >> >>> >> > >>> >> >> -Original Message- >>> >> >> From: Richardson, Bruce >>> >> >> Sent: Wednesday, March 23, 2016 11:45 AM >>&

[dpdk-dev] Question on examples/multi_process app

> > > >Hi Harish, > >> >> > >> >> >> -Original Message- >> >> >> From: Richardson, Bruce >> >> >> Sent: Wednesday, March 23, 2016 11:45 AM >> >> >> To: Ananyev, Konstantin >> >

[dpdk-dev] Updating bnx2x firmware

> >Guys, > > Currently, the bnx2x.c driver looks for the following firmware files >(when >PMD is enabled for it): > >--- >$ ~/sources/dpdk/dpdk-2.2.0/drivers/net/bnx2x$ grep lib\/firmware * >bnx2x.c:#define FW_NAME_57711 "/lib/firmware/bnx2x/bnx2x-e1h-7.2.51.0.fw" >bnx2x.c:#define FW_NAME_57810 "/l

[dpdk-dev] Question on examples/multi_process app

> > >> > >> >> -Original Message- >> >> From: Richardson, Bruce >> >> Sent: Wednesday, March 23, 2016 11:45 AM >> >> To: Ananyev, Konstantin >> >> Cc: Harish Patil; dev at dpdk.org >> >> Subject: Re: [

[dpdk-dev] Question on examples/multi_process app

> > > > >> -Original Message- >> From: Richardson, Bruce >> Sent: Wednesday, March 23, 2016 11:45 AM >> To: Ananyev, Konstantin >> Cc: Harish Patil; dev at dpdk.org >> Subject: Re: [dpdk-dev] Question on examples/multi_process app >>

[dpdk-dev] Question on examples/multi_process app

Hi, I have a question regarding symmetric_mp and mp_server applications under examples/multi_process. In those apps, rte_eth_promiscuous_enable() is called before rte_eth_dev_start(). Is this the correct way to initialize the port/device? As per the description in http://dpdk.org/doc/api/rte__ethde

[dpdk-dev] [PATCH 0/6] DPDK PMD for new QLogic FastLinQ QL4xxxx 25G/40G CNAs

>> >> >> >>On Sat, Feb 20, 2016 at 07:40:25AM -0800, Harish Patil wrote: >>> This patch set introduces DPDK poll mode driver for new QLogic FastLinQ >>>QL4 >>> 25G/40G capable family of CNAs as well as their SR-IOV Virtual >>>Funct

[dpdk-dev] [PATCH v2 02/10] qede: add documentation

> >2016-03-10 05:45, Rasesh Mody: >> doc/guides/nics/index.rst |1 + >> doc/guides/nics/qede.rst | 340 >>+ >> 2 files changed, 341 insertions(+) > >It would be nice to see a new column in the matrix of overview.rst. > Hi Thomas, Yes, we had updat

[dpdk-dev] [PATCH 0/6] DPDK PMD for new QLogic FastLinQ QL4xxxx 25G/40G CNAs

> >On Sat, Feb 20, 2016 at 07:40:25AM -0800, Harish Patil wrote: >> This patch set introduces DPDK poll mode driver for new QLogic FastLinQ >>QL4 >> 25G/40G capable family of CNAs as well as their SR-IOV Virtual >>Functions (VF). >> >> The overall

[dpdk-dev] [PATCH 2/6] qede: add documentation

>> >>-Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Harish Patil >> Sent: Saturday, February 20, 2016 3:40 PM >> To: dev at dpdk.org >> Cc: Sony Chacko >> Subject: [dpdk-dev] [PATCH 2/6] qede: add documentation >

[dpdk-dev] [PATCH 4/6] qede: add driver common module

> >On Sat, 20 Feb 2016 07:58:31 -0800 > wrote: > >> +unsigned long log2_align(unsigned long n) >> +{ > >Common code is good, but you need to practice good function name >hygiene on public functions to avoid any namespace clashes when >using static linking. > >The application might define a function

[dpdk-dev] [PATCH 5/6] qede: add driver

>> >> >> >>On Tue, 23 Feb 2016 02:28:25 + >>Harish Patil wrote: >> >>> All of the checkpatch warnings had been fixed (except one which cannot >>>be >>> fixed) using the checkpatch script available under DPDK scripts/ >>

[dpdk-dev] [PATCH 5/6] qede: add driver

> >On Tue, 23 Feb 2016 02:28:25 + >Harish Patil wrote: > >> All of the checkpatch warnings had been fixed (except one which cannot >>be >> fixed) using the checkpatch script available under DPDK scripts/ >> directory. The linux checkpatch version i

[dpdk-dev] [PATCH 0/6] DPDK PMD for new QLogic FastLinQ QL4xxxx 25G/40G CNAs

> >2016-02-22 16:47, Harish Patil: >> >Please could you share some performance numbers? >> >> We have measured ~68 MPPS @ 64B with zero drop for the 4x25G adapter >> running bi-di RFC traffic. > >How many queues/cores to achieve this performance? Using s

[dpdk-dev] [PATCH 5/6] qede: add driver

> >On Sat, 20 Feb 2016 07:40:30 -0800 >Harish Patil wrote: > >> Signed-off-by: Harish Patil >> Signed-off-by: Rasesh Mody >> Signed-off-by: Sony Chacko >> --- >> drivers/net/qede/LICENSE.qede_pmd | 28 + >> drivers/net/qede/Makefil

[dpdk-dev] [PATCH 3/6] qede: add QLogic PCI ids

> >On Sat, 20 Feb 2016 07:40:28 -0800 >Harish Patil wrote: > >> diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h >>b/lib/librte_eal/common/include/rte_pci_dev_ids.h >> index d088191..0c1a3fe 100644 >> --- a/lib/librte_eal/common/include/rte_p

[dpdk-dev] [PATCH 0/6] DPDK PMD for new QLogic FastLinQ QL4xxxx 25G/40G CNAs

> >2016-02-20 07:40, Harish Patil: >> This patch set introduces DPDK poll mode driver for new QLogic FastLinQ >>QL4 >> 25G/40G capable family of CNAs as well as their SR-IOV Virtual >>Functions (VF). >> >> The overall PMD driver design includes a commo

[dpdk-dev] [PATCH 6/6] qede: enable PMD build

Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- config/common_bsdapp | 15 +++ config/common_linuxapp | 16 drivers/net/Makefile | 1 + mk/rte.app.mk | 2 ++ scripts/test-build.sh | 1 + 5 files changed, 35

[dpdk-dev] [PATCH 5/6] qede: add driver

Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- drivers/net/qede/LICENSE.qede_pmd | 28 + drivers/net/qede/Makefile | 95 ++ drivers/net/qede/qede_eth_if.c| 461 ++ drivers/net/qede/qede_eth_if.h

[dpdk-dev] [PATCH 3/6] qede: add QLogic PCI ids

Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- lib/librte_eal/common/include/rte_pci_dev_ids.h | 44 + 1 file changed, 44 insertions(+) diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h b/lib/librte_eal/common/include

[dpdk-dev] [PATCH 2/6] qede: add documentation

Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- doc/guides/nics/index.rst | 1 + doc/guides/nics/qede.rst | 344 ++ 2 files changed, 345 insertions(+) create mode 100644 doc/guides/nics/qede.rst diff --git a

[dpdk-dev] [PATCH 1/6] qede: add maintainers

Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 628bc05..1b27467 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -352,6 +352,13 @@ Null PMD M: Tetsuya

[dpdk-dev] [PATCH 0/6] DPDK PMD for new QLogic FastLinQ QL4xxxx 25G/40G CNAs

implements DPDK exported APIs/driver entry points by interfacing with the common module for configuration/status and also the fastpath routines. Included in the patch set is the supporting documentation and maintainers. Please apply. Thanks, Harish Patil (6): qede: add maintainers qede: add

[dpdk-dev] [PATCH v5 3/4] ethdev: redesign link speed config API

From: Marc Sune mailto:marcde...@gmail.com>> Date: Sunday, October 4, 2015 at 2:12 PM To: "dev at dpdk.org" mailto:dev at dpdk.org>> Subject: [dpdk-dev] [PATCH v5 3/4] ethdev: redesign link speed config API This patch redesigns the API to set the link speed/s configure f

[dpdk-dev] bnx2x driver and 57800 versus 57810

> >I have to practically identical systems, same hypervisor on each (Centos >7.x). In one, I have a 57800 card which works fine with DPDK with >SRIOV. In the other, I have a 57810 card which doesn't work with SRIOV. > >For the 57810 I have tracked this down to the status block in the VF >failing

[dpdk-dev] [PATCH] bnx2x: remove unused mbuf_alloc_size

S (9 * 1024) >-#define MJUM16BYTES (16 * 1024) >- > /* > * Transmit Buffer Descriptor (tx_bd) definitions* > */ >@@ -402,7 +385,6 @@ struct bnx2x_fastpath { > uint8_t fw_sb_id; /* status block number in FW */ > > uint32_t rx_buf_size; >- int

[dpdk-dev] bnx2x pmd performance expectations

> >Thank you for pointing this out. While it seems to me problem here is RX, >I >will also look into TX burst limitations. > >-a > >On 28 December 2015 at 00:17, Chas Williams <3chas3 at gmail.com> wrote: > >> I wouldn't consider myself an expert on this driver but while looking >> at some other th

[dpdk-dev] [PATCH] bnx2x: set Ethernet address type during transmit for VF's

>On Tue, Dec 08, 2015 at 09:27:05AM -0500, Charles (Chas) Williams wrote: >> On Mon, 2015-12-07 at 17:29 +0000, Harish Patil wrote: >> > > >> > >On Sun, 2015-12-06 at 23:34 +, Harish Patil wrote: >> > >> > >> > >> >

[dpdk-dev] [PATCH] bnx2x: set Ethernet address type during transmit for VF's

> >On Sun, 2015-12-06 at 23:34 +, Harish Patil wrote: >> > >> >The original was always setting unicast. While here, clean up some >> >other references that also point into the Ethernet header. >> > >> >Signed-off-by: Chas Williams <3chas

[dpdk-dev] [PATCH] bnx2x: set Ethernet address type during transmit for VF's

> /* >- * Ethernet address typesm used in ethernet tx BDs >+ * Ethernet address types used in ethernet tx BDs > */ > enum eth_addr_type > { >@@ -4037,7 +4037,8 @@ enum eth_addr_type > UNICAST_ADDRESS, > MULTICAST_ADDRESS, > BROADCAST_ADDRESS, >-

[dpdk-dev] [PATCH] bnx2x: tx_start_bd->vlan_or_ethertype is le16

> >On Tue, 1 Dec 2015 21:53:59 + >Harish Patil wrote: > >> > >> >Anyone to review please? >> > >> >2015-11-03 12:26, Chas Williams: >> >> Signed-off-by: Chas Williams <3chas3 at gmail.com> >> >> --- >> >

[dpdk-dev] [PATCH] bnx2x: tx_start_bd->vlan_or_ethertype is le16

x_start_bd->vlan_or_ethertype >> + = >> rte_cpu_to_le_16(rte_be_to_cpu_16(eh->ether_type)); >> } >> } > > Acked-by: Harish Patil Minor question - any specific reason to use rte_be_to_cpu_16() on ether_type alone before con

[dpdk-dev] [PATCH] l3fwd: Fix l3fwd crash due to unaligned load/store intrinsics

unaligned >>load/store intrinsics >> >> From: Harish Patil >> >> l3fwd app expects PMDs to return packets whose L2 header is >> 16-byte aligned due to usage of _mm_load_si128()/_mm_store_si128() >> intrinsics in the app. However, most of the protoco

[dpdk-dev] [PATCH 3/5] bnx2x: Add RTE_LIBRTE_BNX2X_REG_ACCESS config option

>> >Either other "debug" logs can be put as INFO level, or >> >you need a level 9 for verbose debug. >> >But I don't really understand what is the problem of a verbose debug. >> > >> >It is not critical for the acceptance of this patch. Just wanted to >> >discuss >> >it as we have many config opti

[dpdk-dev] PMD/l3fwd issue

> > >> -Original Message----- >> From: Harish Patil [mailto:harish.patil at qlogic.com] >> Sent: Friday, September 04, 2015 2:08 PM >> To: Ananyev, Konstantin; dev at dpdk.org >> Cc: Ameen Rahman >> Subject: Re: PMD/l3fwd issue >> >> Hi

[dpdk-dev] [PATCH 3/5] bnx2x: Add RTE_LIBRTE_BNX2X_REG_ACCESS config option

>2015-10-23 22:28, Harish Patil: >> >2015-09-11 17:42, Rasesh Mody: >> >> From: Harish Patil >> >> --- a/config/common_linuxapp >> >> +++ b/config/common_linuxapp >> >> @@ -220,6 +220,7 @@ CONFIG_RTE_LIBRTE_

[dpdk-dev] [PATCH] bnx2x: use bnx2xvf driver for VF devices

I_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57810_MF) > RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, BNX2X_DEV_ID_57811_MF) >-- >2.1.0 > > Acked-by: Harish Patil Thanks, Harish This message and any attached documents contain inf

[dpdk-dev] [PATCH 2/5] bnx2x: Fix x86_64-native-linuxapp-clang build error

>2015-10-23 16:36, Harish Patil: >> > >> >2015-09-11 17:42, Rasesh Mody: >> >> #define SHMEM_EEE_ADV_STATUS_MASK 0x00f0 >> >> #define SHMEM_EEE_100M_ADV (1<<0) >> >> -#defi

[dpdk-dev] Status of bnx2x pmd?

> >I have been attempting to build testpmd with the bnx2x pmd enabled to try >and talk through a bcm57810 10G NIC card. I have tried using SR-IOV VFs >and I have tried using the PFs. Neither seem to be able to be properly >initialized in testpmd and/or testpmd aborts. > >Is this PMD actually usable

  1   2   >