Use new guest channel API to send confirmation
message for received power command.
Signed-off-by: Marcin Hajkowski
Tested-by: David Hunt
Acked-by: Lee Daly
---
examples/vm_power_manager/channel_monitor.c | 68 +++--
1 file changed, 62 insertions(+), 6 deletions(-)
diff --git
Extend vm_power_guest to check incoming confirmations
of messages previously sent to host.
Signed-off-by: Marcin Hajkowski
Tested-by: David Hunt
Acked-by: Lee Daly
---
examples/vm_power_manager/guest_cli/Makefile | 1 +
.../guest_cli/vm_power_cli_guest.c| 73
by: Marcin Hajkowski
Reviewed-by: Maxime Coquelin
Acked-by: Anatoly Burakov
---
lib/librte_power/guest_channel.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/librte_power/guest_channel.c b/lib/librte_power/guest_channel.c
index c17ea46b4..9cf7d2cb2 100644
c
v2:
* send ack only if power operation return positive value
* log diffent error for unexpected incoming command and
error during ack/nak cmd sending
Marcin Hajkowski (4):
[PATCH v6 1/4] power: fix invalid socket indicator value
[PATCH v6 2/4] power: extend guest channel API for reading
[PATCH
Added new experimental API rte_power_guest_channel_receive_msg
which gives possibility to receive messages send to guest.
Signed-off-by: Marcin Hajkowski
Tested-by: David Hunt
Acked-by: Lee Daly
---
lib/librte_power/channel_commands.h| 5 +++
lib/librte_power/guest_channel.c | 60
From: Marcin Hajkowski
This patch implement a separate FIFO for each cpu core.
For proper handling JSON interface, removed fields from cmds:
core_list, resource_id, name.
Please note that this patchset depends on
http://patchwork.dpdk.org/patch/52824/
---
v4:
* changes due to code rebase
v3
From: Marcin Hajkowski
Updated power management docs for fifo JSON API.
Removed from JSON API:
* 'name'
* 'resource_id'
* 'core_list'
Signed-off-by: Marcin Hajkowski
Signed-off-by: Lukasz Krakowiak
Signed-off-by: Lukasz Gosiewski
---
.../sample_app_ug/vm
From: Marcin Hajkowski
This patch implement a separate FIFO for each cpu core.
For proper handling JSON interface, removed fields from cmds:
core_list, resource_id, name.
Signed-off-by: Lukasz Krakowiak
Signed-off-by: Lukasz Gosiewski
Signed-off-by: Marcin Hajkowski
---
examples
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lukasz Krakowiak
> Sent: Monday, April 8, 2019 12:45 PM
> To: Hunt, David
> Cc: dev@dpdk.org; Krakowiak, LukaszX
> Subject: [dpdk-dev] [PATCH 0/2] power: add fifo per core for JSON interface
>
> This patch impl
gt; ret = rte_power_exit(TEST_POWER_LCORE_ID);
> if (ret < 0) {
> @@ -502,6 +570,10 @@ test_power_cpufreq(void)
> if (ret < 0)
> goto fail_all;
>
> + ret = check_power_turbo();
> + if (ret < 0)
> + goto fail_all;
> +
> ret = rte_power_exit(TEST_POWER_LCORE_ID);
> if (ret < 0) {
> printf("Cannot exit power management for lcore %u\n",
> --
> 2.19.2.windows.1
Tested-by: Marcin Hajkowski
ead opening brace to closing brace */
> do {
> @@ -828,13 +865,15 @@ read_json_packet(struct channel_info *chan_info)
> root = json_loads(json_data, 0, &error);
>
> if (root) {
> + resource_name =
> get_resource_name_from_chn_path(
> + chan_info->channel_path);
> /*
>* Because our data is now in the json
>* object, we can overwrite the pkt
>* with a channel_packet struct, using
>* parse_json_to_pkt()
>*/
> - ret = parse_json_to_pkt(root, &pkt);
> + ret = parse_json_to_pkt(root, &pkt, resource_name);
> json_decref(root);
> if (ret) {
> RTE_LOG(ERR, CHANNEL_MONITOR,
> @@ -891,9 +930,9 @@ run_channel_monitor(void)
> }
> rte_delay_us(time_period_ms*1000);
> if (policy_is_set) {
> - int j;
> + unsigned int j;
>
> - for (j = 0; j < MAX_CLIENTS; j++) {
> + for (j = 0; j < RTE_DIM(policies); j++) {
> if (policies[j].enabled == 1)
> apply_policy(&policies[j]);
> }
> diff --git a/examples/vm_power_manager/main.c
> b/examples/vm_power_manager/main.c
> index 893bf4cdd..9f24cf69b 100644
> --- a/examples/vm_power_manager/main.c
> +++ b/examples/vm_power_manager/main.c
> @@ -421,7 +421,7 @@ main(int argc, char **argv)
> return -1;
> }
>
> - add_host_channel();
> + add_host_channels();
>
> printf("Running core monitor on lcore id %d\n", lcore_id);
> rte_eal_remote_launch(run_core_monitor, NULL, lcore_id);
> --
> 2.17.1
Tested-by: Marcin Hajkowski
From: Marcin Hajkowski
Send request to power manager for core id provided
by user to get related capabilities.
Signed-off-by: Marcin Hajkowski
---
.../guest_cli/vm_power_cli_guest.c| 119 +-
1 file changed, 117 insertions(+), 2 deletions(-)
diff --git a/examples
From: Marcin Hajkowski
Send capabilities for requested cores.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/channel_monitor.c | 67 +
1 file changed, 67 insertions(+)
diff --git a/examples/vm_power_manager/channel_monitor.c
b/examples/vm_power_manager
From: Marcin Hajkowski
Add new packet type and commands for capabilities query.
Signed-off-by: Marcin Hajkowski
---
lib/librte_power/channel_commands.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/lib/librte_power/channel_commands.h
b/lib/librte_power
From: Marcin Hajkowski
Extend guest channel and sample apps to query CPU capabilities.
Please note that these changes depends on
(http://patchwork.dpdk.org/cover/52335/) and
(http://patchwork.dpdk.org/cover/52213/) which should be applied first.
Marcin Hajkowski (3):
power: add new packet
From: Marcin Hajkowski
Function rte_power_set_env will no longer return
success on attempt to set env in initialized state.
Signed-off-by: Marcin Hajkowski
Reviewed-by: Rami Rosen
Acked-by: David Hunt
Acked-by: Anatoly Burakov
Acked-by: Bruce Richardson
---
doc/guides/rel_notes
From: Marcin Hajkowski
Test all existing power environment configuration to verify if related
data is properly initialized and clean in set/unset scenarios.
Signed-off-by: Marcin Hajkowski
Acked-by: Anatoly Burakov
---
app/test/test_power.c | 156 --
1
From: Marcin Hajkowski
Set all power environment related function pointers to NULL
when unset is being made.
Signed-off-by: Marcin Hajkowski
Acked-by: Anatoly Burakov
---
lib/librte_power/rte_power.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a
From: Marcin Hajkowski
On attempt to set_env in already initialized state notify
user by returning error that operation cannot be performed.
Signed-off-by: Marcin Hajkowski
Acked-by: Anatoly Burakov
---
lib/librte_power/rte_power.c | 3 ++-
lib/librte_power/rte_power.h | 3 ++-
2 files
From: Marcin Hajkowski
Enhance rte_power API user notification by returning more
suitable value in case of power environment setting, add related tests
and some internal data cleaning corrections.
Please note that changes depends on patch
(http://patchwork.dpdk.org/patch/52349/) which should be
From: Marcin Hajkowski
Due to lack of thread safety in exisiting solution
use spinlock mechanism for atomic
modification of power environment related data.
Fixes: 445c6528b5 ("power: common interface for guest and host")
Cc: sta...@dpdk.org
Signed-off-by: Marcin Hajkowski
Acked-b
From: Marcin Hajkowski
Added new experimental API rte_power_guest_channel_receive_msg
which gives possibility to receive messages send to guest.
Signed-off-by: Marcin Hajkowski
---
lib/librte_power/channel_commands.h| 5 +++
lib/librte_power/guest_channel.c | 60
From: Marcin Hajkowski
Use new guest channel API to send confirmation
message for received power command.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/channel_monitor.c | 68 +++--
1 file changed, 62 insertions(+), 6 deletions(-)
diff --git a/examples
From: Marcin Hajkowski
Extend vm_power_guest to check incoming confirmations
of messages previously sent to host.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/guest_cli/Makefile | 1 +
.../guest_cli/vm_power_cli_guest.c| 73 +++
2 files changed
From: Marcin Hajkowski
Currently 0 is being used for not connected slot indication.
This is not consistent with linux doc which identifies 0 as valid
(connected) slot, thus modification was done to change it.
Fixes: cd0d5547 ("power: vm communication channels in guest")
Cc: sta..
From: Marcin Hajkowski
Extend guest channel API to allow bidirectional
communication. Modify power manager host and guest
side to communicate in both directions.
---
v5:
* enhance logging
v4:
* [vm_power_manager] treat 0 as valid socket id
* [guest_manager] use user level logs
* correct code
From: Marcin Hajkowski
Add command and related logic to query CPU frequencies
either for specified CPU or all cores.
Signed-off-by: Marcin Hajkowski
---
.../guest_cli/vm_power_cli_guest.c| 150 --
1 file changed, 138 insertions(+), 12 deletions(-)
diff --git a
From: Marcin Hajkowski
Add new command which gives possibility to enable/disable queries
form VM guest.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/channel_manager.c | 20 +
examples/vm_power_manager/channel_manager.h | 18
examples/vm_power_manager
From: Marcin Hajkowski
On query received from VM guest send CPUs frequencies.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/channel_monitor.c | 67 ++---
1 file changed, 59 insertions(+), 8 deletions(-)
diff --git a/examples/vm_power_manager/channel_monitor.c
From: Marcin Hajkowski
Extend incoming packet reading API with new packet
type which carries CPU frequencies.
Signed-off-by: Marcin Hajkowski
---
lib/librte_power/channel_commands.h | 21 +
lib/librte_power/guest_channel.c| 27 ---
lib
From: Marcin Hajkowski
Extend guest channel and sample apps to query CPU frequncies.
Please note that these changes depends on
(http://patchwork.dpdk.org/cover/52057/) which should be applied first.
Marcin Hajkowski (4):
power: extend guest channel for query freq.
power: process cpu freq
From: Marcin Hajkowski
Extend guest channel API to allow bidirectional
communication. Modify power manager host and guest
side to communicate in both directions.
---
v4:
* [vm_power_manager] treat 0 as valid socket id
* [guest_manager] use user level logs
* correct code formatting
v3:
* fix
From: Marcin Hajkowski
Extend vm_power_guest to check incoming confirmations
of messages previously sent to host.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/guest_cli/Makefile | 1 +
.../guest_cli/vm_power_cli_guest.c| 72 +++
2 files changed
From: Marcin Hajkowski
Use new guest channel API to send confirmation
message for received power command.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/channel_monitor.c | 68 +++--
1 file changed, 62 insertions(+), 6 deletions(-)
diff --git a/examples
From: Marcin Hajkowski
Added new experimental API rte_power_guest_channel_receive_msg
which gives possibility to receive messages send to guest.
Signed-off-by: Marcin Hajkowski
---
lib/librte_power/channel_commands.h| 5 +++
lib/librte_power/guest_channel.c | 60
From: Marcin Hajkowski
Currently 0 is being used for not connected slot indication.
This is not consistent with linux doc which identifies 0 as valid
(connected) slot, thus modification was done to change it.
Fixes: cd0d5547 ("power: vm communication channels in guest")
Cc: sta..
From: Marcin Hajkowski
In current implementation lcoreid 1 is used regardless
of currently available cores. This change introduce dynamic
core selection for sending policy.
Fixes: d191f08533 ("examples/guest_cli: add send policy to host")
Cc: sta...@dpdk.org
Signed-off-by: Marcin
From: Marcin Hajkowski
Currently 0 is being used for not connected slot indication.
This is not consistent with linux doc which identifies 0 as valid
(connected) slot, thus modification was done to change it.
Fixes: cd0d5547 ("power: vm communication channels in guest")
Cc: sta..
From: Marcin Hajkowski
Use new guest channel API to send confirmation
message for received power command.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/channel_monitor.c | 67 +++--
1 file changed, 61 insertions(+), 6 deletions(-)
diff --git a/examples
From: Marcin Hajkowski
Extend vm_power_guest to check incoming confirmations
of messages previously sent to host.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/guest_cli/Makefile | 1 +
.../guest_cli/vm_power_cli_guest.c| 65 +++
2 files changed
From: Marcin Hajkowski
Added new experimental API rte_power_guest_channel_receive_msg
which gives possibility to receive messages send to guest.
Signed-off-by: Marcin Hajkowski
---
lib/librte_power/channel_commands.h| 5 ++
lib/librte_power/guest_channel.c | 65
From: Marcin Hajkowski
Extend guest channel API to allow bidirectional
communication. Modify power manager host and guest
side to communicate in both directions.
v3:
* fix global_fds[lcore_id] comparison to invalid value
* check 0 to verify if read function actually read some data
* define
From: Marcin Hajkowski
Added new experimental API rte_power_guest_channel_receive_msg
which gives possibility to receive messages send to guest.
Signed-off-by: Marcin Hajkowski
---
lib/librte_power/channel_commands.h| 5 +++
lib/librte_power/guest_channel.c | 57
From: Marcin Hajkowski
Use new guest channel API to send confirmation
message for received power command.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/channel_monitor.c | 67 +++--
1 file changed, 61 insertions(+), 6 deletions(-)
diff --git a/examples
From: Marcin Hajkowski
Extend vm_power_guest to check incoming confirmations
of messages previously sent to host.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/guest_cli/Makefile | 1 +
.../guest_cli/vm_power_cli_guest.c| 65 +++
2 files changed
From: Marcin Hajkowski
Currently 0 is being used for not connected slot indication.
This is not consistent with linux doc which identifies 0 as valid
(connected) slot, thus modification was done to change it.
Fixes: cd0d5547 ("power: vm communication channels in guest")
Cc: sta..
From: Marcin Hajkowski
Extend guest channel API to allow bidirectional
communication. Modify power manager host and guest
side to communicate in both directions.
v2:
* send ack only if power operation return positive value
* log diffent error for unexpected incoming command and
error during
invalid command).
Best Regards,
Marcin
-Original Message-
From: Pattan, Reshma
Sent: Friday, March 15, 2019 6:14 PM
To: Hajkowski, MarcinX ; Hunt, David
Cc: dev@dpdk.org; Hajkowski, MarcinX
Subject: RE: [dpdk-dev] [PATCH 4/4] power: send confirmation cmd to vm guest
> -Origi
From: Marcin Hajkowski
On attempt to set_env in already initialized state notify
user by returning error that operation cannot be performed.
Signed-off-by: Marcin Hajkowski
---
doc/guides/rel_notes/release_19_05.rst | 4
lib/librte_power/rte_power.c | 3 ++-
lib/librte_power
From: Marcin Hajkowski
Due to lack of thread safety in exisiting solution
use spinlock mechanism for atomic
modification of power environment related data.
Fixes: 445c6528b5 ("power: common interface for guest and host")
Cc: sta...@dpdk.org
Signed-off-by: Marcin Hajkowski
---
From: Marcin Hajkowski
Set all power environment related function pointers to NULL
when unset is being made.
Signed-off-by: Marcin Hajkowski
---
lib/librte_power/rte_power.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/lib/librte_power/rte_power.c
From: Marcin Hajkowski
Test all existing power environment configuration to verify if related
data is properly initialized and clean in set/unset scenarios.
Signed-off-by: Marcin Hajkowski
---
app/test/test_power.c | 156 --
1 file changed, 121
From: Marcin Hajkowski
Set all power environment related function pointers to NULL
when unset is being made.
Signed-off-by: Marcin Hajkowski
---
lib/librte_power/rte_power.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/lib/librte_power/rte_power.c
From: Marcin Hajkowski
On attempt to set_env in already initialized state notify
user by returning error that operation cannot be performed.
Signed-off-by: Marcin Hajkowski
---
doc/guides/rel_notes/release_19_05.rst | 4
lib/librte_power/rte_power.c | 3 ++-
lib/librte_power
From: Marcin Hajkowski
Due to lack of thread safety in exisiting solution
use spinlock mechanism for atomic
modification of power environment related data.
Fixes: 445c6528b5 ("power: common interface for guest and host")
Cc: sta...@dpdk.org
Signed-off-by: Marcin Hajkowski
---
From: Marcin Hajkowski
Test all existing power environment configuration to verify if related
data is properly initialized and clean in set/unset scenarios.
Signed-off-by: Marcin Hajkowski
---
app/test/test_power.c | 155 --
1 file changed, 120
From: Marcin Hajkowski
Modifications to assure thread safety of rte_power APIs for
power env set and unset, better user notification by returning more
suitable value and internal data cleaning corrections.
Marcin Hajkowski (4):
power: fix non thread-safe power env modification
power: return
From: Marcin Hajkowski
On attempt to set_env in already initialized state notify
user by returning error that operation cannot be performed.
Signed-off-by: Marcin Hajkowski
---
doc/guides/rel_notes/release_19_05.rst | 4
lib/librte_power/rte_power.c | 3 ++-
lib/librte_power
From: Marcin Hajkowski
Test all existing power environment configuration to verify if related
data is properly initialized and clean in set/unset scenarios.
Signed-off-by: Marcin Hajkowski
---
app/test/test_power.c | 155 --
1 file changed, 120
From: Marcin Hajkowski
Set all power environment related function pointers to NULL
when unset is being made.
Signed-off-by: Marcin Hajkowski
---
lib/librte_power/rte_power.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/lib/librte_power/rte_power.c
From: Marcin Hajkowski
Due to lack of thread safety in exisiting solution
use spinlock mechanism for atomic
modification of power environment related data.
Fixes: 445c6528b5 ("power: common interface for guest and host")
Cc: sta...@dpdk.org
Signed-off-by: Marcin Hajkowski
---
From: Marcin Hajkowski
Modifications to assure thread safety of rte_power APIs for
power env set and unset, better user notification by returning more
suitable value and internal data cleaning corrections.
Marcin Hajkowski (4):
power: fix non thread-safe power env modification
power: return
From: Marcin Hajkowski
Function rte_power_set_env will no longer return
success on attempt to set env in initialized state.
Signed-off-by: Marcin Hajkowski
---
doc/guides/rel_notes/deprecation.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst
b
From: Marcin Hajkowski
Use new guest channel API to send confirmation
message for received power command.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/channel_monitor.c | 64 +++--
1 file changed, 58 insertions(+), 6 deletions(-)
diff --git a/examples
From: Marcin Hajkowski
Extend vm_power_guest to check incoming confirmations
of messages previously sent to host.
Signed-off-by: Marcin Hajkowski
---
examples/vm_power_manager/guest_cli/Makefile | 1 +
.../guest_cli/vm_power_cli_guest.c| 65 +++
2 files changed
From: Marcin Hajkowski
Added new experimental API rte_power_guest_channel_receive_msg
which gives possibility to receive messages send to guest.
Signed-off-by: Marcin Hajkowski
---
lib/librte_power/channel_commands.h| 5 +++
lib/librte_power/guest_channel.c | 57
From: Marcin Hajkowski
Extend guest channel API to allow bidirectional
communication. Modify power manager host and guest
side to communicate in both directions.
Marcin Hajkowski (4):
power: fix invalid socket indicator value
power: extend guest channel api for reading
power: process
From: Marcin Hajkowski
Currently 0 is being used for not connected slot indication.
This is not consistent with linux doc which identifies 0 as valid
(connected) slot, thus modification was done to change it.
Fixes: cd0d5547 ("power: vm communication channels in guest")
Cc: sta..
68 matches
Mail list logo
