[PATCH v1] ring: correct the comment and figure description

2022-04-08 Thread Haiyue Wang
The index description isn't right, correct it as the Programmer's guide said. Also correct the guide's figure description about 'Dequeue First Step'. Signed-off-by: Haiyue Wang --- doc/guides/prog_guide/ring_lib.rst | 2 +- lib/ring/rte_ring_core.h | 4

[PATCH v1 3/3] maintainers: update for Intel igc

2022-04-07 Thread Haiyue Wang
Junfeng and Simei have been appointed the new maintainers for the igc PMD. Update the MAINTAINERS file to reflect this. Signed-off-by: Haiyue Wang --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 513748b45b..21c581dc61 100644

[PATCH v1 2/3] maintainers: update for Intel ixgbe

2022-04-07 Thread Haiyue Wang
Qiming and Wenjun have been appointed the new maintainers for the ixgbe PMD. Update the MAINTAINERS file to reflect this. Signed-off-by: Haiyue Wang --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9d098161b2..513748b45b

[PATCH v1 1/3] maintainers: update for Intel e1000

2022-04-07 Thread Haiyue Wang
Simei and Wenjun have been appointed the new maintainers for the e1000 PMD. Update the MAINTAINERS file to reflect this. Signed-off-by: Haiyue Wang --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 15008c03bc..9d098161b2 100644

[PATCH v1] lib: remove x86 atomic header loop include

2022-03-24 Thread Haiyue Wang
Remove the x86 top atomic header include from the architecture related header file, since this x86 top atomic header file has included them. Signed-off-by: Haiyue Wang --- lib/eal/x86/include/rte_atomic_32.h | 1 - lib/eal/x86/include/rte_atomic_64.h | 1 - 2 files changed, 2 deletions(-) diff

[PATCH v3] graph: remove the useless duplicate name check

2022-03-07 Thread Haiyue Wang
k the real name duplicate. Signed-off-by: Haiyue Wang --- v3: No need to define another node id var. v2: update the test case. --- app/test/test_graph.c | 6 ++ lib/graph/node.c | 4 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test/test_graph.c b/app/test/test

[PATCH v2] graph: remove the useless duplicate name check

2022-03-07 Thread Haiyue Wang
k the real name duplicate. Signed-off-by: Haiyue Wang --- v2: update the test case. --- app/test/test_graph.c | 10 +- lib/graph/node.c | 4 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/app/test/test_graph.c b/app/test/test_graph.c index 35e1a95b89..692360e

[PATCH v1] graph: remove the useless duplicate name check

2022-03-06 Thread Haiyue Wang
The node clone API parameter 'name' is the new node's postfix name, not the final node name, so it makes no sense to check it. And the new name will be checked duplicate when calling API '__rte_node_register'. Signed-off-by: Haiyue Wang --- lib/graph/node.c | 4 1

[PATCH v1] ethdev: beautify the Rx desc number check indent

2022-02-14 Thread Haiyue Wang
Align to Tx desc number check indent, which may help to understand Rx descriptor limits member in the alignment comparison view. And remove the extra empty line. Signed-off-by: Haiyue Wang --- lib/ethdev/rte_ethdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib

[PATCH v1] net/af_xdp: make umem configure code more readable

2022-02-09 Thread Haiyue Wang
#endif 'shared code block' } Signed-off-by: Haiyue Wang --- drivers/net/af_xdp/rte_eth_af_xdp.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 1b6192fa44..802

[PATCH v1] doc: fix KNI PMD name typo

2022-01-19 Thread Haiyue Wang
The KNI PMD name should be "net_kni". Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") Cc: sta...@dpdk.org Signed-off-by: Haiyue Wang --- doc/guides/nics/kni.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/kni.rst b/doc/guides/nics/kni.

[PATCH v1] net/iavf: remove the extra symbol '+'

2021-12-15 Thread Haiyue Wang
This extra symbol '+' should be added when patch was reapplied, and the compiler treats it as unsigned type, so the code still runs well. Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel message") Cc: sta...@dpdk.org Signed-off-by: Haiyue Wang -

[PATCH v1] app/testpmd: avoid the process ID out of range

2021-11-14 Thread Haiyue Wang
The 'proc-id' should be less than 'num-procs', if not, exit the testpmd and show the error message. Fixes: a550baf24af9 ("app/testpmd: support multi-process") Signed-off-by: Haiyue Wang --- app/test-pmd/parameters.c | 6 ++ 1 file changed, 6 insertions

[dpdk-dev] [PATCH v3 4/4] common/iavf: update the driver version

2021-09-07 Thread Haiyue Wang
Update the driver version to trace the change. Signed-off-by: Haiyue Wang Acked-by: Qi Zhang --- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index 611fdcea94..89bdbc827e 100644 --- a

[dpdk-dev] [PATCH v3 3/4] common/iavf: remove the FDIR query opcode

2021-09-07 Thread Haiyue Wang
The VIRTCHNL_OP_QUERY_FDIR_FILTER opcode is not used, so remove it. Signed-off-by: Haiyue Wang Acked-by: Qi Zhang --- drivers/common/iavf/virtchnl.h | 38 -- 1 file changed, 38 deletions(-) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf

[dpdk-dev] [PATCH v3 2/4] common/iavf: enable hash calculation based on L4 checksum

2021-09-07 Thread Haiyue Wang
From: Alvin Zhang Add TCP/UDP/SCTP header checksum field selectors, they can be used in creating FDIR or RSS rules related to TCP/UDP/SCTP header checksum. Signed-off-by: Alvin Zhang Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 3 +++ 1 file changed, 3 insertions(+) diff

[dpdk-dev] [PATCH v3 1/4] common/iavf: add QFI fields for GTPU UL and DL

2021-09-07 Thread Haiyue Wang
From: Junfeng Guo The QFI is 6-bit "QoS Flow Identifier" within the GTPU Extension Header. Add virtchnl fields QFI of GTPU UL/DL for supporting the AVF FDIR. Signed-off-by: Junfeng Guo Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 5 + 1 file changed, 5

[dpdk-dev] [PATCH v3 0/4] iavf base code update

2021-09-07 Thread Haiyue Wang
v3: adjust the commit title. v2: update the commit message. Alvin Zhang (1): common/iavf: enable hash calculation based on L4 checksum Haiyue Wang (2): common/iavf: remove the FDIR query opcode common/iavf: update the driver version Junfeng Guo (1): common/iavf: add QFI fields for GTPU

[dpdk-dev] [PATCH v2] ethdev: promote burst mode API to stable

2021-09-05 Thread Haiyue Wang
The DPDK Symbol Bot reports: Please note the symbols listed below have expired. In line with the DPDK ABI policy, they should be scheduled for removal, in the next DPDK release. Symbol rte_eth_rx_burst_mode_get rte_eth_tx_burst_mode_get Signed-off-by: Haiyue Wang Acked-by: Ferruh Yigit Acked

[dpdk-dev] [PATCH v2 4/4] common/iavf: update the driver version

2021-09-05 Thread Haiyue Wang
Update the driver version to trace the change. Signed-off-by: Haiyue Wang Acked-by: Qi Zhang --- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index 611fdcea94..89bdbc827e 100644 --- a

[dpdk-dev] [PATCH v2 3/4] common/iavf: remove the FDIR query opcode

2021-09-05 Thread Haiyue Wang
The VIRTCHNL_OP_QUERY_FDIR_FILTER opcode is not used, so remove it. Signed-off-by: Haiyue Wang Acked-by: Qi Zhang --- drivers/common/iavf/virtchnl.h | 38 -- 1 file changed, 38 deletions(-) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf

[dpdk-dev] [PATCH v2 2/4] common/iavf: add proto hdr field support for L4 checksum

2021-09-05 Thread Haiyue Wang
From: Alvin Zhang Add TCP/UDP/SCTP header checksum field selectors, they can be used in creating FDIR or RSS rules related to TCP/UDP/SCTP header checksum. Signed-off-by: Alvin Zhang Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 3 +++ 1 file changed, 3 insertions(+) diff

[dpdk-dev] [PATCH v2 1/4] common/iavf: add QFI fields for GTPU UL and DL

2021-09-05 Thread Haiyue Wang
From: Junfeng Guo The QFI is 6-bit "QoS Flow Identifier" within the GTPU Extension Header. Add virtchnl fields QFI of GTPU UL/DL for supporting the AVF FDIR. Signed-off-by: Junfeng Guo Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 5 + 1 file changed, 5

[dpdk-dev] [PATCH v2 0/4] iavf base code update

2021-09-05 Thread Haiyue Wang
v2: update the commit message. Alvin Zhang (1): common/iavf: add proto hdr field support for L4 checksum Haiyue Wang (2): common/iavf: remove the FDIR query opcode common/iavf: update the driver version Junfeng Guo (1): common/iavf: add QFI fields for GTPU UL and DL drivers/common

[dpdk-dev] [PATCH v1 3/3] ethdev: promote burst mode API to stable

2021-08-31 Thread Haiyue Wang
The DPDK Symbol Bot reports: Please note the symbols listed below have expired. In line with the DPDK ABI policy, they should be scheduled for removal, in the next DPDK release. Symbol rte_eth_rx_burst_mode_get rte_eth_tx_burst_mode_get Signed-off-by: Haiyue Wang --- lib/ethdev/rte_ethdev.h

[dpdk-dev] [PATCH v1 2/3] net/ice: promote some API to stable

2021-08-31 Thread Haiyue Wang
rte_net_ice_dynflag_proto_xtr_ipv4_mask rte_net_ice_dynflag_proto_xtr_ipv6_mask rte_net_ice_dynflag_proto_xtr_ipv6_flow_mask rte_net_ice_dynflag_proto_xtr_tcp_mask Signed-off-by: Haiyue Wang --- drivers/net/ice/rte_pmd_ice.h | 3 --- drivers/net/ice/version.map | 11 --- 2 files changed, 4 insertions(+), 10

[dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote some API to stable

2021-08-31 Thread Haiyue Wang
rte_pmd_ixgbe_mdio_unlocked_write rte_pmd_ixgbe_upd_fctrl_sbp Signed-off-by: Haiyue Wang --- drivers/net/ixgbe/rte_pmd_ixgbe.h | 5 - drivers/net/ixgbe/version.map | 10 +- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h

[dpdk-dev] [PATCH v1 0/3] Promote some API to stable

2021-08-31 Thread Haiyue Wang
According to DPDK ABI Policy, section 3.5.3. https://doc.dpdk.org/guides/contributing/abi_policy.html Promote some API reported by DPDK Symbol Bot to stable. Haiyue Wang (3): net/ixgbe: promote some API to stable net/ice: promote some API to stable ethdev: promote burst mode API to stable

[dpdk-dev] [PATCH v1 4/4] common/iavf: update the driver version

2021-08-17 Thread Haiyue Wang
Update the driver version to trace the change. Signed-off-by: Haiyue Wang --- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index 611fdcea94..89bdbc827e 100644 --- a/drivers/common/iavf

[dpdk-dev] [PATCH v1 3/4] common/iavf: remove the FDIR query opcode

2021-08-17 Thread Haiyue Wang
The VIRTCHNL_OP_QUERY_FDIR_FILTER opcode is not used, so remove it. Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 38 -- 1 file changed, 38 deletions(-) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index

[dpdk-dev] [PATCH v1 2/4] common/iavf: add proto hdr field support for L4 checksum

2021-08-17 Thread Haiyue Wang
From: Alvin Zhang Add TCP/UDP/SCTP header checksum field selectors. Signed-off-by: Alvin Zhang Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index 9fa5e3e891

[dpdk-dev] [PATCH v1 1/4] common/iavf: add QFI fields for GTPU UL and DL

2021-08-17 Thread Haiyue Wang
From: Junfeng Guo Add virtchnl fields QFI of GTPU UL/DL for AVF FDIR. Signed-off-by: Junfeng Guo Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index

[dpdk-dev] [PATCH v1] net/ice: fix memzone leak when device init failed

2021-08-12 Thread Haiyue Wang
Fixes: 7edc7158d771 ("net/ice: cleanup RSS/FDIR profile on device init") Cc: sta...@dpdk.org Reported-by: David Marchand Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_ethdev.c | 10 -- drivers/net/ice/ice_fdir_filter.c | 2 ++ 2 files changed, 10 insertions(+)

[dpdk-dev] [PATCH v2] net/ice: enable to set HW debug mask

2021-06-29 Thread Haiyue Wang
The HW debug mask is always zero, so user can't enable the related debug function like ICE_DBG_XXX etc, add the devarg 'hw_debug_mask' to set the debug mask log output at runtime. Signed-off-by: Haiyue Wang --- v2: Add the doc in ice.rst --- doc/guides/nics/ice.rst | 8 ++

[dpdk-dev] [PATCH v1] net/ice: enable to set HW debug mask

2021-06-29 Thread Haiyue Wang
The HW debug mask is always zero, so user can't enable the related debug function like ICE_DBG_XXX etc. Add the devarg 'hw_debug_mask' to set the function like for ICE_DBG_NVM: -a :88:00.0,hw_debug_mask=0x80 --log-level=pmd.net.ice.driver:8 Signed-off-by: Haiyue Wang ---

[dpdk-dev] [PATCH v7 3/3] net/i40e: enable PCI bus master after reset

2021-05-23 Thread Haiyue Wang
keep the VF reset state to mark it as I/O error. Signed-off-by: Haiyue Wang --- drivers/net/i40e/i40e_ethdev_vf.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index cb898bdb68..385ebedcd3

[dpdk-dev] [PATCH v7 2/3] net/iavf: enable PCI bus master after reset

2021-05-23 Thread Haiyue Wang
keep the VF reset state to mark it as I/O error. Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_ethdev.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index d688c31cfb..a7ef7a6d4d 100644 --- a

[dpdk-dev] [PATCH v7 1/3] bus/pci: set PCI master in command register

2021-05-23 Thread Haiyue Wang
Add the API to set 'Bus Master Enable' bit to be enabled or disabled in the PCI command register. Signed-off-by: Haiyue Wang Acked-by: Ray Kinsella --- drivers/bus/pci/pci_common.c | 28 drivers/bus/pci/rte_bus_pci.h | 14 ++ drive

[dpdk-dev] [PATCH v7 0/3] fix PF reset causes VF memory request failure

2021-05-23 Thread Haiyue Wang
ome description. v6: update the annotate symbol version, and add some comments in source code v5: error handling if bus master enable failed v4: change the API to set type, so can enable or disable v3: added the missed annotate symbol add time v2: rebase to new librte directory path Haiyue Wang (3): bus/

[dpdk-dev] [PATCH v6 3/3] net/i40e: enable PCI bus master after reset

2021-05-23 Thread Haiyue Wang
state, so keep the VF reset state to mark it as I/O error. Signed-off-by: Haiyue Wang --- drivers/net/i40e/i40e_ethdev_vf.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index cb898bdb68

[dpdk-dev] [PATCH v6 2/3] net/iavf: enable PCI bus master after reset

2021-05-23 Thread Haiyue Wang
state, so keep the VF reset state to mark it as I/O error. Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_ethdev.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index d688c31cfb..a7ef7a6d4d

[dpdk-dev] [PATCH v6 1/3] bus/pci: set PCI master in command register

2021-05-23 Thread Haiyue Wang
Add the API to set 'Bus Master Enable' bit to be enabled or disabled in the PCI command register. Signed-off-by: Haiyue Wang Acked-by: Ray Kinsella --- drivers/bus/pci/pci_common.c | 28 drivers/bus/pci/rte_bus_pci.h | 14 ++ drive

[dpdk-dev] [PATCH v6 0/3] fix PF reset causes VF memory request failure

2021-05-23 Thread Haiyue Wang
ome comments in source code v5: error handling if bus master enable failed v4: change the API to set type, so can enable or disable v3: added the missed annotate symbol add time v2: rebase to new librte directory path Haiyue Wang (3): bus/pci: set PCI master in command register net/iavf: ena

[dpdk-dev] [PATCH v1] net/iavf: fix RSS key access out of index

2021-05-19 Thread Haiyue Wang
The array rss_key has size 'vf->vf_res->rss_key_size', the array index should be less than that. Cc: sta...@dpdk.org Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_ethdev.c | 2 +- 1 file changed,

[dpdk-dev] [PATCH v5 3/3] net/i40e: enable PCI bus master after reset

2021-05-05 Thread Haiyue Wang
state, so keep the VF reset state to mark it as I/O error. Signed-off-by: Haiyue Wang --- drivers/net/i40e/i40e_ethdev_vf.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index cb898bdb6..bded64842

[dpdk-dev] [PATCH v5 2/3] net/iavf: enable PCI bus master after reset

2021-05-05 Thread Haiyue Wang
state, so keep the VF reset state to mark it as I/O error. Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index c06873d26..0084a083b 100644 --- a

[dpdk-dev] [PATCH v5 1/3] bus/pci: set PCI master in command register

2021-05-05 Thread Haiyue Wang
Add the API to set 'Bus Master Enable' bit to be enabled or disabled in the PCI command register. Signed-off-by: Haiyue Wang Acked-by: Ray Kinsella --- drivers/bus/pci/pci_common.c | 28 drivers/bus/pci/rte_bus_pci.h | 14 ++ drive

[dpdk-dev] [PATCH v5 0/3] fix PF reset causes VF memory request failure

2021-05-05 Thread Haiyue Wang
v4: change the API to set type, so can enable or disable v3: added the missed annotate symbol add time v2: rebase to new librte directory path Haiyue Wang (3): bus/pci: set PCI master in command register net/iavf: enable PCI bus master after reset net/i40e: enable PCI bus master after re

[dpdk-dev] [PATCH v4 3/3] net/i40e: enable PCI bus master after reset

2021-04-27 Thread Haiyue Wang
module as the AVF driver does. Signed-off-by: Haiyue Wang --- drivers/net/i40e/i40e_ethdev_vf.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 3c258ba7c..8b041e94c 100644 --- a/drivers/net/i40e

[dpdk-dev] [PATCH v4 2/3] net/iavf: enable PCI bus master after reset

2021-04-27 Thread Haiyue Wang
The VF reset can be triggerred by the PF reset event, in this case, the PCI bus master will be cleared, then the VF is not allowed to issue any Memory or I/O Requests. So after the reset event is detected, always enable the PCI bus master. Signed-off-by: Haiyue Wang --- drivers/net/iavf

[dpdk-dev] [PATCH v4 1/3] bus/pci: set PCI master in command register

2021-04-27 Thread Haiyue Wang
Add the API to set 'Bus Master Enable' bit to be enabled or disabled in the PCI command register. Signed-off-by: Haiyue Wang --- drivers/bus/pci/pci_common.c | 28 drivers/bus/pci/rte_bus_pci.h | 14 ++ drivers/bus/pci/version.map | 3 ++

[dpdk-dev] [PATCH v4 0/3] fix PF reset causes VF memory request failure

2021-04-27 Thread Haiyue Wang
or disable v3: added the missed annotate symbol add time v2: rebase to new librte directory path. Haiyue Wang (3): bus/pci: set PCI master in command register net/iavf: enable PCI bus master after reset net/i40e: enable PCI bus master after reset drivers/bus/pci/pci_common.c |

[dpdk-dev] [PATCH v3 1/3] bus/pci: enable PCI master in command register

2021-04-23 Thread Haiyue Wang
This adds the support to set 'Bus Master Enable' bit in the PCI command register. Signed-off-by: Haiyue Wang Tested-by: Qi Zhang --- drivers/bus/pci/pci_common.c | 20 drivers/bus/pci/rte_bus_pci.h | 12 drivers/bus/pci/version.map | 3 ++

[dpdk-dev] [PATCH v3 2/3] net/iavf: enable PCI bus master after reset

2021-04-23 Thread Haiyue Wang
The VF reset can be triggerred by the PF reset event, in this case, the PCI bus master will be cleared, then the VF is not allowed to issue any Memory or I/O Requests. So after the reset event is detected, always enable the PCI bus master. Signed-off-by: Haiyue Wang Tested-by: Qi Zhang

[dpdk-dev] [PATCH v3 3/3] net/i40e: enable PCI bus master after reset

2021-04-23 Thread Haiyue Wang
module as the AVF driver does. Signed-off-by: Haiyue Wang Tested-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 3c258ba7c..4f1d04eb2 100644

[dpdk-dev] [PATCH v3 0/3] fix PF reset causes VF memory request failure

2021-04-23 Thread Haiyue Wang
v2: rebase to new librte directory path. Haiyue Wang (3): bus/pci: enable PCI master in command register net/iavf: enable PCI bus master after reset net/i40e: enable PCI bus master after reset drivers/bus/pci/pci_common.c | 20 drivers/bus/pci/rte_bus_pci.h |

[dpdk-dev] [PATCH v2 3/3] net/i40e: enable PCI bus master after reset

2021-04-21 Thread Haiyue Wang
module as the AVF driver does. Signed-off-by: Haiyue Wang Tested-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 3c258ba7c..4f1d04eb2 100644

[dpdk-dev] [PATCH v2 2/3] net/iavf: enable PCI bus master after reset

2021-04-21 Thread Haiyue Wang
The VF reset can be triggerred by the PF reset event, in this case, the PCI bus master will be cleared, then the VF is not allowed to issue any Memory or I/O Requests. So after the reset event is detected, always enable the PCI bus master. Signed-off-by: Haiyue Wang Tested-by: Qi Zhang

[dpdk-dev] [PATCH v2 1/3] bus/pci: enable PCI master in command register

2021-04-21 Thread Haiyue Wang
This adds the support to set 'Bus Master Enable' bit in the PCI command register. Signed-off-by: Haiyue Wang Tested-by: Qi Zhang --- drivers/bus/pci/pci_common.c | 20 drivers/bus/pci/rte_bus_pci.h | 12 drivers/bus/pci/version.map | 1 + lib/pci

[dpdk-dev] [PATCH v2 0/3] fix PF reset causes VF memory request failure

2021-04-21 Thread Haiyue Wang
By triggerring the VF reset from PF reset, echo 1 > /sys/bus/pci/devices/PF-BDF/reset the PCI bus master bit will cleared on VF, so the VF needs to enable this bit before restart. This patch set adds the API to enable PCI bus master. v2: rebase to new librte directory path. Hai

[dpdk-dev] [PATCH v1 3/3] net/i40e: enable PCI bus master after reset

2021-04-20 Thread Haiyue Wang
module as the AVF driver does. Signed-off-by: Haiyue Wang --- drivers/net/i40e/i40e_ethdev_vf.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 3c258ba7cf..4f1d04eb2b 100644 --- a/drivers/net/i40e

[dpdk-dev] [PATCH v1 2/3] net/iavf: enable PCI bus master after reset

2021-04-20 Thread Haiyue Wang
The VF reset can be triggerred by the PF reset event, in this case, the PCI bus master will be cleared, then the VF is not allowed to issue any Memory or I/O Requests. So after the reset event is detected, always enable the PCI bus master. Signed-off-by: Haiyue Wang --- drivers/net/iavf

[dpdk-dev] [PATCH v1 1/3] bus/pci: enable PCI master in command register

2021-04-20 Thread Haiyue Wang
This adds the support to set 'Bus Master Enable' bit in the PCI command register. Signed-off-by: Haiyue Wang --- drivers/bus/pci/pci_common.c | 20 drivers/bus/pci/rte_bus_pci.h | 12 drivers/bus/pci/version.map | 1 + lib/librte_pci/rte_pci.h

[dpdk-dev] [PATCH v1 0/3] Fix PF reset causes VF memory request failure

2021-04-20 Thread Haiyue Wang
By triggerring the VF reset from PF reset, echo 1 > /sys/bus/pci/devices/PF-BDF/reset the PCI bus master bit will cleared on VF, so the VF needs to enable this bit before restart. This patch set adds the API to enable PCI bus master. Haiyue Wang (3): bus/pci: enable PCI master

[dpdk-dev] [PATCH v1] net/ice: update QinQ switch filter handling

2021-04-12 Thread Haiyue Wang
The hardware oueter/inner VLAN protocol types are now updated to map to new interface VLAN protocol types, so update the application to use new VLAN protocol types when the rte_flow is QinQ filter type. Signed-off-by: Haiyue Wang --- Depends-on: series-16315 ("base code update ba

[dpdk-dev] [PATCH v1] net/ixgbe: fix Rx errors statistics for UDP checksum

2021-04-07 Thread Haiyue Wang
Restrict the "remove l3_l4_xsum_errors from rx_errors" to 82599 only for hardware errata. Fixes: 256ff05a9cae ("ixgbe: fix Rx errors statistics for UDP checksum") Cc: sta...@dpdk.org Signed-off-by: Haiyue Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 7 +++ 1 file c

[dpdk-dev] [PATCH v1] net/ice: remove the redundant function type

2021-03-28 Thread Haiyue Wang
The function 'ice_is_profile_rule' is defined as 'ice_is_prof_rule' in base code, which has the exactly same function body. So remove the 'ice_is_profile_rule', use the 'ice_is_prof_rule' instead. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_switch

[dpdk-dev] [PATCH v3] net/ixgbe: fix UDP zero checksum error

2021-02-04 Thread Haiyue Wang
recompute the checksum itself if needed. Bugzilla ID: 629 Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Reported-by: Paolo Valerio Signed-off-by: Haiyue Wang --- v3: Update the hardware errata doc name and session v2: Change the always GOOD checksum to UNKOWN if BAD

[dpdk-dev] [PATCH v2] net/ice: fix VLAN 0 adding based on VLAN mode

2021-02-04 Thread Haiyue Wang
ed to allow VLAN 0 priority tagged traffic in DVM, since the VLAN TPID is part of filtering. Fixes: 14e7a4b37b4f ("net/ice/base: support configuring device in double VLAN mode") Signed-off-by: Haiyue Wang --- v2: Change the log level from ERR to DEBUG, since this is not fatal error. -

[dpdk-dev] [PATCH v1] net/ice: fix VLAN 0 adding based on VLAN mode

2021-02-04 Thread Haiyue Wang
ed to allow VLAN 0 priority tagged traffic in DVM, since the VLAN TPID is part of filtering. Fixes: 14e7a4b37b4f ("net/ice/base: support configuring device in double VLAN mode") Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_ethdev.c | 136 +--

[dpdk-dev] [PATCH v2] net/ice: fix VLAN strip show in double VLAN mode

2021-02-03 Thread Haiyue Wang
pport configuring device in double VLAN mode") Signed-off-by: Haiyue Wang --- v2: Add the missed fix tag, and update the commit message. --- drivers/net/ice/ice_ethdev.c | 297 +++ 1 file changed, 131 insertions(+), 166 deletions(-) diff --git a/drivers/net/ice/ic

[dpdk-dev] [PATCH v1] net/ice: update VLAN strip set in double VLAN mode

2021-02-03 Thread Haiyue Wang
d on outer, since the VLAN filter is outer; in single VLAN mode, the VLAN strip is applied on inner, since the VLAN filter is inner. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_ethdev.c | 297 +++ 1 file changed, 131 insertions(+), 166 deletions(-) diff --git

[dpdk-dev] [PATCH v2] net/ixgbe: fix UDP zero checksum error

2021-02-02 Thread Haiyue Wang
recompute the checksum itself if needed. Bugzilla ID: 629 Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Reported-by: Paolo Valerio Signed-off-by: Haiyue Wang --- v2: Change the always GOOD checksum to UNKOWN if BAD. --- doc/guides/nics/ixgbe.rst

[dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-01 Thread Haiyue Wang
ackets ol_flags: PKT_RX_L4_CKSUM_BAD PKT_RX_IP_CKSUM_GOOD Bugzilla ID: 629 Cc: sta...@dpdk.org Signed-off-by: Haiyue Wang --- doc/guides/nics/ixgbe.rst | 6 drivers/net/ixgbe/ixgbe_rxtx.c | 27 +++--- drivers/net/ixgbe/ixgbe_rxtx.h | 2 ++ dri

[dpdk-dev] [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode

2021-01-27 Thread Haiyue Wang
The PF will set the VLAN mode globally, DCF just needs to get the VLAN mode. Signed-off-by: Haiyue Wang --- drivers/net/ice/base/ice_vlan_mode.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ice/base/ice_vlan_mode.c b/drivers/net/ice/base/ice_vlan_mode.c index

[dpdk-dev] [PATCH v1] net/iavf: adjust the VLAN failure handling

2021-01-25 Thread Haiyue Wang
Change the fatal returning to print the error message only, so that the VF device can continue to be configured. Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities") Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_ethdev.c | 4 +--- 1 file changed, 1 insertion(+), 3

[dpdk-dev] [PATCH v1] net/iavf: support to config VLAN filter

2021-01-24 Thread Haiyue Wang
Add the VLAN filtering enable/disable configuration according to the VF successfully negotiated that capability with PF. Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf.h| 1 + drivers/net/iavf/iavf_ethdev.c | 7 ++ drivers/net/iavf/iavf_vchnl.c | 40

[dpdk-dev] [PATCH v1] net/iavf: fix unsupported VLAN offload requested

2021-01-24 Thread Haiyue Wang
If the underlying PF doesn't support a specific ethertype or the ability to toggle VLAN insertion and/or stripping, then the VF prevents sending an invalid message to the PF. Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities") Signed-off-by: Haiyue Wang --- d

[dpdk-dev] [PATCH v3] net/ice: drain out DCF AdminQ command queue

2021-01-21 Thread Haiyue Wang
AdminQ command with buffer to get the stall buffer response from previous. Fixes: daa714d55c72 ("net/ice: handle AdminQ command by DCF") Cc: sta...@dpdk.org Signed-off-by: Haiyue Wang --- v3: Reword the commit message, and remove the no needed checking. v2: Fix the commit message typo :

[dpdk-dev] [PATCH v2] net/ice: drain out DCF AdminQ command queue

2021-01-21 Thread Haiyue Wang
. Fixes: daa714d55c72 ("net/ice: handle AdminQ command by DCF") Cc: sta...@dpdk.org Signed-off-by: Haiyue Wang --- v2: Fix the commit message typo : 'matchiing' should be 'matching' --- drivers/net/ice/ice_dcf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drive

[dpdk-dev] [PATCH v1] net/ice: drain out DCF AdminQ command queue

2021-01-21 Thread Haiyue Wang
. Fixes: daa714d55c72 ("net/ice: handle AdminQ command by DCF") Cc: sta...@dpdk.org Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_dcf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c index 4a9af3292c..a211797d9e 100644 ---

[dpdk-dev] [PATCH v3 2/2] net/iavf: align to the new VLAN offload name

2021-01-19 Thread Haiyue Wang
Since the VLAN offload virtchnl message name has been renamed to setting style, the internal Ethernet type setting name needs be changed to avoid confusing. Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_vchnl.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[dpdk-dev] [PATCH v3 1/2] common/iavf: support VLAN filtering

2021-01-19 Thread Haiyue Wang
, since the virtchnl_vlan_offload message has the desired format, change the structure name to virtchnl_vlan_setting so it can be used for VIRTCHNL_OP_ENABLE_VLAN_FILTERING_V2 and VIRTCHNL_OP_DISABLE_VLAN_FILTERING_V2. Signed-off-by: Brett Creeley Signed-off-by: Haiyue Wang --- drivers/common/iavf

[dpdk-dev] [PATCH v3 0/2] iavf: update the VLAN offload message

2021-01-19 Thread Haiyue Wang
Haiyue Wang (2): common/iavf: support VLAN filtering net/iavf: align to the new VLAN offload name drivers/common/iavf/virtchnl.h | 67 -- drivers/net/iavf/iavf_vchnl.c | 20 +- 2 files changed, 66 insertions(+), 21 deletions(-) -- 2.30.0

[dpdk-dev] [PATCH v2] common/iavf: support VLAN filtering

2021-01-19 Thread Haiyue Wang
, since the virtchnl_vlan_offload message has the desired format, change the structure name to virtchnl_vlan_setting so it can be used for VIRTCHNL_OP_ENABLE_VLAN_FILTERING_V2 and VIRTCHNL_OP_DISABLE_VLAN_FILTERING_V2. Signed-off-by: Brett Creeley Signed-off-by: Haiyue Wang --- v2: update the commit

[dpdk-dev] [PATCH v1] net/iavf: rename the VLAN offload virtchnl message

2021-01-19 Thread Haiyue Wang
Rename the VLAN offload message to make the virtchnl support one more filtering offload, the name is straightforward. Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 67 -- drivers/net/iavf/iavf_vchnl.c | 36 +- 2 files changed

[dpdk-dev] [PATCH v2] net/ice: refactor DCF VLAN handling

2021-01-18 Thread Haiyue Wang
API 'ethdev' parameter to 'vf_rep_eth_dev' to avoid introducing confusion with VF representor eth_dev ops name. Signed-off-by: Haiyue Wang --- v2: change the reset log from ERR to DEBUG level --- drivers/net/ice/ice_dcf_ethdev.c | 47 - drivers/net/ice/ice_dcf_et

[dpdk-dev] [PATCH v1] net/ice: refactor DCF VLAN handling

2021-01-18 Thread Haiyue Wang
API 'ethdev' parameter to 'vf_rep_eth_dev' to avoid introducing confusion with VF representor eth_dev ops name. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_dcf_ethdev.c | 47 - drivers/net/ice/ice_dcf_ethdev.h | 23 ++- drivers/net/ice/ice_dcf_pa

[dpdk-dev] [PATCH v1] net/iavf: adjust the CRC statistics calculation

2021-01-14 Thread Haiyue Wang
The AVF can support to enable / disable CRC strip, so it needs to adjust the statistics calculation for ibytes according to offload setting. Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_ethdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf

[dpdk-dev] [PATCH v6 3/3] net/iavf: implement new VLAN capability handling

2021-01-12 Thread Haiyue Wang
able to configure outer VLAN (0x8100) if port VLAN is disabled to be compatible with legacy mode. When port VLAN is updated by DCF, the AVF needs to reset to query the new VLAN capabilities. Signed-off-by: Qiming Yang Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf.h| 6

[dpdk-dev] [PATCH v6 2/3] net/ice: add the DCF VLAN handling

2021-01-12 Thread Haiyue Wang
Add the DCF port representor infrastructure for the VFs of DCF attached PF. Then the standard ethdev API like VLAN can be used to configure the VFs. Signed-off-by: Qiming Yang Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_dcf.c| 1 + drivers/net/ice/ice_dcf_ethdev.c

[dpdk-dev] [PATCH v6 1/3] net/iavf: support Ethernet CRC strip disable

2021-01-12 Thread Haiyue Wang
The VF will check the PF's CRC strip capability firstly, then set the 'CRC strip disable' value in the queue configuration according to the RX CRC offload setting. Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_ethdev.c | 3 +++ drivers/net/iavf/iavf_rxtx.c | 6 +- d

[dpdk-dev] [PATCH v6 0/3] Add AVF & DCF VLAN feaure

2021-01-12 Thread Haiyue Wang
v6: code clean, and update the commit log. v5: seperate the QinQ switch filter with another thead. v4: make code readable for QinQ TPID setting. v3: code refactor for handing QinQ according to the VC response. Haiyue Wang (3): net/iavf: support Ethernet CRC strip disable net/ice: add the DCF

[dpdk-dev] [PATCH v5 4/4] net/iavf: implement new VLAN capability handling

2021-01-11 Thread Haiyue Wang
The new VLAN virtchnl opcodes introduce new capabilities like VLAN filtering, stripping and insertion. The VF needs to query the VLAN capabilities based on current device configuration firstly. Signed-off-by: Qiming Yang Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf.h| 6

[dpdk-dev] [PATCH v5 3/4] net/ice: add the DCF VLAN handling

2021-01-11 Thread Haiyue Wang
Add the DCF port representor infrastructure for the VFs of DCF attached PF. Then the standard ethdev API like VLAN can be used to configure the VFs. Signed-off-by: Qiming Yang Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_dcf.c| 1 + drivers/net/ice/ice_dcf_ethdev.c

[dpdk-dev] [PATCH v5 1/4] common/iavf: new VLAN opcode

2021-01-11 Thread Haiyue Wang
Add new VLAN opcode support. Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 416 + 1 file changed, 416 insertions(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index fcbaa31fa..b549a853c 100644 --- a/drivers

[dpdk-dev] [PATCH v5 2/4] net/iavf: support Ethernet CRC strip disable

2021-01-11 Thread Haiyue Wang
The VF will check the PF's CRC strip capability firstly, then set the 'CRC strip disable' value in the queue configuration according to the RX CRC offload setting. Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_ethdev.c | 3 +++ drivers/net/iavf/iavf_rxtx.c | 6 +- d

[dpdk-dev] [PATCH v5 0/4] Add AVF & DCF VLAN feaure

2021-01-11 Thread Haiyue Wang
://patchwork.dpdk.org/cover/86137/ Haiyue Wang (4): common/iavf: new VLAN opcode - [1] net/iavf: support Ethernet CRC strip disable net/ice: add the DCF VLAN handling net/iavf: implement new VLAN capability handling drivers/common/iavf/virtchnl.h | 416 +++ drivers/net

[dpdk-dev] [PATCH v4 5/5] net/iavf: implement new VLAN capability handling

2020-12-28 Thread Haiyue Wang
ed on the outer VLAN tag when the double VLAN mode is enabled on the PF: a). 0x8100 b). 0x8100 + 0x8100 c). 0x9100 + 0x8100 d). 0x88a8 + 0x8100 Signed-off-by: Qiming Yang Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf.h| 10 +++ drivers/net/iavf/iavf_ethdev.c

[dpdk-dev] [PATCH v4 4/5] net/ice: add the DCF VLAN handling

2020-12-28 Thread Haiyue Wang
Add the DCF port representor infrastructure for the VFs of DCF attached PF. Then the standard ethdev API like VLAN can be used to configure the VFs. Signed-off-by: Qiming Yang Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_dcf.c| 1 + drivers/net/ice/ice_dcf_ethdev.c

  1   2   3   4   >