[PATCH] bus/auxiliary: fix auxiliary device port destruction

2025-07-07 Thread Gregory Etelson
. The patch validates auxiliary device driver before accessing driver related resources. Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/bus/auxiliary/auxiliary_common.c | 2

[PATCH v2 4/4] net/mlx5: support non-template SAMPLE flow action

2025-06-26 Thread Gregory Etelson
MLX5 HWS flow engine does not support the SAMPLE flow action. The patch adds the SAMPLE action support to the non-template API. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.c| 1 + drivers/net/mlx5/mlx5_flow.h | 23 ++ drivers/net

[PATCH v2 3/4] net/mlx5: add functions for non template sample action

2025-06-26 Thread Gregory Etelson
The patch initiates non-template sample action environment and adds private functions to support the sample flow action. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5.h| 7 + drivers/net/mlx5

[PATCH v2 1/4] net/mlx5: fix the table flags of mirror action

2025-06-26 Thread Gregory Etelson
From: Bing Zhao The HWS mirror action is created with STCs based on the flags. In the past, there was a single type of FDB domain. After introducing the unified FDB feature, there are 4 types of tables in FDB domain, including FDB, FDB_RX, FDB_TX and FDB_UNIFIED. More STCs will be allocated when

[PATCH v2 2/4] net/mlx5: add a stand alone function for mirror creation

2025-06-26 Thread Gregory Etelson
The new mlx5_hw_create_mirror() function separates existing HWS mirror functionality into mirror action creation and indirect list handle creation. The new mirror creation function will be used in non-template SAMPLE action implementation. Signed-off-by: Gregory Etelson Acked-by: Dariusz

[PATCH v2 0/4] net/mlx5: support non template SAMPLE flow action

2025-06-26 Thread Gregory Etelson
Support SAMPLE flow action in the non-template API. Bing Zhao (1): net/mlx5: fix the table flags of mirror action Gregory Etelson (3): net/mlx5: add a stand alone function for mirror creation net/mlx5: add functions for non template sample action net/mlx5: support non-template SAMPLE

[PATCH] net/mlx5: fix access to auxiliary flow data

2025-06-25 Thread Gregory Etelson
`mlx5_flow_hw_aux()` implementation for HWS and non-template flows Fixes: 27d171b88031 ("net/mlx5: abstract flow action and enable reconfigure") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 12 1 fi

[PATCH 5/5] net/mlx5: support non-template SAMPLE flow action

2025-06-17 Thread Gregory Etelson
MLX5 HWS flow engine does not support the SAMPLE flow action. The patch adds the SAMPLE action support to the non-template API. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5.c| 1 + drivers/net/mlx5/mlx5_flow.h | 26 +- drivers/net/mlx5/mlx5_flow_hw.c| 40

[PATCH 3/5] net/mlx5: create utility functions for non-template sample action

2025-06-17 Thread Gregory Etelson
The patch initiates non-template sample action environment and adds function to create hws mirror object. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5.h| 7 + drivers/net/mlx5/mlx5_flow.h | 7 + drivers/net/mlx5

[PATCH 4/5] net/mlx5: add MLX5 mirror flow action

2025-06-17 Thread Gregory Etelson
Add private PMD flow action MLX5_RTE_FLOW_ACTION_TYPE_MIRROR. The new action type provides direct access to the HWS mirror action. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net

[PATCH 2/5] net/mlx5: add mlx5_hw_create_mirror function.

2025-06-17 Thread Gregory Etelson
The new mlx5_hw_create_mirror() function separates existing HWS mirror functionality into mirror action creation and indirect list handle creation. The new mirror creation function will be used in non-template SAMPLE action implementation. Signed-off-by: Gregory Etelson --- drivers/net/mlx5

[PATCH 1/5] net/mlx5: fix the table flags of mirror action

2025-06-17 Thread Gregory Etelson
From: Bing Zhao The HWS mirror action is created with STCs based on the flags. In the past, there was a single type of FDB domain. After introducing the unified FDB feature, there are 4 types of tables in FDB domain, including FDB, FDB_RX, FDB_TX and FDB_UNIFIED. More STCs will be allocated when

[PATCH] common/mlx5: fix extraction of auxiliary network device name

2025-06-15 Thread Gregory Etelson
pport auxiliary bus") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/common/mlx5/linux/mlx5_common_auxiliary.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_common_auxiliary.c b/driv

[PATCH] app/testpmd: fix random flow item token

2025-05-18 Thread Gregory Etelson
source buffer size. Fixes: 738ef8f7c706 ("ethdev: add flow item for random matching") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdl

[PATCH] net/mlx5: fix mark action value in shared Rx queue setup

2025-05-14 Thread Gregory Etelson
Patch `2d8763432add` was not applied correctly. As a result, `mlx5_rxq_data::mark_flag` was assigned wrong value. Fixes: 2d8763432add ("net/mlx5: fix shared Rx queue data access race") Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.c | 2

[PATCH] net/mlx5: fix error notification for large patterns

2025-05-06 Thread Gregory Etelson
w API") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/hws/mlx5dr_bwc.c | 2 +- drivers/net/mlx5/mlx5_flow_hw.c | 8 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_bwc.c b/drivers/net/mlx5/hws/mlx5dr_b

[PATCH] net/mlx5: fix support for meter flow action in HWS

2025-05-03 Thread Gregory Etelson
METER flow action is not supported in MLX5 HWS mode. Application must use METER_MARK flow action. The patch removes METER action from HWS code. Fixes: 48fbb0e93d06 ("net/mlx5: support flow meter mark indirect action with HWS") Signed-off-by: Gregory Etelson Acked-by: Dariusz

Re: [PATCH] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq

2025-05-02 Thread Gregory Etelson
n my opinion, binding DPDK as it is today with Rust can significantly improve application design. Regards, Gregory From: Van Haaren, Harry Sent: Friday, May 2, 2025 16:58 To: Gregory Etelson ; Richardson, Bruce Cc: dev@dpdk.org ; owen.hily...@unh.edu Subject:

Re: [PATCH] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq

2025-04-30 Thread Gregory Etelson
cargo run --example helloworld -- -a -l 0,1,3,5 2 Start RDPDK workers on dedicated cores: cargo run --example helloworld -- -a :43:00.0 -l 0,1,3,5 -- -l 2-8 Regards, Gregory From: Gregory Etelson Sent: Sunday, April 27, 2025 21:50 To: Van Haaren, Harr

Re: [PATCH] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq

2025-04-20 Thread Gregory Etelson
DPDK source. 2. Install DPDK 3. Set PKG_CONFIG_PATH to DPDK installation Activation: # cargo run --example echo -- -a Regards, Gregory From: Van Haaren, Harry Sent: Friday, April 18, 2025 14:40 To: Gregory Etelson Cc: dev@dpdk.org ; Richardson, Bruce ; ow

[RFC] add Rust API for basic port operations

2025-04-16 Thread Gregory Etelson
entation with RTE function calls: https://github.com/getelson-at-mellanox/rdpdk/blob/main/lib/port/raw_port.rs Implement direct calls to mlx5 Rx/Tx IO functions: https://github.com/getelson-at-mellanox/rdpdk/blob/main/port/mlx5/mlx5_port.rs Signed-off-by: Gregory Etelson

[PATCH v4] rust: support raw DPDK API

2025-03-22 Thread Gregory Etelson
procedure will create $MESON_INSTALL_DESTDIR_PREFIX/$libdir/rust crate. 3. Update PKG_CONFIG_PATH to point to DPDK installation. Signed-off-by: Gregory Etelson --- v2: Change rust crate name from dpdklib to dpdk. Add raw module for to link with C API. Add "cargo:rerun-if-changed=build.rs"

[PATCH] config/arm: fix meson for native instruction set Arm CPUs

2025-03-19 Thread Gregory Etelson
belongs to the native Arm CPU instruction set. The patch adds global definition for extra_features. Fixes: 7829776d0abf ("config/arm: add extra -march features") Signed-off-by: Gregory Etelson --- config/arm/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/config/arm/mes

[PATCH v3] rust: support raw DPDK API

2025-03-15 Thread Gregory Etelson
procedure will create $MESON_INSTALL_DESTDIR_PREFIX/$libdir/rust crate. 3. Update PKG_CONFIG_PATH to point to DPDK installation. Signed-off-by: Gregory Etelson --- v2: Change rust crate name from dpdklib to dpdk. Add raw module for to link with C API. Add "cargo:rerun-if-changed=build.rs"

[PATCH] net/mlx5: fix IPIP tunnel verification

2025-03-15 Thread Gregory Etelson
detection logic. Fixes: 2db234e769e1 ("net/mlx5: fix IP-in-IP tunnels recognition") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_dv.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH 2/2] net/mlx5: fix GENEVE parser cleanup

2025-03-13 Thread Gregory Etelson
From: Michael Baum The GENEVE parser is shared across ports on the same physical device. It is created once for the first port and increments a reference counter for each additional port. The parser is created using the InfiniBand (IBV) context (CTX) of the first port, and cleanup should use the

[PATCH 1/2] common/mlx5: add device duplication function

2025-03-13 Thread Gregory Etelson
From: Michael Baum Add function for creating additional CTX for same device base on existing CTX. Signed-off-by: Michael Baum --- drivers/common/mlx5/linux/mlx5_common_os.c | 52 drivers/common/mlx5/mlx5_common.h| 4 ++ drivers/common/mlx5/version.map

[PATCH] net/mlx5: fix mark flow action validation in FDB mode

2025-03-11 Thread Gregory Etelson
SWS FDB and HWS FDB. Cc: sta...@dpdk.org Fixes: d6dc072aeb12 ("net/mlx5: validate flow actions in table creation") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/d

[PATCH v2] rust: support raw DPDK API

2025-03-08 Thread Gregory Etelson
procedure will create $MESON_INSTALL_DESTDIR_PREFIX/$libdir/rust crate. 3. Update PKG_CONFIG_PATH to point to DPDK installation. Signed-off-by: Gregory Etelson --- buildtools/meson.build | 4 + buildtools/rust-env.sh | 81 +++ examples/rust/helloworld

[PATCH] rust: support DPDK API

2025-03-06 Thread Gregory Etelson
procedure will create MESON_INSTALL_DESTDIR_PREFIX/rust directory. 3. Update PKG_CONFIG_PATH to point to DPDK installation. Signed-off-by: Gregory Etelson --- buildtools/meson.build | 4 + buildtools/rust-env.sh | 78 +++ examples/rust/helloworld/Cargo.lock

[PATCH] config/arm: update NVIDIA BlueField-3 configuration

2025-02-18 Thread Gregory Etelson
ARM configuration requires explicit `mcpu` specifications in the implementor description. The patch adds `mcpu` and `flags` description for the NVIDIA BlueField-3 configuration. Signed-off-by: Gregory Etelson --- config/arm/meson.build | 5 + 1 file changed, 5 insertions(+) diff --git a

[PATCH v2] testpmd: support meter_mark init_color in indirect list configuration

2025-02-17 Thread Gregory Etelson
w queue 0 create 0 template_table 1 pattern_template 0 \ actions_template 0 postpone no pattern eth / ipv4 / udp / end \ actions indirect_list handle 10 conf 11 / \ jump group 10 / end Signed-off-by: Gregory Etelson --- v2: Fix commit log. --- app/test-pmd/cmdline_fl

[PATCH] net/mlx5: support ESP in non-template RSS expansion

2025-02-16 Thread Gregory Etelson
Add support for the ESP protocol in non-template RSS expansion. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_nta_rss.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_nta_rss.c b/drivers/net/mlx5/mlx5_nta_rss.c index 602df301ac

[PATCH] testpmd: support meter_mark init_color in indirect list configuration

2025-02-16 Thread Gregory Etelson
w queue 0 create 0 template_table 1 pattern_template 0 \ actions_template 0 postpone no pattern eth / ipv4 / udp / end \ actions indirect_list handle 10 conf 11 / \ jump group 10 / end cc: sta...@dpdk.org Signed-off-by: Gregory Etelson --- app/test-pmd/cmdline_fl

[PATCH 2/2] net/mlx5/hws: add DROP action to multi destination actions

2025-02-13 Thread Gregory Etelson
From: Tamar Mashiah Add DROP action to multi destination actions, set NOP destination type when DROP is specified. cc: sta...@dpdk.org Signed-off-by: Tamar Mashiah --- drivers/net/mlx5/hws/mlx5dr_action.c | 4 drivers/net/mlx5/hws/mlx5dr_cmd.c| 4 2 files changed, 8 insertions(+

[PATCH 1/2] net/mlx5: add DROP destination to mirror clone actions

2025-02-13 Thread Gregory Etelson
From: Tamar Mashiah Add DROP destination to mirror clone actions. cc: sta...@dpdk.org Signed-off-by: Tamar Mashiah --- .mailmap| 1 + drivers/common/mlx5/mlx5_prm.h | 1 + drivers/net/mlx5/mlx5_flow_hw.c | 5 + 3 files changed, 7 insertions(+) diff --git a/.mailm

[PATCH] net/mlx5: fix the GRE mask set on root table

2025-02-10 Thread Gregory Etelson
From: Bing Zhao When setting the value, the GRE mask cannot reuse the one from the value, or else the value cannot be really ANDed with the proper input mask from the user. If the value contains more valid bits than the mask, the rule insertion on the root table will get a failure due to the extr

[PATCH] net/mlx5: fix packet hardware ptype translation

2025-02-09 Thread Gregory Etelson
From: Viacheslav Ovsiienko Since ConnectX-8 NIC the hardware recognizes L4 protocol in the IP fragments if the IP offset is zero and reports the L4 protocol type in CQE fields. This case was not supported in the ptype translation table cause not reporting the ptype in the mbufs. Fixes: ea16068c0

[PATCH] net/mlx5/hws: change error flow on matcher disconnect

2025-02-09 Thread Gregory Etelson
From: Itamar Gozlan Currently, when a firmware (FW) failure occurs during matcher error flow, the system attempts to reconnect the matcher, leading to a segmentation fault. This happens because the matcher is freed but remains in the list. Example scenario: Given matchers M1->M2->M3, if a FW fai

[PATCH] crypto/mlx5: log when num of segs exceed max segs

2025-02-09 Thread Gregory Etelson
From: Shani Peretz This patch logs and aborts when mbuf segment count exceeding max_segs_num. The log message suggests the user to either increase the segment size or set a higher value for the max_segs_num devarg. Fixes: b01095830734 ("crypto/mlx5: add GCM enqueue/dequeue operations") Signed-o

[PATCH v7] testpmd: add hairpin map parameter

2024-10-30 Thread Gregory Etelson
port 2, queue 4. The new `hairpin-map` parameter is optional. If omitted, testpmd will create "default" hairpin maps. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- app/test-pmd/hairpin.c| 350 ++ app/test-pmd/m

[PATCH v6] testpmd: add hairpin map parameter

2024-10-30 Thread Gregory Etelson
port 2, queue 4. The new `hairpin-map` parameter is optional. If omitted, testpmd will create "default" hairpin maps. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- app/test-pmd/hairpin.c| 360 ++ app/test-pmd/m

[PATCH] net/mlx5: fix PMD compilation in non-HWS setup

2024-10-29 Thread Gregory Etelson
/mlx5: validate HWS context in meter operations") Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 9c43201e05..bfe757ec26 100644 --- a/drivers/net/mlx5/m

[PATCH v5 1/1] testpmd: add hairpin-map parameter

2024-10-28 Thread Gregory Etelson
Hello, Is this patch scheduled to be merged into DPDK-24.11 ? What can I do to speed up it's integration ? Regards, Gregory

[PATCH] net/mlx5: fix indirect list flow action callback invocation

2024-10-28 Thread Gregory Etelson
Fix indirect action list callback parameter. The function must be called with a flow action to process - not with actions list. Fixes: e26f50adbf38 ("net/mlx5: support indirect list meter mark action") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Ori Kam --- driver

[PATCH] net/mlx5: validate HWS context in meter operations

2024-10-27 Thread Gregory Etelson
HWS context is created during port configuration. PMD allowed meter operations before port configuration. The patch rejects HWS meter operations before port configuration. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h| 18

[PATCH] net/mlx5: fix SWS meter state initialization

2024-10-27 Thread Gregory Etelson
The PMD uses METER `state` variable to monitor ASO object availability. The patch updates SWS meter object state. Fixes: 4359d9d1f76b ("net/mlx5: fix sync meter processing in HWS") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- driver

[PATCH] net/mlx5: fix non-template API actions template validation

2024-10-27 Thread Gregory Etelson
: 04a4de756e14 ("net/mlx5: support flow age action with HWS") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/driver

[PATCH] net/mlx5: fix internal SQ item definition

2024-10-27 Thread Gregory Etelson
Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h index db56ae051d..9cf54c3a6a 100644 --- a/drivers/net/mlx5/mlx5_flow

[PATCH] net/mlx5: fix error notifications in counter initialization

2024-10-27 Thread Gregory Etelson
) Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 31 ++-- drivers/net/mlx5/mlx5_hws_cnt.c | 123 drivers/net/mlx5/mlx5_hws_cnt.h | 5 +- drivers/net/mlx5/mlx5_trigger.c | 10 ++- 4 fil

[PATCH] net/mlx5: increase number of supported DV sub-flows

2024-10-27 Thread Gregory Etelson
/ \ end flow create 0 priority 15 group 271 ingress \ pattern mark id spec 16777184 id mask 0xff / end \ actions sample ratio 1 index 1 / queue index 0 / end Increase number of supported DV sub-flows to 64 Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5

[PATCH] net/mlx5/hws: fix range definer error recovery

2024-10-27 Thread Gregory Etelson
finer creation") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/hws/mlx5dr_definer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index a9fa5d06ed..

[PATCH] net/mlx5: fix GRE item translation for root table

2024-10-27 Thread Gregory Etelson
Flow items translations for the root tables reuses DV code. DV GRE item translation did not initiate item mask for HWS template. Fixes: cd4ab742064a ("net/mlx5: split flow item matcher and value translation") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Su

[PATCH] net/mlx5: fix raw encap validation

2024-10-26 Thread Gregory Etelson
validation in `mlx5_flow_dv_validate_action_raw_encap_decap` for SWS and HWS cases. Fixes: cbfa4ed03913 ("net/mlx5: update flow actions validation before template creation") Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow_dv.c | 17 + 1 file changed, 13 insert

[PATCH v5 1/1] testpmd: add hairpin-map parameter

2024-09-21 Thread Gregory Etelson
port 2, queue 4. The new `hairpin-map` parameter is optional. If omitted, testpmd will create "default" hairpin maps. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- app/test-pmd/hairpin.c| 386 ++ app/test-pmd/m

[PATCH v4 1/1] testpmd: add hairpin-map parameter

2024-09-10 Thread Gregory Etelson
port 2, queue 4. The new `hairpin-map` parameter is optional. If omitted, testpmd will create "default" hairpin maps. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- app/test-pmd/hairpin.c| 385 ++ app/test-pmd/m

[PATCH] net/mlx5: fix IPv6-in-IPv6 tunnel recognition

2024-07-07 Thread Gregory Etelson
The PMD did not recognize IPv6-in-IPv6 tunnel if IPv6 routing extension was placed between IPv6 outer and inner headers. The patch fixes IPv6-in-IPv6 tunnel recognition. Fixes: 80c676259a04 ("net/mlx5: validate HWS template items") Signed-off-by: Gregory Etelson Acked-by: Dariusz

[PATCH] net/mlx5: fix compilation warning in GCC-9.1

2024-07-07 Thread Gregory Etelson
PMD compilation in the INTEGRITY flow item. Fixes: 23b0a8b298b1 ("net/mlx5: fix integrity item validation and translation") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_dv.c | 4 +++- 1 file changed, 3 insertions(+),

[PATCH] net/mlx5: fix indexed pool resize

2024-07-07 Thread Gregory Etelson
On success, indexed pool resize sets maximal pool entries number to the `num_entries` parameter value. The patch fixes maximal pool entries assignment. The patch also adds `error` parameter to log error types. Fixes: 89578504edd9 ("net/mlx5: add ipool resize function") Signed-off-b

[PATCH] net/mlx5: increase max pattern templates

2024-07-01 Thread Gregory Etelson
From: Ori Kam Until now the number of pattern templates that was supported per table was limited to 2. This was the result of the limitation that the table could only support 1 matcher. which meant that we could only support merge of Ipv4 + TCP and IPv4 + UDP. With the added ability to use exten

[PATCH] net/mlx5: fix HWS GRE OPTION item validation

2024-06-23 Thread Gregory Etelson
group value. HWS pattern template does not have a group. The patch removes group validations for GRE_OPTION item. Fixes: 113feae56db6 ("net/mlx5: validate HWS template items") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_f

[PATCH v4] net: add bit fields to IPv6 header definition

2024-06-18 Thread Gregory Etelson
class` is also separated into DS and ECN fields. The patch also preserves existing `vtc_flow` structure member for backward compatibility. Signed-off-by: Gregory Etelson --- v2: Replace uint32_t with rte_be32_t. Split traffic_class into DS and ECN bits. v3: Define both traffic_class and DS + ECN

[PATCH v3] net: add bit fields to IPv6 header definition

2024-06-18 Thread Gregory Etelson
class` is also separated into DS and ECN fields. The patch also preserves existing `vtc_flow` structure member for backward compatibility. Signed-off-by: Gregory Etelson --- v2: Replace uint32_t with rte_be32_t. Split traffic_class into DS and ECN bits. v3: Define both traffic_class and DS + ECN

[PATCH v2] net: add bit fields to IPv6 header definition

2024-06-18 Thread Gregory Etelson
class` is also separated into DS and ECN fields. The patch also preserves existing `vtc_flow` structure member for backward compatibility. Signed-off-by: Gregory Etelson --- v2: Replace uint32_t with rte_be32_t. Split traffic_class into DS and ECN bits. --- lib/net/rte_ip.h | 18

[PATCH] net: add bit fields to IPv6 header definition

2024-06-17 Thread Gregory Etelson
also preserves existing `vtc_flow` structure member for backward compatibility. Signed-off-by: Gregory Etelson --- lib/net/rte_ip.h | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h index 0d103d4127..26e78a6624 100644 --- a/lib

[PATCH 2/2] net/mlx5: fix non-template IPv6 RSS hash

2024-06-17 Thread Gregory Etelson
. Fixes: 1ca9ec661a02 ("net/mlx5: support RSS expansion in non-template HWS setup") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_nta_rss.c | 91 - 1 file changed, 78 insertions(+), 13 deletions(-) diff --git a/driver

[PATCH 1/2] net/mlx5: refactor non-template RSS expansion

2024-06-17 Thread Gregory Etelson
required. The function returns NULL if it failed to create RSS flow. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 6 +- drivers/net/mlx5/mlx5_nta_rss.c | 24 ++-- 2 files changed, 15 insertions(+), 15 deletions

[PATCH 0/2] fix non-template IPv6 RSS hash

2024-06-17 Thread Gregory Etelson
Gregory Etelson (2): net/mlx5: refactor non-template RSS expansion net/mlx5: fix non-template IPv6 RSS hash drivers/net/mlx5/mlx5_flow_hw.c | 6 +- drivers/net/mlx5/mlx5_nta_rss.c | 99 - 2 files changed, 85 insertions(+), 20 deletions(-) Acked-by: Dariusz

[PATCH] net/mlx5: fix HWS VXLAN item validation

2024-06-17 Thread Gregory Etelson
HWS can match entire VXLAN, VXLAN-GPE and VXLAN-GBP headers. No need for mask validation. Fixes: 113feae56db6 ("net/mlx5: validate HWS template items") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.c | 21 +++-- 1 file c

[PATCH] net/mlx5: validate HWS template items

2024-06-04 Thread Gregory Etelson
HWS item validation scheme is based on existing DV items validation. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- Depends-on: series-32045 ("validate actions in HWS table") --- drivers/net/mlx5/linux/mlx5_flow_os.c | 21 +- drivers/net/mlx5/linux/mlx5_flow_os

[PATCH 2/2] net/mlx5: validate flow actions in table creation

2024-06-01 Thread Gregory Etelson
Add basic actions validation before creating flow table. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5.h| 13 + drivers/net/mlx5/mlx5_flow.c | 15 +- drivers/net/mlx5/mlx5_flow.h | 33 ++- drivers/net/mlx5/mlx5_flow_dv.c

[PATCH 1/2] net/mlx5: fix access to PMD template API

2024-06-01 Thread Gregory Etelson
ation") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 68c5a36bbb..427d7f2359 100644 --- a/driver

[PATCH 0/2] validate actions in HWS table

2024-06-01 Thread Gregory Etelson
Validate flow actions before creation of HWS template table. Gregory Etelson (2): net/mlx5: fix access to PMD template API net/mlx5: validate flow actions in table creation drivers/net/mlx5/mlx5.h| 13 + drivers/net/mlx5/mlx5_flow.c | 15 +- drivers/net/mlx5/mlx5_flow.h

Re: [PATCH v3] cmdline: increase input buffer size

2024-05-15 Thread Gregory Etelson
Hello, What is the status of that patch ? Regards, Gregory From: Gregory Etelson Sent: Friday, May 3, 2024 07:27 To: Gregory Etelson Cc: Ali Alnubani ; dev@dpdk.org ; Maayan Kashani ; Raslan Darawsheh ; bruce.richard...@intel.com ; step...@networkplumber.org

[PATCH v3] cmdline: increase input buffer size

2024-05-02 Thread Gregory Etelson
dst_level 0 dst_offset 0 src_type value \ src_value ff width 8 / count / jump group 100 / end ``` The patch increases cmdline input buffer size to the LINE_MAX value, which typically is 2048 bytes. Signed-off-by: Gregory Etelson Acked-by: Bruce Richardson Reviewed-by: Morten Brørup --- v2: set

[PATCH v2] cmdline: increase input buffer size

2024-05-01 Thread Gregory Etelson
dst_level 0 dst_offset 0 src_type value \ src_value ff width 8 / count / jump group 100 / end ``` The patch increases cmdline input buffer size to the LINE_MAX value. Signed-off-by: Gregory Etelson --- v2: set RDLINE_BUF_SIZE to LINE_MAX change the patch subject --- lib/cmdline

[PATCH] cmdline: configure input buffer size

2024-04-30 Thread Gregory Etelson
=4096' ...` Signed-off-by: Gregory Etelson --- lib/cmdline/cmdline_private.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/cmdline/cmdline_private.h b/lib/cmdline/cmdline_private.h index b64f363903..7908d963f9 100644 --- a/lib/cmdline/cmdline_private.h +++ b/lib/cmdline/cmdline_private.

Re: [PATCH] app/testpmd: fix auto completion for indirect list action

2024-03-23 Thread Gregory Etelson
will crash the controlled testpmd process. I've compiled a small programm to test that idea. Please check it out. Regards, Gregory. commit e4a27c2c2892cfd408b473b18192b30927e4281c Author: Gregory Etelson Date: Sat Mar 23 11:38:44 2024 +0200 validate testpmd flow command diff -

[PATCH] net/mlx5/hws: fix invalid memory access in decapl3

2024-03-22 Thread Gregory Etelson
From: Alex Vesker In case decapL3 action is created we would access header data even in case the SHARED flag is not set, this would lead to an invalid memory access. Fixes: 3a6c50215c07 ("net/mlx5/hws: support multi-pattern") Cc: sta...@dpdk.org Signed-off-by: Alex Vesker --- drivers/net/mlx

Re: [PATCH] app/testpmd: fix auto completion for indirect list action

2024-03-19 Thread Gregory Etelson
Hello Ferruh, >BUT overall how can we catch issues like this in the feature, we don't >have a good way to test testpmd flow commands. >@Ori, @Gregory, do you have any idea? >cc'ed CI mail list too. We have a tool for unit tests based on the testpmd. The tool details are here: https://drive.goog

[PATCH v2] net/mlx5: fix sync meter action

2024-03-19 Thread Gregory Etelson
provided to `flow_hw_job_put()`. This patch also removes dead code found in METER_MARK destroy handler. Coverity issue: 415806 Coverity issue: 415804 Fixes: 4359d9d1f76b ("net/mlx5: fix sync meter processing in HWS") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- v2: Fixe

[PATCH] net/mlx5: fix sync meter action

2024-03-18 Thread Gregory Etelson
;) Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c| 5 + drivers/net/mlx5/mlx5_flow_meter.c | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index

[PATCH] app/testpmd: fix async indirect list action creation

2024-03-07 Thread Gregory Etelson
: add INDIRECT_LIST flow action support") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 1 + app/test-pmd/config.c | 5 ++--- app/test-pmd/testpmd.h | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline_fl

[PATCH v2 3/3] net/mlx5: fix indirect action async job initialization

2024-03-07 Thread Gregory Etelson
("net/mlx5: fix indirect flow completion processing") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/driver

[PATCH v2 2/3] net/mlx5: fix sync meter processing in HWS setup

2024-03-07 Thread Gregory Etelson
. The patch implements sync meter ASO interface with async calls in the template API environment. Fixes: 48fbb0e93d06 ("net/mlx5: support flow meter mark indirect action with HWS") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/m

[PATCH v2 0/3] net/mlx5: fix sync meter processing in HWS setup

2024-03-07 Thread Gregory Etelson
Implement sync meter ASO interface for async calls in the template API environment. Gregory Etelson (3): net/mlx5: fix HWS meter actions availability net/mlx5: fix sync meter processing in HWS setup net/mlx5: fix indirect action async job initialization drivers/net/mlx5/mlx5.h

[PATCH v2 1/3] net/mlx5: fix HWS meter actions availability

2024-03-07 Thread Gregory Etelson
Allow compilation of HWS meter code only on platforms that support HWS. Fixes: 24865366e495 ("net/mlx5: support flow meter action for HWS") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_me

[PATCH 3/3] net/mlx5: fix indirect action async job initialization

2024-03-07 Thread Gregory Etelson
("net/mlx5: fix indirect flow completion processing") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/driver

[PATCH 2/3] net/mlx5: fix sync meter processing in HWS setup

2024-03-07 Thread Gregory Etelson
. The patch implements sync meter ASO interface with async calls in the template API environment. Fixes: 48fbb0e93d06 ("net/mlx5: support flow meter mark indirect action with HWS") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/m

[PATCH 0/3] net/mlx5: fix sync meter processing in HWS setup

2024-03-07 Thread Gregory Etelson
Implement sync meter ASO interface for async calls in the template API environment. Gregory Etelson (3): net/mlx5: fix HWS meter actions availability net/mlx5: fix sync meter processing in HWS setup net/mlx5: fix indirect action async job initialization drivers/net/mlx5/mlx5.h

[PATCH 1/3] net/mlx5: fix HWS meter actions availability

2024-03-07 Thread Gregory Etelson
Allow compilation of HWS meter code only on platforms that support HWS. Fixes: 24865366e495 ("net/mlx5: support flow meter action for HWS") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_me

[PATCH] net/mlx5: fix pattern template size validation

2024-03-05 Thread Gregory Etelson
, during group 0 validation HWS tuned pattern was processed as DV. The patch removed pattern validation for group 0. Fixes: f3aadd103358 ("net/mlx5: improve pattern template validation") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow

Re: [PATCH v3] testpmd: add hairpin-map parameter

2024-03-04 Thread Gregory Etelson
, 2024 20:54 To: Gregory Etelson ; dev@dpdk.org Cc: Maayan Kashani ; NBU-Contact-Thomas Monjalon (EXTERNAL) ; Aman Singh ; Yuying Zhang ; David Marchand Subject: Re: [PATCH v3] testpmd: add hairpin-map parameter External email: Use caution opening links or attachments On 9/28/2023 4:36 PM

[PATCH] net/mlx5: fix VID assignment in VLAN modify

2024-02-29 Thread Gregory Etelson
. The patch assigns VLAN Id directly to `.value` Fixes: 773ca0e91ba1 ("net/mlx5: support VLAN push/pop/modify with HWS") Cc: sta...@dpdk.org (backport) Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 14 +++--- 1 file changed, 7

[PATCH 0/2] fix IP-in-IP tunnels recognition

2024-02-29 Thread Gregory Etelson
fix IP-in-IP tunnels validation and recognition Gregory Etelson (2): net/mlx5: remove code duplications net/mlx5: fix IP-in-IP tunnels recognition drivers/net/mlx5/mlx5_flow_dv.c | 243 +++- 1 file changed, 117 insertions(+), 126 deletions(-) Acked-by: Ori Kam

[PATCH 2/2] net/mlx5: fix IP-in-IP tunnels recognition

2024-02-29 Thread Gregory Etelson
The patch fixes IP-in-IP tunnel recognition for the following patterns / [ipv4|ipv6] proto is [ipv4|ipv6] / end / [ipv4|ipv6] / [ipv4|ipv6] / Fixes: 3d69434113d1 ("net/mlx5: add Direct Verbs validation function") Signed-off-by: Gregory Etelson Acked-by: Ori Kam --- driver

[PATCH 1/2] net/mlx5: remove code duplications

2024-02-29 Thread Gregory Etelson
Remove code duplications in DV L3 items validation translation. Fixes: 3193c2494eea ("net/mlx5: fix L4 protocol validation") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 151 +--- 1 file c

[PATCH] net/mlx5: fix non-masked indirect list meter translation in flow rule

2024-02-29 Thread Gregory Etelson
. The patch always translates non-masked indirect list meter object. Fixes: e26f50adbf38 ("net/mlx5: support indirect list meter mark action") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow

[PATCH] net/mlx5: fix sync meter processing in HWS setup

2024-02-29 Thread Gregory Etelson
. The patch implements sync meter ASO interface with async calls in the template API environment. Fixes: 48fbb0e93d06 ("net/mlx5: support flow meter mark indirect action with HWS") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Ori Kam --- drivers/net/mlx5/mlx5.h

[PATCH] net/mlx5: fix action template expansion: support indirect actions list

2024-02-29 Thread Gregory Etelson
patch adds indirect actions list to calculation of the new MODIFY_HEADER location. Fixes: e26f50adbf38 ("net/mlx5: support indirect list meter mark action") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow

  1   2   3   4   5   6   7   8   >