Re: [PATCH] maintainers: update for ethdev library

2025-07-15 Thread Ferruh Yigit
On 7/11/2025 3:43 PM, Thomas Monjalon wrote: > Ferruh Yigit has no time this year for ethdev maintenance. > > Signed-off-by: Thomas Monjalon > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0e9357f3a3

Re: [PATCH] MAINTAINERS: update maintainers for next-net

2024-12-05 Thread Ferruh Yigit
ertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 60bdcce543..b5690735b1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -28,8 +28,8 @@ M: David Marchand > T: git://dpdk.org/dpdk > > Next-net Tree > +M: Stephen Hemminger > M: Ferruh Yi

Re: [PATCH] net/txgbe: fix a mass of interrupts

2024-11-18 Thread Ferruh Yigit
On 11/15/2024 8:33 AM, Jiawen Wu wrote: > Since firmware version 0x20010, GPIO interrupt enable is set to 0xd by > default, which means enable bit 0 'tx_fault'. And GPIO interrupt polarity > is set to 0xd by default too, which means these interrupts are rising-edge > sensitive. > > So when unplug

Re: [PATCH v8 00/17] modify something as suggested

2024-11-13 Thread Ferruh Yigit
W version > net/r8169: add driver start and driver stop > For series, Reviewed-by: Ferruh Yigit Series applied to dpdk-next-net/main, thanks. This series should be part of -rc3 release. When -rc3 released, can you please send a brief test report, by replying to the release email? This is a

Re: [PATCH 0/3] unnecessary checks for null

2024-11-12 Thread Ferruh Yigit
r null before free > For series, Acked-by: Ferruh Yigit Btw, script catches 'rte_openssl_pmd.c' for 'EVP_PKEY_free()' call, which seems ignoring the NULL value, it can be separate patch for crypto tree. Series applied to dpdk-next-net/main, thanks.

Re: [PATCH v7 00/17] modify code as suggested by the maintainer

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:57 AM, Howard Wang wrote: > ./devtools/check- and some small issues > > Howard Wang (17): > net/r8169: add PMD driver skeleton > net/r8169: add logging structure > net/r8169: add hardware registers access routines > net/r8169: implement core logic for Tx/Rx > net/r816

Re: [PATCH v7 14/17] net/r8169: implement promisc and allmulti modes

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:58 AM, Howard Wang wrote: > diff --git a/doc/guides/nics/features/r8169.ini > b/doc/guides/nics/features/r8169.ini > index e4bbcde2a0..d2ad94dcc6 100644 > --- a/doc/guides/nics/features/r8169.ini > +++ b/doc/guides/nics/features/r8169.ini > @@ -10,6 +10,10 @@ Link status =

Re: [PATCH v7 11/17] net/r8169: implement Rx path

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:57 AM, Howard Wang wrote: > diff --git a/doc/guides/nics/features/r8169.ini > b/doc/guides/nics/features/r8169.ini > index ccb4cd9c23..889e211863 100644 > --- a/doc/guides/nics/features/r8169.ini > +++ b/doc/guides/nics/features/r8169.ini > @@ -8,7 +8,12 @@ Speed capabilities = Y

Re: [PATCH v7 01/17] net/r8169: add PMD driver skeleton

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:57 AM, Howard Wang wrote: > Meson build infrastructure, r8169_ethdev minimal skeleton, > header with Realtek NIC device and vendor IDs. > > Signed-off-by: Howard Wang > --- > MAINTAINERS| 8 ++ > doc/guides/nics/features/r8169.ini | 9 ++ > doc

Re: [PATCH v7 08/17] net/r8169: add support for PHY configuration

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:57 AM, Howard Wang wrote: > This patch is for phy configuration which contains phy power up/down, > phy config, ephy config and so on. > > Signed-off-by: Howard Wang > checkpatch warnings: CHECK:BOOL_COMPARISON: Using comparison to TRUE is error prone #407: FILE: drivers/net/r81

Re: [PATCH v7 07/17] net/r8169: add support for hardware operations

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:57 AM, Howard Wang wrote: > + > +#define TRUE 1 > +#define FALSE 0 > Also checkpatch has BOOL_COMPARISON warnings [1], technically "(hw->NotWrMcuPatchCode == TRUE)" can be "(hw->NotWrMcuPatchCode)" they are same. As you are defining TRUE & FALSE as above (since this is compatibil

Re: [PATCH v7 02/17] net/r8169: add logging structure

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 9:57 AM, Howard Wang wrote: > Implement logging macros for debug purposes. > > Signed-off-by: Howard Wang > <...> > + > +#ifdef RTE_ETHDEV_DEBUG_RX > +#define PMD_RX_LOG(level, fmt, ...) \ > + RTE_LOG_DP_LINE(level, R8169_RX, "%s(): " fmt, __func__, ##__VA_ARGS__) > +#else >

Re: Bus scan is too chatty

2024-11-12 Thread Ferruh Yigit
On 11/12/2024 5:35 PM, Patrick Robb wrote: > Hello, > > I'm noting here that the compressdev test failures reported over the > weekend for the Community Lab are related to this, as the DTS > compressdev tests fail if EAL contains "failed." So, these patchseries > failures can be ignored by maintai

Re: [PATCH v1 0/2] Testpmd flow update/destroy fixes

2024-11-11 Thread Ferruh Yigit
On 10/31/2024 3:00 PM, Danylo Vodopianov wrote: > These patches provide next fixes: > 1. The testpmd command “flow update…“ provides a nullptr as the > context variable. > 2. Avoid removal of additional flows after requested number of flows has > been already removed.

Re: 答复: 答复: [PATCH v6 01/17] net/r8169: add PMD driver skeleton

2024-11-11 Thread Ferruh Yigit
as soon as possible. I have had a fever recently, so it > might be a bit slow. > Great, thanks. (And I hope you get better soon ;) > > Best Regards, > Howard Wang > > -邮件原件- > 发件人: Ferruh Yigit > 发送时间: 2024年11月11日 17:09 > 收件人: 王颢 ; dev@dpdk.org > 抄送: pr

Re: 答复: [PATCH v6 08/17] net/r8169: add support for phy configuration

2024-11-11 Thread Ferruh Yigit
ssible. > Best Regards, > Howard Wang > > -邮件原件- > 发件人: Ferruh Yigit > 发送时间: 2024年11月11日 8:17 > 收件人: 王颢 ; dev@dpdk.org > 抄送: pro_nic_d...@realtek.com > 主题: Re: [PATCH v6 08/17] net/r8169: add support for phy configuration > > > External mail. >

Re: 答复: [PATCH v6 01/17] net/r8169: add PMD driver skeleton

2024-11-11 Thread Ferruh Yigit
0x8126) }, { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x5000) }, > > Best regards, > Howard Wang > > -邮件原件- > 发件人: Ferruh Yigit > 发送时间: 2024年11月11日 8:15 > 收件人: 王颢 ; dev@dpdk.org > 抄送: pro_nic_d...@realtek.com > 主题: Re: [PATCH v6 01/17] net/r8169:

Re: [PATCH 2/2] net/mlx5: fix build with Gcc 15

2024-11-10 Thread Ferruh Yigit
On 11/10/2024 6:41 PM, Stephen Hemminger wrote: > Fixes warnings from Gcc 15 about using string for initialization. > ../drivers/net/mlx5/mlx5_flow.c: In function ‘mlx5_legacy_dmac_flow_create’: > ../drivers/net/mlx5/mlx5_flow.c:8568:44: warning: initializer-string for > array of ‘unsigned char’ i

Re: [PATCH 1/2] net/dpaa2: fix build with Gcc 15

2024-11-10 Thread Ferruh Yigit
quot;\xff\xff\xff", > |^~ > > Fixes: 39c8044ffb7b ("net/dpaa2: support VXLAN flow matching") > Cc: jun.y...@nxp.com > > Signed-off-by: Stephen Hemminger > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [PATCH] net/mlx5: fix MAC address initialization

2024-11-10 Thread Ferruh Yigit
3 | .hdr.dst_addr.addr_bytes = > "\xff\xff\xff\xff\xff\xff", > | > ^~ > > This patch fixes this issue by converting it to array initialization. > > Fixes: cf99567fe566 ("net/mlx5: add legacy unicast flow rules man

Re: [PATCH v6 00/17] Modify code as suggested by the maintainer.

2024-11-10 Thread Ferruh Yigit
On 11/8/2024 12:11 PM, Howard Wang wrote: > Remove some headers and code that are not used. > Improve r8169.ini and r8169.rst gradually. > > Howard Wang (17): > net/r8169: add PMD driver skeleton > net/r8169: add logging structure > net/r8169: add hardware registers access routines > net/r

Re: [PATCH v6 12/17] net/r8169: implement Tx path

2024-11-10 Thread Ferruh Yigit
On 11/8/2024 12:11 PM, Howard Wang wrote: > Add implementation for TX datapath. > > Signed-off-by: Howard Wang > --- > doc/guides/nics/features/r8169.ini | 6 +- > doc/guides/nics/r8169.rst | 1 + > drivers/net/r8169/r8169_ethdev.c | 6 + > drivers/net/r8169/r8169_ethdev.h |

Re: [PATCH v6 13/17] net/r8169: implement device statistics

2024-11-10 Thread Ferruh Yigit
On 11/8/2024 12:11 PM, Howard Wang wrote: > Signed-off-by: Howard Wang > --- > doc/guides/nics/features/r8169.ini | 3 ++ > drivers/net/r8169/r8169_compat.h | 16 ++ > drivers/net/r8169/r8169_ethdev.c | 48 ++ > drivers/net/r8169/r8169_ethdev.h | 3 ++ > drivers/net/r8

Re: [PATCH v6 11/17] net/r8169: implement Rx path

2024-11-10 Thread Ferruh Yigit
On 11/8/2024 12:11 PM, Howard Wang wrote: > Add implementation for RX datapath. > > Signed-off-by: Howard Wang > --- > doc/guides/nics/features/r8169.ini | 12 + > doc/guides/nics/r8169.rst | 8 + > drivers/net/r8169/r8169_compat.h | 24 + > drivers/net/r8169/r8169_ethdev.c | 7

Re: [PATCH v6 09/17] net/r8169: add support for hw initialization

2024-11-10 Thread Ferruh Yigit
On 11/8/2024 12:11 PM, Howard Wang wrote: > This patch initializes software variables, resets the NIC, and performs > other hw initialization tasks. > > Signed-off-by: Howard Wang > <...> > @@ -24,8 +24,8 @@ > #define MII_EXPANSION0x06/* Expansion register > */ >

Re: [PATCH v6 08/17] net/r8169: add support for phy configuration

2024-11-10 Thread Ferruh Yigit
On 11/8/2024 12:11 PM, Howard Wang wrote: > This patch contains phy config, ephy config and so on. > > Signed-off-by: Howard Wang > <...> > @@ -62,6 +62,12 @@ rtl_dev_start(struct rte_eth_dev *dev) > struct rtl_hw *hw = &adapter->hw; > int err; > > + rtl_powerup_pll(hw); > +

Re: [PATCH v6 05/17] net/r8169: add support for hw config

2024-11-10 Thread Ferruh Yigit
On 11/8/2024 12:11 PM, Howard Wang wrote: > Implement the rtl_hw_config function to configure the hardware. > > Signed-off-by: Howard Wang > <...> > +void > +rtl_nic_reset(struct rtl_hw *hw) > +{ > + int i; > + > + rtl_disable_rx_packet_filter(hw); > + > + rtl_enable_rxdvgate(hw);

Re: [PATCH v6 01/17] net/r8169: add PMD driver skeleton

2024-11-10 Thread Ferruh Yigit
On 11/8/2024 12:11 PM, Howard Wang wrote: > Meson build infrastructure, r8169_ethdev minimal skeleton, > header with Realtek NIC device and vendor IDs. > > Signed-off-by: Howard Wang <...> > +/* > + * The set of PCI devices this driver supports > + */ > +static const struct rte_pci_id pci_id_r8

Re: [PATCH 0/2] net/hns3: bugfix for hns3

2024-11-10 Thread Ferruh Yigit
On 11/7/2024 11:56 AM, Jie Hai wrote: > This patchset fixes some bugs. > > Dengdui Huang (2): > net/hns3: fix error code for repeatedly create counter > net/hns3: fix cannot fully use hardware flow director table > Acked-by: Stephen Hemminger Series applied to dpdk-next-net/main, thanks.

Re: [PATCH v2 07/10] net/mlx5: add legacy unicast flow rules management

2024-11-08 Thread Ferruh Yigit
On 10/22/2024 1:06 PM, Dariusz Sosnowski wrote: > This patch adds the following internal functions for creation of > unicast DMAC flow rules: > > - mlx5_legacy_dmac_flow_create() - simple wrapper over > mlx5_ctrl_flow(). > - mlx5_legacy_dmac_vlan_flow_create() - simple wrapper over > mlx5_ctrl

Re: [v2 00/12] ENETC4 PMD support

2024-11-07 Thread Ferruh Yigit
On 10/23/2024 7:24 AM, vanshika.shu...@nxp.com wrote: > From: Vanshika Shukla > > This series introduces a new ENETC4 PMD driver for NXP's i.MX95 > SoC, enabling basic network operations. > > V2 changes: > Handled code comments by the reviewer in: > "net/enetc: Add initial ENETC4 PMD drive

Re: [PATCH v10 00/10] net/zxdh: introduce net zxdh driver

2024-11-07 Thread Ferruh Yigit
On 11/7/2024 9:28 AM, Ferruh Yigit wrote: > On 11/6/2024 12:40 AM, Ferruh Yigit wrote: >> On 11/4/2024 11:58 AM, Junlong Wang wrote: >>> v10: >>>   - >>>  move zxdh under Wind River in MAINTAINERS and add myself as the maintainer >>> and add exp

Re: [PATCH v10 00/10] net/zxdh: introduce net zxdh driver

2024-11-07 Thread Ferruh Yigit
On 11/6/2024 12:40 AM, Ferruh Yigit wrote: > On 11/4/2024 11:58 AM, Junlong Wang wrote: >> v10: >>   - >>  move zxdh under Wind River in MAINTAINERS and add myself as the maintainer >> and add experimental into MAINTAINERS/driver file,elease notes. >>   - chan

Re: [PATCH] net/zxdh: remove redundant log prefix

2024-11-06 Thread Ferruh Yigit
On 11/6/2024 9:08 AM, David Marchand wrote: > By using RTE_LOG*() macros, the log messages are prefixed by the logtype. > > RTE_LOG_LINE_PREFIX(level, ZXDH_RX, "zxdh rx %s(): ", ... > will emit messages like "ZXDH_RX: zxdh rx %s(): ...\n" > > There is no need to add a prefix repeating the same in

Re: [PATCH v3 1/1] net/bonding: make bonding functions stable

2024-11-05 Thread Ferruh Yigit
On 10/31/2024 2:24 AM, lihuisong (C) wrote: > 在 2024/10/30 23:42, Lukas Sismis 写道: >> Remove rte_experimental macros from the stable functions >> as they have been part of the stable API since 23.11. >> >> Signed-off-by: Lukas Sismis > > Acked-by: Huisong Li > Carrying from other thread: Acked-

Re: [PATCH] net/hns3: support flow rule priority

2024-11-05 Thread Ferruh Yigit
On 10/30/2024 9:29 AM, Jie Hai wrote: > From: Dengdui Huang > > The hardware determines the priority of the flow rule based on the position > of the rule in the hardware flow director table. Lower index denotes higher > priority (it means when a packet matches multiple indexes, the smaller > inde

Re: [PATCH v3 2/2] net/vmxnet3: support larger MTU with version 6

2024-11-05 Thread Ferruh Yigit
On 11/4/2024 9:44 PM, Jochen Behrens wrote: > On 11/4/24 02:52, Morten Brørup wrote: >> Virtual hardware version 6 supports larger max MTU, but the device >> information (dev_info) did not reflect this, so it could not be used. >> >> Fixes: b1584dd0affe ("net/vmxnet3: support version 6") >> >> Sig

Re: [PATCH v3 1/2] net/vmxnet3: fix potential out of bounds access

2024-11-05 Thread Ferruh Yigit
is supported. > > Fixes: b1584dd0affe ("net/vmxnet3: support version 6") > > Signed-off-by: Morten Brørup > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [PATCH v4 0/4] NFP PMD enhancement

2024-11-05 Thread Ferruh Yigit
On 11/4/2024 1:34 AM, Chaoyong He wrote: > This patch series fix one problem imported by mistake and add support of > two new APIs. > > --- > v4: > * Also update the 'nfp.ini' file. > v3: > * Adapt to the multiple PF firmware. > v2: > * Add one missing commit. > --- > > Chaoyong He (4): > net/n

Re: [PATCH v3 00/13] Wangxun fixes

2024-11-05 Thread Ferruh Yigit
On 11/4/2024 2:29 AM, Jiawen Wu wrote: > Fix some bugs in txgbe/ngbe, and optimize the Tx flow. > > v2 -> v3: > - Reset Tx desc error statistics in .stats_reset(). > - Add comment for Tx desc error count. > > v1 -> v2: > - Fix build errors on ARM platform. > > Jiawen Wu (13): > net/txgbe: fix

Re: [PATCH v10 00/10] net/zxdh: introduce net zxdh driver

2024-11-05 Thread Ferruh Yigit
t >   net/zxdh: add msg chan enable implementation >   net/zxdh: add zxdh get device backend infos >   net/zxdh: add configure zxdh intr implementation >   net/zxdh: add zxdh dev infos get ops >   net/zxdh: add zxdh dev configure ops >   net/zxdh: add zxdh dev close ops > For series, Acked-by: Ferruh Yigit Series applied to dpdk-next-net/main, thanks.

Re: [PATCH v9 0/9] net/zxdh: introduce net zxdh driver

2024-11-05 Thread Ferruh Yigit
On 11/5/2024 9:39 AM, Junlong Wang wrote: >> > > >> Hi Junlong, >> > > > >> > > >> I can see not all of the eth_dev_ops implemented, and datapath not >> > > >> implemented, so driver is not functional right now. >> > > > >> > > >> What happens if you want to run testpmd with the current state of th

Re: [PATCH v7] examples/ptpclient: add frequency adjustment

2024-11-05 Thread Ferruh Yigit
On 11/4/2024 9:30 AM, Rybalchenko, Kirill wrote: > >> -Original Message- >> From: Ye, MingjinX >> Sent: Tuesday 15 October 2024 09:22 >> To: dev@dpdk.org >> Cc: Ye, MingjinX ; Su, Simei ; >> Wenjun Wu ; Rybalchenko, Kirill >> >> Subject: [PATCH v7] examples/ptpclient: add frequency adjus

Re: 答复: [PATCH v5 01/18] net/r8169: add PMD driver skeleton

2024-11-05 Thread Ferruh Yigit
. And same for the release notes (doc/guides/rel_notes/release_24_11.rst), this patch may have the initial update announcing the new driver, if you want to announce more updates in release notes, they can be added in relevant patch in the series. > > Best Regards, > Howard Wang > >

Re: 答复: [PATCH v5 00/18] modify code as suggested by the maintainer

2024-11-04 Thread Ferruh Yigit
> maintenance, I have retained the CamelCase. > OK to keep the CamelCase syntax since code is shared. > Best Regards, > Howard Wang > > -邮件原件- > 发件人: Ferruh Yigit > 发送时间: 2024年11月3日 10:24 > 收件人: 王颢 ; dev@dpdk.org > 抄送: pro_nic_d...@realtek.com > 主题:

Re: [PATCH v9 0/9] net/zxdh: introduce net zxdh driver

2024-11-04 Thread Ferruh Yigit
On 11/4/2024 2:42 AM, Junlong Wang wrote: >>>   net/zxdh: add zxdh get device backend infos >>>   net/zxdh: add configure zxdh intr implementation >>>   net/zxdh: add zxdh dev infos get ops >>>   net/zxdh: add zxdh dev configure ops >>>  > >> Hi Junlong, > >> I can see not all of the eth_dev_ops 

Re: [PATCH v5 00/18] modify code as suggested by the maintainer

2024-11-02 Thread Ferruh Yigit
On 10/28/2024 7:30 AM, Howard Wang wrote: > Fix some warning issues. > > Howard Wang (18): > net/r8169: add PMD driver skeleton > net/r8169: add logging structure > net/r8169: add hardware registers access routines > net/r8169: implement core logic for Tx/Rx > net/r8169: add support for

Re: [PATCH v5 18/18] doc/guides/nics: add documents for r8169 pmd

2024-11-02 Thread Ferruh Yigit
On 10/28/2024 7:31 AM, Howard Wang wrote: > Signed-off-by: Howard Wang > --- > MAINTAINERS| 2 ++ > doc/guides/nics/features/r8169.ini | 32 ++ > doc/guides/nics/index.rst | 1 + > doc/guides/nics/r8169.rst | 17 +

Re: [PATCH v5 09/18] net/r8169: add support for hw initialization

2024-11-02 Thread Ferruh Yigit
On 10/28/2024 7:31 AM, Howard Wang wrote: > Signed-off-by: Howard Wang > Can you please add some description to the commit log? <...> > diff --git a/drivers/net/r8169/r8169_phy.h b/drivers/net/r8169/r8169_phy.h > index 1d8889f8dc..2576538a00 100644 > --- a/drivers/net/r8169/r8169_phy.h > +++ b

Re: [PATCH v5 03/18] net/r8169: add hardware registers access routines

2024-11-02 Thread Ferruh Yigit
On 10/28/2024 7:30 AM, Howard Wang wrote: > Add implementation for hardware registers access routines. > > Signed-off-by: Howard Wang > <...> > diff --git a/drivers/net/r8169/r8169_base.h b/drivers/net/r8169/r8169_base.h > index 6fc84592a6..2fa947b2d7 100644 > --- a/drivers/net/r8169/r8169_bas

Re: [PATCH v5 01/18] net/r8169: add PMD driver skeleton

2024-11-02 Thread Ferruh Yigit
On 10/28/2024 7:30 AM, Howard Wang wrote: > Meson build infrastructure, r8169_ethdev minimal skeleton, > header with Realtek NIC device and vendor IDs. > > Signed-off-by: Howard Wang > --- > MAINTAINERS | 7 ++ > drivers/net/meson.build | 1 + > drivers/net/r816

Re: [PATCH v3 4/4] net/nfp: add support for port identify

2024-11-02 Thread Ferruh Yigit
On 11/1/2024 2:57 AM, Chaoyong He wrote: > Implement the necessary functions to allow user to visually identify a > physical port associated with a netdev by blinking an LED on that port. > > Signed-off-by: James Hershaw > Signed-off-by: Chaoyong He > --- > .../net/nfp/flower/nfp_flower_represe

Re: [PATCH v3 3/4] net/nfp: add support for EEPROM functions

2024-11-02 Thread Ferruh Yigit
On 11/1/2024 2:57 AM, Chaoyong He wrote: > Add support for the following EEPROM function callbacks: > > .get_eeprom_len > Get the maximum size of the device EEPROM data. > > .get_eeprom > Get the device EEPROM data at a certain offset and length. > > .set_eeprom > Set the device EEPROM data at a

Re: [PATCH 0/4] net/tap: minor cleanups

2024-11-01 Thread Ferruh Yigit
nlmsg to tap_nlmsg > net/tap: do not use opaque parameter in convert > net/tap: do not use rte_malloc for process private data > For the series, Acked-by: Morten Brørup Acked-by: Ferruh Yigit Series applied to dpdk-next-net/main, thanks.

Re: [PATCH v9 6/9] net/zxdh: add zxdh get device backend infos

2024-11-01 Thread Ferruh Yigit
On 11/1/2024 6:21 AM, Junlong Wang wrote: > Add zxdh get device backend infos, > use msg chan to send msg get. > > Signed-off-by: Junlong Wang  > <...> > +uint16_t zxdh_vport_to_vfid(union zxdh_virport_num v) > +{ > +/* epid > 4 is local soft queue. return 1192 */ > +if (v.epid > 4) > +

Re: [PATCH v9 7/9] net/zxdh: add configure zxdh intr implementation

2024-11-01 Thread Ferruh Yigit
On 11/1/2024 6:21 AM, Junlong Wang wrote: > configure zxdh intr include risc,dtb. and release intr. > > Signed-off-by: Junlong Wang  > <...> > +static int32_t zxdh_configure_intr(struct rte_eth_dev *dev) > +{ > +struct zxdh_hw *hw = dev->data->dev_private; > +int32_t ret = 0; > + > +   

Re: [PATCH v9 1/9] net/zxdh: add zxdh ethdev pmd driver

2024-11-01 Thread Ferruh Yigit
On 11/1/2024 6:21 AM, Junlong Wang wrote: > Add basic zxdh ethdev init and register PCI probe functions > Update doc files. > > Signed-off-by: Junlong Wang  > --- >  MAINTAINERS|  6 ++ >  doc/guides/nics/features/zxdh.ini  |  9 +++ >  doc/guides/nics/index.rst  

Re: [PATCH v9 2/9] net/zxdh: add logging implementation

2024-11-01 Thread Ferruh Yigit
On 11/1/2024 6:21 AM, Junlong Wang wrote: > Add zxdh logging implementation. > > Signed-off-by: Junlong Wang  > <...> > +extern int zxdh_logtype_init; > +#define RTE_LOGTYPE_ZXDH_INIT zxdh_logtype_init > +#define PMD_INIT_LOG(level, ...) \ > +RTE_LOG_LINE_PREFIX(level, ZXDH_INIT, "offload_z

Re: [PATCH v9 3/9] net/zxdh: add zxdh device pci init implementation

2024-11-01 Thread Ferruh Yigit
On 11/1/2024 6:21 AM, Junlong Wang wrote: > Add device pci init implementation, > to obtain PCI capability and read configuration, etc. > > Signed-off-by: Junlong Wang  > --- >  drivers/net/zxdh/meson.build   |   1 + >  drivers/net/zxdh/zxdh_ethdev.c |  43 + >  drivers/net/zxdh/zxdh_ethdev.h |

Re: [PATCH v9 4/9] net/zxdh: add msg chan and msg hwlock init

2024-11-01 Thread Ferruh Yigit
On 11/1/2024 6:21 AM, Junlong Wang wrote: > Add msg channel and hwlock init implementation. > > Signed-off-by: Junlong Wang  > <...> > @@ -83,9 +84,23 @@ static int zxdh_eth_dev_init(struct rte_eth_dev *eth_dev) >  if (ret < 0) >  goto err_zxdh_init; >   > +ret = zxdh_msg_chan_i

Re: [PATCH v9 0/9] net/zxdh: introduce net zxdh driver

2024-11-01 Thread Ferruh Yigit
On 11/1/2024 6:21 AM, Junlong Wang wrote: > v9: >   - fix 'v8 3/9' patch use PCI bus API, > and common PCI constants according to David Marchand's comments. > > v8: >   - fix flexible arrays、Waddress-of-packed-member error. >   - all structs、enum、define ,etc use zxdh/ZXDH_ prefixed. >   - use 

Re: [PATCH v02] net/af_packet: add rollover and defrag options

2024-11-01 Thread Ferruh Yigit
On 10/31/2024 1:50 PM, Gur Stavi wrote: > net_af_packet PMD multi "queue" support relies on Linux FANOUT capability. > Linux FANOUT is a SW based load balancer that is similar to HW RSS which > is more common for DPDK PMDs. Instead of multiple HW descriptor queues, > AF PACKET uses multiple sockets

Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets

2024-11-01 Thread Ferruh Yigit
On 11/1/2024 2:56 AM, Stephen Hemminger wrote: > On Fri, 1 Nov 2024 01:22:47 + > Ferruh Yigit wrote: > >> Hi Jiawen, >> >> Above are generic checks, we may add this function to ethdev driver >> header (ethdev_driver.h) so that any PMD can use it, what

Re: [PATCH v7] testpmd: add hairpin map parameter

2024-10-31 Thread Ferruh Yigit
On 10/31/2024 3:51 PM, Stephen Hemminger wrote: > On Thu, 31 Oct 2024 06:58:17 +0200 > Gregory Etelson wrote: > >> Hairpin offloads packet forwarding between ports. >> Packet is expected on Rx port , Rx queue and is forwarded >> to Tx port Tx queue . >> >> Testpmd implements a static hairpin co

Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets

2024-10-31 Thread Ferruh Yigit
On 11/1/2024 1:52 AM, Jiawen Wu wrote: > On Fri, Nov 1, 2024 9:23 AM, Ferruh Yigit wrote: >> On 10/28/2024 2:31 AM, Jiawen Wu wrote: >>> Add checking of the Tx packet length to avoid TDM fatal error as far as >>> possible. Set the pkt_len=1518 for invalid packet in s

Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

2024-10-31 Thread Ferruh Yigit
On 11/1/2024 2:06 AM, Jiawen Wu wrote: >>> @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_error(void *param) >>> if (!txq->resetting) >>> continue; >>> >>> + txq->desc_error++; >>> >> >> Why error value is increased in this function, which resets the Tx queue?

Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

2024-10-31 Thread Ferruh Yigit
On 10/28/2024 2:31 AM, Jiawen Wu wrote: > Count the number of packets not sent due to Tx descriptor error. > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/txgbe_ethdev.c | 6 ++ > drivers/net/txgbe/txgbe_rxtx.c | 3 +++ > drivers/net/txgbe/txgbe_rxtx.h | 1 + > 3 files changed, 10

Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets

2024-10-31 Thread Ferruh Yigit
On 10/28/2024 2:31 AM, Jiawen Wu wrote: > Add checking of the Tx packet length to avoid TDM fatal error as far as > possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, > and drop it directly in featured Tx code path. > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/tx

Re: [PATCH v2] net/vmxnet3: support per-queue stats for fewer queues

2024-10-31 Thread Ferruh Yigit
On 10/25/2024 10:27 AM, Morten Brørup wrote: > Removed the requirement that the configured number of queues to provide > statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the > driver's max number of supported transmit queues (VMXNET3_MAX_TX_QUEUES). > > Also improved support for vi

Re: [PATCH] net/hns3: remove roh devices

2024-10-31 Thread Ferruh Yigit
On 10/31/2024 6:30 AM, Jie Hai wrote: > On 2024/10/26 14:38, Jie Hai wrote: >> From: Dengdui Huang >> >> The devices added in commit 3f1436d7006c ("net/hns3: support new device") >> is no longer available, so revert it. >> >> Fixes: 3f1436d7006c ("net/hns3: support new device") >> Cc: sta...@dpdk.

Re: [PATCH] net/hns3: remove roh devices

2024-10-30 Thread Ferruh Yigit
On 10/26/2024 7:38 AM, Jie Hai wrote: > From: Dengdui Huang > > The devices added in commit 3f1436d7006c ("net/hns3: support new device") > is no longer available, so revert it. > > Fixes: 3f1436d7006c ("net/hns3: support new device") > Cc: sta...@dpdk.org > > Signed-off-by: Dengdui Huang > H

Re: [PATCH] net/vmxnet3: Fix vmxnet3 NULL pointer deref after configuration failure

2024-10-30 Thread Ferruh Yigit
On 10/27/2024 8:43 AM, Morten Brørup wrote: >> From: Roger B Melton [mailto:rmel...@cisco.com] >> Sent: Saturday, 26 October 2024 16.34 >> >> Problem: >> >> If vxmnet3_dev_configure() fails, applications may call >> vmxnet3_dev_close(). If the failure occurs before the vmxnet3 >> hw->shared structu

Re: [PATCH v5 00/80] Provide flow filter and statistics support

2024-10-30 Thread Ferruh Yigit
On 10/30/2024 9:38 PM, Serhii Iliushyk wrote: > The list of updates provided by the patchset: > - FW version > - Speed capabilities > - Link status (Link update only) > - Unicast MAC filter > - Multicast MAC filter > - Promiscuous mode (Enable only. The device always run promiscuous mod

Re: [PATCH v4 05/86] net/ntnic: add minimal NT flow inline profile

2024-10-30 Thread Ferruh Yigit
On 10/30/2024 9:08 PM, Serhii Iliushyk wrote: >> On 30.10.2024, 03:56, "Ferruh Yigit" wrote: >> >> On 10/29/2024 4:41 PM, Serhii Iliushyk wrote: >>> The flow profile implements a all flow related operations >>> >> >> >> Can y

Re: [PATCH] net/vmxnet3: Fix vmxnet3 NULL pointer deref after configuration failure

2024-10-29 Thread Ferruh Yigit
On 10/26/2024 3:33 PM, Roger B Melton wrote: > Problem: > > If vxmnet3_dev_configure() fails, applications may call > vmxnet3_dev_close(). If the failure occurs before the vmxnet3 > hw->shared structure is allocated the close will lead to a segv. > > Root Cause: > > This crash is due to incorrec

Re: [PATCH 0/3] net/ena: ena release 2.11.0

2024-10-29 Thread Ferruh Yigit
On 10/23/2024 10:41 AM, shaib...@amazon.com wrote: > From: Shai Brandes > > Dear all, > Please find attached the patches for our upcoming release. > We welcome and appreciate any feedback you may have. > Thank you in advance. > Best regards, > Shai Brandes > > Shai Brandes (3): > net/ena: upgr

Re: [PATCH 3/3] net/ena: remove outdated devarg documentation

2024-10-29 Thread Ferruh Yigit
On 10/23/2024 10:41 AM, shaib...@amazon.com wrote: > From: Shai Brandes > > Removed obsolete devarg enforcing normal llq policy, > as its logic is now handled by the new `llq_policy` devarg. > > Signed-off-by: Shai Brandes > Fixes: d7918d19d25e ("net/ena: restructure LLQ policy user setting")

Re: [PATCH] net/hns3: fix inaccurate error log

2024-10-29 Thread Ferruh Yigit
On 10/23/2024 8:12 AM, Jie Hai wrote: > If register number obtained from firmware is different from the > register list driver hold, an error log occurs. The incorrect > use of `&&` makes this log inaccurate, change it to `&`. > > Signed-off-by: Jie Hai > Fixes: 99d3bd8b85d3 ("net/hns3: support

Re: [PATCH v4 00/86] Provide flow filter API and statistics

2024-10-29 Thread Ferruh Yigit
On 10/29/2024 4:41 PM, Serhii Iliushyk wrote: > The list of updates provided by the patchset: > - FW version > - Speed capabilities > - Link status (Link update only) > - Unicast MAC filter > - Multicast MAC filter > - Promiscuous mode (Enable only. The device always run promiscuous mod

Re: [PATCH v4 64/86] net/ntnic: update documentation

2024-10-29 Thread Ferruh Yigit
On 10/29/2024 4:42 PM, Serhii Iliushyk wrote: > From: Oleksandr Kolomeiets > > Update required documentation > > Signed-off-by: Oleksandr Kolomeiets > --- > doc/guides/nics/ntnic.rst | 30 ++ > doc/guides/rel_notes/release_24_11.rst | 2 ++ > 2 files chang

Re: [PATCH v4 01/86] net/ntnic: add API for configuration NT flow dev

2024-10-29 Thread Ferruh Yigit
On 10/29/2024 4:41 PM, Serhii Iliushyk wrote: > From: Danylo Vodopianov > > This API allows to enable of flow profile for NT SmartNIC > > Signed-off-by: Danylo Vodopianov > <...> > + for (i = 0; i < alloc_rx_queues; i++) { > +#ifdef SCATTER_GATHER > + eth_dev->rx_queue[i] = q

Re: [PATCH v4 05/86] net/ntnic: add minimal NT flow inline profile

2024-10-29 Thread Ferruh Yigit
On 10/29/2024 4:41 PM, Serhii Iliushyk wrote: > The flow profile implements a all flow related operations > Can you please give some more details about the profiles, and "inline profile" mentioned? > Signed-off-by: Serhii Iliushyk > --- > drivers/net/ntnic/include/flow_api.h | 15

Re: [PATCH v4 70/86] net/ntnic: add aging documentation

2024-10-29 Thread Ferruh Yigit
On 10/29/2024 4:42 PM, Serhii Iliushyk wrote: > From: Danylo Vodopianov > > ntnic.rst document was exntede with age feature specification. > ntnic.ini was extended with rte_flow action age support. > > Signed-off-by: Danylo Vodopianov > --- > doc/guides/nics/features/ntnic.ini | 1 + > do

Re: [PATCH v4 15/86] net/ntnic: add item IPv4

2024-10-29 Thread Ferruh Yigit
On 10/29/2024 4:41 PM, Serhii Iliushyk wrote: > Add possibility to use RTE_FLOW_ITEM_TYPE_IPV4 > > Signed-off-by: Serhii Iliushyk > --- > doc/guides/nics/features/ntnic.ini| 1 + > .../profile_inline/flow_api_profile_inline.c | 162 ++ > 2 files changed, 163 insert

Re: [PATCH 0/9] support multiple PF flower firmware

2024-10-29 Thread Ferruh Yigit
On 10/21/2024 7:32 AM, Chaoyong He wrote: > This patch series add support of the multiple PF flower firmware. > > Peng Zhang (9): > net/nfp: extract the function to allocate the PHY > net/nfp: extract the function to initialize the PF > net/nfp: extract the function to allocate PF > net/nf

Re: [PATCH v2 0/2] net/hns3: bugfix on register dump

2024-10-29 Thread Ferruh Yigit
On 10/22/2024 5:01 AM, Jie Hai wrote: > > Jie Hai (2): > net/hns3: fix variable type > net/hns3: fix pointer offset > Series applied to dpdk-next-net/main, thanks.

Re: [PATCH RESEND v7 0/5] app/testpmd: support multiple process attach and detach port

2024-10-29 Thread Ferruh Yigit
On 10/18/2024 3:48 AM, lihuisong (C) wrote: > Hi Ferruh, > > Thanks for your considering again. please see reply inline. > > 在 2024/10/18 9:04, Ferruh Yigit 写道: >> On 10/8/2024 3:32 AM, lihuisong (C) wrote: >>> Hi Thomas and Ferruh, >>> >>> We&#

Re: [PATCH v5 1/1] testpmd: add hairpin-map parameter

2024-10-29 Thread Ferruh Yigit
On 9/22/2024 7:50 AM, Gregory Etelson wrote: > Hairpin offloads packet forwarding between ports. > Packet is expected on Rx port , Rx queue and is forwarded > to Tx port Tx queue . > > Testpmd implements a static hairpin configuration scheme. > > The new parameter allows explicit selection of R

Re: [PATCH] net/netvsc: force TX VLAN offload on 801.2Q packet

2024-10-25 Thread Ferruh Yigit
On 10/19/2024 4:32 PM, Stephen Hemminger wrote: > On Fri, 18 Oct 2024 11:13:50 -0700 > lon...@linuxonhyperv.com wrote: > >> icrosoft.com> >> >> The VSP assumes the packet doesn't have VLAN tags. When VLAN tag is >> present in a TX packet, always strip it and use PPI to send VLAN info >> through VS

Re: [PATCH 0/4] net/hns3: support more flow pattern match

2024-10-25 Thread Ferruh Yigit
On 10/18/2024 7:19 AM, Jie Hai wrote: > 1. support general tunnel flow match > 2. support outer VLAN flow match > > Chengwen Feng (4): > net/hns3: restrict FDIR only support one tunnel header > net/hns3: support general tunnel flow match > net/hns3: add FDIR VLAN match mode param string >

Re: [PATCH] ethdev: fix link with C++

2024-10-25 Thread Ferruh Yigit
On 10/25/2024 8:18 AM, Andrew Rybchenko wrote: > On 10/24/24 23:25, David Marchand wrote: >> Some ethdev symbols were put out of extern "C" {} and became unavailable >> when linking with C++ objects. >> >> Fixes: 719834a6849e ("use C linkage where appropriate in headers") >> >> Reported-by: John Mi

Re: [PATCH v01] net/af_packet: don't specify protocol on socket create

2024-10-25 Thread Ferruh Yigit
On 10/26/2024 12:10 AM, Ferruh Yigit wrote: > On 10/17/2024 2:38 AM, Stephen Hemminger wrote: >> On Sun, 13 Oct 2024 16:59:47 +0300 >> Gur Stavi wrote: >> >>> When creating AF_PACKET socket with specified protocol it is >>> immediately implicitly bound to

Re: [PATCH] net/nfp: fix return value check problem

2024-10-25 Thread Ferruh Yigit
On 10/17/2024 8:36 AM, Chaoyong He wrote: > Fix one return value check problem found by the CI. > > Coverity issue: 445519 > Fixes: 08ea495d624b ("net/nfp: support loading firmware from flash") > Cc: sta...@dpdk.org > > Signed-off-by: Chaoyong He > Reviewed-by: Peng Zhang > Applied to dpdk-ne

Re: [PATCH 0/4] net/hns3: support more flow pattern match

2024-10-25 Thread Ferruh Yigit
Recheck-request: iol-unit-arm64-testing, iol-unit-amd64-testing

Re: [PATCH v01] net/af_packet: don't specify protocol on socket create

2024-10-25 Thread Ferruh Yigit
ces. > Thanks, this answers some of my questions in this thread, also I did some experiment and verified the same. I agree this change is more close the intention of the driver (driver is not to get packets from all interfaces), hence: Acked-by: Ferruh Yigit

Re: [PATCH 0/6] Adjust format and level of log

2024-10-19 Thread Ferruh Yigit
On 10/17/2024 7:15 AM, Chaoyong He wrote: > This patches unify the format of log, also adjust some log level. > > Zerun Fu (6): > net/nfp: modify the level of some logs > net/nfp: modify the level of speed update log > net/nfp: reformat the header of logs > net/nfp: reformat the abbreviati

Re: [PATCH RESEND v7 0/5] app/testpmd: support multiple process attach and detach port

2024-10-17 Thread Ferruh Yigit
On 10/8/2024 3:32 AM, lihuisong (C) wrote: > Hi Thomas and Ferruh, > > We've discussed it on and off a few times, and we've reached some > consensus. > They've been going through more than 2 years😅 > Can you have a look at this series again? > If we really don't need it, I will drop it from my ups

Re: [PATCH] net/gve: replace typedefs with macros in gve osdep

2024-10-17 Thread Ferruh Yigit
On 10/18/2024 12:42 AM, Joshua Washington wrote: > Currently, a number of integer types are typedef'd to their > corresponding upserspace or RTE values. This can be problematic if these > types are already defined somewhere else, as it would cause type > collisions. This patch changes the typedefs

Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues

2024-10-17 Thread Ferruh Yigit
On 10/17/2024 8:20 PM, lon...@linuxonhyperv.com wrote: > From: Alan Elder > > The previous code allowed the number of Tx queues to be set higher than > the number of Rx queues. If a packet was sent on a Tx queue with index >> = number Rx queues there was a segfault due to accessing beyond the en

Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues

2024-10-17 Thread Ferruh Yigit
On 10/18/2024 12:02 AM, Stephen Hemminger wrote: > On Thu, 17 Oct 2024 22:38:49 + > Long Li wrote: > >>> Subject: Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues >>> >>> On Thu, 17 Oct 2024 12:20:29 -0700 >>> lon...@linuxonhyperv.com wrote: >>> +static void +hn_rx_que

  1   2   3   4   5   6   7   8   9   10   >